GNU bug report logs - #30433
[PATCH] gnu: Add epipe.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30433 in the body.
You can then email your comments to 30433 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add epipe.
Date: Mon, 12 Feb 2018 10:48:51 +0300

* gnu/packages/emacs.scm (epipe): New public variable.
---
 gnu/packages/emacs.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 99e78d454..98d0ee1fb 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7064,3 +7064,48 @@ navigation with the grails mode.")
 @code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and
 @kbd{C-<} to jump to the next and previous slide.")
       (license license:gpl3+))))
+
+(define-public epipe
+  (let ((commit "c966d549d5416fb92ecf4bd4a0a5a8fc9239e3af")
+        (revision "1"))
+    (package
+      (name "epipe")
+      (version (string-append "0.0.1" "-" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/cute-jumper/epipe")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "0lkisi1s7sn12nx8zh58qmsxwnk1rjwryj18wcbr148xqz3swg57"))))
+      (build-system trivial-build-system)
+      (inputs
+       `(("bash" ,bash)
+         ("perl" ,perl)))
+      (arguments
+       '(#:modules ((guix build utils))
+         #:builder
+         (begin
+           (use-modules (guix build utils))
+           ;; Copy source
+           (copy-recursively (assoc-ref %build-inputs "source") ".")
+           ;; Patch shebangs
+           (substitute* "epipe"
+             (("/usr/bin/env bash")
+              (string-append (assoc-ref %build-inputs "bash") "/bin/bash")))
+           (substitute* "epipe.pl"
+             (("/usr/bin/perl")
+              (string-append (assoc-ref %build-inputs "perl") "/bin/perl")))
+           ;; Installation
+           (for-each (lambda (file)
+                       (install-file file (string-append %output "/bin")))
+                     '("epipe" "epipe.pl"))
+           #t)))
+      (home-page "https://github.com/cute-jumper/epipe")
+      (synopsis "Pipe to the @code{emacsclient}")
+      (description "@code{epipe} provides an utility to use your editor in
+the pipeline, featuring the support for running @code{emacsclient}.")
+      (license license:gpl3+))))
-- 
2.15.1

Message #8 received at 30433 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 30433 <at> debbugs.gnu.org
Subject: Re: [bug#30433] [PATCH] gnu: Add epipe.
Date: Mon, 12 Feb 2018 14:38:48 -0500

[Message part 1 (text/plain, inline)]

On Mon, Feb 12, 2018 at 10:48:51AM +0300, Oleg Pykhalov wrote:
> * gnu/packages/emacs.scm (epipe): New public variable.

Thanks!

> +(define-public epipe
> +  (let ((commit "c966d549d5416fb92ecf4bd4a0a5a8fc9239e3af")
> +        (revision "1"))
> +    (package
> +      (name "epipe")
> +      (version (string-append "0.0.1" "-" revision "."
> +                              (string-take commit 7)))

This commit corresponds to the upstream tag "0.1.0", so you can omit the
commit and revision variables, and just set the version to "0.1.0"...

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/cute-jumper/epipe")
> +                      (commit commit)))

... and here use (commit version).

> +      (arguments
> +       '(#:modules ((guix build utils))
> +         #:builder
> +         (begin
> +           (use-modules (guix build utils))
> +           ;; Copy source
> +           (copy-recursively (assoc-ref %build-inputs "source") ".")
> +           ;; Patch shebangs
> +           (substitute* "epipe"
> +             (("/usr/bin/env bash")
> +              (string-append (assoc-ref %build-inputs "bash") "/bin/bash")))
> +           (substitute* "epipe.pl"
> +             (("/usr/bin/perl")
> +              (string-append (assoc-ref %build-inputs "perl") "/bin/perl")))
> +           ;; Installation
> +           (for-each (lambda (file)
> +                       (install-file file (string-append %output "/bin")))
> +                     '("epipe" "epipe.pl"))
> +           #t)))

I think you could use the patch-shebang procedure from (guix build
utils), as in the package for woof.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30433 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 30433 <at> debbugs.gnu.org
Subject: Re: [bug#30433] [PATCH] gnu: Add epipe.
Date: Wed, 14 Feb 2018 16:14:15 +0300

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Mon, Feb 12, 2018 at 10:48:51AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/emacs.scm (epipe): New public variable.
>
> Thanks!

Thank you for review.

>> +(define-public epipe
>> +  (let ((commit "c966d549d5416fb92ecf4bd4a0a5a8fc9239e3af")
>> +        (revision "1"))
>> +    (package
>> +      (name "epipe")
>> +      (version (string-append "0.0.1" "-" revision "."
>> +                              (string-take commit 7)))
>
> This commit corresponds to the upstream tag "0.1.0", so you can omit the
> commit and revision variables, and just set the version to "0.1.0"...

Maybe it's better to get a source via url-fetch from GitHub archive
tarball?

>> +      (source (origin
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url "https://github.com/cute-jumper/epipe")
>> +                      (commit commit)))
>
> ... and here use (commit version).

OK.

>> +      (arguments
>> +       '(#:modules ((guix build utils))
>> +         #:builder
>> +         (begin
>> +           (use-modules (guix build utils))
>> +           ;; Copy source
>> +           (copy-recursively (assoc-ref %build-inputs "source") ".")
>> +           ;; Patch shebangs
>> +           (substitute* "epipe"
>> +             (("/usr/bin/env bash")
>> +              (string-append (assoc-ref %build-inputs "bash") "/bin/bash")))
>> +           (substitute* "epipe.pl"
>> +             (("/usr/bin/perl")
>> +              (string-append (assoc-ref %build-inputs "perl") "/bin/perl")))
>> +           ;; Installation
>> +           (for-each (lambda (file)
>> +                       (install-file file (string-append %output "/bin")))
>> +                     '("epipe" "epipe.pl"))
>> +           #t)))
>
> I think you could use the patch-shebang procedure from (guix build
> utils), as in the package for woof.

As I see only for Perl, because folling does nothing:
--8<---------------cut here---------------start------------->8---
(patch-shebang "epipe"
  (list (string-append (assoc-ref %build-inputs "bash")
                       "/bin")))
--8<---------------cut here---------------end--------------->8---

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 30433 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 30433 <at> debbugs.gnu.org
Subject: Re: [bug#30433] [PATCH] gnu: Add epipe.
Date: Wed, 14 Feb 2018 15:51:44 -0500

[Message part 1 (text/plain, inline)]

On Wed, Feb 14, 2018 at 04:14:15PM +0300, Oleg Pykhalov wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> > This commit corresponds to the upstream tag "0.1.0", so you can omit the
> > commit and revision variables, and just set the version to "0.1.0"...
> 
> Maybe it's better to get a source via url-fetch from GitHub archive
> tarball?

Yeah, if the result is the same I think it's better to use url-fetch.

> > I think you could use the patch-shebang procedure from (guix build
> > utils), as in the package for woof.
> 
> As I see only for Perl, because folling does nothing:
> --8<---------------cut here---------------start------------->8---
> (patch-shebang "epipe"
>   (list (string-append (assoc-ref %build-inputs "bash")
>                        "/bin")))
> --8<---------------cut here---------------end--------------->8---

Huh, weird! Well, I think that whatever works should be fine.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 30433 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 30433-done <at> debbugs.gnu.org, 30433 <at> debbugs.gnu.org
Subject: Re: [bug#30433] [PATCH] gnu: Add epipe.
Date: Thu, 15 Feb 2018 20:47:32 +0300

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Feb 14, 2018 at 04:14:15PM +0300, Oleg Pykhalov wrote:
>> Leo Famulari <leo <at> famulari.name> writes:
>> > This commit corresponds to the upstream tag "0.1.0", so you can omit the
>> > commit and revision variables, and just set the version to "0.1.0"...
>> 
>> Maybe it's better to get a source via url-fetch from GitHub archive
>> tarball?
>
> Yeah, if the result is the same I think it's better to use url-fetch.

OK.

>> > I think you could use the patch-shebang procedure from (guix build
>> > utils), as in the package for woof.
>> 
>> As I see only for Perl, because folling does nothing:
>> --8<---------------cut here---------------start------------->8---
>> (patch-shebang "epipe"
>>   (list (string-append (assoc-ref %build-inputs "bash")
>>                        "/bin")))
>> --8<---------------cut here---------------end--------------->8---
>
> Huh, weird! Well, I think that whatever works should be fine.

Pushed as 5b2382929959db9d883982329ec8fdf4103a9351

I'll close the bug report.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.