GNU bug report logs - #30423
2018-01-25; [patch] flymake support

Previous Next

Full log

Message #25 received at 30423 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 30423 <at> debbugs.gnu.org, Mosè Giordano <mose <at> gnu.org>
Subject: Re: bug#30423: separate flymake into latex-flymake.el
Date: Sun, 18 Feb 2018 21:14:58 +0100

Alex Branham <alex.branham <at> gmail.com> writes:

> Here's a different version of the patch I sent with flymake support in
> its own file. I also removed the lexical-binding from latex.el.

Hi Alex,

many thanks for your patch.  Some comments:

> +;;; latex-flymake.el --- Flymake integration  -*- lexical-binding: t; -*-

Could you please add the standard header with Copyright etc. here?

> +;;; Commentary:
> +;; This file provides flymake integration for latex documents using
> +;; "chktex" as a backend.  You must be running Emacs 26 or newer.
> +;; Enable it by adding the following to your init file:
> +
> +;; (add-hook 'LaTeX-mode-hook flymake-mode)
                               _/^\_
There is a quote missing here.

Is there a reason why you didn't add this file to Makefile.in in order
to get byte-compiled?  And could you please add something to the manual?

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.