GNU bug report logs - #30417
[PATCH] java-plexus and java-modello

Previous Next

Full log

View this message in rfc822 format

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 30417 <at> debbugs.gnu.org
Subject: [bug#30417] [PATCH 04/11] gnu: Add java-plexus-compiler-javac.
Date: Wed, 14 Feb 2018 20:23:06 +0100

On Sun, 11 Feb 2018 00:04:31 +0100
Julien Lepiller <julien <at> lepiller.eu> wrote:

> gnu/packages/java.scm (java-plexus-compiler-javac): New variable.
> ---
>  gnu/packages/java.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 55233b7ba..29439d667 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2737,6 +2737,26 @@ and decryption.")
>  compilers.")
>      (license license:asl2.0)))
>  
> +(define-public java-plexus-compiler-javac
> +  (package
> +    (inherit java-plexus-compiler-api)
> +    (name "java-plexus-compiler-javac")

LGTM, except of this comment:

This one also has some source files unde license:expat. As the package
inherits from java-plexus-compiler-api, and if you add the missing
license there, everything should be fine automatically.


Björn

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.