From unknown Sat Sep 13 05:21:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30417 <30417@debbugs.gnu.org> To: bug#30417 <30417@debbugs.gnu.org> Subject: Status: [PATCH] java-plexus and java-modello Reply-To: bug#30417 <30417@debbugs.gnu.org> Date: Sat, 13 Sep 2025 12:21:48 +0000 retitle 30417 [PATCH] java-plexus and java-modello reassign 30417 guix-patches submitter 30417 Julien Lepiller severity 30417 normal tag 30417 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 17:48:37 2018 Received: (at submit) by debbugs.gnu.org; 10 Feb 2018 22:48:37 +0000 Received: from localhost ([127.0.0.1]:37342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekdwj-0008BX-C0 for submit@debbugs.gnu.org; Sat, 10 Feb 2018 17:48:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekdwh-0008BK-KH for submit@debbugs.gnu.org; Sat, 10 Feb 2018 17:48:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekdwb-0006BZ-P4 for submit@debbugs.gnu.org; Sat, 10 Feb 2018 17:48:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36953) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ekdwb-0006BP-LC for submit@debbugs.gnu.org; Sat, 10 Feb 2018 17:48:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekdwa-0007QO-Ot for guix-patches@gnu.org; Sat, 10 Feb 2018 17:48:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekdwX-000683-8g for guix-patches@gnu.org; Sat, 10 Feb 2018 17:48:28 -0500 Received: from lepiller.eu ([89.234.186.109]:41980) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ekdwW-00066a-UF for guix-patches@gnu.org; Sat, 10 Feb 2018 17:48:25 -0500 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 9a092b66 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Sat, 10 Feb 2018 22:49:26 +0000 (UTC) Date: Sat, 10 Feb 2018 23:48:11 +0100 From: Julien Lepiller To: guix-patches@gnu.org Subject: [PATCH] java-plexus and java-modello Message-ID: <20180210234811.40ddec07@lepiller.eu> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, this patch series adds more java packages required by maven. We're almost there: only ~50 packages (including maven) left after these ones. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:52 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:52 +0000 Received: from localhost ([127.0.0.1]:37353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCS-00006s-42 for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:52 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCQ-00006e-6k for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:50 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 9e5e073e (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:55 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 01/11] gnu: Add java-plexus-component-annotations. Date: Sun, 11 Feb 2018 00:04:28 +0100 Message-Id: <20180210230438.26794-1-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-plexus-component-annotations): New variable. --- gnu/packages/java.scm | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index e714a031c..b7f3fd54e 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2662,6 +2662,17 @@ archives (jar).") `(("archiver" ,java-plexus-archiver) ("hamcrest" ,java-hamcrest-core))))) +(define-public java-plexus-component-annotations + (package + (inherit java-plexus-container-default) + (name "java-plexus-component-annotations") + (arguments + `(#:jar-name "plexus-component-annotations.jar" + #:source-dir "plexus-component-annotations/src/main/java" + #:tests? #f)); no tests + (inputs '()) + (native-inputs '()))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:54 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:54 +0000 Received: from localhost ([127.0.0.1]:37358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCU-00007H-Bc for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:54 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCR-00006e-99 for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:51 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id f65321ad (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:55 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 02/11] gnu: Add java-plexus-cipher. Date: Sun, 11 Feb 2018 00:04:29 +0100 Message-Id: <20180210230438.26794-2-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-plexus-cipher): New variable. --- gnu/packages/java.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index b7f3fd54e..8b51f7122 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2673,6 +2673,42 @@ archives (jar).") (inputs '()) (native-inputs '()))) +(define-public java-plexus-cipher + (package + (name "java-plexus-cipher") + (version "1.7") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/codehaus-plexus/plexus-cipher" + "/archive/plexus-cipher-" version ".tar.gz")) + (sha256 + (base32 + "1j3r8xzlxlk340snkjp6lk2ilkxlkn8qavsfiq01f43xmvv8ymk3")))) + (build-system ant-build-system) + (arguments + `(#:jar-name "plexus-cipher.jar" + #:source-dir "src/main/java" + #:jdk ,icedtea-8 + #:tests? #f; FIXME: requires sisu-inject-bean + #:phases + (modify-phases %standard-phases + (add-before 'build 'copy-resources + (lambda _ + (copy-recursively "src/main/resources" "build/classes") + (mkdir-p "build/classes/META-INF/sisu") + (with-output-to-file "build/classes/META-INF/sisu/javax.inject.Named" + (lambda _ + (display "org.sonatype.plexus.components.cipher.DefaultPlexusCipher\n"))) + #t))))) + (inputs + `(("java-cdi-api" ,java-cdi-api) + ("java-javax-inject" ,java-javax-inject))) + (home-page "http://codehaus-plexus.github.io/plexus-cipher/") + (synopsis "Encryption/decryption Component") + (description "Plexus-cipher contains a component to deal with encryption +and decryption.") + (license license:asl2.0))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:55 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:55 +0000 Received: from localhost ([127.0.0.1]:37361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCU-00007J-K1 for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:55 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCS-00006e-2t for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:52 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id f24fd9a7 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:55 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 03/11] gnu: Add java-plexus-compiler-api. Date: Sun, 11 Feb 2018 00:04:30 +0100 Message-Id: <20180210230438.26794-3-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-plexus-compiler-api): New variable. --- gnu/packages/java.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 8b51f7122..55233b7ba 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2709,6 +2709,34 @@ archives (jar).") and decryption.") (license license:asl2.0))) +(define-public java-plexus-compiler-api + (package + (name "java-plexus-compiler-api") + (version "2.8.2") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/codehaus-plexus/plexus-compiler" + "/archive/plexus-compiler-" version ".tar.gz")) + (sha256 + (base32 + "0g3x26pymcdnfnwv2a1i57pd5s26f5zqfi1rdy98z1bn01klx25k")))) + (build-system ant-build-system) + (arguments + `(#:jar-name "plexus-compiler-api.jar" + #:source-dir "plexus-compiler-api/src/main/java" + #:jdk ,icedtea-8 + #:test-dir "plexus-compiler-api/src/test")) + (inputs + `(("java-plexus-container-default" ,java-plexus-container-default) + ("java-plexus-util" ,java-plexus-utils))) + (native-inputs + `(("java-junit" ,java-junit))) + (home-page "https://github.com/codehaus-plexus/plexus-compiler") + (synopsis "Plexus Compilers component's API to manipulate compilers") + (description "This package contains the API used by components to manipulate +compilers.") + (license license:asl2.0))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:55 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:55 +0000 Received: from localhost ([127.0.0.1]:37364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCV-00007X-3l for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:55 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCS-00006e-TA for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:53 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id f0e10bdd (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:55 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 04/11] gnu: Add java-plexus-compiler-javac. Date: Sun, 11 Feb 2018 00:04:31 +0100 Message-Id: <20180210230438.26794-4-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) gnu/packages/java.scm (java-plexus-compiler-javac): New variable. --- gnu/packages/java.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 55233b7ba..29439d667 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2737,6 +2737,26 @@ and decryption.") compilers.") (license license:asl2.0))) +(define-public java-plexus-compiler-javac + (package + (inherit java-plexus-compiler-api) + (name "java-plexus-compiler-javac") + (arguments + `(#:jar-name "plexus-compiler-javac.jar" + #:source-dir "plexus-compilers/plexus-compiler-javac/src/main/java" + #:jdk ,icedtea-8 + #:tests? #f; depends on compiler-test -> maven-core -> ... -> this package. + #:test-dir "plexus-compilers/plexus-compiler-javac/src/test")) + (inputs + `(("java-plexus-compiler-api" ,java-plexus-compiler-api) + ("java-plexus-utils" ,java-plexus-utils) + ("java-plexus-container-default" ,java-plexus-container-default))) + (native-inputs + `(("java-junit" ,java-junit))) + (synopsis "Javac Compiler support for Plexus Compiler component") + (description "This package contains the Javac Compiler support for Plexus +Compiler component."))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:58 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:58 +0000 Received: from localhost ([127.0.0.1]:37370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCX-00008A-PM for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:57 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCT-00006e-HX for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:53 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id b74ae5cf (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:55 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 05/11] gnu: Add java-sisu-build-api. Date: Sun, 11 Feb 2018 00:04:32 +0100 Message-Id: <20180210230438.26794-5-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-sisu-build-api): New variable. --- gnu/packages/java.scm | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 29439d667..af9acd71f 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2757,6 +2757,60 @@ compilers.") (description "This package contains the Javac Compiler support for Plexus Compiler component."))) +(define-public java-sisu-build-api + (package + (name "java-sisu-build-api") + (version "0.0.7") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/sonatype/sisu-build-api/" + "archive/plexus-build-api-" version ".tar.gz")) + (sha256 + (base32 + "1c3rrpma3x634xp2rm2p5iskfhzdyc7qfbhjzr70agrl1jwghgy2")))) + (build-system ant-build-system) + (arguments + `(#:jar-name "sisu-build-api.jar" + #:source-dir "src/main/java" + #:jdk ,icedtea-8 + #:tests? #f; FIXME: how to run the tests? + #:phases + (modify-phases %standard-phases + (add-before 'build 'copy-resurces + (lambda _ + (mkdir-p "build/classes/org/sonatype/plexus/build/incremental") + (copy-file "src/main/resources/org/sonatype/plexus/build/incremental/version.properties" + "build/classes/org/sonatype/plexus/build/incremental/version.properties") + #t)) + (add-before 'build 'generate-plexus-compontent + (lambda _ + (mkdir-p "build/classes/META-INF/plexus") + ;; This file is required for plexus to inject this package. + ;; FIXME: how is it generated? + (with-output-to-file "build/classes/META-INF/plexus/components.xml" + (lambda _ + (display + "\n + \n + \n + org.sonatype.plexus.build.incremental.BuildContext\n + default\n + org.sonatype.plexus.build.incremental.DefaultBuildContext\n + Filesystem based non-incremental build context implementation which behaves as if all files\n +were just created.\n + \n + \n +\n")))))))) + (inputs + `(("java-plexus-utils" ,java-plexus-utils) + ("java-plexus-container-default" ,java-plexus-container-default))) + (home-page "https://github.com/sonatype/sisu-build-api/") + (synopsis "Base build API for maven") + (description "This package contains the base build API for maven and +a default implementation of it. This API is about scanning files in a +project and determining what files need to be rebuilt.") + (license license:asl2.0))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:58 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:58 +0000 Received: from localhost ([127.0.0.1]:37372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCY-00008D-2u for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:58 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCU-00006e-Ad for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:54 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 611a5f8f (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:56 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 06/11] gnu: Add java-modello-core. Date: Sun, 11 Feb 2018 00:04:33 +0100 Message-Id: <20180210230438.26794-6-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-modello-core): New variable. --- gnu/packages/java.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index af9acd71f..d75960831 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2811,6 +2811,56 @@ a default implementation of it. This API is about scanning files in a project and determining what files need to be rebuilt.") (license license:asl2.0))) +(define-public java-modello-core + (package + (name "java-modello-core") + (version "1.9.1") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/codehaus-plexus/modello" + "/archive/modello-" version ".tar.gz")) + (sha256 + (base32 + "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh")))) + (build-system ant-build-system) + (arguments + `(#:jar-name "modello-core.jar" + #:source-dir "modello-core/src/main/java" + #:test-dir "modello-core/src/test" + #:main-class "org.codehaus.modello.ModelloCli" + #:jdk ,icedtea-8 + #:phases + (modify-phases %standard-phases + (add-before 'build 'copy-resources + (lambda _ + (mkdir-p "build/classes/META-INF/plexus") + (copy-file "modello-core/src/main/resources/META-INF/plexus/components.xml" + "build/classes/META-INF/plexus/components.xml") + #t)) + (add-before 'check 'fix-tests + (lambda _ + (substitute* '("modello-core/src/test/java/org/codehaus/modello/core/DefaultModelloCoreTest.java" + "modello-core/src/test/java/org/codehaus/modello/core/io/ModelReaderTest.java") + (("src/test") "modello-core/src/test"))))))) + (inputs + `(("java-plexus-utils" ,java-plexus-utils) + ("java-plexus-container-default-bootstrap" ,java-plexus-container-default-bootstrap) + ("java-sisu-build-api" ,java-sisu-build-api))) + (native-inputs + `(("java-junit" ,java-junit) + ("java-plexus-classworlds" ,java-plexus-classworlds) + ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) + ("java-guava" ,java-guava))) + (home-page "http://codehaus-plexus.github.io/modello/") + (synopsis "Framework for code generation from a simple model") + (description "Modello is a framework for code generation from a simple model. + +Modello generates code from a simple model format: based on a plugin +architecture, various types of code and descriptors can be generated from the +single model, including Java POJOs, XML/JSON/YAML marshallers/unmarshallers, +XSD and documentation.") + (license license:asl2.0))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:58 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:58 +0000 Received: from localhost ([127.0.0.1]:37374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCY-00008K-Dp for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:58 -0500 Received: from lepiller.eu ([89.234.186.109]:49608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCU-00007G-JD for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:55 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 39d6d3d5 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:56 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 07/11] gnu: Add java-modello-plugins-java. Date: Sun, 11 Feb 2018 00:04:34 +0100 Message-Id: <20180210230438.26794-7-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-modello-plugins-java): New variable. --- gnu/packages/java.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index d75960831..76a586a98 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2861,6 +2861,28 @@ single model, including Java POJOs, XML/JSON/YAML marshallers/unmarshallers, XSD and documentation.") (license license:asl2.0))) +(define-public java-modello-plugins-java + (package + (inherit java-modello-core) + (name "java-modello-plugins-java") + (arguments + `(#:jar-name "modello-plugins-java.jar" + #:source-dir "modello-plugins/modello-plugin-java/src/main/java" + #:test-dir "modello-plugins/modello-plugin-java/src/test" + #:jdk ,icedtea-8 + #:tests? #f; requires maven-model, which depends on this package + #:phases + (modify-phases %standard-phases + (add-before 'build 'copy-resources + (lambda _ + (mkdir-p "build/classes") + (copy-recursively "modello-plugins/modello-plugin-java/src/main/resources" + "build/classes") + #t))))) + (inputs + `(("java-modello-core" ,java-modello-core) + ,@(package-inputs java-modello-core))))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:58 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:58 +0000 Received: from localhost ([127.0.0.1]:37376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCY-00008S-K3 for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:58 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCV-00006e-7r for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:55 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 654d5a2c (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:56 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 08/11] gnu: Add java-modello-plugins-xml. Date: Sun, 11 Feb 2018 00:04:35 +0100 Message-Id: <20180210230438.26794-8-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-modello-plugins-xml): New variable. --- gnu/packages/java.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 76a586a98..1f29e3a29 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2883,6 +2883,32 @@ XSD and documentation.") `(("java-modello-core" ,java-modello-core) ,@(package-inputs java-modello-core))))) +(define-public java-modello-plugins-xml + (package + (inherit java-modello-core) + (name "java-modello-plugins-xml") + (arguments + `(#:jar-name "modello-plugins-xml.jar" + #:source-dir "modello-plugins/modello-plugin-xml/src/main/java" + #:test-dir "modello-plugins/modello-plugin-xml/src/test" + #:jdk ,icedtea-8 + #:phases + (modify-phases %standard-phases + (add-before 'build 'copy-resources + (lambda _ + (mkdir-p "build/classes") + (copy-recursively "modello-plugins/modello-plugin-xml/src/main/resources" + "build/classes") + #t)) + (add-before 'check 'fix-paths + (lambda _ + (substitute* "modello-plugins/modello-plugin-xml/src/test/java/org/codehaus/modello/plugins/xml/XmlModelloPluginTest.java" + (("src/test") "modello-plugins/modello-plugin-xml/src/test"))))))) + (inputs + `(("java-modello-core" ,java-modello-core) + ("java-modello-plugins-java" ,java-modello-plugins-java) + ,@(package-inputs java-modello-core))))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:59 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:59 +0000 Received: from localhost ([127.0.0.1]:37378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCY-00008Y-R5 for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:59 -0500 Received: from lepiller.eu ([89.234.186.109]:49608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCV-00007G-IP for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:55 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id ecbec5bf (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:56 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 09/11] gnu: Add java-modello-test. Date: Sun, 11 Feb 2018 00:04:36 +0100 Message-Id: <20180210230438.26794-9-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) gnu/packages/java.scm (java-modello-test): New variable. --- gnu/packages/java.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 1f29e3a29..18ba46c5c 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2909,6 +2909,21 @@ XSD and documentation.") ("java-modello-plugins-java" ,java-modello-plugins-java) ,@(package-inputs java-modello-core))))) +(define-public java-modello-test + (package + (inherit java-modello-core) + (name "java-modello-test") + (arguments + `(#:jar-name "modello-test.jar" + #:source-dir "modello-test/src/main/java" + #:tests? #f; no tests + #:jdk ,icedtea-8)) + (inputs + `(("java-plexus-utils" ,java-plexus-utils) + ("java-plexus-compiler-api" ,java-plexus-compiler-api) + ("java-plexus-compiler-javac" ,java-plexus-compiler-javac) + ("java-plexus-container-default" ,java-plexus-container-default))))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:59 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:59 +0000 Received: from localhost ([127.0.0.1]:37380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCZ-00008f-20 for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:59 -0500 Received: from lepiller.eu ([89.234.186.109]:49606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCW-00006e-0A for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:56 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id da6a4730 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:56 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 10/11] gnu: Add java-modello-plugins-xpp3. Date: Sun, 11 Feb 2018 00:04:37 +0100 Message-Id: <20180210230438.26794-10-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) gnu/packages/java.scm (java-modello-plugins-xpp3): New variable. --- gnu/packages/java.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 18ba46c5c..758665df9 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2924,6 +2924,34 @@ XSD and documentation.") ("java-plexus-compiler-javac" ,java-plexus-compiler-javac) ("java-plexus-container-default" ,java-plexus-container-default))))) +(define-public java-modello-plugins-xpp3 + (package + (inherit java-modello-core) + (name "java-modello-plugins-xpp3") + (arguments + `(#:jar-name "modello-plugins-xpp3.jar" + #:source-dir "modello-plugins/modello-plugin-xpp3/src/main/java" + #:test-dir "modello-plugins/modello-plugin-xpp3/src/test" + #:tests? #f; I can find some of its dependencies, for instance org.codehaus.modello.test.features.io.xpp3.ModelloFeaturesTestXpp3Reader + #:jdk ,icedtea-8 + #:phases + (modify-phases %standard-phases + (add-before 'build 'copy-resources + (lambda _ + (mkdir-p "build/classes") + (copy-recursively "modello-plugins/modello-plugin-xpp3/src/main/resources" + "build/classes") + #t))))) + (inputs + `(("java-modello-core" ,java-modello-core) + ("java-modello-plugins-java" ,java-modello-plugins-java) + ("java-modello-plugins-xml" ,java-modello-plugins-xml) + ,@(package-inputs java-modello-core))) + (native-inputs + `(("java-xmlunit" ,java-xmlunit) + ("java-modello-test" ,java-modello-test) + ,@(package-native-inputs java-modello-core))))) + (define-public java-asm (package (name "java-asm") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 18:04:59 2018 Received: (at 30417) by debbugs.gnu.org; 10 Feb 2018 23:04:59 +0000 Received: from localhost ([127.0.0.1]:37382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCZ-00008n-8e for submit@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:59 -0500 Received: from lepiller.eu ([89.234.186.109]:49608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekeCW-00007G-TP for 30417@debbugs.gnu.org; Sat, 10 Feb 2018 18:04:57 -0500 Received: from localhost.localdomain (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 3ef13da5 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30417@debbugs.gnu.org>; Sat, 10 Feb 2018 23:05:57 +0000 (UTC) From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: [PATCH 11/11] gnu: Add java-plexus-sec-dispatcher. Date: Sun, 11 Feb 2018 00:04:38 +0100 Message-Id: <20180210230438.26794-11-julien@lepiller.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-plexus-sec-dispatcher): New variable. --- gnu/packages/java.scm | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 88 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 758665df9..bd3fc7e70 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2757,6 +2757,94 @@ compilers.") (description "This package contains the Javac Compiler support for Plexus Compiler component."))) +(define-public java-plexus-sec-dispatcher + (package + (name "java-plexus-sec-dispatcher") + (version "1.4") ;; Newest release listed at the Maven Central Repository. + (source (origin + ;; This project doesn't tag releases or publish tarballs, so we take + ;; the "prepare release plexus-sec-dispatcher-1.4" git commit. + (method url-fetch) + (uri (string-append "https://github.com/sonatype/plexus-sec-dispatcher/" + "archive/7db8f88048.tar.gz")) + (sha256 + (base32 + "1smfrk4n7xbrsxpxcp2j4i0j8q86j73w0w6xg7qz83dp6dagdjgp")) + (file-name (string-append name "-" version ".tar.gz")))) + (arguments + `(#:jar-name "plexus-sec-dispatcher.jar" + #:source-dir "src/main/java" + #:jdk ,icedtea-8 + #:phases + (modify-phases %standard-phases + (add-before 'build 'generate-models + (lambda* (#:key inputs #:allow-other-keys) + (define (modello-single-mode file version mode) + (zero? (system* "java" + "org.codehaus.modello.ModelloCli" + file mode "src/main/java" version + "false" "true"))) + (let ((file "src/main/mdo/settings-security.mdo")) + (and + (modello-single-mode file "1.0.0" "java") + (modello-single-mode file "1.0.0" "xpp3-reader") + (modello-single-mode file "1.0.0" "xpp3-writer"))))) + (add-before 'build 'generate-components.xml + (lambda _ + (mkdir-p "build/classes/META-INF/plexus") + (with-output-to-file "build/classes/META-INF/plexus/components.xml" + (lambda _ + (display + "\n + \n + \n + org.sonatype.plexus.components.sec.dispatcher.SecDispatcher\n + default\n + org.sonatype.plexus.components.sec.dispatcher.DefaultSecDispatcher\n + \n + \n + \n + org.sonatype.plexus.components.cipher.PlexusCipher\n + _cipher\n + \n + \n + org.sonatype.plexus.components.sec.dispatcher.PasswordDecryptor\n + _decryptors\n + \n + \n + \n + <_configuration-file>~/.settings-security.xml\n + \n + \n + \n +\n"))))) + (add-before 'check 'fix-paths + (lambda _ + (copy-recursively "src/test/resources" "target")))))) + (inputs + `(("java-plexus-cipher" ,java-plexus-cipher))) + (native-inputs + `(("java-modello-core" ,java-modello-core) + ;; for modello: + ("java-plexus-container-default" ,java-plexus-container-default) + ("java-plexus-classworlds" ,java-plexus-classworlds) + ("java-plexus-utils" ,java-plexus-utils) + ("java-guava" ,java-guava) + ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) + ("java-sisu-build-api" ,java-sisu-build-api) + ;; modello plugins: + ("java-modellop-plugins-java" ,java-modello-plugins-java) + ("java-modellop-plugins-xml" ,java-modello-plugins-xml) + ("java-modellop-plugins-xpp3" ,java-modello-plugins-xpp3) + ;; for tests + ("java-junit" ,java-junit))) + (build-system ant-build-system) + (home-page "http://spice.sonatype.org/plexus-sec-dispatcher/") + (synopsis "Plexus Security Dispatcher Component") + (description "This package is the Plexus Security Dispatcher Component. +This component descrypts a string passed to it") + (license license:asl2.0))) + (define-public java-sisu-build-api (package (name "java-sisu-build-api") -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:36:06 2018 Received: (at 30417) by debbugs.gnu.org; 11 Feb 2018 23:36:06 +0000 Received: from localhost ([127.0.0.1]:38730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1el1AD-0004Ij-P9 for submit@debbugs.gnu.org; Sun, 11 Feb 2018 18:36:05 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44052 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1el1AB-0004Ia-JF for 30417@debbugs.gnu.org; Sun, 11 Feb 2018 18:36:04 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 26F4A40709; Mon, 12 Feb 2018 00:36:02 +0100 (CET) Date: Mon, 12 Feb 2018 00:36:01 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 01/11] gnu: Add java-plexus-component-annotations. Message-ID: <20180212003601.494e2979@alma-ubu> In-Reply-To: <20180210230438.26794-1-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-1-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:28 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-plexus-component-annotations): New > variable. > --- > gnu/packages/java.scm | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index e714a031c..b7f3fd54e 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2662,6 +2662,17 @@ archives (jar).") > `(("archiver" ,java-plexus-archiver) > ("hamcrest" ,java-hamcrest-core))))) > =20 > +(define-public java-plexus-component-annotations > + (package > + (inherit java-plexus-container-default) > + (name "java-plexus-component-annotations") > + (arguments > + `(#:jar-name "plexus-component-annotations.jar" > + #:source-dir "plexus-component-annotations/src/main/java" > + #:tests? #f)); no tests > + (inputs '()) > + (native-inputs '()))) > + > (define-public java-asm > (package > (name "java-asm") * This one inherits java-plexus-container-default, but does not adapt synopsis/description. Is that OK? * Sorry for being so late, but I also looked into the java-plexus-container-default-bootstrap: It contains some jar's in the test path. Is that OK? find . -name "*.jar" ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-a-2.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/plexus-archiver-1.0-alpha-8.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-c-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/plugin1-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-b-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-a-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/plugin0-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/c.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/b.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/d.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/a.jar * We have a java-plexus-container-default and java-plexus-container-default-bootstrap. Both are "define-public". Should we make the bootstrap non-public? Otherwise, LGTM. And even though I have my comments, thanks for all this awesome Java/Maven work! Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:42:11 2018 Received: (at 30417) by debbugs.gnu.org; 11 Feb 2018 23:42:11 +0000 Received: from localhost ([127.0.0.1]:38734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1el1G7-0004Qo-G5 for submit@debbugs.gnu.org; Sun, 11 Feb 2018 18:42:11 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44055 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1el1G3-0004Qe-Rv for 30417@debbugs.gnu.org; Sun, 11 Feb 2018 18:42:08 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 1EDDA40709; Mon, 12 Feb 2018 00:42:07 +0100 (CET) Date: Mon, 12 Feb 2018 00:42:06 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 02/11] gnu: Add java-plexus-cipher. Message-ID: <20180212004206.510f794f@alma-ubu> In-Reply-To: <20180210230438.26794-2-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-2-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:29 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-plexus-cipher): New variable. > --- > gnu/packages/java.scm | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index b7f3fd54e..8b51f7122 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2673,6 +2673,42 @@ archives (jar).") > (inputs '()) > (native-inputs '()))) > =20 > +(define-public java-plexus-cipher > + (package > + (name "java-plexus-cipher") > + (version "1.7") > + (source (origin > + (method url-fetch) > + (uri (string-append > "https://github.com/codehaus-plexus/plexus-cipher" > + "/archive/plexus-cipher-" version > ".tar.gz")) > + (sha256 > + (base32 > + > "1j3r8xzlxlk340snkjp6lk2ilkxlkn8qavsfiq01f43xmvv8ymk3")))) > + (build-system ant-build-system) > + (arguments > + `(#:jar-name "plexus-cipher.jar" > + #:source-dir "src/main/java" > + #:jdk ,icedtea-8 > + #:tests? #f; FIXME: requires sisu-inject-bean > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'copy-resources > + (lambda _ > + (copy-recursively "src/main/resources" "build/classes") > + (mkdir-p "build/classes/META-INF/sisu") > + (with-output-to-file > "build/classes/META-INF/sisu/javax.inject.Named" > + (lambda _ > + (display > "org.sonatype.plexus.components.cipher.DefaultPlexusCipher\n"))) > + #t))))) > + (inputs > + `(("java-cdi-api" ,java-cdi-api) > + ("java-javax-inject" ,java-javax-inject))) > + (home-page "http://codehaus-plexus.github.io/plexus-cipher/") For the Homepage I get a 404. That's what I find as an alternative: https://github.com/sonatype/plexus-cipher Otherwise, LGTM Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:47:38 2018 Received: (at 30417) by debbugs.gnu.org; 11 Feb 2018 23:47:38 +0000 Received: from localhost ([127.0.0.1]:38738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1el1LO-0004YW-7R for submit@debbugs.gnu.org; Sun, 11 Feb 2018 18:47:38 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44057 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1el1LM-0004YO-RS for 30417@debbugs.gnu.org; Sun, 11 Feb 2018 18:47:37 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 17CD640709; Mon, 12 Feb 2018 00:47:36 +0100 (CET) Date: Mon, 12 Feb 2018 00:47:35 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 03/11] gnu: Add java-plexus-compiler-api. Message-ID: <20180212004735.1a2e1dfb@alma-ubu> In-Reply-To: <20180210230438.26794-3-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-3-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:30 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-plexus-compiler-api): New variable. > --- > gnu/packages/java.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 8b51f7122..55233b7ba 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2709,6 +2709,34 @@ archives (jar).") > and decryption.") > (license license:asl2.0))) > =20 > +(define-public java-plexus-compiler-api > + (package > + (name "java-plexus-compiler-api") > + (version "2.8.2") > + (source (origin > + (method url-fetch) > + (uri (string-append > "https://github.com/codehaus-plexus/plexus-compiler" > + "/archive/plexus-compiler-" > version ".tar.gz")) > + (sha256 > + (base32 > + > "0g3x26pymcdnfnwv2a1i57pd5s26f5zqfi1rdy98z1bn01klx25k")))) > + (build-system ant-build-system) > + (arguments > + `(#:jar-name "plexus-compiler-api.jar" > + #:source-dir "plexus-compiler-api/src/main/java" > + #:jdk ,icedtea-8 > + #:test-dir "plexus-compiler-api/src/test")) > + (inputs > + > `(("java-plexus-container-default" ,java-plexus-container-default) > + ("java-plexus-util" ,java-plexus-utils))) > + (native-inputs > + `(("java-junit" ,java-junit))) > + (home-page "https://github.com/codehaus-plexus/plexus-compiler") > + (synopsis "Plexus Compilers component's API to manipulate > compilers") > + (description "This package contains the API used by components > to manipulate +compilers.") > + (license license:asl2.0))) There are some files licensed under "MIT" (which one is that exactly in FSF-speach again?), for example: https://github.com/codehaus-plexus/plexus-compiler/blob/master/plexus-compi= ler-api/src/main/java/org/codehaus/plexus/compiler/AbstractCompiler.java I haven't done a full review of it yet. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 14:18:05 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 19:18:06 +0000 Received: from localhost ([127.0.0.1]:43166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em2ZB-0005Ae-Op for submit@debbugs.gnu.org; Wed, 14 Feb 2018 14:18:05 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44060 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em2Z9-0005AW-TE for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 14:18:04 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 789A44043C; Wed, 14 Feb 2018 20:18:02 +0100 (CET) Date: Wed, 14 Feb 2018 20:18:01 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 03/11] gnu: Add java-plexus-compiler-api. Message-ID: <20180214201801.48093f2c@alma-ubu> In-Reply-To: <20180212004735.1a2e1dfb@alma-ubu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-3-julien@lepiller.eu> <20180212004735.1a2e1dfb@alma-ubu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Mon, 12 Feb 2018 00:47:35 +0100 Bj=C3=B6rn H=C3=B6fling wrote: > On Sun, 11 Feb 2018 00:04:30 +0100 > Julien Lepiller wrote: >=20 > > * gnu/packages/java.scm (java-plexus-compiler-api): New variable. [...] > > + (license license:asl2.0))) =20 >=20 > There are some files licensed under "MIT" (which one is that exactly > in FSF-speach again?), for example: > https://github.com/codehaus-plexus/plexus-compiler/blob/master/plexus-com= piler-api/src/main/java/org/codehaus/plexus/compiler/AbstractCompiler.java >=20 > I haven't done a full review of it yet. Apart from the missing "license:expat" this LGTM. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 14:23:10 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 19:23:10 +0000 Received: from localhost ([127.0.0.1]:43187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em2e5-0005JZ-Nr for submit@debbugs.gnu.org; Wed, 14 Feb 2018 14:23:09 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44063 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em2e4-0005JQ-4m for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 14:23:08 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 850C54043C; Wed, 14 Feb 2018 20:23:07 +0100 (CET) Date: Wed, 14 Feb 2018 20:23:06 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 04/11] gnu: Add java-plexus-compiler-javac. Message-ID: <20180214202306.3645c832@alma-ubu> In-Reply-To: <20180210230438.26794-4-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-4-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:31 +0100 Julien Lepiller wrote: > gnu/packages/java.scm (java-plexus-compiler-javac): New variable. > --- > gnu/packages/java.scm | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 55233b7ba..29439d667 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2737,6 +2737,26 @@ and decryption.") > compilers.") > (license license:asl2.0))) > =20 > +(define-public java-plexus-compiler-javac > + (package > + (inherit java-plexus-compiler-api) > + (name "java-plexus-compiler-javac") LGTM, except of this comment: This one also has some source files unde license:expat. As the package inherits from java-plexus-compiler-api, and if you add the missing license there, everything should be fine automatically. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 14:53:37 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 19:53:37 +0000 Received: from localhost ([127.0.0.1]:43203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em37Y-0005zy-OY for submit@debbugs.gnu.org; Wed, 14 Feb 2018 14:53:36 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44065 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em37X-0005zq-65 for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 14:53:35 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 29BFA4043C; Wed, 14 Feb 2018 20:53:34 +0100 (CET) Date: Wed, 14 Feb 2018 20:53:33 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 05/11] gnu: Add java-sisu-build-api. Message-ID: <20180214205333.113684dd@alma-ubu> In-Reply-To: <20180210230438.26794-5-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-5-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:32 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-sisu-build-api): New variable. > --- > gnu/packages/java.scm | 54 > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, > 54 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 29439d667..af9acd71f 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2757,6 +2757,60 @@ compilers.") > (description "This package contains the Javac Compiler support > for Plexus Compiler component."))) > =20 > +(define-public java-sisu-build-api > + (package > + (name "java-sisu-build-api") > + (version "0.0.7") > + (source (origin > + (method url-fetch) > + (uri (string-append > "https://github.com/sonatype/sisu-build-api/" > + "archive/plexus-build-api-" > version ".tar.gz")) > + (sha256 > + (base32 > + > "1c3rrpma3x634xp2rm2p5iskfhzdyc7qfbhjzr70agrl1jwghgy2")))) > + (build-system ant-build-system) > + (arguments > + `(#:jar-name "sisu-build-api.jar" > + #:source-dir "src/main/java" > + #:jdk ,icedtea-8 > + #:tests? #f; FIXME: how to run the tests? > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'copy-resurces > + (lambda _ > + (mkdir-p > "build/classes/org/sonatype/plexus/build/incremental") > + (copy-file > "src/main/resources/org/sonatype/plexus/build/incremental/version.propert= ies" > + > "build/classes/org/sonatype/plexus/build/incremental/version.properties") The content of this file is: api.version =3D ${project.version} Is that OK? Or should we better write the correct version into the file? > + #t)) > + (add-before 'build 'generate-plexus-compontent > + (lambda _ > + (mkdir-p "build/classes/META-INF/plexus") > + ;; This file is required for plexus to inject this > package. > + ;; FIXME: how is it generated? > + (with-output-to-file > "build/classes/META-INF/plexus/components.xml" > + (lambda _ > + (display > + "\n > + \n > + \n > + > org.sonatype.plexus.build.incremental.BuildContext\n > + default\n > + > org.sonatype.plexus.build.incremental.DefaultBuildContext= \n > + Filesystem based non-incremental build context > implementation which behaves as if all files\n +were just > created.\n > + \n > + \n > +\n")))))))) R5RS specifies that "with-output-to-file re-turn(s) the value(s) yielded by thunk". As your last call within thunk is "(display..."), the return value is unspecified. Add a "#t" to either the thunk or after (call-with-output-to-file .."). Linter complained about some too long lines, but I think that's OK. At least I wouldn't know how to do better. Otherwise, LGTM. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 15:22:29 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 20:22:29 +0000 Received: from localhost ([127.0.0.1]:43227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3ZV-00009l-5z for submit@debbugs.gnu.org; Wed, 14 Feb 2018 15:22:29 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44066 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3ZT-00009d-4R for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 15:22:27 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id AA6A73FED6; Wed, 14 Feb 2018 21:22:25 +0100 (CET) Date: Wed, 14 Feb 2018 21:22:25 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 06/11] gnu: Add java-modello-core. Message-ID: <20180214212225.07b5d25b@alma-ubu> In-Reply-To: <20180210230438.26794-6-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-6-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:33 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-modello-core): New variable. > --- > gnu/packages/java.scm | 50 > ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 > insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index af9acd71f..d75960831 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2811,6 +2811,56 @@ a default implementation of it. This API is > about scanning files in a project and determining what files need to > be rebuilt.") (license license:asl2.0))) > =20 > +(define-public java-modello-core > + (package > + (name "java-modello-core") > + (version "1.9.1") > + (source (origin > + (method url-fetch) > + (uri (string-append > "https://github.com/codehaus-plexus/modello" > + "/archive/modello-" version > ".tar.gz")) > + (sha256 > + (base32 > + > "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh")))) > + (build-system ant-build-system) > + (arguments > + `(#:jar-name "modello-core.jar" > + #:source-dir "modello-core/src/main/java" > + #:test-dir "modello-core/src/test" > + #:main-class "org.codehaus.modello.ModelloCli" > + #:jdk ,icedtea-8 > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'copy-resources > + (lambda _ > + (mkdir-p "build/classes/META-INF/plexus") > + (copy-file > "modello-core/src/main/resources/META-INF/plexus/components.xml" > + > "build/classes/META-INF/plexus/components.xml") > + #t)) > + (add-before 'check 'fix-tests > + (lambda _ > + (substitute* > '("modello-core/src/test/java/org/codehaus/modello/core/DefaultModelloCor= eTest.java" > + > "modello-core/src/test/java/org/codehaus/modello/core/io/ModelReaderTest.= java") > + (("src/test") "modello-core/src/test"))))))) > + (inputs > + `(("java-plexus-utils" ,java-plexus-utils) > + > ("java-plexus-container-default-bootstrap" ,java-plexus-container-default= -bootstrap) > + ("java-sisu-build-api" ,java-sisu-build-api))) > + (native-inputs > + `(("java-junit" ,java-junit) > + ("java-plexus-classworlds" ,java-plexus-classworlds) > + ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) > + ("java-guava" ,java-guava))) > + (home-page "http://codehaus-plexus.github.io/modello/") > + (synopsis "Framework for code generation from a simple model") > + (description "Modello is a framework for code generation from a > simple model. + > +Modello generates code from a simple model format: based on a plugin > +architecture, various types of code and descriptors can be generated > from the +single model, including Java POJOs, XML/JSON/YAML > marshallers/unmarshallers, +XSD and documentation.") > + (license license:asl2.0))) I'm not sure about how to declare the license: If you consider only the code under modello-core, that is only license:expat (if I havent overseen anything). But as you are not working with snippets here, I think you have to look at every file in the original source package. And there I found three types of licenses: * expat, as above * asl2.0, like in ./modello-plugins/modello-plugin-stax/src/test/java/org/codehaus/model= lo/generator/xml/stax/BooleanTypeStaxGeneratorTest.java * Finally, some kind of "5-clause-BSD": ./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/pl= ugin/java/javasource/JNaming.java I always have my troubles matching a license text to one of the available licenses, so I quote it in full here: /** * Redistribution and use of this software and associated documentation * ("Software"), with or without modification, are permitted provided * that the following conditions are met: * * 1. Redistributions of source code must retain copyright * statements and notices. Redistributions must also contain a * copy of this document. * * 2. Redistributions in binary form must reproduce the * above copyright notice, this list of conditions and the * following disclaimer in the documentation and/or other * materials provided with the distribution. * * 3. The name "Exolab" must not be used to endorse or promote * products derived from this Software without prior written * permission of Intalio, Inc. For written permission, * please contact info@codehaus.org. * * 4. Products derived from this Software may not be called "Exolab" * nor may "Exolab" appear in their names without prior written * permission of Intalio, Inc. Exolab is a registered * trademark of Intalio, Inc. * * 5. Due credit should be given to the Exolab Project * (http://www.codehaus.org/). * * THIS SOFTWARE IS PROVIDED BY INTALIO, INC. AND CONTRIBUTORS * ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT * NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL * INTALIO, INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED * OF THE POSSIBILITY OF SUCH DAMAGE. * * Copyright 1999-2000 (C) Intalio, Inc. All Rights Reserved. * * $Id$ */ > + > (define-public java-asm > (package > (name "java-asm") Linter found 3 lines too long: /home/bjoern/guix/guix/gnu/packages/java.scm:2903:2: java-modello-core@1.9.1: line 2930 is way too long (110 characters) /home/bjoern/guix/guix/gnu/packages/java.scm:2903:2: java-modello-core@1.9.1: line 2931 is way too long (107 characters) /home/bjoern/guix/guix/gnu/packages/java.scm:2903:2: java-modello-core@1.9.1: line 2935 is way too long (91 characters) The first ones are the substitute*, I think that is OK. The last one is the dependency: ("java-plexus-container-default-bootstrap" ,java-plexus-container-de= fault-bootstrap) That could be broken up in two lines. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 15:34:07 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 20:34:07 +0000 Received: from localhost ([127.0.0.1]:43253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3kk-0000S6-OH for submit@debbugs.gnu.org; Wed, 14 Feb 2018 15:34:07 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44069 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3ki-0000Rx-89 for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 15:34:04 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 720883FED6; Wed, 14 Feb 2018 21:34:03 +0100 (CET) Date: Wed, 14 Feb 2018 21:34:02 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 07/11] gnu: Add java-modello-plugins-java. Message-ID: <20180214213402.35c33347@alma-ubu> In-Reply-To: <20180210230438.26794-7-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-7-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:34 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-modello-plugins-java): New variable. > --- > gnu/packages/java.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index d75960831..76a586a98 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2861,6 +2861,28 @@ single model, including Java POJOs, > XML/JSON/YAML marshallers/unmarshallers, XSD and documentation.") > (license license:asl2.0))) > =20 > +(define-public java-modello-plugins-java > + (package > + (inherit java-modello-core) > + (name "java-modello-plugins-java") > + (arguments > + `(#:jar-name "modello-plugins-java.jar" > + #:source-dir > "modello-plugins/modello-plugin-java/src/main/java" > + #:test-dir "modello-plugins/modello-plugin-java/src/test" > + #:jdk ,icedtea-8 > + #:tests? #f; requires maven-model, which depends on this > package > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'copy-resources > + (lambda _ > + (mkdir-p "build/classes") > + (copy-recursively > "modello-plugins/modello-plugin-java/src/main/resources" > + "build/classes") > + #t))))) > + (inputs > + `(("java-modello-core" ,java-modello-core) > + ,@(package-inputs java-modello-core))))) > + > (define-public java-asm > (package > (name "java-asm") License: This is again a mixture of ASL and "5-clause-BSD" like in ./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/pl= ugin/java/javasource/JModifiers.java Compare with comments in java-modello-core. Synopsys and Description are inherited from java-modello-core but should be specialized here. Otherwise, LGTM. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 15:37:57 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 20:37:57 +0000 Received: from localhost ([127.0.0.1]:43263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3oT-0000Xb-IH for submit@debbugs.gnu.org; Wed, 14 Feb 2018 15:37:57 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44070 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3oS-0000XU-Lb for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 15:37:56 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id E8F5F3FED6; Wed, 14 Feb 2018 21:37:55 +0100 (CET) Date: Wed, 14 Feb 2018 21:37:55 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 08/11] gnu: Add java-modello-plugins-xml. Message-ID: <20180214213755.505eed4f@alma-ubu> In-Reply-To: <20180210230438.26794-8-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-8-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:35 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-modello-plugins-xml): New variable. All comments for java-modello-plugins-java hold here too. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 15:39:14 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 20:39:14 +0000 Received: from localhost ([127.0.0.1]:43267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3ph-0000Zm-Rj for submit@debbugs.gnu.org; Wed, 14 Feb 2018 15:39:13 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44073 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3pg-0000Zd-BS for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 15:39:12 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 9C4E13FED6; Wed, 14 Feb 2018 21:39:11 +0100 (CET) Date: Wed, 14 Feb 2018 21:39:11 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 09/11] gnu: Add java-modello-test. Message-ID: <20180214213911.04192896@alma-ubu> In-Reply-To: <20180210230438.26794-9-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-9-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:36 +0100 Julien Lepiller wrote: > gnu/packages/java.scm (java-modello-test): New variable. All comments for java-modello-plugins-java hold here too. Especially synopsis/description should be different here, as this is a testing package like junit is. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 15:43:22 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 20:43:22 +0000 Received: from localhost ([127.0.0.1]:43275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3ti-0000ft-Ha for submit@debbugs.gnu.org; Wed, 14 Feb 2018 15:43:22 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44075 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em3th-0000fl-3R for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 15:43:21 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 667313FED6; Wed, 14 Feb 2018 21:43:20 +0100 (CET) Date: Wed, 14 Feb 2018 21:43:19 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 10/11] gnu: Add java-modello-plugins-xpp3. Message-ID: <20180214214319.272db096@alma-ubu> In-Reply-To: <20180210230438.26794-10-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-10-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:37 +0100 Julien Lepiller wrote: > gnu/packages/java.scm (java-modello-plugins-xpp3): New variable. > --- > gnu/packages/java.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 18ba46c5c..758665df9 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2924,6 +2924,34 @@ XSD and documentation.") > ("java-plexus-compiler-javac" ,java-plexus-compiler-javac) > ("java-plexus-container-default" ,java-plexus-container-default))= ))) > =20 > +(define-public java-modello-plugins-xpp3 > + (package > + (inherit java-modello-core) > + (name "java-modello-plugins-xpp3") > + (arguments > + `(#:jar-name "modello-plugins-xpp3.jar" > + #:source-dir > "modello-plugins/modello-plugin-xpp3/src/main/java" > + #:test-dir "modello-plugins/modello-plugin-xpp3/src/test" The following line is too long: > + #:tests? #f; I can find some of its dependencies, for > instance > org.codehaus.modello.test.features.io.xpp3.ModelloFeaturesTestXpp3Reader Did you really mean "I can find" or did you mean the opposite: "I can't find"? I would expect here reasons of why the tests are NOT executable. > + #:jdk ,icedtea-8 > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'copy-resources > + (lambda _ > + (mkdir-p "build/classes") > + (copy-recursively > "modello-plugins/modello-plugin-xpp3/src/main/resources" > + "build/classes") > + #t))))) > + (inputs > + `(("java-modello-core" ,java-modello-core) > + ("java-modello-plugins-java" ,java-modello-plugins-java) > + ("java-modello-plugins-xml" ,java-modello-plugins-xml) > + ,@(package-inputs java-modello-core))) > + (native-inputs > + `(("java-xmlunit" ,java-xmlunit) > + ("java-modello-test" ,java-modello-test) > + ,@(package-native-inputs java-modello-core))))) > + > (define-public java-asm > (package > (name "java-asm") License, description, synopsis: See java-modello-plugins-java. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 15:59:22 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 20:59:22 +0000 Received: from localhost ([127.0.0.1]:43291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em49C-000122-GY for submit@debbugs.gnu.org; Wed, 14 Feb 2018 15:59:22 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44077 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em49B-00011u-2q for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 15:59:21 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 450503FED6; Wed, 14 Feb 2018 21:59:20 +0100 (CET) Date: Wed, 14 Feb 2018 21:59:19 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 11/11] gnu: Add java-plexus-sec-dispatcher. Message-ID: <20180214215919.401a5537@alma-ubu> In-Reply-To: <20180210230438.26794-11-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-11-julien@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sun, 11 Feb 2018 00:04:38 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-plexus-sec-dispatcher): New variable. > --- > gnu/packages/java.scm | 88 > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, > 88 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 758665df9..bd3fc7e70 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2757,6 +2757,94 @@ compilers.") > (description "This package contains the Javac Compiler support > for Plexus Compiler component."))) > =20 > +(define-public java-plexus-sec-dispatcher > + (package > + (name "java-plexus-sec-dispatcher") [...] > + (home-page "http://spice.sonatype.org/plexus-sec-dispatcher/") > + (synopsis "Plexus Security Dispatcher Component") > + (description "This package is the Plexus Security Dispatcher > Component. +This component descrypts a string passed to it") Spelling: s/descrypts/decrypts/ Add a full-stop "." at the end of the last sentence. Otherwise, LGTM. Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 16:02:32 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 21:02:32 +0000 Received: from localhost ([127.0.0.1]:43295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em4CF-00017s-VC for submit@debbugs.gnu.org; Wed, 14 Feb 2018 16:02:32 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44079 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em4CD-00017k-NX for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 16:02:30 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 0B1863FED6; Wed, 14 Feb 2018 22:02:29 +0100 (CET) Date: Wed, 14 Feb 2018 22:02:28 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 11/11] gnu: Add java-plexus-sec-dispatcher. Message-ID: <20180214220228.7bd1f0a1@alma-ubu> In-Reply-To: <20180214215919.401a5537@alma-ubu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-11-julien@lepiller.eu> <20180214215919.401a5537@alma-ubu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed, 14 Feb 2018 21:59:19 +0100 Bj=C3=B6rn H=C3=B6fling wrote: > On Sun, 11 Feb 2018 00:04:38 +0100 > Julien Lepiller wrote: >=20 > > * gnu/packages/java.scm (java-plexus-sec-dispatcher): New variable. > > --- > > gnu/packages/java.scm | 88 > > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, > > 88 insertions(+) > >=20 > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > > index 758665df9..bd3fc7e70 100644 > > --- a/gnu/packages/java.scm > > +++ b/gnu/packages/java.scm > > @@ -2757,6 +2757,94 @@ compilers.") > > (description "This package contains the Javac Compiler support > > for Plexus Compiler component."))) > > =20 > > +(define-public java-plexus-sec-dispatcher > > + (package > > + (name "java-plexus-sec-dispatcher") =20 >=20 > [...] >=20 > > + (home-page "http://spice.sonatype.org/plexus-sec-dispatcher/") > > + (synopsis "Plexus Security Dispatcher Component") > > + (description "This package is the Plexus Security Dispatcher > > Component. +This component descrypts a string passed to it") =20 >=20 > Spelling: s/descrypts/decrypts/ > Add a full-stop "." at the end of the last sentence. >=20 > Otherwise, LGTM. >=20 > Bj=C3=B6rn Sorry, here is one more point: The linter didn't complain about the homepage, but for me this is not reachable. I would suggest: https://github.com/sonatype/plexus-sec-dispatcher Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 16:56:50 2018 Received: (at 30417) by debbugs.gnu.org; 14 Feb 2018 21:56:50 +0000 Received: from localhost ([127.0.0.1]:43404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em52k-0002Qu-Iq for submit@debbugs.gnu.org; Wed, 14 Feb 2018 16:56:49 -0500 Received: from lepiller.eu ([89.234.186.109]:49646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em52h-0002Qj-TD for 30417@debbugs.gnu.org; Wed, 14 Feb 2018 16:56:44 -0500 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 93fbdf83 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <30417@debbugs.gnu.org>; Wed, 14 Feb 2018 21:57:56 +0000 (UTC) Date: Wed, 14 Feb 2018 22:56:38 +0100 From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: Re: [bug#30417] [PATCH 06/11] gnu: Add java-modello-core. Message-ID: <20180214225638.374d098f@lepiller.eu> In-Reply-To: <20180214212225.07b5d25b@alma-ubu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-6-julien@lepiller.eu> <20180214212225.07b5d25b@alma-ubu> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Le Wed, 14 Feb 2018 21:22:25 +0100, Bj=C3=B6rn H=C3=B6fling a =C3=A9crit : > On Sun, 11 Feb 2018 00:04:33 +0100 > Julien Lepiller wrote: >=20 > > * gnu/packages/java.scm (java-modello-core): New variable. > > --- > > gnu/packages/java.scm | 50 > > ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, > > 50 insertions(+) > >=20 > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > > index af9acd71f..d75960831 100644 > > --- a/gnu/packages/java.scm > > +++ b/gnu/packages/java.scm > > @@ -2811,6 +2811,56 @@ a default implementation of it. This API is > > about scanning files in a project and determining what files need to > > be rebuilt.") (license license:asl2.0))) > > =20 > > +(define-public java-modello-core > > + (package > > + (name "java-modello-core") > > + (version "1.9.1") > > + (source (origin > > + (method url-fetch) > > + (uri (string-append > > "https://github.com/codehaus-plexus/modello" > > + "/archive/modello-" version > > ".tar.gz")) > > + (sha256 > > + (base32 > > + > > "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh")))) > > + (build-system ant-build-system) > > + (arguments > > + `(#:jar-name "modello-core.jar" > > + #:source-dir "modello-core/src/main/java" > > + #:test-dir "modello-core/src/test" > > + #:main-class "org.codehaus.modello.ModelloCli" > > + #:jdk ,icedtea-8 > > + #:phases > > + (modify-phases %standard-phases > > + (add-before 'build 'copy-resources > > + (lambda _ > > + (mkdir-p "build/classes/META-INF/plexus") > > + (copy-file > > "modello-core/src/main/resources/META-INF/plexus/components.xml" > > + > > "build/classes/META-INF/plexus/components.xml") > > + #t)) > > + (add-before 'check 'fix-tests > > + (lambda _ > > + (substitute* > > '("modello-core/src/test/java/org/codehaus/modello/core/DefaultModelloC= oreTest.java" > > + > > "modello-core/src/test/java/org/codehaus/modello/core/io/ModelReaderTes= t.java") > > + (("src/test") "modello-core/src/test"))))))) > > + (inputs > > + `(("java-plexus-utils" ,java-plexus-utils) > > + > > ("java-plexus-container-default-bootstrap" ,java-plexus-container-defau= lt-bootstrap) > > + ("java-sisu-build-api" ,java-sisu-build-api))) > > + (native-inputs > > + `(("java-junit" ,java-junit) > > + ("java-plexus-classworlds" ,java-plexus-classworlds) > > + ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) > > + ("java-guava" ,java-guava))) > > + (home-page "http://codehaus-plexus.github.io/modello/") > > + (synopsis "Framework for code generation from a simple model") > > + (description "Modello is a framework for code generation from a > > simple model. + > > +Modello generates code from a simple model format: based on a > > plugin +architecture, various types of code and descriptors can be > > generated from the +single model, including Java POJOs, > > XML/JSON/YAML marshallers/unmarshallers, +XSD and documentation.") > > + (license license:asl2.0))) =20 >=20 > I'm not sure about how to declare the license: >=20 > If you consider only the code under modello-core, that is only > license:expat (if I havent overseen anything). >=20 > But as you are not working with snippets here, I think you have to > look at every file in the original source package. And there I found > three types of licenses: >=20 > * expat, as above > * asl2.0, like > in ./modello-plugins/modello-plugin-stax/src/test/java/org/codehaus/mod= ello/generator/xml/stax/BooleanTypeStaxGeneratorTest.java > * Finally, some kind of "5-clause-BSD": > ./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/= plugin/java/javasource/JNaming.java > I always have my troubles matching a license text to one of the > available licenses, so I quote it in full here: >=20 > /** > * Redistribution and use of this software and associated > documentation > * ("Software"), with or without modification, are permitted provided > * that the following conditions are met: > * > * 1. Redistributions of source code must retain copyright > * statements and notices. Redistributions must also contain a > * copy of this document. > * > * 2. Redistributions in binary form must reproduce the > * above copyright notice, this list of conditions and the > * following disclaimer in the documentation and/or other > * materials provided with the distribution. > * > * 3. The name "Exolab" must not be used to endorse or promote > * products derived from this Software without prior written > * permission of Intalio, Inc. For written permission, > * please contact info@codehaus.org. > * > * 4. Products derived from this Software may not be called "Exolab" > * nor may "Exolab" appear in their names without prior written > * permission of Intalio, Inc. Exolab is a registered > * trademark of Intalio, Inc. > * > * 5. Due credit should be given to the Exolab Project > * (http://www.codehaus.org/). > * > * THIS SOFTWARE IS PROVIDED BY INTALIO, INC. AND CONTRIBUTORS > * ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT > * NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL > * INTALIO, INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, > * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR > * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, > * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED > * OF THE POSSIBILITY OF SUCH DAMAGE. > * > * Copyright 1999-2000 (C) Intalio, Inc. All Rights Reserved. > * > * $Id$ > */ We don't have anything for that license. I've seen it in some other java packages, and I used (non-copyleft "file:///LICENSE.txt"), except this time, LICENSE.txt contains only the expat license. The files that have this license are also licensed under the expat license. Is it OK to declare only the expat license here, as it is the only one in LICENSE.txt? >=20 >=20 > > + > > (define-public java-asm > > (package > > (name "java-asm") =20 >=20 > Linter found 3 lines too long: >=20 > /home/bjoern/guix/guix/gnu/packages/java.scm:2903:2: > java-modello-core@1.9.1: line 2930 is way too long (110 > characters) /home/bjoern/guix/guix/gnu/packages/java.scm:2903:2: > java-modello-core@1.9.1: line 2931 is way too long (107 > characters) /home/bjoern/guix/guix/gnu/packages/java.scm:2903:2: > java-modello-core@1.9.1: line 2935 is way too long (91 characters) >=20 > The first ones are the substitute*, I think that is OK. The last one > is the dependency: >=20 > ("java-plexus-container-default-bootstrap" ,java-plexus-container-= default-bootstrap) >=20 > That could be broken up in two lines. >=20 >=20 > Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 14:16:50 2018 Received: (at 30417) by debbugs.gnu.org; 16 Feb 2018 19:16:50 +0000 Received: from localhost ([127.0.0.1]:47206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emlV0-0003Of-L8 for submit@debbugs.gnu.org; Fri, 16 Feb 2018 14:16:50 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:44093 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emlUu-0003OS-06 for 30417@debbugs.gnu.org; Fri, 16 Feb 2018 14:16:42 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 2B01640133; Fri, 16 Feb 2018 20:16:38 +0100 (CET) Date: Fri, 16 Feb 2018 20:16:37 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Julien Lepiller Subject: Re: [bug#30417] [PATCH 06/11] gnu: Add java-modello-core. Message-ID: <20180216201637.73fe7c9c@alma-ubu> In-Reply-To: <20180214225638.374d098f@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-6-julien@lepiller.eu> <20180214212225.07b5d25b@alma-ubu> <20180214225638.374d098f@lepiller.eu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed, 14 Feb 2018 22:56:38 +0100 Julien Lepiller wrote: > Le Wed, 14 Feb 2018 21:22:25 +0100, > Bj=C3=B6rn H=C3=B6fling a =C3=A9crit : >=20 > > On Sun, 11 Feb 2018 00:04:33 +0100 > > Julien Lepiller wrote: > > =20 > > > * gnu/packages/java.scm (java-modello-core): New variable. > > > --- > > > gnu/packages/java.scm | 50 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, > > > 50 insertions(+) > > >=20 > > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > > > index af9acd71f..d75960831 100644 > > > --- a/gnu/packages/java.scm > > > +++ b/gnu/packages/java.scm > > > @@ -2811,6 +2811,56 @@ a default implementation of it. This API > > > is about scanning files in a project and determining what files > > > need to be rebuilt.") (license license:asl2.0))) > > > =20 > > > +(define-public java-modello-core > > > + (package > > > + (name "java-modello-core") > > > + (version "1.9.1") > > > + (source (origin > > > + (method url-fetch) > > > + (uri (string-append > > > "https://github.com/codehaus-plexus/modello" > > > + "/archive/modello-" version > > > ".tar.gz")) > > > + (sha256 > > > + (base32 > > > + > > > "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh")))) > > > + (build-system ant-build-system) > > > + (arguments > > > + `(#:jar-name "modello-core.jar" > > > + #:source-dir "modello-core/src/main/java" > > > + #:test-dir "modello-core/src/test" > > > + #:main-class "org.codehaus.modello.ModelloCli" > > > + #:jdk ,icedtea-8 > > > + #:phases > > > + (modify-phases %standard-phases > > > + (add-before 'build 'copy-resources > > > + (lambda _ > > > + (mkdir-p "build/classes/META-INF/plexus") > > > + (copy-file > > > "modello-core/src/main/resources/META-INF/plexus/components.xml" > > > + > > > "build/classes/META-INF/plexus/components.xml") > > > + #t)) > > > + (add-before 'check 'fix-tests > > > + (lambda _ > > > + (substitute* > > > '("modello-core/src/test/java/org/codehaus/modello/core/DefaultModell= oCoreTest.java" > > > + > > > "modello-core/src/test/java/org/codehaus/modello/core/io/ModelReaderT= est.java") > > > + (("src/test") "modello-core/src/test"))))))) > > > + (inputs > > > + `(("java-plexus-utils" ,java-plexus-utils) > > > + > > > ("java-plexus-container-default-bootstrap" ,java-plexus-container-def= ault-bootstrap) > > > + ("java-sisu-build-api" ,java-sisu-build-api))) > > > + (native-inputs > > > + `(("java-junit" ,java-junit) > > > + ("java-plexus-classworlds" ,java-plexus-classworlds) > > > + > > > ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) > > > + ("java-guava" ,java-guava))) > > > + (home-page "http://codehaus-plexus.github.io/modello/") > > > + (synopsis "Framework for code generation from a simple > > > model") > > > + (description "Modello is a framework for code generation > > > from a simple model. + > > > +Modello generates code from a simple model format: based on a > > > plugin +architecture, various types of code and descriptors can be > > > generated from the +single model, including Java POJOs, > > > XML/JSON/YAML marshallers/unmarshallers, +XSD and documentation.") > > > + (license license:asl2.0))) =20 > >=20 > > I'm not sure about how to declare the license: > >=20 > > If you consider only the code under modello-core, that is only > > license:expat (if I havent overseen anything). > >=20 > > But as you are not working with snippets here, I think you have to > > look at every file in the original source package. And there I found > > three types of licenses: > >=20 > > * expat, as above > > * asl2.0, like > > in ./modello-plugins/modello-plugin-stax/src/test/java/org/codehaus/m= odello/generator/xml/stax/BooleanTypeStaxGeneratorTest.java > > * Finally, some kind of "5-clause-BSD": > > ./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modell= o/plugin/java/javasource/JNaming.java > > I always have my troubles matching a license text to one of the > > available licenses, so I quote it in full here: > >=20 > > /** > > * Redistribution and use of this software and associated > > documentation > > * ("Software"), with or without modification, are permitted > > provided > > * that the following conditions are met: > > * > > * 1. Redistributions of source code must retain copyright > > * statements and notices. Redistributions must also contain a > > * copy of this document. > > * > > * 2. Redistributions in binary form must reproduce the > > * above copyright notice, this list of conditions and the > > * following disclaimer in the documentation and/or other > > * materials provided with the distribution. > > * > > * 3. The name "Exolab" must not be used to endorse or promote > > * products derived from this Software without prior written > > * permission of Intalio, Inc. For written permission, > > * please contact info@codehaus.org. > > * > > * 4. Products derived from this Software may not be called "Exolab" > > * nor may "Exolab" appear in their names without prior written > > * permission of Intalio, Inc. Exolab is a registered > > * trademark of Intalio, Inc. > > * > > * 5. Due credit should be given to the Exolab Project > > * (http://www.codehaus.org/). > > * > > * THIS SOFTWARE IS PROVIDED BY INTALIO, INC. AND CONTRIBUTORS > > * ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT > > * NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > > * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT > > SHALL > > * INTALIO, INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, > > * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > > DAMAGES > > * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > > OR > > * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > > INTERRUPTION) > > * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > > CONTRACT, > > * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > > * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF > > ADVISED > > * OF THE POSSIBILITY OF SUCH DAMAGE. > > * > > * Copyright 1999-2000 (C) Intalio, Inc. All Rights Reserved. > > * > > * $Id$ > > */ =20 >=20 > We don't have anything for that license. I've seen it in some other > java packages, and I used (non-copyleft "file:///LICENSE.txt"), except > this time, LICENSE.txt contains only the expat license. The files that > have this license are also licensed under the expat license. Is it OK > to declare only the expat license here, as it is the only one in > LICENSE.txt? I'm not a license expert. Has anyone else a opinion on that? Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 17 10:06:28 2018 Received: (at 30417) by debbugs.gnu.org; 17 Feb 2018 15:06:28 +0000 Received: from localhost ([127.0.0.1]:48424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en44G-00063O-Rh for submit@debbugs.gnu.org; Sat, 17 Feb 2018 10:06:28 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:42667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en44E-00063E-Ak for 30417@debbugs.gnu.org; Sat, 17 Feb 2018 10:06:23 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A3C8C20B36; Sat, 17 Feb 2018 10:06:21 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 17 Feb 2018 10:06:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=Gz23/Tfx2c7je/YygNKoOsnveqxJ6dUY62IpCb7Sfk4=; b=tXEwTIcM n8k54Jamj4nFuTEurtkxGGbOF1ff3KdhSesYvCEvKjxm1ZdkZGe6d/sJg8QSBGOT hQtsNUnOh/7yZXHTqi+AgCb/3Nd76JCsCEpT/ePU/Zc1w5adipLrneFDgvccvtiM DxQ45iGUjBgvb8jYReuZpCu9udnTkNWPhdGYsOibMixhXrGBhWA/KN62H8UPr5v+ XW02BBw2mUhuDuekO0QjQa7JHmQyRaZb5BZDLuAbDpra4+k1dll7OF1/xZpYg87t xlwxk1zL7bu+24ETLToLjY6yHxHJGqwiTtxkPvdne3RN5SIOcGJPxlwergNN9ZAU 8mbQ59IMLF8zeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=Gz23/Tfx2c7je/YygNKoOsnveqxJ6 dUY62IpCb7Sfk4=; b=aHmJLN5R1JQbd7ZRzeGYC99/W4HQ6iCnEOqQfG+Q8Fcrc jmOhT8+QxShGVwCsLxxyuVqy8Zp2lmna6Sx7qJqGh1AdIHsi4s40Xg/2JFvuAJMy YNoDMw7uzuyxdMioHM+5lQ7S/hepUdHL7parQrxAF7z8ne2ya8XTtzCrGG4rU/XJ eFPpYONKc4nZGYbu4BZW0Vl/+vPUDcOxYPq9DI1+sCjSUuCVqulGaoqT+q0K/hvm e8iAEk3HI2AQybnGhacvkxj/m0ZE7GnO3rkDaiOGMWkyN8DpAT8siiXpBA5hpvuM Oy1KatUHFrx32uHNzm5Vv6FbMW7Y8izKpGe3BOSuQ== X-ME-Sender: Received: from localhost (ip-86-49-250-168.net.upcbroadband.cz [86.49.250.168]) by mail.messagingengine.com (Postfix) with ESMTPA id 193B32460B; Sat, 17 Feb 2018 10:06:20 -0500 (EST) From: Marius Bakke To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= , Julien Lepiller Subject: Re: [bug#30417] [PATCH 06/11] gnu: Add java-modello-core. In-Reply-To: <20180216201637.73fe7c9c@alma-ubu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-6-julien@lepiller.eu> <20180214212225.07b5d25b@alma-ubu> <20180214225638.374d098f@lepiller.eu> <20180216201637.73fe7c9c@alma-ubu> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Sat, 17 Feb 2018 16:06:19 +0100 Message-ID: <878tbrveok.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30417 Cc: 30417@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > On Wed, 14 Feb 2018 22:56:38 +0100 > Julien Lepiller wrote: > >> Le Wed, 14 Feb 2018 21:22:25 +0100, >> Bj=C3=B6rn H=C3=B6fling a =C3=A9crit= : >>=20 >> > On Sun, 11 Feb 2018 00:04:33 +0100 >> > Julien Lepiller wrote: >> >=20=20=20 >> > > * gnu/packages/java.scm (java-modello-core): New variable. >> > > --- >> > > gnu/packages/java.scm | 50 >> > > ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, >> > > 50 insertions(+) >> > >=20 >> > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm >> > > index af9acd71f..d75960831 100644 >> > > --- a/gnu/packages/java.scm >> > > +++ b/gnu/packages/java.scm >> > > @@ -2811,6 +2811,56 @@ a default implementation of it. This API >> > > is about scanning files in a project and determining what files >> > > need to be rebuilt.") (license license:asl2.0))) >> > >=20=20 >> > > +(define-public java-modello-core >> > > + (package >> > > + (name "java-modello-core") >> > > + (version "1.9.1") >> > > + (source (origin >> > > + (method url-fetch) >> > > + (uri (string-append >> > > "https://github.com/codehaus-plexus/modello" >> > > + "/archive/modello-" version >> > > ".tar.gz")) >> > > + (sha256 >> > > + (base32 >> > > + >> > > "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh")))) >> > > + (build-system ant-build-system) >> > > + (arguments >> > > + `(#:jar-name "modello-core.jar" >> > > + #:source-dir "modello-core/src/main/java" >> > > + #:test-dir "modello-core/src/test" >> > > + #:main-class "org.codehaus.modello.ModelloCli" >> > > + #:jdk ,icedtea-8 >> > > + #:phases >> > > + (modify-phases %standard-phases >> > > + (add-before 'build 'copy-resources >> > > + (lambda _ >> > > + (mkdir-p "build/classes/META-INF/plexus") >> > > + (copy-file >> > > "modello-core/src/main/resources/META-INF/plexus/components.xml" >> > > + >> > > "build/classes/META-INF/plexus/components.xml") >> > > + #t)) >> > > + (add-before 'check 'fix-tests >> > > + (lambda _ >> > > + (substitute* >> > > '("modello-core/src/test/java/org/codehaus/modello/core/DefaultModel= loCoreTest.java" >> > > + >> > > "modello-core/src/test/java/org/codehaus/modello/core/io/ModelReader= Test.java") >> > > + (("src/test") "modello-core/src/test"))))))) >> > > + (inputs >> > > + `(("java-plexus-utils" ,java-plexus-utils) >> > > + >> > > ("java-plexus-container-default-bootstrap" ,java-plexus-container-de= fault-bootstrap) >> > > + ("java-sisu-build-api" ,java-sisu-build-api))) >> > > + (native-inputs >> > > + `(("java-junit" ,java-junit) >> > > + ("java-plexus-classworlds" ,java-plexus-classworlds) >> > > + >> > > ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) >> > > + ("java-guava" ,java-guava))) >> > > + (home-page "http://codehaus-plexus.github.io/modello/") >> > > + (synopsis "Framework for code generation from a simple >> > > model") >> > > + (description "Modello is a framework for code generation >> > > from a simple model. + >> > > +Modello generates code from a simple model format: based on a >> > > plugin +architecture, various types of code and descriptors can be >> > > generated from the +single model, including Java POJOs, >> > > XML/JSON/YAML marshallers/unmarshallers, +XSD and documentation.") >> > > + (license license:asl2.0)))=20=20=20=20 >> >=20 >> > I'm not sure about how to declare the license: >> >=20 >> > If you consider only the code under modello-core, that is only >> > license:expat (if I havent overseen anything). >> >=20 >> > But as you are not working with snippets here, I think you have to >> > look at every file in the original source package. And there I found >> > three types of licenses: >> >=20 >> > * expat, as above >> > * asl2.0, like >> > in ./modello-plugins/modello-plugin-stax/src/test/java/org/codehaus/= modello/generator/xml/stax/BooleanTypeStaxGeneratorTest.java >> > * Finally, some kind of "5-clause-BSD": >> > ./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/model= lo/plugin/java/javasource/JNaming.java >> > I always have my troubles matching a license text to one of the >> > available licenses, so I quote it in full here: >> >=20 >> > /** >> > * Redistribution and use of this software and associated >> > documentation >> > * ("Software"), with or without modification, are permitted >> > provided >> > * that the following conditions are met: >> > * >> > * 1. Redistributions of source code must retain copyright >> > * statements and notices. Redistributions must also contain a >> > * copy of this document. >> > * >> > * 2. Redistributions in binary form must reproduce the >> > * above copyright notice, this list of conditions and the >> > * following disclaimer in the documentation and/or other >> > * materials provided with the distribution. >> > * >> > * 3. The name "Exolab" must not be used to endorse or promote >> > * products derived from this Software without prior written >> > * permission of Intalio, Inc. For written permission, >> > * please contact info@codehaus.org. >> > * >> > * 4. Products derived from this Software may not be called "Exolab" >> > * nor may "Exolab" appear in their names without prior written >> > * permission of Intalio, Inc. Exolab is a registered >> > * trademark of Intalio, Inc. >> > * >> > * 5. Due credit should be given to the Exolab Project >> > * (http://www.codehaus.org/). >> > * >> > * THIS SOFTWARE IS PROVIDED BY INTALIO, INC. AND CONTRIBUTORS >> > * ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT >> > * NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND >> > * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT >> > SHALL >> > * INTALIO, INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, >> > * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL >> > DAMAGES >> > * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS >> > OR >> > * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS >> > INTERRUPTION) >> > * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN >> > CONTRACT, >> > * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) >> > * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF >> > ADVISED >> > * OF THE POSSIBILITY OF SUCH DAMAGE. >> > * >> > * Copyright 1999-2000 (C) Intalio, Inc. All Rights Reserved. >> > * >> > * $Id$ >> > */=20=20 >>=20 >> We don't have anything for that license. I've seen it in some other >> java packages, and I used (non-copyleft "file:///LICENSE.txt"), except >> this time, LICENSE.txt contains only the expat license. The files that >> have this license are also licensed under the expat license. Is it OK >> to declare only the expat license here, as it is the only one in >> LICENSE.txt? > > > I'm not a license expert. Has anyone else a opinion on that? I haven't checked, but if these source files are not part of the installed product (e.g. they are only used for tests, or optional plugins/features), AFAIU we don't need to list them in the (license ...) field. But please add a comment about them regardless. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqIROsACgkQoqBt8qM6 VPrEKQgAi5soOIxxpJrFMzHGjCOJJ1IjZExPyzOymA6kVj6bDMuRWlTbImKH4JHH DRdKBpwhKLEz4Ubt3VECCWO5AbAi6f36mD7b4QVVL94mPC+BHPsJpgOXz05taJuM CwbV45mkCBUTnLKrPhXqxS/Fa48ConwDrrX6pRtXFi25SKUoeU95UW1+sI7XNLMQ 6sE+mcuXRBOiKU0LngYfHLOzWvnoqcziEfcdpGaY//ZOHLGXmEJYGyJM+D2koo9a /QkFNHw6qL0kiK3XgAn76RVRumZ4oFZty3TikhTj/R+G2zffuhkWVntIlEjN0pc5 1bd1vmoKQpGHlHToQCj4TdrOzivKmw== =Ef2S -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 16:11:27 2018 Received: (at 30417) by debbugs.gnu.org; 24 Feb 2018 21:11:27 +0000 Received: from localhost ([127.0.0.1]:59079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eph6I-0006Ru-HB for submit@debbugs.gnu.org; Sat, 24 Feb 2018 16:11:27 -0500 Received: from lepiller.eu ([89.234.186.109]:50110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eph6G-0006Rl-Pa for 30417@debbugs.gnu.org; Sat, 24 Feb 2018 16:11:21 -0500 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 03d85708 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <30417@debbugs.gnu.org>; Sat, 24 Feb 2018 21:12:52 +0000 (UTC) Date: Sat, 24 Feb 2018 22:11:15 +0100 From: Julien Lepiller To: 30417@debbugs.gnu.org Subject: Re: [bug#30417] [PATCH 06/11] gnu: Add java-modello-core. Message-ID: <20180224221108.63006124@lepiller.eu> In-Reply-To: <878tbrveok.fsf@fastmail.com> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-6-julien@lepiller.eu> <20180214212225.07b5d25b@alma-ubu> <20180214225638.374d098f@lepiller.eu> <20180216201637.73fe7c9c@alma-ubu> <878tbrveok.fsf@fastmail.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/V1DtyWh.gZFLZ2wD6I1==sK" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --MP_/V1DtyWh.gZFLZ2wD6I1==sK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Le Sat, 17 Feb 2018 16:06:19 +0100, Marius Bakke a =C3=A9crit : > Bj=C3=B6rn H=C3=B6fling writes: >=20 > > On Wed, 14 Feb 2018 22:56:38 +0100 > > Julien Lepiller wrote: > > =20 > >> Le Wed, 14 Feb 2018 21:22:25 +0100, > >> Bj=C3=B6rn H=C3=B6fling a =C3=A9cr= it : > >> =20 > >> > On Sun, 11 Feb 2018 00:04:33 +0100 > >> > Julien Lepiller wrote: > >> > =20 > >> > > * gnu/packages/java.scm (java-modello-core): New variable. > >> > > --- > >> > > gnu/packages/java.scm | 50 > >> > > ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file > >> > > changed, 50 insertions(+) > >> > >=20 > >> > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > >> > > index af9acd71f..d75960831 100644 > >> > > --- a/gnu/packages/java.scm > >> > > +++ b/gnu/packages/java.scm > >> > > @@ -2811,6 +2811,56 @@ a default implementation of it. This > >> > > API is about scanning files in a project and determining what > >> > > files need to be rebuilt.") (license license:asl2.0))) > >> > > =20 > >> > > +(define-public java-modello-core > >> > > + (package > >> > > + (name "java-modello-core") > >> > > + (version "1.9.1") > >> > > + (source (origin > >> > > + (method url-fetch) > >> > > + (uri (string-append > >> > > "https://github.com/codehaus-plexus/modello" > >> > > + "/archive/modello-" version > >> > > ".tar.gz")) > >> > > + (sha256 > >> > > + (base32 > >> > > + > >> > > "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh")))) > >> > > + (build-system ant-build-system) > >> > > + (arguments > >> > > + `(#:jar-name "modello-core.jar" > >> > > + #:source-dir "modello-core/src/main/java" > >> > > + #:test-dir "modello-core/src/test" > >> > > + #:main-class "org.codehaus.modello.ModelloCli" > >> > > + #:jdk ,icedtea-8 > >> > > + #:phases > >> > > + (modify-phases %standard-phases > >> > > + (add-before 'build 'copy-resources > >> > > + (lambda _ > >> > > + (mkdir-p "build/classes/META-INF/plexus") > >> > > + (copy-file > >> > > "modello-core/src/main/resources/META-INF/plexus/components.xml" > >> > > + > >> > > "build/classes/META-INF/plexus/components.xml") > >> > > + #t)) > >> > > + (add-before 'check 'fix-tests > >> > > + (lambda _ > >> > > + (substitute* > >> > > '("modello-core/src/test/java/org/codehaus/modello/core/DefaultMod= elloCoreTest.java" > >> > > + > >> > > "modello-core/src/test/java/org/codehaus/modello/core/io/ModelRead= erTest.java") > >> > > + (("src/test") "modello-core/src/test"))))))) > >> > > + (inputs > >> > > + `(("java-plexus-utils" ,java-plexus-utils) > >> > > + > >> > > ("java-plexus-container-default-bootstrap" ,java-plexus-container-= default-bootstrap) > >> > > + ("java-sisu-build-api" ,java-sisu-build-api))) > >> > > + (native-inputs > >> > > + `(("java-junit" ,java-junit) > >> > > + ("java-plexus-classworlds" ,java-plexus-classworlds) > >> > > + > >> > > ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) > >> > > + ("java-guava" ,java-guava))) > >> > > + (home-page "http://codehaus-plexus.github.io/modello/") > >> > > + (synopsis "Framework for code generation from a simple > >> > > model") > >> > > + (description "Modello is a framework for code generation > >> > > from a simple model. + > >> > > +Modello generates code from a simple model format: based on a > >> > > plugin +architecture, various types of code and descriptors > >> > > can be generated from the +single model, including Java POJOs, > >> > > XML/JSON/YAML marshallers/unmarshallers, +XSD and > >> > > documentation.") > >> > > + (license license:asl2.0))) =20 > >> >=20 > >> > I'm not sure about how to declare the license: > >> >=20 > >> > If you consider only the code under modello-core, that is only > >> > license:expat (if I havent overseen anything). > >> >=20 > >> > But as you are not working with snippets here, I think you have > >> > to look at every file in the original source package. And there > >> > I found three types of licenses: > >> >=20 > >> > * expat, as above > >> > * asl2.0, like > >> > in ./modello-plugins/modello-plugin-stax/src/test/java/org/codehau= s/modello/generator/xml/stax/BooleanTypeStaxGeneratorTest.java > >> > * Finally, some kind of "5-clause-BSD": > >> > ./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/mod= ello/plugin/java/javasource/JNaming.java > >> > I always have my troubles matching a license text to one of the > >> > available licenses, so I quote it in full here: > >> >=20 > >> > /** > >> > * Redistribution and use of this software and associated > >> > documentation > >> > * ("Software"), with or without modification, are permitted > >> > provided > >> > * that the following conditions are met: > >> > * > >> > * 1. Redistributions of source code must retain copyright > >> > * statements and notices. Redistributions must also contain > >> > a > >> > * copy of this document. > >> > * > >> > * 2. Redistributions in binary form must reproduce the > >> > * above copyright notice, this list of conditions and the > >> > * following disclaimer in the documentation and/or other > >> > * materials provided with the distribution. > >> > * > >> > * 3. The name "Exolab" must not be used to endorse or promote > >> > * products derived from this Software without prior written > >> > * permission of Intalio, Inc. For written permission, > >> > * please contact info@codehaus.org. > >> > * > >> > * 4. Products derived from this Software may not be called > >> > "Exolab" > >> > * nor may "Exolab" appear in their names without prior > >> > written > >> > * permission of Intalio, Inc. Exolab is a registered > >> > * trademark of Intalio, Inc. > >> > * > >> > * 5. Due credit should be given to the Exolab Project > >> > * (http://www.codehaus.org/). > >> > * > >> > * THIS SOFTWARE IS PROVIDED BY INTALIO, INC. AND CONTRIBUTORS > >> > * ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, > >> > BUT > >> > * NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > >> > * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT > >> > SHALL > >> > * INTALIO, INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, > >> > * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > >> > DAMAGES > >> > * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE > >> > GOODS OR > >> > * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > >> > INTERRUPTION) > >> > * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > >> > CONTRACT, > >> > * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > >> > * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF > >> > ADVISED > >> > * OF THE POSSIBILITY OF SUCH DAMAGE. > >> > * > >> > * Copyright 1999-2000 (C) Intalio, Inc. All Rights Reserved. > >> > * > >> > * $Id$ > >> > */ =20 > >>=20 > >> We don't have anything for that license. I've seen it in some other > >> java packages, and I used (non-copyleft "file:///LICENSE.txt"), > >> except this time, LICENSE.txt contains only the expat license. The > >> files that have this license are also licensed under the expat > >> license. Is it OK to declare only the expat license here, as it is > >> the only one in LICENSE.txt? =20 > > > > > > I'm not a license expert. Has anyone else a opinion on that? =20 >=20 > I haven't checked, but if these source files are not part of the > installed product (e.g. they are only used for tests, or optional > plugins/features), AFAIU we don't need to list them in the > (license ...) field. >=20 > But please add a comment about them regardless. I've addressed all the comments in other packages, but this one remains. Here is what I did. Do you think it's OK (I don't really like to use string-append, but it shortens the length of lines). What do you think? --MP_/V1DtyWh.gZFLZ2wD6I1==sK Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0007-gnu-Add-java-modello-core.patch =46rom 5b1ecd2d2c451d3aba05eb9647bff39574b02e4f Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Sat, 10 Feb 2018 22:51:17 +0100 Subject: [PATCH 07/12] gnu: Add java-modello-core. * gnu/packages/java.scm (java-modello-core): New variable. --- gnu/packages/java.scm | 63 +++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 63 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index a274055a5..6288a2a63 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2814,6 +2814,69 @@ a default implementation of it. This API is about s= canning files in a project and determining what files need to be rebuilt.") (license license:asl2.0))) =20 +(define-public java-modello-core + (package + (name "java-modello-core") + (version "1.9.1") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/codehaus-plexus/mode= llo" + "/archive/modello-" version ".tar.gz")) + (sha256 + (base32 + "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh")))) + (build-system ant-build-system) + (arguments + `(#:jar-name "modello-core.jar" + #:source-dir "modello-core/src/main/java" + #:test-dir "modello-core/src/test" + #:main-class "org.codehaus.modello.ModelloCli" + #:jdk ,icedtea-8 + #:phases + (modify-phases %standard-phases + (add-before 'build 'copy-resources + (lambda _ + (mkdir-p "build/classes/META-INF/plexus") + (copy-file "modello-core/src/main/resources/META-INF/plexus/c= omponents.xml" + "build/classes/META-INF/plexus/components.xml") + #t)) + (add-before 'check 'fix-tests + (lambda _ + (with-directory-excursion "modello-core/src/test/java/org/cod= ehaus" + (substitute* '("modello/core/DefaultModelloCoreTest.java" + "modello/core/io/ModelReaderTest.java") + (("src/test") "modello-core/src/test"))) + #t))))) + (inputs + `(("java-plexus-utils" ,java-plexus-utils) + ("java-plexus-container-default" ,java-plexus-container-default) + ("java-sisu-build-api" ,java-sisu-build-api))) + (native-inputs + `(("java-junit" ,java-junit) + ("java-plexus-classworlds" ,java-plexus-classworlds) + ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) + ("java-guava" ,java-guava))) + (home-page "http://codehaus-plexus.github.io/modello/") + (synopsis "Framework for code generation from a simple model") + (description "Modello is a framework for code generation from a simple= model. + +Modello generates code from a simple model format: based on a plugin +architecture, various types of code and descriptors can be generated from = the +single model, including Java POJOs, XML/JSON/YAML marshallers/unmarshaller= s, +XSD and documentation.") + (license (list + license:expat + ;; Although this package uses only files licensed under exp= at, + ;; other parts of the source are licensed under different + ;; licenses. We include them to be inherited by other pack= ages. + license:asl2.0 + ;; Some files in modello-plugin-java are licensed under a + ;; 5-clause BSD license. + (license:non-copyleft + (string-append "file:///modello-plugins/modello-plugin-ja= va/" + "src/main/java/org/codehaus/modello/plugin= /" + "java/javasource/JNaming.java")))))) + (define-public java-asm (package (name "java-asm") --=20 2.16.2 --MP_/V1DtyWh.gZFLZ2wD6I1==sK-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 16:20:23 2018 Received: (at 30417) by debbugs.gnu.org; 24 Feb 2018 21:20:23 +0000 Received: from localhost ([127.0.0.1]:59092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ephEx-0006ek-6y for submit@debbugs.gnu.org; Sat, 24 Feb 2018 16:20:23 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ephEt-0006ea-Dp for 30417@debbugs.gnu.org; Sat, 24 Feb 2018 16:20:15 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 56FAF20930; Sat, 24 Feb 2018 16:20:15 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 24 Feb 2018 16:20:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=jpfFLxUWfohWDXzVPbOpggqBOG21JIKVBjKOxpteLnA=; b=cfPvOEXy TYOJ4AcbMmog+3+jmDp8oM12OF7eDmdgksCrmx8QYKRVEuExbB4xzjGUXne1shWa uWrZYzB0L+BvJ2+5B54BT9Yo7Ng7sY+mFsvGZuzQEeKbTQf5hpOThQUainLgQ6zw zmH8OwEZnBphqukVl51pzpFRR77wLxiHAyJTQVCiw7aV3t79gftdCSOdikDHaSxB juIrVXcR29EAYkAENF4GY5EgX2FONb6FPUjGWECfyXXibaULp/DchC2e501UUOOF /iXUyaldcWDAdt4xbUp+IwpdkynNzicETG2C2Edj+MmjCWAyvAJew0e7MXazMoyM fAagL/T4Y+sjlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=jpfFLxUWfohWDXzVPbOpggqBOG21J IKVBjKOxpteLnA=; b=WdYWVYEGRgZOpG658n7fYwSL53SkjNtn8F2OOfH1IyiZo jO+Ng5qnl25Gz2kg07X6spQvwYqoziQ1qZB0ezl/qr9n5d4dt1EeBk8ULGp/3zLV Pxcxd17sLKgsae99rl62P+kbX+nuazATv1fn7qOuHJapIIloxA9jI+cxd6slr11j KTK3afG/IvdeKHW0wK+xaaN8i1w71fFaT6eap9i5ET4e18hPgzb0x4ghyISI2wu+ bNOT8vhdAJ01HmnEyfNPzuoE+epk3/rcyuOXEqgJzZNDs0/za0HWrGF2LAkwMdad WxJKZXwUJtKoEcHqyrjku5ldQjT/oca1YW61sawbQ== X-ME-Sender: Received: from localhost (cm-84.214.173.174.getinternet.no [84.214.173.174]) by mail.messagingengine.com (Postfix) with ESMTPA id E474D247E8; Sat, 24 Feb 2018 16:20:14 -0500 (EST) From: Marius Bakke To: Julien Lepiller , 30417@debbugs.gnu.org Subject: Re: [bug#30417] [PATCH 06/11] gnu: Add java-modello-core. In-Reply-To: <20180224221108.63006124@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-6-julien@lepiller.eu> <20180214212225.07b5d25b@alma-ubu> <20180214225638.374d098f@lepiller.eu> <20180216201637.73fe7c9c@alma-ubu> <878tbrveok.fsf@fastmail.com> <20180224221108.63006124@lepiller.eu> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Sat, 24 Feb 2018 22:20:13 +0100 Message-ID: <87o9ke84qa.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30417 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien Lepiller writes: > Le Sat, 17 Feb 2018 16:06:19 +0100, > Marius Bakke a =C3=A9crit : > >> Bj=C3=B6rn H=C3=B6fling writes: >>=20 >> > On Wed, 14 Feb 2018 22:56:38 +0100 >> > Julien Lepiller wrote: >> >> We don't have anything for that license. I've seen it in some other >> >> java packages, and I used (non-copyleft "file:///LICENSE.txt"), >> >> except this time, LICENSE.txt contains only the expat license. The >> >> files that have this license are also licensed under the expat >> >> license. Is it OK to declare only the expat license here, as it is >> >> the only one in LICENSE.txt?=20=20 >> > >> > >> > I'm not a license expert. Has anyone else a opinion on that?=20=20 >>=20 >> I haven't checked, but if these source files are not part of the >> installed product (e.g. they are only used for tests, or optional >> plugins/features), AFAIU we don't need to list them in the >> (license ...) field. >>=20 >> But please add a comment about them regardless. > > I've addressed all the comments in other packages, but this one > remains. Here is what I did. Do you think it's OK (I don't really like > to use string-append, but it shortens the length of lines). What do you > think? LGTM. > From 5b1ecd2d2c451d3aba05eb9647bff39574b02e4f Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sat, 10 Feb 2018 22:51:17 +0100 > Subject: [PATCH 07/12] gnu: Add java-modello-core. > > * gnu/packages/java.scm (java-modello-core): New variable. > --- > gnu/packages/java.scm | 63 +++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 63 insertions(+) > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index a274055a5..6288a2a63 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2814,6 +2814,69 @@ a default implementation of it. This API is about= scanning files in a > project and determining what files need to be rebuilt.") > (license license:asl2.0))) >=20=20 > +(define-public java-modello-core > + (package > + (name "java-modello-core") > + (version "1.9.1") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/codehaus-plexus/mo= dello" > + "/archive/modello-" version ".tar.gz")) > + (sha256 > + (base32 > + "0l2pvns8pmlrmjm3iknp7gpg3654y1m8qhy55b19sdwdchdcyxfh"))= )) > + (build-system ant-build-system) > + (arguments > + `(#:jar-name "modello-core.jar" > + #:source-dir "modello-core/src/main/java" > + #:test-dir "modello-core/src/test" > + #:main-class "org.codehaus.modello.ModelloCli" > + #:jdk ,icedtea-8 > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'copy-resources > + (lambda _ > + (mkdir-p "build/classes/META-INF/plexus") > + (copy-file "modello-core/src/main/resources/META-INF/plexus= /components.xml" > + "build/classes/META-INF/plexus/components.xml") > + #t)) > + (add-before 'check 'fix-tests > + (lambda _ > + (with-directory-excursion "modello-core/src/test/java/org/c= odehaus" > + (substitute* '("modello/core/DefaultModelloCoreTest.java" > + "modello/core/io/ModelReaderTest.java") > + (("src/test") "modello-core/src/test"))) > + #t))))) > + (inputs > + `(("java-plexus-utils" ,java-plexus-utils) > + ("java-plexus-container-default" ,java-plexus-container-default) > + ("java-sisu-build-api" ,java-sisu-build-api))) > + (native-inputs > + `(("java-junit" ,java-junit) > + ("java-plexus-classworlds" ,java-plexus-classworlds) > + ("java-geronimo-xbean-reflect" ,java-geronimo-xbean-reflect) > + ("java-guava" ,java-guava))) > + (home-page "http://codehaus-plexus.github.io/modello/") > + (synopsis "Framework for code generation from a simple model") > + (description "Modello is a framework for code generation from a simp= le model. > + > +Modello generates code from a simple model format: based on a plugin > +architecture, various types of code and descriptors can be generated fro= m the > +single model, including Java POJOs, XML/JSON/YAML marshallers/unmarshall= ers, > +XSD and documentation.") > + (license (list > + license:expat > + ;; Although this package uses only files licensed under e= xpat, > + ;; other parts of the source are licensed under different > + ;; licenses. We include them to be inherited by other pa= ckages. > + license:asl2.0 > + ;; Some files in modello-plugin-java are licensed under a > + ;; 5-clause BSD license. > + (license:non-copyleft > + (string-append "file:///modello-plugins/modello-plugin-= java/" > + "src/main/java/org/codehaus/modello/plug= in/" > + "java/javasource/JNaming.java")))))) > + > (define-public java-asm > (package > (name "java-asm") > --=20 > 2.16.2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqR1w0ACgkQoqBt8qM6 VPoJ0AgA0QT3GI4x4SXCOhm5RcqEFDjd9ZSs0tJMhtyT0zAFFxhcWNvPLPoQySlG 5hdx88uILiSdqT6NIVRYZytboQaJ4d0R2faYiAeaJ+Ku03uQgtMgSnTBKwbmMwEn U7gOc5ltEBVz5LabmwKuk7+zxJ1Ch0lbOdiZzKetoWErDc/5EHrjJNqZypd+iTPn ytGo6Cek8CRSoiXQ9kn3+BgDOH2q0QXQEFlwDBAnLKvS9l7AFjYL8ICNjwhp/CTd 2trzD/oj1UvYKisub7LmstJ3i03DeRO72toI789Qgc/ZP4VJB/bnQuzl0lMqlSae YeicWRj9tIbDE690cmbv8x/X4RbbUg== =cvZ7 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 06:08:44 2018 Received: (at 30417-done) by debbugs.gnu.org; 25 Feb 2018 11:08:44 +0000 Received: from localhost ([127.0.0.1]:59424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epuAe-0002eE-Kj for submit@debbugs.gnu.org; Sun, 25 Feb 2018 06:08:44 -0500 Received: from lepiller.eu ([89.234.186.109]:50654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epuAc-0002e4-GN for 30417-done@debbugs.gnu.org; Sun, 25 Feb 2018 06:08:43 -0500 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id f945ce02 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <30417-done@debbugs.gnu.org>; Sun, 25 Feb 2018 11:10:14 +0000 (UTC) Date: Sun, 25 Feb 2018 12:08:36 +0100 From: Julien Lepiller To: 30417-done@debbugs.gnu.org Subject: Re: [bug#30417] [PATCH] java-plexus and java-modello Message-ID: <20180225120836.12e4d6bc@lepiller.eu> In-Reply-To: <20180210234811.40ddec07@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30417-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Le Sat, 10 Feb 2018 23:48:11 +0100, Julien Lepiller a =C3=A9crit : > Hi, this patch series adds more java packages required by maven. We're > almost there: only ~50 packages (including maven) left after these > ones. Pushed as 0aa85081d6319b582d53e9113be41cbe1a59f2a8. Thank you for your review! From unknown Sat Sep 13 05:21:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Mar 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator