Subject: Re: [bug#30417] [PATCH 10/11] gnu: Add java-modello-plugins-xpp3.

From: Björn Höfling <[email-masked]>
Date: Wed, 14 Feb 2018 21:43:19 +0100

On Sun, 11 Feb 2018 00:04:37 +0100
Julien Lepiller <[email-masked]> wrote:

> gnu/packages/java.scm (java-modello-plugins-xpp3): New variable.
> ---
>  gnu/packages/java.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 18ba46c5c..758665df9 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2924,6 +2924,34 @@ XSD and documentation.")
>         ("java-plexus-compiler-javac" ,java-plexus-compiler-javac)
>         ("java-plexus-container-default" ,java-plexus-container-default)))))
>  
> +(define-public java-modello-plugins-xpp3
> +  (package
> +    (inherit java-modello-core)
> +    (name "java-modello-plugins-xpp3")
> +    (arguments
> +     `(#:jar-name "modello-plugins-xpp3.jar"
> +       #:source-dir
> "modello-plugins/modello-plugin-xpp3/src/main/java"
> +       #:test-dir "modello-plugins/modello-plugin-xpp3/src/test"

The following line is too long:

> +       #:tests? #f; I can find some of its dependencies, for
> instance
> org.codehaus.modello.test.features.io.xpp3.ModelloFeaturesTestXpp3Reader

Did you really mean "I can find" or did you mean the opposite: "I can't
find"? I would expect here reasons of why the tests are NOT executable.

> +       #:jdk ,icedtea-8
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'copy-resources
> +           (lambda _
> +             (mkdir-p "build/classes")
> +             (copy-recursively
> "modello-plugins/modello-plugin-xpp3/src/main/resources"
> +                               "build/classes")
> +             #t)))))
> +    (inputs
> +     `(("java-modello-core" ,java-modello-core)
> +       ("java-modello-plugins-java" ,java-modello-plugins-java)
> +       ("java-modello-plugins-xml" ,java-modello-plugins-xml)
> +       ,@(package-inputs java-modello-core)))
> +    (native-inputs
> +     `(("java-xmlunit" ,java-xmlunit)
> +       ("java-modello-test" ,java-modello-test)
> +       ,@(package-native-inputs java-modello-core)))))
> +
>  (define-public java-asm
>    (package
>      (name "java-asm")

License, description, synopsis: See java-modello-plugins-java.

Björn