Subject: Re: [bug#30417] [PATCH 07/11] gnu: Add java-modello-plugins-java.

From: Björn Höfling <[email-masked]>
Date: Wed, 14 Feb 2018 21:34:02 +0100

On Sun, 11 Feb 2018 00:04:34 +0100
Julien Lepiller <[email-masked]> wrote:

> * gnu/packages/java.scm (java-modello-plugins-java): New variable.
> ---
>  gnu/packages/java.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index d75960831..76a586a98 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2861,6 +2861,28 @@ single model, including Java POJOs,
> XML/JSON/YAML marshallers/unmarshallers, XSD and documentation.")
>      (license license:asl2.0)))
>  
> +(define-public java-modello-plugins-java
> +  (package
> +    (inherit java-modello-core)
> +    (name "java-modello-plugins-java")
> +    (arguments
> +     `(#:jar-name "modello-plugins-java.jar"
> +       #:source-dir
> "modello-plugins/modello-plugin-java/src/main/java"
> +       #:test-dir "modello-plugins/modello-plugin-java/src/test"
> +       #:jdk ,icedtea-8
> +       #:tests? #f; requires maven-model, which depends on this
> package
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'copy-resources
> +           (lambda _
> +             (mkdir-p "build/classes")
> +             (copy-recursively
> "modello-plugins/modello-plugin-java/src/main/resources"
> +                               "build/classes")
> +             #t)))))
> +    (inputs
> +     `(("java-modello-core" ,java-modello-core)
> +       ,@(package-inputs java-modello-core)))))
> +
>  (define-public java-asm
>    (package
>      (name "java-asm")

License: This is again a mixture of ASL and "5-clause-BSD" like in
./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/plugin/java/javasource/JModifiers.java

Compare with comments in java-modello-core.

Synopsys and Description are inherited from java-modello-core but
should be specialized here.

Otherwise, LGTM.

Björn