Subject: Re: [bug#30417] [PATCH 01/11] gnu: Add java-plexus-component-annotations.

From: Björn Höfling <[email-masked]>
Date: Mon, 12 Feb 2018 00:36:01 +0100

On Sun, 11 Feb 2018 00:04:28 +0100
Julien Lepiller <[email-masked]> wrote:

> * gnu/packages/java.scm (java-plexus-component-annotations): New
> variable.
> ---
>  gnu/packages/java.scm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index e714a031c..b7f3fd54e 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2662,6 +2662,17 @@ archives (jar).")
>       `(("archiver" ,java-plexus-archiver)
>         ("hamcrest" ,java-hamcrest-core)))))
>  
> +(define-public java-plexus-component-annotations
> +  (package
> +    (inherit java-plexus-container-default)
> +    (name "java-plexus-component-annotations")
> +    (arguments
> +     `(#:jar-name "plexus-component-annotations.jar"
> +       #:source-dir "plexus-component-annotations/src/main/java"
> +       #:tests? #f)); no tests
> +    (inputs '())
> +    (native-inputs '())))
> +
>  (define-public java-asm
>    (package
>      (name "java-asm")

* This one inherits java-plexus-container-default, but does not adapt
synopsis/description. Is that OK?

* Sorry for being so late, but I also looked into the
  java-plexus-container-default-bootstrap: It contains some jar's in
  the test path. Is that OK?

find . -name "*.jar"
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-a-2.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/plexus-archiver-1.0-alpha-8.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-c-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/plugin1-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-b-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/component-a-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/test-components/plugin0-1.0-SNAPSHOT.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/c.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/b.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/d.jar
./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/test/resources/jar-repository/a.jar

* We have a java-plexus-container-default and
  java-plexus-container-default-bootstrap. Both are "define-public".
  Should we make the bootstrap non-public?

Otherwise, LGTM.

And even though I have my comments, thanks for all this
awesome Java/Maven work!

Björn