Subject: Re: [bug#30404] [PATCH] Add cat-avatar-generator-service.

From: Julien Lepiller <[email-masked]>
Date: Fri, 9 Feb 2018 23:48:32 +0100

Le Fri, 09 Feb 2018 23:19:17 +0100,
[email-masked] (Ludovic Courtès) a écrit :

> Julien Lepiller <[email-masked]> skribis:
> 
> > By the way, if you don't know the author of this package, he's
> > awesome: https://www.peppercarrot.com/  
> 
> Looks very nice indeed!
> 
> > From 5375bd9633cb37b3f26d16742fdc451f3296f723 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <[email-masked]>
> > Date: Fri, 12 Jan 2018 23:08:50 +0100
> > Subject: [PATCH 1/2] gnu: Add cat-avatar-generator.
> >
> > * gnu/packages/web.scm (cat-avatar-generator): New variable.  
> 
> LGTM.
> 
> > From b5e362ac44bf3bd284ba14e886960311b67a4019 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <[email-masked]>
> > Date: Fri, 12 Jan 2018 23:14:14 +0100
> > Subject: [PATCH 2/2] gnu: Add cat-avatar-generator-service.
> >
> > * gnu/services/web.scm (cat-avatar-generator-service): New
> > variable.  
> 
> [...]
> 
> > +(define* (cat-avatar-generator-service
> > +           #:key
> > +           (cache-dir "/var/cache/cat-avatar-generator")
> > +           (configuration (nginx-server-configuration)))
> > +  (simple-service 'cat-http-server nginx-service-type
> > +    (list (nginx-server-configuration  
> 
> Normally the 3rd argument would be aligned with the 1st here.
I don't understand that comment... What should be aligned exactly?

> 
> You’ll hate me for asking that, but could you add a couple of lines to
> the manual about this service?
Sure, I'll do that :)

> Otherwise LGTM!
> Thanks,
> Ludo’.