GNU bug report logs - #30404
[PATCH] Add cat-avatar-generator-service.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30404 in the body.
You can then email your comments to 30404 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add cat-avatar-generator-service.
Date: Fri, 9 Feb 2018 21:44:09 +0100

[Message part 1 (text/plain, inline)]

Hi, attached is a simple and cute package :)

It's a simple service that uses the nginx service and the php
integration.

By the way, if you don't know the author of this package, he's awesome:
https://www.peppercarrot.com/

[0001-gnu-Add-cat-avatar-generator.patch (text/x-patch, attachment)]

[0002-gnu-Add-cat-avatar-generator-service.patch (text/x-patch, attachment)]

Message #8 received at 30404 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 30404 <at> debbugs.gnu.org
Subject: Re: [bug#30404] [PATCH] Add cat-avatar-generator-service.
Date: Fri, 09 Feb 2018 23:19:17 +0100

Julien Lepiller <julien <at> lepiller.eu> skribis:

> By the way, if you don't know the author of this package, he's awesome:
> https://www.peppercarrot.com/

Looks very nice indeed!

> From 5375bd9633cb37b3f26d16742fdc451f3296f723 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Fri, 12 Jan 2018 23:08:50 +0100
> Subject: [PATCH 1/2] gnu: Add cat-avatar-generator.
>
> * gnu/packages/web.scm (cat-avatar-generator): New variable.

LGTM.

> From b5e362ac44bf3bd284ba14e886960311b67a4019 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Fri, 12 Jan 2018 23:14:14 +0100
> Subject: [PATCH 2/2] gnu: Add cat-avatar-generator-service.
>
> * gnu/services/web.scm (cat-avatar-generator-service): New variable.

[...]

> +(define* (cat-avatar-generator-service
> +           #:key
> +           (cache-dir "/var/cache/cat-avatar-generator")
> +           (configuration (nginx-server-configuration)))
> +  (simple-service 'cat-http-server nginx-service-type
> +    (list (nginx-server-configuration

Normally the 3rd argument would be aligned with the 1st here.

You’ll hate me for asking that, but could you add a couple of lines to
the manual about this service?

Otherwise LGTM!

Thanks,
Ludo’.

Message #11 received at 30404 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 30404 <at> debbugs.gnu.org
Subject: Re: [bug#30404] [PATCH] Add cat-avatar-generator-service.
Date: Fri, 9 Feb 2018 23:48:32 +0100

Le Fri, 09 Feb 2018 23:19:17 +0100,
ludo <at> gnu.org (Ludovic Courtès) a écrit :

> Julien Lepiller <julien <at> lepiller.eu> skribis:
> 
> > By the way, if you don't know the author of this package, he's
> > awesome: https://www.peppercarrot.com/  
> 
> Looks very nice indeed!
> 
> > From 5375bd9633cb37b3f26d16742fdc451f3296f723 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien <at> lepiller.eu>
> > Date: Fri, 12 Jan 2018 23:08:50 +0100
> > Subject: [PATCH 1/2] gnu: Add cat-avatar-generator.
> >
> > * gnu/packages/web.scm (cat-avatar-generator): New variable.  
> 
> LGTM.
> 
> > From b5e362ac44bf3bd284ba14e886960311b67a4019 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien <at> lepiller.eu>
> > Date: Fri, 12 Jan 2018 23:14:14 +0100
> > Subject: [PATCH 2/2] gnu: Add cat-avatar-generator-service.
> >
> > * gnu/services/web.scm (cat-avatar-generator-service): New
> > variable.  
> 
> [...]
> 
> > +(define* (cat-avatar-generator-service
> > +           #:key
> > +           (cache-dir "/var/cache/cat-avatar-generator")
> > +           (configuration (nginx-server-configuration)))
> > +  (simple-service 'cat-http-server nginx-service-type
> > +    (list (nginx-server-configuration  
> 
> Normally the 3rd argument would be aligned with the 1st here.
I don't understand that comment... What should be aligned exactly?

> 
> You’ll hate me for asking that, but could you add a couple of lines to
> the manual about this service?
Sure, I'll do that :)

> 
> Otherwise LGTM!
> 
> Thanks,
> Ludo’.

Message #14 received at 30404 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 30404 <at> debbugs.gnu.org
Subject: Re: [bug#30404] [PATCH] Add cat-avatar-generator-service.
Date: Wed, 14 Feb 2018 20:20:11 +0100

Heya!

Julien Lepiller <julien <at> lepiller.eu> skribis:

> Le Fri, 09 Feb 2018 23:19:17 +0100,
> ludo <at> gnu.org (Ludovic Courtès) a écrit :

[...]

>> > +(define* (cat-avatar-generator-service
>> > +           #:key
>> > +           (cache-dir "/var/cache/cat-avatar-generator")
>> > +           (configuration (nginx-server-configuration)))
>> > +  (simple-service 'cat-http-server nginx-service-type
>> > +    (list (nginx-server-configuration  
>> 
>> Normally the 3rd argument would be aligned with the 1st here.
> I don't understand that comment... What should be aligned exactly?

The lines above should be like this:

  (simple-service 'cat-http-server nginx-service-type
                  (list (nginx-server-configuration


(Here (list …) is the 3rd argument to ‘simple-service’.)

No big deal though.  :-)

Thanks,
Ludo’.

Message #19 received at 30404-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 30404-done <at> debbugs.gnu.org
Subject: Re: [bug#30404] [PATCH] Add cat-avatar-generator-service.
Date: Wed, 14 Feb 2018 23:20:52 +0100

Pushed as 3bedac50571204643d5e3b204dc720ae7d571a1f and
08da664d1041133e8282a5df0fcab6eee7e548fa. Thanks!

Le Wed, 14 Feb 2018 20:20:11 +0100,
ludo <at> gnu.org (Ludovic Courtès) a écrit :

> Heya!
> 
> Julien Lepiller <julien <at> lepiller.eu> skribis:
> 
> > Le Fri, 09 Feb 2018 23:19:17 +0100,
> > ludo <at> gnu.org (Ludovic Courtès) a écrit :  
> 
> [...]
> 
> >> > +(define* (cat-avatar-generator-service
> >> > +           #:key
> >> > +           (cache-dir "/var/cache/cat-avatar-generator")
> >> > +           (configuration (nginx-server-configuration)))
> >> > +  (simple-service 'cat-http-server nginx-service-type
> >> > +    (list (nginx-server-configuration    
> >> 
> >> Normally the 3rd argument would be aligned with the 1st here.  
> > I don't understand that comment... What should be aligned exactly?  
> 
> The lines above should be like this:
> 
>   (simple-service 'cat-http-server nginx-service-type
>                   (list (nginx-server-configuration
> 
> 
> (Here (list …) is the 3rd argument to ‘simple-service’.)
> 
> No big deal though.  :-)
> 
> Thanks,
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.