From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 08 18:09:42 2018 Received: (at submit) by debbugs.gnu.org; 8 Feb 2018 23:09:42 +0000 Received: from localhost ([127.0.0.1]:34462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejvJy-0000jo-8R for submit@debbugs.gnu.org; Thu, 08 Feb 2018 18:09:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejvJv-0000jZ-0J for submit@debbugs.gnu.org; Thu, 08 Feb 2018 18:09:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejvJo-0000DZ-4U for submit@debbugs.gnu.org; Thu, 08 Feb 2018 18:09:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ejvJn-0000DJ-VM for submit@debbugs.gnu.org; Thu, 08 Feb 2018 18:09:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejvJm-0000qq-3t for guix-patches@gnu.org; Thu, 08 Feb 2018 18:09:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejvJh-0008Uw-Uv for guix-patches@gnu.org; Thu, 08 Feb 2018 18:09:26 -0500 Received: from mout.gmx.net ([212.227.17.21]:60517) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejvJh-0008Uf-G1 for guix-patches@gnu.org; Thu, 08 Feb 2018 18:09:21 -0500 Received: from labiere ([80.229.147.137]) by mail.gmx.com (mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MLR30-1ekTXx2Qi2-000cDm for ; Fri, 09 Feb 2018 00:09:19 +0100 From: Pierre Langlois To: guix-patches@gnu.org Subject: [PATCH] gnu: clementine: Remove Spotify downloader. Date: Thu, 08 Feb 2018 23:09:19 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:s7wzis5qsPwwj2vJr0YtnN25YWxB9vM+91EtrfHjHb5jNppUKZJ 6kTXi2CAAaBB0y9z4RNvX44t0rWft0Tn6YBEa/qY2toe0eF86Mn5VwLHGfrrlbSDZF7Vbeb aIdZVZrG2DGMQRtmZpmRRKX8s4kVmyBFLoHtuFxvsi+KAJP4FMzfjePZ/kSO+jWuAX8Wgn5 Hhyrr4mwDpkpAozfdi91Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:qteSfqxzEs0=:rUeS2Ygdq06xEGqfNerQaD zb2oOHQS7OQupesG/DAPqBGD7AM7/cvM9v4gdVRIfBemb5h9azJ5HJ9FdY7Ah6bcyWWJ/twxy 6M1lzM/U9EAQrFO9pFXD4/NzWCJnrefUIrJtmQxbb+ue96tVvH8uY7bCDdDnxAlVBho2h5YkB KuZqxIHOJevuY2xheCt+xeFrBOXE72htb1sTMTNaVaqtUn1TpBEN6uWqfISrGHqgeFNxSRKge oT1aYOEFOuPmi63v3j7VK7BWpc5EQiJ5w+TaljfXmTgpVArJUttIbEV3GB405OUCCUuQwXATO cfjwlnDaDtBHRoDydsmVdkHU3GP+Xge102Wdxs1JrA5u+ggy7vqOrRYK4grHdCF/efqqM56rL fk5u+UMPtf6rYbRYkmTnxKtscSga1bHYyHyQ1FSxm+2MAUse9A1nsaLKndhR4PTVXU1P/sQ1+ fEGeZQfoAScgVkyY11J3GchIz7o+Us8Q7JO3zYmcNT629L3rgwVlfQRoZVjEOfKgRzPYE4Ix+ 4xDycBi6iS3C/Zl2TvOINwMdyP+wLGdDHOleITChtyzhe+bpZ5WRR7dDecv9+JKipyKoJH29l WS5VuaffQvZjICxFcDUvbMdA5mWgpnOZhqNAntRaQJ1+uuAG+7vJXcqNDVqtmJOMUN282ASj0 QTE5WUU69ptBHdxFlnNa5VKVdlv3ErrG6NlM0nIqsj13PfOA7C7DeoxKBeFZ3jKC2D+vp5V5k EUIGuNTFXA+CUciekYxIubs2BiHTycK+J2BoJqWLiC4+niSZS8YMrzeY+oiT0y7tD8agmMXzQ z15RFe9G9GwZTa15dSBtb+p7wQCuQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain Hi Guix! I realized today that a new version of crypto++ was out so I set out to update it but Clementine failed to compile. There's a patch on master [0] that fixes the issue so I was going to apply it when I realized the bit of code in question downloads a binary blob to support Spotify. It turns out there's a button in the preference menu that allows users to download this proprietary blob, and crypto++ appears to be used to check it. So I thought that rather than apply the patch, we should probably remove support for this download button all together. There is a flag that allows not compiling "spotifyblobdownloader.cpp". Also, this was also the only place in the codebase that used crypto++ so we can drop this input. What do you think? [0]: https://github.com/clementine-player/Clementine/commit/38c1f8777cecc7b2f91fecbcc48c41479839304b.patch --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-clementine-Remove-Spotify-downloader.patch >From 63d16f402b1c756a650f5f6bad15b4818c747bf1 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Thu, 8 Feb 2018 22:03:36 +0000 Subject: [PATCH 1/2] gnu: clementine: Remove Spotify downloader. Clementine has a button in the preference menu that allows downloading a binary blob to add support for Spofify. Let's remove this button. It turns out this is the only part of the code base that uses crypto++, let's remove this dependency too. * gnu/packages/music.scm (clementine)[arguments]: Remove crypto++ support. Set HAVE_SPOTIFY_DOWNLOADER to FALSE. [inputs]: Remove crypto++ input. * gnu/packages/patches/clementine-remove-crypto++-dependency.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 1 + gnu/packages/music.scm | 15 +++++---------- .../clementine-remove-crypto++-dependency.patch | 19 +++++++++++++++++++ 3 files changed, 25 insertions(+), 10 deletions(-) create mode 100644 gnu/packages/patches/clementine-remove-crypto++-dependency.patch diff --git a/gnu/local.mk b/gnu/local.mk index 2ef483df0..06e78c2f5 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -579,6 +579,7 @@ dist_patch_DATA = \ %D%/packages/patches/chmlib-inttypes.patch \ %D%/packages/patches/clang-libc-search-path.patch \ %D%/packages/patches/clang-3.8-libc-search-path.patch \ + %D%/packages/patches/clementine-remove-crypto++-dependency.patch \ %D%/packages/patches/clementine-use-openssl.patch \ %D%/packages/patches/clisp-remove-failing-test.patch \ %D%/packages/patches/clucene-pkgconfig.patch \ diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 2db8ffea3..c66e2c488 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -226,18 +226,14 @@ score, keyboard, guitar, drum and controller views.") "sha2" ;; Replaced by openssl. "taglib" "tinysvcmdns"))) - (patches (search-patches "clementine-use-openssl.patch")))) + (patches (search-patches "clementine-use-openssl.patch" + "clementine-remove-crypto++-dependency.patch")))) (build-system cmake-build-system) (arguments '(#:test-target "clementine_test" - #:configure-flags - (let ((crypto (assoc-ref %build-inputs "crypto++"))) - (list "-DENABLE_VISUALISATIONS=OFF" ; requires unpackaged "projectm" - "-DCRYPTOPP_FOUND=TRUE" - (string-append "-DCRYPTOPP_INCLUDE_DIRS=" crypto "/include") - (string-append "-DCRYPTOPP_LIBRARY_DIRS=" crypto "/lib") - (string-append "-DCRYPTOPP_LIBRARIES=" crypto "/lib/libcryptopp.a") - "-DUSE_SYSTEM_SHA2=TRUE")) + #:configure-flags (list "-DENABLE_VISUALISATIONS=OFF" ; requires unpackaged "projectm" + "-DHAVE_SPOTIFY_DOWNLOADER=FALSE" + "-DUSE_SYSTEM_SHA2=TRUE") #:phases (modify-phases %standard-phases (add-after 'install 'wrap-program @@ -254,7 +250,6 @@ score, keyboard, guitar, drum and controller views.") (inputs `(("boost" ,boost) ("chromaprint" ,chromaprint) - ("crypto++" ,crypto++) ("fftw" ,fftw) ("glib" ,glib) ("glu" ,glu) diff --git a/gnu/packages/patches/clementine-remove-crypto++-dependency.patch b/gnu/packages/patches/clementine-remove-crypto++-dependency.patch new file mode 100644 index 000000000..e7cf80dde --- /dev/null +++ b/gnu/packages/patches/clementine-remove-crypto++-dependency.patch @@ -0,0 +1,19 @@ +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 3202b8b..473ecb9 100755 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -279,14 +279,6 @@ optional_component(LIBPULSE ON "Pulse audio integration" + + optional_component(VISUALISATIONS ON "Visualisations") + +-if(NOT HAVE_SPOTIFY_BLOB AND NOT CRYPTOPP_FOUND) +- message(FATAL_ERROR "Either crypto++ must be available or the non-GPL Spotify " +- "code must be compiled in") +-elseif(CRYPTOPP_FOUND) +- set(HAVE_CRYPTOPP ON) +- set(HAVE_SPOTIFY_DOWNLOADER ON) +-endif() +- + # Find DBus if it's enabled + if (HAVE_DBUS) + find_package(Qt5 COMPONENTS DBus) -- 2.16.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-gnu-crypto-Update-to-6.0.0.patch Content-Transfer-Encoding: 8bit >From 9d9b90882491ff2ebf6f3a3580d4d7dbcdf57c72 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Thu, 8 Feb 2018 09:57:41 +0000 Subject: [PATCH 2/2] gnu: crypto++: Update to 6.0.0. * gnu/packages/crypto.scm (crypto++): Update to 6.0.0. * gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch: Delete file. * gnu/local.mk (dist_patch_DATA): Remove it. --- gnu/local.mk | 1 - gnu/packages/crypto.scm | 6 +- .../crypto++-fix-dos-in-asn.1-decoders.patch | 65 ---------------------- 3 files changed, 2 insertions(+), 70 deletions(-) delete mode 100644 gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch diff --git a/gnu/local.mk b/gnu/local.mk index 06e78c2f5..88d55964e 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -598,7 +598,6 @@ dist_patch_DATA = \ %D%/packages/patches/crawl-upgrade-saves.patch \ %D%/packages/patches/crda-optional-gcrypt.patch \ %D%/packages/patches/crossmap-allow-system-pysam.patch \ - %D%/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch \ %D%/packages/patches/clucene-contribs-lib.patch \ %D%/packages/patches/cube-nocheck.patch \ %D%/packages/patches/cursynth-wave-rand.patch \ diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm index e616c9223..a3a28fed0 100644 --- a/gnu/packages/crypto.scm +++ b/gnu/packages/crypto.scm @@ -581,7 +581,7 @@ data on your platform, so the seed itself will be as random as possible. (define-public crypto++ (package (name "crypto++") - (version "5.6.5") + (version "6.0.0") (source (origin (method url-fetch/zipbomb) (uri (string-append "https://cryptopp.com/cryptopp" @@ -589,9 +589,7 @@ data on your platform, so the seed itself will be as random as possible. ".zip")) (sha256 (base32 - "0d1cqdz369ivi082k59025wvxzywvkizw7i0pf5h0a1izs3g8pm7")) - (patches - (search-patches "crypto++-fix-dos-in-asn.1-decoders.patch")))) + "1nidm6xbdza5cbgf5md2zznmaq692rfyjasycwipl6rzdfwjvb34")))) (build-system gnu-build-system) (arguments `(#:make-flags diff --git a/gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch b/gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch deleted file mode 100644 index 88b2e7f25..000000000 --- a/gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch +++ /dev/null @@ -1,65 +0,0 @@ -From 3d9181d7bdd8e491f745dbc9e34bd20b6f6da069 Mon Sep 17 00:00:00 2001 -From: Gergely Nagy -Date: Wed, 14 Dec 2016 13:19:01 +0100 -Subject: [PATCH] Fix possible DoS in ASN.1 decoders (CVE-2016-9939) - ---- - asn.cpp | 10 ++++++++++ - asn.h | 2 ++ - 2 files changed, 12 insertions(+) - -diff --git a/asn.cpp b/asn.cpp -index 297ff010..2e923ef7 100644 ---- a/asn.cpp -+++ b/asn.cpp -@@ -123,6 +123,8 @@ size_t BERDecodeOctetString(BufferedTransformation &bt, SecByteBlock &str) - size_t bc; - if (!BERLengthDecode(bt, bc)) - BERDecodeError(); -+ if (bc > bt.MaxRetrievable()) -+ BERDecodeError(); - - str.New(bc); - if (bc != bt.Get(str, bc)) -@@ -139,6 +141,8 @@ size_t BERDecodeOctetString(BufferedTransformation &bt, BufferedTransformation & - size_t bc; - if (!BERLengthDecode(bt, bc)) - BERDecodeError(); -+ if (bc > bt.MaxRetrievable()) -+ BERDecodeError(); - - bt.TransferTo(str, bc); - return bc; -@@ -161,6 +165,8 @@ size_t BERDecodeTextString(BufferedTransformation &bt, std::string &str, byte as - size_t bc; - if (!BERLengthDecode(bt, bc)) - BERDecodeError(); -+ if (bc > bt.MaxRetrievable()) -+ BERDecodeError(); - - SecByteBlock temp(bc); - if (bc != bt.Get(temp, bc)) -@@ -188,6 +194,10 @@ size_t BERDecodeBitString(BufferedTransformation &bt, SecByteBlock &str, unsigne - size_t bc; - if (!BERLengthDecode(bt, bc)) - BERDecodeError(); -+ if (bc == 0) -+ BERDecodeError(); -+ if (bc > bt.MaxRetrievable()) -+ BERDecodeError(); - - byte unused; - if (!bt.Get(unused)) -diff --git a/asn.h b/asn.h -index ed9de52c..33f0dd09 100644 ---- a/asn.h -+++ b/asn.h -@@ -498,6 +498,8 @@ void BERDecodeUnsigned(BufferedTransformation &in, T &w, byte asnTag = INTEGER, - bool definite = BERLengthDecode(in, bc); - if (!definite) - BERDecodeError(); -+ if (bc > in.MaxRetrievable()) -+ BERDecodeError(); - - SecByteBlock buf(bc); - -- 2.16.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 09 13:36:38 2018 Received: (at 30400) by debbugs.gnu.org; 9 Feb 2018 18:36:38 +0000 Received: from localhost ([127.0.0.1]:35674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekDXK-0002pH-KC for submit@debbugs.gnu.org; Fri, 09 Feb 2018 13:36:38 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekDXJ-0002pA-PO for 30400@debbugs.gnu.org; Fri, 09 Feb 2018 13:36:38 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2A2CF213F4; Fri, 9 Feb 2018 13:36:37 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Fri, 09 Feb 2018 13:36:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=J8K+85lW01bTr6CXnpIXo99EFVLGDwWEHD213ecEfJQ=; b=oGmI9 rCeqI408Feolcc0YuOWX5W08sgb4pbZihc/GdE9F834+Rt9CoOa3OT8pkrPMlNap Ql7bqYOwSGH/OgRU9k6W6ZFETUaPt+Z5yiG3ggHfZ5WXlO6Cp1O5eSssruVbVb1z wGFNnfE/N32LfD/u1e6ZvMlbfE1NgeZcecxsw0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=J8K+85lW01bTr6CXnpIXo99EFVLGD wWEHD213ecEfJQ=; b=W0X8WVhXVivKbbFiEiZREKU7zrhsY+Qz+jUZTx3zse9vO eEBYQ7fzPgMwWt9MJxmlTQ8lRieP/txu5z7qTFJXGm+MYzjILiYDktzVLBDFbl2N r8QoTSSNvA/IUkCF942gj1DXbsXR1IGrmxAwltbWO2QPG3C8WQ0UADX7jvVcVoTS e3qHTsOWmSMNI9X+TcEpOxkGwgyEjJw2Lu+fNKewTpZWZxhA6g+GFy/D86paf0eW eAUAIlqXFokMxrdPnl0D4hJD9Nbb/ykv9zYK61U2UN3NgCUztqLBBkFy/eAsGlwd cE1JY4ATVeQpFxQAgIB19X9byD6w1HX7arL5LOsCA== X-ME-Sender: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id AC1BA245F1; Fri, 9 Feb 2018 13:36:36 -0500 (EST) Date: Fri, 9 Feb 2018 13:36:35 -0500 From: Leo Famulari To: Pierre Langlois Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader. Message-ID: <20180209183635.GB2356@jasmine.lan> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NMuMz9nt05w80d4+" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30400 Cc: 30400@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --NMuMz9nt05w80d4+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote: > Hi Guix! >=20 > I realized today that a new version of crypto++ was out so I set out to > update it but Clementine failed to compile. There's a patch on master [0] > that fixes the issue so I was going to apply it when I realized the bit > of code in question downloads a binary blob to support Spotify. It > turns out there's a button in the preference menu that allows users to > download this proprietary blob, and crypto++ appears to be used to check > it. Thanks for pointing this out! I reindented the #:configure-flags and added some comments to the first patch, and pushed as af414f34fb6e3609e572880f3b0b3bbcb1b3bfc6 My understanding of the FSDG [0] makes me think that we'll need to go further and, in an origin snippet, remove the code performs the download of the non-free component. This would mean that `guix build --source clementine` would return something that follows the FSDG. CC-ing Ludo for clarification. [0] https://www.gnu.org/distros/free-system-distribution-guidelines.en.html --NMuMz9nt05w80d4+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlp96jMACgkQJkb6MLrK fwj9iA/9GWdwDPvcxTfjNsZM/z+M7kjJ0/QLtU49MqdrN7aIpvpzDTXYocMIqoMi vncs4xK+xbWQiA/fcE1hpJjIYW0wyqhwqRwb67UjeG18/rctlv12/2j1pU5ZVBFe yDppLkKe89uQaDI7xum2XRra5DiHQxuc5DK4dHSTluEO9kgFc8TE4vVcT8YBTwIX ACnW6264ub4RNXsbJB6iaLPc+szUtbxrULFISVojyxbJ9nmq/MVkNpvHcwcO3DuD /hyVDZ+5UJDDKhcopHgj8vjsPCTLIcNFx8UJ/BfM2UuYTzd0SkhBSDHvS7eSuDEu rZ64tFp6WzLL8rD6CvDKrYcwQelZb1XRzwHVgOMS1Y1et5lKyp5VT+/uey0NCELp gPPRYr/OW6tj6bx8TuIZxJBjc9K8EGe/7LoUhLHVaNCyATPdaOGtS/xGWjTVx9hY RzKefct904JcA2XULKHSFWKN7STFeK+3Uc49orInCZF5YuAjhrgMiHUHPgD8stXt fPjtrhhc50ZqUM2S84fxipQeGq8d8OQzn9hQt1LwsBRxuuQdYYlOushErCkwS2Hi oOJ3ZyrS4t3LEn4j7TM7KP5AyVz94K/Z0WHsgS4lBgO4C+yKT+bJO3dOQK/tDirB 1894Ep1LRqRLC5t7h37nb3Ld4t1SOkUqlbaITFr7plSpmtdI8F8= =8fpS -----END PGP SIGNATURE----- --NMuMz9nt05w80d4+-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 09 13:37:59 2018 Received: (at 30400) by debbugs.gnu.org; 9 Feb 2018 18:37:59 +0000 Received: from localhost ([127.0.0.1]:35679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekDYc-0002rH-VA for submit@debbugs.gnu.org; Fri, 09 Feb 2018 13:37:59 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekDYZ-0002r7-Hq for 30400@debbugs.gnu.org; Fri, 09 Feb 2018 13:37:57 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 52DD321096; Fri, 9 Feb 2018 13:37:55 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Fri, 09 Feb 2018 13:37:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=CfSZzo8hKua8tzQYOFIKidm8VTNzaNCSCA2Pe3u/pgQ=; b=q1bGo DNxvdG938DgFtTSWbR8iprHcSbDxfZS6tnYANRYNaMgmJVLW4sqh+6APwgDcNrqG x1qnJptqV+0awPlKzl0r+7gxQgXU1rNap1Ryg1ptKhZleRtl2jb2BOWT3178xh8a yCw3z42Ecgr5kOHPmRqGoFmX/rtxMdyajpcn2c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=CfSZzo8hKua8tzQYOFIKidm8VTNza NCSCA2Pe3u/pgQ=; b=U4WYlr6DPYvhnbCqrl8VsMgU33Iu/OdQPl26BvDJQsXBX fA5dc87EaYrbBH7cCJDCmviPnvMpdVLCuu0TNDkIdR2Cd2cdblh11v9iefyAGJky IOUM/mGbvjVAcktKGapb6OAvBE16iZz7u7FdUuvw1Q7Maj9PubvIIPWAk3Ea7aS+ e6Cyu9e7qkGJXZyV6sv9t24cDihEyGxLiod4b6rbyc9nRY87Vafv1Gf72FO+wbqE xcFTRuq/sHu8I80l5FnQPUl7j+bcHD36f7trcCZvHtHP8EVdBghzaOABG5TyT+od 6rUP+BvCLMg3yrh05PkaKTTCgrWJ0Trut4scgVYRQ== X-ME-Sender: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 01AEF7E321; Fri, 9 Feb 2018 13:37:54 -0500 (EST) Date: Fri, 9 Feb 2018 13:37:54 -0500 From: Leo Famulari To: Pierre Langlois Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader. Message-ID: <20180209183754.GC2356@jasmine.lan> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lMM8JwqTlfDpEaS6" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30400 Cc: 30400@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --lMM8JwqTlfDpEaS6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote: > From 9d9b90882491ff2ebf6f3a3580d4d7dbcdf57c72 Mon Sep 17 00:00:00 2001 > From: Pierre Langlois > Date: Thu, 8 Feb 2018 09:57:41 +0000 > Subject: [PATCH 2/2] gnu: crypto++: Update to 6.0.0. >=20 > * gnu/packages/crypto.scm (crypto++): Update to 6.0.0. > * gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch: Delete > file. > * gnu/local.mk (dist_patch_DATA): Remove it. I didn't push this patch yet because 1) it doesn't apply and 2) I have to go AFK now and don't have time to make it apply. I'll do it later today unless somebody does it first. --lMM8JwqTlfDpEaS6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlp96oIACgkQJkb6MLrK fwhcEBAAqQFIM+YkK53YrglF2bOpB+LXjUCnjjXeO+o6Nif3RfnsvKPX18rURAIV KSZerf38/kGLYMqunOYXBtE+y7KBQ6i/yxrXV9ss0FOLuVBlZb5T+EflURXumcl6 KV4hrhlSmLt5uI/j1h4/cztiTSd7VEemzswsDt/q5YULiivP8JPMWlfxJ6EFouYa vUnhhpQ3MS8EwmzBPXA5UzEdsCcAT9EpJFCabyeDqWGD3YxThBkJOxwGk3O+zl6q YgSihpNW1RPM3km+aUn6kFb99bUK6Qg/Ar51pnjX1kFXFj7lNqWMptpKLzeKa3ux GTuEjnOGA26Hw+N1nZG1iWuipMdaPfQaxy3tgJE+piZF8+kjBUftGGrmN1MiZuhB Sxb3vZ9WXSablaXHKP+bSvnR8oPHjBTV3Y83iNcg6L3h07CFDUoKy7r8lTsiDLmr jsjEkhW8+My1BDfEpF92ByVad7m1an1cwfAn68Uz0CR0LMv7946XH8GaKQ6McwF1 FHU/ixAl3zzNT4L8x4oGUGJ2YR+4H28dxh91TmuOpj7u9idyD4MfiYZbCaisLjXb jlLDUZ8sPranyRDEA9Gh6Jl3E4B+sP/rxe74WrJGMHdlSwPsXvc2YDj5HkLYByCU EdIn9jfd81Ar1UB5zK/Tq/jec0N+k6f+qiv+ULSgJBXJ0Yg29AA= =x96Z -----END PGP SIGNATURE----- --lMM8JwqTlfDpEaS6-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 09 17:12:16 2018 Received: (at 30400) by debbugs.gnu.org; 9 Feb 2018 22:12:16 +0000 Received: from localhost ([127.0.0.1]:35841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekGu0-0000Dd-1O for submit@debbugs.gnu.org; Fri, 09 Feb 2018 17:12:16 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:51166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekGty-0000DV-GN for 30400@debbugs.gnu.org; Fri, 09 Feb 2018 17:12:14 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id F05411122E; Fri, 9 Feb 2018 23:12:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AyzDZslrt9Ic; Fri, 9 Feb 2018 23:12:13 +0100 (CET) Received: from ribbon (vpn-0-27.aquilenet.fr [IPv6:2a0c:e300:4:27::]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C2A2210ED3; Fri, 9 Feb 2018 23:12:12 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Leo Famulari Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader. References: <20180209183635.GB2356@jasmine.lan> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 =?utf-8?Q?Pluvi=C3=B4se?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 09 Feb 2018 23:12:03 +0100 In-Reply-To: <20180209183635.GB2356@jasmine.lan> (Leo Famulari's message of "Fri, 9 Feb 2018 13:36:35 -0500") Message-ID: <87tvupx170.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30400 Cc: 30400@debbugs.gnu.org, Pierre Langlois X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, Leo Famulari skribis: > On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote: >> Hi Guix! >>=20 >> I realized today that a new version of crypto++ was out so I set out to >> update it but Clementine failed to compile. There's a patch on master [0] >> that fixes the issue so I was going to apply it when I realized the bit >> of code in question downloads a binary blob to support Spotify. It >> turns out there's a button in the preference menu that allows users to >> download this proprietary blob, and crypto++ appears to be used to check >> it. > > Thanks for pointing this out! I reindented the #:configure-flags and > added some comments to the first patch, and pushed as > af414f34fb6e3609e572880f3b0b3bbcb1b3bfc6 > > My understanding of the FSDG [0] makes me think that we'll need to go > further and, in an origin snippet, remove the code performs the download > of the non-free component. This would mean that `guix build --source > clementine` would return something that follows the FSDG. CC-ing Ludo > for clarification. Correct, removal of non-free code should go in =E2=80=98snippet=E2=80=99 fo= r the reason you gave. Thanks for looking into it, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 15 04:33:30 2018 Received: (at 30400-done) by debbugs.gnu.org; 15 Feb 2018 09:33:30 +0000 Received: from localhost ([127.0.0.1]:43629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emFv0-0003v6-KJ for submit@debbugs.gnu.org; Thu, 15 Feb 2018 04:33:30 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:53850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emFuw-0003uw-TH for 30400-done@debbugs.gnu.org; Thu, 15 Feb 2018 04:33:29 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C4ACE108C3; Thu, 15 Feb 2018 10:33:25 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wlu9BL9lQX8F; Thu, 15 Feb 2018 10:33:24 +0100 (CET) Received: from ribbon (unknown [193.50.110.160]) by hera.aquilenet.fr (Postfix) with ESMTPSA id B0A16FEEF; Thu, 15 Feb 2018 10:33:24 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Leo Famulari Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader. References: <20180209183754.GC2356@jasmine.lan> Date: Thu, 15 Feb 2018 10:33:24 +0100 In-Reply-To: <20180209183754.GC2356@jasmine.lan> (Leo Famulari's message of "Fri, 9 Feb 2018 13:37:54 -0500") Message-ID: <87zi4afvh7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30400-done Cc: 30400-done@debbugs.gnu.org, Pierre Langlois X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Leo Famulari skribis: > On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote: >> From 9d9b90882491ff2ebf6f3a3580d4d7dbcdf57c72 Mon Sep 17 00:00:00 2001 >> From: Pierre Langlois >> Date: Thu, 8 Feb 2018 09:57:41 +0000 >> Subject: [PATCH 2/2] gnu: crypto++: Update to 6.0.0. >> >> * gnu/packages/crypto.scm (crypto++): Update to 6.0.0. >> * gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch: Delete >> file. >> * gnu/local.mk (dist_patch_DATA): Remove it. > > I didn't push this patch yet because 1) it doesn't apply and 2) I have > to go AFK now and don't have time to make it apply. I'll do it later > today unless somebody does it first. Pushed as 6ca15c9ef615979862a07c02bd316e7f12a0c7ca. Thanks! Ludo'. From unknown Tue Jun 17 01:29:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Mar 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator