GNU bug report logs - #30381
gnu: Add gzdoom.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: okapi <at> firemail.cc
Cc: 30381 <at> debbugs.gnu.org
Subject: [bug#30381] gnu: Add gzdoom.
Date: Fri, 09 Feb 2018 11:20:03 +0100

okapi <at> firemail.cc skribis:

> From c3b7fea66a5bc5bd13f448da15d704659ee5bcb7 Mon Sep 17 00:00:00 2001
> From: okapi <okapi <at> firemail.cc>
> Date: Wed, 17 Jan 2018 00:21:42 +0100
> Subject: [PATCH 2/2] gnu: Add gzdoom.
>
> * gnu/packages/games.scm (gzdoom): New variable.
> * gnu/packages/patches/gzdoom-search-in-installed-share.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

Overall LGTM!  Minor issues:

> +    (native-inputs `(("pkg-config" ,pkg-config)
> +                     ("unzip" ,unzip)))
> +    (synopsis "Modern Doom 2 source port")
> +    (description "Gzdoom is a Doom 2 source port with a modern renderer.

To give a bit more context, maybe: “Gzdoom is a port of the Doom 2
ADJECTIVE game, using a modern renderer.” (I’ll let you find what
ADJECTIVE to use.  :-))

> +It improves modding support with ZDoom's advanced mapping features and the new
> +ZScript language.  In addition to Doom, it supports Heretic, Hexen, Strife,
> +Chex Quest, and fan-created games like Harmony and Hacx.")
> +    (home-page "https://zdoom.org/index")
> +    (license (list license:gpl3+         ; gzdoom game
> +                   license:lgpl3+        ; gzdoom renderer
> +                   license:expat         ; gdtoa
> +                   (license:non-copyleft ; modified dumb
> +                    "file://dumb/licence.txt"
> +                    "Dumb license, explicitly GPL compatible.")))))
> diff --git a/gnu/packages/patches/gzdoom-search-in-installed-share.patch b/gnu/packages/patches/gzdoom-search-in-installed-share.patch
> new file mode 100644
> index 000000000..d16b604db
> --- /dev/null
> +++ b/gnu/packages/patches/gzdoom-search-in-installed-share.patch
> @@ -0,0 +1,14 @@

Please add a couple of lines explaining what the patch does, and what
its upstream status is (with a link to the upstream commit/issue, if
any.)

Could you send an updated patch?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.