GNU bug report logs - #30374
[PATCH] gnu: Add kirigami.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30374 in the body.
You can then email your comments to 30374 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add kirigami.
Date: Wed,  7 Feb 2018 00:00:00 +0100

---
 gnu/packages/kde-frameworks.scm | 60 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index ef2a7cb07..946c7511a 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -766,6 +766,66 @@ but also for getting notified upon idle time events, such as custom timeouts,
 or user activity.")
     (license (list license:gpl2+ license:lgpl2.1+))))
 
+(define-public kirigami
+  ;; Kirigami is listed as tier 1 framework, but optionally includes
+  ;; plasma-framework which is tier 3.
+  (package
+    (name "kirigami")
+    (version "5.39.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/frameworks/"
+                    (version-major+minor version) "/"
+                    "kirigami2-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0spgylk4yjy74rs5d5b28qv72qz5ra9j3wfmk6vx2b6cvf1fw517"))))
+    (properties `((upstream-name . "kirigami2")))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("kwindowsystem" ,kwindowsystem)
+       ;; TODO: Find a way to activate this optional include without
+       ;; introducing a recursive dependency.
+       ;;("plasma-frameworks" ,plasma-framework) ;; Tier 3!
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("qtquickcontrols2" ,qtquickcontrols2)
+       ("qtsvg" ,qtsvg)
+       ;; Run-time dependency
+       ("qtgraphicaleffects" ,qtgraphicaleffects)))
+    (arguments
+     `(#:tests? #f ;; FIXME: Test suite is broken,
+       ;; see https://bugs.kde.org/show_bug.cgi?id=386456
+       ;; Note for when enabling the tests: The test-suite is meant to be run
+       ;; without prior installation, see
+       ;; https://cgit.kde.org/kirigami.git/commit/?id=24ad2c9
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "QtQuick plugins to build user interfaces based on the KDE UX
+guidelines")
+    (description "Kirigami is a set of QtQuick components at the moment
+targeted for mobile use (in the future desktop as well) targeting both Plasma
+Mobile and Android.  It’s not a whole set of components, all the “Primitive”
+ones like buttons and textboxes are a job for QtQuickControls (soon
+QtQuickControls2) but it’s a set of high level components to make the creation
+of applications that look and feel great on mobile as well as desktop devices
+and follow the Kirigami Human Interface Guidelines.  The target of those
+components is anybody that wants to do an application using QtQuick as its
+main UI, especially if targeting a mobile platform, without adding many
+dependencies.  They work on a variety of platforms, such as Plasma Mobile,
+Desktop Linux, Android and Windows.")
+    (license license:lgpl2.1+)))
+
 (define-public kitemmodels
   (package
     (name "kitemmodels")
-- 
2.13.6

Message #8 received at 30374 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 30374 <at> debbugs.gnu.org
Subject: PATCH] gnu: Add kirigami.
Date: Wed, 7 Feb 2018 00:05:56 +0100

Please note: This intentionally adds version 5.39 (instead of the most
current version) to be in line with the other KF5 packages. Updates of
all package will be done just after this add has been accepted.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #11 received at 30374 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 30374 <at> debbugs.gnu.org
Subject: Re: [bug#30374] [PATCH] gnu: Add kirigami.
Date: Fri, 09 Feb 2018 15:04:38 +0100

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> ---
>  gnu/packages/kde-frameworks.scm | 60 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)

[...]

> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "QtQuick plugins to build user interfaces based on the KDE UX
> +guidelines")

Perhaps cut after “interfaces” since the rest is more or less in the
description?

> +    (description "Kirigami is a set of QtQuick components at the moment
> +targeted for mobile use (in the future desktop as well) targeting both Plasma
> +Mobile and Android.  It’s not a whole set of components, all the “Primitive”
> +ones like buttons and textboxes are a job for QtQuickControls (soon
> +QtQuickControls2) but it’s a set of high level components to make the creation
> +of applications that look and feel great on mobile as well as desktop devices
> +and follow the Kirigami Human Interface Guidelines.  The target of those
> +components is anybody that wants to do an application using QtQuick as its
> +main UI, especially if targeting a mobile platform, without adding many
> +dependencies.  They work on a variety of platforms, such as Plasma Mobile,
> +Desktop Linux, Android and Windows.")

This looks like a project overview more than a package description from
the Guix user perspective.  Could you adjust it somewhat, focusing on
what it does or what it provides on GNU/Linux?

We usually don’t mention portability in descriptions since by definition
people reading it are using GNU.  Definitely avoid mentioning the
proprietary OSes and “Linux” for “GNU/Linux” please.  :-)

OK with changes along these lines and with a proper commit log!

Thank you,
Ludo’.

Message #14 received at 30374 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 30374 <at> debbugs.gnu.org
Subject: Re: [bug#30374] [PATCH] gnu: Add kirigami.
Date: Sat, 10 Feb 2018 11:48:12 +0100

Am 09.02.2018 um 15:04 schrieb Ludovic Courtès:
> This looks like a project overview more than a package description from
> the Guix user perspective.  Could you adjust it somewhat, focusing on
> what it does or what it provides on GNU/Linux?

You are right. I simply copied the text form somewhere else, thus the
poor quality Will post an updated patch the net days.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #19 received at 30374-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 30374-close <at> debbugs.gnu.org
Subject: Re: [bug#30374] [PATCH] gnu: Add kirigami.
Date: Mon, 12 Feb 2018 16:27:01 +0100

Am 10.02.2018 um 11:48 schrieb Hartmut Goebel:
> Am 09.02.2018 um 15:04 schrieb Ludovic Courtès:
>> This looks like a project overview more than a package description from
>> the Guix user perspective.  Could you adjust it somewhat, focusing on
>> what it does or what it provides on GNU/Linux?
> You are right. I simply copied the text form somewhere else, thus the
> poor quality Will post an updated patch the net days.
>
After rewriting the text only two sentences are left, so I decided to
push it directly (0093e26f911cc9a055615d599b2e44b4d3a6cf6a). Thanks for
the review.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.