From unknown Sun Jun 22 17:10:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30346 <30346@debbugs.gnu.org> To: bug#30346 <30346@debbugs.gnu.org> Subject: Status: lcms.c doesn't compile when lcms.h isn't in default search path Reply-To: bug#30346 <30346@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:10:39 +0000 retitle 30346 lcms.c doesn't compile when lcms.h isn't in default search pa= th reassign 30346 emacs submitter 30346 Rainer Orth severity 30346 minor tag 30346 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 09:24:23 2018 Received: (at submit) by debbugs.gnu.org; 4 Feb 2018 14:24:23 +0000 Received: from localhost ([127.0.0.1]:56261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiLDT-0005Py-5c for submit@debbugs.gnu.org; Sun, 04 Feb 2018 09:24:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiLDR-0005Pm-K5 for submit@debbugs.gnu.org; Sun, 04 Feb 2018 09:24:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiLDL-0000No-K9 for submit@debbugs.gnu.org; Sun, 04 Feb 2018 09:24:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=5.0 tests=BAYES_20, RECEIVED_FROM_WINDOWS_HOST,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52032) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eiLDL-0000Ni-Gu for submit@debbugs.gnu.org; Sun, 04 Feb 2018 09:24:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiLDK-0005Fv-H7 for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 09:24:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiLDH-0000Ml-To for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 09:24:14 -0500 Received: from smtp.cebitec.uni-bielefeld.de ([129.70.160.84]:51781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiLDH-0000MS-Mn for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 09:24:11 -0500 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 1C57BA5D for ; Sun, 4 Feb 2018 15:15:34 +0100 (CET) X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3b5X3AEeL-5l for ; Sun, 4 Feb 2018 15:15:33 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4FDDB9D4.dip0.t-ipconnect.de [79.221.185.212]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id B457BA5C for ; Sun, 4 Feb 2018 15:15:32 +0100 (CET) From: Rainer Orth To: bug-gnu-emacs@gnu.org Subject: lcms.c doesn't compile when lcms.h isn't in default search path Date: Sun, 04 Feb 2018 15:15:31 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I just tried to compile emacs 26.0.91 on Solaris 11.4 Beta. This failed building lcms.o: CC lcms.o /vol/gnu/src/emacs/emacs-26.0.91/src/lcms.c:23:19: fatal error: lcms2.h: No such file or directory lcms.h lives in /usr/include/lcms/lcms.h and lcms2.pc correctly adds a matching -I to Cflags. However, configure.ac just does a link test for cmsCreateTransform, which succeeds. I can work around this by adding a matching -I option to CPPFLAGS at configure time, but it seems silly having to do so if the information can be derived automatically. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 20:55:02 2018 Received: (at 30346) by debbugs.gnu.org; 5 Feb 2018 01:55:02 +0000 Received: from localhost ([127.0.0.1]:57524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiVzn-0001rw-8G for submit@debbugs.gnu.org; Sun, 04 Feb 2018 20:55:02 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:35446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiVzi-0001rh-1X for 30346@debbugs.gnu.org; Sun, 04 Feb 2018 20:54:58 -0500 Received: by mail-io0-f196.google.com with SMTP id m11so28630746iob.2 for <30346@debbugs.gnu.org>; Sun, 04 Feb 2018 17:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+qakxzC5FfS3EmQhZd1Oklt+KZPT+V3hV6JdAe5WoaQ=; b=sqDarSjjhoxLy0R35UWyP5MrOgj5ZOnNV0Ft1VS2hsRGjPpVJeJseXJcl85uVWnQas S4UPHWzeVC+xG7PEHi2S+ZVIIBSr5CN1AoHGGVLXj9uIq45DdiNqGAaqC2ikveTZ/9Rj tBsG4bhW3w4WW8b+PzpBPnoyFKkZh88JYzgVS3eXBjbRlOgQF2Xe2YIWG3QW4aCbbkLp Fw17JAtuVMgf6gGc+vsCzfSaZvODRLQZhZb/bbxbITQZ4IygSQAt8uEXdn5R6ZKXeFsW OQrLYPxEms9DCdByZswlxULffy2MMtX+YywSCenI5kCM167A9cs2TnYKBoQuJ+MNdged LR1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+qakxzC5FfS3EmQhZd1Oklt+KZPT+V3hV6JdAe5WoaQ=; b=C4ii37CSoqV59uPLc2VWXl3c2IUB+EVSbcurEg53hDRHZ3oxUbFSh2nqxyB7a0Jd1l Xz+otP347OZsfRhpBSdtvlwFT7vgwPiRqRbYtqfg+en7kgrzyNWbpqDU3EGZyHKKiR7H 8f3HL5KV13Sn784LFvHpxV9xy2oPXIoac9flUzoT1b+Vc8sPyuMZKA4eTk6vQBODyEhp OPHftwyn6bJTE1reik+HM/xmFPreb2Rygk2uQYEwYwm7YrDAKZ3eBqyf2KEo7FR6Ujih RZ9EBZByhSEwzrRHpWz9JtvEXhOFhNIQBlV9S8TUq8Rjgcbky2AJG3BWSR3VH76ylwuH ErBg== X-Gm-Message-State: AKwxytcmZ8EazOCzIHPoCsmOdiUQ6Sgka6mSgFbjHmjDfa2SoHmWfOqg ZHTDlldfN1JIt0tX3ZFjVXBQJw== X-Google-Smtp-Source: AH8x224/d4I4ujvUtU3i40mUBbJSOXwCfhnA4WUvg64AI/opjxiywh8aCU6b7+7+c29wIzyaklK8ww== X-Received: by 10.107.93.13 with SMTP id r13mr20088019iob.32.1517795688066; Sun, 04 Feb 2018 17:54:48 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c140sm6133107itc.1.2018.02.04.17.54.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Feb 2018 17:54:46 -0800 (PST) From: Noam Postavsky To: Rainer Orth Subject: Re: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path References: Date: Sun, 04 Feb 2018 20:54:45 -0500 In-Reply-To: (Rainer Orth's message of "Sun, 04 Feb 2018 15:15:31 +0100") Message-ID: <874lmwfbfe.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30346 Cc: 30346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain Rainer Orth writes: > I just tried to compile emacs 26.0.91 on Solaris 11.4 Beta. This failed > building lcms.o: > > CC lcms.o > /vol/gnu/src/emacs/emacs-26.0.91/src/lcms.c:23:19: fatal error: lcms2.h: No such file or directory > > lcms.h lives in /usr/include/lcms/lcms.h and lcms2.pc correctly adds a > matching -I to Cflags. However, configure.ac just does a link test for > cmsCreateTransform, which succeeds. I can work around this by adding a > matching -I option to CPPFLAGS at configure time, but it seems silly > having to do so if the information can be derived automatically. Does the below work? (I notice that all of a sudden this bug's severity has been set to "important", although it looks more like it should be "minor" to me. And I would intend the patch for master, not emacs-26.) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Use-pkg-config-to-find-lcms2-CFLAGS-and-LIBS-Bug-.patch Content-Description: patch >From 30b2c9bcc26739cc6634f496b3dc415cf5310555 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 4 Feb 2018 20:43:26 -0500 Subject: [PATCH v1] Use pkg-config to find lcms2 CFLAGS and LIBS (Bug#30346) * configure.ac: Use EMACS_CHECK_MODULES fors LCMS2 rather than AC_SEARCH_LIBS. * src/Makefile.in: Get LCMS2_LIBS and LCMS2_CFLAGS from configure, instead of just LIBLCMS2. --- configure.ac | 12 +++++------- src/Makefile.in | 7 ++++--- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index f9c7bb76e5..7ee1fae83b 100644 --- a/configure.ac +++ b/configure.ac @@ -3469,12 +3469,9 @@ AC_DEFUN HAVE_LCMS2=no LIBLCMS2= if test "${with_lcms2}" != "no"; then - OLIBS=$LIBS - AC_SEARCH_LIBS([cmsCreateTransform], [lcms2], [HAVE_LCMS2=yes]) - LIBS=$OLIBS - case $ac_cv_search_cmsCreateTransform in - -*) LIBLCMS2=$ac_cv_search_cmsCreateTransform ;; - esac + EMACS_CHECK_MODULES([LCMS2], [lcms2]) + AC_CHECK_HEADER([lcms2.h]) + AC_CHECK_LIB([lcms2], [cmsCreateTransform]) fi if test "${HAVE_LCMS2}" = "yes"; then AC_DEFINE([HAVE_LCMS2], 1, [Define to 1 if you have the lcms2 library (-llcms2).]) @@ -3483,7 +3480,8 @@ AC_DEFUN LIBLCMS2= fi fi -AC_SUBST(LIBLCMS2) +AC_SUBST(LCMS2_CFLAGS) +AC_SUBST(LCMS2_LIBS) HAVE_ZLIB=no LIBZ= diff --git a/src/Makefile.in b/src/Makefile.in index 15ca1667d6..9fa1d7b6f2 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -234,7 +234,8 @@ LIBXML2_CFLAGS = GETADDRINFO_A_LIBS = @GETADDRINFO_A_LIBS@ -LIBLCMS2 = @LIBLCMS2@ +LCMS2_LIBS = @LCMS2_LIBS@ +LCMS2_CFLAGS = @LCMS2_CFLAGS@ LIBZ = @LIBZ@ @@ -360,7 +361,7 @@ EMACS_CFLAGS= $(GNUSTEP_CFLAGS) $(CFLAGS_SOUND) $(RSVG_CFLAGS) $(IMAGEMAGICK_CFLAGS) \ $(PNG_CFLAGS) $(LIBXML2_CFLAGS) $(DBUS_CFLAGS) \ $(XRANDR_CFLAGS) $(XINERAMA_CFLAGS) $(XFIXES_CFLAGS) $(XDBE_CFLAGS) \ - $(WEBKIT_CFLAGS) \ + $(WEBKIT_CFLAGS) $(LCMS2_CFLAGS) \ $(SETTINGS_CFLAGS) $(FREETYPE_CFLAGS) $(FONTCONFIG_CFLAGS) \ $(LIBOTF_CFLAGS) $(M17N_FLT_CFLAGS) $(DEPFLAGS) \ $(LIBSYSTEMD_CFLAGS) \ @@ -492,7 +493,7 @@ LIBES = $(LIBXML2_LIBS) $(LIBGPM) $(LIBS_SYSTEM) $(CAIRO_LIBS) \ $(LIBS_TERMCAP) $(GETLOADAVG_LIBS) $(SETTINGS_LIBS) $(LIBSELINUX_LIBS) \ $(FREETYPE_LIBS) $(FONTCONFIG_LIBS) $(LIBOTF_LIBS) $(M17N_FLT_LIBS) \ - $(LIBGNUTLS_LIBS) $(LIB_PTHREAD) $(GETADDRINFO_A_LIBS) $(LIBLCMS2) \ + $(LIBGNUTLS_LIBS) $(LIB_PTHREAD) $(GETADDRINFO_A_LIBS) $(LCMS2_LIBS) \ $(NOTIFY_LIBS) $(LIB_MATH) $(LIBZ) $(LIBMODULES) $(LIBSYSTEMD_LIBS) ## FORCE it so that admin/unidata can decide whether these files -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 05 12:21:47 2018 Received: (at 30346) by debbugs.gnu.org; 5 Feb 2018 17:21:47 +0000 Received: from localhost ([127.0.0.1]:58971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eikSh-0006lI-4C for submit@debbugs.gnu.org; Mon, 05 Feb 2018 12:21:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eikSf-0006l3-9p for 30346@debbugs.gnu.org; Mon, 05 Feb 2018 12:21:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eikSW-0007XW-7m for 30346@debbugs.gnu.org; Mon, 05 Feb 2018 12:21:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eikSW-0007XG-32; Mon, 05 Feb 2018 12:21:36 -0500 Received: from [176.228.60.248] (port=4155 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eikSV-0001UM-Fn; Mon, 05 Feb 2018 12:21:35 -0500 Date: Mon, 05 Feb 2018 19:21:28 +0200 Message-Id: <83y3k773on.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <874lmwfbfe.fsf@users.sourceforge.net> (message from Noam Postavsky on Sun, 04 Feb 2018 20:54:45 -0500) Subject: Re: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path References: <874lmwfbfe.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30346 Cc: 30346@debbugs.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Sun, 04 Feb 2018 20:54:45 -0500 > Cc: 30346@debbugs.gnu.org > > Does the below work? (I notice that all of a sudden this bug's severity > has been set to "important", although it looks more like it should be > "minor" to me. And I would intend the patch for master, not emacs-26.) I agree. > HAVE_LCMS2=no > LIBLCMS2= > if test "${with_lcms2}" != "no"; then > - OLIBS=$LIBS > - AC_SEARCH_LIBS([cmsCreateTransform], [lcms2], [HAVE_LCMS2=yes]) > - LIBS=$OLIBS > - case $ac_cv_search_cmsCreateTransform in > - -*) LIBLCMS2=$ac_cv_search_cmsCreateTransform ;; > - esac > + EMACS_CHECK_MODULES([LCMS2], [lcms2]) > + AC_CHECK_HEADER([lcms2.h]) > + AC_CHECK_LIB([lcms2], [cmsCreateTransform]) > fi > if test "${HAVE_LCMS2}" = "yes"; then > AC_DEFINE([HAVE_LCMS2], 1, [Define to 1 if you have the lcms2 library (-llcms2).]) > @@ -3483,7 +3480,8 @@ AC_DEFUN > LIBLCMS2= > fi > fi > -AC_SUBST(LIBLCMS2) > +AC_SUBST(LCMS2_CFLAGS) > +AC_SUBST(LCMS2_LIBS) Maybe I'm missing something, but it looks like you effectively renamed LIBLCMS2 to LCMS2_LIBS, so now LIBLCMS2 is set, but not used, and the part of configure.ac that took care of the MS-Windows build, where "-lcms2" should NOT be used at link time, now does nothing useful. Right? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 05 14:37:51 2018 Received: (at 30346) by debbugs.gnu.org; 5 Feb 2018 19:37:51 +0000 Received: from localhost ([127.0.0.1]:59038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eimaN-0001mo-L1 for submit@debbugs.gnu.org; Mon, 05 Feb 2018 14:37:51 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eimaJ-0001mR-3c for 30346@debbugs.gnu.org; Mon, 05 Feb 2018 14:37:47 -0500 Received: by mail-wm0-f46.google.com with SMTP id f3so28170423wmc.1 for <30346@debbugs.gnu.org>; Mon, 05 Feb 2018 11:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=tqPpvzelDqKDtlXr9SzRWWtiksQeXfdpeRgrgaY0yVk=; b=mQll+6Yn+Vdcm2AeLzpiGDrTAs4COIwIOEIiFYut9DNGcWWghqxPUETQAW5fgDhQj8 Iu30p9tkIFnaSDiIYjQ8pk7ucJ8613LUc8nF/jnTVEiao7bIO0HIf+IGOxc7bEXZhLY7 lQ//syyn52yxck0Ivv9myxcky3tT/qSZrvLnM4KbiA5zc13xsFxyVBIje3FRLX5pKeey 3nC1LTIP+J4rSrA1kkBHXB4hCCzQ37eZzyYhKUJFUVKgtLXQ3XttoJ0pg+7/uoKJsVMN ICF5bcfBkaCtKDmiGOYxCYneHSB/4xrQT9cWUeHbzepF5iKc0ayqZPeICOQ9gWL0aP2L lIyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=tqPpvzelDqKDtlXr9SzRWWtiksQeXfdpeRgrgaY0yVk=; b=emn6SYHZ6klVngya/dA28cueaKbLxdG/1y6Cny2gGde6/B375WyziRAk5iPZ3eWqVo diUGxfxiBiiKF2VvOL167t63lJ/RqQ1eEQyNZdS7dE7nP7JdP1J6T8rBrioyaflP2Ih7 y+ABh0K0GSbc09hwY81TydgOqGjufNt4RiEu72kV2ZMgfH56p6L5/P0mYaIVJ8l/l+3+ PWkhoJuv+f8S8u9VcecB4JeUSBIC/SbVf3hqryzSbimjFHifmL6FYx+JC9xGuO9EYdnI xVeddh9z9CbltaTPQcEhKr8HvHmth/B5U/aQC0kYI7jLfN59syHG5zWxnsKx7N6ZyIc7 sqwQ== X-Gm-Message-State: APf1xPC5G8hmhHyL20iYFTNYUefP/sYrVtdc7tO+l9YLxf6oF35EHabI zkeAaMdeOLXUNPskfJ+aK5RF8chxsn/MKCw/LnM= X-Google-Smtp-Source: AH8x226AHtZwKs/mKNHFv/EFhn3S0ptajVeN9lUphmGLwUA0a9DTgNph+kGPB5ewxjsmvWIsUwMvaSm1ddhcPoN2y5c= X-Received: by 10.28.157.206 with SMTP id g197mr330802wme.96.1517859461103; Mon, 05 Feb 2018 11:37:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.182.69 with HTTP; Mon, 5 Feb 2018 11:37:40 -0800 (PST) In-Reply-To: <83y3k773on.fsf@gnu.org> References: <874lmwfbfe.fsf@users.sourceforge.net> <83y3k773on.fsf@gnu.org> From: Noam Postavsky Date: Mon, 5 Feb 2018 14:37:40 -0500 X-Google-Sender-Auth: ZjFAX0EIYsga7yD5_HhO64knAic Message-ID: Subject: Re: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path To: Eli Zaretskii Content-Type: multipart/mixed; boundary="001a114b4448ffb07005647c31ec" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30346 Cc: 30346@debbugs.gnu.org, ro@cebitec.uni-bielefeld.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a114b4448ffb07005647c31ec Content-Type: text/plain; charset="UTF-8" severity 30346 minor quit On Mon, Feb 5, 2018 at 12:21 PM, Eli Zaretskii wrote: >> Does the below work? (I notice that all of a sudden this bug's severity >> has been set to "important", although it looks more like it should be >> "minor" to me. And I would intend the patch for master, not emacs-26.) > > I agree. > Maybe I'm missing something, but it looks like you effectively renamed > LIBLCMS2 to LCMS2_LIBS, so now LIBLCMS2 is set, but not used, and the > part of configure.ac that took care of the MS-Windows build, where > "-lcms2" should NOT be used at link time, now does nothing useful. > Right? Ah, you're right. Also, I think the AC_CHECK_HEADERS/LIB calls I put wouldn't work without some CFLAGS and LIBS juggling. But I guess they're redundant anyway unless we start getting reports about pkg-config of lcms2 being incorrect. New patch attached (the patch is still against emacs-26 just for convenience of OP). --001a114b4448ffb07005647c31ec Content-Type: application/octet-stream; name="v2-0001-Use-pkg-config-to-find-lcms2-CFLAGS-and-LIBS-Bug-.patch" Content-Disposition: attachment; filename="v2-0001-Use-pkg-config-to-find-lcms2-CFLAGS-and-LIBS-Bug-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jdam60ea0 RnJvbSA3NDYyMzcyNzJjNzg1N2JjNDMxZjVkY2Y5NGE0MGE2ODA5MjFkYTNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBTdW4sIDQgRmViIDIwMTggMjA6NDM6MjYgLTA1MDAKU3ViamVjdDogW1BBVENIIHYyXSBV c2UgcGtnLWNvbmZpZyB0byBmaW5kIGxjbXMyIENGTEFHUyBhbmQgTElCUyAoQnVnIzMwMzQ2KQoK KiBjb25maWd1cmUuYWM6IFVzZSBFTUFDU19DSEVDS19NT0RVTEVTIGZvcnMgTENNUzIgcmF0aGVy IHRoYW4KQUNfU0VBUkNIX0xJQlMuCiogc3JjL01ha2VmaWxlLmluOiBHZXQgTENNUzJfTElCUyBh bmQgTENNUzJfQ0ZMQUdTIGZyb20gY29uZmlndXJlLAppbnN0ZWFkIG9mIGp1c3QgTElCTENNUzIu Ci0tLQogY29uZmlndXJlLmFjICAgIHwgMTUgKysrKysrLS0tLS0tLS0tCiBzcmMvTWFrZWZpbGUu aW4gfCAgNyArKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEyIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRl eCBmOWM3YmI3Li4zMjY4OGQxIDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmln dXJlLmFjCkBAIC0zNDY3LDIzICszNDY3LDIwIEBAIEFDX0RFRlVOCiBBQ19TVUJTVChMSUJKUEVH KQogCiBIQVZFX0xDTVMyPW5vCi1MSUJMQ01TMj0KK0xDTVMyX0NGTEFHUz0KK0xDTVMyX0xJQlM9 CiBpZiB0ZXN0ICIke3dpdGhfbGNtczJ9IiAhPSAibm8iOyB0aGVuCi0gIE9MSUJTPSRMSUJTCi0g IEFDX1NFQVJDSF9MSUJTKFtjbXNDcmVhdGVUcmFuc2Zvcm1dLCBbbGNtczJdLCBbSEFWRV9MQ01T Mj15ZXNdKQotICBMSUJTPSRPTElCUwotICBjYXNlICRhY19jdl9zZWFyY2hfY21zQ3JlYXRlVHJh bnNmb3JtIGluCi0gICAgLSopIExJQkxDTVMyPSRhY19jdl9zZWFyY2hfY21zQ3JlYXRlVHJhbnNm b3JtIDs7Ci0gIGVzYWMKKyAgRU1BQ1NfQ0hFQ0tfTU9EVUxFUyhbTENNUzJdLCBbbGNtczJdKQog ZmkKIGlmIHRlc3QgIiR7SEFWRV9MQ01TMn0iID0gInllcyI7IHRoZW4KICAgQUNfREVGSU5FKFtI QVZFX0xDTVMyXSwgMSwgW0RlZmluZSB0byAxIGlmIHlvdSBoYXZlIHRoZSBsY21zMiBsaWJyYXJ5 ICgtbGxjbXMyKS5dKQogICAjIyMgbWluZ3czMiBkb2Vzbid0IHVzZSAtbGxjbXMyLCBzaW5jZSBp dCBsb2FkcyB0aGUgbGlicmFyeSBkeW5hbWljYWxseS4KICAgaWYgdGVzdCAiJHtvcHN5c30iID0g Im1pbmd3MzIiOyB0aGVuCi0gICAgIExJQkxDTVMyPQorICAgICBMQ01TMl9MSUJTPQogICBmaQog ZmkKLUFDX1NVQlNUKExJQkxDTVMyKQorQUNfU1VCU1QoTENNUzJfQ0ZMQUdTKQorQUNfU1VCU1Qo TENNUzJfTElCUykKIAogSEFWRV9aTElCPW5vCiBMSUJaPQpkaWZmIC0tZ2l0IGEvc3JjL01ha2Vm aWxlLmluIGIvc3JjL01ha2VmaWxlLmluCmluZGV4IDE1Y2ExNjYuLjlmYTFkN2IgMTAwNjQ0Ci0t LSBhL3NyYy9NYWtlZmlsZS5pbgorKysgYi9zcmMvTWFrZWZpbGUuaW4KQEAgLTIzNCw3ICsyMzQs OCBAQCBMSUJYTUwyX0NGTEFHUyA9CiAKIEdFVEFERFJJTkZPX0FfTElCUyA9IEBHRVRBRERSSU5G T19BX0xJQlNACiAKLUxJQkxDTVMyID0gQExJQkxDTVMyQAorTENNUzJfTElCUyA9IEBMQ01TMl9M SUJTQAorTENNUzJfQ0ZMQUdTID0gQExDTVMyX0NGTEFHU0AKIAogTElCWiA9IEBMSUJaQAogCkBA IC0zNjAsNyArMzYxLDcgQEAgRU1BQ1NfQ0ZMQUdTPQogICAkKEdOVVNURVBfQ0ZMQUdTKSAkKENG TEFHU19TT1VORCkgJChSU1ZHX0NGTEFHUykgJChJTUFHRU1BR0lDS19DRkxBR1MpIFwKICAgJChQ TkdfQ0ZMQUdTKSAkKExJQlhNTDJfQ0ZMQUdTKSAkKERCVVNfQ0ZMQUdTKSBcCiAgICQoWFJBTkRS X0NGTEFHUykgJChYSU5FUkFNQV9DRkxBR1MpICQoWEZJWEVTX0NGTEFHUykgJChYREJFX0NGTEFH UykgXAotICAkKFdFQktJVF9DRkxBR1MpIFwKKyAgJChXRUJLSVRfQ0ZMQUdTKSAkKExDTVMyX0NG TEFHUykgXAogICAkKFNFVFRJTkdTX0NGTEFHUykgJChGUkVFVFlQRV9DRkxBR1MpICQoRk9OVENP TkZJR19DRkxBR1MpIFwKICAgJChMSUJPVEZfQ0ZMQUdTKSAkKE0xN05fRkxUX0NGTEFHUykgJChE RVBGTEFHUykgXAogICAkKExJQlNZU1RFTURfQ0ZMQUdTKSBcCkBAIC00OTIsNyArNDkzLDcgQEAg TElCRVMgPQogICAgJChMSUJYTUwyX0xJQlMpICQoTElCR1BNKSAkKExJQlNfU1lTVEVNKSAkKENB SVJPX0xJQlMpIFwKICAgICQoTElCU19URVJNQ0FQKSAkKEdFVExPQURBVkdfTElCUykgJChTRVRU SU5HU19MSUJTKSAkKExJQlNFTElOVVhfTElCUykgXAogICAgJChGUkVFVFlQRV9MSUJTKSAkKEZP TlRDT05GSUdfTElCUykgJChMSUJPVEZfTElCUykgJChNMTdOX0ZMVF9MSUJTKSBcCi0gICAkKExJ QkdOVVRMU19MSUJTKSAkKExJQl9QVEhSRUFEKSAkKEdFVEFERFJJTkZPX0FfTElCUykgJChMSUJM Q01TMikgXAorICAgJChMSUJHTlVUTFNfTElCUykgJChMSUJfUFRIUkVBRCkgJChHRVRBRERSSU5G T19BX0xJQlMpICQoTENNUzJfTElCUykgXAogICAgJChOT1RJRllfTElCUykgJChMSUJfTUFUSCkg JChMSUJaKSAkKExJQk1PRFVMRVMpICQoTElCU1lTVEVNRF9MSUJTKQogCiAjIyBGT1JDRSBpdCBz byB0aGF0IGFkbWluL3VuaWRhdGEgY2FuIGRlY2lkZSB3aGV0aGVyIHRoZXNlIGZpbGVzCi0tIAoy LjYuMi53aW5kb3dzLjEKCg== --001a114b4448ffb07005647c31ec-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 05:18:50 2018 Received: (at 30346) by debbugs.gnu.org; 6 Feb 2018 10:18:50 +0000 Received: from localhost ([127.0.0.1]:59551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej0Kv-0005hO-Ug for submit@debbugs.gnu.org; Tue, 06 Feb 2018 05:18:50 -0500 Received: from smtp.cebitec.uni-bielefeld.de ([129.70.160.84]:58361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej0Kt-0005hA-Oa for 30346@debbugs.gnu.org; Tue, 06 Feb 2018 05:18:48 -0500 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 64351B95; Tue, 6 Feb 2018 11:18:29 +0100 (CET) X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3Jq5unWyLBdh; Tue, 6 Feb 2018 11:18:28 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 4E4DBB94; Tue, 6 Feb 2018 11:18:28 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w16AI8gH020644; Tue, 6 Feb 2018 11:18:08 +0100 (MET) X-Authentication-Warning: lokon.CeBiTec.Uni-Bielefeld.DE: ro set sender to ro@CeBiTec.Uni-Bielefeld.DE using -f From: Rainer Orth To: Noam Postavsky Subject: Re: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path References: <874lmwfbfe.fsf@users.sourceforge.net> <83y3k773on.fsf@gnu.org> Date: Tue, 06 Feb 2018 11:18:08 +0100 In-Reply-To: (Noam Postavsky's message of "Mon, 5 Feb 2018 14:37:40 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30346 Cc: Eli Zaretskii , 30346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Noam, > New patch attached (the patch is still against emacs-26 just for > convenience of OP). just got around to trying it: worked like a charm. Thanks. It would be good if it could go into the emacs-26 branch, too, so that the 26.1 release compiles out of the box. Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 13:51:45 2018 Received: (at 30346) by debbugs.gnu.org; 6 Feb 2018 18:51:45 +0000 Received: from localhost ([127.0.0.1]:60545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej8LJ-00012t-Is for submit@debbugs.gnu.org; Tue, 06 Feb 2018 13:51:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej8LI-00012h-1C for 30346@debbugs.gnu.org; Tue, 06 Feb 2018 13:51:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ej8L8-0000UG-Ll for 30346@debbugs.gnu.org; Tue, 06 Feb 2018 13:51:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ej8L8-0000UC-Hk; Tue, 06 Feb 2018 13:51:34 -0500 Received: from [176.228.60.248] (port=1361 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ej8L7-0002wu-Ti; Tue, 06 Feb 2018 13:51:34 -0500 Date: Tue, 06 Feb 2018 20:51:29 +0200 Message-Id: <83o9l26jf2.fsf@gnu.org> From: Eli Zaretskii To: Rainer Orth In-reply-to: (message from Rainer Orth on Tue, 06 Feb 2018 11:18:08 +0100) Subject: Re: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path References: <874lmwfbfe.fsf@users.sourceforge.net> <83y3k773on.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30346 Cc: 30346@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Rainer Orth > Cc: Eli Zaretskii , 30346@debbugs.gnu.org > Date: Tue, 06 Feb 2018 11:18:08 +0100 > > It would be good if it could go into the emacs-26 branch, too, so that > the 26.1 release compiles out of the box. Sorry, it's too late to make non-trivial changes in the build machinery of emacs-26 (if we start using lcms2.pc, it might expose us to issues we never saw since the lcms2 support was added to Emacs). I think this problem is not too grave, since specifying CPPFLAGS at configure time solves it. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 13:54:21 2018 Received: (at 30346) by debbugs.gnu.org; 6 Feb 2018 18:54:21 +0000 Received: from localhost ([127.0.0.1]:60549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej8Np-00016r-0c for submit@debbugs.gnu.org; Tue, 06 Feb 2018 13:54:21 -0500 Received: from smtp.cebitec.uni-bielefeld.de ([129.70.160.84]:36754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej8Nn-00016c-DQ for 30346@debbugs.gnu.org; Tue, 06 Feb 2018 13:54:19 -0500 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id A099EFE2; Tue, 6 Feb 2018 19:53:53 +0100 (CET) X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0wkzhHmaC3aN; Tue, 6 Feb 2018 19:53:52 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4FDDB9D4.dip0.t-ipconnect.de [79.221.185.212]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 37566FE1; Tue, 6 Feb 2018 19:53:52 +0100 (CET) From: Rainer Orth To: Eli Zaretskii Subject: Re: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path References: <874lmwfbfe.fsf@users.sourceforge.net> <83y3k773on.fsf@gnu.org> <83o9l26jf2.fsf@gnu.org> Date: Tue, 06 Feb 2018 19:53:50 +0100 In-Reply-To: <83o9l26jf2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Feb 2018 20:51:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30346 Cc: 30346@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Eli, > Sorry, it's too late to make non-trivial changes in the build > machinery of emacs-26 (if we start using lcms2.pc, it might expose us > to issues we never saw since the lcms2 support was added to Emacs). Understood. > I think this problem is not too grave, since specifying CPPFLAGS at > configure time solves it. Indeed: and there's even the patch in the bug :-) Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 17 09:12:42 2018 Received: (at 30346) by debbugs.gnu.org; 17 Feb 2018 14:12:42 +0000 Received: from localhost ([127.0.0.1]:47636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en3EI-0007C4-Dp for submit@debbugs.gnu.org; Sat, 17 Feb 2018 09:12:42 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:40392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en3EG-0007Bm-Kf; Sat, 17 Feb 2018 09:12:40 -0500 Received: by mail-io0-f170.google.com with SMTP id t22so6994259ioa.7; Sat, 17 Feb 2018 06:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T2mqMZY4nX0WEkLQWYu1JWU+rgKNcqAihFy2CfXZEKY=; b=dkyjtsF7071LNufo8YlkKmqQMUlxaH8qTt0KRkzlbJ3EsT5FFn6NiAHyucXjUDiPLS XZq1vfBzY4+et1RBo9WYB7P5yMHda8gV2Vu7Swj63X2MhA85887pgvmeDRfqAXkm5MfD NXcGExT36yJcEQgPTHj/WuWGhRATYvnZLGtrOQqJFO2VigwlaZNUAZ1FLXAPWN2UX2+V F/GIRl6UCrqYm6yHIEI6b8mRUkhTM/xX9DZXIOdVDfAQAU/u4JD18QHJY03wm6R4sHZH U0vY2pVOfvgEXeIoVIgPw396drsfBT1lvLk0Gnv75WuBTWHvh1Q8NU2Of2EXONiZ/+VE VnTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T2mqMZY4nX0WEkLQWYu1JWU+rgKNcqAihFy2CfXZEKY=; b=OjIPoF5/U5O+21yIt8JlfbSX1Oi3Z3LbQW9eM2H4AnnD8/GEyDj8sE1BpQpRtPl74C gtbtEZrkvQYGb4XrBAXhZR0DJvrjC1Xpfi1mZferVYGu0b3X/ENXFLVxqO3XIv1iIQCa 9OnzViIIb94XVrctv/9XjIhymkF22TLapQml+mBW6mmOtfXvgn04RO6/UkOtOqeiJirU 7718cwoiNj3eb68yIfqG59iqQYb2oNTOyhWC/U/piw4n+H+Pp78vCSMZmGIXQpNvAkdZ fk0Letgh/HrO9nwIVdIFmH+ibXJTAiLQwNjdQavdNr/S+YmECxwxn7cq1mMppyNj2B91 qzpg== X-Gm-Message-State: APf1xPAWPMzNxQcMI1fWO6AaFtUHRlCQPjdSeGZZHv4kgRvA8HEOfPo9 HddtmtjNskfuDKGoHPm6oybppg== X-Google-Smtp-Source: AH8x227itEoPbM1tpMI9mY5KA/c+gwcCfNWBCAFQvQWm4KK1YSfAl5AOeve7G1F9eWYiGwBGYJgm+Q== X-Received: by 10.107.14.73 with SMTP id 70mr12398101ioo.258.1518876754932; Sat, 17 Feb 2018 06:12:34 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r13sm22938935ioa.4.2018.02.17.06.12.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Feb 2018 06:12:33 -0800 (PST) From: Noam Postavsky To: Rainer Orth Subject: Re: bug#30346: lcms.c doesn't compile when lcms.h isn't in default search path References: <874lmwfbfe.fsf@users.sourceforge.net> <83y3k773on.fsf@gnu.org> <83o9l26jf2.fsf@gnu.org> Date: Sat, 17 Feb 2018 09:12:32 -0500 In-Reply-To: (Rainer Orth's message of "Tue, 06 Feb 2018 19:53:50 +0100") Message-ID: <87d1137lin.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30346 Cc: Eli Zaretskii , 30346@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 30346 fixed close 30346 27.1 quit Rainer Orth writes: > Hi Eli, > >> Sorry, it's too late to make non-trivial changes in the build >> machinery of emacs-26 (if we start using lcms2.pc, it might expose us >> to issues we never saw since the lcms2 support was added to Emacs). > > Understood. > >> I think this problem is not too grave, since specifying CPPFLAGS at >> configure time solves it. > > Indeed: and there's even the patch in the bug :-) Pushed to master. [1: cb3863370c]: 2018-02-17 08:49:18 -0500 Use pkg-config to find lcms2 CFLAGS and LIBS (Bug#30346) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cb3863370cbe574810f796726faa39ba0de0a429 From unknown Sun Jun 22 17:10:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Mar 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 16:33:54 2019 Received: (at control) by debbugs.gnu.org; 22 Mar 2019 20:33:54 +0000 Received: from localhost ([127.0.0.1]:54722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7QrP-0005xJ-Ub for submit@debbugs.gnu.org; Fri, 22 Mar 2019 16:33:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7QrO-0005x7-3U for control@debbugs.gnu.org; Fri, 22 Mar 2019 16:33:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7QpX-0005C3-K7 for control@debbugs.gnu.org; Fri, 22 Mar 2019 16:33:37 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1h7QpX-0005FS-9f for control@debbugs.gnu.org; Fri, 22 Mar 2019 16:31:55 -0400 Subject: control message for bug 34946 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Fri, 22 Mar 2019 16:31:55 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 30346 forcemerge 30346 34946 From unknown Sun Jun 22 17:10:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Apr 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator