GNU bug report logs - #30343
make transpose-regions interactive

Previous Next

Full log

Message #25 received at 30343-done <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 30343-done <at> debbugs.gnu.org
Subject: Re: bug#30343: make transpose-regions interactive
Date: Sun, 11 Mar 2018 12:11:19 +0100

> Date: Sat, 10 Mar 2018 14:02:01 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> CC: 30343 <at> debbugs.gnu.org
> Reply-to: Eli Zaretskii <eliz <at> gnu.org>
> 
> This LGTM, thanks.  One minor comment:
> 
> > +Interactively, STARTR1 and ENDR1 are point and mark; STARTR2 and ENDR2
> > +are the last two marks pushed to the mark ring; LEAVE-MARKERS is nil.
> > +If a prefix argument N is given, STARTR2 and ENDR2 are the two
> > +successive marks N entries backwards in the mark ring.  A negative
> > +prefix argument instead counts forwards from the oldest mark in the
> 
> Please use "back" in "forward" here, instead of "backwards" and
> "forwards".  ("Backwards" has a meaning that might confuse readers
> here.)

Thanks again for the review, it's pushed now with your doc fix.

commit b88e7c8bcd523f1f503f87a1734679405322b5ec
Date:   Sun Mar 11 11:59:01 2018 +0100

  Make transpose-regions interactive (Bug#30343)
  
  * doc/emacs/fixit.texi (Transpose): Mention and explain the new
  command.
  * editfns.c (Ftranspose_regions): Add an interactive calling
  specification, and add documentation for it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.