GNU bug report logs - #30342
25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement

Previous Next

Package: emacs;

Reported by: Daniel Brooks <db48x <at> db48x.net>

Date: Sun, 4 Feb 2018 01:15:02 UTC

Severity: wishlist

Tags: notabug, wontfix

Found in version 25.3

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Daniel Brooks <db48x <at> db48x.net>
Cc: 30342 <at> debbugs.gnu.org
Subject: bug#30342: 25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement
Date: Sat, 03 Feb 2018 21:14:41 -0500

Daniel Brooks <db48x <at> db48x.net> writes:

> I happened to be looking at this function and noticed that both sides of
> the with_background condition do exactly the same thing; I'm sure it
> gradually got so.
>
> http://git.savannah.gnu.org/cgit/emacs.git/tree/src/xfont.c#n1046

They don't do *exactly* the same thing, one calls XDrawString and the
other XDrawImageString.
This bug report was last modified 7 years and 109 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.