GNU bug report logs - #30342
25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: db48x <at> db48x.net, 30342 <at> debbugs.gnu.org
Subject: bug#30342: 25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement
Date: Sun, 04 Feb 2018 18:17:58 +0200

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Sat, 03 Feb 2018 21:14:41 -0500
> Cc: 30342 <at> debbugs.gnu.org
> 
> Daniel Brooks <db48x <at> db48x.net> writes:
> 
> > I happened to be looking at this function and noticed that both sides of
> > the with_background condition do exactly the same thing; I'm sure it
> > gradually got so.
> >
> > http://git.savannah.gnu.org/cgit/emacs.git/tree/src/xfont.c#n1046
> 
> They don't do *exactly* the same thing, one calls XDrawString and the
> other XDrawImageString.

Right.  So I think there's no problem here, and this bug can be
closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.