Subject: Re: [bug#30341] [PATCH 3/4] gnu: Add python-curtsies.

From: Marius Bakke <[email-masked]>
Date: Thu, 15 Feb 2018 13:07:36 +0100

Hartmut Goebel <[email-masked]> writes:

> * gnu/packages/python.scm (python-curtsies, python2-curtsies): New variables.

Also fit for terminals.scm, I think.

> ---
>  gnu/packages/python.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 61739ceb6..49b698f3d 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -12488,3 +12488,39 @@ than a terminal.")
>  
>  (define-public python2-blessings
>    (package-with-python2 python-blessings))
> +
> +(define-public python-curtsies
> +  (package
> +    (name "python-curtsies")
> +    (version "0.2.11")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "curtsies" version))
> +        (sha256
> +          (base32

Please run the indentation of all these through emacs :-)

> +           "1vljmw3sy6lrqahhpyg4gk13mzcx3mwhvg8s41698ms3cpgkjipc"))))
> +    (build-system python-build-system)
> +   (arguments
> +    `(#:phases
> +      (modify-phases %standard-phases
> +        (replace 'check
> +          (lambda _
> +            (zero? (system* "nosetests" "-v")))))))

Use (invoke ...) instead of (zero? (system* ...)).

Other than that LGTM.

> +    (propagated-inputs
> +     `(("python-blessings" ,python-blessings)
> +       ("python-wcwidth", python-wcwidth)))
> +    (native-inputs
> +     `(("python-mock" ,python-mock)
> +       ("python-pyte" ,python-pyte)
> +       ("python-nose" ,python-nose)))
> +    (home-page "https://github.com/thomasballinger/curtsies")
> +    (synopsis "Library for curses-like terminal interaction with colored
> +strings")
> +    (description "Curtsies is a Python library for interacting with the
> +terminal.  It features string-like objects which carry formatting information,
> +per-line fullscreen terminal rendering, and keyboard input event reporting.")
> +    (license license:expat)))
> +
> +(define-public python2-curtsies
> +  (package-with-python2 python-curtsies))
> -- 
> 2.13.6