From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 0/6] Adopt NixOS patches for Qt5 Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2018 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15176857525389 (code B ref -1); Sat, 03 Feb 2018 19:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Feb 2018 19:22:32 +0000 Received: from localhost ([127.0.0.1]:55914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3OS-0001Or-LH for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3OR-0001Oe-2V for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei3OL-0006RT-4P for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ei3OL-0006RL-13 for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei3OJ-0007XG-Tq for guix-patches@gnu.org; Sat, 03 Feb 2018 14:22:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei3OG-0006My-OP for guix-patches@gnu.org; Sat, 03 Feb 2018 14:22:23 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:40537) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ei3OG-0006LP-HX for guix-patches@gnu.org; Sat, 03 Feb 2018 14:22:20 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkJB60XTz1qs09 for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkJB5wq3z1qqkK for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 8WobJT9KDlJE for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 5BD8560821 for ; Sat, 3 Feb 2018 20:22:12 +0100 (CET) From: Hartmut Goebel Date: Sat, 3 Feb 2018 20:22:12 +0100 Message-Id: <20180203192212.29173-1-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I reviewed the patches NixOS aplies to Qt 5.9 and 5.10. The changes of this series hold the result. I stepped over these when trying to make KDE Plasma work. Most changes are about using store-paths to other packages and for dynamically loaded libs. To ease futuer work, I also added comments about patches we do not need and why. Hartmut Goebel (6): gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. gnu: qtdeclarative: Add note about a patch NixOS has but we don't need. gnu: qtscript: Add note about a patch NixOS has but we don't need. gnu: qtserialport: Use the store paths for dynamically loaded libs. gnu: qttools: Add note about a patch NixOS has but we don't need. gnu: qtwebkit: Add note about a patch NixOS has but we don't need. gnu/packages/qt.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 61 insertions(+), 1 deletion(-) -- 2.13.6 From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> In-Reply-To: <20180203192212.29173-1-h.goebel@crazy-compilers.com> Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2018 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15176859115695 (code B ref 30340); Sat, 03 Feb 2018 19:26:02 +0000 Received: (at 30340) by debbugs.gnu.org; 3 Feb 2018 19:25:11 +0000 Received: from localhost ([127.0.0.1]:55924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R1-0001Tm-9O for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:11 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:56499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3Qz-0001TW-Cz for 30340@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:09 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkMS2r6Nz1qsTG for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:08 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkMS1pm2z1qqkK for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:08 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id YXTjLD4a3a5V for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:07 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:07 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 0A61160821 for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:06 +0100 (CET) From: Hartmut Goebel Date: Sat, 3 Feb 2018 20:25:00 +0100 Message-Id: <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Adobt the NixOS patches as of 2018-01-19: - .cmake.in and .prf files are not patches. - src/corelib/tools/qtimezoneprivate_tz.cpp: NixOS uses $TZDIR, we use hardcoded path to tzdata. - src/corelib/kernel/qcoreapplication.cpp: NixOS adds plugin paths derived from PATH. We do not need this, since we have native-search-path QT_PLUGIN_PATH. - src/network/kernel/qdnslookup_unix.cpp, src/network/kernel/qhostinfo_unix.cpp: Use hardcoded path to libresolv. - src/network/ssl/qsslcontext_openssl.cpp: NixOS changes a conditional compilation for Qt 5.9 (but leaves it unchanged for Qt 5.10) to fix compilation with libressl. But Qt does not support libressl anway, see config.tests/openssl/openssl.cpp in qtbase 5.9.4. - src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp: Use hardcoded path to libx11. - src/plugins/platforms/xcb/gl_integrations/xcb_glx/qglxintegration.cpp: Use hardcoded path to mess's libGL, no need for a fall-back. - src/plugins/platforms/xcb/qxcbcursor.cpp: Use hardcoded path to Xcursor. - src/plugins/platformthemes/gtk3/main.cpp: NixOS changes $XDG_DATA_DIRS and $GIO_EXTRA_MODULES in the code. We use search-path-specification for this. - src/testlib/qtestassert.h: Unchanged for guix. * gnu/packages/qt.scm (qtbase) Add comment. [inputs]: Add tzdata. [aguments]: Add 'patch-paths'. --- gnu/packages/qt.scm | 39 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 8bd51ae66..606c5035a 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -35,6 +35,7 @@ #:use-module (guix packages) #:use-module (guix utils) #:use-module (gnu packages) + #:use-module (gnu packages base) #:use-module (gnu packages bison) #:use-module (gnu packages compression) #:use-module (gnu packages cups) @@ -430,6 +431,7 @@ developers using C++ or QML, a CSS & JavaScript like language.") ("postgresql" ,postgresql) ("pulseaudio" ,pulseaudio) ("sqlite" ,sqlite) + ("tzdata" ,tzdata) ("unixodbc" ,unixodbc) ("xcb-util" ,xcb-util) ("xcb-util-image" ,xcb-util-image) @@ -540,7 +542,42 @@ developers using C++ or QML, a CSS & JavaScript like language.") "qt_config.prf" "winrt/package_manifest.prf")) (("\\$\\$\\[QT_HOST_DATA/get\\]") archdata) (("\\$\\$\\[QT_HOST_DATA/src\\]") archdata)) - #t)))))) + #t))) + (add-after 'unpack 'patch-paths + ;; Use the absolute paths for dynamically loaded libs, otherwise + ;; the lib will be searched in the actual executable's RUNPATH, + ;; which may not include the requested lib. + (lambda* (#:key inputs #:allow-other-keys) + ;; tzdata + (substitute* "src/corelib/tools/qtimezoneprivate_tz.cpp" + (("\"/usr(/(share|lib)/zoneinfo/)" _ path _) + (string-append "\"" (assoc-ref inputs "tzdata") path))) + ;; libresolve. TODO: Check is this is really required + (let ((glibc (assoc-ref inputs ,(if (%current-target-system) + "cross-libc" "libc")))) + (substitute* '("src/network/kernel/qdnslookup_unix.cpp" + "src/network/kernel/qhostinfo_unix.cpp") + (("^\\s*(lib.setFileName\\(QLatin1String\\(\")(resolv\"\\)\\);)" _ a b) + (string-append a glibc "/lib/lib" b)))) + ;; X11/locale (compose path) + (substitute* "src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp" + ;; Don't search in /usr/…/X11/locale, … + (("^\\s*m_possibleLocations.append\\(QStringLiteral\\(\"/usr/.*/X11/locale\"\\)\\);" line) + (string-append "// " line)) + ;; … but use libx11's path + (("^\\s*(m_possibleLocations.append\\(QStringLiteral\\()X11_PREFIX \"(/.*/X11/locale\"\\)\\);)" _ a b) + (string-append a "\"" (assoc-ref inputs "libx11") b))) + ;; libGL + (substitute* "src/plugins/platforms/xcb/gl_integrations/xcb_glx/qglxintegration.cpp" + (("^\\s*(QLibrary lib\\(QLatin1String\\(\")(GL\"\\)\\);)" _ a b) + (string-append a (assoc-ref inputs "mesa") "/lib/lib" b))) + ;; libXcusor + (substitute* "src/plugins/platforms/xcb/qxcbcursor.cpp" + (("^\\s*(QLibrary xcursorLib\\(QLatin1String\\(\")(Xcursor\"\\), 1\\);)" _ a b) + (string-append a (assoc-ref inputs "libxcursor") "/lib/lib" b)) + (("^\\s*(xcursorLib.setFileName\\(QLatin1String\\(\")(Xcursor\"\\)\\);)" _ a b) + (string-append a (assoc-ref inputs "libxcursor") "/lib/lib" b))) + #t))))) (native-search-paths (list (search-path-specification (variable "QMAKEPATH") -- 2.13.6 From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 2/6] gnu: qtdeclarative: Add note about a patch NixOS has but we don't need. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2018 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15176859115702 (code B ref 30340); Sat, 03 Feb 2018 19:26:02 +0000 Received: (at 30340) by debbugs.gnu.org; 3 Feb 2018 19:25:11 +0000 Received: from localhost ([127.0.0.1]:55926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R1-0001Tp-Kd for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:11 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:35095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R0-0001Tf-O1 for 30340@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:10 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkMV1yWjz1qsTS for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:10 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkMV1tsvz1qqkK for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:10 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id dvd6GEaIZeFw for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:09 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:09 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 18EA360B27 for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:06 +0100 (CET) From: Hartmut Goebel Date: Sat, 3 Feb 2018 20:25:01 +0100 Message-Id: <20180203192505.29516-2-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/qt.scm(qtdeclarative): Add comment. --- gnu/packages/qt.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 606c5035a..9050fe113 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -773,6 +773,8 @@ xmlpatternsvalidator."))) (arguments (substitute-keyword-arguments (package-arguments qtsvg) ((#:tests? _ #f) #f))) ; TODO: Enable the tests + ;; Note: NixOS has a patch to add import paths derived from PATH. We do + ;; not need this, since we have native-search-path QML2_IMPORT_PATH. (native-inputs `(("perl" ,perl) ("pkg-config" ,pkg-config) -- 2.13.6 From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 3/6] gnu: qtscript: Add note about a patch NixOS has but we don't need. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2018 19:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15176859145718 (code B ref 30340); Sat, 03 Feb 2018 19:26:03 +0000 Received: (at 30340) by debbugs.gnu.org; 3 Feb 2018 19:25:14 +0000 Received: from localhost ([127.0.0.1]:55929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R3-0001UA-SL for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:14 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:47603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R2-0001Tt-2Y for 30340@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:12 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkMW3V2tz1qsh9 for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:11 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkMW2W1vz1qqkK for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:11 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 0ICD6K8vmuVn for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:10 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:10 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 3CEC160B42 for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:06 +0100 (CET) From: Hartmut Goebel Date: Sat, 3 Feb 2018 20:25:02 +0100 Message-Id: <20180203192505.29516-3-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --- gnu/packages/qt.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 9050fe113..45495dd6c 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -1127,6 +1127,9 @@ that helps in Qt development."))) ("qttools" ,qttools))) (inputs `(("qtbase" ,qtbase))) + ;; Note: NixOS has a patch to change a typedef in + ;; "src/3rdparty/javascriptcore/JavaScriptCore/wtf/Threading.h" to compile + ;; with glib-2.32. We don't need this, since we are using pthreads. (synopsis "Qt Script module") (description "Qt provides support for application scripting with ECMAScript. The following guides and references cover aspects of programming with -- 2.13.6 From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 4/6] gnu: qtserialport: Use the store paths for dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2018 19:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15176859175741 (code B ref 30340); Sat, 03 Feb 2018 19:26:03 +0000 Received: (at 30340) by debbugs.gnu.org; 3 Feb 2018 19:25:17 +0000 Received: from localhost ([127.0.0.1]:55933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R7-0001UW-2b for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:17 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:59750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R4-0001UH-RO for 30340@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:15 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkMZ2jvLz1qsTG for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:14 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkMZ2fWfz1qqkK for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:14 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id S7AlLOIsVuM9 for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:13 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:13 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 4FAF460BAE for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:06 +0100 (CET) From: Hartmut Goebel Date: Sat, 3 Feb 2018 20:25:03 +0100 Message-Id: <20180203192505.29516-4-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Adobt the NixOS patches as of 2018-01-19 for qtserialport. * gnu/packages/qt.scm(qtserialport)[#:phases]: New phase. --- gnu/packages/qt.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 45495dd6c..4fc108dac 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -1002,6 +1002,18 @@ compositor libraries."))) (inputs `(("qtbase" ,qtbase) ("eudev" ,eudev))) + (arguments + (substitute-keyword-arguments (package-arguments qtsvg) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'unpack 'patch-dlopen-paths + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "src/serialport/qtudev_p.h" + ;; Use the absolute path, otherwise the lib will be searched in + ;; the actual executable's RUNPATH, which may not include libudev. + (("^\\s*(udevLibrary->setFileNameAndVersion\\(QStringLiteral\\(\")(udev\"\\),\\s*[0-9]+\\);)" _ a b) + (string-append a (assoc-ref inputs "eudev") "/lib/lib" b))) + #t)))))) (synopsis "Qt Serial Port module") (description "The Qt Serial Port module provides the library for interacting with serial ports from within Qt."))) -- 2.13.6 From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 5/6] gnu: qttools: Add note about a patch NixOS has but we don't need. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2018 19:26:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15176859175747 (code B ref 30340); Sat, 03 Feb 2018 19:26:05 +0000 Received: (at 30340) by debbugs.gnu.org; 3 Feb 2018 19:25:17 +0000 Received: from localhost ([127.0.0.1]:55935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R7-0001UY-Jo for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:17 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:48363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R6-0001UP-LR for 30340@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:16 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkMc1KC3z1qsh9 for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:16 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkMc1Dm4z1qqkK for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:16 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 8I60u66xZuxH for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:15 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:15 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 623BA60BCF for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:06 +0100 (CET) From: Hartmut Goebel Date: Sat, 3 Feb 2018 20:25:04 +0100 Message-Id: <20180203192505.29516-5-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --- gnu/packages/qt.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 4fc108dac..e607b8248 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -1109,6 +1109,8 @@ positioning and geolocation plugins."))) (arguments (substitute-keyword-arguments (package-arguments qtsvg) ((#:tests? _ #f) #f))) ; TODO: Enable the tests + ;; Note: NixOS has a patch to fix path to qhelpgenerator in cmake files to + ;; fix a build-error in KDevelop. We don't experience the build-error. (native-inputs `(("perl" ,perl) ("qtdeclarative" ,qtdeclarative))) -- 2.13.6 From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 6/6] gnu: qtwebkit: Add note about a patch NixOS has but we don't need. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2018 19:26:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15176859205762 (code B ref 30340); Sat, 03 Feb 2018 19:26:05 +0000 Received: (at 30340) by debbugs.gnu.org; 3 Feb 2018 19:25:20 +0000 Received: from localhost ([127.0.0.1]:55938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R9-0001Us-Pq for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:19 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:59244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3R8-0001Ul-SQ for 30340@debbugs.gnu.org; Sat, 03 Feb 2018 14:25:19 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkMf2tHGz1qsTG for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:18 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkMf2q3Wz1qqkv for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:18 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id m0CJS_U5exiB for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:17 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:17 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 919F160C14 for <30340@debbugs.gnu.org>; Sat, 3 Feb 2018 20:25:06 +0100 (CET) From: Hartmut Goebel Date: Sat, 3 Feb 2018 20:25:05 +0100 Message-Id: <20180203192505.29516-6-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/qt.scm(qtwebkit): Add comment. --- gnu/packages/qt.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index e607b8248..dc20416aa 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -1956,6 +1956,10 @@ different kinds of sliders, and much more.") (arguments `(#:phases (modify-phases %standard-phases + ;; Note: NixOS has a patch to use the absolute path for loading + ;; libgtk-x11-2.0. We don't have gtk+ as an input and the respective + ;; files (e.g. in Source/WebCore/plugins/qt/) are not compiled at + ;; all. (add-before 'configure 'fix-qmlwebkit-plugins-rpath (lambda _ (substitute* "Source/WebKit/qt/declarative/experimental/experimental.pri" -- 2.13.6 From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 2/6] gnu: qtdeclarative: Add note about a patch NixOS has but we don't need. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15179071706335 (code B ref 30340); Tue, 06 Feb 2018 08:53:02 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 08:52:50 +0000 Received: from localhost ([127.0.0.1]:59497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiyzi-0001e7-6A for submit@debbugs.gnu.org; Tue, 06 Feb 2018 03:52:50 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiyzf-0001dy-5p for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 03:52:48 -0500 Received: from localhost (178.113.196.151.wireless.dyn.drei.com [178.113.196.151]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 1E4753360375; Tue, 6 Feb 2018 09:52:46 +0100 (CET) Date: Tue, 6 Feb 2018 09:52:44 +0100 From: Danny Milosavljevic Message-ID: <20180206095244.2bbee56a@scratchpost.org> In-Reply-To: <20180203192505.29516-2-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180203192505.29516-2-h.goebel@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) LGTM! From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 3/6] gnu: qtscript: Add note about a patch NixOS has but we don't need. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 08:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15179071986407 (code B ref 30340); Tue, 06 Feb 2018 08:54:02 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 08:53:18 +0000 Received: from localhost ([127.0.0.1]:59501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz0A-0001fH-Et for submit@debbugs.gnu.org; Tue, 06 Feb 2018 03:53:18 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:39448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz08-0001f9-V8 for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 03:53:17 -0500 Received: from localhost (178.113.196.151.wireless.dyn.drei.com [178.113.196.151]) by dd26836.kasserver.com (Postfix) with ESMTPSA id CD9253360375; Tue, 6 Feb 2018 09:53:15 +0100 (CET) Date: Tue, 6 Feb 2018 09:53:14 +0100 From: Danny Milosavljevic Message-ID: <20180206095314.25405f3d@scratchpost.org> In-Reply-To: <20180203192505.29516-3-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180203192505.29516-3-h.goebel@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) LGTM! From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 5/6] gnu: qttools: Add note about a patch NixOS has but we don't need. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 08:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15179072816548 (code B ref 30340); Tue, 06 Feb 2018 08:55:01 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 08:54:41 +0000 Received: from localhost ([127.0.0.1]:59505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz1V-0001hY-N8 for submit@debbugs.gnu.org; Tue, 06 Feb 2018 03:54:41 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:39528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz1T-0001hQ-Q3 for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 03:54:40 -0500 Received: from localhost (178.113.196.151.wireless.dyn.drei.com [178.113.196.151]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 9A8B73360375; Tue, 6 Feb 2018 09:54:38 +0100 (CET) Date: Tue, 6 Feb 2018 09:54:36 +0100 From: Danny Milosavljevic Message-ID: <20180206095436.6f93eb54@scratchpost.org> In-Reply-To: <20180203192505.29516-5-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180203192505.29516-5-h.goebel@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) LGTM! From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 4/6] gnu: qtserialport: Use the store paths for dynamically loaded libs. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15179073676704 (code B ref 30340); Tue, 06 Feb 2018 08:57:02 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 08:56:07 +0000 Received: from localhost ([127.0.0.1]:59509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz2s-0001k4-Vx for submit@debbugs.gnu.org; Tue, 06 Feb 2018 03:56:07 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:39634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz2q-0001ju-Q6 for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 03:56:05 -0500 Received: from localhost (178.113.196.151.wireless.dyn.drei.com [178.113.196.151]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 2F07F3360375; Tue, 6 Feb 2018 09:56:03 +0100 (CET) Date: Tue, 6 Feb 2018 09:55:59 +0100 From: Danny Milosavljevic Message-ID: <20180206095559.5d224217@scratchpost.org> In-Reply-To: <20180203192505.29516-4-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180203192505.29516-4-h.goebel@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, 3 Feb 2018 20:25:03 +0100 Hartmut Goebel wrote: > Adobt the NixOS patches as of 2018-01-19 for qtserialport. ^p LGTM otherwise. From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 6/6] gnu: qtwebkit: Add note about a patch NixOS has but we don't need. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15179074776875 (code B ref 30340); Tue, 06 Feb 2018 08:58:01 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 08:57:57 +0000 Received: from localhost ([127.0.0.1]:59513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz4f-0001mp-CD for submit@debbugs.gnu.org; Tue, 06 Feb 2018 03:57:57 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:39784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz4b-0001me-V8 for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 03:57:55 -0500 Received: from localhost (178.113.196.151.wireless.dyn.drei.com [178.113.196.151]) by dd26836.kasserver.com (Postfix) with ESMTPSA id D2E933360375; Tue, 6 Feb 2018 09:57:52 +0100 (CET) Date: Tue, 6 Feb 2018 09:57:49 +0100 From: Danny Milosavljevic Message-ID: <20180206095749.00da401d@scratchpost.org> In-Reply-To: <20180203192505.29516-6-h.goebel@crazy-compilers.com> References: <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180203192505.29516-6-h.goebel@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: LGTM! [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.145.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [85.13.145.193 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) LGTM! From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 09:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151790766411539 (code B ref 30340); Tue, 06 Feb 2018 09:02:01 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 09:01:04 +0000 Received: from localhost ([127.0.0.1]:59518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz7f-0002zq-Qz for submit@debbugs.gnu.org; Tue, 06 Feb 2018 04:01:03 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:40068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiz7e-0002xh-1B for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 04:01:02 -0500 Received: from localhost (178.113.196.151.wireless.dyn.drei.com [178.113.196.151]) by dd26836.kasserver.com (Postfix) with ESMTPSA id CB3983362292; Tue, 6 Feb 2018 10:01:00 +0100 (CET) Date: Tue, 6 Feb 2018 10:00:57 +0100 From: Danny Milosavljevic Message-ID: <20180206100057.5fce0725@scratchpost.org> In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > + ;; libresolve. TODO: Check is this is really required > + (let ((glibc (assoc-ref inputs ,(if (%current-target-system) > + "cross-libc" "libc")))) > + (substitute* '("src/network/kernel/qdnslookup_unix.cpp" > + "src/network/kernel/qhostinfo_unix.cpp") > + (("^\\s*(lib.setFileName\\(QLatin1String\\(\")(resolv\"\\)\\);)" _ a b) > + (string-append a glibc "/lib/lib" b)))) Any news on this? >+ ;; libXcu[ ]sor ^r Otherwise LGTM. From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15179182586673 (code B ref 30340); Tue, 06 Feb 2018 11:58:02 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 11:57:38 +0000 Received: from localhost ([127.0.0.1]:59600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej1sY-0001jZ-3x for submit@debbugs.gnu.org; Tue, 06 Feb 2018 06:57:38 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:43582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej1sV-0001jQ-MO for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 06:57:36 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zbNHf3kqrz1qvpF; Tue, 6 Feb 2018 12:57:34 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zbNHf2ZcTz1r2Zw; Tue, 6 Feb 2018 12:57:34 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ieCqXcjMsOab; Tue, 6 Feb 2018 12:57:33 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-174-233.dynamic.mnet-online.de [93.104.174.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Tue, 6 Feb 2018 12:57:33 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 2D06F6058E; Tue, 6 Feb 2018 12:57:33 +0100 (CET) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180206100057.5fce0725@scratchpost.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <08c9a446-3587-b1fe-b60e-d068d1861d0d@crazy-compilers.com> Date: Tue, 6 Feb 2018 12:57:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180206100057.5fce0725@scratchpost.org> Content-Type: multipart/alternative; boundary="------------BDC404A36F16F2B805795B4B" Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------BDC404A36F16F2B805795B4B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Am 06.02.2018 um 10:00 schrieb Danny Milosavljevic: >> + ;; libresolve. TODO: Check is this is really required >> + (let ((glibc (assoc-ref inputs ,(if (%current-target-system) >> + "cross-libc" "libc")))) >> + (substitute* '("src/network/kernel/qdnslookup_unix.cpp" >> + "src/network/kernel/qhostinfo_unix.cpp") >> + (("^\\s*(lib.setFileName\\(QLatin1String\\(\")(resolv\"\\)\\);)" _ a b) >> + (string-append a glibc "/lib/lib" b)))) > Any news on this? > I'm afraid, I don't understand this question. I don't know if "this is really required", otherwise I would not have put the comment there. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------BDC404A36F16F2B805795B4B Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Am 06.02.2018 um 10:00 schrieb Danny Milosavljevic:
+             ;; libresolve. TODO: Check is this is really required
+             (let ((glibc (assoc-ref inputs ,(if (%current-target-system)
+                                                 "cross-libc" "libc"))))
+               (substitute* '("src/network/kernel/qdnslookup_unix.cpp"
+                              "src/network/kernel/qhostinfo_unix.cpp")
+                 (("^\\s*(lib.setFileName\\(QLatin1String\\(\")(resolv\"\\)\\);)" _ a b)
+                (string-append a glibc "/lib/lib" b))))

Any news on this?

I'm afraid, I don't understand this question. I don't know if "this is really required", otherwise I would not have put the comment there.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------BDC404A36F16F2B805795B4B-- From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Feb 2018 17:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151793969131258 (code B ref 30340); Tue, 06 Feb 2018 17:55:01 +0000 Received: (at 30340) by debbugs.gnu.org; 6 Feb 2018 17:54:51 +0000 Received: from localhost ([127.0.0.1]:60522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej7SF-000884-IW for submit@debbugs.gnu.org; Tue, 06 Feb 2018 12:54:51 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:55422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej7SD-00087v-6H for 30340@debbugs.gnu.org; Tue, 06 Feb 2018 12:54:49 -0500 Received: from localhost (178.113.196.151.wireless.dyn.drei.com [178.113.196.151]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 379193360102; Tue, 6 Feb 2018 18:54:47 +0100 (CET) Date: Tue, 6 Feb 2018 18:54:43 +0100 From: Danny Milosavljevic Message-ID: <20180206185443.171d146c@scratchpost.org> In-Reply-To: <08c9a446-3587-b1fe-b60e-d068d1861d0d@crazy-compilers.com> References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180206100057.5fce0725@scratchpost.org> <08c9a446-3587-b1fe-b60e-d068d1861d0d@crazy-compilers.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Hartmut, On Tue, 6 Feb 2018 12:57:32 +0100 Hartmut Goebel wrote: >>>[-lresolv -> glibc] > > Any news on this? > I'm afraid, I don't understand this question. I don't know if "this is > really required", otherwise I would not have put the comment there. Oh, I thought you investigated or asked someone upstream about it. I don't know Qt interna so well - but it would be possible to ask upstream. The part under discussion is static bool resolveLibraryInternal() { QLibrary lib; #ifdef LIBRESOLV_SO lib.setFileName(QStringLiteral(LIBRESOLV_SO)); if (!lib.load()) #endif { lib.setFileName(QLatin1String("resolv")); <----- if (!lib.load()) return false; ... so I guess it can't hurt to substitute something in the line with the arrow, but LIBRESOLV_SO is more important, right? From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Feb 2018 16:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel , 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151802022320858 (code B ref 30340); Wed, 07 Feb 2018 16:18:03 +0000 Received: (at 30340) by debbugs.gnu.org; 7 Feb 2018 16:17:03 +0000 Received: from localhost ([127.0.0.1]:33397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejSP9-0005QM-4i for submit@debbugs.gnu.org; Wed, 07 Feb 2018 11:17:03 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejSP7-0005Pu-Lc for 30340@debbugs.gnu.org; Wed, 07 Feb 2018 11:17:02 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4AE6420F66; Wed, 7 Feb 2018 11:17:01 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Wed, 07 Feb 2018 11:17:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=0InL8kygjQjVrij4ziESVFdbR09YJbw4lsNdSs3Q3y0=; b=lAZFNbTP 3js1PiejBveaJgtnNdeBwcZRsQCfKoybmqL1WPphcHpxabNEmMYD1QjKBLotocKX TM5+gNiJXxxpSKw79YlRcO2tlDbyMB9q2OoKLFRvYfJgZ0T88sFHqnJuccH2FjTU hb/GTlJDlOAVe7iEyYkAIZ3bWCk6R7/UH4rUTu3Q1Xi+lIMId0L4bKmm/f32DAhJ YHfBoAXwDA/6Pm9DJiUP3mewV0RxWTHeaGK53OoMjiYUiF7qgHycEOHf5AzimjlR m/aFV0lqt3pahTZo9dAknzjN748YfPa16rvYIlTwVfZY1zb22RWQtI+G8/AgnRZq 7puXaSqiUU96oA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=0InL8kygjQjVrij4ziESVFdbR09YJ bw4lsNdSs3Q3y0=; b=fit5Vz4D9ZnzHe7/BuZDr2cL4YWtW4gha/cfmnCOvjLkF MKMHQYw0IlaKkHmmAj9rbaiqMqvHn1DMuxz9uvqUyH0xcDGbLr2XkLSQCHQy6t+A D5R+DpXg82lZPBeMVVTVDM2iMLRg6s22+wq/ZSjdW5gYwOyDiSX+qLvIW24YLMGI 506wFrdUiXl7yreQeW24ya8DXbhEIyG9BuJ21OG7929mpu9JI2THfuROorNnvvEA BCpmaoYoFYY5nd4uAP++Pr9e2OEcDU27dgq2v47aRUyAn+gmkpoxuttF3B3QdGYj q5DVn5la6VhdKPFAR2CefCgcm5tnaqbxWZwHU6KHQ== X-ME-Sender: Received: from localhost (ip-86-49-249-109.net.upcbroadband.cz [86.49.249.109]) by mail.messagingengine.com (Postfix) with ESMTPA id CA83624550; Wed, 7 Feb 2018 11:17:00 -0500 (EST) From: Marius Bakke In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Wed, 07 Feb 2018 17:16:59 +0100 Message-ID: <87k1voixl0.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hartmut Goebel writes: > Adobt the NixOS patches as of 2018-01-19: I don't see any patches in this series. FWIW I think we deviate enough from NixOS at this point that the comments are unnecessary. > - .cmake.in and .prf files are not patches. > > - src/corelib/tools/qtimezoneprivate_tz.cpp: NixOS uses $TZDIR, we use > hardcoded path to tzdata. Why hardcode the path? We set TZDIR as well in (gnu system). [...] > @@ -540,7 +542,42 @@ developers using C++ or QML, a CSS & JavaScript like= language.") > "qt_config.prf" "winrt/package_manifest.prf")) > (("\\$\\$\\[QT_HOST_DATA/get\\]") archdata) > (("\\$\\$\\[QT_HOST_DATA/src\\]") archdata)) > - #t)))))) > + #t))) > + (add-after 'unpack 'patch-paths > + ;; Use the absolute paths for dynamically loaded libs, otherw= ise > + ;; the lib will be searched in the actual executable's RUNPAT= H, > + ;; which may not include the requested lib. Is there any reason we cannot add these libraries to RUNPATH instead? The below approach seems somewhat fragile to me. > + (lambda* (#:key inputs #:allow-other-keys) > + ;; tzdata > + (substitute* "src/corelib/tools/qtimezoneprivate_tz.cpp" > + (("\"/usr(/(share|lib)/zoneinfo/)" _ path _) > + (string-append "\"" (assoc-ref inputs "tzdata") path))) > + ;; libresolve. TODO: Check is this is really required > + (let ((glibc (assoc-ref inputs ,(if (%current-target-system) > + "cross-libc" "libc")))) > + (substitute* '("src/network/kernel/qdnslookup_unix.cpp" > + "src/network/kernel/qhostinfo_unix.cpp") > + (("^\\s*(lib.setFileName\\(QLatin1String\\(\")(resolv\"= \\)\\);)" _ a b) > + (string-append a glibc "/lib/lib" b)))) > + ;; X11/locale (compose path) > + (substitute* "src/plugins/platforminputcontexts/compose/gen= erator/qtablegenerator.cpp" > + ;; Don't search in /usr/=E2=80=A6/X11/locale, =E2=80=A6 > + (("^\\s*m_possibleLocations.append\\(QStringLiteral\\(\"/= usr/.*/X11/locale\"\\)\\);" line) > + (string-append "// " line)) > + ;; =E2=80=A6 but use libx11's path > + (("^\\s*(m_possibleLocations.append\\(QStringLiteral\\()X= 11_PREFIX \"(/.*/X11/locale\"\\)\\);)" _ a b) > + (string-append a "\"" (assoc-ref inputs "libx11") b))) > + ;; libGL > + (substitute* "src/plugins/platforms/xcb/gl_integrations/xcb= _glx/qglxintegration.cpp" > + (("^\\s*(QLibrary lib\\(QLatin1String\\(\")(GL\"\\)\\);)"= _ a b) > + (string-append a (assoc-ref inputs "mesa") "/lib/lib" b)= )) > + ;; libXcusor > + (substitute* "src/plugins/platforms/xcb/qxcbcursor.cpp" > + (("^\\s*(QLibrary xcursorLib\\(QLatin1String\\(\")(Xcurso= r\"\\), 1\\);)" _ a b) > + (string-append a (assoc-ref inputs "libxcursor") "/lib/l= ib" b)) > + (("^\\s*(xcursorLib.setFileName\\(QLatin1String\\(\")(Xcu= rsor\"\\)\\);)" _ a b) > + (string-append a (assoc-ref inputs "libxcursor") "/lib/l= ib" b))) > + #t))))) > (native-search-paths > (list (search-path-specification > (variable "QMAKEPATH") > --=20 > 2.13.6 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlp7JnsACgkQoqBt8qM6 VPoyOAgAiLqfZLEZMGwAPDBn/eV8e9P3vyvTngtrYUIXgdTVCVdYiCoxDmUAQ6k1 sm8VIaEhDbx1DL8ulpBKb3jDNCfkBEdCcS48MM45KqWJbrYryNLwXF2pCnnYV0gR U0vuglZpsrjxlQGtjI1tY6wIK2UGvwcQMVgNZ2MdgGapihC9B+3qJ5ekTJC57efo XjIBYBReA86UpjUg3uV/oDOYEo97u3F/rdJ/C3mZ7P0ksscsBIwjz0yR8JbzKDsY fyKl6Iv294CYcGwOJDKMRSomB+d0KCznfLRnnI/WIVoOE4qO5z7nDYKsvSjhtut8 rQctAnTHEGpCjfOkazuZu5KhYvJr3A== =9vT6 -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Feb 2018 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15181337626275 (code B ref 30340); Thu, 08 Feb 2018 23:50:02 +0000 Received: (at 30340) by debbugs.gnu.org; 8 Feb 2018 23:49:22 +0000 Received: from localhost ([127.0.0.1]:34475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejvwQ-0001d8-2I for submit@debbugs.gnu.org; Thu, 08 Feb 2018 18:49:22 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:35890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejvwO-0001d1-VZ for 30340@debbugs.gnu.org; Thu, 08 Feb 2018 18:49:21 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zcvzz6JNVz1qsWF; Fri, 9 Feb 2018 00:49:19 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zcvzz666Rz1qqkK; Fri, 9 Feb 2018 00:49:19 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id jNg8X1v4vZI7; Fri, 9 Feb 2018 00:49:19 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-83-171-149-3.dynamic.mnet-online.de [83.171.149.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Fri, 9 Feb 2018 00:49:19 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id B576060907; Fri, 9 Feb 2018 00:49:18 +0100 (CET) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <20180206100057.5fce0725@scratchpost.org> <08c9a446-3587-b1fe-b60e-d068d1861d0d@crazy-compilers.com> <20180206185443.171d146c@scratchpost.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: Date: Fri, 9 Feb 2018 00:49:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180206185443.171d146c@scratchpost.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Danny, Am 06.02.2018 um 18:54 schrieb Danny Milosavljevic: > The part under discussion is > static bool resolveLibraryInternal() > { > QLibrary lib; > #ifdef LIBRESOLV_SO > lib.setFileName(QStringLiteral(LIBRESOLV_SO)); > if (!lib.load()) > #endif > { > lib.setFileName(QLatin1String("resolv")); <----- > if (!lib.load()) > return false; > ... > > so I guess it can't hurt to substitute something in the line with the arrow, > but LIBRESOLV_SO is more important, right? Thanks a lot for this valuable hint! I investigated this: 1) LIBRESOLV_SO seems to be not defined. The reason seems to be that __GNU_LIBRARY__ is not defined and thus gnu/lib-names.h is not included. (I grepped the code and build-reesults just after the build stage.) 2) Even if LIBRESOLV_SO would be defined, we would need to append the store path. (No problem, though.) Any idea how to solve 1)? -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Feb 2018 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.15181838288553 (code B ref 30340); Fri, 09 Feb 2018 13:44:01 +0000 Received: (at 30340) by debbugs.gnu.org; 9 Feb 2018 13:43:48 +0000 Received: from localhost ([127.0.0.1]:34776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ek8xw-0002Dt-Ah for submit@debbugs.gnu.org; Fri, 09 Feb 2018 08:43:48 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:47692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ek8xt-0002Dk-Rq for 30340@debbugs.gnu.org; Fri, 09 Feb 2018 08:43:46 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CA1FF1119B; Fri, 9 Feb 2018 14:43:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1xR7uZmJZTv7; Fri, 9 Feb 2018 14:43:44 +0100 (CET) Received: from ribbon (unknown [193.50.110.130]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DED7F6FAE; Fri, 9 Feb 2018 14:43:43 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 =?UTF-8?Q?Pluvi=C3=B4se?= an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 09 Feb 2018 14:43:43 +0100 In-Reply-To: <20180203192505.29516-1-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Sat, 3 Feb 2018 20:25:00 +0100") Message-ID: <87mv0i1do0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Hartmut, This sounds like a great improvement! Hartmut Goebel skribis: > Adobt the NixOS patches as of 2018-01-19: > > - .cmake.in and .prf files are not patches. > > - src/corelib/tools/qtimezoneprivate_tz.cpp: NixOS uses $TZDIR, we use > hardcoded path to tzdata. > > - src/corelib/kernel/qcoreapplication.cpp: NixOS adds plugin paths derived > from PATH. We do not need this, since we have native-search-path > QT_PLUGIN_PATH. > > - src/network/kernel/qdnslookup_unix.cpp, > src/network/kernel/qhostinfo_unix.cpp: Use hardcoded path to libresolv. > > - src/network/ssl/qsslcontext_openssl.cpp: NixOS changes a conditional > compilation for Qt 5.9 (but leaves it unchanged for Qt 5.10) to fix > compilation with libressl. But Qt does not support libressl anway, see > config.tests/openssl/openssl.cpp in qtbase 5.9.4. > > - src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp: > Use hardcoded path to libx11. > > - src/plugins/platforms/xcb/gl_integrations/xcb_glx/qglxintegration.cpp: > Use hardcoded path to mess's libGL, no need for a fall-back. > > - src/plugins/platforms/xcb/qxcbcursor.cpp: Use hardcoded path to Xcursor. > > - src/plugins/platformthemes/gtk3/main.cpp: NixOS changes $XDG_DATA_DIRS = and > $GIO_EXTRA_MODULES in the code. We use search-path-specification for th= is. > > - src/testlib/qtestassert.h: Unchanged for guix. I don=E2=80=99t understand all of this (does it describe problems or soluti= ons? what does it mean =E2=80=9Cfiles are not patches=E2=80=9D? etc.) and I thin= k we should describe the problems/solutions on their own, without =E2=80=9CNixOS does t= his=E2=80=9D comments, which isn=E2=80=99t really helpful IMO. As an aside, I think explanations when they=E2=80=99re needed, should go in= the source, not in the commit log. > * gnu/packages/qt.scm (qtbase) Add comment. [inputs]: Add tzdata. > [aguments]: Add 'patch-paths'. [...] > + (add-after 'unpack 'patch-paths > + ;; Use the absolute paths for dynamically loaded libs, otherw= ise > + ;; the lib will be searched in the actual executable's RUNPAT= H, > + ;; which may not include the requested lib. > + (lambda* (#:key inputs #:allow-other-keys) > + ;; tzdata > + (substitute* "src/corelib/tools/qtimezoneprivate_tz.cpp" > + (("\"/usr(/(share|lib)/zoneinfo/)" _ path _) > + (string-append "\"" (assoc-ref inputs "tzdata") path))) > + ;; libresolve. TODO: Check is this is really required I think you can remove =E2=80=9CTODO=E2=80=9D here. > + (let ((glibc (assoc-ref inputs ,(if (%current-target-system) > + "cross-libc" "libc")))) > + (substitute* '("src/network/kernel/qdnslookup_unix.cpp" > + "src/network/kernel/qhostinfo_unix.cpp") > + (("^\\s*(lib.setFileName\\(QLatin1String\\(\")(resolv\"= \\)\\);)" _ a b) > + (string-append a glibc "/lib/lib" b)))) > + ;; X11/locale (compose path) > + (substitute* "src/plugins/platforminputcontexts/compose/gen= erator/qtablegenerator.cpp" > + ;; Don't search in /usr/=E2=80=A6/X11/locale, =E2=80=A6 > + (("^\\s*m_possibleLocations.append\\(QStringLiteral\\(\"/= usr/.*/X11/locale\"\\)\\);" line) > + (string-append "// " line)) > + ;; =E2=80=A6 but use libx11's path > + (("^\\s*(m_possibleLocations.append\\(QStringLiteral\\()X= 11_PREFIX \"(/.*/X11/locale\"\\)\\);)" _ a b) > + (string-append a "\"" (assoc-ref inputs "libx11") b))) > + ;; libGL > + (substitute* "src/plugins/platforms/xcb/gl_integrations/xcb= _glx/qglxintegration.cpp" > + (("^\\s*(QLibrary lib\\(QLatin1String\\(\")(GL\"\\)\\);)"= _ a b) > + (string-append a (assoc-ref inputs "mesa") "/lib/lib" b)= )) > + ;; libXcusor > + (substitute* "src/plugins/platforms/xcb/qxcbcursor.cpp" > + (("^\\s*(QLibrary xcursorLib\\(QLatin1String\\(\")(Xcurso= r\"\\), 1\\);)" _ a b) > + (string-append a (assoc-ref inputs "libxcursor") "/lib/l= ib" b)) > + (("^\\s*(xcursorLib.setFileName\\(QLatin1String\\(\")(Xcu= rsor\"\\)\\);)" _ a b) > + (string-append a (assoc-ref inputs "libxcursor") "/lib/l= ib" b))) > + #t))))) That makes sense to me, and actually, I don=E2=80=99t think it needs more explanations. :-) Did you notice improvements on KDE applications? So, LGTM! Thanks, Ludo=E2=80=99. From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Feb 2018 15:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 30340@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151844984331110 (code B ref 30340); Mon, 12 Feb 2018 15:38:01 +0000 Received: (at 30340) by debbugs.gnu.org; 12 Feb 2018 15:37:23 +0000 Received: from localhost ([127.0.0.1]:39860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elGAV-00085i-4a for submit@debbugs.gnu.org; Mon, 12 Feb 2018 10:37:23 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:35543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elGAT-00085a-69 for 30340@debbugs.gnu.org; Mon, 12 Feb 2018 10:37:21 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zg8tS415Xz1qqkl; Mon, 12 Feb 2018 16:37:20 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zg8tS3kbDz1r3T8; Mon, 12 Feb 2018 16:37:20 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id upHwj-7-qBKq; Mon, 12 Feb 2018 16:37:19 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-212-114-232-16.dynamic.mnet-online.de [212.114.232.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 12 Feb 2018 16:37:19 +0100 (CET) Received: from thisbe.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id F0BD360589; Mon, 12 Feb 2018 16:37:18 +0100 (CET) From: Hartmut Goebel References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> Organization: crazy-compilers.com Message-ID: <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> Date: Mon, 12 Feb 2018 16:37:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87k1voixl0.fsf@fastmail.com> Content-Type: multipart/alternative; boundary="------------A1D9A5DBB7E292A0D2F57F81" Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------A1D9A5DBB7E292A0D2F57F81 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Am 07.02.2018 um 17:16 schrieb Marius Bakke: > Hartmut Goebel writes: > >> Adobt the NixOS patches as of 2018-01-19: > I don't see any patches in this series. I only *adopted* what NixOs does with patches, not the patches itself. I will rework this. > FWIW I think we deviate enough > from NixOS at this point that the comments are unnecessary. Are you referring to patch (1/6)? Or do you mean patches 2, 3, 5 and 6 are unnecessary? I do not care about the comments, but FMPOV it is important to document somehow in the code or in the commits that all patches as of 2018-01-19 have been considered. an alternative would be to group these few commits into a (very short) branch and documenting the fact in the merge-commit. WDYT? >> - src/corelib/tools/qtimezoneprivate_tz.cpp: NixOS uses $TZDIR, we use >> hardcoded path to tzdata. > Why hardcode the path? We set TZDIR as well in (gnu system). The upstream code (qt.com) uses hard-coded path (/usr/share/zoneinfo/), so for me it seems to be much more natural to simply change this - and stay closer to upstream. NixOS seems to require TZDATA since some things work differently compared to guix. E.g. nixos is deriving library search paths from $PATH in some other patch. This is something guix does not need. >> + (add-after 'unpack 'patch-paths >> + ;; Use the absolute paths for dynamically loaded libs, otherwise >> + ;; the lib will be searched in the actual executable's RUNPATH, >> + ;; which may not include the requested lib. > Is there any reason we cannot add these libraries to RUNPATH instead? > The below approach seems somewhat fragile to me. Rethinking this, this comment is wrong and I'll correct it. QLibrary (which is used an all these cases) is documented with: When loading the library, QLibrary searches in all the system-specific library locations (e.g. |LD_LIBRARY_PATH| on Unix), unless the file name has an absolute path. But guix does not set LD_LIBRARYPATH (e.g. in "guix environment"), thus we need to have absolute paths for the libraries. Does this make sense? -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------A1D9A5DBB7E292A0D2F57F81 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Am 07.02.2018 um 17:16 schrieb Marius Bakke:
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:


Adobt the NixOS patches as of 2018-01-19:

I don't see any patches in this series.

I only *adopted* what NixOs does with patches, not the patches itself. I will rework this.

 FWIW I think we deviate enough
from NixOS at this point that the comments are unnecessary.

Are you referring to patch (1/6)? Or do you mean patches 2, 3, 5 and 6 are unnecessary?

I do not care about the comments, but FMPOV it is important to document somehow in the code or in the commits that all patches as of 2018-01-19 have been considered. an alternative would be to group these few commits into a (very short) branch and documenting the fact in the merge-commit.

WDYT?

- src/corelib/tools/qtimezoneprivate_tz.cpp: NixOS uses $TZDIR, we use
  hardcoded path to tzdata.

Why hardcode the path?  We set TZDIR as well in (gnu system).

The upstream code (qt.com) uses hard-coded path (/usr/share/zoneinfo/), so for me it seems to be much more natural to simply change this - and stay closer to upstream. NixOS seems to require TZDATA since some things work differently compared to guix. E.g. nixos is deriving library search paths from $PATH in some other patch. This is something guix does not need.

+         (add-after 'unpack 'patch-paths
+           ;; Use the absolute paths for dynamically loaded libs, otherwise
+           ;; the lib will be searched in the actual executable's RUNPATH,
+           ;; which may not include the requested lib.

Is there any reason we cannot add these libraries to RUNPATH instead?
The below approach seems somewhat fragile to me.

Rethinking this, this comment is wrong and I'll correct it. QLibrary (which is used an all these cases) is documented with:

When loading the library, QLibrary searches in all the system-specific library locations (e.g. LD_LIBRARY_PATH on Unix), unless the file name has an absolute path.
But guix does not set LD_LIBRARYPATH (e.g. in "guix environment"), thus we need to have absolute paths for the libraries.

Does this make sense?
-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------A1D9A5DBB7E292A0D2F57F81-- From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Feb 2018 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Marius Bakke , 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.1518451163506 (code B ref 30340); Mon, 12 Feb 2018 16:00:02 +0000 Received: (at 30340) by debbugs.gnu.org; 12 Feb 2018 15:59:23 +0000 Received: from localhost ([127.0.0.1]:39876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elGVm-000086-UP for submit@debbugs.gnu.org; Mon, 12 Feb 2018 10:59:23 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:36738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elGVi-00007v-VV for 30340@debbugs.gnu.org; Mon, 12 Feb 2018 10:59:19 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zg9Mp125kz1r2sL; Mon, 12 Feb 2018 16:59:18 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zg9Mn73SMz1r3TB; Mon, 12 Feb 2018 16:59:17 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id y_Kh6TJf527z; Mon, 12 Feb 2018 16:59:17 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-212-114-232-16.dynamic.mnet-online.de [212.114.232.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 12 Feb 2018 16:59:17 +0100 (CET) Received: from thisbe.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id AA87B60589; Mon, 12 Feb 2018 16:59:16 +0100 (CET) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87mv0i1do0.fsf@gnu.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <30c8ed79-2d93-9160-1006-94e9dac8fe03@crazy-compilers.com> Date: Mon, 12 Feb 2018 16:59:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87mv0i1do0.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, Am 09.02.2018 um 14:43 schrieb Ludovic Courtès: > This sounds like a great improvement! Thanks. > I don’t understand all of this (does it describe problems or solutions? > what does it mean “files are not patches”? etc.) and I think we should > describe the problems/solutions on their own, without “NixOS does this” > comments, which isn’t really helpful IMO. > > As an aside, I think explanations when they’re needed, should go in the > source, not in the commit log. My idea is to use the commit message to document: "We reviewed the NixOS patches as of 2018-01-09, and this is what we decided how to handle the respective changes." (This might still be worth rewriting.) This will give confidence that all patches are considered to the ones working on this next. In contrast the code comments only document the actual code for the case one doesn't cares about how/whether the code follows NixOS. (As you already commented.)  you mean patches 2, 3, 5 and 6 are unnecessary? I'm not even sure it we'd better remove all the refernces to NixOs from this change and only document it in commit messages. We could group these few commits into a (very short) branch, drop patches 2, 3, 5 and 6, and documenting "considered all NixOS patched: Not needed, … etc." in the merge-commit: * Merge branch 'nixos patches for Qt 5.9' into master. |\ | * gnu: qtserialport: Use the store paths for dynamically | * gnu: qtbase: Use the store paths for |/ The comments currently in patch 2, 3, 5, and 6 would into the Merge commit's message. WDYT? > I think you can remove “TODO” here. ACK. > Did you notice improvements on KDE applications? KDE Plasma feels to be more stable with these changes applied. I can't proof it's these changes, since I have a similar series for KF5. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Feb 2018 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel , 30340@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151856210316332 (code B ref 30340); Tue, 13 Feb 2018 22:49:01 +0000 Received: (at 30340) by debbugs.gnu.org; 13 Feb 2018 22:48:23 +0000 Received: from localhost ([127.0.0.1]:41907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eljN9-0004FL-73 for submit@debbugs.gnu.org; Tue, 13 Feb 2018 17:48:23 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eljN7-0004FE-9d for 30340@debbugs.gnu.org; Tue, 13 Feb 2018 17:48:21 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CE09A21855; Tue, 13 Feb 2018 17:48:20 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 13 Feb 2018 17:48:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=tRoIOIOYuSdVSIDNlUZH+x5bi1ldBwakSgw3v/q8N9M=; b=a+dCL2na sB1VevZafKbrteBC1fFeePeiTlaWXgnqdftn5mCIFZZAvD/xN+p8kIfjSLUjOzTj lHKs74H580n32ofktRflza86wpBbgw6TTTdQMeCXqueMQAOj+BfoAdV6H6mv2ZHg sEODVhM/abiHqs+A+cc+ukLpj8WqMLNB4neLniO/+FfRgrDQbkclgDUeHHVDIzXl 1Fdx1pj73nPXczeqCPoWE8s380KJzmjQ8V1jOqgK0wM2EctdqLquXdG1Fy0mznUV ah7G+/GIMV1hVc7TN09MhPr1NHldwi4G2IvEuYJ+2Sh9ec9Buft+I/cqJsUZMXBq dvAFEp4Bu7Rs/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=tRoIOIOYuSdVSIDNlUZH+x5bi1ldB wakSgw3v/q8N9M=; b=iL/3s8ocvYNzBHHcz/e45gZ0yheSz14cWeDFg7hh1Lb1R vZ40TqsSpRZZdszXS66ouWmjquJyByBWR2j0wcfFkhqTZtuZpzVR0O59jNjSZjYM JyLx8J3WU/XGShfYBvwC11yoqtNgS4NfsjxgCYslkNVe4/9vbD6yrC9qB5zwTNUA jhI5LKW5uHVfdC933SrQlxSQEdGq+49aZyhph7tmR8akW0kIivbBMGlmIaw+eXPz //gaY4VkGEjHAewvsnz7JWxN9x0QHMqMBpRkiUotX8PjO0SgW4uXV+n4o+C0dY3f nST/q4xtdYtfYPqYeKlxxDGsrBySww5hwuyokf3VQ== X-ME-Sender: Received: from localhost (unknown [212.7.159.74]) by mail.messagingengine.com (Postfix) with ESMTPA id 616B07E520; Tue, 13 Feb 2018 17:48:20 -0500 (EST) From: Marius Bakke In-Reply-To: <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Tue, 13 Feb 2018 23:48:18 +0100 Message-ID: <87sha4wlot.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hartmut Goebel writes: > Am 07.02.2018 um 17:16 schrieb Marius Bakke: >> Hartmut Goebel writes: >> >>> Adobt the NixOS patches as of 2018-01-19: >> I don't see any patches in this series.=20 > > I only *adopted* what NixOs does with patches, not the patches itself. I > will rework this. > >> FWIW I think we deviate enough >> from NixOS at this point that the comments are unnecessary. > > Are you referring to patch (1/6)? Or do you mean patches 2, 3, 5 and 6 > are unnecessary? > > I do not care about the comments, but FMPOV it is important to document > somehow in the code or in the commits that all patches as of 2018-01-19 > have been considered. an alternative would be to group these few commits > into a (very short) branch and documenting the fact in the merge-commit. > > WDYT? I don't think the comments are all that useful. They only add noise in the commit log and the code -- since we have a working and up-to-date Qt, it is implied that we don't need anything more from NixOS or elsewhere. >>> - src/corelib/tools/qtimezoneprivate_tz.cpp: NixOS uses $TZDIR, we use >>> hardcoded path to tzdata. >> Why hardcode the path? We set TZDIR as well in (gnu system). > > The upstream code (qt.com) uses hard-coded path (/usr/share/zoneinfo/), > so for me it seems to be much more natural to simply change this - and > stay closer to upstream. NixOS seems to require TZDATA since some things > work differently compared to guix. E.g. nixos is deriving library search > paths from $PATH in some other patch. This is something guix does not nee= d. For tzdata in particular, we are trying to reduce the number of dependent packages so that we can update it directly on 'master'. Often a new tzdata release introduces changes with near-immediate effects, so it's important to be able to update it fast. Adding it to qtbase would add 282 new dependent packages, which is unfortunate. So I much prefer using TZDIR, even though it would be technically better to reference it directly. >>> + (add-after 'unpack 'patch-paths >>> + ;; Use the absolute paths for dynamically loaded libs, othe= rwise >>> + ;; the lib will be searched in the actual executable's RUNP= ATH, >>> + ;; which may not include the requested lib. >> Is there any reason we cannot add these libraries to RUNPATH instead? >> The below approach seems somewhat fragile to me. > > Rethinking this, this comment is wrong and I'll correct it. QLibrary > (which is used an all these cases) is documented with: > > When loading the library, QLibrary > searches in all the > system-specific library locations (e.g. |LD_LIBRARY_PATH| on Unix), > unless the file name has an absolute path. > > But guix does not set LD_LIBRARYPATH (e.g. in "guix environment"), thus > we need to have absolute paths for the libraries. > > Does this make sense? Yes, that makes sense :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqDazIACgkQoqBt8qM6 VPpazwgAjh7GWIxecnHW2H3xV0ITNownF3KK+Svji9XFJr0I3/WFDLasjmInjmMb 6wwULXHljqPcjsPhdQPQMANROhUwZLx7bx8rDjdJsz7gKCpq64FAgTM5t9gLFfQS WN2RIOwkLoWcdh8aksz+JCsv+bBHQ5n7eL+rQeJ+x0pHHk6nkYtiZlewlEU4G5Zr i1Js1DUpJ69rRkRS0Jr8CEEJuyLuK7XwNfiDXK+7a+EQgkFlrP7OvqWw7bEH48QE gp5Tym+J5wBvF1mBg3AAv7Kb5r9p12mHDevUjT5Vn+/TmXGXlq4lgDNpZqNjCQEZ Q/vb1h67dxtqljDnVXRsvoAKEVhJ3w== =Eiqj -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Feb 2018 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30340@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Marius Bakke Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151879791828446 (code B ref 30340); Fri, 16 Feb 2018 16:19:02 +0000 Received: (at 30340) by debbugs.gnu.org; 16 Feb 2018 16:18:38 +0000 Received: from localhost ([127.0.0.1]:47104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emiib-0007Ok-On for submit@debbugs.gnu.org; Fri, 16 Feb 2018 11:18:37 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:57578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emiiX-0007OZ-Ni for 30340@debbugs.gnu.org; Fri, 16 Feb 2018 11:18:34 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zjdc854Kqz1qyvW; Fri, 16 Feb 2018 17:18:32 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zjdc83s4Xz1sQxK; Fri, 16 Feb 2018 17:18:32 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id xMfAiJqVFtQ0; Fri, 16 Feb 2018 17:18:31 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-175-206.dynamic.mnet-online.de [93.104.175.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Fri, 16 Feb 2018 17:18:31 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 1648260584; Fri, 16 Feb 2018 17:18:31 +0100 (CET) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> Date: Fri, 16 Feb 2018 17:18:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87sha4wlot.fsf@fastmail.com> Content-Type: multipart/alternative; boundary="------------6EA775E0CA29205C2709EDDE" Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------6EA775E0CA29205C2709EDDE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Am 13.02.2018 um 23:48 schrieb Marius Bakke: >> I do not care about the comments, but FMPOV it is important to document >> somehow in the code or in the commits that all patches as of 2018-01-19 >> have been considered. an alternative would be to group these few commits >> into a (very short) branch and documenting the fact in the merge-commit. >> >> WDYT? > I don't think the comments are all that useful. They only add noise in > the commit log and the code -- since we have a working and up-to-date > Qt, it is implied that we don't need anything more from NixOS or > elsewhere. > @Ludo: What's you opinion on this? (See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30340#62) -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------6EA775E0CA29205C2709EDDE Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Am 13.02.2018 um 23:48 schrieb Marius Bakke:
I do not care about the comments, but FMPOV it is important to document
somehow in the code or in the commits that all patches as of 2018-01-19
have been considered. an alternative would be to group these few commits
into a (very short) branch and documenting the fact in the merge-commit.

WDYT?

I don't think the comments are all that useful.  They only add noise in
the commit log and the code -- since we have a working and up-to-date
Qt, it is implied that we don't need anything more from NixOS or
elsewhere.

@Ludo: What's you opinion on this? (See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30340#62)

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------6EA775E0CA29205C2709EDDE-- From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Feb 2018 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 30340@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151879837129243 (code B ref 30340); Fri, 16 Feb 2018 16:27:01 +0000 Received: (at 30340) by debbugs.gnu.org; 16 Feb 2018 16:26:11 +0000 Received: from localhost ([127.0.0.1]:47113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emipv-0007bb-Dg for submit@debbugs.gnu.org; Fri, 16 Feb 2018 11:26:11 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:54204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emipu-0007bU-DL for 30340@debbugs.gnu.org; Fri, 16 Feb 2018 11:26:10 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zjdmx6bzXz1qyvl; Fri, 16 Feb 2018 17:26:09 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zjdmx6Lgrz1sQxL; Fri, 16 Feb 2018 17:26:09 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id bMgx6sVK2YTw; Fri, 16 Feb 2018 17:26:04 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-175-206.dynamic.mnet-online.de [93.104.175.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Fri, 16 Feb 2018 17:26:04 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id BFFCB60584; Fri, 16 Feb 2018 17:26:03 +0100 (CET) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: Date: Fri, 16 Feb 2018 17:26:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87sha4wlot.fsf@fastmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am 13.02.2018 um 23:48 schrieb Marius Bakke: > For tzdata in particular, we are trying to reduce the number of > dependent packages so that we can update it directly on 'master'. Often > a new tzdata release introduces changes with near-immediate effects, so > it's important to be able to update it fast. > > Adding it to qtbase would add 282 new dependent packages, which is > unfortunate. So I much prefer using TZDIR, even though it would be > technically better to reference it directly. > IC. Should not be much of a problem to adopt the actual patch from NixOS. But I wonder: How is ensured that timezone is installed e.g. in an `guix environment`, if there is no dependency? -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Feb 2018 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel , 30340@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151879899230318 (code B ref 30340); Fri, 16 Feb 2018 16:37:02 +0000 Received: (at 30340) by debbugs.gnu.org; 16 Feb 2018 16:36:32 +0000 Received: from localhost ([127.0.0.1]:47119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emizw-0007sw-Cw for submit@debbugs.gnu.org; Fri, 16 Feb 2018 11:36:32 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:48239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emizu-0007sn-W8 for 30340@debbugs.gnu.org; Fri, 16 Feb 2018 11:36:31 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9AA2A20CE2; Fri, 16 Feb 2018 11:36:30 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Fri, 16 Feb 2018 11:36:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=inDoQLvmRLweyutLR7/IMy9IANzLfRVbvjLT7uMxrYE=; b=cX06dL4+ ol74SQ2D5hZ6I3FPJcg0YxfxMuv90vFcHQyyf1dXwg4cRbjCwDl+GctFbZTCWtFJ Y3+b7l9lUa+qPQdxxlytEDsFmWhuGPfIHRxuIuAja66+UZM5exDrS8Qd7RSuZZtK YYN16IXxvCLnnySNXBS7g+CNGi8Fw+QV8iRGAYPWkSIysgHXVYbpSr0dFBi5FMjm RLryRnibT5gQXHZ0BY2+Orz0sF2pe7xCKwUuD3MVB3GLofF2TAJY4MkeAb7R2oIT dI/ETpMPgn3oJcLXeJ02sVHLV8RSN6thFLZFxkKhV7Bq2ilZCuW2/fsJuRD3M5W7 xxy/OCYAM/27uA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=inDoQLvmRLweyutLR7/IMy9IANzLf RVbvjLT7uMxrYE=; b=DCmxnH+nKLRyKCsGu0i6cJePxbY3P0OELoUs3OmFjR95p n0oy94L4eECXf7/Avhw7PkySqb2W3OgNrF4vm1stCwPNf9uTqLuqz0gxNYrozrYL NnzEaRgX/ds9/K7HH9RvI2Tw/clqWOdybE+G5s77Y3q9oOEu9XtOqhNNVF2qIXkE JCCdzLeuGQecdJCvAgL9kMUSYhLPvHF+Vj0dvUVlPhguqC22kytpJ5VBEPk8EhnT USnVwWXaqv77GcjClFjd29b48kOIjybksu4oJLZx6+bF8wNIeGMJDEFrNUojcxhd 8qLuNDSzEyEHE+waw4Z22zsudxMZnzQUjFt/KLUNQ== X-ME-Sender: Received: from localhost (ip-86-49-250-168.net.upcbroadband.cz [86.49.250.168]) by mail.messagingengine.com (Postfix) with ESMTPA id EB02C241E0; Fri, 16 Feb 2018 11:36:29 -0500 (EST) From: Marius Bakke In-Reply-To: References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Fri, 16 Feb 2018 17:36:28 +0100 Message-ID: <87mv08vqlv.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Hartmut Goebel writes: > Am 13.02.2018 um 23:48 schrieb Marius Bakke: >> For tzdata in particular, we are trying to reduce the number of >> dependent packages so that we can update it directly on 'master'. Often >> a new tzdata release introduces changes with near-immediate effects, so >> it's important to be able to update it fast. >> >> Adding it to qtbase would add 282 new dependent packages, which is >> unfortunate. So I much prefer using TZDIR, even though it would be >> technically better to reference it directly. >> > > IC. Should not be much of a problem to adopt the actual patch from NixOS. > > But I wonder: How is ensured that timezone is installed e.g. in an `guix > environment`, if there is no dependency? Good question. I suppose we could add a search path for TZDIR so that the variable gets set as long as you include tzdata in the environment. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqHCIwACgkQoqBt8qM6 VPo6qwgAsoUkeMF8cMWeyIUZH7E4B3oPmDAfJ743nV/jHflAssEdObXyUAq4I/Yj LmuGzaJ+qXtAYhcvcbbdBTLffTpbdIk8SMV34BvBdcknd8XeKIQl75JkBSMAXrGf 25HV8VLolTRjAeFMVLP+UW4UPSKwoebpf7PZT6CHsgkxT5w8asaJi3Au4mf8nbuX 1gRoLs2Wny/+cx1eD3l31qkKVO4XlHvnoAc248PZMlerpT8op6v3/ylvttF9EirL vcfUVOgH/0SNpc7L2SXavaNPI0mSdDO0TgI72/L9lu8suQU9bM4Zh6s3MCLXH0cE HDDyfkKI93p4s8WkfC5H7M6w+9hlMQ== =Ys/H -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Feb 2018 16:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: Marius Bakke , 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151879977731587 (code B ref 30340); Fri, 16 Feb 2018 16:50:01 +0000 Received: (at 30340) by debbugs.gnu.org; 16 Feb 2018 16:49:37 +0000 Received: from localhost ([127.0.0.1]:47133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emjCb-0008DO-6h for submit@debbugs.gnu.org; Fri, 16 Feb 2018 11:49:37 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:36074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emjCa-0008DG-36 for 30340@debbugs.gnu.org; Fri, 16 Feb 2018 11:49:36 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7088E11316; Fri, 16 Feb 2018 17:49:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2iMYU_fRY2On; Fri, 16 Feb 2018 17:49:34 +0100 (CET) Received: from ribbon (unknown [193.50.110.160]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CCDA5FB09; Fri, 16 Feb 2018 17:49:33 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?UTF-8?Q?Pluvi=C3=B4se?= an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 16 Feb 2018 17:49:33 +0100 In-Reply-To: <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 16 Feb 2018 17:18:30 +0100") Message-ID: <87606wnale.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hartmut Goebel skribis: > Am 13.02.2018 um 23:48 schrieb Marius Bakke: >>> I do not care about the comments, but FMPOV it is important to document >>> somehow in the code or in the commits that all patches as of 2018-01-19 >>> have been considered. an alternative would be to group these few commits >>> into a (very short) branch and documenting the fact in the merge-commit. >>> >>> WDYT? >> I don't think the comments are all that useful. They only add noise in >> the commit log and the code -- since we have a working and up-to-date >> Qt, it is implied that we don't need anything more from NixOS or >> elsewhere. >> > @Ludo: What's you opinion on this? (See also > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30340#62) I don=E2=80=99t have much to add. It=E2=80=99s good to add comments for th= ings that aren=E2=80=99t obvious by looking at the =E2=80=98substitute*=E2=80=99 sequ= ences, but for obvious things it=E2=80=99s =E2=80=9Cnoise=E2=80=9D indeed. At any rate, this shouldn=E2=80=99t hold the patches back. Thanks, Ludo=E2=80=99. From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] Re: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Feb 2018 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Marius Bakke , 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151880699810580 (code B ref 30340); Fri, 16 Feb 2018 18:50:02 +0000 Received: (at 30340) by debbugs.gnu.org; 16 Feb 2018 18:49:58 +0000 Received: from localhost ([127.0.0.1]:47194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eml54-0002ka-7y for submit@debbugs.gnu.org; Fri, 16 Feb 2018 13:49:58 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:40527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eml53-0002kS-0s for 30340@debbugs.gnu.org; Fri, 16 Feb 2018 13:49:57 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zjhyq6cyXz1qsh2; Fri, 16 Feb 2018 19:49:55 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zjhyq6H4Fz1qqlB; Fri, 16 Feb 2018 19:49:55 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id VwyZ1eTIbZ8C; Fri, 16 Feb 2018 19:49:54 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-175-206.dynamic.mnet-online.de [93.104.175.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Fri, 16 Feb 2018 19:49:54 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 7541460584; Fri, 16 Feb 2018 19:49:54 +0100 (CET) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> <87606wnale.fsf@gnu.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <4fa3562d-7e3e-3008-e371-d5002370d533@crazy-compilers.com> Date: Fri, 16 Feb 2018 19:49:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87606wnale.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am 16.02.2018 um 17:49 schrieb Ludovic Courtès: > I don’t have much to add. It’s good to add comments for things that > aren’t obvious by looking at the ‘substitute*’ sequences, but for > obvious things it’s “noise” indeed. This is a wise, while abstract answer. :-) Unfortunately it does not help me to decide and finish the patches. :-\ - Should I keep or drop these "Add note about a patch NixOS …" patches (2,3,5,6) - If dropping: Should I use a short living branch as described in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30340#62 -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Feb 2018 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: Marius Bakke , 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151888372529231 (code B ref 30340); Sat, 17 Feb 2018 16:09:02 +0000 Received: (at 30340) by debbugs.gnu.org; 17 Feb 2018 16:08:45 +0000 Received: from localhost ([127.0.0.1]:48475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en52b-0007bP-KG for submit@debbugs.gnu.org; Sat, 17 Feb 2018 11:08:45 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:42302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en52Z-0007bE-Dz for 30340@debbugs.gnu.org; Sat, 17 Feb 2018 11:08:43 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 6D792FB09; Sat, 17 Feb 2018 17:08:42 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C7r9OuZVIVIs; Sat, 17 Feb 2018 17:08:41 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 75225DA91; Sat, 17 Feb 2018 17:08:41 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> <87606wnale.fsf@gnu.org> <4fa3562d-7e3e-3008-e371-d5002370d533@crazy-compilers.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?UTF-8?Q?Pluvi=C3=B4se?= an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 17 Feb 2018 17:08:40 +0100 In-Reply-To: <4fa3562d-7e3e-3008-e371-d5002370d533@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 16 Feb 2018 19:49:54 +0100") Message-ID: <874lmflhtj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Hartmut, Hartmut Goebel skribis: > - Should I keep or drop these "Add note about a patch NixOS =E2=80=A6" pa= tches > (2,3,5,6) IMO yes. > - If dropping: Should I use a short living branch as described in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30340#62 IMO no=E2=80=94as you know we keep the history linear whenever possible. At the end of the day, what matters is that these patches get in. We shouldn=E2=80=99t spend so long rehashing our views on how to write comment= s. Also, you have commit access because as a group we trust you to be able to make simple decisions in line with the group conventions and practices. Once you=E2=80=99ve had initial feedback, you should feel empow= ered. Thanks for working on this! Ludo=E2=80=99. From unknown Fri Aug 15 21:22:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Feb 2018 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30340 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Hartmut Goebel , 30340@debbugs.gnu.org Received: via spool by 30340-submit@debbugs.gnu.org id=B30340.151889911522913 (code B ref 30340); Sat, 17 Feb 2018 20:26:02 +0000 Received: (at 30340) by debbugs.gnu.org; 17 Feb 2018 20:25:15 +0000 Received: from localhost ([127.0.0.1]:48667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en92o-0005xU-Ou for submit@debbugs.gnu.org; Sat, 17 Feb 2018 15:25:14 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:52407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1en92n-0005xM-8J for 30340@debbugs.gnu.org; Sat, 17 Feb 2018 15:25:13 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 43E5420649; Sat, 17 Feb 2018 15:25:12 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sat, 17 Feb 2018 15:25:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=oEI0wzfU0xDajDmcpa5tuKqP4qfE7W82QYTxx7JYAOA=; b=SUfNT /e8PxAvCa6wt8Hk/LKBYT+70EWOaIwEPkPsSKHt1rrP0Vy1QorPpU3zGlfuFIJ9J 1l/kE0x3EgKSjCBznKz82YeDUs7ayi8RCj5XNcLpsX17aBBcFH/6+bpP8jtxJgD5 zz9H4czONdKb8y0VIOTGZeddGqrJt34aGAeIQ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=oEI0wzfU0xDajDmcpa5tuKqP4qfE7 W82QYTxx7JYAOA=; b=ChlHMzeN8NzhgLOI5bMneCjQ6M5OesQ/BBFk+PylBuZMk bXxzCwMr7ugPXreuhQEWyRpx3CxdpPDzymT6Js4k9Nw01XEFL/2FjVgQgLjFicCF A7kGuoP5pkzZG+uCQBfLa9j7fTvso7lpYpu4abgz3zENlBNiG27riQhsxxr7CL9j +acmRbaReYYI1FsAPDoEy/pHyMB4RAfVYcFI3wqDrAQu0/ii5jeswVv2Go9JdLSE YYnOU+SLDxWzDfrnE6bhf2/fhiC6FmyBSPbbY9nPikQCmvcxd8+9jFyfztk2fXLu zTidf7xPHed1dgdm5E8PJrQTatd9MlQy9dEkLSRlQ== X-ME-Sender: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id E5ECF7E137; Sat, 17 Feb 2018 15:25:11 -0500 (EST) Date: Sat, 17 Feb 2018 15:25:11 -0500 From: Leo Famulari Message-ID: <20180217202511.GB18836@jasmine.lan> References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> <87606wnale.fsf@gnu.org> <4fa3562d-7e3e-3008-e371-d5002370d533@crazy-compilers.com> <874lmflhtj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XF85m9dhOBO43t/C" Content-Disposition: inline In-Reply-To: <874lmflhtj.fsf@gnu.org> User-Agent: Mutt/1.9.3 (2018-01-21) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --XF85m9dhOBO43t/C Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 17, 2018 at 05:08:40PM +0100, Ludovic Court=C3=A8s wrote: > Also, you have commit access because as a group we trust you to be able > to make simple decisions in line with the group conventions and > practices. Once you=E2=80=99ve had initial feedback, you should feel emp= owered. +1 Nothing will ever be perfect :) --XF85m9dhOBO43t/C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlqIj6YACgkQJkb6MLrK fwiiVQ/+OJ4LJOi7QUCeHN5qJLq7Bka3//3/8jkxv5NfUFBk1oLk5VGkS3gWM9RY h0rBjlINDXmBIlra4QsxrKemy2JEtprJWQP9Bd8wwgSr/Q3VPEBhciTCLM68nqdT uQgpk3N4UCecqM+3t//cKcGxF2XRFcigiH0DrNztt+/SpWXlKBZqCpqVKZZu7dCt hYsQ46qR+5icOOd61v3OMArwVpj/azejFbny6wvYJdTtgDSQqRPkZZ1nd7999b1G xO13hY4NblroQgWlxGKrJkTYZwy6fhwjVDnNCmMN0hV6rT4PLLNh3qf0I8gQzLE2 TBA2BjPOgSSWiUVOQL6UqOl2pEYV6T5Maar6HdMXrU1BfCM8s2BF4LUw2O9sbl8T UHEXQfvZBLPXTJV1rq//59Jju10ZM5oAPWD37eJrqZ4vE90HzjwvLVMp8wi8kyRw yTxg5ye2ZGhCNShHZihi5iN+BpB3ghpd7FqTnAVc+BNHK7NoxMLIEVpb1r0vaqLe QwKo68Q7HzFWS4n06yvUStLJsNMvdZJ+nkRfUK+rKTyBXKSnZXlbD/BTVVEcWrW0 jGzyDEo7QWEUCgLkgxm+f4OlocvyIEnfZFGMsLrhGSPIHE8sriJ0NWn2uRHbKpV7 QJY7WLQQsSpJS8Gndqex+CRScf5KU88wY4pjEM3b0r6zlHfamrY= =kug4 -----END PGP SIGNATURE----- --XF85m9dhOBO43t/C-- From unknown Fri Aug 15 21:22:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Hartmut Goebel Subject: bug#30340: closed (Re: Adopt NixOS patches for Qt5) Message-ID: References: <434adf04-3064-df8a-7a50-15821c17a294@crazy-compilers.com> <20180203192212.29173-1-h.goebel@crazy-compilers.com> X-Gnu-PR-Message: they-closed 30340 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 30340@debbugs.gnu.org Date: Sun, 18 Feb 2018 17:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1518976322-32418-1" This is a multi-part message in MIME format... ------------=_1518976322-32418-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #30340: [PATCH 0/6] Adopt NixOS patches for Qt5 which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 30340@debbugs.gnu.org. --=20 30340: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30340 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1518976322-32418-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 30340-close) by debbugs.gnu.org; 18 Feb 2018 17:51:49 +0000 Received: from localhost ([127.0.0.1]:50096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enT7s-0008QR-Li for submit@debbugs.gnu.org; Sun, 18 Feb 2018 12:51:48 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:49400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enT7r-0008QJ-7J for 30340-close@debbugs.gnu.org; Sun, 18 Feb 2018 12:51:47 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zkvZp48vMz1r1hd for <30340-close@debbugs.gnu.org>; Sun, 18 Feb 2018 18:51:46 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zkvZp42tQz1r1nR for <30340-close@debbugs.gnu.org>; Sun, 18 Feb 2018 18:51:46 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id VGILvUgeAGGs for <30340-close@debbugs.gnu.org>; Sun, 18 Feb 2018 18:51:46 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-184-7.dynamic.mnet-online.de [93.104.184.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <30340-close@debbugs.gnu.org>; Sun, 18 Feb 2018 18:51:46 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id B04BF6016F for <30340-close@debbugs.gnu.org>; Sun, 18 Feb 2018 18:51:45 +0100 (CET) From: Hartmut Goebel Subject: Re: Adopt NixOS patches for Qt5 To: 30340-close@debbugs.gnu.org References: <20180208215749.13348-1-h.goebel@crazy-compilers.com> Organization: crazy-compilers.com Message-ID: <434adf04-3064-df8a-7a50-15821c17a294@crazy-compilers.com> Date: Sun, 18 Feb 2018 18:51:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30340-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I finally pushed this as bdf0c644d..042f7c263. Changes to the original patches are: * qtbase:   - Don't use tzdata as input, adopt patch for using TZDIR instead   - Update comment why store-paths are needed * qtserialport:   - Update comment why store-paths are needed * drop patches 2, 3, 5 and 6 (Add not …) -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | ------------=_1518976322-32418-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Feb 2018 19:22:32 +0000 Received: from localhost ([127.0.0.1]:55914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3OS-0001Or-LH for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3OR-0001Oe-2V for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei3OL-0006RT-4P for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ei3OL-0006RL-13 for submit@debbugs.gnu.org; Sat, 03 Feb 2018 14:22:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei3OJ-0007XG-Tq for guix-patches@gnu.org; Sat, 03 Feb 2018 14:22:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei3OG-0006My-OP for guix-patches@gnu.org; Sat, 03 Feb 2018 14:22:23 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:40537) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ei3OG-0006LP-HX for guix-patches@gnu.org; Sat, 03 Feb 2018 14:22:20 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zYkJB60XTz1qs09 for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zYkJB5wq3z1qqkK for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 8WobJT9KDlJE for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-168-48.dynamic.mnet-online.de [93.104.168.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Sat, 3 Feb 2018 20:22:18 +0100 (CET) Received: from thisbe.fritz.box (thisbe.fritz.box [192.168.110.23]) by hermia.goebel-consult.de (Postfix) with ESMTP id 5BD8560821 for ; Sat, 3 Feb 2018 20:22:12 +0100 (CET) From: Hartmut Goebel To: guix-patches@gnu.org Subject: [PATCH 0/6] Adopt NixOS patches for Qt5 Date: Sat, 3 Feb 2018 20:22:12 +0100 Message-Id: <20180203192212.29173-1-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I reviewed the patches NixOS aplies to Qt 5.9 and 5.10. The changes of this series hold the result. I stepped over these when trying to make KDE Plasma work. Most changes are about using store-paths to other packages and for dynamically loaded libs. To ease futuer work, I also added comments about patches we do not need and why. Hartmut Goebel (6): gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. gnu: qtdeclarative: Add note about a patch NixOS has but we don't need. gnu: qtscript: Add note about a patch NixOS has but we don't need. gnu: qtserialport: Use the store paths for dynamically loaded libs. gnu: qttools: Add note about a patch NixOS has but we don't need. gnu: qtwebkit: Add note about a patch NixOS has but we don't need. gnu/packages/qt.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 61 insertions(+), 1 deletion(-) -- 2.13.6 ------------=_1518976322-32418-1--