GNU bug report logs - #30333
[PATCH] gnu: Add emacs-scratch-el.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30333 in the body.
You can then email your comments to 30333 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-scratch-el.
Date: Sat,  3 Feb 2018 13:47:03 +0300

* gnu/packages/emacs.scm (emacs-scratch-el): New public variable.
---
 gnu/packages/emacs.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9523f14da..69d18b060 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -6940,3 +6940,41 @@ navigation with the grails mode.")
 @code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and
 @kbd{C-<} to jump to the next and previous slide.")
       (license license:gpl3+))))
+
+(define-public emacs-scratch-el
+  (let ((commit "2cdf2b841ce7a0987093f65b0cc431947549f897")
+        (revision "1"))
+    (package
+      (name "emacs-scratch-el")
+      (version (string-append "1.2" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/ieure/scratch-el.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "0wscsndynjmnliajqaz28r1ww81j8wh84zwaaswx51abhwgl0idf"))))
+      (build-system emacs-build-system)
+      (native-inputs
+       `(("texinfo" ,texinfo)))
+      (arguments
+       '(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'install-doc
+             (lambda* (#:key outputs #:allow-other-keys)
+               (unless (invoke "makeinfo" "scratch.texi")
+                 (error "makeinfo failed"))
+               (install-file "scratch.info"
+                             (string-append (assoc-ref outputs "out")
+                                            "/share/info")))))))
+      (home-page "https://github.com/ieure/scratch-el/")
+      (synopsis "Create scratch buffers with the same mode current buffer")
+      (description "Scratch is an extension to Emacs that enables one to create
+scratch buffers that are in the same mode as the current buffer.  This is
+notably useful when working on code in some language; you may grab code into a
+scratch buffer, and, by virtue of this extension, do so using the Emacs
+formatting rules for that language.")
+      (license license:bsd-2))))
-- 
2.15.1

Message #8 received at 30333 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>, 30333 <at> debbugs.gnu.org
Subject: Re: [bug#30333] [PATCH] gnu: Add emacs-scratch-el.
Date: Wed, 14 Feb 2018 00:00:57 +0100

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> * gnu/packages/emacs.scm (emacs-scratch-el): New public variable.

[...]

> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 9523f14da..69d18b060 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -6940,3 +6940,41 @@ navigation with the grails mode.")
>  @code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and
>  @kbd{C-<} to jump to the next and previous slide.")
>        (license license:gpl3+))))
> +
> +(define-public emacs-scratch-el
> +  (let ((commit "2cdf2b841ce7a0987093f65b0cc431947549f897")
> +        (revision "1"))
> +    (package
> +      (name "emacs-scratch-el")
> +      (version (string-append "1.2" revision "."
> +                              (string-take commit 7)))

You can use (git-version "1.2" revision commit) here.

(by the way, where does 1.2 come from?)

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/ieure/scratch-el.git")
> +                      (commit commit)))
> +                (file-name (string-append name "-" version "-checkout"))

Similarly, prefer (git-file-name ...).

> +                (sha256
> +                 (base32
> +                  "0wscsndynjmnliajqaz28r1ww81j8wh84zwaaswx51abhwgl0idf"))))
> +      (build-system emacs-build-system)
> +      (native-inputs
> +       `(("texinfo" ,texinfo)))
> +      (arguments
> +       '(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'install 'install-doc
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (unless (invoke "makeinfo" "scratch.texi")
> +                 (error "makeinfo failed"))
> +               (install-file "scratch.info"
> +                             (string-append (assoc-ref outputs "out")
> +                                            "/share/info")))))))

(install-file ...) has an unspecified return value, so return #t here.

> +      (home-page "https://github.com/ieure/scratch-el/")
> +      (synopsis "Create scratch buffers with the same mode current buffer")

s/same mode/same mode as/

Other than that LGTM.

> +      (description "Scratch is an extension to Emacs that enables one to create
> +scratch buffers that are in the same mode as the current buffer.  This is
> +notably useful when working on code in some language; you may grab code into a
> +scratch buffer, and, by virtue of this extension, do so using the Emacs
> +formatting rules for that language.")
> +      (license license:bsd-2))))
> -- 
> 2.15.1

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30333 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30333 <at> debbugs.gnu.org, 30333-done <at> debbugs.gnu.org
Subject: Re: [bug#30333] [PATCH] gnu: Add emacs-scratch-el.
Date: Wed, 14 Feb 2018 16:00:29 +0300

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
>
>> * gnu/packages/emacs.scm (emacs-scratch-el): New public variable.
>
> [...]
>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 9523f14da..69d18b060 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -6940,3 +6940,41 @@ navigation with the grails mode.")
>>  @code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and
>>  @kbd{C-<} to jump to the next and previous slide.")
>>        (license license:gpl3+))))
>> +
>> +(define-public emacs-scratch-el
>> +  (let ((commit "2cdf2b841ce7a0987093f65b0cc431947549f897")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-scratch-el")
>> +      (version (string-append "1.2" revision "."
>> +                              (string-take commit 7)))
>
> You can use (git-version "1.2" revision commit) here.

OK.

> (by the way, where does 1.2 come from?)

https://github.com/ieure/scratch-el/blob/master/scratch.el#L4

>> +      (source (origin
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url "https://github.com/ieure/scratch-el.git")
>> +                      (commit commit)))
>> +                (file-name (string-append name "-" version "-checkout"))
>
> Similarly, prefer (git-file-name ...).

OK.

>> +                (sha256
>> +                 (base32
>> +                  "0wscsndynjmnliajqaz28r1ww81j8wh84zwaaswx51abhwgl0idf"))))
>> +      (build-system emacs-build-system)
>> +      (native-inputs
>> +       `(("texinfo" ,texinfo)))
>> +      (arguments
>> +       '(#:phases
>> +         (modify-phases %standard-phases
>> +           (add-after 'install 'install-doc
>> +             (lambda* (#:key outputs #:allow-other-keys)
>> +               (unless (invoke "makeinfo" "scratch.texi")
>> +                 (error "makeinfo failed"))
>> +               (install-file "scratch.info"
>> +                             (string-append (assoc-ref outputs "out")
>> +                                            "/share/info")))))))
>
> (install-file ...) has an unspecified return value, so return #t here.

OK.

>> +      (home-page "https://github.com/ieure/scratch-el/")
>> +      (synopsis "Create scratch buffers with the same mode current buffer")
>
> s/same mode/same mode as/

OK.

> Other than that LGTM.

Pushed as ac07b94ab53fb13bb56ea876a5143985e6dfaf11

I'll close the bug report.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.