From unknown Sat Sep 06 07:59:04 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n) Reply-To: Leo , 3033@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 17 Apr 2009 21:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3033 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124000387918887 (code B ref -1); Fri, 17 Apr 2009 21:40:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 17 Apr 2009 21:31:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3HLVDUV018864 for ; Fri, 17 Apr 2009 14:31:15 -0700 Received: from mx10.gnu.org ([199.232.76.166]:56116) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LumOd-0008Df-Vq for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 07:38:16 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LumOc-0004uW-1m for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 07:38:15 -0400 Received: from ppsw-0.csi.cam.ac.uk ([131.111.8.130]:54997) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LumOb-0004tu-K6 for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 07:38:13 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:53233 helo=victoria.local) by ppsw-0.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.150]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1LumOZ-0007Ke-1Q (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Fri, 17 Apr 2009 12:38:11 +0100 From: Leo To: emacs-pretest-bug@gnu.org Date: Fri, 17 Apr 2009 12:38:08 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Sender: "Leo, Shidai Liu" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= When I try to open by drag and drop the attached file, Emacs keep asking me 'Try to auto fix whitespace loss? (y/n)'. No matter y or n, the dialogue will appear again and again until I kill the buffer. I enable whitespace mode using (add-hook 'diff-mode-hook 'whitespace-mode). GNU Emacs 23.0.92.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-04-15 on 64-71-7-214.static.wiline.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=emacs-gnus-ticked-doc.patch Content-Description: emacs-gnus-ticked-doc.patch Index: gnus.texi diff -u gnus/texi/gnus.texi:7.204 gnus/texi/gnus.texi:7.205 --- gnus.texi:7.204 Sat Dec 30 16:36:31 2006 +++ gnus.texi Sat Dec 30 22:01:07 2006 @@ -10569,6 +10569,12 @@ Pull all dormant articles (for the current group) into the summary buffer (@code{gnus-summary-insert-dormant-articles}). +@item Y t +@kindex Y t (Summary) +@findex gnus-summary-insert-ticked-articles +Pull all ticked articles (for the current group) into the summary buffer +(@code{gnus-summary-insert-ticked-articles}). + @end table --=-=-=-- From unknown Sat Sep 06 07:59:04 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n) Reply-To: Chong Yidong , 3033@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 18 Apr 2009 02:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3033 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3033-submit@emacsbugs.donarmstrong.com id=B3033.124001960128224 (code B ref 3033); Sat, 18 Apr 2009 02:00:03 +0000 Received: (at 3033) by emacsbugs.donarmstrong.com; 18 Apr 2009 01:53:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3I1rIpZ028218 for <3033@emacsbugs.donarmstrong.com>; Fri, 17 Apr 2009 18:53:19 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 9744F57E21C; Fri, 17 Apr 2009 21:55:08 -0400 (EDT) From: Chong Yidong To: Leo Cc: 3033@debbugs.gnu.org Date: Fri, 17 Apr 2009 21:55:08 -0400 Message-ID: <874owmwwsj.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > When I try to open by drag and drop the attached file, Emacs keep asking > me 'Try to auto fix whitespace loss? (y/n)'. No matter y or n, the > dialogue will appear again and again until I kill the buffer. > > I enable whitespace mode using (add-hook 'diff-mode-hook > 'whitespace-mode). I can't reproduce this. Do you see the bug with a .emacs containing only `(add-hook 'diff-mode-hook 'whitespace-mode)' and nothing else? From unknown Sat Sep 06 07:59:04 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n) Reply-To: Leo , 3033@debbugs.gnu.org Resent-From: Leo Original-Sender: news Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 18 Apr 2009 13:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3033 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124006112930435 (code B ref -1); Sat, 18 Apr 2009 13:30:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 18 Apr 2009 13:25:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3IDPNIA030422 for ; Sat, 18 Apr 2009 06:25:26 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvAXr-0004Df-AI for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 09:25:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvAXm-000497-Jg for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 09:25:22 -0400 Received: from [199.232.76.173] (port=45909 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvAXm-000494-Dl for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 09:25:18 -0400 Received: from main.gmane.org ([80.91.229.2]:35793 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LvAXl-0002j0-WB for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 09:25:18 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LvAXi-0004qY-Bw for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 13:25:14 +0000 Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 18 Apr 2009 13:25:14 +0000 Received: from sdl.web by smaug.linux.pwf.cam.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 18 Apr 2009 13:25:14 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Date: Sat, 18 Apr 2009 14:24:59 +0100 Organization: University of Cambridge Lines: 31 Message-ID: References: <874owmwwsj.fsf@cyd.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: smaug.linux.pwf.cam.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:5EmQ3UKCnSmhjQZMEAxp+PPLqFY= Sender: news X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) On 2009-04-18 02:55 +0100, Chong Yidong wrote: >> When I try to open by drag and drop the attached file, Emacs keep asking >> me 'Try to auto fix whitespace loss? (y/n)'. No matter y or n, the >> dialogue will appear again and again until I kill the buffer. >> >> I enable whitespace mode using (add-hook 'diff-mode-hook >> 'whitespace-mode). > > I can't reproduce this. Do you see the bug with a .emacs containing > only `(add-hook 'diff-mode-hook 'whitespace-mode)' and nothing else? I have used edebug and error-on-quit to trace the culprit and find a reproducible recipe. It turns out it has nothing to do with whitespace. 1. emacs -q 2. M-x which-func-mode 3. C-x C-f emacs-gnus-ticked-doc.patch You should be able to see a dialogue pop up as in this screenshot http://imagebin.org/46002. In my experience, I have found which-func-mode to be intrusive and unreliable. So I guess I will have to disable it to avoid further trouble. Best wishes, -- .: Leo :. [ sdl.web AT gmail.com ] .: I use Emacs :. www.git-scm.com git - the one true version control system From unknown Sat Sep 06 07:59:04 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n) Reply-To: martin rudalics , 3033@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 20 Apr 2009 08:10:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3033 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3033-submit@emacsbugs.donarmstrong.com id=B3033.12402144856334 (code B ref 3033); Mon, 20 Apr 2009 08:10:05 +0000 Received: (at 3033) by emacsbugs.donarmstrong.com; 20 Apr 2009 08:01:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=HAS_BUG_NUMBER,MIXEDBDN, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n3K81Me9006321 for <3033@emacsbugs.donarmstrong.com>; Mon, 20 Apr 2009 01:01:23 -0700 Received: (qmail invoked by alias); 20 Apr 2009 08:01:16 -0000 Received: from 62-47-55-47.adsl.highway.telekom.at (EHLO [62.47.55.47]) [62.47.55.47] by mail.gmx.net (mp023) with SMTP; 20 Apr 2009 10:01:16 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/EqewqG+/EvWH7raMsfyFPJCqR7uViokwG4lEr6f gyycISPIjlYtV4 Message-ID: <49EC2B1B.1070507@gmx.at> Date: Mon, 20 Apr 2009 09:58:19 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Leo , 3033@debbugs.gnu.org References: <874owmwwsj.fsf@cyd.mit.edu> In-Reply-To: Content-Type: multipart/mixed; boundary="------------030000040104020805000104" X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71,0.71 This is a multi-part message in MIME format. --------------030000040104020805000104 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > I have used edebug and error-on-quit to trace the culprit and find a > reproducible recipe. It turns out it has nothing to do with whitespace. > > 1. emacs -q > 2. M-x which-func-mode > 3. C-x C-f emacs-gnus-ticked-doc.patch > [...] > In my experience, I have found which-func-mode to be intrusive and > unreliable. So I guess I will have to disable it to avoid further > trouble. Looks to me like a bug in `diff-sanity-check-hunk' which fails to make the hunk well-formed. However, I think `diff-find-source-location' shouldn't do any sanity checks in the first place when called with a non-nil NOPROMPT argument. So could you try whether the attached patch solves your problem? Thanks, martin. --------------030000040104020805000104 Content-Type: text/plain; name="diff-mode.el.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-mode.el.diff" *** diff-mode.el.~1.157.~ 2009-01-13 15:55:57.000000000 +0100 --- diff-mode.el 2009-04-20 09:39:22.515625000 +0200 *************** *** 1575,1581 **** ;; the user may disagree on what constitutes the hunk ;; (e.g. because an empty line truncates the hunk mid-course), ;; leading to potentially nasty surprises for the user. ! (_ (diff-sanity-check-hunk)) (hunk (buffer-substring (point) (save-excursion (diff-end-of-hunk) (point)))) (old (diff-hunk-text hunk reverse char-offset)) --- 1575,1581 ---- ;; the user may disagree on what constitutes the hunk ;; (e.g. because an empty line truncates the hunk mid-course), ;; leading to potentially nasty surprises for the user. ! (_ (unless noprompt (diff-sanity-check-hunk))) (hunk (buffer-substring (point) (save-excursion (diff-end-of-hunk) (point)))) (old (diff-hunk-text hunk reverse char-offset)) --------------030000040104020805000104-- From unknown Sat Sep 06 07:59:04 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n) Reply-To: Stefan Monnier , 3033@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 20 Apr 2009 16:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3033 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3033-submit@emacsbugs.donarmstrong.com id=B3033.12402428189517 (code B ref 3033); Mon, 20 Apr 2009 16:00:03 +0000 Received: (at 3033) by emacsbugs.donarmstrong.com; 20 Apr 2009 15:53:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3KFrYxj009509 for <3033@emacsbugs.donarmstrong.com>; Mon, 20 Apr 2009 08:53:35 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n3KFrYRF022353; Mon, 20 Apr 2009 11:53:34 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 24F688089C; Mon, 20 Apr 2009 11:53:33 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 3033@debbugs.gnu.org, Leo Message-ID: References: <874owmwwsj.fsf@cyd.mit.edu> <49EC2B1B.1070507@gmx.at> Date: Mon, 20 Apr 2009 11:53:33 -0400 In-Reply-To: <49EC2B1B.1070507@gmx.at> (martin rudalics's message of "Mon, 20 Apr 2009 09:58:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3257=0 > the hunk well-formed. However, I think `diff-find-source-location' > shouldn't do any sanity checks in the first place when called with a > non-nil NOPROMPT argument. Indeed, thank you, Stefan From unknown Sat Sep 06 07:59:04 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n) Reply-To: Leo , 3033@debbugs.gnu.org Resent-From: Leo Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 20 Apr 2009 16:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3033 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3033-submit@emacsbugs.donarmstrong.com id=B3033.124024506221180 (code B ref 3033); Mon, 20 Apr 2009 16:40:03 +0000 Received: (at 3033) by emacsbugs.donarmstrong.com; 20 Apr 2009 16:31:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fk-out-0910.google.com (fk-out-0910.google.com [209.85.128.191]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3KGUwLB021171 for <3033@emacsbugs.donarmstrong.com>; Mon, 20 Apr 2009 09:30:59 -0700 Received: by fk-out-0910.google.com with SMTP id 22so1805650fkq.1 for <3033@emacsbugs.donarmstrong.com>; Mon, 20 Apr 2009 09:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=KDX6iVf+qlUfTs3JD8nLnOwqx3ojehanujoXR2aGQqc=; b=wazbjbPQBJ8HSw1byfjIccgkspFubRv7gCt5G4Q0YRiafyp+xJL5DGa68V6/miTLVJ Led93cJ21/4EEnV8yZaiKPQI+cdzgENTZ3CFAXYR6v7tzgvJI+8d0J0wVdEUJhu0W1Nu ZM3MHJ9O2VuT3L5k47UJcZ8sPs8gkLbjFLx/I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=CKh9FoJdKLXl809b/na+fxq9WSskSxy9ZSojMFVDDB8eGTdIfdMYzF1nzpTEE4ahlU /8e3xemEHAEel8mzo2yeb0T5eoFhZj4w6aPVFPkFXvZeGZR6qt/QdNnjnb64qIsGtKJZ Q/wqlRp300w7YrwjNxuC6DJu91dDBKBuxZOOo= MIME-Version: 1.0 Received: by 10.223.109.199 with SMTP id k7mr1709984fap.45.1240245057653; Mon, 20 Apr 2009 09:30:57 -0700 (PDT) In-Reply-To: <49EC2B1B.1070507@gmx.at> References: <874owmwwsj.fsf@cyd.mit.edu> <49EC2B1B.1070507@gmx.at> Date: Mon, 20 Apr 2009 17:30:56 +0100 Message-ID: <20a0c1020904200930l6711c4dbl1f7e99362dba7033@mail.gmail.com> From: Leo To: martin rudalics Cc: 3033@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 2009/4/20 martin rudalics : >> I have used edebug and error-on-quit to trace the culprit and find a >> reproducible recipe. It turns out it has nothing to do with whitespace. >> >> 1. emacs -q >> 2. M-x which-func-mode >> 3. C-x C-f emacs-gnus-ticked-doc.patch >> > [...] >> In my experience, I have found which-func-mode to be intrusive and >> unreliable. So I guess I will have to disable it to avoid further >> trouble. > > Looks to me like a bug in `diff-sanity-check-hunk' which fails to make > the hunk well-formed. =A0However, I think `diff-find-source-location' > shouldn't do any sanity checks in the first place when called with a > non-nil NOPROMPT argument. =A0So could you try whether the attached patch > solves your problem? > > Thanks, martin. I tried the patch and it seems to work. Thank you. Leo From unknown Sat Sep 06 07:59:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Leo Subject: bug#3033 closed by martin rudalics (Re: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n)) Message-ID: References: <49ED735A.4030704@gmx.at> X-Emacs-PR-Message: they-closed 3033 X-Emacs-PR-Package: emacs Reply-To: 3033@debbugs.gnu.org Date: Tue, 21 Apr 2009 07:30:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1240299003-5850-1" This is a multi-part message in MIME format... ------------=_1240299003-5850-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #3033: 23.0.92; Try to auto fix whitespace loss? (y/n) It has been closed by martin rudalics . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact martin rudalics by replying to this email. --=20 3033: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D3033 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1240299003-5850-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3033-done) by emacsbugs.donarmstrong.com; 21 Apr 2009 07:21:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n3L7Lihu004432 for <3033-done@emacsbugs.donarmstrong.com>; Tue, 21 Apr 2009 00:21:46 -0700 Received: (qmail invoked by alias); 21 Apr 2009 07:21:38 -0000 Received: from 62-47-55-223.adsl.highway.telekom.at (EHLO [62.47.55.223]) [62.47.55.223] by mail.gmx.net (mp056) with SMTP; 21 Apr 2009 09:21:38 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18SNv1vSaUS8rSezO3aKl4HCLOPPHDmqDD/bwqyDy VdfWpMFDeLyhLU Message-ID: <49ED735A.4030704@gmx.at> Date: Tue, 21 Apr 2009 09:18:50 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Leo CC: 3033-done@debbugs.gnu.org Subject: Re: bug#3033: 23.0.92; Try to auto fix whitespace loss? (y/n) References: <874owmwwsj.fsf@cyd.mit.edu> <49EC2B1B.1070507@gmx.at> <20a0c1020904200930l6711c4dbl1f7e99362dba7033@mail.gmail.com> In-Reply-To: <20a0c1020904200930l6711c4dbl1f7e99362dba7033@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.73 > I tried the patch and it seems to work. Thanks for testing. So this has been fixed as: * diff-mode.el (diff-find-source-location): Don't call diff-sanity-check-hunk when NOPROMPT is non-nil. (Bug#3033) martin ------------=_1240299003-5850-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 17 Apr 2009 21:31:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3HLVDUV018864 for ; Fri, 17 Apr 2009 14:31:15 -0700 Received: from mx10.gnu.org ([199.232.76.166]:56116) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LumOd-0008Df-Vq for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 07:38:16 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LumOc-0004uW-1m for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 07:38:15 -0400 Received: from ppsw-0.csi.cam.ac.uk ([131.111.8.130]:54997) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LumOb-0004tu-K6 for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 07:38:13 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:53233 helo=victoria.local) by ppsw-0.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.150]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1LumOZ-0007Ke-1Q (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Fri, 17 Apr 2009 12:38:11 +0100 From: Leo To: emacs-pretest-bug@gnu.org Subject: 23.0.92; Try to auto fix whitespace loss? (y/n) Date: Fri, 17 Apr 2009 12:38:08 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Sender: "Leo, Shidai Liu" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= When I try to open by drag and drop the attached file, Emacs keep asking me 'Try to auto fix whitespace loss? (y/n)'. No matter y or n, the dialogue will appear again and again until I kill the buffer. I enable whitespace mode using (add-hook 'diff-mode-hook 'whitespace-mode). GNU Emacs 23.0.92.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-04-15 on 64-71-7-214.static.wiline.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=emacs-gnus-ticked-doc.patch Content-Description: emacs-gnus-ticked-doc.patch Index: gnus.texi diff -u gnus/texi/gnus.texi:7.204 gnus/texi/gnus.texi:7.205 --- gnus.texi:7.204 Sat Dec 30 16:36:31 2006 +++ gnus.texi Sat Dec 30 22:01:07 2006 @@ -10569,6 +10569,12 @@ Pull all dormant articles (for the current group) into the summary buffer (@code{gnus-summary-insert-dormant-articles}). +@item Y t +@kindex Y t (Summary) +@findex gnus-summary-insert-ticked-articles +Pull all ticked articles (for the current group) into the summary buffer +(@code{gnus-summary-insert-ticked-articles}). + @end table --=-=-=-- ------------=_1240299003-5850-1--