Package: emacs;
Reported by: Alan Third <alan <at> idiocy.org>
Date: Fri, 2 Feb 2018 20:33:02 UTC
Severity: normal
Tags: fixed
Found in version 27.0.50
Done: Noam Postavsky <npostavs <at> users.sourceforge.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30327 in the body.
You can then email your comments to 30327 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
View this report as an mbox folder, status mbox, maintainer mbox
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Fri, 02 Feb 2018 20:33:02 GMT) Full text and rfc822 format available.Alan Third <alan <at> idiocy.org>:bug-gnu-emacs <at> gnu.org.
(Fri, 02 Feb 2018 20:33:02 GMT) Full text and rfc822 format available.Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Alan Third <alan <at> idiocy.org> To: bug-gnu-emacs <at> gnu.org Subject: 27.0.50; Failures in files-tests.el on macOS Date: Fri, 02 Feb 2018 20:31:18 +0000
[Message part 1 (text/plain, inline)]
Today I ran make check and two new failures popped up. It looks like they're from recent additions to files-tests.el. Log file attached.
[files-tests.log (text/plain, inline)]
Running 78 tests (2018-02-02 19:52:13+0000)
passed 1/78 files-file-name-non-special-notify-handlers
passed 2/78 files-test--save-buffers-kill-emacs--confirm-kill-processes
passed 3/78 files-test-abbreviated-home-dir
uncompressing files-test-bug-181410IxLS0.gz...
uncompressing files-test-bug-181410IxLS0.gz...done
compressing files-test-bug-181410IxLS0.gz...
compressing files-test-bug-181410IxLS0.gz...done
Wrote /var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-test-bug-181410IxLS0.gz
passed 4/78 files-test-bug-18141
failed 5/78 files-test-bug-21454
passed 6/78 files-test-local-variables
passed 7/78 files-test-make-temp-file-empty-prefix
passed 8/78 files-test-no-file-write-contents
passed 9/78 files-test-read-file-in-~
passed 10/78 files-tests--copy-directory
passed 11/78 files-tests--file-name-non-special--buffers
(Shell command succeeded with no output)
passed 12/78 files-tests--file-name-non-special--subprocess
passed 13/78 files-tests--insert-directory-wildcard-in-dir-p
passed 14/78 files-tests--make-directory
passed 15/78 files-tests-file-name-non-special-access-file
passed 16/78 files-tests-file-name-non-special-add-name-to-file
passed 17/78 files-tests-file-name-non-special-byte-compiler-base-file-name
passed 18/78 files-tests-file-name-non-special-copy-directory
passed 19/78 files-tests-file-name-non-special-copy-file
passed 20/78 files-tests-file-name-non-special-delete-directory
passed 21/78 files-tests-file-name-non-special-delete-file
passed 22/78 files-tests-file-name-non-special-diff-latest-backup-file
passed 23/78 files-tests-file-name-non-special-directory-file-name
passed 24/78 files-tests-file-name-non-special-directory-files
Test files-tests-file-name-non-special-directory-files-and-attributes backtrace:
signal(ert-test-failed (((should (equal (directory-files-and-attribu
ert-fail(((should (equal (directory-files-and-attributes nospecial-d
(if (unwind-protect (setq value-188 (apply fn-186 args-187)) (setq f
(let (form-description-190) (if (unwind-protect (setq value-188 (app
(let ((value-188 'ert-form-evaluation-aborted-189)) (let (form-descr
(let* ((fn-186 (function equal)) (args-187 (condition-case err (let
(progn (let* ((fn-186 (function equal)) (args-187 (condition-case er
(unwind-protect (progn (let* ((fn-186 (function equal)) (args-187 (c
(let* ((tmpdir (make-temp-file "files-tests" t)) (nospecial-dir (fil
(closure (t) nil (let* ((tmpdir (make-temp-file "files-tests" t)) (n
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name files-tests-file-name-non-special-dir
ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/files-tests.el" "--e
command-line()
normal-top-level()
Test files-tests-file-name-non-special-directory-files-and-attributes condition:
(ert-test-failed
((should
(equal
(directory-files-and-attributes nospecial-dir)
(directory-files-and-attributes tmpdir)))
:form
(equal
(("." t 2 501 20 ... ... ... 64 "drwx------" ...)
(".." t 186 501 20 ... ... ... 5952 "drwx------" ...))
(("." t 2 501 20 ... ... ... 64 "drwx------" ...)
(".." t 186 501 20 ... ... ... 5952 "drwx------" ...)))
:value nil :explanation
(list-elt 0
(list-elt 5
(list-elt 2 ...)))))
FAILED 25/78 files-tests-file-name-non-special-directory-files-and-attributes
Compressing /var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-tests3OoP64...
Compressing /var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-tests3OoP64...done
Uncompressing /var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-tests3OoP64.gz...
Uncompressing /var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-tests3OoP64.gz...done
passed 26/78 files-tests-file-name-non-special-dired-compress-handler
passed 27/78 files-tests-file-name-non-special-dired-uncache
passed 28/78 files-tests-file-name-non-special-expand-file-name
passed 29/78 files-tests-file-name-non-special-file-accessible-directory-p
passed 30/78 files-tests-file-name-non-special-file-acl
passed 31/78 files-tests-file-name-non-special-file-attributes
passed 32/78 files-tests-file-name-non-special-file-directory-p
passed 33/78 files-tests-file-name-non-special-file-equal-p
passed 34/78 files-tests-file-name-non-special-file-executable-p
passed 35/78 files-tests-file-name-non-special-file-exists-p
passed 36/78 files-tests-file-name-non-special-file-in-directory-p
passed 37/78 files-tests-file-name-non-special-file-local-copy
passed 38/78 files-tests-file-name-non-special-file-modes
passed 39/78 files-tests-file-name-non-special-file-name-all-completions
passed 40/78 files-tests-file-name-non-special-file-name-as-directory
passed 41/78 files-tests-file-name-non-special-file-name-case-insensitive-p
passed 42/78 files-tests-file-name-non-special-file-name-completion
passed 43/78 files-tests-file-name-non-special-file-name-directory
passed 44/78 files-tests-file-name-non-special-file-name-nondirectory
passed 45/78 files-tests-file-name-non-special-file-name-sans-versions
passed 46/78 files-tests-file-name-non-special-file-newer-than-file-p
passed 47/78 files-tests-file-name-non-special-file-ownership-preserved-p
passed 48/78 files-tests-file-name-non-special-file-readable-p
passed 49/78 files-tests-file-name-non-special-file-regular-p
passed 50/78 files-tests-file-name-non-special-file-remote-p
passed 51/78 files-tests-file-name-non-special-file-selinux-context
passed 52/78 files-tests-file-name-non-special-file-symlink-p
Test files-tests-file-name-non-special-file-truename backtrace:
signal(ert-test-failed (((should (equal nospecial (file-truename nos
ert-fail(((should (equal nospecial (file-truename nospecial))) :form
(if (unwind-protect (setq value-383 (apply fn-381 args-382)) (setq f
(let (form-description-385) (if (unwind-protect (setq value-383 (app
(let ((value-383 'ert-form-evaluation-aborted-384)) (let (form-descr
(let* ((fn-381 (function equal)) (args-382 (condition-case err (let
(progn (let* ((fn-381 (function equal)) (args-382 (condition-case er
(unwind-protect (progn (let* ((fn-381 (function equal)) (args-382 (c
(let* ((tmpfile (make-temp-file "files-tests" nil)) (nospecial (file
(closure (t) nil (let* ((tmpfile (make-temp-file "files-tests" nil))
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name files-tests-file-name-non-special-fil
ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/files-tests.el" "--e
command-line()
normal-top-level()
Test files-tests-file-name-non-special-file-truename condition:
(ert-test-failed
((should
(equal nospecial
(file-truename nospecial)))
:form
(equal "/:/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ" "/:/private/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ")
:value nil :explanation
(arrays-of-different-length 68 76 "/:/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ" "/:/private/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ" first-mismatch-at 3)))
FAILED 53/78 files-tests-file-name-non-special-file-truename
passed 54/78 files-tests-file-name-non-special-file-writable-p
passed 55/78 files-tests-file-name-non-special-find-backup-file-name
passed 56/78 files-tests-file-name-non-special-get-file-buffer
passed 57/78 files-tests-file-name-non-special-insert-directory
passed 58/78 files-tests-file-name-non-special-insert-file-contents
passed 59/78 files-tests-file-name-non-special-load
passed 60/78 files-tests-file-name-non-special-make-auto-save-file-name
passed 61/78 files-tests-file-name-non-special-make-directory
passed 62/78 files-tests-file-name-non-special-make-directory-internal
passed 63/78 files-tests-file-name-non-special-make-nearby-temp-file
passed 64/78 files-tests-file-name-non-special-make-symbolic-link
passed 65/78 files-tests-file-name-non-special-quote-unquote
passed 66/78 files-tests-file-name-non-special-rename-file
passed 67/78 files-tests-file-name-non-special-set-file-acl
passed 68/78 files-tests-file-name-non-special-set-file-modes
passed 69/78 files-tests-file-name-non-special-set-file-selinux-context
passed 70/78 files-tests-file-name-non-special-set-file-times
passed 71/78 files-tests-file-name-non-special-set-visited-file-modtime
passed 72/78 files-tests-file-name-non-special-shell-command
passed 73/78 files-tests-file-name-non-special-start-file-process
passed 74/78 files-tests-file-name-non-special-substitute-in-file-name
passed 75/78 files-tests-file-name-non-special-temporary-file-directory
passed 76/78 files-tests-file-name-non-special-unhandled-file-name-directory
passed 77/78 files-tests-file-name-non-special-vc-registered
passed 78/78 files-tests-file-name-non-special-write-region
Ran 78 tests, 76 results as expected, 2 unexpected (2018-02-02 19:52:15+0000)
1 expected failures
2 unexpected results:
FAILED files-tests-file-name-non-special-directory-files-and-attributes
FAILED files-tests-file-name-non-special-file-truename
[Message part 3 (text/plain, inline)]
In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin17.4.0, NS appkit-1561.20 Version 10.13.3 (Build 17D47)) of 2018-02-02 built on breton.holly.idiocy.org Repository revision: cfe5d62bc53fd82ea28a22ca9cce734de1ed6cdb Windowing system distributor 'Apple', version 10.3.1561 System Description: Mac OS X 10.13.3 Recent messages: Indenting region...done Entering debugger... Back to top level Undo! Type C-x 1 to delete the help window. Making completion list... Turning on magit-auto-revert-mode...done [2 times] [C-t] show common commands, [?] describe events, [C-h i] show manual mwheel-scroll: Beginning of buffer [47 times] Making completion list... Configured features: RSVG NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8 Major mode: Emacs-Lisp Minor modes in effect: magit-auto-revert-mode: t auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t diff-auto-refine-mode: t paredit-mode: t global-flycheck-mode: t flycheck-mode: t shell-dirtrack-mode: t show-paren-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /Users/alan/.emacs.d/elpa/org-20171205/ob-stan hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-stan /Users/alan/.emacs.d/elpa/org-20171205/ob-exp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-exp /Users/alan/.emacs.d/elpa/org-20171205/ob-J hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-J /Users/alan/.emacs.d/elpa/org-20171205/org-eshell hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-eshell /Users/alan/.emacs.d/elpa/org-20171205/ob-emacs-lisp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-emacs-lisp /Users/alan/.emacs.d/elpa/org-20171205/org-gnus hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-gnus /Users/alan/.emacs.d/elpa/org-20171205/ob-css hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-css /Users/alan/.emacs.d/elpa/org-20171205/ob-lob hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-lob /Users/alan/.emacs.d/elpa/org-20171205/ob-forth hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-forth /Users/alan/.emacs.d/elpa/org-20171205/org-macs hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-macs /Users/alan/.emacs.d/elpa/org-20171205/ob hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob /Users/alan/.emacs.d/elpa/org-20171205/org-version hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-version /Users/alan/.emacs.d/elpa/org-20171205/ob-scheme hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-scheme /Users/alan/.emacs.d/elpa/org-20171205/ox hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox /Users/alan/.emacs.d/elpa/org-20171205/ob-abc hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-abc /Users/alan/.emacs.d/elpa/org-20171205/ob-C hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-C /Users/alan/.emacs.d/elpa/org-20171205/org-capture hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-capture /Users/alan/.emacs.d/elpa/org-20171205/ob-ref hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ref /Users/alan/.emacs.d/elpa/org-20171205/ob-clojure hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-clojure /Users/alan/.emacs.d/elpa/org-20171205/org-mouse hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-mouse /Users/alan/.emacs.d/elpa/org-20171205/ob-ledger hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ledger /Users/alan/.emacs.d/elpa/org-20171205/org-ctags hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-ctags /Users/alan/.emacs.d/elpa/org-20171205/org-entities hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-entities /Users/alan/.emacs.d/elpa/org-20171205/org-archive hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-archive /Users/alan/.emacs.d/elpa/org-20171205/ob-screen hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-screen /Users/alan/.emacs.d/elpa/org-20171205/ob-haskell hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-haskell /Users/alan/.emacs.d/elpa/org-20171205/ob-asymptote hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-asymptote /Users/alan/.emacs.d/elpa/org-20171205/org-mhe hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-mhe /Users/alan/.emacs.d/elpa/org-20171205/org-table hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-table /Users/alan/.emacs.d/elpa/org-20171205/ob-keys hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-keys /Users/alan/.emacs.d/elpa/org-20171205/ox-org hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-org /Users/alan/.emacs.d/elpa/org-20171205/org-plot hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-plot /Users/alan/.emacs.d/elpa/org-20171205/ob-awk hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-awk /Users/alan/.emacs.d/elpa/org-20171205/ob-groovy hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-groovy /Users/alan/.emacs.d/elpa/org-20171205/ob-octave hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-octave /Users/alan/.emacs.d/elpa/org-20171205/org-faces hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-faces /Users/alan/.emacs.d/elpa/org-20171205/org-colview hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-colview /Users/alan/.emacs.d/elpa/org-20171205/ob-R hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-R /Users/alan/.emacs.d/elpa/org-20171205/org-timer hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-timer /Users/alan/.emacs.d/elpa/org-20171205/ob-ebnf hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ebnf /Users/alan/.emacs.d/elpa/org-20171205/org-mobile hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-mobile /Users/alan/.emacs.d/elpa/org-20171205/ob-fortran hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-fortran /Users/alan/.emacs.d/elpa/org-20171205/ob-shell hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-shell /Users/alan/.emacs.d/elpa/org-20171205/ob-perl hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-perl /Users/alan/.emacs.d/elpa/org-20171205/ob-sqlite hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sqlite /Users/alan/.emacs.d/elpa/org-20171205/ob-sed hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sed /Users/alan/.emacs.d/elpa/org-20171205/org-list hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-list /Users/alan/.emacs.d/elpa/org-20171205/ob-ruby hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ruby /Users/alan/.emacs.d/elpa/org-20171205/ob-eval hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-eval /Users/alan/.emacs.d/elpa/org-20171205/org-habit hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-habit /Users/alan/.emacs.d/elpa/org-20171205/org-clock hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-clock /Users/alan/.emacs.d/elpa/org-20171205/ox-html hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-html /Users/alan/.emacs.d/elpa/org-20171205/org-src hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-src /Users/alan/.emacs.d/elpa/org-20171205/ob-lisp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-lisp /Users/alan/.emacs.d/elpa/org-20171205/ob-ditaa hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ditaa /Users/alan/.emacs.d/elpa/org-20171205/org-pcomplete hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-pcomplete /Users/alan/.emacs.d/elpa/org-20171205/org-lint hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-lint /Users/alan/.emacs.d/elpa/org-20171205/org-rmail hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-rmail /Users/alan/.emacs.d/elpa/org-20171205/ox-latex hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-latex /Users/alan/.emacs.d/elpa/org-20171205/ob-sass hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sass /Users/alan/.emacs.d/elpa/org-20171205/ob-io hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-io /Users/alan/.emacs.d/elpa/org-20171205/ob-tangle hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-tangle /Users/alan/.emacs.d/elpa/org-20171205/ob-calc hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-calc /Users/alan/.emacs.d/elpa/org-20171205/ob-java hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-java /Users/alan/.emacs.d/elpa/org-20171205/ox-icalendar hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-icalendar /Users/alan/.emacs.d/elpa/org-20171205/org-eww hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-eww /Users/alan/.emacs.d/elpa/org-20171205/ox-md hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-md /Users/alan/.emacs.d/elpa/org-20171205/ox-beamer hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-beamer /Users/alan/.emacs.d/elpa/org-20171205/org-element hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-element /Users/alan/.emacs.d/elpa/org-20171205/org-protocol hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-protocol /Users/alan/.emacs.d/elpa/org-20171205/ob-mscgen hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-mscgen /Users/alan/.emacs.d/elpa/org-20171205/ob-gnuplot hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-gnuplot /Users/alan/.emacs.d/elpa/org-20171205/ob-latex hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-latex /Users/alan/.emacs.d/elpa/org-20171205/org-id hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-id /Users/alan/.emacs.d/elpa/org-20171205/ob-vala hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-vala /Users/alan/.emacs.d/elpa/org-20171205/ox-man hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-man /Users/alan/.emacs.d/elpa/org-20171205/org-feed hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-feed /Users/alan/.emacs.d/elpa/org-20171205/ob-lua hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-lua /Users/alan/.emacs.d/elpa/org-20171205/ob-table hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-table /Users/alan/.emacs.d/elpa/org-20171205/ob-ocaml hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-ocaml /Users/alan/.emacs.d/elpa/org-20171205/ob-coq hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-coq /Users/alan/.emacs.d/elpa/org-20171205/ob-picolisp hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-picolisp /Users/alan/.emacs.d/elpa/org-20171205/org-indent hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-indent /Users/alan/.emacs.d/elpa/org-20171205/ob-lilypond hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-lilypond /Users/alan/.emacs.d/elpa/org-20171205/ob-matlab hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-matlab /Users/alan/.emacs.d/elpa/org-20171205/org-datetree hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-datetree /Users/alan/.emacs.d/elpa/org-20171205/ob-python hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-python /Users/alan/.emacs.d/elpa/org-20171205/org-bbdb hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-bbdb /Users/alan/.emacs.d/elpa/org-20171205/ob-makefile hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-makefile /Users/alan/.emacs.d/elpa/org-20171205/org-duration hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-duration /Users/alan/.emacs.d/elpa/org-20171205/org-agenda hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-agenda /Users/alan/.emacs.d/elpa/org-20171205/ob-dot hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-dot /Users/alan/.emacs.d/elpa/org-20171205/ob-js hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-js /Users/alan/.emacs.d/elpa/org-20171205/ox-publish hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-publish /Users/alan/.emacs.d/elpa/org-20171205/org-inlinetask hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-inlinetask /Users/alan/.emacs.d/elpa/org-20171205/ob-org hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-org /Users/alan/.emacs.d/elpa/org-20171205/ob-core hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-core /Users/alan/.emacs.d/elpa/org-20171205/org-compat hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-compat /Users/alan/.emacs.d/elpa/org-20171205/org-docview hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-docview /Users/alan/.emacs.d/elpa/org-20171205/ox-odt hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-odt /Users/alan/.emacs.d/elpa/org-20171205/ob-plantuml hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-plantuml /Users/alan/.emacs.d/elpa/org-20171205/ox-ascii hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-ascii /Users/alan/.emacs.d/elpa/org-20171205/org-loaddefs hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-loaddefs /Users/alan/.emacs.d/elpa/org-20171205/org-w3m hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-w3m /Users/alan/.emacs.d/elpa/org-20171205/org-bibtex hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-bibtex /Users/alan/.emacs.d/elpa/org-20171205/org-info hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-info /Users/alan/.emacs.d/elpa/org-20171205/ob-hledger hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-hledger /Users/alan/.emacs.d/elpa/org-20171205/ob-maxima hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-maxima /Users/alan/.emacs.d/elpa/org-20171205/org hides /Applications/Emacs.app/Contents/Resources/lisp/org/org /Users/alan/.emacs.d/elpa/org-20171205/org-macro hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-macro /Users/alan/.emacs.d/elpa/org-20171205/ob-sql hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-sql /Users/alan/.emacs.d/elpa/org-20171205/org-attach hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-attach /Users/alan/.emacs.d/elpa/org-20171205/ob-processing hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-processing /Users/alan/.emacs.d/elpa/org-20171205/ox-texinfo hides /Applications/Emacs.app/Contents/Resources/lisp/org/ox-texinfo /Users/alan/.emacs.d/elpa/org-20171205/org-irc hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-irc /Users/alan/.emacs.d/elpa/org-20171205/org-crypt hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-crypt /Users/alan/.emacs.d/elpa/org-20171205/org-footnote hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-footnote /Users/alan/.emacs.d/elpa/org-20171205/org-install hides /Applications/Emacs.app/Contents/Resources/lisp/org/org-install /Users/alan/.emacs.d/elpa/org-20171205/ob-comint hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-comint /Users/alan/.emacs.d/elpa/org-20171205/ob-shen hides /Applications/Emacs.app/Contents/Resources/lisp/org/ob-shen Features: (shadow sort mail-extr emacsbug sendmail bug-reference magit-obsolete magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-branch magit-collab ghub url-auth let-alist magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert autorevert filenotify magit-process magit-margin magit-mode magit-git magit-section magit-popup git-commit magit-utils crm log-edit message rmc puny rfc822 mml mml-sec epa epg gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async eieio-opt cl-print debug help-fns radix-tree pcase vc-git diff-mode dired dired-loaddefs misearch multi-isearch cursor-sensor js2-mode js sgml-mode dom cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs imenu term/xterm xterm elec-pair flycheck-objc-clang mm-util mail-prsvr unichar exec-path-from-shell powershell-mode speedbar sb-image ezimage dframe post derived cl warnings abc-mode paredit go-eldoc go-mode url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap find-file ffap thingatpt etags xref project compile geiser flycheck find-func rx subr-x dash tramp trampver tramp-compat tramp-loaddefs shell pcomplete comint ansi-color ring parse-time format-spec advice windmove server iedit iedit-lib paren cl-extra help-mode edmacro kmacro wombat-theme use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf autoinsert info package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 496860 43127) (symbols 48 44147 4) (miscs 40 311 518) (strings 32 111675 3862) (string-bytes 1 3328385) (vectors 16 71535) (vector-slots 8 1546360 42364) (floats 8 110 757) (intervals 56 2250 138) (buffers 992 24)) -- Alan Third
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Fri, 02 Feb 2018 21:04:01 GMT) Full text and rfc822 format available.Message #8 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Noam Postavsky <npostavs <at> users.sourceforge.net> To: Alan Third <alan <at> idiocy.org> Cc: 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Fri, 2 Feb 2018 16:03:30 -0500
On Fri, Feb 2, 2018 at 3:31 PM, Alan Third <alan <at> idiocy.org> wrote: > Today I ran make check and two new failures popped up. It looks like > they're from recent additions to files-tests.el. > Repository revision: cfe5d62bc53fd82ea28a22ca9cce734de1ed6cdb I don't have that revision, does it include Michael's very recent fix to that test? [1: 344750a] [1: 344750a]: 2018-02-02 18:51:25 +0100 Handle quoted remote file names for file notifications https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=344750aef4a8e8c67b1857cf0fe413ba855026d6
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Fri, 02 Feb 2018 22:04:01 GMT) Full text and rfc822 format available.Message #11 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Michael Albinus <michael.albinus <at> gmx.de> To: Alan Third <alan <at> idiocy.org> Cc: 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Fri, 02 Feb 2018 23:03:15 +0100
[Message part 1 (text/plain, inline)]
Alan Third <alan <at> idiocy.org> writes: Hi Alan, > Today I ran make check and two new failures popped up. It looks like > they're from recent additions to files-tests.el. > > Log file attached. > > Test files-tests-file-name-non-special-file-truename condition: > (ert-test-failed > ((should > (equal nospecial > (file-truename nospecial))) > :form > (equal "/:/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ" "/:/private/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ") My crystal ball tells me, that your temporary-file-directory is located on a symlinked directory. Does the following patch cures it?
[Message part 2 (text/plain, inline)]
diff --git a/test/lisp/files-tests.el b/test/lisp/files-tests.el
index 90e5ebf215..61e22a47af 100644
--- a/test/lisp/files-tests.el
+++ b/test/lisp/files-tests.el
@@ -353,7 +353,8 @@ files-tests--with-temp-file
(declare (indent 1) (debug ((symbolp symbolp &optional form) body)))
(cl-check-type name symbol)
(cl-check-type non-special-name symbol)
- `(let* ((,name (make-temp-file "files-tests" ,dir-flag))
+ `(let* ((temporary-file-directory (file-truename temporary-file-directory))
+ (,name (make-temp-file "files-tests" ,dir-flag))
(,non-special-name (file-name-quote ,name)))
(unwind-protect
(progn ,@body)
[Message part 3 (text/plain, inline)]
Best regards, Michael.
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Fri, 02 Feb 2018 23:05:02 GMT) Full text and rfc822 format available.Message #14 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Alan Third <alan <at> idiocy.org> To: Michael Albinus <michael.albinus <at> gmx.de> Cc: 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Fri, 2 Feb 2018 23:04:41 +0000
On Fri, Feb 02, 2018 at 11:03:15PM +0100, Michael Albinus wrote:
> My crystal ball tells me, that your temporary-file-directory is located
> on a symlinked directory.
>
> Does the following patch cures it?
Yes, thank you, that fixes one. Here is a bit more information on the
other:
F files-tests-file-name-non-special-directory-files-and-attributes
(ert-test-failed
((should
(equal
(directory-files-and-attributes nospecial-dir)
(directory-files-and-attributes tmpdir)))
:form
(equal
(("." t 2 501 20
(23156 60751 10790 323000)
(23156 60751 10688 536000)
(23156 60751 10688 536000)
64 "drwx------" ...)
(".." t 187 501 20
(23156 60750 989630 970000)
(23156 60751 10697 474000)
(23156 60751 10697 474000)
5984 "drwx------" ...))
(("." t 2 501 20
(23156 60751 10850 531000)
(23156 60751 10688 536000)
(23156 60751 10688 536000)
64 "drwx------" ...)
(".." t 187 501 20
(23156 60750 989630 970000)
(23156 60751 10697 474000)
(23156 60751 10697 474000)
5984 "drwx------" ...)))
:value nil :explanation
(list-elt 0
(list-elt 5
(list-elt 2
(different-atoms ... ...))))))
I don’t have the first clue what it means...
--
Alan Third
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Fri, 02 Feb 2018 23:58:02 GMT) Full text and rfc822 format available.Message #17 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Philipp Stephani <p.stephani2 <at> gmail.com> To: Alan Third <alan <at> idiocy.org> Cc: Michael Albinus <michael.albinus <at> gmx.de>, 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Fri, 02 Feb 2018 23:57:10 +0000
[Message part 1 (text/plain, inline)]
Alan Third <alan <at> idiocy.org> schrieb am Sa., 3. Feb. 2018 um 00:05 Uhr:
> On Fri, Feb 02, 2018 at 11:03:15PM +0100, Michael Albinus wrote:
> > My crystal ball tells me, that your temporary-file-directory is located
> > on a symlinked directory.
> >
> > Does the following patch cures it?
>
> Yes, thank you, that fixes one. Here is a bit more information on the
> other:
>
> F files-tests-file-name-non-special-directory-files-and-attributes
> (ert-test-failed
> ((should
> (equal
> (directory-files-and-attributes nospecial-dir)
> (directory-files-and-attributes tmpdir)))
> :form
> (equal
> (("." t 2 501 20
> (23156 60751 10790 323000)
> (23156 60751 10688 536000)
> (23156 60751 10688 536000)
> 64 "drwx------" ...)
> (".." t 187 501 20
> (23156 60750 989630 970000)
> (23156 60751 10697 474000)
> (23156 60751 10697 474000)
> 5984 "drwx------" ...))
> (("." t 2 501 20
> (23156 60751 10850 531000)
> (23156 60751 10688 536000)
> (23156 60751 10688 536000)
> 64 "drwx------" ...)
> (".." t 187 501 20
> (23156 60750 989630 970000)
> (23156 60751 10697 474000)
> (23156 60751 10697 474000)
> 5984 "drwx------" ...)))
> :value nil :explanation
> (list-elt 0
> (list-elt 5
> (list-elt 2
> (different-atoms ... ...))))))
>
> I don’t have the first clue what it means...
>
The differing element is the last access time. This isn't surprising given
that reading the directory accesses it. Probably the test should simply
ignore the fifth element (the access time).
[Message part 2 (text/html, inline)]
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Sat, 03 Feb 2018 05:48:01 GMT) Full text and rfc822 format available.Message #20 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Noam Postavsky <npostavs <at> users.sourceforge.net> To: Philipp Stephani <p.stephani2 <at> gmail.com> Cc: Alan Third <alan <at> idiocy.org>, Michael Albinus <michael.albinus <at> gmx.de>, 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Sat, 03 Feb 2018 00:47:29 -0500
[Message part 1 (text/plain, inline)]
Philipp Stephani <p.stephani2 <at> gmail.com> writes: > The differing element is the last access time. This isn't surprising > given that reading the directory accesses it. Probably the test > should simply ignore the fifth element (the access time). Ah, good point. I went through all the different file handlers pretty quickly when writing these tests, so I missed these details. It passes for me because I mount with 'relatime'. Element 9 is "unspecified", so I think we shouldn't check that either.
[v1-0001-Don-t-require-all-file-attributes-to-be-equal-Bug.patch (text/x-diff, inline)]
From 911722154298b3ee7b8328a84215210de5b8fa00 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs <at> gmail.com>
Date: Sat, 3 Feb 2018 00:44:45 -0500
Subject: [PATCH v1] ; Don't require all file-attributes to be equal
(Bug#30327)
* test/lisp/files-tests.el (files-tests-file-attributes-equal): New
function.
(files-tests-file-name-non-special-directory-files-and-attributes)
(files-tests-file-name-non-special-file-attributes): Use it instead of
`equal'.
---
test/lisp/files-tests.el | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/test/lisp/files-tests.el b/test/lisp/files-tests.el
index 3879ca8731..df9d3ad49b 100644
--- a/test/lisp/files-tests.el
+++ b/test/lisp/files-tests.el
@@ -408,10 +408,21 @@ files-tests--with-temp-file
(should (equal (directory-files nospecial-dir)
(directory-files tmpdir)))))
+(defun files-tests-file-attributes-equal (attr1 attr2)
+ ;; Element 4 is access time, which may be changed by the act of
+ ;; checking the attributes.
+ (setf (nth attr-nospecial 4) nil)
+ (setf (nth attr-tmpdir 4) nil)
+ ;; Element 9 is unspecified.
+ (setf (nth attr-nospecial 9) nil)
+ (setf (nth attr-tmpdir 9) nil)
+ (equal attr1 attr2))
+
(ert-deftest files-tests-file-name-non-special-directory-files-and-attributes ()
(files-tests--with-temp-non-special (tmpdir nospecial-dir t)
- (should (equal (directory-files-and-attributes nospecial-dir)
- (directory-files-and-attributes tmpdir)))))
+ (should (files-tests-file-attributes-equal
+ (directory-files-and-attributes nospecial-dir)
+ (directory-files-and-attributes tmpdir)))))
(ert-deftest files-tests-file-name-non-special-dired-compress-handler ()
;; `dired-compress-file' can get confused by filenames with ":" in
@@ -442,7 +453,8 @@ files-tests--with-temp-file
(ert-deftest files-tests-file-name-non-special-file-attributes ()
(files-tests--with-temp-non-special (tmpfile nospecial)
- (should (equal (file-attributes nospecial) (file-attributes tmpfile)))))
+ (should (files-tests-file-attributes-equal
+ (file-attributes nospecial) (file-attributes tmpfile)))))
(ert-deftest files-tests-file-name-non-special-file-directory-p ()
(files-tests--with-temp-non-special (tmpdir nospecial-dir t)
--
2.11.0
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Sat, 03 Feb 2018 16:14:01 GMT) Full text and rfc822 format available.Message #23 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Alan Third <alan <at> idiocy.org> To: Noam Postavsky <npostavs <at> users.sourceforge.net> Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, Michael Albinus <michael.albinus <at> gmx.de>, 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Sat, 3 Feb 2018 16:13:11 +0000
On Sat, Feb 03, 2018 at 12:47:29AM -0500, Noam Postavsky wrote:
> Philipp Stephani <p.stephani2 <at> gmail.com> writes:
>
> > The differing element is the last access time. This isn't surprising
> > given that reading the directory accesses it. Probably the test
> > should simply ignore the fifth element (the access time).
>
> Ah, good point. I went through all the different file handlers pretty
> quickly when writing these tests, so I missed these details. It passes
> for me because I mount with 'relatime'.
>
> Element 9 is "unspecified", so I think we shouldn't check that either.
The patch makes it even worse with two failures now:
F files-tests-file-name-non-special-directory-files-and-attributes
(void-variable attr-nospecial)
F files-tests-file-name-non-special-file-attributes
(void-variable attr-nospecial)
I tried changing the new function to:
(defun files-tests-file-attributes-equal (attr1 attr2)
;; Element 4 is access time, which may be changed by the act of
;; checking the attributes.
(setf (nth 4 attr1) nil)
(setf (nth 4 attr2) nil)
;; Element 9 is unspecified.
(setf (nth 9 attr1) nil)
(setf (nth 9 attr2) nil)
(equal attr1 attr2))
Which fixes one but still causes the other to fail:
F files-tests-file-name-non-special-directory-files-and-attributes
(wrong-type-argument consp nil)
--
Alan Third
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Sat, 03 Feb 2018 16:30:02 GMT) Full text and rfc822 format available.Message #26 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Noam Postavsky <npostavs <at> users.sourceforge.net> To: Alan Third <alan <at> idiocy.org> Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, Michael Albinus <michael.albinus <at> gmx.de>, 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Sat, 03 Feb 2018 11:29:29 -0500
[Message part 1 (text/plain, inline)]
Alan Third <alan <at> idiocy.org> writes: > On Sat, Feb 03, 2018 at 12:47:29AM -0500, Noam Postavsky wrote: >> Philipp Stephani <p.stephani2 <at> gmail.com> writes: >> >> > The differing element is the last access time. This isn't surprising >> > given that reading the directory accesses it. Probably the test >> > should simply ignore the fifth element (the access time). >> >> Ah, good point. I went through all the different file handlers pretty >> quickly when writing these tests, so I missed these details. It passes >> for me because I mount with 'relatime'. >> >> Element 9 is "unspecified", so I think we shouldn't check that either. > > The patch makes it even worse with two failures now: Sorry about that, I made some initial fix, then after testing, extended it, but completely forgot to actually try out the extended version. Here's a patch actually works on my box (and hopefully on others too).
[v2-0001-Don-t-require-all-file-attributes-to-be-equal-Bug.patch (text/x-diff, inline)]
From 0276d2e2d438a4f9606e708ef6367800ad7a5bfc Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs <at> gmail.com>
Date: Sat, 3 Feb 2018 00:44:45 -0500
Subject: [PATCH v2] ; Don't require all file-attributes to be equal
(Bug#30327)
* test/lisp/files-tests.el (files-tests-file-attributes-equal): New
function.
(files-tests-file-name-non-special-directory-files-and-attributes)
(files-tests-file-name-non-special-file-attributes): Use it instead of
`equal'.
---
test/lisp/files-tests.el | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/test/lisp/files-tests.el b/test/lisp/files-tests.el
index 3879ca8731..2c651c6715 100644
--- a/test/lisp/files-tests.el
+++ b/test/lisp/files-tests.el
@@ -408,10 +408,23 @@ files-tests--with-temp-file
(should (equal (directory-files nospecial-dir)
(directory-files tmpdir)))))
+(defun files-tests-file-attributes-equal (attr1 attr2)
+ ;; Element 4 is access time, which may be changed by the act of
+ ;; checking the attributes.
+ (setf (nth 4 attr1) nil)
+ (setf (nth 4 attr2) nil)
+ ;; Element 9 is unspecified.
+ (setf (nth 9 attr1) nil)
+ (setf (nth 9 attr2) nil)
+ (equal attr1 attr2))
+
(ert-deftest files-tests-file-name-non-special-directory-files-and-attributes ()
(files-tests--with-temp-non-special (tmpdir nospecial-dir t)
- (should (equal (directory-files-and-attributes nospecial-dir)
- (directory-files-and-attributes tmpdir)))))
+ (cl-loop for (file1 . attr1) in (directory-files-and-attributes nospecial-dir)
+ for (file2 . attr2) in (directory-files-and-attributes tmpdir)
+ do
+ (should (equal file1 file2))
+ (should (files-tests-file-attributes-equal attr1 attr2)))))
(ert-deftest files-tests-file-name-non-special-dired-compress-handler ()
;; `dired-compress-file' can get confused by filenames with ":" in
@@ -442,7 +455,8 @@ files-tests--with-temp-file
(ert-deftest files-tests-file-name-non-special-file-attributes ()
(files-tests--with-temp-non-special (tmpfile nospecial)
- (should (equal (file-attributes nospecial) (file-attributes tmpfile)))))
+ (should (files-tests-file-attributes-equal
+ (file-attributes nospecial) (file-attributes tmpfile)))))
(ert-deftest files-tests-file-name-non-special-file-directory-p ()
(files-tests--with-temp-non-special (tmpdir nospecial-dir t)
--
2.11.0
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Sat, 03 Feb 2018 17:27:02 GMT) Full text and rfc822 format available.Message #29 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Alan Third <alan <at> idiocy.org> To: Noam Postavsky <npostavs <at> users.sourceforge.net> Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, Michael Albinus <michael.albinus <at> gmx.de>, 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Sat, 3 Feb 2018 17:26:16 +0000
On Sat, Feb 03, 2018 at 11:29:29AM -0500, Noam Postavsky wrote: > Sorry about that, I made some initial fix, then after testing, extended > it, but completely forgot to actually try out the extended version. > Here's a patch actually works on my box (and hopefully on others too). Yup, works here now with both yours and Michael’s patches. Thank you! -- Alan Third
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Sat, 03 Feb 2018 19:11:02 GMT) Full text and rfc822 format available.Message #32 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Michael Albinus <michael.albinus <at> gmx.de> To: Alan Third <alan <at> idiocy.org> Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 30327 <at> debbugs.gnu.org, Noam Postavsky <npostavs <at> users.sourceforge.net> Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Sat, 03 Feb 2018 20:10:27 +0100
Alan Third <alan <at> idiocy.org> writes: > Yup, works here now with both yours and Michael’s patches. I have pushed the patch in files-tests--with-temp-non-special to the master branch. > Thank you! Best regards, Michael.
bug-gnu-emacs <at> gnu.org:bug#30327; Package emacs.
(Sat, 03 Feb 2018 19:39:02 GMT) Full text and rfc822 format available.Message #35 received at 30327 <at> debbugs.gnu.org (full text, mbox):
From: Noam Postavsky <npostavs <at> users.sourceforge.net> To: Michael Albinus <michael.albinus <at> gmx.de> Cc: Alan Third <alan <at> idiocy.org>, Philipp Stephani <p.stephani2 <at> gmail.com>, 30327 <at> debbugs.gnu.org Subject: Re: bug#30327: 27.0.50; Failures in files-tests.el on macOS Date: Sat, 03 Feb 2018 14:38:12 -0500
tags 30327 fixed close 30327 quit Michael Albinus <michael.albinus <at> gmx.de> writes: > Alan Third <alan <at> idiocy.org> writes: > >> Yup, works here now with both yours and Michael’s patches. > > I have pushed the patch in files-tests--with-temp-non-special to the > master branch. Pushed my patch now too, so we should be done here. [1: 9da8da2c41]: 2018-02-03 14:36:14 -0500 Don't require all file-attributes to be equal (Bug#30327) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9da8da2c4105a28064b1b7d3880ae3fc831c7e8a
Noam Postavsky <npostavs <at> users.sourceforge.net>
to control <at> debbugs.gnu.org.
(Sat, 03 Feb 2018 19:39:02 GMT) Full text and rfc822 format available.Noam Postavsky <npostavs <at> users.sourceforge.net>
to control <at> debbugs.gnu.org.
(Sat, 03 Feb 2018 19:39:02 GMT) Full text and rfc822 format available.Debbugs Internal Request <help-debbugs <at> gnu.org>
to internal_control <at> debbugs.gnu.org.
(Sun, 04 Mar 2018 12:24:04 GMT) Full text and rfc822 format available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.