GNU bug report logs - #30320
26.0.91; Crash when using lsp-ui-doc-mode

Previous Next

Full log

Message #86 received at 30320 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 30320 <at> debbugs.gnu.org, jake.goulding <at> gmail.com
Subject: Re: bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode
Date: Sun, 11 Feb 2018 17:43:13 +0200

> Date: Sun, 11 Feb 2018 10:36:10 +0100
> From: martin rudalics <rudalics <at> gmx.at>
> CC: jake.goulding <at> gmail.com, 30320 <at> debbugs.gnu.org
> 
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -350,10 +350,13 @@ struct frame *
>    struct frame *f = XFRAME (frame);
>    Lisp_Object par_size;
>  
> -  if ((!NILP (horizontal)
> -       && NUMBERP (par_size = get_frame_param (f, Qmin_width)))
> -      || (NILP (horizontal)
> -	  && NUMBERP (par_size = get_frame_param (f, Qmin_height))))
> +  /* The 'min-width' and 'min-height' parameters have no effect on TTY
> +     frames.  */
> +  if (!(FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f))
> +      && ((!NILP (horizontal)
> +	   && NUMBERP (par_size = get_frame_param (f, Qmin_width)))
> +	  || (NILP (horizontal)
> +	      && NUMBERP (par_size = get_frame_param (f, Qmin_height)))))
>      {
>        int min_size = XINT (par_size);

So you are saying that frame-windows-min-size will never return too
small values, at least not for TTY frames?  If so, this LGTM, thanks.
I just hoped Jake would be able to test this with the original Lisp
that caused the problems.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.