GNU bug report logs - #30320
26.0.91; Crash when using lsp-ui-doc-mode

Previous Next

Full log

Message #62 received at 30320 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Jake Goulding <jake.goulding <at> gmail.com>
Cc: 30320 <at> debbugs.gnu.org
Subject: Re: bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode
Date: Tue, 06 Feb 2018 10:29:04 +0100

> As for preventing such crashes even though some Lisp does nonsensical
> things: I think a TTY frame cannot be less than 3 or 4 lines plus the
> number of lines used for the menu bar.  Martin, WDYT about adding
> these limitations to adjust_frame_size?

A better location is when adjusting min_size in frame_windows_min_size
here:

      int min_size = XINT (par_size);

      /* Don't allow phantom frames.  */
      if (min_size < 1)
	min_size = 1;

As you see we currently allow 1 here for width and height measured in
characters.  Feel free to change this any way you want -
FRAME_TERMCAP_P conditioned it shouldn't hurt and be suitable for the
release version.  If you want me to do it, please tell me the value(s)
you consider appropriate and where to apply it.

I never cared about this because I never was able to crash Emacs when
using small sizes.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.