GNU bug report logs - #30285
dired-do-chmod vs. top line of dired

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#30285: closed (dired-do-chmod vs. top line of dired)
Date: Tue, 06 Feb 2018 21:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 06 Feb 2018 23:32:21 +0200
with message-id <87wozpx0re.fsf <at> mail.linkov.net>
and subject line Re: bug#30285: dired-do-chmod vs. top line of dired
has caused the debbugs.gnu.org bug report #30285,
regarding dired-do-chmod vs. top line of dired
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
30285: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30285
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: dired-do-chmod vs. top line of dired
Date: Mon, 29 Jan 2018 20:32:51 +0800

M runs the command dired-do-chmod.
If used on the very top line of dired
(the directory name,) it says:
"Change mode of * [0 files] to: "
which doesn't make a lot of sense.
emacs-version "25.2.2"

Same problem if used on the second line, (total...).

(Why doesn't it just complain "can't operate on" like it does for the
third line, ".".)

[Message part 3 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: jidanni <at> jidanni.org, 30285-done <at> debbugs.gnu.org,
 Drew Adams <drew.adams <at> oracle.com>, Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#30285: dired-do-chmod vs. top line of dired
Date: Tue, 06 Feb 2018 23:32:21 +0200

> Wouldn't this
>
> -  (let* ((files (dired-get-marked-files t arg))
> +  (let* ((files (or (dired-get-marked-files t arg)
> +                    (user-error "No files specified")))
>
> call for an extra argument to 'dired-get-marked-files' to emit the
> user error right there?  If it's TRT in your cases, it might give
> coders a heads-up that it's TRT in their cases as well.

This is now pushed to master and closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.