GNU bug report logs - #30285
dired-do-chmod vs. top line of dired

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Mon, 29 Jan 2018 12:44:01 UTC

Severity: minor

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #71 received at 30285 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>, Drew Adams <drew.adams <at> oracle.com>
Cc: 30285 <at> debbugs.gnu.org, jidanni <at> jidanni.org,
 Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#30285: dired-do-chmod vs. top line of dired
Date: Sun, 04 Feb 2018 11:02:17 +0100
> Agreed.  Simplicity is the hallmark of Emacs.

Wouldn't this

-  (let* ((files (dired-get-marked-files t arg))
+  (let* ((files (or (dired-get-marked-files t arg)
+                    (user-error "No files specified")))

call for an extra argument to 'dired-get-marked-files' to emit the
user error right there?  If it's TRT in your cases, it might give
coders a heads-up that it's TRT in their cases as well.

martin




This bug report was last modified 7 years and 167 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.