GNU bug report logs - #30285
dired-do-chmod vs. top line of dired

Previous Next

Full log

View this message in rfc822 format

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 30285 <at> debbugs.gnu.org, jidanni <at> jidanni.org, Tino Calancha <tino.calancha <at> gmail.com>
Subject: bug#30285: dired-do-chmod vs. top line of dired
Date: Wed, 31 Jan 2018 18:49:19 +0900 (JST)

On Tue, 30 Jan 2018, Drew Adams wrote:

> Obviously, for `dired-do-*' commands we still need to
> handle the case where files or dirs are marked.  And
> in that case the command should DTRT even if called from
> a non-file line, i.e., one of the problematic places
> we've been discussing - it should not raise an error
> in that context.
IIRC, my latest patch handle those situations pretty well.
Could you tested it and provide feedback about how to
improve it?

> For `dired-do-*' commands that already call
> `dired-get-marked-files' the clear solution, I think,
> is to just test that return value and raise an error
> if it is nil.
>
> If there is are `dired-do-*' commands that do not call
> `dired-get-marked-files' then we have a choice how to
> solve the problem.  But it might well be that even then
> the best solution is to use `dired-get-marked-files'.
Since you are reluctant to the addition of the new predicate.  That's 
fine.
May I ask you to provide an alternative  patch to compare
with mine? Then, people here might do further feedback based
on those 2 alternatives.

Thank you very much!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.