GNU bug report logs - #30270
[PATCH] url-fetch returns #t instead of FILE

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: bug#30270: closed (Re: bug#30270: [PATCH] url-fetch returns #t
 instead of FILE)
Date: Sun, 28 Jan 2018 22:03:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#30270: [PATCH] url-fetch returns #t instead of FILE

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 30270 <at> debbugs.gnu.org.

-- 
30270: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30270
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 30270-done <at> debbugs.gnu.org
Subject: Re: bug#30270: [PATCH] url-fetch returns #t instead of FILE
Date: Sun, 28 Jan 2018 23:02:14 +0100

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From 61ca016f3a2a6504d899a6ec3b9daaf1647be451 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Sat, 27 Jan 2018 12:22:11 -0500
> Subject: [PATCH] download: Fix return value of the url-fetch procedure.
>
> Fixes #30270 which was introduced by commit 347fa4aebf.
>
> * guix/build/download.scm (url-fetch): Return `file' instead of #t upon success.

Good catch!

I changed the log to read “Fixes <http://...>” and committed.

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: [PATCH] url-fetch returns #t instead of FILE
Date: Sat, 27 Jan 2018 12:29:48 -0500

Hello!

Commit 347fa4aebf, introduced a regression where `url-fetch' would return #t
instead of the file name (as the docstring says it should), which broke
the fiasco script used to find broken hashes of Github's archives[0].

Patch to follow.

[0]  https://notabug.org/apteryx/fiasco

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.