Subject: bug#30270: closed (Re: bug#30270: [PATCH] url-fetch returns #t instead of FILE)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 28 Jan 2018 22:03:02 +0000

Your bug report

#30270: [PATCH] url-fetch returns #t instead of FILE

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
30270: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30270
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#30270: [PATCH] url-fetch returns #t instead of FILE
From: [email-masked] (Ludovic Courtès)
To: Maxim Cournoyer <[email-masked]>
Cc: [email-masked]
Date: Sun, 28 Jan 2018 23:02:14 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Maxim Cournoyer <[email-masked]> skribis:

> From 61ca016f3a2a6504d899a6ec3b9daaf1647be451 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <[email-masked]>
> Date: Sat, 27 Jan 2018 12:22:11 -0500
> Subject: [PATCH] download: Fix return value of the url-fetch procedure.
>
> Fixes #30270 which was introduced by commit 347fa4aebf.
>
> * guix/build/download.scm (url-fetch): Return `file' instead of #t upon success.

Good catch!

I changed the log to read “Fixes <http://...>” and committed.

Thanks,
Ludo’.

Subject: [PATCH] url-fetch returns #t instead of FILE
From: Maxim Cournoyer <[email-masked]>
To: bug-guix <[email-masked]>
Date: Sat, 27 Jan 2018 12:29:48 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello!

Commit 347fa4aebf, introduced a regression where `url-fetch' would return #t
instead of the file name (as the docstring says it should), which broke
the fiasco script used to find broken hashes of Github's archives[0].

Patch to follow.

[0]  https://notabug.org/apteryx/fiasco