From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 12:30:05 2018 Received: (at submit) by debbugs.gnu.org; 27 Jan 2018 17:30:05 +0000 Received: from localhost ([127.0.0.1]:45442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efUIn-0000SF-Ea for submit@debbugs.gnu.org; Sat, 27 Jan 2018 12:30:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efUIj-0000RD-V9 for submit@debbugs.gnu.org; Sat, 27 Jan 2018 12:30:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efUId-0003xO-Mh for submit@debbugs.gnu.org; Sat, 27 Jan 2018 12:29:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54644) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1efUId-0003xE-JX for submit@debbugs.gnu.org; Sat, 27 Jan 2018 12:29:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efUIc-0003xd-I3 for bug-guix@gnu.org; Sat, 27 Jan 2018 12:29:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efUIY-0003sy-LL for bug-guix@gnu.org; Sat, 27 Jan 2018 12:29:54 -0500 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:45362) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efUIY-0003sl-GT for bug-guix@gnu.org; Sat, 27 Jan 2018 12:29:50 -0500 Received: by mail-io0-x236.google.com with SMTP id p188so3519850ioe.12 for ; Sat, 27 Jan 2018 09:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=XIGV2KmtA9IXKUckbpP8Je8ErDeoa9+lqi2R2xqNndI=; b=Zhq2HIM6h0Mya6R/gJdPOJRSYayGL6mcSzD9+nffYOsZYM0Zin3EaB8tBJVZO6zYvT /oU6meMxyizhleXB2AVpF7fvLulh93GGPmVV11UML/yQ3AnEToycATfISnR9l0niX7db hKDMKy3UhlWjlfpJgbFNRsP6x5sSBCqn2b8fPm0NRKrYKn2usxrJhKzDGZcPChlpIn1n SFobdUySW0VSinvGKbmGKR3QMlyyKmPN58Qf9iM28/SqDZt61EwG4f67gEvU6DOJGrpL S8vA9Q2wte2WPtLrfbF4PmFU62j6CCXjj0ZgLCpQXl/c59LAVbAqjFgp10CG5zXmbNrC 6Uww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=XIGV2KmtA9IXKUckbpP8Je8ErDeoa9+lqi2R2xqNndI=; b=ZWSKaCsVksEOGXC2qfJtOXPcEGWKx9fM3GdjwYjOVimXqqYvh3WhKe+B4PQXypyoWw 4HKfkmiiMNEi2IDUo/NQivFUacvpa6TEfH3CWmYlZsUzlXwMhAErALfaKtlO5tGgje/R 4gMGDQkef0gZ8RMbY7NNLNuDF9WEaaLs+WePG9pmEjfDZyPxdq3BgQZwPubypWmrtv4G pALPJfPunf0WAZSLZRELUDInrse5B/SHYYf7inegFrAVA0wlZwjen/o6XvljbQpAAmvw jSnd7dlI6tERBeJdiikof2APhOy346Mt0a+ZOwfQChK6XwlWir6x6nsLsCkSOZY0fGcC pZjw== X-Gm-Message-State: AKwxytcS2xzwQHqxaEoW+b0gMbRRPZXHwES2OWY86xGYdYOTEwlZVvIT ylivoX+Pp8yddp/Fh2ll40yOXA== X-Google-Smtp-Source: AH8x225FfcpUs7O5Zbuh1zlmsPD57hPTt/uSLzq+dnHw247EfaUcQH0m3KQ0eBv0HBBMqHonqKnGMw== X-Received: by 10.107.186.86 with SMTP id k83mr20215457iof.208.1517074189535; Sat, 27 Jan 2018 09:29:49 -0800 (PST) Received: from apteryx ([45.72.232.234]) by smtp.gmail.com with ESMTPSA id m184sm3462914itg.8.2018.01.27.09.29.48 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jan 2018 09:29:49 -0800 (PST) From: Maxim Cournoyer To: bug-guix Subject: [PATCH] url-fetch returns #t instead of FILE Date: Sat, 27 Jan 2018 12:29:48 -0500 Message-ID: <87vafn6whf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello! Commit 347fa4aebf, introduced a regression where `url-fetch' would return #t instead of the file name (as the docstring says it should), which broke the fiasco script used to find broken hashes of Github's archives[0]. Patch to follow. [0] https://notabug.org/apteryx/fiasco From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 12:35:53 2018 Received: (at 30270) by debbugs.gnu.org; 27 Jan 2018 17:35:53 +0000 Received: from localhost ([127.0.0.1]:45447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efUOP-0000ef-4j for submit@debbugs.gnu.org; Sat, 27 Jan 2018 12:35:53 -0500 Received: from mail-it0-f41.google.com ([209.85.214.41]:33551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efUON-0000eO-J7 for 30270@debbugs.gnu.org; Sat, 27 Jan 2018 12:35:51 -0500 Received: by mail-it0-f41.google.com with SMTP id u12so1122694ite.0 for <30270@debbugs.gnu.org>; Sat, 27 Jan 2018 09:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=bj8rUNYcLkFPT5khOjLMpgLPVvvTYGYQ+v7OzsyhPFY=; b=WRdh/mgsV2uMQWUkGv4fEGJ778KSFkB+5TiyQkrWmrbTLC2SOgIUmmFz6akNhfnyMv NTDBxwz8B7+NBoO+Dy8k6HFcsZpGOllPDVK1Qnq7LLF3BJdFQyZ0wIKrIYw2POWpcduX gmlgkP1/Tm1KMC//gFaRJPbY8YWjhFp3gCQ6SY1EUcjnV0EuzIMwz+/xb3TeueFFPgH6 U1TnR6X1JTCauAIUXt43VdRO6d19138gN65F30Eg5NckOuhmaJ9vMqO1K8EjCOQtDZ45 Ukdlcg8p0cWx0/AEnzoKwIg5mfKke6ZCgSRINcEHqQtVIDmROBjy4xdr3YsJax5sY7S/ zHcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bj8rUNYcLkFPT5khOjLMpgLPVvvTYGYQ+v7OzsyhPFY=; b=CcjIEvf0zy9Jtgpa02s+5c5kLWsqxFKtJX03jYLDEEktjEd3xy91vmYhEjYkxg3j07 wwgpdLCzQm2rRqO8pVxO7L9xfAH2SoNZTvz5WEfb4TGpf07FdSQIBrGFrO0zSUxev0O0 DLB95dOhAAwhLcAqnQmW60xzpM5Bu5/5AfmqqDXsxQ3upMzPG5Gq6ELalCSQPRVqyX70 ilw4lputB4u86xlwV7DTl7Qy9fa8QOH5f2KOsya+hMHz2tLPPbAzXCRwzcn0+vuUi7xs FiCjRsYcRl7PnyCgbQWdsIhFDBcxUsrCv+qYX5Nct39PIcasPZ65vAVsJW4dU5bGZNEi 9LmA== X-Gm-Message-State: AKwxytd1yNjipfZW3JYpSCYEOQa7xYpg7lmHyZrIaX1+d7a99SlM2pn5 mNXNzJGmAGyN60q/s8o+4lGpXg== X-Google-Smtp-Source: AH8x225px95iBmGKyk5Iovr0xjmXiWLoCA+iFOox+PYCnm670/C55gSVNhXTv8lcVQvehAllQ5TK2g== X-Received: by 10.36.67.77 with SMTP id s74mr2734437itb.149.1517074545599; Sat, 27 Jan 2018 09:35:45 -0800 (PST) Received: from apteryx ([45.72.232.234]) by smtp.gmail.com with ESMTPSA id 124sm1943028itw.30.2018.01.27.09.35.44 for <30270@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jan 2018 09:35:45 -0800 (PST) From: Maxim Cournoyer To: 30270@debbugs.gnu.org Subject: Re: bug#30270: [PATCH] url-fetch returns #t instead of FILE References: <87vafn6whf.fsf@gmail.com> Date: Sat, 27 Jan 2018 12:35:44 -0500 In-Reply-To: <87vafn6whf.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 27 Jan 2018 12:29:48 -0500") Message-ID: <87o9lf6w7j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30270 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Maxim Cournoyer writes: > Hello! > > Commit 347fa4aebf, introduced a regression where `url-fetch' would return #t > instead of the file name (as the docstring says it should), which broke > the fiasco script used to find broken hashes of Github's archives[0]. > > Patch to follow. ^ --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-download-Fix-return-value-of-the-url-fetch-procedure.patch >From 61ca016f3a2a6504d899a6ec3b9daaf1647be451 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Sat, 27 Jan 2018 12:22:11 -0500 Subject: [PATCH] download: Fix return value of the url-fetch procedure. Fixes #30270 which was introduced by commit 347fa4aebf. * guix/build/download.scm (url-fetch): Return `file' instead of #t upon success. --- guix/build/download.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/build/download.scm b/guix/build/download.scm index 609a10053..1b630a9d6 100644 --- a/guix/build/download.scm +++ b/guix/build/download.scm @@ -770,7 +770,7 @@ otherwise simply ignore them." #:reporter (progress-reporter/file (uri-abbreviation uri) size)) (newline))) - #t))) + file))) ((ftp) (false-if-exception* (ftp-fetch uri file #:timeout timeout))) -- 2.16.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 28 17:02:19 2018 Received: (at 30270-done) by debbugs.gnu.org; 28 Jan 2018 22:02:19 +0000 Received: from localhost ([127.0.0.1]:46836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efv1n-0007L0-7D for submit@debbugs.gnu.org; Sun, 28 Jan 2018 17:02:19 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:52394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efv1l-0007Kq-4o for 30270-done@debbugs.gnu.org; Sun, 28 Jan 2018 17:02:18 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 08FE31125E; Sun, 28 Jan 2018 23:02:16 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QmWETLlDPKwV; Sun, 28 Jan 2018 23:02:15 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 2C7ED11257; Sun, 28 Jan 2018 23:02:15 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Maxim Cournoyer Subject: Re: bug#30270: [PATCH] url-fetch returns #t instead of FILE References: <87vafn6whf.fsf@gmail.com> <87o9lf6w7j.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?Q?Pluvi=C3=B4se?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 28 Jan 2018 23:02:14 +0100 In-Reply-To: <87o9lf6w7j.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 27 Jan 2018 12:35:44 -0500") Message-ID: <87po5ty74p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30270-done Cc: 30270-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Maxim Cournoyer skribis: > From 61ca016f3a2a6504d899a6ec3b9daaf1647be451 Mon Sep 17 00:00:00 2001 > From: Maxim Cournoyer > Date: Sat, 27 Jan 2018 12:22:11 -0500 > Subject: [PATCH] download: Fix return value of the url-fetch procedure. > > Fixes #30270 which was introduced by commit 347fa4aebf. > > * guix/build/download.scm (url-fetch): Return `file' instead of #t upon s= uccess. Good catch! I changed the log to read =E2=80=9CFixes =E2=80=9D and committe= d. Thanks, Ludo=E2=80=99. From unknown Wed Aug 20 01:21:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 26 Feb 2018 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator