From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 07:55:58 2018 Received: (at submit) by debbugs.gnu.org; 27 Jan 2018 12:55:58 +0000 Received: from localhost ([127.0.0.1]:44450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efQ1V-0001Il-NF for submit@debbugs.gnu.org; Sat, 27 Jan 2018 07:55:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efQ1R-0001IU-Sw for submit@debbugs.gnu.org; Sat, 27 Jan 2018 07:55:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efQ1L-0002Eu-OB for submit@debbugs.gnu.org; Sat, 27 Jan 2018 07:55:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44371) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1efQ1L-0002Em-Ku for submit@debbugs.gnu.org; Sat, 27 Jan 2018 07:55:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efQ1K-0003yp-4K for guix-patches@gnu.org; Sat, 27 Jan 2018 07:55:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efQ1G-0002CX-Pn for guix-patches@gnu.org; Sat, 27 Jan 2018 07:55:46 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59135) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1efQ1G-0002Bb-GT for guix-patches@gnu.org; Sat, 27 Jan 2018 07:55:42 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E4CC121040 for ; Sat, 27 Jan 2018 07:55:39 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute3.internal (MEProxy); Sat, 27 Jan 2018 07:55:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ofosos.org; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=0o9sGFgk5LyG3c/04rXP7c9CF0JjkBsHnyGptUOekmA=; b=Gs0dN EmfLxPj9JRg22Db/MGKRa7Y2T90eL3XqgtH1DfGWd7SDVPuiUEseRGBHIFr0Rdx7 8bu6KZtWYakTyZF3QQVW/VBlyOyT2Rlg69It6NUWUc449L1MMU1Lhm1y5snc0lNB FFz1dpGeuPjQd63kVBsH60zgqXBKuDeWMQw0Go= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=0o9sGFgk5LyG3c/04rXP7c9CF0Jjk BsHnyGptUOekmA=; b=hbHQfD8k1EMGLyLXZEyOPllqPcc+1IYOTS+zrXmKNmiVv lf57WUooyJ06AzWhPbdSBuy74tFtwOnouqNjkkmrE33haQrDFtdP2Vs8Ml4SfJ8D wqveklz0cqoS9zBRT4lIyz14akMERZAgPCL0BIeL6xYFPID1jf/ppRA8gQnTKewk qBAbZdoStjdLA3Kv+aDxf3HvAil5BFktLqnMdk67xOU1k4h2loX81U/gSnmoTYBS qtVlEdl3TkapWCSiT+HASk8fsEDYrh8iSZbT6pCWrn59QjoCAqed1MMjfecd6XkG COG46TTTbHPr9A3ueAxBzEZ+f22LEQi3rWs+x67dw== X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id C06EF9E409; Sat, 27 Jan 2018 07:55:39 -0500 (EST) Message-Id: <1517057739.331219.1250048536.75FA3BFA@webmail.messagingengine.com> From: Mark Meyer To: guix-patches@gnu.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_15170577393312190" X-Mailer: MessagingEngine.com Webmail Interface - ajax-20f48d70 Date: Sat, 27 Jan 2018 13:55:39 +0100 Subject: Add FANN X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is a multi-part message in MIME format. --_----------=_15170577393312190 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" Hi, this is a patch to add FANN, the fast artificial neural network to Guix. Cheers, Mark -- Mark Meyer mark@ofosos.org --_----------=_15170577393312190 Content-Disposition: attachment; filename="0001-gnu-Add-fann.patch" Content-Id: <1517057737.331218.763fd7b362eb2bd4fa3b56ff103c4eacc188e130.5E9872DD@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-fann.patch" RnJvbSA2M2IxZWNhMzUyZDljZTk3NzI0YmI4MzI2MTdjNGZhOWMyODQwM2Uw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIE1leWVyIDxt YXJrQG9mb3Nvcy5vcmc+CkRhdGU6IFNhdCwgMjcgSmFuIDIwMTggMTM6NTM6 MTQgKzAxMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFkZCBmYW5uLgoKKiBn bnUvcGFja2FnZXMvYWkuc2NtIChmYW5uKTogTmV3IHZhcmlhYmxlLgotLS0K IGdudS9sb2NhbC5tayAgICAgICAgfCAgMSArCiBnbnUvcGFja2FnZXMvYWku c2NtIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDIg ZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUg MTAwNjQ0IGdudS9wYWNrYWdlcy9haS5zY20KCmRpZmYgLS1naXQgYS9nbnUv bG9jYWwubWsgYi9nbnUvbG9jYWwubWsKaW5kZXggODBkNmE4ZDRjLi5kMzBk MGNjOWUgMTAwNjQ0Ci0tLSBhL2dudS9sb2NhbC5taworKysgYi9nbnUvbG9j YWwubWsKQEAgLTUzLDYgKzUzLDcgQEAgR05VX1NZU1RFTV9NT0RVTEVTID0J CQkJXAogICAlRCUvcGFja2FnZXMvYWRtaW4uc2NtCQkJXAogICAlRCUvcGFj a2FnZXMvYWRucy5zY20JCQkJXAogICAlRCUvcGFja2FnZXMvYWxnZWJyYS5z Y20JCQlcCisgICVEJS9wYWNrYWdlcy9haS5zY20JCQkJXAogICAlRCUvcGFj a2FnZXMvYWlkYy5zY20JCQkJXAogICAlRCUvcGFja2FnZXMvYW5kcm9pZC5z Y20JCQlcCiAgICVEJS9wYWNrYWdlcy9hbmltYXRpb24uc2NtCQkJXApkaWZm IC0tZ2l0IGEvZ251L3BhY2thZ2VzL2FpLnNjbSBiL2dudS9wYWNrYWdlcy9h aS5zY20KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwLi41 YjJkYTJlNzAKLS0tIC9kZXYvbnVsbAorKysgYi9nbnUvcGFja2FnZXMvYWku c2NtCkBAIC0wLDAgKzEsMzIgQEAKKyhkZWZpbmUtbW9kdWxlIChnbnUgcGFj a2FnZXMgYWkpCisgICM6dXNlLW1vZHVsZSAoKGd1aXggbGljZW5zZXMpICM6 cHJlZml4IGxpY2Vuc2U6KQorICAjOnVzZS1tb2R1bGUgKGd1aXggdXRpbHMp CisgICM6dXNlLW1vZHVsZSAoZ3VpeCBkb3dubG9hZCkKKyAgIzp1c2UtbW9k dWxlIChndWl4IHBhY2thZ2VzKQorICAjOnVzZS1tb2R1bGUgKGd1aXggYnVp bGQtc3lzdGVtIGNtYWtlKQorICAjOnVzZS1tb2R1bGUgKGd1aXggZ2l0LWRv d25sb2FkKQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcykpCisKKyhk ZWZpbmUtcHVibGljIGxpYmZhbm4KKyAgKHBhY2thZ2UKKyAgICAobmFtZSAi bGliZmFubiIpCisgICAgKHZlcnNpb24gImQ3MWQ1NDc4OGIiKQorICAgIChz b3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgICAobWV0aG9kIGdpdC1mZXRj aCkKKyAgICAgICAgICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAg ICAgICAgICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vbGliZmFu bi9mYW5uLmdpdCIpCisgICAgICAgICAgICAgICAgICAgIChjb21taXQgdmVy c2lvbikpKQorICAgICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAg ICAoYmFzZTMyCisgICAgICAgICAgICAgICAgIjBpYndwZnJqczZxMmxpanM4 c2x4amd6YjJsbGNsNnJrM3Yyc2tpNHI2MjE1ZzVqamhnM3giKSkpKQorICAg IChidWlsZC1zeXN0ZW0gY21ha2UtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1 bWVudHMKKyAgICAgYCgjOnRlc3RzPyAjZikpCisgICAgKGhvbWUtcGFnZSAi aHR0cDovL2xlZW5pc3Nlbi5kay9mYW5uL3dwLyIpCisgICAgKHN5bm9wc2lz ICJGYXN0IEFydGlmaWNpYWwgTmV1cmFsIE5ldHdvcmsiKQorICAgIChkZXNj cmlwdGlvbgorICAgICAiRkFOTiBpcyBhIGZyZWUgb3BlbiBzb3VyY2UgbmV1 cmFsIG5ldHdvcmsgbGlicmFyeSwgd2hpY2ggaW1wbGVtZW50cworbXVsdGls YXllciBhcnRpZmljaWFsIG5ldXJhbCBuZXR3b3JrcyBpbiBDIHdpdGggc3Vw cG9ydCBmb3IgYm90aCBmdWxseQorY29ubmVjdGVkIGFuZCBzcGFyc2VseSBj b25uZWN0ZWQgbmV0d29ya3MuIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmxn cGwyLjEpKSkKKwotLSAKMi4xNS4xCgo= --_----------=_15170577393312190-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 21:13:51 2018 Received: (at 30266) by debbugs.gnu.org; 28 Jan 2018 02:13:51 +0000 Received: from localhost ([127.0.0.1]:45633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efcTf-0002Qh-19 for submit@debbugs.gnu.org; Sat, 27 Jan 2018 21:13:51 -0500 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:48382 helo=newmailhub.uq.edu.au) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efcTc-0002QX-Dh for 30266@debbugs.gnu.org; Sat, 27 Jan 2018 21:13:49 -0500 Received: from smtp2.soe.uq.edu.au (smtp2.soe.uq.edu.au [10.138.113.41]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id w0S2DiEl009530; Sun, 28 Jan 2018 12:13:44 +1000 Received: from [192.168.1.105] ([123.200.134.98]) (authenticated bits=0) by smtp2.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id w0S2Dhp3038733 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 28 Jan 2018 12:13:44 +1000 Subject: Re: [bug#30266] Add FANN To: Mark Meyer , 30266@debbugs.gnu.org References: <1517057739.331219.1250048536.75FA3BFA@webmail.messagingengine.com> From: Ben Woodcroft Message-ID: Date: Sun, 28 Jan 2018 12:13:42 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1517057739.331219.1250048536.75FA3BFA@webmail.messagingengine.com> Content-Type: multipart/alternative; boundary="------------B17261A4B82A96B207C47374" Content-Language: en-US X-UQ-FilterTime: 1517105626 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------B17261A4B82A96B207C47374 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Mark, Thanks for the patch. > +(define-module (gnu packages ai) > + #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix utils) > + #:use-module (guix download) > + #:use-module (guix packages) > + #:use-module (guix build-system cmake) > + #:use-module (guix git-download) > + #:use-module (gnu packages)) I think machine-learning.scm would be a good home for this package, so a new file wouldn't be needed. > + > +(define-public libfann > + (package > + (name "libfann") > + (version "d71d54788b") The last release is 129 commits behind and it has been some time, so I think you are right - we should package from a git commit. Usually we package from git using this style though (i.e. reason for not using the release, use of 'file-name', and a version that includes the last release followed by '-1.').   ;; There are no recent releases so we package from git.   (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87"))     (package       (name "newick-utils")       (version (string-append "1.6-1." (string-take commit 8)))       (source (origin                 (method git-fetch)                 (uri (git-reference                       (url "https://github.com/tjunier/newick_utils.git")                       (commit commit)))                 (file-name (string-append name "-" version "-checkout"))                 (sha256                  (base32 "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268pxnb")))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url"https://github.com/libfann/fann.git") > + (commit version))) > + (sha256 > + (base32 > + "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x")))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f)) I see from the website: > Once you have installed the library you can test it out by going to > the examples directory and type |make runtest|, which will compile the > examples and run a few of them to test that everything is working. Is that possible? Ideally, since there are tests it would be good to run them. > + (home-page"http://leenissen.dk/fann/wp/") > + (synopsis "Fast Artificial Neural Network") > + (description > + "FANN is a free open source neural network library, which implements > +multilayer artificial neural networks in C with support for both fully > +connected and sparsely connected networks.") > + (license license:lgpl2.1))) Otherwise LGTM. Can you send an updated patch please? Thanks, ben --------------B17261A4B82A96B207C47374 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi Mark,

Thanks for the patch.

+(define-module (gnu packages ai)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix build-system cmake)
+  #:use-module (guix git-download)
+  #:use-module (gnu packages))
I think machine-learning.scm would be a good home for this package, so a new file wouldn't be needed.


+
+(define-public libfann
+  (package
+    (name "libfann")
+    (version "d71d54788b")

The last release is 129 commits behind and it has been some time, so I think you are right - we should package from a git commit.

Usually we package from git using this style though (i.e. reason for not using the release, use of 'file-name', and a version that includes the last release followed by '-1.<commit>').

  ;; There are no recent releases so we package from git.
  (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87"))
    (package
      (name "newick-utils")
      (version (string-append "1.6-1." (string-take commit 8)))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                      (url "https://github.com/tjunier/newick_utils.git")
                      (commit commit)))
                (file-name (string-append name "-" version "-checkout"))
                (sha256
                 (base32
                  "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268pxnb"))))


+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/libfann/fann.git")
+                    (commit version)))
+              (sha256
+               (base32
+                "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f))
I see from the website:

Once you have installed the library you can test it out by going to the examples directory and type make runtest, which will compile the examples and run a few of them to test that everything is working.
Is that possible? Ideally, since there are tests it would be good to run them.

+    (home-page "http://leenissen.dk/fann/wp/")
+    (synopsis "Fast Artificial Neural Network")
+    (description
+     "FANN is a free open source neural network library, which implements
+multilayer artificial neural networks in C with support for both fully
+connected and sparsely connected networks.")
+    (license license:lgpl2.1)))
Otherwise LGTM. Can you send an updated patch please?

Thanks, ben

--------------B17261A4B82A96B207C47374-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 01 10:32:59 2018 Received: (at 30266) by debbugs.gnu.org; 1 Feb 2018 15:32:59 +0000 Received: from localhost ([127.0.0.1]:52574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehGr8-0007NL-GG for submit@debbugs.gnu.org; Thu, 01 Feb 2018 10:32:59 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehGr6-0007ND-J9 for 30266@debbugs.gnu.org; Thu, 01 Feb 2018 10:32:53 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 29DE920E5B; Thu, 1 Feb 2018 10:32:52 -0500 (EST) Received: from web4 ([10.202.2.214]) by compute3.internal (MEProxy); Thu, 01 Feb 2018 10:32:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ofosos.org; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=eN0k/fF2PRo3u+jgbvhuVexTDX ounzgGohGZ4/7QzBc=; b=lh7D98zagEbMbdyElqEvWZstF1VYm7I2GxURGCa1Jf mqGixrk75PzYldf7lfAO8U/ADK4tZjkX4gVyHPX9L9/YIOjPyBhYtRdWtU/RbDTV RIonz4EuGPt3NMTz37QbXbzny2SJ8fQ2e28F9DFOmJYxC7ez/w3Nsg50Lj6x6Ljb k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eN0k/f F2PRo3u+jgbvhuVexTDXounzgGohGZ4/7QzBc=; b=krzBcwhmLNbsX50M7qBjd2 GJGCmfL+sHlXN8RQ2m/hKWtBJlqzJiOJr4WaAt65/iog8JIhzsKGSkDoGWSKR+Tv EIDabHXei2L10aFeiJg3Wi3xAREBYn+eRAvd8FJeeAjsKYueJNnODM66NsgQ5wWL kr4KjPrQHcWS0KcvVhBpIYxMdC8xtVyQVACOYqfqksqdcko5+vN1lEy5eNlX713R 5hAAnOrL04M1Z9dUPLYj9vQjPfixa2pr6/xfONlhhlLsLl3MEQXUwlKFhSZSf9Eb rop7c6PZ0sh6syEYqzmr+KY+i+xT/sxzpBr1FZ9ONoEJVWsCHMeolHAjX9Lge7ag == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id F315EBA43C; Thu, 1 Feb 2018 10:32:51 -0500 (EST) Message-Id: <1517499171.1017760.1256044528.7C0C62C3@webmail.messagingengine.com> From: Mark Meyer To: Ben Woodcroft , 30266@debbugs.gnu.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_151749917110177601" X-Mailer: MessagingEngine.com Webmail Interface - ajax-fde26eb3 Date: Thu, 01 Feb 2018 16:32:51 +0100 Subject: Re: [bug#30266] Add FANN In-Reply-To: References: <1517057739.331219.1250048536.75FA3BFA@webmail.messagingengine.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --_----------=_151749917110177601 Content-Transfer-Encoding: 7bit Content-Type: multipart/alternative; boundary="_----------=_151749917110177600" This is a multi-part message in MIME format. --_----------=_151749917110177600 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" Thanks for the good feedback. Please consider the attached patch. Best, Mark On Sun, Jan 28, 2018, at 03:13, Ben Woodcroft wrote: > Hi Mark, > Thanks for the patch. >> +(define-module (gnu packages ai) + #:use-module ((guix licenses) >> #:prefix license:) + #:use-module (guix utils) + #:use-module (guix >> download) + #:use-module (guix packages) + #:use-module (guix build- >> system cmake) + #:use-module (guix git-download) + #:use-module >> (gnu packages))> I think machine-learning.scm would be a good home for this package, so > a new file wouldn't be needed.> > > >> + +(define-public libfann + (package + (name "libfann") + >> (version "d71d54788b")> > The last release is 129 commits behind and it has been some time, so I > think you are right - we should package from a git commit.> Usually we package from git using this style though (i.e. reason for > not using the release, use of 'file-name', and a version that includes > the last release followed by '-1.').> ;; There are no recent releases so we package from git. > (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87")) > (package > (name "newick-utils") > (version (string-append "1.6-1." (string-take commit 8))) > (source (origin > (method git-fetch) > (uri (git-reference > (url " > https://github.com/tjunier/newick_utils.git")> (commit commit))) > (file-name (string-append name "-" version "- > checkout"))> (sha256 > (base32 > "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268p- > xnb"))))> > >> + (source (origin + (method git-fetch) + >> (uri (git-reference + (url " >> https://github.com/libfann/fann.git") + >> (commit version))) + (sha256 + >> (base32 + "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2sk- >> i4r6215g5jjhg3x")))) + (build-system cmake-build-system) + >> (arguments + `(#:tests? #f))> I see from the website: > > >> Once you have installed the library you can test it out by going to >> the examples directory and type make runtest, which will compile the >> examples and run a few of them to test that everything is working.> Is that possible? Ideally, since there are tests it would be good to > run them.> > >> + (home-page "http://leenissen.dk/fann/wp/") + (synopsis "Fast >> Artificial Neural Network") + (description + "FANN is a >> free open source neural network library, which implements >> +multilayer artificial neural networks in C with support for >> both fully +connected and sparsely connected networks.") + >> (license license:lgpl2.1)))> Otherwise LGTM. Can you send an updated patch please? > > Thanks, ben -- Mark Meyer mark@ofosos.org --_----------=_151749917110177600 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset="utf-8"
Thanks for the good feedback. Please consider the attached patch.

Best, Mark

On Sun, Jan 28, 2018, at 03:13, Ben Woodcroft wrote:

Hi Mark,

Thanks for the patch.

+(define-module (gnu packages ai)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix build-system cmake)
+  #:use-module (guix git-download)
+  #:use-module (gnu packages))
I think machine-learning.scm would be a good home for this package, so a new file wouldn't be needed.



+
+(define-public libfann
+  (package
+    (name "libfann")
+    (version "d71d54788b")


The last release is 129 commits behind and it has been some time, so I think you are right - we should package from a git commit.

Usually we package from git using this style though (i.e. reason for not using the release, use of 'file-name', and a version that includes the last release followed by '-1.<commit>').

  ;; There are no recent releases so we package from git.
  (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87"))
    (package
      (name "newick-utils")
      (version (string-append "1.6-1." (string-take commit 8)))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                      (url "https://github.com/tjunier/newick_utils.git")
                      (commit commit)))
                (file-name (string-append name "-" version "-checkout"))
                (sha256
                 (base32
                  "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268pxnb"))))


+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/libfann/fann.git")
+                    (commit version)))
+              (sha256
+               (base32
+                "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f))
I see from the website:



Once you have installed the library you can test it out by going to the examples directory and type make runtest, which will compile the examples and run a few of them to test that everything is working.
Is that possible? Ideally, since there are tests it would be good to run them.


+    (home-page "http://leenissen.dk/fann/wp/")
+    (synopsis "Fast Artificial Neural Network")
+    (description
+     "FANN is a free open source neural network library, which implements
+multilayer artificial neural networks in C with support for both fully
+connected and sparsely connected networks.")
+    (license license:lgpl2.1)))
Otherwise LGTM. Can you send an updated patch please?


Thanks, ben


--
Mark Meyer
mark@ofosos.org

--_----------=_151749917110177600-- --_----------=_151749917110177601 Content-Disposition: attachment; filename="0001-gnu-Add-fann.patch" Content-Id: <1517499166.1017758.f9e0aaefd23e9e8835b45c843b7f9ce7cb6972b1.64165099@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-fann.patch" RnJvbSA3YzZlYWFlNTZiYzllZjU3YjYwY2VhY2Y0OWEzM2NkZDU5NjZiMzYx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIE1leWVyIDxt YXJrQG9mb3Nvcy5vcmc+CkRhdGU6IFRodSwgMSBGZWIgMjAxOCAxNTowNzo1 OCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGdudTogQWRkIGZhbm4uCgoqIGdu dS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNjbSAoZmFubik6IE5ldyB2 YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvbWFjaGluZS1sZWFybmluZy5z Y20gfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZp bGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNjbSBiL2dudS9wYWNrYWdl cy9tYWNoaW5lLWxlYXJuaW5nLnNjbQppbmRleCBiZDEzY2VkY2IuLmZhYTRi ZGY3ZiAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL21hY2hpbmUtbGVhcm5p bmcuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNj bQpAQCAtNCw2ICs0LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiwgMjAx NyBNYXJpdXMgQmFra2UgPG1iYWtrZUBmYXN0bWFpbC5jb20+CiA7OzsgQ29w eXJpZ2h0IMKpIDIwMTYgSGFydG11dCBHb2ViZWwgPGguZ29lYmVsQGNyYXp5 LWNvbXBpbGVycy5jb20+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggVG9iaWFz IEdlZXJpbmNreC1SaWNlIDxtZUB0b2JpYXMuZ3I+Cis7OzsgQ29weXJpZ2h0 IMKpIDIwMTggTWFyayBNZXllciA8bWFya0BvZm9zb3Mub3JnPgogOzs7CiA7 OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTMx LDYgKzMyLDcgQEAKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3Rl bSBvY2FtbCkKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBw eXRob24pCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gcikK KyAgIzp1c2UtbW9kdWxlIChndWl4IGdpdC1kb3dubG9hZCkKICAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIGF1dG90b29scykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgYm9vc3QpCkBAIC01MCw2ICs1MiwzNSBAQAogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyB4bWwpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHhvcmcpKQogCisoZGVmaW5lLXB1YmxpYyBmYW5uCisgIChsZXQgKChj b21taXQgImQ3MWQ1NDc4OGJlZTU2YmE0Y2Y3NTIyODAxMjcwMTUyZGE1MjA5 ZDciKSkKKyAgICAocGFja2FnZQorICAgICAgKG5hbWUgImZhbm4iKQorICAg ICAgKHZlcnNpb24gKHN0cmluZy1hcHBlbmQgIjIuMi4wLTEuIiAoc3RyaW5n LXRha2UgY29tbWl0IDgpKSkKKyAgICAgIChzb3VyY2UgKG9yaWdpbgorICAg ICAgICAgICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAgICAg ICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAgICAgICAg ICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vbGliZmFubi9mYW5uLmdpdCIp CisgICAgICAgICAgICAgICAgICAgICAgKGNvbW1pdCB2ZXJzaW9uKSkpCisg ICAgICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAgICAgICAgICAoYmFz ZTMyCisgICAgICAgICAgICAgICAgICAiMGlid3BmcmpzNnEybGlqczhzbHhq Z3piMmxsY2w2cmszdjJza2k0cjYyMTVnNWpqaGczeCIpKSkpCisgICAgICAo YnVpbGQtc3lzdGVtIGNtYWtlLWJ1aWxkLXN5c3RlbSkKKyAgICAgIChhcmd1 bWVudHMKKyAgICAgICBgKCM6cGhhc2VzIChtb2RpZnktcGhhc2VzICVzdGFu ZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2No ZWNrCisgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91 dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgICAgICAg ICAgICAgKGxldCogKChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICh3aXRoLWRpcmVjdG9yeS1l eGN1cnNpb24gKHN0cmluZy1hcHBlbmQgKGdldGN3ZCkgIi90ZXN0cyIpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi9mYW5uX3Rl c3RzIikpKSkpKSkpCisgICAgICAoaG9tZS1wYWdlICJodHRwOi8vbGVlbmlz c2VuLmRrL2Zhbm4vd3AvIikKKyAgICAgIChzeW5vcHNpcyAiRmFzdCBBcnRp ZmljaWFsIE5ldXJhbCBOZXR3b3JrIikKKyAgICAgIChkZXNjcmlwdGlvbgor ICAgICAgICJGQU5OIGlzIGEgZnJlZSBvcGVuIHNvdXJjZSBuZXVyYWwgbmV0 d29yayBsaWJyYXJ5LCB3aGljaCBpbXBsZW1lbnRzCittdWx0aWxheWVyIGFy dGlmaWNpYWwgbmV1cmFsIG5ldHdvcmtzIGluIEMgd2l0aCBzdXBwb3J0IGZv ciBib3RoIGZ1bGx5Citjb25uZWN0ZWQgYW5kIHNwYXJzZWx5IGNvbm5lY3Rl ZCBuZXR3b3Jrcy4iKQorICAgICAgKGxpY2Vuc2UgbGljZW5zZTpsZ3BsMi4x KSkpKQorCiAoZGVmaW5lLXB1YmxpYyBsaWJzdm0KICAgKHBhY2thZ2UKICAg ICAobmFtZSAibGlic3ZtIikKLS0gCjIuMTUuMQoK --_----------=_151749917110177601-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 02 08:12:18 2018 Received: (at 30266-done) by debbugs.gnu.org; 2 Feb 2018 13:12:18 +0000 Received: from localhost ([127.0.0.1]:53370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehb8b-0002ky-VO for submit@debbugs.gnu.org; Fri, 02 Feb 2018 08:12:18 -0500 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:45648 helo=newmailhub.uq.edu.au) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehb8Y-0002ki-RA for 30266-done@debbugs.gnu.org; Fri, 02 Feb 2018 08:12:16 -0500 Received: from smtp1.soe.uq.edu.au (smtp1.soe.uq.edu.au [10.138.113.40]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id w12DCAVn002078; Fri, 2 Feb 2018 23:12:10 +1000 Received: from [192.168.1.105] ([123.200.134.98]) (authenticated bits=0) by smtp1.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id w12DC94l001828 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 2 Feb 2018 23:12:11 +1000 Subject: Re: [bug#30266] Add FANN To: Mark Meyer , 30266-done@debbugs.gnu.org References: <1517057739.331219.1250048536.75FA3BFA@webmail.messagingengine.com> <1517499171.1017760.1256044528.7C0C62C3@webmail.messagingengine.com> From: Ben Woodcroft Message-ID: Date: Fri, 2 Feb 2018 23:12:07 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1517499171.1017760.1256044528.7C0C62C3@webmail.messagingengine.com> Content-Type: multipart/alternative; boundary="------------3C80730A335A6E802021B6EA" Content-Language: en-US X-UQ-FilterTime: 1517577131 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30266-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------3C80730A335A6E802021B6EA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Thanks Mark. I made a few small changes and pushed the patch as a9b34762391e6f3b066aef6fc1ebc614ec88db86. On 02/02/18 01:32, Mark Meyer wrote: > Thanks for the good feedback. Please consider the attached patch. > > Best, Mark > > On Sun, Jan 28, 2018, at 03:13, Ben Woodcroft wrote: >> >> Hi Mark, >> >> Thanks for the patch. >> >>> +(define-module (gnu packages ai) >>> + #:use-module ((guix licenses) #:prefix license:) >>> + #:use-module (guix utils) >>> + #:use-module (guix download) >>> + #:use-module (guix packages) >>> + #:use-module (guix build-system cmake) >>> + #:use-module (guix git-download) >>> + #:use-module (gnu packages)) >> I think machine-learning.scm would be a good home for this package, >> so a new file wouldn't be needed. >> >> >> >>> + >>> +(define-public libfann >>> + (package >>> + (name "libfann") >>> + (version "d71d54788b") >> >> >> The last release is 129 commits behind and it has been some time, so >> I think you are right - we should package from a git commit. >> >> Usually we package from git using this style though (i.e. reason for >> not using the release, use of 'file-name', and a version that >> includes the last release followed by '-1.'). >> >>   ;; There are no recent releases so we package from git. >>   (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87")) >>     (package >>       (name "newick-utils") >>       (version (string-append "1.6-1." (string-take commit 8))) >>       (source (origin >>                 (method git-fetch) >>                 (uri (git-reference >>                       (url >> "https://github.com/tjunier/newick_utils.git" >> ) >>                       (commit commit))) >>                 (file-name (string-append name "-" version "-checkout")) >>                 (sha256 >>                  (base32 >> "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268pxnb")))) >> >> >>> + (source (origin >>> + (method git-fetch) >>> + (uri (git-reference >>> + (url"https://github.com/libfann/fann.git" >>> ) >>> + (commit version))) >>> + (sha256 >>> + (base32 >>> + "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x")))) >>> + (build-system cmake-build-system) >>> + (arguments >>> + `(#:tests? #f)) >> I see from the website: >> >> >> >>> Once you have installed the library you can test it out by going to >>> the examples directory and type |make runtest|, which will compile >>> the examples and run a few of them to test that everything is working. >> Is that possible? Ideally, since there are tests it would be good to >> run them. >> >> >>> + (home-page"http://leenissen.dk/fann/wp/" ) >>> + (synopsis "Fast Artificial Neural Network") >>> + (description >>> + "FANN is a free open source neural network library, which implements >>> +multilayer artificial neural networks in C with support for both fully >>> +connected and sparsely connected networks.") >>> + (license license:lgpl2.1))) >> Otherwise LGTM. Can you send an updated patch please? >> >> >> Thanks, ben >> > > -- > Mark Meyer > mark@ofosos.org > --------------3C80730A335A6E802021B6EA Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Thanks Mark. I made a few small changes and pushed the patch as a9b34762391e6f3b066aef6fc1ebc614ec88db86.


On 02/02/18 01:32, Mark Meyer wrote:
Thanks for the good feedback. Please consider the attached patch.

Best, Mark

On Sun, Jan 28, 2018, at 03:13, Ben Woodcroft wrote:

Hi Mark,

Thanks for the patch.

+(define-module (gnu packages ai)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix build-system cmake)
+  #:use-module (guix git-download)
+  #:use-module (gnu packages))
I think machine-learning.scm would be a good home for this package, so a new file wouldn't be needed.



+
+(define-public libfann
+  (package
+    (name "libfann")
+    (version "d71d54788b")


The last release is 129 commits behind and it has been some time, so I think you are right - we should package from a git commit.

Usually we package from git using this style though (i.e. reason for not using the release, use of 'file-name', and a version that includes the last release followed by '-1.<commit>').

  ;; There are no recent releases so we package from git.
  (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87"))
    (package
      (name "newick-utils")
      (version (string-append "1.6-1." (string-take commit 8)))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                      (url "https://github.com/tjunier/newick_utils.git")
                      (commit commit)))
                (file-name (string-append name "-" version "-checkout"))
                (sha256
                 (base32
                  "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268pxnb"))))


+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/libfann/fann.git")
+                    (commit version)))
+              (sha256
+               (base32
+                "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f))
I see from the website:



Once you have installed the library you can test it out by going to the examples directory and type make runtest, which will compile the examples and run a few of them to test that everything is working.
Is that possible? Ideally, since there are tests it would be good to run them.


+    (home-page "http://leenissen.dk/fann/wp/")
+    (synopsis "Fast Artificial Neural Network")
+    (description
+     "FANN is a free open source neural network library, which implements
+multilayer artificial neural networks in C with support for both fully
+connected and sparsely connected networks.")
+    (license license:lgpl2.1)))
Otherwise LGTM. Can you send an updated patch please?


Thanks, ben


--
Mark Meyer
mark@ofosos.org


--------------3C80730A335A6E802021B6EA-- From unknown Tue Aug 19 09:34:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 Mar 2018 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator