GNU bug report logs - #30243
26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames

Previous Next

Full log

Message #47 received at 30243 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 30243 <at> debbugs.gnu.org, Philipp Stephani <p.stephani2 <at> gmail.com>
Subject: Re: bug#30243: 26.0.91;
 Infinite recursion in `make-auto-save-file-name' for quoted filenames
Date: Sun, 28 Jan 2018 20:17:16 +0100

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

>> Yes, would be better. There shall also be cleanup; I've added a missing
>> delete-file which was missing.
>
> Right, should all be done now.

I've pushed another fix, which uses file-name-quote{,d-p} instead of
messing with "/:". This is cleaner, and shall also be an example for
people who care about quoted file names.

Futhermore, I've added a small test, which demonstrates how to use these
functions.

>> I feel a little bit uncomfortable with this, because my fix in
>> file-notify-add-watch didn't get heavy testing.
>
> However, if you think the file-notify fix might possibly affect other
> things, I think leaving that part out for 26.1 would be acceptable.

LGTM.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.