From unknown Wed Sep 10 20:08:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30243 <30243@debbugs.gnu.org> To: bug#30243 <30243@debbugs.gnu.org> Subject: Status: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames Reply-To: bug#30243 <30243@debbugs.gnu.org> Date: Thu, 11 Sep 2025 03:08:16 +0000 retitle 30243 26.0.91; Infinite recursion in `make-auto-save-file-name' for= quoted filenames reassign 30243 emacs submitter 30243 phst@a.muc.corp.google.com severity 30243 normal tag 30243 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 17:22:49 2018 Received: (at submit) by debbugs.gnu.org; 24 Jan 2018 22:22:49 +0000 Received: from localhost ([127.0.0.1]:41478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeTRR-0007Wf-9c for submit@debbugs.gnu.org; Wed, 24 Jan 2018 17:22:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <3uARpWgQVDT8qitub.nvd.dpsq.hpphmf.dpncvh-hov-fnbdthov.psh@flex--phst.bounces.google.com>) id 1eeTHF-0006wZ-P1 for submit@debbugs.gnu.org; Wed, 24 Jan 2018 17:12:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <3uARpWgQVDT8qitub.nvd.dpsq.hpphmf.dpncvh-hov-fnbdthov.psh@flex--phst.bounces.google.com>) id 1eeTH9-0008UQ-JZ for submit@debbugs.gnu.org; Wed, 24 Jan 2018 17:12:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <3uARpWgQVDT8qitub.nvd.dpsq.hpphmf.dpncvh-hov-fnbdthov.psh@flex--phst.bounces.google.com>) id 1eeTH9-0008U8-GT for submit@debbugs.gnu.org; Wed, 24 Jan 2018 17:12:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <3uARpWgQVDT8qitub.nvd.dpsq.hpphmf.dpncvh-hov-fnbdthov.psh@flex--phst.bounces.google.com>) id 1eeTH8-00049j-AI for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 17:12:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <3uARpWgQVDT8qitub.nvd.dpsq.hpphmf.dpncvh-hov-fnbdthov.psh@flex--phst.bounces.google.com>) id 1eeTH6-0008QG-WF for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 17:12:10 -0500 Received: from mail-yw0-x249.google.com ([2607:f8b0:4002:c05::249]:55607) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <3uARpWgQVDT8qitub.nvd.dpsq.hpphmf.dpncvh-hov-fnbdthov.psh@flex--phst.bounces.google.com>) id 1eeTH6-0008Om-Qw for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 17:12:08 -0500 Received: by mail-yw0-x249.google.com with SMTP id l74so3031276ywc.22 for ; Wed, 24 Jan 2018 14:12:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to; bh=carquPhxtAGMHn6W6/b9hptw1qDrCllexXek9Si/Zss=; b=wO+N3QgM0jyXClPx5cw8VCkXjRJ/dC+cdZ359GdjeC9PAIG2oD0HdtZCjKQUZNY7vU gyJZRqY11ZunPHAbZqAEchHxeSOqtwISjXZqZ1JzhRI9ZEwy6mBUm2HlkBuEo1ocycIc pD6S5c9h9FbIZxdFPzA51uMSNhHYe2FpFYhlPPx/EO5JEDXopEu6AqzNRypcBxRMjAXz SAkwhoDNA61WmEfk9xkL4PkPte4Rrrp4dvtHcFAsQOi7NVJ8KyDDM20xKhkJj3K2i1KK IPzbJ/Hyc0fFOiNU0LajTqqpx8RxKmdZvWQHrl420GCT2rruCKwb8/7ZV4/T+8eSceC3 zogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to; bh=carquPhxtAGMHn6W6/b9hptw1qDrCllexXek9Si/Zss=; b=aPJJRJ4iGqhTw+M+AYB9VwzlNSXAzyA1tWzBenxuCbPSfPsAOCS0IXN0oXYVFdNZx+ S/GWRSMoJZcoWSZw5L+BHZD/4op2pAU6XeLUZ7ab6+szn2C5+hRtXxEaD3323VZuV424 q+iGgJgq7ZuuhhihQaDpZkPMv8WoSYsE52/XtAHSflqCVODJWf4GhreBX9atyE5ktMUw 7pc/oVZRgHQP0ndFebJocC2f6ba9hbkDam3tDh0mSlwe8YfT8pwIFUezB9jb6XH+tFKj uorXtuH2mBwdaQBjxSesHP6bqmdTOTThz3Lby+Paj/l8w270YF3ayuSlJo3i4ghG8Ld1 Z6rA== X-Gm-Message-State: AKwxytcmXmbMtApgJdiviO5L0+q9xC1CQtqzIPG5pk72anhkZFz9HdBz wmfkOGTUVOjmscQY X-Google-Smtp-Source: AH8x226lkXzhO/2qdUWOtA+9TFajVFCjdzJRQNvfjRQPQN8qAocCiQmsP7hLNdic13O1t3T8tSz6FCwH X-Received: by 10.129.212.7 with SMTP id z7mr4001062ywi.160.1516831928154; Wed, 24 Jan 2018 14:12:08 -0800 (PST) Date: Wed, 24 Jan 2018 23:12:04 +0100 Message-Id: Mime-Version: 1.0 Subject: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames From: phst@a.muc.corp.google.com To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 24 Jan 2018 17:22:48 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q -nw -batch --eval=3D'(with-temp-buffer (let ((buffer-file-name "/:= /tmp/x")) (make-auto-save-file-name)))' Variable binding depth exceeds max-specpdl-size Since find-file calls after-find-file, which calls make-auto-save-file-name, this can be trivially reproduced by visiting any quoted file in Emacs 26, e.g. using C-x f /:/tmp/a. I think this should block the Emacs 26 release because it makes quoted file names essentially unusable. In GNU Emacs 26.0.91 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.24) of 2018-01-24 built on localhost Repository revision: 59db8dca030ba6a34d143c3cc6715f02beba1068 Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Debian GNU/Linux Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --without-threads --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 95204 8643) (symbols 48 20381 1) (miscs 40 41 145) (strings 32 28348 1660) (string-bytes 1 755236) (vectors 16 14065) (vector-slots 8 497282 8868) (floats 8 49 68) (intervals 56 223 0) (buffers 992 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 17:43:56 2018 Received: (at 30243) by debbugs.gnu.org; 24 Jan 2018 22:43:56 +0000 Received: from localhost ([127.0.0.1]:41504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeTls-0001WG-Bg for submit@debbugs.gnu.org; Wed, 24 Jan 2018 17:43:56 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:42654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeTlr-0001W4-1K for 30243@debbugs.gnu.org; Wed, 24 Jan 2018 17:43:55 -0500 Received: by mail-lf0-f51.google.com with SMTP id q17so7303878lfa.9 for <30243@debbugs.gnu.org>; Wed, 24 Jan 2018 14:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KVymEpbXCsFSAnhAL7S03QxCmrL78Nlr8cYrKywqdT4=; b=CeXZUMCkpBkwUhAO3y/mlmqmxRoYZDjz4Qa4m5abGy1qdon/7ZD753/6ipQZhxfMt1 OEf/gQMX0GUGzYGf4o+dY55xquW2v674Vfu/nDrQct/macvIOKLpoZQcdQy5skRNVvff U3T1zIUErRRp0HuP9crVSbs0IlBc50RKpqbez8cLLytYp09SVLK40G0KMxWedBuw/fnq mCGQ8Daq5S+NqC56bbVGjCztKvuTYbvDbZKZ7U9nqqf/pp3A1WzC7qvcqcor/sbXxFid PAlOAGKkuREmhYJnnnW5+MDts6UYMlNFt5tXzxj3+yUn7yrHZPLxBy5aqugaQHRyndO6 wvYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KVymEpbXCsFSAnhAL7S03QxCmrL78Nlr8cYrKywqdT4=; b=bFQt4fCqjpcboRDJajq8r/ErCFvqGRkdF3oM7VO4HiVPjSq8i/DpuyG+kYQvNTYz9I BjPq2kvomEF0m+wrxAdyMFm1hs28r1o82JC8ga82/Yel+oGmlNEwXeonZLtPfk8KCl8E hK2s8QykH6Oita81UAwwueAZfmPvRDseRpqtdaHsjsyFmJvyCZ0n86r69bAIZprgAkaj oZr4lFxATsVLzO/ke+wEPZMXrkErpt5K0RA9AkIx5FEvVcJ1ttuTbvlCr/SeQ75X2oOQ ZJf0+cLWaibfEnfR55remLusg7Qa5moT8Uh8Y7pVn27oJsjEIIE5kCA45W6QVzq71PM0 65Tg== X-Gm-Message-State: AKwxyte7QaHuCI3Y4fOJIsJnUiISD5IdRChyAC8IDSSL0z2uUbq2Xycl XAr504JknIMtMmd8Fw9MVeN8jhqFBi9YbRNgn9s= X-Google-Smtp-Source: AH8x224WhADtMFUuPXIWT5MJ9yWAgYBCLUYDfnFnT5m2peCeW/8qrd5Z99OAt2wdvcSOJotD05gEy99R+oRW/za2MXY= X-Received: by 10.46.77.87 with SMTP id a84mr4282597ljb.100.1516833828923; Wed, 24 Jan 2018 14:43:48 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Wed, 24 Jan 2018 22:43:38 +0000 Message-ID: Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames To: phst@a.muc.corp.google.com Content-Type: multipart/alternative; boundary="94eb2c1abb708e6df205638d65d4" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c1abb708e6df205638d65d4 Content-Type: text/plain; charset="UTF-8" schrieb am Mi., 24. Jan. 2018 um 23:23 Uhr: > > emacs -Q -nw -batch --eval=3D'(with-temp-buffer (let ((buffer-file-name > "/:= > /tmp/x")) (make-auto-save-file-name)))' > Variable binding depth exceeds max-specpdl-size > > According to git bisect, the problematic commit is: commit a1bbc490155b61a634a6d0b165000ce35b93aa35 (HEAD, refs/bisect/bad) Author: Michael Albinus Date: Wed Dec 6 20:49:30 2017 +0100 Fix Bug#29579 * lisp/files.el (file-name-non-special): Inhibit `file-name-handler-alist' only for some operations. Add missing operations. (Bug#29579) [...] which makes sense because it touches the part of the code that's causing issues. Since this commit was a bug fix for a related issue with quoted file names, reverting it is probably not the best way forward. We should push a fix and make a new pretest. --94eb2c1abb708e6df205638d65d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<phst@a.muc.corp.google.com&= gt; schrieb am Mi., 24. Jan. 2018 um 23:23=C2=A0Uhr:

emacs -Q -nw -batch --eval=3D3D'(with-temp-buffer (let ((buffer-file-na= me "/:=3D
/tmp/x")) (make-auto-save-file-name)))'
Variable binding depth exceeds max-specpdl-size

According to git bisect, the problematic commit is:
=
commit a1bbc490155b61a634a6d0b165000ce35b93aa35 (HEAD, = refs/bisect/bad)
Author: Michael Albinus <michael.albinus@gmx.de>
Date:=C2=A0 = =C2=A0Wed Dec 6 20:49:30 2017 +0100

=C2=A0 =C2=A0 = Fix Bug#29579
=C2=A0 =C2=A0=C2=A0
=C2=A0 =C2=A0 * lisp/= files.el (file-name-non-special):
=C2=A0 =C2=A0 Inhibit `file-nam= e-handler-alist' only for some operations.
=C2=A0 =C2=A0 Add = missing operations.=C2=A0 (Bug#29579)

[...]<= /div>

which makes sense because it touches the part of t= he code that's causing issues.
Since this commit was a bug fi= x for a related issue with quoted file names, reverting it is probably not = the best way forward. We should push a fix and make a new pretest.
--94eb2c1abb708e6df205638d65d4-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 18:04:48 2018 Received: (at 30243) by debbugs.gnu.org; 24 Jan 2018 23:04:48 +0000 Received: from localhost ([127.0.0.1]:41514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeU64-00021H-DQ for submit@debbugs.gnu.org; Wed, 24 Jan 2018 18:04:48 -0500 Received: from mail-it0-f45.google.com ([209.85.214.45]:39592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeU62-000210-6m for 30243@debbugs.gnu.org; Wed, 24 Jan 2018 18:04:46 -0500 Received: by mail-it0-f45.google.com with SMTP id 68so7127387ite.4 for <30243@debbugs.gnu.org>; Wed, 24 Jan 2018 15:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lKi/pODzyWyOXeUrs3shvft+WjsaMIaL8zG4lLRznr8=; b=UM+rG8oTYWKtE4VuU+7mwVwlvdPQWSP+KoXxBJE4ydltB21JrQNnF4shJcB8x4XlCw 8xRLxvBeBOo/WCwdrLfbTikJ2dEroT/dFHlRg6T/j+vXwhzf/eipB+e2Q+ztzcEH7KPH iRJjsxu5NAHlZV4K0dk69+Q13xqFDtnAZF/D6g38hkzf3MIzaME57fOcNDStyyP64LZy xYNd+D3vg+WbnDoKogcH/JNm0Kuy/0DWFyqoEqZEst6YKflszUvzfcUbh+vtqd/bHd8n kRAPuq0JXWtkbqPUvWR0BiswFGQIHQY6Dzeu4FYga1xqZMhHS29nmnPR+WnbV+I0j3KF Q+6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=lKi/pODzyWyOXeUrs3shvft+WjsaMIaL8zG4lLRznr8=; b=Wy+fg/FHnYDM2jjuXPa8bXC2IdPAsInyf19o4mC+ZlK7Kmyf7xHa65t5HBtJOMWf2d nFDFFN2rrN23hLi5pj5fOeqpWbyDHfsfA1s/41VkEnUwsWkwt0zzhr8Dq52B3WN24mf+ i4iqYNlm9MdFlUIw1nyl6lt/tgeOLb+PKzxCd06KFqQ9EeEMmzmLRaFxXWf/PMZ/45zx SIAYu8TnfHmlhCT/q5WSUhAEVDkNIL87rX593wSH39n7nCvr3KYjIMyDQPli4R9jqqW6 CpCkym1rkw1ElQxx7frepKW+Zi00hNN0KUqDkaEY19IPAlzVu14Rub0xqXHBrDBJKt4+ nvkA== X-Gm-Message-State: AKwxytd3oheQcv/GZV0VlFRpaxTOfAbwSuDus5iB5YWmnoyBO7anC4Si u1cGezvrYETbFWOzDQwUnhhM0Q== X-Google-Smtp-Source: AH8x225RvhkhIxH1wqLHatlykSfYhm8QSIRkbpheBk6U4HfWs6elgROUBcSqPogOAL5RggX8obYIRg== X-Received: by 10.36.208.146 with SMTP id m140mr10524935itg.61.1516835080459; Wed, 24 Jan 2018 15:04:40 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w133sm705198itc.44.2018.01.24.15.04.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 15:04:39 -0800 (PST) From: Noam Postavsky To: Philipp Stephani Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: Date: Wed, 24 Jan 2018 18:04:38 -0500 In-Reply-To: (Philipp Stephani's message of "Wed, 24 Jan 2018 22:43:38 +0000") Message-ID: <87shaun9ix.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, phst@a.muc.corp.google.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Philipp Stephani writes: > Since this commit was a bug fix for a related issue with quoted file > names, reverting it is probably not the best way forward. We should > push a fix and make a new pretest. The following seems to fix it. We should review other file handler operations of course, but can we really expect to learn anything from another pretest? --- i/lisp/files.el +++ w/lisp/files.el @@ -7004,6 +7004,11 @@ file-name-non-special (expand-file-name (unhandled-file-name-directory default-directory))) default-directory)) + (buffer-file-name + (if (and (memq operation '(make-auto-save-file-name)) + (string-match "\\`/:" buffer-file-name)) + (substring buffer-file-name (match-end 0)) + buffer-file-name)) ;; Get a list of the indices of the args which are file names. (file-arg-indices (cdr (or (assq operation From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 18:25:53 2018 Received: (at 30243) by debbugs.gnu.org; 24 Jan 2018 23:25:53 +0000 Received: from localhost ([127.0.0.1]:41526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeUQT-0002UP-05 for submit@debbugs.gnu.org; Wed, 24 Jan 2018 18:25:53 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:42983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeUQR-0002UC-5k for 30243@debbugs.gnu.org; Wed, 24 Jan 2018 18:25:51 -0500 Received: by mail-lf0-f54.google.com with SMTP id q17so7408506lfa.9 for <30243@debbugs.gnu.org>; Wed, 24 Jan 2018 15:25:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oe+cqRFQO0p6WBoypWh9wWnl1cYHWpYqIL/RbmSeh9w=; b=KORsebSu0DdDmxHye2I58aDZXg7sGZ6aGtQHqF5VeVhm86Imw0RZuRq/2l5jplPIyR SW/v/xXRWBvXTppGawn2N3oyV21dnNYmTzOMM98qpdjv64QPUHxRHQI9nYtgBLMcohGM yCsUrOZmvgSz4DHSbd+dCSwx9Soulp5E+cx+117mv6lyIuN5Bnd6QWXNJ4Q6C2d4vETP shfXOaTpSWM3Z8xpOF/ugmP5y1ELW4jfhyd3ctyrxgMAWIQ348OUpnqQdvwBDjjulZmt 0oz00Tt4O5N7oCCod/DJxj5YI/gqiuCaztA/gEKSWueRQXcadgVmIPXf9BLEIZyk5YBV ESgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oe+cqRFQO0p6WBoypWh9wWnl1cYHWpYqIL/RbmSeh9w=; b=aK+nPNr1eSh/w/UVI9vO1OlfSvYonF3ogTI0M8R4XjBbxiyLdlY8AhmNKI0kc5tnpT BxEzBztG3tAOa7AwYiSXJsoy5PY7DU1lEi4FvwPP+GgzyTcHOmpjbN9OWdbK0GOwc8kB ZzFXhi4c9As556xJ66h9qLUI96Tsom17c0DadmfpBi0kiw1S7JaHGAYPfbXrA2fl9bg/ UzegPyd6PaEMvl0BddbaeJca9tD9K0G353DOzxe04OPLk7Xi2RioQdPWiqcF5cO+gA9i 9crMyseNslGUlPQtmImXgTiV1oFNQdlcriLv8Xo1BVnUj7l4EpLJBO7CcjaoFmG0hvOn Hwaw== X-Gm-Message-State: AKwxyteCjzFGeiEIUHmfG/Rn/MB3M22ewQXiGKNsIgqrgISr24iYbBZG pEr7ATlGtBnA049p6j8i3PQVmPQeVYxVuf873+s= X-Google-Smtp-Source: AH8x224nO4Q08AKCjpkROI14Kv9UH0e5786+oZ3d//pxEsE/rKEURMSkszbJtmA+GnjEqokclo9o276FING+kmNEbAQ= X-Received: by 10.46.118.18 with SMTP id r18mr4329089ljc.11.1516836345214; Wed, 24 Jan 2018 15:25:45 -0800 (PST) MIME-Version: 1.0 References: <87shaun9ix.fsf@users.sourceforge.net> In-Reply-To: <87shaun9ix.fsf@users.sourceforge.net> From: Philipp Stephani Date: Wed, 24 Jan 2018 23:25:34 +0000 Message-ID: Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames To: Noam Postavsky Content-Type: multipart/alternative; boundary="f4f5e80762f089fd8f05638dfbd2" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, phst@a.muc.corp.google.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --f4f5e80762f089fd8f05638dfbd2 Content-Type: text/plain; charset="UTF-8" Noam Postavsky schrieb am Do., 25. Jan. 2018 um 00:04 Uhr: > Philipp Stephani writes: > > > Since this commit was a bug fix for a related issue with quoted file > > names, reverting it is probably not the best way forward. We should > > push a fix and make a new pretest. > > The following seems to fix it. We should review other file handler > operations of course, but can we really expect to learn anything from > another pretest? > > --- i/lisp/files.el > +++ w/lisp/files.el > @@ -7004,6 +7004,11 @@ file-name-non-special > (expand-file-name > (unhandled-file-name-directory default-directory))) > default-directory)) > + (buffer-file-name > + (if (and (memq operation '(make-auto-save-file-name)) > + (string-match "\\`/:" buffer-file-name)) > + (substring buffer-file-name (match-end 0)) > + buffer-file-name)) > ;; Get a list of the indices of the args which are file names. > (file-arg-indices > (cdr (or (assq operation > Thanks, when you commit this, could you please also add a regression test so we don't reintroduce the bug later? --f4f5e80762f089fd8f05638dfbd2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Noam P= ostavsky <npostavs@use= rs.sourceforge.net> schrieb am Do., 25. Jan. 2018 um 00:04=C2=A0Uhr:=
Philipp Stephani <p.stephani2@gmail.com>= writes:

> Since this commit was a bug fix for a related issue with quoted file > names, reverting it is probably not the best way forward. We should > push a fix and make a new pretest.

The following seems to fix it.=C2=A0 We should review other file handler operations of course, but can we really expect to learn anything from
another pretest?

--- i/lisp/files.el
+++ w/lisp/files.el
@@ -7004,6 +7004,11 @@ file-name-non-special
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (expand-file-name =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(unhandled-fi= le-name-directory default-directory)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0default-directory))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(buffer-file-name
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (if (and (memq operation '(make-aut= o-save-file-name))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(stri= ng-match "\\`/:" buffer-file-name))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (substring buffer-file-na= me (match-end 0))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 buffer-file-name))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Get a list of the indices of the args = which are file names.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-arg-indices
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (cdr (or (assq operation

Thanks, when you commit this, could you please also ad= d a regression test so we don't reintroduce the bug later?=C2=A0
<= /div>
--f4f5e80762f089fd8f05638dfbd2-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 00:57:58 2018 Received: (at 30243) by debbugs.gnu.org; 25 Jan 2018 05:57:58 +0000 Received: from localhost ([127.0.0.1]:41633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeaXu-00034k-5j for submit@debbugs.gnu.org; Thu, 25 Jan 2018 00:57:58 -0500 Received: from mail-io0-f178.google.com ([209.85.223.178]:35998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeaXs-00034V-A5 for 30243@debbugs.gnu.org; Thu, 25 Jan 2018 00:57:56 -0500 Received: by mail-io0-f178.google.com with SMTP id l17so7399319ioc.3 for <30243@debbugs.gnu.org>; Wed, 24 Jan 2018 21:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AYlJepg3qeozTzjomQjhFavlIYYZe/cv+PC411zUZr0=; b=FDJwJ3cjEagvtEcE8TvpSk3RhneL3MIcjehmoLU+4DtaJqPcLpjJ4km6ciNk2Ba6rd wq/bjLOYVS+5xBnzZVO+SegH7F7DoZ/KYmLfOEwvNVm1CGSLBOog0ZQMPlKar86Dgd8d JtCi58UXpg7H6S9twCeitOgXHL3rL2lKlc8fjjl0otMqFXvh9WGfaor5/hZK/Eu0MQ91 VC9EqTKd+ANrD3KxL6Qk8/ffhnjwV5ZJOZT/f+pL9eM0RvGb6Lbi4B7WnrT48tldIk2Q NI8DzsqASSKDEcw4mvvjN3mllB15pVT48tFuuRb0OKuX2PJPB7hi7TyK3uQFoEFBnTGE 5b4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=AYlJepg3qeozTzjomQjhFavlIYYZe/cv+PC411zUZr0=; b=l6pGHsvCdHEXBTavlqlwb1xUASHOHpLqstOd3vBXXFbAI4+oddRCMAxFWhGbiO6J92 xAvl6KRlHgITzFr18620YYYkBWL6cslvWHSg5LuiOb1mSkZ6wR+YhFngAEcJOk8jMFLP aFZXbRRwpE0Z0uNogXXJ+SxdJMp12qAxhY0iJTrldTT80NbESy6/PoTvmsyerGqZ4TbK g9oaTJtuhMSEqnBLn0AxOG+6QWjluoGGcabFYZlnB0bsbNIIODR8OqEnB1pTe3ZttkXG TvPFxmPR3O/+omLzmhupfQ6RsUDbB18GnaQceVAz7k0628JCbZgGREZWmrR407aS3/DH rHzw== X-Gm-Message-State: AKwxytfl9MJdqHWlcBdTGgGG7DaDNl50NTBeB2vQVFYQtKE7/Izhqqd8 NNCm6kiTyuNqu3GrpmMqvf0= X-Google-Smtp-Source: AH8x227frv1dx4EBzFyqf4PDZTW3oibyFRrlSwnHWn2DCzPOtkkctijg+N5x3pvZSyvFGsHX/s6eAw== X-Received: by 10.107.139.82 with SMTP id n79mr10586149iod.94.1516859870771; Wed, 24 Jan 2018 21:57:50 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c9sm1210333iod.5.2018.01.24.21.57.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 21:57:49 -0800 (PST) From: Noam Postavsky To: Philipp Stephani Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> Date: Thu, 25 Jan 2018 00:57:46 -0500 In-Reply-To: (Philipp Stephani's message of "Wed, 24 Jan 2018 23:25:34 +0000") Message-ID: <87po5ymqed.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, phst@a.muc.corp.google.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Philipp Stephani writes: > Noam Postavsky schrieb am Do., 25. > Jan. 2018 um 00:04=C2=A0Uhr: > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(buffer-file-name > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (if (and (memq operation '(make-a= uto-save-file-name)) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(string-match "\\`/:" buffer-file-name)) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (substring buffer-f= ile-name (match-end 0)) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 buffer-file-name)) > Thanks, when you commit this, could you please also add a regression > test so we don't reintroduce the bug later?=C2=A0 Yeah, we need to test more than just that operation though. I've added a test for all the operations listed in `(elisp) Magic File Names'. I discovered several other similar problems. With `file-name-all-completions' I even got Emacs to crash (I presume due to stack corruption during the recursion). Also note that the above patch breaks find-file for /: quoted files, buffer-file-name needs to be bound more selectively (as in the new patch, attached below). `file-notify-rm-watch' and `file-notify-valid-p' are still broken, I can't immediately see how to fix them and it's getting past my bedtime. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v2-0001-Test-and-fix-quoted-file-name-handlers-Bug-30243.patch Content-Description: patch >From 5adeec4f3367ac5406e14c3b9c376a2cabc6d5ea Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 25 Jan 2018 00:37:50 -0500 Subject: [PATCH v2] Test and fix "/:" quoted file name handlers (Bug#30243) * lisp/files.el (file-name-non-special): Strip the "/:" from `default-directory' for `temporary-file-directory' operation; both arguments to `file-name-completion', `file-name-all-completion', and `file-equal-p' operations; `buffer-file-name' for `make-auto-save-file-name' and 'set-visited-file-modtime' operations. Don't touch any operands of `file-notify-rm-watch' and `file-notify-valid-p' as they receive descriptors; not file names (this is not sufficient to fix these operations for "/:" quoted file names though). * test/lisp/files-tests.el (files-tests--with-temp-dir): New macro. (files-file-name-non-special-notify-handlers) (files-file-name-non-special-handlers): New tests. --- lisp/files.el | 21 +++++- test/lisp/files-tests.el | 186 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 203 insertions(+), 4 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index 66420e7259..576640393f 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -6999,7 +6999,7 @@ file-name-non-special ;; Bug#25949. (if (memq operation '(insert-directory process-file start-file-process - shell-command)) + shell-command temporary-file-directory)) (directory-file-name (expand-file-name (unhandled-file-name-directory default-directory))) @@ -7023,15 +7023,22 @@ file-name-non-special ;; temporarily to unquoted filename. (verify-visited-file-modtime unquote-then-quote) ;; List the arguments which are filenames. - (file-name-completion 1) - (file-name-all-completions 1) + (file-name-completion 0 1) + (file-name-all-completions 0 1) + (file-equal-p 0 1) (write-region 2 5) (rename-file 0 1) (copy-file 0 1) (copy-directory 0 1) (file-in-directory-p 0 1) (make-symbolic-link 0 1) - (add-name-to-file 0 1)))) + (add-name-to-file 0 1) + (make-auto-save-file-name buffer-file-name) + (set-visited-file-modtime buffer-file-name) + ;; These file-notify-* operations take a + ;; descriptor. + (file-notify-rm-watch . nil) + (file-notify-valid-p . nil)))) ;; For all other operations, treat the first argument only ;; as the file name. '(nil 0)))) @@ -7054,6 +7061,12 @@ file-name-non-special (pcase method (`identity (car arguments)) (`add (file-name-quote (apply operation arguments))) + (`buffer-file-name + (let ((buffer-file-name + (if (string-match "\\`/:" buffer-file-name) + (substring buffer-file-name (match-end 0)) + buffer-file-name))) + (apply operation arguments))) (`insert-file-contents (let ((visit (nth 1 arguments))) (unwind-protect diff --git a/test/lisp/files-tests.el b/test/lisp/files-tests.el index 8dbfc2965c..4738a50b43 100644 --- a/test/lisp/files-tests.el +++ b/test/lisp/files-tests.el @@ -21,6 +21,9 @@ (require 'ert) (require 'nadvice) +(require 'bytecomp) ; `byte-compiler-base-file-name'. +(require 'dired) ; `dired-uncache'. +(require 'filenotify) ; `file-notify-add-watch'. ;; Set to t if the local variable was set, `query' if the query was ;; triggered. @@ -286,6 +289,14 @@ files-tests--with-temp-file (progn ,@body) (delete-file ,name)))) +(defmacro files-tests--with-temp-dir (name &rest body) + (declare (indent 1)) + (cl-check-type name symbol) + `(let ((,name (make-temp-file "emacs" t))) + (unwind-protect + (progn ,@body) + (delete-directory ,name t)))) + (ert-deftest files-tests--file-name-non-special--buffers () "Check that Bug#25951 is fixed. We call `verify-visited-file-modtime' on a buffer visiting a file @@ -327,6 +338,181 @@ files-tests--with-temp-file `((verify-visited-file-modtime ,buffer-visiting-file) (verify-visited-file-modtime nil)))))))) +(ert-deftest files-file-name-non-special-notify-handlers () + :expected-result :failed + (files-tests--with-temp-file tmpfile + (let* ((nospecial (concat "/:" tmpfile)) + (watch (file-notify-add-watch nospecial '(change) #'ignore))) + (should (file-notify-valid-p watch)) + (file-notify-rm-watch watch)))) + + +(ert-deftest files-file-name-non-special-handlers () + (files-tests--with-temp-file tmpfile + (files-tests--with-temp-dir tmpdir + (let ((nospecial (concat "/:" tmpfile)) + (nospecial-dir (concat "/:" tmpdir))) + (should (null (access-file nospecial "test"))) + (let ((newname (concat nospecial "add-name"))) + (add-name-to-file nospecial newname) + (should (file-exists-p newname))) + (should (equal (byte-compiler-base-file-name nospecial) + (byte-compiler-base-file-name tmpfile))) + (let ((newname (concat (directory-file-name nospecial-dir) + "copy-dir"))) + (copy-directory nospecial-dir newname) + (should (file-directory-p newname)) + (delete-directory newname) + (should-not (file-directory-p newname))) + (let ((newname (concat (directory-file-name nospecial) + "copy-file"))) + (copy-file nospecial newname) + (should (file-exists-p newname)) + (delete-file newname) + (should-not (file-exists-p newname))) + (should (equal (diff-latest-backup-file nospecial) + (diff-latest-backup-file tmpfile))) + (should (equal (directory-file-name nospecial-dir) + (concat "/:" (directory-file-name tmpdir)))) + (should (equal (directory-files nospecial-dir) + (directory-files tmpdir))) + (should (equal (directory-files-and-attributes nospecial-dir) + (directory-files-and-attributes tmpdir))) + (dired-compress-file (dired-compress-file nospecial)) + (dired-uncache nospecial-dir) + (should (equal (expand-file-name nospecial) + nospecial)) + (should (file-accessible-directory-p nospecial-dir)) + (should (equal (file-acl nospecial) + (file-acl tmpfile))) + (should (equal (file-attributes nospecial) + (file-attributes tmpfile))) + (should (equal (file-directory-p nospecial-dir) + (file-directory-p tmpdir))) + (should (file-equal-p nospecial tmpfile)) + (should (file-equal-p tmpfile nospecial)) + (should-not (file-executable-p nospecial)) + (should (file-exists-p nospecial)) + (should (file-in-directory-p nospecial temporary-file-directory)) + (should-not (file-in-directory-p nospecial nospecial-dir)) + (should-not (file-in-directory-p tmpfile nospecial-dir)) + (should-not (file-local-copy nospecial)) ; Already local. + (should (equal (file-modes nospecial) + (file-modes tmpfile))) + (should (equal (file-name-all-completions nospecial nospecial-dir) + (file-name-all-completions tmpfile tmpdir))) + (file-name-as-directory nospecial) + (should (equal (file-name-case-insensitive-p nospecial) + (file-name-case-insensitive-p tmpfile))) + (should (equal (file-name-completion nospecial nospecial-dir) + (file-name-completion tmpfile tmpdir))) + (should (equal (file-name-directory nospecial) + (concat "/:" temporary-file-directory))) + (should (equal (file-name-nondirectory nospecial) + (file-name-nondirectory tmpfile))) + (should (equal (file-name-sans-versions nospecial) + nospecial)) + (should-not (file-newer-than-file-p nospecial tmpfile)) + (should (equal (file-ownership-preserved-p nospecial) + (file-ownership-preserved-p tmpfile))) + (should (file-readable-p nospecial)) + (should (file-regular-p nospecial)) + (should-not (file-remote-p nospecial)) + (should (equal (file-selinux-context nospecial) + (file-selinux-context tmpfile))) + (should-not (file-symlink-p nospecial)) + (file-truename nospecial) + (should (file-writable-p nospecial)) + (should (equal (find-backup-file-name nospecial) + (mapcar (lambda (f) (concat "/:" f)) + (find-backup-file-name tmpfile)))) + (should-not (get-file-buffer nospecial)) + (should (equal (with-temp-buffer + (insert-directory nospecial-dir nil) + (buffer-string)) + (with-temp-buffer + (insert-directory tmpdir nil) + (buffer-string)))) + (with-temp-buffer + (insert-file-contents nospecial) + (should (zerop (buffer-size)))) + (should (load nospecial)) + (save-current-buffer + (should (equal (prog2 (set-buffer (find-file-noselect nospecial)) + (make-auto-save-file-name) + (kill-buffer)) + (prog2 (set-buffer (find-file-noselect tmpfile)) + (make-auto-save-file-name) + (kill-buffer))))) + (let ((default-directory nospecial-dir)) + (make-directory "dir") + (should (file-directory-p "dir")) + (delete-directory "dir") + (make-directory-internal "dir") + (should (file-directory-p "dir")) + (delete-directory "dir") + (let ((near-tmpfile (make-nearby-temp-file "file"))) + (should (file-exists-p near-tmpfile)) + (delete-file near-tmpfile))) + (let* ((linkname (expand-file-name "link" tmpdir)) + (may-symlink (ignore-errors (make-symbolic-link tmpfile linkname) + t))) + (when may-symlink + (should (file-symlink-p linkname)) + (delete-file linkname) + (let ((linkname (expand-file-name "link" nospecial-dir))) + (make-symbolic-link tmpfile linkname) + (should (file-symlink-p linkname)) + (delete-file linkname)))) + ;; `files-tests--file-name-non-special--subprocess' already + ;; tests `process-file'. + (rename-file nospecial (concat nospecial "x")) + (rename-file (concat nospecial "x") nospecial) + (rename-file tmpfile (concat nospecial "x")) + (rename-file (concat nospecial "x") nospecial) + (rename-file nospecial (concat tmpfile "x")) + (rename-file (concat nospecial "x") nospecial) + (set-file-acl nospecial (file-acl nospecial)) + (set-file-modes nospecial (file-modes nospecial)) + (set-file-selinux-context nospecial (file-selinux-context nospecial)) + (set-file-times nospecial) + ;; `files-tests--file-name-non-special--buffers' already tests + ;; `verify-visited-file-modtime'. + (with-temp-buffer + (write-region nil nil nospecial nil :visit)) + (save-current-buffer + (set-buffer (find-file-noselect nospecial)) + (set-visited-file-modtime) + (kill-buffer)) + (with-temp-buffer + (let ((default-directory nospecial-dir)) + (shell-command (concat (shell-quote-argument + (concat invocation-directory invocation-name)) + " --version") + (current-buffer)) + (goto-char (point-min)) + (should (search-forward emacs-version nil t)))) + (with-temp-buffer + (let ((default-directory nospecial-dir)) + (let ((proc (start-file-process + "emacs" (current-buffer) + (concat invocation-directory invocation-name) + "--version"))) + (accept-process-output proc) + (goto-char (point-min)) + (should (search-forward emacs-version nil t)) + (kill-process proc) + (accept-process-output proc )))) + (let ((process-environment (cons "FOO=foo" process-environment))) + ;; The "/:" prevents substitution. + (equal (substitute-in-file-name nospecial) nospecial)) + (let ((default-directory nospecial-dir)) + (equal (temporary-file-directory) temporary-file-directory)) + (equal (unhandled-file-name-directory nospecial-dir) + (file-name-as-directory tmpdir)) + (should (equal (vc-registered nospecial) + (vc-registered tmpfile))))))) + (ert-deftest files-tests--insert-directory-wildcard-in-dir-p () (let ((alist (list (cons "/home/user/*/.txt" (cons "/home/user/" "*/.txt")) (cons "/home/user/.txt" nil) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 04:49:24 2018 Received: (at 30243) by debbugs.gnu.org; 25 Jan 2018 09:49:24 +0000 Received: from localhost ([127.0.0.1]:41742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eee9s-0000iA-30 for submit@debbugs.gnu.org; Thu, 25 Jan 2018 04:49:24 -0500 Received: from mout.gmx.net ([212.227.17.20]:52524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eee9q-0000hw-EJ for 30243@debbugs.gnu.org; Thu, 25 Jan 2018 04:49:22 -0500 Received: from detlef.gmx.de ([79.140.117.159]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MOCSm-1ekASa3RJc-005b1B; Thu, 25 Jan 2018 10:49:04 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames In-Reply-To: <87po5ymqed.fsf@users.sourceforge.net> (Noam Postavsky's message of "Thu, 25 Jan 2018 00:57:46 -0500") References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Thu, 25 Jan 2018 10:49:04 +0100 Message-ID: <874lnafeun.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:HCMWUKaO4IAeJFOlz7ArfLFv2/WFO+g5ijEuO1ixtlT9TzHFOG7 wBsQ0wc7RbcQFp2GMbc524RWOT7WJo1aTNYsHfEaimBvX5L3GfE1Ow8yVIbTadx+13+mlrr IKB0F0MZBVypt+SjD1fe/Gc++wF7AyJ1tEDQkdcQY9QvpUjZ65Xnf+9kJQgKZMTEH6a/JqF 6U5eMyuoVvKFcGxOnknZQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:fW57aW8Y/MY=:4Gvtb9UQjoQcIWvvkRJWEz Zczc9wzCc608fbxSjgqLtcDpVGC1tFpT4dWD6wFXWJFjckWIqa6JTYaAsmqqmNRE2p9GyaUjb tugFUA6Fa2L3BalPi3nGvLRuVuLp/CIQS2R5QC8JKD1wge/RfIHn72EFvNzdTVTdcXCteo6D1 ORhp2R8XUYVQGYlndtqABVmFcnZryQOPfz/+PFM0kYb3KFTWeFgNAQmR2tUpsahQdp6lPHdcH 84/wjZXSDOZIXx1oZdNDhYa/78z2JGk3/PG8ITos8wrrE96ekroQgTGouoNfMcyGhGAa3RpyO qu3K+55rLD4SZO5YiFxWI85VTvioam9GlURkD77VY0SN402DehIXu20jdsdO5xdqvAuokx7BL mrkzwLmpwwUdMhME1oWFAFGLjrjz2X5IFU4eqo/b3ZnvfxCmLYkbkJjvC/qIcNVi5EUnoUN/L /zHJ6UzTsB5Lh+8vbn417e7vxrms5NbB7XUcqHkRrCmgyUeFNHGZYcnh8BkaATqf037D0XSmb GJMKtgvmaErFr7WMPcgjHCirapoo+EMg9ybvUJj5SU63ujQ1qS5NHqeGpTEf2tyfS/AqugU1W p2Jd8hjm5WvVlVvlmv0cO+mmNF5/2j+5PgI9ImminGOcf5DEXtziKI7d/k5/Gcuju6U/tk7of k8N7ThLCxNW5NfJ9A8sFn4duF64RwZFm1HbtNJ7/uOsqMgX5buuAwcVcjui79DI5tn6HmykZc Md5pqpogHVoq84V4QTKDSbOsM98C7BH+qnJzareQWy7rsgavhzpvM44smWO3ZE44hDxW22VFp vFUkXD7U0XBCeWduzv+jjV2/PGmZbOSC1qo7UZXN8dIH4JmJbA= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: Hi Noam, > Yeah, we need to test more than just that operation though. I've added > a test for all the operations listed in `(elisp) Magic File Names'. I > discovered several other similar problems. With > `file-name-all-completions' I even got Emacs to crash (I presume due to > stack corruption during the recursion). Also note that the above patch > breaks find-file for /: quoted files, buffer-file-name needs to be bound > more selectively (as in the new patch, attached below). > > `file-notify-rm-watch' and `file-notify-valid-p' are still broken, I > can't immediately see how to fix them and it's getting past my bedtime. Maybe I could be of some help? Pls commit your changes you have worked on, and tell me which missing part I shall try to follow. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 09:07:40 2018 Received: (at 30243) by debbugs.gnu.org; 25 Jan 2018 14:07:40 +0000 Received: from localhost ([127.0.0.1]:41890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeiBn-00006m-Pm for submit@debbugs.gnu.org; Thu, 25 Jan 2018 09:07:39 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:43506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeiBm-00006Z-9B for 30243@debbugs.gnu.org; Thu, 25 Jan 2018 09:07:38 -0500 Received: by mail-io0-f169.google.com with SMTP id 72so8728447iom.10 for <30243@debbugs.gnu.org>; Thu, 25 Jan 2018 06:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bMy1J1JSGXClmpq1Np4ZJBGBed53uP8H+zJ6rVjl5A0=; b=jdCZjGUfS9PAxL95gQd+XMZbNnV5TB7R4QwMreFOkY3reGwu2JHo0vSXz24mhVd9F9 5UU7FbtzpWhJqqa0iIbbVgvbJ8QrqkxP9b+Zxy4wUDF1WmH6L/Vs9wbrpMR+YWDLjIw/ pIJ1j3bjFVbNaQAr4ndhhwvpMKSDOHX45fcPE1Rvz7dLtlbBi3p+K/8uEI0TVm/Fyz/2 q0GP4lviMHVXKIwOK3zlSl9nkjvxUyC4WmyV2wn1qrJHYuVKqU4m83WYZTtmbPFNKC1U URJHRzpnT7dM4nzSEPqs51uD4NMmYy0/3CnP7mUEe0rtMGRgdRU4kirscExjMpbhY/6h HJlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=bMy1J1JSGXClmpq1Np4ZJBGBed53uP8H+zJ6rVjl5A0=; b=RuDci6cZGYNtBWmUFjn3IgzKafa9vAk+cZwPb/FUWmv13WVcGjRYqT/jVKnIOYCcXe VjdZfYoy5gfpXvjVrJK2JHzoTSuhbxjx6SGZHzGuMwHfuxNgLCg7RyH4aC6/XPr5Y2LW 9ZANFIZhGoCfyUufaipB5wtA0DU0XBSyem/afTfoh5kxyykr1Xmw1EpR1wIhOzUgFKj/ x437Y6ZbhL7WxAIlozOuS0MsFqrCjfC2E0xZE/WDVvrqDzwQpioIuWl/Y2rpxNBgsarQ LbZcTHsiCoTdy0Fe5BuCq32wL2VJ9Zztos6Ao40zyoUPkwK6JMW8kjylc9IbAHrG03pE Dm7A== X-Gm-Message-State: AKwxytcN2rWliOiUD8pmIy5DPnMj0Z0uDUJyyzs8PvnhPJALX3X42gNk Ep+WUJePzxPaipWIFI6S1Do= X-Google-Smtp-Source: AH8x2270CU5Qvfe/YpVdXNNVz1EDRXe+6Xss1AluE6QXD0MkOHqg4B8MrxGDWR0/OT3QdkV5RULEsQ== X-Received: by 10.107.142.147 with SMTP id q141mr12141539iod.15.1516889252496; Thu, 25 Jan 2018 06:07:32 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id f139sm1947149iof.35.2018.01.25.06.07.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 06:07:31 -0800 (PST) From: Noam Postavsky To: Michael Albinus Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> Date: Thu, 25 Jan 2018 09:07:29 -0500 In-Reply-To: <874lnafeun.fsf@gmx.de> (Michael Albinus's message of "Thu, 25 Jan 2018 10:49:04 +0100") Message-ID: <87mv12m3q6.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Michael Albinus writes: >> `file-notify-rm-watch' and `file-notify-valid-p' are still broken, I >> can't immediately see how to fix them and it's getting past my bedtime. > > Maybe I could be of some help? Pls commit your changes you have worked > on, and tell me which missing part I shall try to follow. I pushed my patch to the scratch/nonspecial-handlers branch. If you run make -C test files-tests SELECTOR='\"non-special\"' you will see the relevant tests, files-file-name-non-special-notify-handlers being the one which currently fails. Maybe it's just a matter of binding file-name-handler-alist to nil again for those operations, not sure. PS we should probably update test/Makefile.in to require less escaping for SELECTOR. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 11:36:44 2018 Received: (at 30243) by debbugs.gnu.org; 25 Jan 2018 16:36:44 +0000 Received: from localhost ([127.0.0.1]:42750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eekW3-0003rH-Pf for submit@debbugs.gnu.org; Thu, 25 Jan 2018 11:36:44 -0500 Received: from mout.gmx.net ([212.227.15.18]:59044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eekW1-0003r1-MD for 30243@debbugs.gnu.org; Thu, 25 Jan 2018 11:36:42 -0500 Received: from detlef.gmx.de ([79.140.117.159]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LngNT-1fH7w40xB9-00hriQ; Thu, 25 Jan 2018 17:36:27 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> Date: Thu, 25 Jan 2018 17:36:26 +0100 In-Reply-To: <87mv12m3q6.fsf@users.sourceforge.net> (Noam Postavsky's message of "Thu, 25 Jan 2018 09:07:29 -0500") Message-ID: <877es528vp.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:g2oAZon24PMNZn8J0BdGh4ZwfjOZ7JopWiWFhkBC83cU48VmzOy o29hJqoas97zQmyQ8I8/GHAcx9OrR7wQZ+VerMJtvxObwXw68c6tYM/orJjJyfIZ2qaVYuK cy7KTRoeCFI/ojBDTXicBnY++WhIIEdxcpDC6Wi0FG1KKrHFvNr2VFV+mc/+ZzQh8tc6WV9 RinN2qPd40OptAHHd96pA== X-UI-Out-Filterresults: notjunk:1;V01:K0:JlEmrtfw4Ts=:/g+b02i3EDJ+fbjnmokEly gi2paXMRHl9fxzo8tZyxuKtwheQudxM5P3H/uFhu5VtjqF32Xeee9s6Sk96pVexzF0VJOmLAX buNJxpTzhckH9HkTvl/5+pycUWpxDANXfyHxH26Gmzg9GaOn9G5heKus2/FqOwM4Pbp7Khx3A iMzzh0w7y1Rp11R12H+kKfERVY5KHoLrKpQU0OOsGzc8EQw7EJqOzAMJCVWKvFI47ebQ564WW OL4r8Kamg9V7wTCaORw1/Rw7/1EiYK5BrBNMeXDe9j/XusIc7WtgDYQYbCgYzihlvA1tPgnu8 IAa0uEpwAqw3q6PIbVLYiWjfCdrRK5qVQhnuHpAAOgrMNuoawKXC/3vAViH9FmCkra0fvuavT Si2TpSE/6JSbgKMcDhtK08JoeuLb+143qBJ/b5wTerSYTyy2/2pCdG31wedACNCdt4aiGfLmd TnjOxhzYrYyaLr7U1SiuOKeyAfn8YKmD/AoSbQqNMBfFJKjZY2vG2wKDBOoJBGOu9DFAAniqy +3gVMzZ718n17cEKrUFT1wUtapMWM1njcAehTLWwXURwmaKZ6EB1oR2+RHd4IOZ/KM+CTuSAQ F/Sh1d+jNXUEGG5AaTWs0m7DsMuxAodLwmdZNxDwfz3iQaEwxr8hjCRumXMuXUVYNIe0OdWhM KPKMfH1AUbosKqBDne7Y4c+4+8pdw4PrHlFFGlMbTsE/L0EEKQQml99FOPQTNtXfTbM/q3Bev QXfPs29dkFccASQY8uo2CzGNdWUFtKWaY59Dukbh/vYQG9+PPBfQzQkhZUxAiD7IOJ95/sYn9 maugiwcFvsZ9cz14Dfa3FLDLeNXn29O/w6x2JSOuOmINCu0u30= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: Hi Noam, > I pushed my patch to the scratch/nonspecial-handlers branch. If you run > > make -C test files-tests SELECTOR='\"non-special\"' > > you will see the relevant tests, Thanks. > files-file-name-non-special-notify-handlers being the one which > currently fails. Maybe it's just a matter of binding > file-name-handler-alist to nil again for those operations, not sure. I tried to debug this interactively. First, I had to give the debug property to files-tests--with-temp-file and files-tests--with-temp-dir, in order to be able to debug interactively. I've tried to instrument file-notify-valid-p for debugging, but I've got the error Invalid read syntax: "Expected lambda expression" Strange. No idea what's up, could it be due to the when-let* macro? Anyway, I've instrumented files-file-name-non-special-notify-handlers. When running the test, it returns file-notify-add-watch as expected, but when entering file-notify-valid-p, it returns the error Lisp nesting exceeds 'max-lisp-eval-depth' Emacs is frozen, and there is the error message in the shell Emacs is started from: emacs: malloc.c:2427: sysmalloc: Assertion `(old_top == initial_top (av) && old_size == 0) || ((unsigned long) (old_size) >= MINSIZE && prev_inuse (old_top) && ((unsigned long) old_end & (pagesize - 1)) == 0)' failed. Fatal error 6: Aborted No idea what's up. I'd say you've uncovered a bug :-) I'll try to continue tomorrow, running Emacs under gdb, but for now I have to stop (there's a life outside Emacs ...) > PS we should probably update test/Makefile.in to require less escaping > for SELECTOR. Go on. But pls remember, that SELECTOR is not a string only, it can be also a Lisp form. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 11:46:58 2018 Received: (at 30243) by debbugs.gnu.org; 25 Jan 2018 16:46:58 +0000 Received: from localhost ([127.0.0.1]:42754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eekfx-000461-QT for submit@debbugs.gnu.org; Thu, 25 Jan 2018 11:46:57 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eekfv-00045n-AL for 30243@debbugs.gnu.org; Thu, 25 Jan 2018 11:46:55 -0500 Received: by mail-wm0-f47.google.com with SMTP id r78so16153848wme.0 for <30243@debbugs.gnu.org>; Thu, 25 Jan 2018 08:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3qNf6nRj7KTKxjUDYMc+sJN8u5Yra46OHHPv4kRcle0=; b=Lw2z+0wqSGkfgJxT8dtVPEz1oA2y4D4q7NaRR9S9MkcaXug9rBzPjmp5eRcoNyqzwS BVz3YpJ8ZglaQgVNXV1Lj0pLJEJJvhIVFdlOmuxOQhshnP8cDf7xmGOY51UkcMWjbamN oqSUpdkmQ4lkdivM234LzNERiezY1lqy8Eeqcd2vfp7ReJFEN6u1apsMFESwJ10DlLpa jqehG7TQDbILhYBY5Dl2EjXd0AZMNVu6a8oMivE+hMbKc4+/q3jw9S0U407OMvn3u/m3 1IstL/rtoYBpKnKzIhuTUF1+5rKe7tKDwW2c0m5qlVGPSOhXJfYQqx8V0clowZwdK4pl mI7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3qNf6nRj7KTKxjUDYMc+sJN8u5Yra46OHHPv4kRcle0=; b=IbopsgkGdcARZhmFq4hByJhr+6luqYgbcDjihJRpL13YYT4Yu76Fz1J4/+u67JmxDF RMjBDo7o+gqoDTbYTjfskOMy7P3FMA8kF0ZnsbB2qf//0gjvQqDRyom4ocHSfmP67qok 4fSV5Q3vF9ncbLs2CSwLee7meQW5MZVRguK8WUKMxeAQSMsw6jx2zBGxCUpaNoF7dabY LqbyIm45Ud5tMGZ0Akcdfc1jvDxq4HuVMU1656mZaEoskEu3hfGE74MCpX0VJUIyuqLQ GmU78w7NKQFUFGTOTLZ10lHWI1GTOCyhRGqknftzyBQZqdOusm1oLzutdr+Ch6DE3hOu 0SYw== X-Gm-Message-State: AKwxyteEvGPPVOvKFba8Oj3AOFRd5UXYaSykXfo/t2NhECeFIVYVqrKM lwAm3Cb3BgkBhGMmDENkuU58dUC4GkiEN52ryFo= X-Google-Smtp-Source: AH8x224MabJwOGuV6k1eDFJSCO8x8vUGkIzd7tY05TrbgE93zStBYqyFimjgEW5HumOEg3ekgfSzEbV/94MObOlxmR0= X-Received: by 10.28.239.19 with SMTP id n19mr7950862wmh.20.1516898809267; Thu, 25 Jan 2018 08:46:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.182.77 with HTTP; Thu, 25 Jan 2018 08:46:48 -0800 (PST) In-Reply-To: <877es528vp.fsf@gmx.de> References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> From: Noam Postavsky Date: Thu, 25 Jan 2018 11:46:48 -0500 X-Google-Sender-Auth: SH2Lljo-K6_wsz0KQMQA9rjmKeQ Message-ID: Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On Thu, Jan 25, 2018 at 11:36 AM, Michael Albinus wrote: > Emacs is frozen, and there is the error message in the shell Emacs is > started from: > > emacs: malloc.c:2427: sysmalloc: Assertion `(old_top == initial_top (av) && old_size == 0) || ((unsigned long) (old_size) >= MINSIZE && prev_inuse (old_top) && ((unsigned long) old_end & (pagesize - 1)) == 0)' failed. > Fatal error 6: Aborted Oh, that's what I got from `file-name-all-completions' before fixing it. My guess is that it's due to stack overflow. Although it is a bit strange to get heap corruption from stack usage, maybe a bad interaction with the stack overflow recovery mechanism? I'll take a look at the edebug problems later today. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 20:46:30 2018 Received: (at 30243) by debbugs.gnu.org; 26 Jan 2018 01:46:30 +0000 Received: from localhost ([127.0.0.1]:42976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eet65-00087T-R6 for submit@debbugs.gnu.org; Thu, 25 Jan 2018 20:46:30 -0500 Received: from mail-it0-f41.google.com ([209.85.214.41]:43417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eet63-00087F-0e for 30243@debbugs.gnu.org; Thu, 25 Jan 2018 20:46:27 -0500 Received: by mail-it0-f41.google.com with SMTP id u62so274447ita.2 for <30243@debbugs.gnu.org>; Thu, 25 Jan 2018 17:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GCIv/n/rvdtih4cLZaCGTvYboSM5i7JVocoUcD7DHGU=; b=dtXVK+hQGhB9xUSPHYu6zb1XrrIl3uCyFNTwyR5fnVXzgbK8PuKzPOWWZlsYx6PlQz IVovrHT+BLzpbov0VfM/IDbK9yDPMXgjsHvVKbjOFroguQiqsoy12d/JS98O3ncuHY89 WEqEn287thzLlgKbGciDKhvQooVBGjzrxmchOQooqksVkj04VPgZWCEjxZTKjOKQpZwC BY+g6SZDMQarmzn5A6Er4apQCrAqsjkXqx546Axv8pByxZl9d/M/KlIbzxgf+BGDm1jv KOwmkfKl1gdmvtpdv94lbBS24sWyv6zkkIWQOhv2s83AntxrYu2PZN9+O4hKvTVEkVSL 54Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=GCIv/n/rvdtih4cLZaCGTvYboSM5i7JVocoUcD7DHGU=; b=OUShwR/Wg9ZkOo+fyLU5VMTIDILzqCz/wbEsddjxuqW5qpbf+Eh1Y8ud3Fhjcd6RAI YqMEih0B6oK6yBdLfOeC7SPoOIPWygKaW9PZiTj/4iz0fMGtgaWDJfBWWp6krk0dv8b6 w1qmR9jsl6vwKaJzCI0wH7Bjt0QPwkIrqdj6Gu7xlbLWctdoUIN7QIlNuocflhOZCbQ1 +FOyTTLEl23u8RtMkrQgSMsEplVbPEvomtIxGsFWHnkPVD44CPMrPvk/jsL0Fnv2Vh77 xQ+ZoNq/2oPRhbAT5gPXnYfAv7djjym0mCGxNaAKGlvSVtRk4E/F19VKBTXuybriKC74 KF0Q== X-Gm-Message-State: AKwxytcYhr+2A8HMNVzEqYzSMVOoZObHsOfV0UTvQbahc5kTYI/68OFD M5Vc2FIUD9f9cb5i6+DGJoE= X-Google-Smtp-Source: AH8x2245hbPEHckZoDEg6AbGLKZ+pVcGKCjHSXcku7krg2Xh74j2W86BlIvxBhAh2QWaBvaCHAIV3w== X-Received: by 10.36.222.66 with SMTP id d63mr180755itg.99.1516931181308; Thu, 25 Jan 2018 17:46:21 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y128sm38647itb.43.2018.01.25.17.46.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 17:46:20 -0800 (PST) From: Noam Postavsky To: Michael Albinus Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> Date: Thu, 25 Jan 2018 20:46:18 -0500 In-Reply-To: (Noam Postavsky's message of "Thu, 25 Jan 2018 11:46:48 -0500") Message-ID: <87h8r9mlxx.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Noam Postavsky writes: > On Thu, Jan 25, 2018 at 11:36 AM, Michael Albinus > wrote: > >> Emacs is frozen, and there is the error message in the shell Emacs is >> started from: >> >> emacs: malloc.c:2427: sysmalloc: Assertion `(old_top == initial_top >> (av) && old_size == 0) || ((unsigned long) (old_size) >= MINSIZE && >> prev_inuse (old_top) && ((unsigned long) old_end & (pagesize - 1)) >> == 0)' failed. >> Fatal error 6: Aborted > > Oh, that's what I got from `file-name-all-completions' before fixing > it. My guess is that it's due to stack overflow. Although it is a bit > strange to get heap corruption from stack usage, maybe a bad > interaction with the stack overflow recovery mechanism? It's not related to stack overflow recovery, it still happens with attempt-stack-overflow-recovery set to nil. The problem appears to be that we hit the limit in grow_specpdl(), and then call signal_error which does Ffuncall and then record_in_backtrace writes to specdl, this latter write is invalid since we failed to grow specdl before. Thus memory corruption, undefined behaviour, etc. #0 0x000000000063999d in record_in_backtrace (function=XIL(0xd9ea380), args=0xffef5b188, nargs=2) at ../../src/eval.c:2096 #1 0x000000000063b8c9 in Ffuncall (nargs=3, args=0xffef5b180) at ../../src/eval.c:2746 #2 0x000000000063b320 in call2 (fn=XIL(0xd9ea380), arg1=XIL(0x5250), arg2=XIL(0x1161fc03)) at ../../src/eval.c:2625 #3 0x00000000006381db in signal_or_quit (error_symbol=XIL(0x5250), data=XIL(0x1161fc03), keyboard_quit=false) at ../../src/eval.c:1565 #4 0x000000000063806d in Fsignal (error_symbol=XIL(0x5250), data=XIL(0x1161fc03)) at ../../src/eval.c:1514 #5 0x000000000057939a in xsignal (error_symbol=XIL(0x5250), data=XIL(0x1161fc03)) at ../../src/lisp.h:3861 #6 0x0000000000638704 in signal_error (s=0x75e388 "Variable binding depth exceeds max-specpdl-size", arg=XIL(0)) at ../../src/eval.c:1688 #7 0x00000000006398cd in grow_specpdl () at ../../src/eval.c:2080 (More stack frames follow...) Lisp Backtrace: "stringp" (0xfef5b398) "file-name-non-special" (0xfef5bb58) "file-newer-than-file-p" (0xfef5bf38) "apply" (0xfef5c130) "file-name-non-special" (0xfef5c6f8) "file-newer-than-file-p" (0xfef5c998) "apply" (0xfef5cb90) "file-name-non-special" (0xfef5d158) "file-newer-than-file-p" (0xfef5d3f8) "apply" (0xfef5d5f0) "file-name-non-special" (0xfef5dbb8) "file-newer-than-file-p" (0xfef5de58) "apply" (0xfef5e050) [...] > I'll take a look at the edebug problems later today. Turns out this is just Bug#10577. You can work around it by loading subr-x before instrumenting forms which use when-let*. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 26 06:01:20 2018 Received: (at 30243) by debbugs.gnu.org; 26 Jan 2018 11:01:20 +0000 Received: from localhost ([127.0.0.1]:43099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef1l2-00066M-CK for submit@debbugs.gnu.org; Fri, 26 Jan 2018 06:01:20 -0500 Received: from mout.gmx.net ([212.227.17.22]:57253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef1l0-000669-9G for 30243@debbugs.gnu.org; Fri, 26 Jan 2018 06:01:19 -0500 Received: from detlef.gmx.de ([212.86.46.41]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lx4dh-1eq0Bi0jof-016dPN; Fri, 26 Jan 2018 12:01:03 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> Date: Fri, 26 Jan 2018 12:01:02 +0100 Message-ID: <871sichok1.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:cPnh+NY8bYOU/DW3eM4VARtJNuG0ZOTTftq9CtX4BgdP34YIviO r1xpbu6d7MjW1dlpvU1D3GtXTmBf3HGZwldYG7+xSmoNT/mdWgwctd4rjelQUwzUxriJAwT bKBUJ3KMJGM6DzW0S4TdxVd1g7FPRTs4FHQluiKSXC7NClu5buApQME5CXAeS3YtPfM2cht aj2StYqHXO6o6e7tjCaug== X-UI-Out-Filterresults: notjunk:1;V01:K0:nfpa9isJ9lY=:WT8n61oFa9tqKh2G9ybP1t oSxi9g3ltEoN6oUhDhdAno4kONg51V10iBerw8JwKqcdpETJaQJ13JKpO9b9H1H84xfcWJ2Ph PHYQNEnMOyLYT4aYhRHbSgbMsgd365/7igxozsmD1q24y/EQdcq1lgwin0p5VYuv3HFKpF8mC 0AInpj260NqmNcx7S/gH0KOG9iOjfEwCvqyGM/aEr23nVmyxXLi1ULB2IVPsMmEar9dCvSs+K bmAgmzoRojYKVy1FI6PYi6PLMRSf+r3AJ0MSWcCtFT18TAeC1tNezMi8xtO2saXn0FT7ZshTM 6p4SUo9blgxugoaQIFXvkGcRmCUZLsP4Ah8RMV/+Syo2/XQ6tnDaSvwFMALQC4LGj0ihbv4PG CQU0xsYSWdIMcpzB/EHKfDQ1dP2KSl5T2w+yzSVhc/1AAYPihuBUylLIvDy5ceWnsvH2ooIyQ qsudn9Sb+lTUmmB8Fr+ByIfYvBUCq4T7En1iNhmbvV1SO/3moB8AOOod5OsnuzX7BmhUGVOAZ NkvTlhtwfv7a2pVa3C03iDv5xLw/94wWFygPGCkCx07ogql3/9oZuGQTA9QalqZ4DOKo3wXci VYSmbqmg1ifEIE6CRo+NnVmN3vho7ZZXpSMK60CSMA4hLqKsAY9CW0vFn3Y/0Jm/CiMjFOl0+ wpupPt9lvhrqCUhDjKObk4r1dlZKb6JC37vP7J+KPQCEVPxu0hyJuw7enc0aPvY6dJqmUR4Hx vviBrZl3ZD+BCNWh7WpN50hdJkL1AwGDn4OOKrUyLia8jhEoudQsUn4jHwcFPP5hii6uXwm9h W0gWQdqTrDebc+dNacBC0a4ESS+VwDn8XWe6VxVePo0MClvJaY= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Noam Postavsky writes: Hi Noam, > Lisp Backtrace: > "stringp" (0xfef5b398) > "file-name-non-special" (0xfef5bb58) > "file-newer-than-file-p" (0xfef5bf38) > "apply" (0xfef5c130) > "file-name-non-special" (0xfef5c6f8) > "file-newer-than-file-p" (0xfef5c998) > "apply" (0xfef5cb90) > "file-name-non-special" (0xfef5d158) > "file-newer-than-file-p" (0xfef5d3f8) > "apply" (0xfef5d5f0) > "file-name-non-special" (0xfef5dbb8) > "file-newer-than-file-p" (0xfef5de58) > "apply" (0xfef5e050) > [...] Thanks! I've fixed this in filenotify.el (in fact, the underlying watch descriptor should not use quoted file names). Patch pushed to the branch. In my interactive test, there was also another error: --8<---------------cut here---------------start------------->8--- F files-file-name-non-special-handlers (ert-test-failed ((should (equal (find-backup-file-name nospecial) (mapcar (lambda ... ...) (find-backup-file-name tmpfile)))) :form (equal ("/:/tmp/emacsqk0Dcl~") ("/:/tmp/emacsqk0Dcl.~1~")) :value nil :explanation (list-elt 0 (arrays-of-different-length 19 22 "/:/tmp/emacsqk0Dcl~" "/:/tmp/emacsqk0Dcl.~1~" first-mismatch-at 18)))) --8<---------------cut here---------------end--------------->8--- I guess, it is because I have set `version-control' to t in my .emacs (not investigated further). Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 26 17:11:28 2018 Received: (at 30243) by debbugs.gnu.org; 26 Jan 2018 22:11:28 +0000 Received: from localhost ([127.0.0.1]:44119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efCDY-0006Vx-DD for submit@debbugs.gnu.org; Fri, 26 Jan 2018 17:11:28 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efCDT-0006VU-BU for 30243@debbugs.gnu.org; Fri, 26 Jan 2018 17:11:24 -0500 Received: by mail-wm0-f50.google.com with SMTP id v71so23866979wmv.2 for <30243@debbugs.gnu.org>; Fri, 26 Jan 2018 14:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=pI+939pzQAnTG9PBkGxMQJODWsQGIadpjJ2Ab1Sd5KI=; b=OtyorzhGG+gwTx0ksZY1t+0XjIJdaBOJa76DCVAyED6BLp73IwITaLDy6Y2Kv8EiPX 3NCwAF4ZYmniLhAqrNVq60hAVjrYYON9Xqx/sBMcG9m0J89njGKn2DSHy6izH+REpEC1 sJb1+84S3LZQgAFRCmzzmrFzJOL3eiSK0nwZ8vnu3CQThjAEBZ8u07oTwTQACJlvSXxK 4WIXWBOLU9yPN+sBgVyJ07BhYHjxIkd8I/9kRI3NEoOvwGo3mJYEtyhm9/0+X2tSkG7K 6dCHh3qJRP/RcuwAgABRCOJ7QajIOn+d79Z3m9ksGiOfbpztRK1Oa834ob3tKBES7DVm XlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=pI+939pzQAnTG9PBkGxMQJODWsQGIadpjJ2Ab1Sd5KI=; b=Oyb3OSvtGS+aCvbB4H671rSGQeokO2YKLxmqjvx1QGP/DrjaaDFdOnb9W2x4MCkoi6 1DQqhwYCH+qWyYPs10wmbgRPuXZOMGj6dxKr8irjYOGXlUmuMFqaruT55CD8Em3mS3CW 6O1QFqqif7450rXLC5W+9SOKnlE1Co92KWOXS1+w7HfVZdUbwakKSq0NMdfzhQV83C56 NbJCS6gNgzo2ELUAXC1fnkdDw6WsO3LfGRLhKIJRgJrfadmbxE0mQoxF6PzMRja0kMsq NQls5BA5S1JnXVsTu3USSt60UaIJ0oZm8qbM/d70jESW/3Als7avUOv1mQi0tyFLsINg nMYQ== X-Gm-Message-State: AKwxyteY5VPZfm+k861J44XWsSFxGVSq2eYEB6nQaYUqnyO6dKKwzgy5 benRjkaI+/xUG7WMNSBRUlRyhfvu9Mv/5+3FfYc= X-Google-Smtp-Source: AH8x2249XDuY9M0BHlx90HR/G5mbVaMAom42g7UeeVdUBvgPoIWgPSAHgP18aIYiqlF+MmItmvvsYpmqkxTRZgR566U= X-Received: by 10.28.239.19 with SMTP id n19mr11594065wmh.20.1517004677474; Fri, 26 Jan 2018 14:11:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.182.77 with HTTP; Fri, 26 Jan 2018 14:11:17 -0800 (PST) In-Reply-To: <871sichok1.fsf@gmx.de> References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> From: Noam Postavsky Date: Fri, 26 Jan 2018 17:11:17 -0500 X-Google-Sender-Auth: zZBZQmp48bYFT6ISjYRZ4pqR8Kg Message-ID: Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On Fri, Jan 26, 2018 at 6:01 AM, Michael Albinus wrote: > Thanks! I've fixed this in filenotify.el (in fact, the underlying watch > descriptor should not use quoted file names). Patch pushed to the branch. Ah, makes sense. > (equal > ("/:/tmp/emacsqk0Dcl~") > ("/:/tmp/emacsqk0Dcl.~1~")) > I guess, it is because I have set `version-control' to t in my .emacs > (not investigated further). Hmm, couldn't reproduce here, but it looks like a bug (although not as severe as the inf loop stuff). I've tried running the tests on w32, and discovered I missed testing file-newer-than-file-p with both args quoted. There's also some apparently w32-specific trouble with dired-compress-file and insert-directory (although looking at the code, I'm not entirely sure why dired-compress-file passed on GNU/Linux). I pushed 2 more patches to fix file-newer-than-file-p and avoid the test w32 errors. I'm thinking also the massive test needs to be split up, as it's a bit unwieldy. Having one test per operation almost seems like overkill, but I think it will make it easier to check we've covered everything, so I'll probably go with that. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 28 05:28:39 2018 Received: (at 30243) by debbugs.gnu.org; 28 Jan 2018 10:28:39 +0000 Received: from localhost ([127.0.0.1]:45720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efkCV-0008J3-Lu for submit@debbugs.gnu.org; Sun, 28 Jan 2018 05:28:39 -0500 Received: from mout.gmx.net ([212.227.17.21]:58193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efkCT-0008Ik-BV for 30243@debbugs.gnu.org; Sun, 28 Jan 2018 05:28:37 -0500 Received: from detlef.gmx.de ([178.20.95.79]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LnlmV-1fGCXw2DMd-00hwdu; Sun, 28 Jan 2018 11:28:23 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> Date: Sun, 28 Jan 2018 11:28:22 +0100 In-Reply-To: (Noam Postavsky's message of "Fri, 26 Jan 2018 17:11:17 -0500") Message-ID: <87372qz395.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:VLswWDF/F8ERsxnOi5PE6T/F9fe9ApwhnzHWfeFMWmfHOHRBbqI m6Tw6o9w23J6P6lFH5XWCAT1jFfcvalRRBv1h1anwn0+ysA9EsFtDmCASmqLevUgmVZ+4kf ahHYUdFc1QTZTp9bHgUEwEVSy5AS0+7sjQhcEH6FC4vsj77Yrzo0VcOv2lwuINtObo0u4WZ IqjYqD1VHqKzEX78YTj4A== X-UI-Out-Filterresults: notjunk:1;V01:K0:HrEgdiarJfc=:aiCZQIdMSepr/afE4bQK6T QOHXe+3M4/IgVaI50R33EE5Lq7ZiIofvcHj016O4UFF0HEY0XuHpBRDLtSQxZ05NTloH0nKm4 ZOZ4gu577XdW1ruSiMI/JnpjBS8jqsFF2OXjLa6bkrn6CaZy2+18KXhcGqA/u2OG5HMVazw7u Sp07nBDiFYsobDGmY0Zn5IdZakbiz7K3inBE+QXoYNtAkCXlsYCFUjVd7qi3frYucfyqhCOLn /44GW8jLKKacVhop09owsw+zL/EzXKg9/SceZZ3LQWGBygvXa99UuBcr5RzAfcJjn0VgIrk9w n06oseKS9hUGy/TCtZU1v3GgADBi5r+OoB2FrgWkGDcnSZElvMslQqVkDpmHO+OnjtNDqSFjB Jq6BV4iIw57PTMVLeMNrzGDqZzndGV7HOTQelFx8MqXlObRz7u0BA/dpwuqm6rKgEuaN6GCH4 WLhpPt31J3arRGgcfyQAOrP3zQ4Zjs3+6PZJVzgpCca0qFvmUXxqDhMDoF1/RJ5YQT6meE1bz LkQSbG5+AU0zMHMLqLBH6TkWmGl0Vj5hqgQPt9/vqS+ND2uRzjHqb63aY3IhxnWSHvb+BBqDu j6GEcdLHaaQ0qTXd87ZXXhbTbaUA0ldGIa3jEvl+6yh6HP3WCoaqaDbEcNT4Fxh7hQePtRfMI jSdJnUIXdEWDErkm5KQHke0CJJzGbUAw0Og1wXNEJcadBsfXJ0YxSoNSrfKqGcRrMXoXDz9iv jgHPo9qNTYuisBxL1nwuuzvCtbPgnfec7kAl7w9vivpruUwDqskGmCPBJ6AmiSMDiOZyvqTab 30+HrMuCQg3oe/IbytljmqI1RqpBXszy2GdK+fyaiAgZi9/T94= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: Hi Noam, >> (equal >> ("/:/tmp/emacsqk0Dcl~") >> ("/:/tmp/emacsqk0Dcl.~1~")) > >> I guess, it is because I have set `version-control' to t in my .emacs >> (not investigated further). > > Hmm, couldn't reproduce here, but it looks like a bug (although not as > severe as the inf loop stuff). Well, if I start emacs -Q, the error does not appear. Hmm, maybe I will track it later. > I'm thinking also the massive test needs to be split up, as it's a bit > unwieldy. Having one test per operation almost seems like overkill, > but I think it will make it easier to check we've covered everything, > so I'll probably go with that. Yes, would be better. There shall also be cleanup; I've added a missing delete-file which was missing. The branch scratch/nonspecial-handlers is based on Emacs 26.0.91, do you plan to merge it there? I feel a little bit uncomfortable with this, because my fix in file-notify-add-watch didn't get heavy testing. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 28 09:58:31 2018 Received: (at 30243) by debbugs.gnu.org; 28 Jan 2018 14:58:31 +0000 Received: from localhost ([127.0.0.1]:46381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efoPf-00005z-Cr for submit@debbugs.gnu.org; Sun, 28 Jan 2018 09:58:31 -0500 Received: from mail-it0-f43.google.com ([209.85.214.43]:39627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efoPd-00005d-21 for 30243@debbugs.gnu.org; Sun, 28 Jan 2018 09:58:29 -0500 Received: by mail-it0-f43.google.com with SMTP id 68so6511752ite.4 for <30243@debbugs.gnu.org>; Sun, 28 Jan 2018 06:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+9dcQ9CdYk3pIgQdHyWYaTMb8bPSVNkPKf/19335/e4=; b=SYDIIWhEGG/XZEc7tenr+a6LquC5v8Vj45DXUYHA9j1/PoiIpp8D6iQbt/yUHYckFz FMPYnnKgVdeScQGSF1PF/KBhZum+ATlHd3oyxYXsLksjMBZp/gSFSO0n0LHJoluUgRq/ GRT18b22psU2mvfYRhM65F04Bl2BRhN+jjFwXZRxvUQoLuInj4qDBZ2OPYXDdUkgbZxn gQzToXbvVEnpWei3sBGgdeTHJCh+X27S3Yb1B8k5gtJl1b4ihC92F+7e6hDFtCjIjxRl Ja1ogtNnilB+L5dnXP7X8Qr4XBjGVTT/VCdLBC16K5czVKmgBoFi38rtnPl/2Y+a90BW F4uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+9dcQ9CdYk3pIgQdHyWYaTMb8bPSVNkPKf/19335/e4=; b=dzlTLfhCiQys3dqbTHNUX6nHdEqAVmFtWgsYfTUDNwbEKb6CrpGV1C76IscN/S6QlF UxYiASLL/IqxYoL9am4kD8rZntaQ43azZ+wjJNQNJ6VDNpDedOncsf9GM+xlaqx+EIzm BPygTQnvYm64SJk8UGZNm9heXHbeh2ipHqPSQwi3HRN/raVA+0Rr/MvMLX/6nUpxNKK9 4GtFKJQ9yCbWLsKy+0wHCitNmHgXumKM8i79rpcq3Mfb7eK94gYOVpUf7xCDzbRDN+Cm 7L9Ihfes5wghEPhSHiMImq4aYdBqcBqcHwxp1+dlufUXmAQYwAZKZvnGegbnK05MZOsw VBSA== X-Gm-Message-State: AKwxyteOByfLlsZLXFYBCmcmXIYM+5T7Y3lRNG5c/cUvBXItDl7iB7Gl rIlgZf0agCKDCP81Ny80FsA= X-Google-Smtp-Source: AH8x224eSE4QPuoioylhllUzhCYRWl3jGjBwQPHE5mFEAvuG3Gw7NFooLjjl9ZQMMR9gdwJFRQhhNw== X-Received: by 10.36.130.198 with SMTP id t189mr21603458itd.45.1517151503160; Sun, 28 Jan 2018 06:58:23 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id s70sm6204773itb.0.2018.01.28.06.58.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jan 2018 06:58:22 -0800 (PST) From: Noam Postavsky To: Michael Albinus Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> Date: Sun, 28 Jan 2018 09:58:21 -0500 In-Reply-To: <87372qz395.fsf@gmx.de> (Michael Albinus's message of "Sun, 28 Jan 2018 11:28:22 +0100") Message-ID: <87shaqkp2q.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Michael Albinus writes: >> I'm thinking also the massive test needs to be split up, as it's a bit >> unwieldy. Having one test per operation almost seems like overkill, >> but I think it will make it easier to check we've covered everything, >> so I'll probably go with that. > > Yes, would be better. There shall also be cleanup; I've added a missing > delete-file which was missing. Right, should all be done now. > The branch scratch/nonspecial-handlers is based on Emacs 26.0.91, do you > plan to merge it there? Yeah, I agree with Phillip that breaking "/:" files for the release would be quite a severe regression. > I feel a little bit uncomfortable with this, because my fix in > file-notify-add-watch didn't get heavy testing. However, if you think the file-notify fix might possibly affect other things, I think leaving that part out for 26.1 would be acceptable. Now that the code is ready, perhaps Eli has something to say on where it should go? From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 28 14:17:35 2018 Received: (at 30243) by debbugs.gnu.org; 28 Jan 2018 19:17:35 +0000 Received: from localhost ([127.0.0.1]:46558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efsSN-00081Q-0Y for submit@debbugs.gnu.org; Sun, 28 Jan 2018 14:17:35 -0500 Received: from mout.gmx.net ([212.227.15.15]:49295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efsSK-00081C-VA for 30243@debbugs.gnu.org; Sun, 28 Jan 2018 14:17:33 -0500 Received: from detlef.gmx.de ([178.20.95.79]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MEXHd-1eZXiJ2nlZ-00Fn1R; Sun, 28 Jan 2018 20:17:19 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> Date: Sun, 28 Jan 2018 20:17:16 +0100 In-Reply-To: <87shaqkp2q.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sun, 28 Jan 2018 09:58:21 -0500") Message-ID: <87k1w1iyir.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:6o0iJSxL8z8Oln9+z+Sk9lX+usNsToTu1DD4hBvo3KsxkpNwyLa BxzB7CxbYw6tGy+OB1+hSA3S6xDxlSbrOA9RGQI2xCFo2WsFO4OgrtOyo82dBaOzobKpbrw F4mIcIL/F+3R6sBmmBScy9pNaUkHcHFM5ACt/wTYcFqTkktQLLhs8yURvVbch+vKBk9hJs9 fDBi7NJPXN+bBSBB9BsFA== X-UI-Out-Filterresults: notjunk:1;V01:K0:6oFyszaWL0c=:yDcrKoI1S7ePPco1O4gNKh PaZaCIZBXlEe+Ak+70vTcddsHNotQGQ0ffmLcN2rdLVYQjZTu6KLoUisqzoYYqdWa+cHMbBHg cGEFJ+2j1oSv9lq8rrjt6dEfhy5oKtgrsCi3GJA2W+wBUSriVbzfI+mJOYsSUSfl2G4o2CgNH L3hBypBbVKW9V7J7LiIo3cp6NDHx/kPd4PClevPSylMRv1j2hDLxvGHpQ1sOdoB6rgDOIiQD/ z41P1JrldPvftc/7OOA9dV6pB8mLj6XUxGvGZC/Q3ZSTY8uQjuOxGEdQqrccTBWLZfZwuWKO4 Zwcvo4GFJCBS/CgPGbylgt/RbTUsqvOxEwJ9t92N+XZoSp1Frgvm95Cm0LyHbVtLmszhfBYD2 1yMEOmjBegwgQkFyEoRUoLiIdKwkIEpF510zEPhmheFL7TWQTWvBHYNrTzyyMxBTfjm3n51oA CxCRwhmi8lZJD3IBWOgIh9ZWT1r5byM5yO53n6TRQoPUiW1YukGETY2Ypct8fghfvL6X3ZTe/ RI31lpuKLwYlfw34tOke4FDQCHe0ZQQM7dO/4AFNad8LIKNbO+YbPbyR+t3XXCS3xcqUUeWJ/ pA7pn6v57056gOjNHR1Hp2CWOjzRRFNe/VDveJARZus5oGOy0aVTrTtVGtJ/GLuNK62FV6I2E 2kay8OFk8bCvDiQeH6voKmeQh3crBR5/OYUo2+nRs08H7xlVW5MDGzGkzTVSA2t1thNQvcoXo ypqZj+tNCAP3/Pz01OGDfbTRdsgfH16NZ6eCKOf6eygPfNpmaBRLZwarQ/0altpG9BFeZhvUG 8O0gBd5F2ZweQuSpWWQT3zEEFNv23oV4ID16HRKDB02C3QZljk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: >> Yes, would be better. There shall also be cleanup; I've added a missing >> delete-file which was missing. > > Right, should all be done now. I've pushed another fix, which uses file-name-quote{,d-p} instead of messing with "/:". This is cleaner, and shall also be an example for people who care about quoted file names. Futhermore, I've added a small test, which demonstrates how to use these functions. >> I feel a little bit uncomfortable with this, because my fix in >> file-notify-add-watch didn't get heavy testing. > > However, if you think the file-notify fix might possibly affect other > things, I think leaving that part out for 26.1 would be acceptable. LGTM. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 08:46:23 2018 Received: (at 30243) by debbugs.gnu.org; 30 Jan 2018 13:46:24 +0000 Received: from localhost ([127.0.0.1]:48672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWEx-00017g-Fz for submit@debbugs.gnu.org; Tue, 30 Jan 2018 08:46:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWEt-00017R-B8 for 30243@debbugs.gnu.org; Tue, 30 Jan 2018 08:46:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egWEk-0003rU-Bb for 30243@debbugs.gnu.org; Tue, 30 Jan 2018 08:46:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egWEd-0003pO-Pl; Tue, 30 Jan 2018 08:46:03 -0500 Received: from [176.228.60.248] (port=2901 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1egWEd-0003rX-BQ; Tue, 30 Jan 2018 08:46:03 -0500 Date: Tue, 30 Jan 2018 15:46:13 +0200 Message-Id: <83mv0vh32y.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87shaqkp2q.fsf@users.sourceforge.net> (message from Noam Postavsky on Sun, 28 Jan 2018 09:58:21 -0500) Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, p.stephani2@gmail.com, michael.albinus@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Sun, 28 Jan 2018 09:58:21 -0500 > Cc: 30243@debbugs.gnu.org, Philipp Stephani > > > The branch scratch/nonspecial-handlers is based on Emacs 26.0.91, do you > > plan to merge it there? > > Yeah, I agree with Phillip that breaking "/:" files for the release > would be quite a severe regression. > > > I feel a little bit uncomfortable with this, because my fix in > > file-notify-add-watch didn't get heavy testing. > > However, if you think the file-notify fix might possibly affect other > things, I think leaving that part out for 26.1 would be acceptable. > > Now that the code is ready, perhaps Eli has something to say on where it > should go? I think to make up my mind I'd need a few words about each part of the changes (with the exception of the test suite changes): why is each of them needed, and what does it do to fix which part of the original problem. I also wonder how come we've succeeded to break quoted file names so fundamentally -- what change did that, and why did we make it on the release branch? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 11:02:22 2018 Received: (at 30243) by debbugs.gnu.org; 30 Jan 2018 16:02:22 +0000 Received: from localhost ([127.0.0.1]:49734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egYMY-0004X4-7X for submit@debbugs.gnu.org; Tue, 30 Jan 2018 11:02:22 -0500 Received: from mout.gmx.net ([212.227.17.20]:49743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egYMW-0004Wq-CP for 30243@debbugs.gnu.org; Tue, 30 Jan 2018 11:02:20 -0500 Received: from detlef.gmx.de ([213.220.148.66]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MGip3-1eTeB62GOn-00DXgp; Tue, 30 Jan 2018 17:02:01 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> Date: Tue, 30 Jan 2018 17:02:00 +0100 In-Reply-To: <83mv0vh32y.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Jan 2018 15:46:13 +0200") Message-ID: <87bmhb9vyf.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:9KQt5TaCogE7OWpC9/NZpG8PWX9GaEBxNHzP7lscSGOjKpnxRj3 5Pj7hMc0W4RKESms4jUt6S91UPZoxDQ8Am8Xtsc6hr6i6/J4+gEFVQgd5+QtZvEwE9zt0uf B3BKnLDHZR83uU3Z1JuhQgblax8E/Z6Ec8PdUSczcXXBqATQVacZ0typlqhE5Pa/caIgd91 BUKaqjC792CelxvPFwHeQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:hbJ4Aj0y3h8=:308OTfgHGqAeGydEVsQMKI QgEbu0MyhwZvzHFJIXdrYb82zt47yqmpiGsx7E07Kvda8H3y5xYWYv96hfPBOK6JyscFiIo0u 7VGGul0Jr8ZxIiFKzjB/onN7BcMqAueAbzWkPrE8RiIRoQEOJERuWwtHaSHl/vNpkztzX9kNE fDD2dULUip7UAWyE9WMijwhandkmNjxXKbS62ZEisTo8N0cYybo9yNCQvmDGjXaXoa/5oWO0G 8AI56Zueck99oAu/yQByZJ+YNJ1cVjDT9DX5neJTdruUeUsTgfGCJEPd6saHjW6KjvIaQQ2OM 2AKjwghRkCFZN1JMFVWSVFLX0u5l57kg4pOZp2xlHpThEbW8kD3mnwWe+unEhqDoFgz0wHuD+ pbAjfrSWgtT4K0/G6qNbgnM4O0AwWA1ny909C4P2hB+KnA2qSJUfsnlbpNdNDz9IXyuZKxtaE t3OMmy6/rNVOxN7LakJPvspXK98RvHVV8hJ0CFVyrKSMaBa/8KFP2oNS78RuROyMeJc3NuxEe ME12nzyflAqeIrJFXTJCYAUz7lvugHrdB/9NVqc2yxEhJom7siRS8S+D0RJ08ymZZZFMVNkdl AUMKjLZNVrrN4aJ8VVBsPcv8vXodpnflvDOBZpc3m0mg7MCHswFqQ5UxYkb5fISF6pntajcIZ jyfMA7ZHY+7ZSRpWh1V/uAWGbk956ELA2v/z3/OoLlplFa5J7EIpKgS3YjYRu+kD9igQh4Kr5 sx9ciGiUgA3i1AbizONU4NBRN2oJCJZBCOPon4XIKIvipeFcLXvMXsoc4sTgZ5+UZkEQpzkds Pv3bzYGwYl0XkzS+4itgf0BYxyfYQRsn5NiQhnmZ/qmW3LeLlM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, p.stephani2@gmail.com, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: Hi Eli, > I think to make up my mind I'd need a few words about each part of the > changes (with the exception of the test suite changes): why is each of > them needed, and what does it do to fix which part of the original > problem. The change in `file-notify-valid-p' is not related to the original problem; it was uncovered by the extensive tests Noam has written. I have already proposed, not to push *this* change into the emacs-26 branch. It shall go to the master. > Thanks. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 14:22:54 2018 Received: (at 30243) by debbugs.gnu.org; 30 Jan 2018 19:22:54 +0000 Received: from localhost ([127.0.0.1]:49826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egbUa-0003Pl-Qe for submit@debbugs.gnu.org; Tue, 30 Jan 2018 14:22:54 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:40926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egbUZ-0003PY-CU for 30243@debbugs.gnu.org; Tue, 30 Jan 2018 14:22:51 -0500 Received: by mail-lf0-f54.google.com with SMTP id h92so17035463lfi.7 for <30243@debbugs.gnu.org>; Tue, 30 Jan 2018 11:22:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cnkmcXfUbhSsm3Ioxa5WDYQ0MptaJMOE6ZKEDZgZMjc=; b=idD8DpD6An7w40grlVjqR9oAGQ7bDkk4NKeJDhWKJAtLUdImlAsqy/iDqPCb/6eMLK bgW+yMflSCaSHacZ9E21EMsQqStn7CHSi32lvNJGYMp1JJQYrBpgA9r5Q6h8MqSVWyyy AOpIdGRQ2a7mcQZvkkgb2EgzHmauDhvR/GS6IloA+2WVKvQMyk1/zNtvGQXOSG9j7nVQ /Q/qP4e3rbJebwL7io9ds4w30ILwpqAl4Q4cK/gw/6PSBnhwDyR74u9TWkSM6jXtnzMX xnAfxg2+FVXpRkyuXFfu3GBd78oPIAn7graiAYLsqcNTZwWDP+u/8ZNQD/r7mlPwCixP xocQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cnkmcXfUbhSsm3Ioxa5WDYQ0MptaJMOE6ZKEDZgZMjc=; b=mDNfLt2jCWIfjUiDagpK8416Zgxmoqxl0la87uKrXTqfUjqXLcgi4VcA8qOKUI2gmr MxdUrzgDdQYpMiAF2XBr0/2dhu/DDaJb4rzozBzaQtP5MhuQLmyLNxYWUTSaM5VUluup UMRazyhLhyJDXeLkII8PiVCQI8I9n+JMUc+PnRNMO2GkSOWOtWhCQ5jT92XdvWeqNv+r AVx483Ve+QHa8uNbBB2ZG/TPUS8dx2ERpJMNoxcX16aBuMKONlySYKwafpJgVKv1lzlr 4Ur7wOCIe7mLV/TWil6XXD5bjIvvRnLbyklrdUAK9jBhvNHM+UDzFVbLaoR6kA9wC8Qc zuEA== X-Gm-Message-State: AKwxytfSYXlsslJQkSWOWYJi+vJtvRtwEkk4NOey1wz3MrtEzOQpLd7I 2+mf9okGwYh9gDlGHpsXb0/9Bp3l66qVvM/l+BM= X-Google-Smtp-Source: AH8x225Wwg5rLzRuPDoo6MNVY0CnzZf3u49IuKJulcXkjkDgGVQaBSgqrCxiaZfwcDeCAetabUaeFQ+QlpE2GT4RNos= X-Received: by 10.46.118.18 with SMTP id r18mr16276387ljc.11.1517340165255; Tue, 30 Jan 2018 11:22:45 -0800 (PST) MIME-Version: 1.0 References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> In-Reply-To: <83mv0vh32y.fsf@gnu.org> From: Philipp Stephani Date: Tue, 30 Jan 2018 19:22:34 +0000 Message-ID: Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames To: Eli Zaretskii Content-Type: multipart/alternative; boundary="f4f5e80762f08db6930564034910" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, michael.albinus@gmx.de, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --f4f5e80762f08db6930564034910 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Di., 30. Jan. 2018 um 14:46 Uhr: > > From: Noam Postavsky > > Date: Sun, 28 Jan 2018 09:58:21 -0500 > > Cc: 30243@debbugs.gnu.org, Philipp Stephani > > > > > The branch scratch/nonspecial-handlers is based on Emacs 26.0.91, do > you > > > plan to merge it there? > > > > Yeah, I agree with Phillip that breaking "/:" files for the release > > would be quite a severe regression. > > > > > I feel a little bit uncomfortable with this, because my fix in > > > file-notify-add-watch didn't get heavy testing. > > > > However, if you think the file-notify fix might possibly affect other > > things, I think leaving that part out for 26.1 would be acceptable. > > > > Now that the code is ready, perhaps Eli has something to say on where it > > should go? > > I think to make up my mind I'd need a few words about each part of the > changes (with the exception of the test suite changes): why is each of > them needed, and what does it do to fix which part of the original > problem. > > I also wonder how come we've succeeded to break quoted file names so > fundamentally -- what change did that, and why did we make it on the > release branch? > > If my git bisect is correct, it was commit a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix Bug#29579. So by fixing one bug we introduced another one :( --f4f5e80762f08db6930564034910 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Di., 30. Jan. 2018 um 14:46=C2=A0Uhr:
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sun, 28 Jan 2018 09:58:21 -0500
> Cc: 30243@d= ebbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
>
> > The branch scratch/nonspecial-handlers is based on Emacs 26.0.91,= do you
> > plan to merge it there?
>
> Yeah, I agree with Phillip that breaking "/:" files for the = release
> would be quite a severe regression.
>
> > I feel a little bit uncomfortable with this, because my fix in > > file-notify-add-watch didn't get heavy testing.
>
> However, if you think the file-notify fix might possibly affect other<= br> > things, I think leaving that part out for 26.1 would be acceptable. >
> Now that the code is ready, perhaps Eli has something to say on where = it
> should go?

I think to make up my mind I'd need a few words about each part of the<= br> changes (with the exception of the test suite changes): why is each of
them needed, and what does it do to fix which part of the original
problem.

I also wonder how come we've succeeded to break quoted file names so fundamentally -- what change did that, and why did we make it on the
release branch?


If my git bisect is correct, it was co= mmit=C2=A0a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix=C2=A0Bug#29579. S= o by fixing one bug we introduced another one :(
--f4f5e80762f08db6930564034910-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 19:02:03 2018 Received: (at 30243) by debbugs.gnu.org; 31 Jan 2018 00:02:03 +0000 Received: from localhost ([127.0.0.1]:49982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egfqk-0001Px-R7 for submit@debbugs.gnu.org; Tue, 30 Jan 2018 19:02:03 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:43768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egfqj-0001PU-Jc for 30243@debbugs.gnu.org; Tue, 30 Jan 2018 19:02:02 -0500 Received: by mail-io0-f172.google.com with SMTP id 72so13400996iom.10 for <30243@debbugs.gnu.org>; Tue, 30 Jan 2018 16:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=m27RNY9/rrhbVvk3RkzZFPYHvrXpX3s3ovsIVnDROLo=; b=Kyl86FnDsbSB1ZwrDTvDnsiA4H+yT7ndEC7kpaEcdAxdYkCVpYq+Iv9kkTUyVrxLk3 4lm1n0uGx1qPnh5+E4AtMfdejGTMWRHnvbpXZ2FlJ4E6ec9q5Ce57FL6yJ6LlIPXx87C nAYvQpHsv61sgPaxUOpNxW+O504e49tvm8eoro8CmR1+NRYoDoEZVMc4bwIYg+Tqt6kH FtWjqXp2wnDvAzEK1OUZS/EdVMlQZBEnQNkW14z90mgAxwtwL9gLD3poB2rx3sSJhM6a 9NyZoxTEnP0NT1z7k3Xpq65bdyvjLhwV2TmDpp/4VB75UCf9J8XVXQHd5lv/+m6p7+xt dYcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=m27RNY9/rrhbVvk3RkzZFPYHvrXpX3s3ovsIVnDROLo=; b=lsdMYGpotn1Ip2LScZlcxFn0BdBZToFv1NDwZLkaUj2y04SaxxwCwSKgqMx4w9PBe7 747uKWqIL3OsHFnsM52mNY4iAwMd53XOTDntbDPgC3Tzmh+avy0TYBJyGliaOeb9BNfg +N+3BCRkVgh5AyAKO4pzSWXKHZQKBy8eQ0+Vf8X/kV/0GWXSq1NWAe8AELj1hsIB+7sv HljAXSvUYYmlnwm6vIEtKuvCQWtal+aTBfZhpvYzzwfcYupqI/NFb4+3lzoCtR+lT27z Jk2g0o9tSRobTbWDvlDJI5LGL3z9kTFAjxYThqCiv/Rp5/Ulg2egjnPqGZe5kakszWen GrkA== X-Gm-Message-State: AKwxytcePQh012RyRPf5+MPqx2N1eHYaq0qDsPxiSd6fQ6znJt6a7wVz oaHSODnCGLDZQa4hhhs0xB4= X-Google-Smtp-Source: AH8x225GaJXfwqx7EJJ5X8FAijvVwHDCv/nPVZKrts7JWHwrhlijVMX4f26LGvLzlSoYzjInw7HHHg== X-Received: by 10.107.175.103 with SMTP id y100mr19420663ioe.45.1517356915804; Tue, 30 Jan 2018 16:01:55 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 97sm6540465ioh.31.2018.01.30.16.01.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jan 2018 16:01:54 -0800 (PST) From: Noam Postavsky To: Philipp Stephani Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> Date: Tue, 30 Jan 2018 19:01:52 -0500 In-Reply-To: (Philipp Stephani's message of "Tue, 30 Jan 2018 19:22:34 +0000") Message-ID: <87inbij3pr.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Eli Zaretskii , michael.albinus@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Philipp Stephani writes: > If my git bisect is correct, it was > commit=C2=A0a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix=C2=A0Bug#2957= 9. So > by fixing one bug we introduced another one :( Actually, looking at Bug#29579 again, it doesn't seem *that* bad, and as far as I can tell, it has existed for a long time (still occurs back in 24.3). So reverting that fix seems like a reasonable option too. I can confirm that doing so fixes this bug. > Eli Zaretskii schrieb am Di., 30. Jan. 2018 um > 14:46=C2=A0Uhr: >=20=20=20=20 > I think to make up my mind I'd need a few words about each part of > the changes (with the exception of the test suite changes): why is > each of them needed, and what does it do to fix which part of the > original problem. The file-name-non-special function handles all file-handler operations for "/:" quoted files. It has an alist inside, to decide which arguments are filenames and so require the "/:" to be removed before calling the real operation. The alist was not complete, so for many operations the "/:" would only be stripped from the first argument (that's a fallback for operations not listed in the alist). Up until the fix for Bug#29579 this didn't matter so much, because file-name-non-special would bind file-name-handler-alist to nil, thus preventing any further filenames from being passed to the handler anyway. So multi-filename-arg handlers were broken, but unobtrusively so. With the fix for Bug#29579, such handlers got stuck in infinite recursion, as they kept getting called, not stripping the "/:" prefix, thus getting called again, etc... The proposed patch just fixes up this alist to finally list all the arguments for all the handlers correctly: @@ -7000,7 +7000,7 @@ file-name-non-special ;; Bug#25949. (if (memq operation '(insert-directory process-file start-file-process - shell-command)) + shell-command temporary-file-direc= tory)) (directory-file-name (expand-file-name (unhandled-file-name-directory default-directory))) @@ -7024,15 +7024,23 @@ file-name-non-special ;; temporarily to unquoted filename. (verify-visited-file-modtime unquote-then-quote) ;; List the arguments which are filenames. - (file-name-completion 1) - (file-name-all-completions 1) + (file-name-completion 0 1) + (file-name-all-completions 0 1) + (file-equal-p 0 1) + (file-newer-than-file-p 0 1) (write-region 2 5) (rename-file 0 1) (copy-file 0 1) (copy-directory 0 1) (file-in-directory-p 0 1) (make-symbolic-link 0 1) - (add-name-to-file 0 1)))) + (add-name-to-file 0 1) + (make-auto-save-file-name buffer-file-name) + (set-visited-file-modtime buffer-file-name) + ;; These file-notify-* operations take a + ;; descriptor. + (file-notify-rm-watch . nil) + (file-notify-valid-p . nil)))) ;; For all other operations, treat the first argument only ;; as the file name. '(nil 0)))) @@ -7055,6 +7063,12 @@ file-name-non-special (pcase method (`identity (car arguments)) (`add (file-name-quote (apply operation arguments))) + (`buffer-file-name + (let ((buffer-file-name + (if (string-match "\\`/:" buffer-file-name) + (substring buffer-file-name (match-end 0)) + buffer-file-name))) + (apply operation arguments))) (`insert-file-contents (let ((visit (nth 1 arguments))) (unwind-protect > I also wonder how come we've succeeded to break quoted file names > so fundamentally -- what change did that, and why did we make it > on the release branch? IMO, the root cause is pretty clearly lack of adequate tests for this. There are more than 60 file-handler operations; it's crazy to expect to be able to make a correct change without an automated test that at least exercises each one. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 31 10:38:55 2018 Received: (at 30243) by debbugs.gnu.org; 31 Jan 2018 15:38:55 +0000 Received: from localhost ([127.0.0.1]:51403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eguTP-000666-6N for submit@debbugs.gnu.org; Wed, 31 Jan 2018 10:38:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eguTN-00065r-IY for 30243@debbugs.gnu.org; Wed, 31 Jan 2018 10:38:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eguTF-0005um-ME for 30243@debbugs.gnu.org; Wed, 31 Jan 2018 10:38:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eguTF-0005uc-Jd; Wed, 31 Jan 2018 10:38:45 -0500 Received: from [176.228.60.248] (port=4085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eguTE-0005ec-Tv; Wed, 31 Jan 2018 10:38:45 -0500 Date: Wed, 31 Jan 2018 17:38:58 +0200 Message-Id: <83bmhaf371.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Tue, 30 Jan 2018 19:22:34 +0000) Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, michael.albinus@gmx.de, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Tue, 30 Jan 2018 19:22:34 +0000 > Cc: Noam Postavsky , michael.albinus@gmx.de, > 30243@debbugs.gnu.org > > If my git bisect is correct, it was commit a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix Bug#29579. > So by fixing one bug we introduced another one :( Thanks. yes, this happens to us all the time. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 31 11:02:17 2018 Received: (at 30243) by debbugs.gnu.org; 31 Jan 2018 16:02:17 +0000 Received: from localhost ([127.0.0.1]:51411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eguq1-0006mL-Dg for submit@debbugs.gnu.org; Wed, 31 Jan 2018 11:02:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egupx-0006m0-8w for 30243@debbugs.gnu.org; Wed, 31 Jan 2018 11:02:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egupm-0004g0-5I for 30243@debbugs.gnu.org; Wed, 31 Jan 2018 11:02:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egupe-0004bW-OQ; Wed, 31 Jan 2018 11:01:54 -0500 Received: from [176.228.60.248] (port=4129 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1egupd-0003lo-Ki; Wed, 31 Jan 2018 11:01:54 -0500 Date: Wed, 31 Jan 2018 18:02:06 +0200 Message-Id: <83607if24h.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87inbij3pr.fsf@users.sourceforge.net> (message from Noam Postavsky on Tue, 30 Jan 2018 19:01:52 -0500) Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, p.stephani2@gmail.com, michael.albinus@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: Eli Zaretskii , 30243@debbugs.gnu.org, michael.albinus@gmx.de > Date: Tue, 30 Jan 2018 19:01:52 -0500 > > Philipp Stephani writes: > > > If my git bisect is correct, it was > > commit a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix Bug#29579. So > > by fixing one bug we introduced another one :( > > Actually, looking at Bug#29579 again, it doesn't seem *that* bad, and as > far as I can tell, it has existed for a long time (still occurs back in > 24.3). So reverting that fix seems like a reasonable option too. I can > confirm that doing so fixes this bug. I tend to agree. Michael, WDYT? > > I also wonder how come we've succeeded to break quoted file names > > so fundamentally -- what change did that, and why did we make it > > on the release branch? > > IMO, the root cause is pretty clearly lack of adequate tests for this. > There are more than 60 file-handler operations; it's crazy to expect to > be able to make a correct change without an automated test that at least > exercises each one. Right, thanks. So if Michael agrees, I think we should revert the fix for bug#29579 on the release branch, and merge the branch you two worked on onto master. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 31 13:07:38 2018 Received: (at 30243) by debbugs.gnu.org; 31 Jan 2018 18:07:38 +0000 Received: from localhost ([127.0.0.1]:51476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egwnJ-0001Xu-RK for submit@debbugs.gnu.org; Wed, 31 Jan 2018 13:07:38 -0500 Received: from mout.gmx.net ([212.227.15.19]:51378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egwnI-0001Xd-Hs for 30243@debbugs.gnu.org; Wed, 31 Jan 2018 13:07:37 -0500 Received: from detlef.gmx.de ([213.220.148.66]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LbuCq-1f8c2l0yNY-00jF7u; Wed, 31 Jan 2018 19:07:19 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> Date: Wed, 31 Jan 2018 19:07:17 +0100 In-Reply-To: <83607if24h.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 31 Jan 2018 18:02:06 +0200") Message-ID: <87zi4t297u.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:GSK6Ep/ZLM7nsFl+iroqqMcV8clpMo4znmhejQU1wuHicWsS2v9 CIvilzoVqgsE7LWfXzpw+zliVEOCbCKCOTQZA7RDd2yjNGY2EZwlzZyB3so5qnLvtW7HINT Lx9gUJItyA880tQsGESe2dSfl9kGrinPw3jWabQeGjgbRcvI96th4DQf+vZsclS3GXZQFFl TurDTh5cfzVtQmSou+HUw== X-UI-Out-Filterresults: notjunk:1;V01:K0:8xP8Oubpie0=:vf5lAV/TmmgmT2327gbCcD DUa57nc9p47XscLF5iAJ8JSwq4nCp1o4JRoea/FgvPB3SjSbjFbLJ+F4PtTLdsvAA/ijyAvQf nxqObXjYZA87AcLGIU1MIFNsQdDK30Unl2gPkG6bAEFggHy0VyAy2D7bRWJJnZA9BrRV6G/XP L3jg9nlWa3/7emXTGqBhb+l0l3rza8U2wFF1TMi7vK5OaShEoqG9XzRzhK07zJSDCtSkNHoEV UxXg/oMWJWqm3h+YSIu5C4awA/c1m7FMfQF1x9BEkqROFTuk6vRtMQq4U5NPI9XcrqSooUsip BEhu1ShzJS9/EdWZZ8/BGA4RU0oxIaO7JCwGj1pZon+7sqk+gpgmnzkPC5FnXsxMEXPlqk3QS rcguuFfWgfPDGEOGYLAxT/FWgYuKvdsyLZj5WxazbXcSdhqDhp1RAi3YzDALAYk83JErCthgs lkYCRUOuiUQ8B9TtLgL2Ug5gCh1K5Fsbw75ZG0YTYLjD8ZYe40puuS+1HGDXeIixuqUXdjT/W rOOqkumvpfgqNALTgQ7wVNhnmxIApFBzpwpaFR4OAIiBPpm54AWHi9HRZYxAONCaYR6KcE9x5 8JRCg2zftEjIfOa5izphLstzU3fys6Ctiy179RZR1+XD+q3sHsZNwNVO+dIZ3xKGYBYL/Oi9Y JAvUD/eerawPAJfzRT81vvAm+LUtrYHR4YRMLiLdAupB0XFAS9V9Lj/H+qbd6o+rte/jwDHVl lA1IQukxu7B3/468l/nJ9BeZUmVjgwzpNzbn9IKtTD8+e67kk/VLQ/GSer1DZ5BwPq5odp504 IX+J0s7dzgvFRIXwFZPlPPvYetLglGSJjfFbS9zRRCIaXn6hXI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, p.stephani2@gmail.com, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: Hi Eli, >> Actually, looking at Bug#29579 again, it doesn't seem *that* bad, and as >> far as I can tell, it has existed for a long time (still occurs back in >> 24.3). So reverting that fix seems like a reasonable option too. I can >> confirm that doing so fixes this bug. > > I tend to agree. Michael, WDYT? Noam is right. The bug exist "since ever", and it wasn't detected in the wild but when I was working on my tramp-tests. So it might be OK to revert it in the emacs-26 branch. > So if Michael agrees, I think we should revert the fix for bug#29579 > on the release branch, and merge the branch you two worked on onto > master. Agreed. I expect some broken tests in tramp-tests then (IIRC, copy-file and rename-file were affected). I will skip those tests for Emacs 26, immediately after the revert has happened. Pls ping me when it is reverted. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 31 13:16:23 2018 Received: (at 30243) by debbugs.gnu.org; 31 Jan 2018 18:16:23 +0000 Received: from localhost ([127.0.0.1]:51492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egwvm-0001rI-OO for submit@debbugs.gnu.org; Wed, 31 Jan 2018 13:16:22 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egwvi-0001qv-ET for 30243@debbugs.gnu.org; Wed, 31 Jan 2018 13:16:20 -0500 Received: by mail-wm0-f49.google.com with SMTP id v71so844838wmv.2 for <30243@debbugs.gnu.org>; Wed, 31 Jan 2018 10:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=WNh+x+OWHSnEdtKcxCOWpDuyA/8qEaPk9rbanJULEvs=; b=MZlKYmd2/VTXNpe8XQdKQdubXYiLg9JuazxkFAgpGl9AzkxNaGrFjperYw4seOiLRP EdKXfIKuG+traBgA9C03LqndzadTfztJbECrYvrzTvHAG3MVzw3wu8PFp1DBVuviM9N3 RNJiR2Q3A692TAVAasazb2uJAz0hYuHjwnNncg0eFG3WmzOKYO1Xr5kGMRzOYpy9aFR+ rDOQMSmrDnNTN2BpAIpa1I+4E+9n93UYYAvcM2EQqpAiOgG175mZLtWSkqEOmS594tQQ KOW+eER8DLYdqUKN3JvtyK87jLyQ5Q5Ee6Yyev1CoV8VFpUcTLtLCyN/ePlpWfP49dND rYkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=WNh+x+OWHSnEdtKcxCOWpDuyA/8qEaPk9rbanJULEvs=; b=E20Op9LPzyKGV7EkgjLOqWzuYTQMYfjMB+Xliv2rPY85zW7kiFj/YCLKnmx+gLaUQC RBgiYZ0qGsavrzmITQhnhSM5ZwoxOs4OvTzTAwfwn7wceqio+pe9ypIKii47xpZcV3yd RfmLLwvSPeWDc/YHLNQ/tYi/aMJBITL316E74ck5D/z33guD1VopVzT8Gku8fUiWgAJm Q9bGsWwRHSlVL4I5UH70prtxReOIZmd9YHrF8sy0p6t3iJGkzm47nvVIlZV8WueTx7I3 EtJatgxGnf9Kd52UCZu6IV9kLzsk5Ch82uW+HxmIlrB1yRgUr575lbXZxwj/LkIcnXtB DwGg== X-Gm-Message-State: AKwxytc9DbWfWbElTDn7Wo2EUDVBgZcd2sMPLp3/upHCErnVLP4QiXKB SdCFH7CF7bfz/rskgk43gIQiWPjvCU2Fu8DXmm0= X-Google-Smtp-Source: AH8x225Wafd78o0bxmamaZS8gUcVWv1FGV+5zmfdFzMXnhod7E+KlycBhhQjvrTORkB3JCv0gIH3Qk1AHzF9JnJ8o7E= X-Received: by 10.28.35.200 with SMTP id j191mr17728741wmj.146.1517422572689; Wed, 31 Jan 2018 10:16:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.182.77 with HTTP; Wed, 31 Jan 2018 10:16:12 -0800 (PST) In-Reply-To: <87zi4t297u.fsf@gmx.de> References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> From: Noam Postavsky Date: Wed, 31 Jan 2018 13:16:12 -0500 X-Google-Sender-Auth: jImwUwTIi-rZLQ-dzU-2XmegVec Message-ID: Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Eli Zaretskii , Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Wed, Jan 31, 2018 at 1:07 PM, Michael Albinus wrote: > Agreed. I expect some broken tests in tramp-tests then (IIRC, copy-file > and rename-file were affected). I will skip those tests for Emacs 26, > immediately after the revert has happened. Pls ping me when it is > reverted. Actually, if it's not too much trouble, I think it would be better if you did the reverting; it looks to me like not all of the commit is directly related to this, and I think you're probably the best able to untangle that. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 31 13:22:09 2018 Received: (at 30243) by debbugs.gnu.org; 31 Jan 2018 18:22:09 +0000 Received: from localhost ([127.0.0.1]:51496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egx1N-00024D-E8 for submit@debbugs.gnu.org; Wed, 31 Jan 2018 13:22:09 -0500 Received: from mout.gmx.net ([212.227.15.18]:58484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egx1M-00023u-23 for 30243@debbugs.gnu.org; Wed, 31 Jan 2018 13:22:08 -0500 Received: from detlef.gmx.de ([213.220.148.66]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LwJFG-1eoMAh3uLW-0185Tl; Wed, 31 Jan 2018 19:21:54 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> Date: Wed, 31 Jan 2018 19:21:52 +0100 In-Reply-To: (Noam Postavsky's message of "Wed, 31 Jan 2018 13:16:12 -0500") Message-ID: <87vafh28jj.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:AHkH3cys7+fj3ERqUfCDYpJSNdBW5QnR2yWJOMKkT7SYpoy2fqL a/NMgsq5JxfSWvjLXm1WdkNrqxeXjki3f6U5NhP/DQeIBAxJWOGlmOyUj+sFFJAE8PVHZbd rrfIT6kOBlxfCyaQi9PUwSe3KoDzCeKd3FUIk/n7tO2nVi1K+jpnDKX04OMV9ExQ1kBZzAb AQdAPt83QYkNp7Lu9L0/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:XhP3tzdcPIc=:VDdTx2lis/qKR2L+gZxQeb jczmyFZJlwkGlYXbPQtwKLDKCIF9bDSP+C2VlgTMDyKDK6QUlbR5yCS1TmKbo+Ekmo4N+be32 fple/OS9pUgR+EjpiEqqmIQc38vtET1J4QEYHl8wbI4aMKEnDKs+n01mwgt53+YmvDem6NMg/ svekV8pJDU/+wrUP0C2WqNguF4bEPEP5IJZYDc0w0gt8oMDkcSev8FcYYPwrICKeBWcBvC0vu RH81MdfVv7A/BC+WoehfEx04LK+mZeRJPMli7yaPY/jLV6c6SW67wUPIfAqtfdHzpJUNFHTG6 qrfUaGn35XE+I7CafYbknB6H8FlBLTBqB5XhTghSTLk4yjWn8bYRvaTCJskDjUAOyQY9AQU9B +ucb1gy5QPW5wStDFDALBkfp+DxshX8vxI1KLphzwbGFqzsaY2gejbTEUd/umqXVBKPi0yd7G IWCeTNkEur4zYDPyWKm+KjtUlcTqvVFQupqhIuEkDzHi1Xo8JBI/g/CmiWqZV/kwWs0BfPQ0F FlKy2d2B4dTagPirOxJRKsGycuyugJR3xO5TjF2TgkPjQ+OTVEEeG3vTyBMdaMJ6BPKU51gNe zsc3dg/fTSZZoUyXtEl+KHoMXjAlXhufNIjtIg2AYhO6lkxv3aTbQuGjgPs9wMu86VA8kes0P wN0zOAoO1o7+Oznl0OEWWBzDz2sTtRKq1kUErhjAz/FF+/IrR6ENHA1tYJPri3ySGZU1b2B+t 7AGEQeuGteoFw/Vv9x+PuH8/wQSY+rL+yaf19PyijPSKnZ6Qm9ZVS7X6QotrTEg9ntag+IQg9 7PhSZtxvk1bNK4oZEDVctf7/ZHsJM75xk5HOvEPJVPVqFwYsLs= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Eli Zaretskii , Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: > Actually, if it's not too much trouble, I think it would be better if > you did the reverting; it looks to me like not all of the commit is > directly related to this, and I think you're probably the best able to > untangle that. Will do, but rather tomorrow. I'm just attending the monthly Berlin Emacs Meetup. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 01 09:02:12 2018 Received: (at 30243) by debbugs.gnu.org; 1 Feb 2018 14:02:12 +0000 Received: from localhost ([127.0.0.1]:51920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehFRM-000516-6I for submit@debbugs.gnu.org; Thu, 01 Feb 2018 09:02:12 -0500 Received: from mout.gmx.net ([212.227.15.15]:59519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehFRK-00050r-9s for 30243@debbugs.gnu.org; Thu, 01 Feb 2018 09:02:10 -0500 Received: from detlef.gmx.de ([213.220.148.66]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MaqeA-1eRMRq0ZJa-00KQzJ; Thu, 01 Feb 2018 15:01:56 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> Date: Thu, 01 Feb 2018 15:01:55 +0100 In-Reply-To: (Noam Postavsky's message of "Wed, 31 Jan 2018 13:16:12 -0500") Message-ID: <874ln0x0z0.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:LVOInizVl0EbxXREVlTVamfWY7pnpAJDjm1JH/y+ok4gtFp0nVJ SDlhQ7nUiu7BrfGLucLoW6AhbMIeZ34hkIARPky4u28cH0j9uAZzCIYumaQyTnKUzd1+SCx fKOwomNxiPwGE+rCoM1IhQxK+SbA7nbXMzl2ZQbRvWcH/R1ohzSa1X1U4DsTO+ofSmi5U+a 3r4BFpQ4pkwdNbY/wxTNg== X-UI-Out-Filterresults: notjunk:1;V01:K0:BoUGxPaX9fs=:JIXKk8SAxeWcRGAU1p9xjY IJcx1rwfDw+hawpr54cDMlcgxl+S6pFGnZfc8rHNtlxZo7D1OZqugYj5c/WtAcz3/ZotoZvA6 EHbZqn7WP7HRaMiAkis612aXNZolb+AkLNzTPiybED1xXU0vI/XOyjYYGPJ32ouCJsRFokHDp le+IW05C0nZmgbyDPSnsY6aTkGXbanS/xLq6/P7ghPq8te3GcurroYMGa3s4r3IT61va97OYU KJ6fpVtuzS9BQcrZXGdnAiJrpgsjoa6UnpdKfV+D0t4cYTpVPDZjmslfriTB0m4rJlPemJnXl 4hXtuJjkWBm8vHuReS7xMAILqgq4fIflwDll5ECuEuSJkW0zj+8t0CUnecagbTVuazE6awf8F 3MJzvD+VpmhDF183YufJCgWt60Xtx1yhcli0fAw1oQl9/rDL3rqlVatq/Nd5S7A7Cqw4KiwA4 PyB4WlyEMcNG8RbG+Ga/ieJUsIfWfmPCIEZPyeUDzHX8Ky6GEfrRO2lTeDE+VJDGz0WyJlzl9 GmXxm77TOq+FWIHp9B+L06g/IGbTL8BRuyVZyG7LcgLxCiE0pjzo8cPLW7Gkue+wWPtN+joK8 pUFU4LoTh/sqIU+KuA3oRo08Gbm65sQl24kilzLveiVVSSZ9mSJQQOyhDpyQ6dlEfftDgkIr8 LsVgnaKITgEwCFYifj5y3Q/JZM3tUIh0/5/OLzZbQ4UQu+lHlMFzkWwL50MbemAkOQuSCUnzj +mYz1gumQOoksE3EZDdB1HbvylZReYet2b5U0AJuFndtbO/Stp8kutHApleA0GK/BGy/QlPV8 MUcCms8xc35QAFhM/1/MoN6lc250b5Tqe6r814UJ3eYK1io0Pg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Eli Zaretskii , Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: > Actually, if it's not too much trouble, I think it would be better if > you did the reverting; it looks to me like not all of the commit is > directly related to this, and I think you're probably the best able to > untangle that. I've pushed this to the emacs-26 branch. Philipp, could you pls check whether everything is OK now for you? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 01 11:40:51 2018 Received: (at 30243) by debbugs.gnu.org; 1 Feb 2018 16:40:51 +0000 Received: from localhost ([127.0.0.1]:52611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehHur-0000Yk-D2 for submit@debbugs.gnu.org; Thu, 01 Feb 2018 11:40:50 -0500 Received: from mail-lf0-f49.google.com ([209.85.215.49]:37860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehHup-0000YT-VS for 30243@debbugs.gnu.org; Thu, 01 Feb 2018 11:40:48 -0500 Received: by mail-lf0-f49.google.com with SMTP id 63so27164083lfv.4 for <30243@debbugs.gnu.org>; Thu, 01 Feb 2018 08:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xwn0WeZpUtrWhAPZ2/Kej+EIgaVko1APWH2rvCzO+sI=; b=fNO191h7su1tJL6JANT31xqKgK/Z+dZDT4BKa3zWsYE5uCGfeZA0N71SdadwGOEUCB v3t4GoKH56lJJPunLmzM+UOUf4zJ/MfHoPE0v5CElEPfrBh1HAnCltGQL+sDpwLXvaJc VsHSqXhDOofM7TatFDVuJb59DxC9Mv5W0RdOFV7hPCpki0oL1LLnSuWDkxXzHf2ZsoPo ezTLUFPLdii1StYC/4w35Wk11osczWVl0aUwnbu5l0GxNdrBkv6kjIxFKN5HCIPliq3N EvbfkfW449QUeTqAGhvfviwwU70pXP2IUjC97Se60KcPEg0GMoHucytSgwKtl9rWvK2z fO+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xwn0WeZpUtrWhAPZ2/Kej+EIgaVko1APWH2rvCzO+sI=; b=LX4h7CWeQ5M6USCFvR7hDaOL2SlIGfj/75b0T/Q6oh0lWK+gl+e58ouAOogB27hxEz /X9eGGsVxdNWwjHNtj/kjjP6bip8O+AQ4WPY+6ke7Tyn974uRd1YeJDX5oG6SpvCbNeu xKAVdRVBBM4PtVwqSApFSbZDhALHe7NvVCJ6ZvJL931lATgSUJp+P0E/f6EziZxF9tUN gHbJXmEkvXR+QTW8gQEC4AfFplPCjZHq+iGShI+9ONI8Y/QkzJKeMJ+gKbubcBKarNfX 1sXo3r+e2t+Qs3wUc3dcrSFo2UkdGt0S7s+NWG8z7b9NGn8gQ4xwS+SMdEqz6wgKjRH5 LHqw== X-Gm-Message-State: AKwxyteH+kkM36wVQsWJFPBnj12fMAk5zFsYIWVM7dYAkurqDtmDIBRz I3uFzFLlL6yye8mJSluWovKjo46KVup2dpqrswc= X-Google-Smtp-Source: AH8x227CL+MXvQHDElxg3kGOUdYGRUJmI7JD3Y2rOtwNdkEJFrgXcqLHCJehoqDeDPU50VYnu7hdRbNNqSDroTZSXaU= X-Received: by 10.46.15.2 with SMTP id 2mr5260075ljp.144.1517503241915; Thu, 01 Feb 2018 08:40:41 -0800 (PST) MIME-Version: 1.0 References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> <874ln0x0z0.fsf@gmx.de> In-Reply-To: <874ln0x0z0.fsf@gmx.de> From: Philipp Stephani Date: Thu, 01 Feb 2018 16:40:30 +0000 Message-ID: Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames To: Michael Albinus Content-Type: multipart/alternative; boundary="f40304360414ae155e05642941b2" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --f40304360414ae155e05642941b2 Content-Type: text/plain; charset="UTF-8" Michael Albinus schrieb am Do., 1. Feb. 2018 um 15:01 Uhr: > Noam Postavsky writes: > > > Actually, if it's not too much trouble, I think it would be better if > > you did the reverting; it looks to me like not all of the commit is > > directly related to this, and I think you're probably the best able to > > untangle that. > > I've pushed this to the emacs-26 branch. Philipp, could you pls check > whether everything is OK now for you? > > Seems to work. I've tested both the batch command and visiting a quoted file, they appear to work as expected. Thanks! --f40304360414ae155e05642941b2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Michae= l Albinus <michael.albinus@gmx= .de> schrieb am Do., 1. Feb. 2018 um 15:01=C2=A0Uhr:
Noam Postavsky <npostavs@users.sourceforge.net>= writes:

> Actually, if it's not too much trouble, I think it would be better= if
> you did the reverting; it looks to me like not all of the commit is > directly related to this, and I think you're probably the best abl= e to
> untangle that.

I've pushed this to the emacs-26 branch. Philipp, could you pls check whether everything is OK now for you?


Seems to work. I've tested both th= e batch command and visiting a quoted file, they appear to work as expected= . Thanks!=C2=A0
--f40304360414ae155e05642941b2-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 01 13:52:36 2018 Received: (at 30243) by debbugs.gnu.org; 1 Feb 2018 18:52:36 +0000 Received: from localhost ([127.0.0.1]:52677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehJyN-0005ee-Tk for submit@debbugs.gnu.org; Thu, 01 Feb 2018 13:52:36 -0500 Received: from mout.gmx.net ([212.227.17.21]:59075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehJyM-0005eQ-9N for 30243@debbugs.gnu.org; Thu, 01 Feb 2018 13:52:34 -0500 Received: from detlef.gmx.de ([178.20.93.111]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mhhr5-1eKRlf0de7-00MrLG; Thu, 01 Feb 2018 19:52:20 +0100 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87shaun9ix.fsf@users.sourceforge.net> <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> <874ln0x0z0.fsf@gmx.de> Date: Thu, 01 Feb 2018 19:52:19 +0100 In-Reply-To: (Philipp Stephani's message of "Thu, 01 Feb 2018 16:40:30 +0000") Message-ID: <87372kpmos.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:aKUGJZ77476a3Kru7p5lrwRTh2dhdONNpFeAtRZKqApATd6Py6J OronujkZa9uy4y8ULyzWCrwuGpLENJZKfFi2odl1DuvzSziAZeBlmKgXY07KQX+Msk8x3Rv O2z0byFSAmWZU/4WI9p/k4GKnPUVjnN4tgroPzTqEPPSm886jknlQ1KY7AWLoRYGqyTrhBb upAk10qpeeGPs1ROddTMQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:6l/BF1Z35zY=:DQWOQuLSINg01fuSP9We4T PWZNrhswpv3XPcOrKMDhpzYVuqpxQCzvWRASXMU2kkSVmkqmVZvEztUnqMA8LJeXSZURPkf+8 tQ48AUbFIA80Oi05gnr6Xlk4B1wXNLrNFJIIZOOFLMQcJe5qsQfvVzwkZ0XeX2X8X/78ZhhOC jXzoID+yN/Z5l3wBzisnXnxv/tifyQ7VE0WRsnIotsne4HbInjTPFNNimgxumJ8Pbffqz2qO+ A+sXLluXX/t1aQuyj1wyS9YH6IrttlIg0g0FzisDWhNcCS0y1o4oPhmo9JcOGsIrX4eVscuE6 QXPnXwINB01snQoPmvBR3Woulk85boUNHnHKFGJjZhPr9AsOiiq3jqZBLNDq5jfNn7EvfxqOY 42f28wlrOqmCFYMhFC4aE7jbxbimtgS5bfPwvX8j4zSCLPnNTjRwApLLEyjYzukc4ljd2hxA7 l+SLrcc9i9Joc1U7SnQ1QPSXTUKAPdVxdXCx8jrPqJpXO+tzfFN5AgwMTrW1u+POnFNuOjreQ tEJoyfYfpgWbbUns9rA2bbKom2ShWyZPd9UKKCsKeOhUhk/iCxFF/v/fdwGbanK/jpkmyvOT5 5CN6riF6G0SaEomlzz645krQR5/aS1E3T/vB+e8eCUfAMFhtHyR+HRBpXfKtRhjjS/tIX+vAu vSyIZc34TUvmT2jnjP9hqhnj2lplS+rToHDQZNOiuVsa5t+q3rd21TLfC1ma878V2j3NCulxp ql5nDjYF6tAZ2iOzDBdNRpVIGDZUQPnWrYxJKd+ZOBg6rHhL320FpShnmlutsnNq0JcURg5KA WjGNWKKACKkLv4gwnqvvTPakI45jD2VRM+4ImW6yPb++6zSV5I= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Philipp Stephani writes: Hi Philipp, > Seems to work. I've tested both the batch command and visiting a > quoted file, they appear to work as expected. Thanks! Thanks for checking. So we seem to be OK now with the emacs-26 branch. I propose to close this bug after Noam has merged the scratch/nonspecial-handlers branch into master, and the tests pass successfully. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 01 20:17:10 2018 Received: (at 30243) by debbugs.gnu.org; 2 Feb 2018 01:17:10 +0000 Received: from localhost ([127.0.0.1]:53061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehPyX-000868-TN for submit@debbugs.gnu.org; Thu, 01 Feb 2018 20:17:10 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:45369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehPyW-00085v-8b for 30243@debbugs.gnu.org; Thu, 01 Feb 2018 20:17:08 -0500 Received: by mail-io0-f169.google.com with SMTP id p188so21244144ioe.12 for <30243@debbugs.gnu.org>; Thu, 01 Feb 2018 17:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YNEqt6w6hw7qQ3wTu9sTbegk4Ei2zoLnizOaiSsZWoQ=; b=j02ZqgB4wjSu+0aVe9DQGe/ntZtC1ZyvpLrDQ3O1DzoLSt/ZOeuCGg5a/mm2FkpPDA rpNTyH0tp+Mj9x8eJ9DWseaLGncq6410FtVOxgRIsYf1eZHK0uW+YL8kweQZUBLmYvoY DdZSNM/KsTFDWdulLNBQ5KzTjSYIXz+RcbLoU0iv+rBA+Z/2UKAkKiSBIg3YhH7cXmZp tY9t12Buk0cNw5vh6hzCWTIo646Eo2ZnL4ejEMqEXaEX34cvXz/unVWJlw9ftxGKqrD0 UI6zTtxt20QCqYB+MmwzHJIjGTH8Hcpdw7rPRlLTp/Fae7CL+hMVO7Q4UI6MlxwLK8yp dlhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=YNEqt6w6hw7qQ3wTu9sTbegk4Ei2zoLnizOaiSsZWoQ=; b=SxP8696vd+IR4kpFwY1sXPmdaqnf4sHiM/GkIXDLUjhjxqLijAyRWi4K4za+SATKkG +lGVyvG44bkGM48DJqDW4r7NEf03LFNwSGMO+zajsjf/4P2s0+dX5Dtw+3KQY8nRh8kY 0HvUSN8O9FilJC/fjYgrNOXiV1fGYji5o/jCBsMmcTdYRTOgKvWimW6pleEbrXaUba+1 IY449hp4Oabz6njJti6bkFc7iQwR0S2iqrxuP8DQGUn9TPXGO9zZpDUVL9O60DPB+EgS ixYlAr+KtwVlYkK9dATsVSWI9cuy83lm+8fDkQg78R2JolFK9XZ7PPQBGRVQrovB+JF8 Xjxg== X-Gm-Message-State: AKwxytcOYlaQMXV2cEUk6QWwTQvVtGOH1XhO2zqs6U5feQewMYfFZshc L8JPr9DzntcMWUuiE1jyKEw= X-Google-Smtp-Source: AH8x225zLiRzfQQIZIatV1EgR97Ae6RtiOMDN3yJJdfNAU27TCm1zWhaq+0NEsqUboBR2BwhmReCsw== X-Received: by 10.107.173.144 with SMTP id m16mr30005332ioo.122.1517534222543; Thu, 01 Feb 2018 17:17:02 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id s70sm1981304itb.0.2018.02.01.17.17.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Feb 2018 17:17:01 -0800 (PST) From: Noam Postavsky To: Michael Albinus Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> <874ln0x0z0.fsf@gmx.de> <87372kpmos.fsf@gmx.de> Date: Thu, 01 Feb 2018 20:16:59 -0500 In-Reply-To: <87372kpmos.fsf@gmx.de> (Michael Albinus's message of "Thu, 01 Feb 2018 19:52:19 +0100") Message-ID: <87607ggph0.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Michael Albinus writes: > Philipp Stephani writes: > > Hi Philipp, > >> Seems to work. I've tested both the batch command and visiting a >> quoted file, they appear to work as expected. Thanks! > > Thanks for checking. So we seem to be OK now with the emacs-26 branch. > > I propose to close this bug after Noam has merged the > scratch/nonspecial-handlers branch into master, and the tests pass > successfully. I'v pushed to master. [1: 65da409e41]: 2018-02-01 20:14:57 -0500 Test and fix "/:" quoted file name handlers (Bug#30243) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=65da409e411a0cdfa1932d21ce8a7f87ceae9e25 [2: 00c65bcf4e]: 2018-02-01 20:15:11 -0500 Use file-name-quote{,d-p} in files-tests.el https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=00c65bcf4ee8ca4ce04ad46907de29c832b8310b [3: e08de2bae2]: 2018-02-01 20:15:12 -0500 Handle quoted file names in filenotify.el https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e08de2bae2a8e91c0245259dfcbfdca1d191a119 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 02 12:57:06 2018 Received: (at 30243) by debbugs.gnu.org; 2 Feb 2018 17:57:06 +0000 Received: from localhost ([127.0.0.1]:54532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehfaE-0005Xp-Cd for submit@debbugs.gnu.org; Fri, 02 Feb 2018 12:57:06 -0500 Received: from mout.gmx.net ([212.227.17.22]:61418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehfaC-0005XL-FA for 30243@debbugs.gnu.org; Fri, 02 Feb 2018 12:57:04 -0500 Received: from detlef.gmx.de ([212.86.43.48]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MQMBU-1eIPSI0Mns-00Tjda; Fri, 02 Feb 2018 18:56:50 +0100 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <87po5ymqed.fsf@users.sourceforge.net> <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> <874ln0x0z0.fsf@gmx.de> <87372kpmos.fsf@gmx.de> <87607ggph0.fsf@users.sourceforge.net> Date: Fri, 02 Feb 2018 18:56:49 +0100 In-Reply-To: <87607ggph0.fsf@users.sourceforge.net> (Noam Postavsky's message of "Thu, 01 Feb 2018 20:16:59 -0500") Message-ID: <87mv0rxoke.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:j8SuGJ/x2SoRdkxbwP4o9R+MtO4t4BA5Vx0QYLKhdBEbjs0n6PE Oiqeewpak3yHf4XZFnGmc1lzQ1iptMl8WbdyL+qyMz06ioe2+I18KaDG6zopbnPNkHMR6jZ lPkMJaVnsqSyc73LkkNp8r6TnV1HNpih6TEuRVUpR8KN2bRmOLdgLEAfKZaCfwbq349+5uk BVAWwDiaaEIznAzxWpfCA== X-UI-Out-Filterresults: notjunk:1;V01:K0:JC9bxZQXTTU=:8zh04+JcpiToU5rMag6UGQ rDCCEG6+fLMw0dCO7VUplUPZpjTYfnocDiHZgVrhV0Gmy1nEIhriIU08ySwQLROnREGo3Qjfh RW+2ayNApcrbzfYGfX2DWU7B6dSh03cP/kBtzDJZYW0ovxb0D1mvjnI0Ljrs5tiCgkobFY3N2 Wh2ngHuf36V8287VlVNcDxxSJJctzzXUXbAO2dPkYG23gUXC9mk2WYs5v3rQbjQZ3jq+c/mh2 ERQtAB3TtlA+RAsIHVhZFtIKv3OCvAqIw8m2g1AE5L8yMuQbB9MSHVYEtEANZg7C9+5gmseQF wQNnCzU3KRH65XDJaeuVy/jtOBYGmFJJEVlfodMQcgpvLxT30ozgem0VmtgSJo5qKfHbcJ2aH EFWyaLxqyvjd95MetuF06F2Ght8LOg1mbp4pXpHCnrDcjcBqDlYYq2Ke14qPfhE5Bkj19awJz lC7pLphDcvYfeyr8eQrszMb2kHa9ZNAkC832efsld6Sm3Kl/04T0BrVP8oyP+dKiMapiTYrWr 3GfvLJDg7ZGDLUYblFMK8cFS4G1L0OzvzcSmU+bRKeUaSl0gIUKiiLkNgN9EMdCAEZunoRIvj 6Woz9agdaskoAkuZRIWlKijBFQqr8jatZ8JY7GsNIQ03AhKlXBHVXjx9vOzhsQLSNo02kZAH5 BXVj6dFTD2Y7LDh3LtrkbdaO0dS2gbEpkIttdmSsGcNqKhZHkNXzUBQjYZUJvu7WfFgnDmuLR 4NS3zhUcMGp/u2kcXH0q5FGfUHISB4XEVASiYb/ssHlv7HsksnTmdg54rqWqUg/jCpdr7ZDqQ xpnbw+v/JUtz2HOKJyu7fVgPuVjsOWmwiUAS6qSTXxxs+874tc= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: Hi Noam, > I'v pushed to master. > > [1: 65da409e41]: 2018-02-01 20:14:57 -0500 > Test and fix "/:" quoted file name handlers (Bug#30243) > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=65da409e411a0cdfa1932d21ce8a7f87ceae9e25 > > [2: 00c65bcf4e]: 2018-02-01 20:15:11 -0500 > Use file-name-quote{,d-p} in files-tests.el > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=00c65bcf4ee8ca4ce04ad46907de29c832b8310b > > [3: e08de2bae2]: 2018-02-01 20:15:12 -0500 > Handle quoted file names in filenotify.el > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e08de2bae2a8e91c0245259dfcbfdca1d191a119 Thanks. I did rerun filenotify-tests.el interactively, after applying (setq temporary-file-directory (file-name-quote temporary-file-directory)) And indeed, the tests for a quoted remote temporary-file-directory did fail. Fixed now, and pushed to master. I've also extended files-tests-file-name-non-special-quote-unquote with some more quoting/unquoting scenarii. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 15:34:30 2018 Received: (at 30243) by debbugs.gnu.org; 3 Feb 2018 20:34:30 +0000 Received: from localhost ([127.0.0.1]:55978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei4W6-0004xx-BU for submit@debbugs.gnu.org; Sat, 03 Feb 2018 15:34:30 -0500 Received: from mail-io0-f181.google.com ([209.85.223.181]:37095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei4W5-0004xe-2B; Sat, 03 Feb 2018 15:34:29 -0500 Received: by mail-io0-f181.google.com with SMTP id f89so26472742ioj.4; Sat, 03 Feb 2018 12:34:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xO5t+jKldPXc5DZRiNf34/2elAUhy8d+Kv3aMgyZF1o=; b=MOmwjDPSt50T+zAvPZTDv3NSCeuM35SzUfihpwmIZlgCnOQXIlBqfcTj9/rb1EW0QS ZWlZlHWeB86OjZxhBdacIzQMoKy9Kob0rMw+SPWe77H40Vo/7mfeMdptgSTpgeVoenum 2GgGrM82qxGaxpF8d3UHBZoTVA1K4lKhq/N4yKGfNgdqfMGIMsdqWpeV1/oWhTbPLS/F i4K076EF0uAR6S6+rmh7CYv71CaMqf4L/zyn/Lx5JVth7i9gAGLyl1j7zZBA5I5lH3T/ /WCfLHp8Oj2WPPACUfJENeg+XMNJgUt25e0GTQztLdB0aAu6u5uT87POrxTruBvo5Tco di3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=xO5t+jKldPXc5DZRiNf34/2elAUhy8d+Kv3aMgyZF1o=; b=I05nDb90dcjOUM20fnPsE8IE4AVmM1W1belniMfq1V3Yy5sxv5K/aSXKRH1K1Q3YqE Cd5JPTCfOoZXp/df0pl9cEWjv3MrdpTU+fQqfi/ATUzUUc6QCUgxUIbWL0kJaaWKq9KM eQBLZdY6J/XM0tSFQjYmKROf9BD08aULuSVEzbW77s9+1b8Ig5YoD2MdCluAVVb4tX45 jjf68M3/Vh+J7bZX/ENWLT62XSLWIZ/l9OkgpTFlkA7HD2YPXS16jXGcj/Mww+fZeQ+a PX7GbagoUL+N6y4JZ2bNgEDFus0mhBZptct9xqUUntL+ObDquqnGamBxHwwyszp/N8rN X37g== X-Gm-Message-State: AKwxytc5LVtWHk6jalc7PyCcU7KpYnxN3eteXh6bZB1H/BZhOL+7sSKU GxAMS88ayNwjOa8gWkZktLz1kg== X-Google-Smtp-Source: AH8x224FgQwWY1eDs9jL9eIHNGeVtw1n/thJDWD4gzppFlCtra2fl7hV2O3i2Lmb/+1LFz3nGfSAuA== X-Received: by 10.107.36.20 with SMTP id k20mr47082069iok.143.1517690063273; Sat, 03 Feb 2018 12:34:23 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v190sm2956651itb.3.2018.02.03.12.34.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Feb 2018 12:34:21 -0800 (PST) From: Noam Postavsky To: Michael Albinus Subject: Re: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames References: <874lnafeun.fsf@gmx.de> <87mv12m3q6.fsf@users.sourceforge.net> <877es528vp.fsf@gmx.de> <87h8r9mlxx.fsf@users.sourceforge.net> <871sichok1.fsf@gmx.de> <87372qz395.fsf@gmx.de> <87shaqkp2q.fsf@users.sourceforge.net> <83mv0vh32y.fsf@gnu.org> <87inbij3pr.fsf@users.sourceforge.net> <83607if24h.fsf@gnu.org> <87zi4t297u.fsf@gmx.de> <874ln0x0z0.fsf@gmx.de> <87372kpmos.fsf@gmx.de> <87607ggph0.fsf@users.sourceforge.net> <87mv0rxoke.fsf@gmx.de> Date: Sat, 03 Feb 2018 15:34:20 -0500 In-Reply-To: <87mv0rxoke.fsf@gmx.de> (Michael Albinus's message of "Fri, 02 Feb 2018 18:56:49 +0100") Message-ID: <87lgg9g6cz.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30243 Cc: 30243@debbugs.gnu.org, Philipp Stephani , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tags 30243 fixed close 30243 26.1 quit Michael Albinus writes: > Thanks. I did rerun filenotify-tests.el interactively, after applying > (setq temporary-file-directory (file-name-quote temporary-file-directory)) > > And indeed, the tests for a quoted remote temporary-file-directory did > fail. Fixed now, and pushed to master. > > I've also extended files-tests-file-name-non-special-quote-unquote with > some more quoting/unquoting scenarii. Okay, I think we can consider this bug done. From unknown Wed Sep 10 20:08:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 04 Mar 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator