From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 30235@debbugs.gnu.org X-Debbugs-Original-To: "" Received: via spool by submit@debbugs.gnu.org id=B.151674960415246 (code B ref -1); Tue, 23 Jan 2018 23:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jan 2018 23:20:04 +0000 Received: from localhost ([127.0.0.1]:40125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee7rG-0003xp-K1 for submit@debbugs.gnu.org; Tue, 23 Jan 2018 18:20:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee7rD-0003xD-55 for submit@debbugs.gnu.org; Tue, 23 Jan 2018 18:19:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee7qH-0006ce-Jz for submit@debbugs.gnu.org; Tue, 23 Jan 2018 18:19:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ee7qH-0006bU-5L for submit@debbugs.gnu.org; Tue, 23 Jan 2018 18:19:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee7po-0003ZK-8r for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 18:19:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee7pM-0005LS-2Z for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 18:18:32 -0500 Received: from mail-ot0-x22f.google.com ([2607:f8b0:4003:c0f::22f]:37315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee7pL-0005JU-A9 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 18:18:03 -0500 Received: by mail-ot0-x22f.google.com with SMTP id a24so1997168otd.4 for ; Tue, 23 Jan 2018 15:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=/NN6+JyhBmex1sFNegzEWHj47unYrXxERDNR0+MVhaA=; b=AG3iwoNvmX6CWhIdivJTiJHH4eIzTjPuc+6KSlxiCbJKO7IWaXjFPfyV1q3ILXfHJB LWs1ooFw08JLuP41/boBtF0bghUME9kR1mVpw4uB9BAx8l1rUvy2HygOGTAATSZ7GNpj CY50Dx7prvkLzuvJjOh28Lwt5TlixK6cBvGc/G+WB89BggMoqClSSefnk311fM+cnVwA ++VCRlEmmXxrMZArUPPQKnkm1xCdPp0nmgMKtLWfa07TbHO+vjFTUYvx8bmt0PN8lmQl sZ38n++itY/Jeqbdb1wM+Rthcc66+QzH82zT3++h9YCMNQKdce9XyrYRSPzCTX7SWr6u 3qSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=/NN6+JyhBmex1sFNegzEWHj47unYrXxERDNR0+MVhaA=; b=oU/KkcgeRs1p3yuJEw5yiPn0RASA53VuWzdaLRrp26zQdUOoV2QepISksb6GqPPmTs SQj4djqjAJqwRDaCH34qfJXOY6kAHVuIAqlOqTDCZrVtC9qaYDiZQLN31xShL1rmewT9 5jrvK0QrYEiuDaP2vo+o3lg2EPW1IDmPH2vKt5UWPCSpDMU5RoI40abw8P1h8ft6WLHz qWJyDQwE2/i03RS5K1CVzJJhDB4bdMfc6n/uiM27rFgOE41xDpqWZLD5Qv/qjHSvs5kE VV44/WIDCP6BzfH0QFhMQ67xZRdBddsy9mFmk22IKP4PNtA+FQpba4Si2E0a21X+LJaV thpA== X-Gm-Message-State: AKwxyteyJWcEEslNejgrTcYDTubOHA12CO2RqsWYQ02mB2GlY0VYIhG3 psKXHEGWHfu/lanyrM4U4CF5eUzo X-Google-Smtp-Source: AH8x226R8qtJZ4lf8NBPmEs0bGX4h1lbY+3bRDD1HOOT9axErXoo3eWKRaL9ZdFp4glhCrVRl66bgg== X-Received: by 10.157.91.22 with SMTP id x22mr8772379oth.206.1516749482083; Tue, 23 Jan 2018 15:18:02 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id s15sm1682270ois.25.2018.01.23.15.18.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2018 15:18:01 -0800 (PST) User-agent: mu4e 0.9.18; emacs 26.0.91 From: Alex Branham Date: Tue, 23 Jan 2018 17:18:00 -0600 Message-ID: <87y3ko9nbr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I'm not sure if this is the right place to submit patches for ELPA packages, but I couldn't find anywhere else to go. Let me know if this should go some place else. This patch silences several byte compiler warnings, mostly having to do with unused lexical variables in loops. There are two remaining that I couldn't figure out how to deal with because I'm not terribly familiar with the innards of Emacs's undo feature. (Note that the line numbers are after applying the attached patch): In undo-tree-pull-undo-in-region-branch: undo-tree.el:2261:16:Warning: =E2=80=98undo-elt-crosses-region=E2=80=99 is = an obsolete function (as of 25.1). In undo-tree-pull-redo-in-region-branch: undo-tree.el:2470:16:Warning: =E2=80=98undo-elt-crosses-region=E2=80=99 is = an obsolete function (as of 25.1). >From f9a275a3cdb586f9ea91e26be84b4a42efe957fc Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 23 Jan 2018 17:10:48 -0600 Subject: [PATCH] Silence the byte-compiler --- undo-tree.el | 38 +++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/undo-tree.el b/undo-tree.el index 6c7ee2f..fc52cff 100644 --- a/undo-tree.el +++ b/undo-tree.el @@ -757,6 +757,10 @@ (eval-when-compile (require 'cl)) (require 'diff) +;; silence the byte compiler +(defvar undo-tree-mode) +(defvar undo-tree-visualizer-selection-mode) + ;;; =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D @@ -2048,7 +2052,7 @@ which is defined in the `warnings' library.\n") ((=3D (mod num-children 2) 1) (setq p (undo-tree-node-next node)) ;; compute left-width - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf lwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2064,7 +2068,7 @@ which is defined in the `warnings' library.\n") ;; compute right-width (incf rwidth (undo-tree-node-rwidth (car p))) (setq p (cdr p)) - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf rwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2076,7 +2080,7 @@ which is defined in the `warnings' library.\n") (t (setq p (undo-tree-node-next node)) ;; compute left-width - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf lwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2086,7 +2090,7 @@ which is defined in the `warnings' library.\n") ;; centre-width is 0 when number of children is even (setq cwidth 0) ;; compute right-width - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf rwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2748,7 +2752,7 @@ changes within the current region." ;; `buffer-undo-tree' (undo-list-transfer-to-tree) - (dotimes (i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) + (dotimes (_i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) ;; check if at top of undo tree (unless (undo-tree-node-previous (undo-tree-current buffer-undo-tree= )) (user-error "No further undo information")) @@ -2857,7 +2861,7 @@ changes within the current region." ;; `buffer-undo-tree' (undo-list-transfer-to-tree) - (dotimes (i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) + (dotimes (_i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) ;; check if at bottom of undo tree (when (null (undo-tree-node-next (undo-tree-current buffer-undo-tree= ))) (user-error "No further redo information")) @@ -3576,7 +3580,7 @@ signaling an error if file is not found." (car (undo-tree-node-next node))))) (move-marker (setq pos (make-marker)) (point)) (setq n (cons nil (undo-tree-node-next node))) - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (setq n (cdr n)) (when (or (null active-branch) (eq (car n) @@ -3629,7 +3633,7 @@ signaling an error if file is not found." (move-marker pos (point))) ;; right subtrees (move-marker trunk-pos (1+ trunk-pos)) - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (setq n (cdr n)) (when (or (null active-branch) (eq (car n) @@ -3684,7 +3688,7 @@ signaling an error if file is not found." (when (characterp str) (setq str (make-string arg str)) (setq arg 1)) - (dotimes (i arg) (insert str)) + (dotimes (_i arg) (insert str)) (setq arg (* arg (length str))) (undo-tree-move-forward arg) ;; make sure mark isn't active, otherwise `backward-delete-char' might @@ -3769,7 +3773,7 @@ signaling an error if file is not found." (undo-tree-move-forward (+ (undo-tree-node-char-rwidth (car n)) (/ undo-tree-visualizer-spacing 2) 1)) - (dotimes (i (- (/ l 2) p 1)) + (dotimes (_i (- (/ l 2) p 1)) (setq n (cdr n)) (undo-tree-move-forward (+ (undo-tree-node-char-lwidth (car n)) @@ -3787,7 +3791,7 @@ signaling an error if file is not found." (+ (undo-tree-node-char-rwidth (car n)) (/ undo-tree-visualizer-spacing 2) 1)) (setq n (cdr n))) - (dotimes (i (- p (/ l 2) (mod l 2))) + (dotimes (_i (- p (/ l 2) (mod l 2))) (undo-tree-move-backward (+ (undo-tree-node-char-lwidth (car n)) (undo-tree-node-char-rwidth (car n)) @@ -3801,13 +3805,13 @@ signaling an error if file is not found." (defun undo-tree-timestamp-to-string - (timestamp &optional relative current register) + (timestamp &optional relative current register) ;; Convert TIMESTAMP to string (either absolute or RELATVE time), indica= ting ;; if it's the CURRENT node and/or has an associated REGISTER. (if relative ;; relative time (let ((time (floor (float-time - (subtract-time (current-time) timestamp)))) + (time-subtract (current-time) timestamp)))) n) (setq time ;; years @@ -4232,7 +4236,7 @@ specifies `saved', and a negative prefix argument spe= cifies (user-error "Undo-tree mode not enabled in buffer")) (let ((node undo-tree-visualizer-selected-node)) (catch 'top - (dotimes (i (or arg 1)) + (dotimes (_i (or arg 1)) (unless (undo-tree-node-previous node) (throw 'top t)) (setq node (undo-tree-node-previous node)))) ;; when using lazy drawing, extend tree upwards as required @@ -4254,7 +4258,7 @@ specifies `saved', and a negative prefix argument spe= cifies (user-error "Undo-tree mode not enabled in buffer")) (let ((node undo-tree-visualizer-selected-node)) (catch 'bottom - (dotimes (i (or arg 1)) + (dotimes (_i (or arg 1)) (unless (nth (undo-tree-node-branch node) (undo-tree-node-next node)) (throw 'bottom t)) (setq node @@ -4281,7 +4285,7 @@ specifies `saved', and a negative prefix argument spe= cifies (goto-char (undo-tree-node-marker undo-tree-visualizer-selected-node)) (setq end (line-end-position)) (catch 'end - (dotimes (i arg) + (dotimes (_i arg) (while (or (null node) (eq node undo-tree-visualizer-selected-node)) (forward-char) (setq node (get-text-property (point) 'undo-tree-node)) @@ -4304,7 +4308,7 @@ specifies `saved', and a negative prefix argument spe= cifies (goto-char (undo-tree-node-marker undo-tree-visualizer-selected-node)) (setq beg (line-beginning-position)) (catch 'beg - (dotimes (i arg) + (dotimes (_i arg) (while (or (null node) (eq node undo-tree-visualizer-selected-node)) (backward-char) (setq node (get-text-property (point) 'undo-tree-node)) -- 2.16.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Silence-the-byte-compiler.patch >From f9a275a3cdb586f9ea91e26be84b4a42efe957fc Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 23 Jan 2018 17:10:48 -0600 Subject: [PATCH] Silence the byte-compiler --- undo-tree.el | 38 +++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/undo-tree.el b/undo-tree.el index 6c7ee2f..fc52cff 100644 --- a/undo-tree.el +++ b/undo-tree.el @@ -757,6 +757,10 @@ (eval-when-compile (require 'cl)) (require 'diff) +;; silence the byte compiler +(defvar undo-tree-mode) +(defvar undo-tree-visualizer-selection-mode) + ;;; ===================================================================== @@ -2048,7 +2052,7 @@ which is defined in the `warnings' library.\n") ((= (mod num-children 2) 1) (setq p (undo-tree-node-next node)) ;; compute left-width - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf lwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2064,7 +2068,7 @@ which is defined in the `warnings' library.\n") ;; compute right-width (incf rwidth (undo-tree-node-rwidth (car p))) (setq p (cdr p)) - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf rwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2076,7 +2080,7 @@ which is defined in the `warnings' library.\n") (t (setq p (undo-tree-node-next node)) ;; compute left-width - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf lwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2086,7 +2090,7 @@ which is defined in the `warnings' library.\n") ;; centre-width is 0 when number of children is even (setq cwidth 0) ;; compute right-width - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (if (undo-tree-node-lwidth (car p)) (incf rwidth (+ (undo-tree-node-lwidth (car p)) (undo-tree-node-cwidth (car p)) @@ -2748,7 +2752,7 @@ changes within the current region." ;; `buffer-undo-tree' (undo-list-transfer-to-tree) - (dotimes (i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) + (dotimes (_i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) ;; check if at top of undo tree (unless (undo-tree-node-previous (undo-tree-current buffer-undo-tree)) (user-error "No further undo information")) @@ -2857,7 +2861,7 @@ changes within the current region." ;; `buffer-undo-tree' (undo-list-transfer-to-tree) - (dotimes (i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) + (dotimes (_i (or (and (numberp arg) (prefix-numeric-value arg)) 1)) ;; check if at bottom of undo tree (when (null (undo-tree-node-next (undo-tree-current buffer-undo-tree))) (user-error "No further redo information")) @@ -3576,7 +3580,7 @@ signaling an error if file is not found." (car (undo-tree-node-next node))))) (move-marker (setq pos (make-marker)) (point)) (setq n (cons nil (undo-tree-node-next node))) - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (setq n (cdr n)) (when (or (null active-branch) (eq (car n) @@ -3629,7 +3633,7 @@ signaling an error if file is not found." (move-marker pos (point))) ;; right subtrees (move-marker trunk-pos (1+ trunk-pos)) - (dotimes (i (/ num-children 2)) + (dotimes (_i (/ num-children 2)) (setq n (cdr n)) (when (or (null active-branch) (eq (car n) @@ -3684,7 +3688,7 @@ signaling an error if file is not found." (when (characterp str) (setq str (make-string arg str)) (setq arg 1)) - (dotimes (i arg) (insert str)) + (dotimes (_i arg) (insert str)) (setq arg (* arg (length str))) (undo-tree-move-forward arg) ;; make sure mark isn't active, otherwise `backward-delete-char' might @@ -3769,7 +3773,7 @@ signaling an error if file is not found." (undo-tree-move-forward (+ (undo-tree-node-char-rwidth (car n)) (/ undo-tree-visualizer-spacing 2) 1)) - (dotimes (i (- (/ l 2) p 1)) + (dotimes (_i (- (/ l 2) p 1)) (setq n (cdr n)) (undo-tree-move-forward (+ (undo-tree-node-char-lwidth (car n)) @@ -3787,7 +3791,7 @@ signaling an error if file is not found." (+ (undo-tree-node-char-rwidth (car n)) (/ undo-tree-visualizer-spacing 2) 1)) (setq n (cdr n))) - (dotimes (i (- p (/ l 2) (mod l 2))) + (dotimes (_i (- p (/ l 2) (mod l 2))) (undo-tree-move-backward (+ (undo-tree-node-char-lwidth (car n)) (undo-tree-node-char-rwidth (car n)) @@ -3801,13 +3805,13 @@ signaling an error if file is not found." (defun undo-tree-timestamp-to-string - (timestamp &optional relative current register) + (timestamp &optional relative current register) ;; Convert TIMESTAMP to string (either absolute or RELATVE time), indicating ;; if it's the CURRENT node and/or has an associated REGISTER. (if relative ;; relative time (let ((time (floor (float-time - (subtract-time (current-time) timestamp)))) + (time-subtract (current-time) timestamp)))) n) (setq time ;; years @@ -4232,7 +4236,7 @@ specifies `saved', and a negative prefix argument specifies (user-error "Undo-tree mode not enabled in buffer")) (let ((node undo-tree-visualizer-selected-node)) (catch 'top - (dotimes (i (or arg 1)) + (dotimes (_i (or arg 1)) (unless (undo-tree-node-previous node) (throw 'top t)) (setq node (undo-tree-node-previous node)))) ;; when using lazy drawing, extend tree upwards as required @@ -4254,7 +4258,7 @@ specifies `saved', and a negative prefix argument specifies (user-error "Undo-tree mode not enabled in buffer")) (let ((node undo-tree-visualizer-selected-node)) (catch 'bottom - (dotimes (i (or arg 1)) + (dotimes (_i (or arg 1)) (unless (nth (undo-tree-node-branch node) (undo-tree-node-next node)) (throw 'bottom t)) (setq node @@ -4281,7 +4285,7 @@ specifies `saved', and a negative prefix argument specifies (goto-char (undo-tree-node-marker undo-tree-visualizer-selected-node)) (setq end (line-end-position)) (catch 'end - (dotimes (i arg) + (dotimes (_i arg) (while (or (null node) (eq node undo-tree-visualizer-selected-node)) (forward-char) (setq node (get-text-property (point) 'undo-tree-node)) @@ -4304,7 +4308,7 @@ specifies `saved', and a negative prefix argument specifies (goto-char (undo-tree-node-marker undo-tree-visualizer-selected-node)) (setq beg (line-beginning-position)) (catch 'beg - (dotimes (i arg) + (dotimes (_i arg) (while (or (null node) (eq node undo-tree-visualizer-selected-node)) (backward-char) (setq node (get-text-property (point) 'undo-tree-node)) -- 2.16.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 26 09:01:37 2018 Received: (at control) by debbugs.gnu.org; 26 Jan 2018 14:01:38 +0000 Received: from localhost ([127.0.0.1]:43225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef4ZV-00065X-Pn for submit@debbugs.gnu.org; Fri, 26 Jan 2018 09:01:37 -0500 Received: from mail-it0-f51.google.com ([209.85.214.51]:38156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef4ZU-00065L-5f for control@debbugs.gnu.org; Fri, 26 Jan 2018 09:01:36 -0500 Received: by mail-it0-f51.google.com with SMTP id w14so1788414itc.3 for ; Fri, 26 Jan 2018 06:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=/rUj7ALrsm8RWMhbmLO2NBX7efqrx2p2j/FF+MTfQWU=; b=ebPvQdvcmse2p7t2ZQ2TUhzwwhz0H0v0r+ODgzVyFYv3WzxWWR0FXm+LreEpmfysxV RXwMK99pVHXHBpeyQwvu2fN+AYqfxbT9Dp9XFdSXx4RUsVU3qOhlXrOuogBTkdN9Fs+D 5jRzb4DrBmq7waT/kboloaU11Po2eS6Cqh02okfBDDorhB1yf/4M5rxL+L+bATtKfdjR dvqEezEc1MHHMjONPJrL4J6BzCpSDyke0ECH0fgtcUIcUyMYzoGoeLXbFGAAJuIcyezl vSz7JnSDeYpoJE9TR0ZsNJWLme0uSjxs6cfWA9gJEeD7KKc5DGVf3A+VqQXj0kdC1QEu dDWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=/rUj7ALrsm8RWMhbmLO2NBX7efqrx2p2j/FF+MTfQWU=; b=jMtbAE1SUvvm55vlU5LQv7uRtkeEyYq7iTSxnDFJ7nvlLRRpjy28J1SjrDqCEW76W8 CzwDwDrYRkoF61Jl1EYwwFNMEbapOGUVsZehY/SiO1iczgMvMRybMdRedMQbwHuxbKa2 CF1kXHFLhmN1OKJeieiSXojCmJgqwHI0+mr1TZVCmRdXAF37j37hwpOZ7UV8OrTNTXh0 RE/0NirMo1pEWWfJK/qQgDxuhtO7jEnw0zsBI/EZB+oCHoxkcfz6QBGqI5uEAg11il2p 6XVAmlCz45Avtv3yjVDUfJjEYPgt2FmHsMTGuizRfHNSjjGKbLS0vIVpc29fw6zKnovj e9/A== X-Gm-Message-State: AKwxytcDWjoRrFIedtE9NBPGBngmBE9iEW10HgodVfoFnr/z2hjw9//8 b9QcG5+ZurVPBJnCOmTsNWk61Q== X-Google-Smtp-Source: AH8x226tk5zHwnU8kJV5HjB3brzb+5AqiH/TJw3tf/YQnYBm2QPIVB68cRwxURReh9N0H7jFOK895w== X-Received: by 10.36.176.8 with SMTP id d8mr12321334itf.63.1516975290003; Fri, 26 Jan 2018 06:01:30 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v11sm2237100itf.6.2018.01.26.06.01.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 06:01:28 -0800 (PST) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #30235 Date: Fri, 26 Jan 2018 09:01:26 -0500 Message-ID: <87bmhgn2h5.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) severity 24354 minor merge 30235 24354 quit From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 11:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 30235@debbugs.gnu.org, 24354@debbugs.gnu.org Received: via spool by 30235-submit@debbugs.gnu.org id=B30235.156146348132313 (code B ref 30235); Tue, 25 Jun 2019 11:52:02 +0000 Received: (at 30235) by debbugs.gnu.org; 25 Jun 2019 11:51:21 +0000 Received: from localhost ([127.0.0.1]:58792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjyr-0008P2-Cv for submit@debbugs.gnu.org; Tue, 25 Jun 2019 07:51:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjyo-0008Oo-KT; Tue, 25 Jun 2019 07:51:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfjyk-0007fv-6R; Tue, 25 Jun 2019 13:51:16 +0200 From: Lars Ingebrigtsen References: <87y3ko9nbr.fsf@gmail.com> Date: Tue, 25 Jun 2019 13:51:14 +0200 In-Reply-To: <87y3ko9nbr.fsf@gmail.com> (Alex Branham's message of "Tue, 23 Jan 2018 17:18:00 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Branham writes: > I'm not sure if this is the right place to submit patches for ELPA > packages, but I couldn't find anywhere else to go. Let me know if this > should go some place else. > > This patch silences sever [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > I'm not sure if this is the right place to submit patches for ELPA > packages, but I couldn't find anywhere else to go. Let me know if this > should go some place else. > > This patch silences several byte compiler warnings, mostly having to do > with unused lexical variables in loops. The unused dolist fixes look OK, but they could also be rewritten as (cl-loop repeat ... do ...) to avoid the binding altogether. The other changes (time-subtract/subtract-time) I'm not so sure about, because ELPA things are supposed to work across a large number of Emacs versions, and time-subtract is newer than subtract-time. The same with the other obsolete functions -- you're bound to get those warnings in ELPA packages. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Alex Branham , 30235@debbugs.gnu.org Received: via spool by 30235-submit@debbugs.gnu.org id=B30235.156146954518268 (code B ref 30235); Tue, 25 Jun 2019 13:33:02 +0000 Received: (at 30235) by debbugs.gnu.org; 25 Jun 2019 13:32:25 +0000 Received: from localhost ([127.0.0.1]:58954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflYe-0004kZ-Mx for submit@debbugs.gnu.org; Tue, 25 Jun 2019 09:32:24 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflYc-0004kH-8D for 30235@debbugs.gnu.org; Tue, 25 Jun 2019 09:32:23 -0400 Received: by mail-ed1-f65.google.com with SMTP id e3so27118125edr.10 for <30235@debbugs.gnu.org>; Tue, 25 Jun 2019 06:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RMy0IWnuqAv0VtiqOGRAer8KBiGxVBuB2yy3aLuEp2k=; b=x+WXPquEjJOUwYjN/M++sKd2SExJS09PPoZPCC2GT5kv+EhbY9uTcCogzzV+AlSgkM 5mBWfcoHZs+HxbLF9W4Y54KNvBhADfn0k349jpKs5zlJQEAlsc8Cj6IP5nE7KNwlbhiP 5hBH0p+6tzLY3brz62eKoRTYouww+xam4d1/uyS7dPYza7r8kqEG08J2JXeDfOR7tcb6 jWiXPiOrkaaX77IQQITTlr+NW1c/dzYC0J/EzYm2fYI2ZrUnk0x34Yxt1W/gOnzhbtq5 rkVr1hHCzTGhXpNbRRVOvvj2EYT7uyNSsomIKSao+JPC8FvxgGHV3+v9R+FYN8dghnkm rGrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RMy0IWnuqAv0VtiqOGRAer8KBiGxVBuB2yy3aLuEp2k=; b=gGetA7GDKSkhM4BnYZ6kmeby9n96b6Ontw8zw5eTDQ87CsTwIkwdHz2nudKKZ2lAAk AKYlrCHJxIeFFtrkJ7xGwllyW5j5dNPkYy3Rx03Hntzy3FuGRoRUMr55fSVSKIIQxr6A bTz9I5LQovqFFoL2yPWh/pZ8LDYMtcTSa1q9NRH7RP4uxlZPLChgZEr1OcSWYiwrIAQL Wu9xgDLPJi0+AmBVOpEXtVpivVWAFbKTPE4W2351K9b53ztO9PUx9ZknTBEnYoM0ofJA WFtF/TgLWRpSNblJdonFw4FaCS2Z2MdMJIfTaAbV+NfT859YWjzDWV627I3j31Ld3PqU EXbw== X-Gm-Message-State: APjAAAWTO6JRPijS7lXPex2lweQWXroChiqVP3CVo3EXx2hXCUTkq9mt RqgeZ4i0dvgUkQUsfIuJ1lKcQA== X-Google-Smtp-Source: APXvYqzAACRpkjQ7zFMGHHC4K+N4yLMc1O2WFZB5HM3O8FzVOWIGuLY/eT2LL68EfhbkOIYd3deY7w== X-Received: by 2002:a50:fa96:: with SMTP id w22mr72987003edr.45.1561469536418; Tue, 25 Jun 2019 06:32:16 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id 17sm2034579ejo.3.2019.06.25.06.32.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 25 Jun 2019 06:32:15 -0700 (PDT) From: "Basil L. Contovounesios" References: <87y3ko9nbr.fsf@gmail.com> Date: Tue, 25 Jun 2019 14:32:14 +0100 In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 25 Jun 2019 13:51:14 +0200") Message-ID: <87lfxp6ba9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Alex Branham writes: > >> I'm not sure if this is the right place to submit patches for ELPA >> packages, but I couldn't find anywhere else to go. Let me know if this >> should go some place else. >> >> This patch silences several byte compiler warnings, mostly having to do >> with unused lexical variables in loops. > > The unused dolist fixes look OK, but they could also be rewritten as > > (cl-loop repeat ... > do ...) > > to avoid the binding altogether. There's really no need to completely rewrite all those dotimes in terms of cl-loop. Writing (dotimes (_ ...) ...) is quite common and fine. > The other changes (time-subtract/subtract-time) I'm not so sure about, > because ELPA things are supposed to work across a large number of Emacs > versions, and time-subtract is newer than subtract-time. Sure, but subtract-time has been called time-subtract for almost two decades now[1]. [1: 74fcda73dd]: Add autoload cookies. Many doc fixes. 2002-01-27 23:30:29 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=74fcda73dd8743f66256aa5fdaff6260dc356c54 > The same with the other obsolete functions -- you're bound to get those > warnings in ELPA packages. Sure, but often a compatibility shim can go a long way, and in this case the question is why was undo-elt-crosses-region obsoleted as part of bug#17235, and what should undo-tree.el do in future Emacs versions. Maybe Barry, Toby, or Stefan should be CCed in this or a new discussion about it, seeing as Jonas' concerns were never addressed, AFAICT. Thanks, -- Basil From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Basil L. Contovounesios" Cc: Alex Branham , 30235@debbugs.gnu.org Received: via spool by 30235-submit@debbugs.gnu.org id=B30235.156146970418524 (code B ref 30235); Tue, 25 Jun 2019 13:36:02 +0000 Received: (at 30235) by debbugs.gnu.org; 25 Jun 2019 13:35:04 +0000 Received: from localhost ([127.0.0.1]:58962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflbE-0004oi-FN for submit@debbugs.gnu.org; Tue, 25 Jun 2019 09:35:04 -0400 Received: from quimby.gnus.org ([80.91.231.51]:49194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflbC-0004oM-5H for 30235@debbugs.gnu.org; Tue, 25 Jun 2019 09:35:02 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hflb8-0000JJ-JT; Tue, 25 Jun 2019 15:35:00 +0200 From: Lars Ingebrigtsen References: <87y3ko9nbr.fsf@gmail.com> <87lfxp6ba9.fsf@tcd.ie> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEXAu61AWH7g0abj1awp Q2kSEhfl2bFkb4WPkpjx68/QWlioAAACY0lEQVQ4jVWUTWvjMBCGp1lwlFsFXpzj4ly6t2KD7wGF /oGEXg0GUd8aNiDvTS5LNb3lFPC/3VeSlaRDcBI9ejWaL1Ndl8mY069NuSFdV/M/Z+N37a0i3c0S XpQ30NTUzAp3PbHc1LXuyBhmpvLeAJqOFOwA26vBsF2k0zrayoGP6s+zcOMubHgxYQMVhmmpPjpd scmDNhqZwTZv6sem+sXuO2Dbv/mrnglH3ggNTFNLi8XvqRVGqt0N2GzSuiQG8JJEiG12yfrnB/XV krg7DKAnolGpNb6Ek/msoXfq34RElNvCQmKMjHejApcacx+/evGEcesA1JCJJUCu8q3NiCwlIIsj IlNSrp3VGo4SUFspA/iaYLpvrwAGIosp2gV3TgCaWQAJEpDvZuDXZR/3Cx5Dlj2QgwWIgtaZcfsz Oe8nx+soICYX0oIKyjUcLh/jOgCH0Ek6uV7hBPi+eIFjlsE5LwvzdzqT35+FZPmPQgWtmFZzBFh3 oZ34dKDRTskuPv8FWyZhDOpxBefP6XL0ZQE4IptpvRWry1IO7wBwg76aJe1g+/NoDAA8ScRRZDoA LInVWeLpUHof4LuOdSDKpvbhUThfdxRKFugtwUTgLdGnOKmYXemRsbRCmMgI0Wm/OyiaqyHXvvFa Mfjotnkuab+PBSlspoVPlRl3r0fEkXrVz4UsiuFJHHc4RFHlE3dKjfn6L/Uo6Ubrzs9nzOBtDLQ3 TK4QH3H+/AnokwhKtOY8mH7K8WYoZ3BbbTQemzqATodtGPDGO2xq/06ICl1WZQUYHd6DLj6beJP6 6uOb1VW1qcr/8jdZH6A2jWcAAAAASUVORK5CYII= Date: Tue, 25 Jun 2019 15:34:58 +0200 In-Reply-To: <87lfxp6ba9.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 25 Jun 2019 14:32:14 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > Sure, but subtract-time has been called time-subtract for almost two > decades now[1]. That sounds safe, then. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Sure, but subtract-time has been called time-subtract for almost two > decades now[1]. That sounds safe, then. :-) > Maybe Barry, Toby, or Stefan should be CCed in this or a new discussion > about it, seeing as Jonas' concerns were never addressed, AFAICT. Sure; go ahead and poke them about it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: Richard Stallman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 03:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: alex.branham@gmail.com, 30235@debbugs.gnu.org, 24354@debbugs.gnu.org Reply-To: rms@gnu.org Received: via spool by 30235-submit@debbugs.gnu.org id=B30235.156151948221838 (code B ref 30235); Wed, 26 Jun 2019 03:25:02 +0000 Received: (at 30235) by debbugs.gnu.org; 26 Jun 2019 03:24:42 +0000 Received: from localhost ([127.0.0.1]:34043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfyY6-0005g8-1v for submit@debbugs.gnu.org; Tue, 25 Jun 2019 23:24:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfyY4-0005fr-8X; Tue, 25 Jun 2019 23:24:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hfyXx-0007nc-Ot; Tue, 25 Jun 2019 23:24:35 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hfyXw-00012n-OS; Tue, 25 Jun 2019 23:24:32 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman In-Reply-To: (message from Lars Ingebrigtsen on Tue, 25 Jun 2019 13:51:14 +0200) References: <87y3ko9nbr.fsf@gmail.com> Message-Id: Date: Tue, 25 Jun 2019 23:24:32 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > The unused dolist fixes look OK, but they could also be rewritten as > (cl-loop repeat ... > do ...) > to avoid the binding altogether. Warnings are meant to be our helpers, not our masters. We should not get in the habit of jumping through hoops to satisfy a demanding, rigid program. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Sep 2019 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 30235@debbugs.gnu.org, toby-undo-tree@dr-qubit.org Received: via spool by 30235-submit@debbugs.gnu.org id=B30235.156872395131403 (code B ref 30235); Tue, 17 Sep 2019 12:40:01 +0000 Received: (at 30235) by debbugs.gnu.org; 17 Sep 2019 12:39:11 +0000 Received: from localhost ([127.0.0.1]:51802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAClD-0008AR-8v for submit@debbugs.gnu.org; Tue, 17 Sep 2019 08:39:11 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAClB-0008AJ-R5 for 30235@debbugs.gnu.org; Tue, 17 Sep 2019 08:39:10 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iACl7-0000Gl-3S; Tue, 17 Sep 2019 14:39:07 +0200 From: Lars Ingebrigtsen References: <87y3ko9nbr.fsf@gmail.com> Date: Tue, 17 Sep 2019 14:39:04 +0200 In-Reply-To: <87y3ko9nbr.fsf@gmail.com> (Alex Branham's message of "Tue, 23 Jan 2018 17:18:00 -0600") Message-ID: <877e67m713.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Branham writes: > - (dotimes (i arg) > + (dotimes (_i arg) Jonas said: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > - (dotimes (i arg) > + (dotimes (_i arg) Jonas said: > Toby, I am aware that I have suggested before that you use `_' as VAR in > calls to `dotimes' instead of `i'. You rejected that suggestion, > claiming that the byte-compiler complaining about `i' not being used is > a bug. While my preference is to avoid compiler warnings (because having a warning-free build allows anybody working on the code to proceed with greater speed and confidence), I think that for ELPA code this should be up to the maintainer. Since it seems like Toby is opposed to these changes, I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 08:39:21 2019 Received: (at control) by debbugs.gnu.org; 17 Sep 2019 12:39:21 +0000 Received: from localhost ([127.0.0.1]:51805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAClM-0008Ar-Ia for submit@debbugs.gnu.org; Tue, 17 Sep 2019 08:39:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAClL-0008Ak-82 for control@debbugs.gnu.org; Tue, 17 Sep 2019 08:39:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAClG-0000Gu-HS for control@debbugs.gnu.org; Tue, 17 Sep 2019 14:39:16 +0200 Date: Tue, 17 Sep 2019 14:39:14 +0200 Message-Id: <875zlrm70t.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #30235 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 30235 wontfix close 30235 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30235 wontfix close 30235 quit From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: Toby Cubitt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Sep 2019 11:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch wontfix To: Lars Ingebrigtsen , Alex Branham Cc: 30235@debbugs.gnu.org, toby-undo-tree@dr-qubit.org Received: via spool by 30235-submit@debbugs.gnu.org id=B30235.156880752628866 (code B ref 30235); Wed, 18 Sep 2019 11:53:01 +0000 Received: (at 30235) by debbugs.gnu.org; 18 Sep 2019 11:52:06 +0000 Received: from localhost ([127.0.0.1]:53689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAYVB-0007VW-Nq for submit@debbugs.gnu.org; Wed, 18 Sep 2019 07:52:06 -0400 Received: from starfish.geekisp.com ([216.168.135.166]:3350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAYVA-0007V0-K5 for 30235@debbugs.gnu.org; Wed, 18 Sep 2019 07:52:05 -0400 Received: (qmail 16803 invoked by uid 1003); 18 Sep 2019 11:51:58 -0000 Received: from [IPv6:2a01:4c8:103f:4e68:1:2:95a2:b41f] (localhost.geekisp.com [127.0.0.1]) by localhost.geekisp.com (tmda-ofmipd) with ESMTP; Wed, 18 Sep 2019 07:51:51 -0400 Date: Wed, 18 Sep 2019 12:51:46 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <877e67m713.fsf@gnus.org> References: <87y3ko9nbr.fsf@gmail.com> <877e67m713.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: X-Delivery-Agent: TMDA/1.1.11 (Ladyburn) From: Toby Cubitt X-Primary-Address: toby@dr-qubit.org X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Alex, Not opposed to this at all! (I forgot what i said previously, but if I was= then it was before I knew of the _ method=2E) Indeed, I think I already ma= de exactly this change a while back in the undo-tree development repo, but = maybe forgot to transfer this into ELPA=2E Undo-tree went into ELPA before there was support for separate per-package= git repos in ELPA, which is why this isn't automatic=2E It makes upstreami= ng changes from my development repo(s) to ELPA that bit more complicated th= an a simple git push=2E I'm very busy with real life these days, so this in= evitably gets forgotten/postponed=2E Maybe this is a good opportunity to sh= ift all my ELPA packages over to per-package git repos, so I can just make = the ELPA repos upstreams of my package development repos? Best wishes, Toby=20 On 17 September 2019 13:39:04 BST, Lars Ingebrigtsen wr= ote: >Alex Branham writes: > >> - (dotimes (i arg) >> + (dotimes (_i arg) > >Jonas said: > >> Toby, I am aware that I have suggested before that you use `_' as VAR >in >> calls to `dotimes' instead of `i'=2E You rejected that suggestion, >> claiming that the byte-compiler complaining about `i' not being used >is >> a bug=2E > >While my preference is to avoid compiler warnings (because having a >warning-free build allows anybody working on the code to proceed with >greater speed and confidence), I think that for ELPA code this should >be >up to the maintainer=2E Since it seems like Toby is opposed to these >changes, I'm closing this bug report=2E --=20 Dr T=2E S=2E Cubitt Reader (Associate Professor) in Quantum Information Royal Society University Research Fellow Department of Computer Science University College London email: tsc25@cantab=2Enet=20 web: www=2Edr-qubit=2Eorg From unknown Tue Jun 17 01:48:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30235: [patch] undo-tree byte-compiler warnings Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Sep 2019 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch wontfix To: Toby Cubitt Cc: Alex Branham , 30235@debbugs.gnu.org, toby-undo-tree@dr-qubit.org Received: via spool by 30235-submit@debbugs.gnu.org id=B30235.15688148388255 (code B ref 30235); Wed, 18 Sep 2019 13:54:02 +0000 Received: (at 30235) by debbugs.gnu.org; 18 Sep 2019 13:53:58 +0000 Received: from localhost ([127.0.0.1]:53787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaP7-000290-8X for submit@debbugs.gnu.org; Wed, 18 Sep 2019 09:53:58 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaP4-00028r-R1 for 30235@debbugs.gnu.org; Wed, 18 Sep 2019 09:53:55 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAaOz-0002JS-Pw; Wed, 18 Sep 2019 15:53:52 +0200 From: Lars Ingebrigtsen References: <87y3ko9nbr.fsf@gmail.com> <877e67m713.fsf@gnus.org> Date: Wed, 18 Sep 2019 15:53:49 +0200 In-Reply-To: (Toby Cubitt's message of "Wed, 18 Sep 2019 12:51:46 +0100") Message-ID: <878sqllngy.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Toby Cubitt writes: > Not opposed to this at all! (I forgot what i said previously, but if I > was then it was before I knew of the _ method.) Indeed, I think I > already made exactly this change a while back in the undo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Toby Cubitt writes: > Not opposed to this at all! (I forgot what i said previously, but if I > was then it was before I knew of the _ method.) Indeed, I think I > already made exactly this change a while back in the undo-tree > development repo, but maybe forgot to transfer this into ELPA. Oh, OK. :-) > Undo-tree went into ELPA before there was support for separate > per-package git repos in ELPA, which is why this isn't automatic. It > makes upstreaming changes from my development repo(s) to ELPA that bit > more complicated than a simple git push. I'm very busy with real life > these days, so this inevitably gets forgotten/postponed. Maybe this is > a good opportunity to shift all my ELPA packages over to per-package > git repos, so I can just make the ELPA repos upstreams of my package > development repos? Sounds like a good idea. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no