From unknown Sun Aug 17 09:12:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30205 <30205@debbugs.gnu.org> To: bug#30205 <30205@debbugs.gnu.org> Subject: Status: 27.0.50; Minor mode commands enable the minor mode even if the body fails Reply-To: bug#30205 <30205@debbugs.gnu.org> Date: Sun, 17 Aug 2025 16:12:01 +0000 retitle 30205 27.0.50; Minor mode commands enable the minor mode even if th= e body fails reassign 30205 emacs submitter 30205 Philipp Stephani severity 30205 minor tag 30205 wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 22 04:55:12 2018 Received: (at submit) by debbugs.gnu.org; 22 Jan 2018 09:55:12 +0000 Received: from localhost ([127.0.0.1]:37709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edYoo-0004IW-9j for submit@debbugs.gnu.org; Mon, 22 Jan 2018 04:55:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edYom-0004IG-OY for submit@debbugs.gnu.org; Mon, 22 Jan 2018 04:55:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edYog-0001Cl-IH for submit@debbugs.gnu.org; Mon, 22 Jan 2018 04:55:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1edYog-0001Ca-Ef for submit@debbugs.gnu.org; Mon, 22 Jan 2018 04:55:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edYoe-0005QQ-T2 for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 04:55:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edYod-0001A5-Kr for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 04:55:00 -0500 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:35385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edYod-00019Z-EQ for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 04:54:59 -0500 Received: by mail-wr0-x22d.google.com with SMTP id g38so7910058wrd.2 for ; Mon, 22 Jan 2018 01:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=334vd6i32HUEtMFj7DeWdnKy1TBCMhi4buIH/D4V8hU=; b=obTwcyO8jq3/9GEQOdRf4mzBCLe8BgpRdwgyiSDe+D3PCaL5AE2kBIflrm759Eovt7 barcyERFrdb5g6rliw39b0QqoaHn1ARewezDUpw8uqJFradnEoiyF8fO3FjVTycRgsGN eDYOJ1pNexkCk5sEn23Djilm/s1wkC+cndUWfYwgAzAj7u5uNPYBciNv8tY8iSglnvcL 4+6HPTVx3/N6i8PGa9S3o2Bt0Nxke7t/o1JlGdmpWDbs5ZtX575q/VXR6aL2cLz+zuWJ VhJzIfYr2fp7G4xalTGhekQqo/JZHZAVBbYVoDAzmy9sGGdBrS2ckXz14zzMRIG55qoh Zo/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=334vd6i32HUEtMFj7DeWdnKy1TBCMhi4buIH/D4V8hU=; b=EPHVfN0SDfFM09Gi205ifBpsSmCVjkllEc1vuZnGY0oLMqew2mT3+jZhA1/pAUseaE xhThyMRlx3rAS3RfUvzJ+Rii+Kejhtchm7y2UblM1fVB1Um43mgi9W3p8D4iBsOYNSQv TsHKK36ZuvisqQhe+e4jyoepj7puf3k42PXOXptw0pMOO/V/qnZ9a7GQvh2dqNjvKWnk b5atBejlAeZHhyj0BCYHmrEmCAWo5FZvXOJhMDMIIyf3+mW83PwbOHHN2GaofbWtZ9So s0GM5hNIB9RdusgUx6aKsp0sf1wLRb5ZVMeHqnC12ejpAzyNqKdSZHe/W3AD2r0xURny hL5A== X-Gm-Message-State: AKwxytcMRRGnRtTpm5T/Qg2kIpVNsa7HJz/5x5YizsgUvyuCZob4tzdI Rw46lqscVPSHvPze5rCUZ/EQNJNC X-Google-Smtp-Source: AH8x227j4IaO3A76pHnOy9oT4csHp1EGv0rcXKvjJnpL6rbCndXJByuK2Ji29U2Fz/Fuq4qiVItwdw== X-Received: by 10.223.164.146 with SMTP id g18mr5443348wrb.241.1516614898047; Mon, 22 Jan 2018 01:54:58 -0800 (PST) Received: from a.muc.corp.google.com ([2a00:79e0:15:4:bfda:710c:4a38:a674]) by smtp.gmail.com with ESMTPSA id s206sm6143292wme.4.2018.01.22.01.54.57 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 01:54:57 -0800 (PST) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Minor mode commands enable the minor mode even if the body fails Date: Mon, 22 Jan 2018 10:54:56 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) In *scratch*: (define-minor-mode foo-mode nil nil nil nil (error "what")) C-h v foo-mode shows that foo-mode is nil, as it should be. But after M-x foo-mode, it is t, even though the mode command failed. This can be confusing for mode commands that can conditionally fail, e.g. depending on some external property. In GNU Emacs 27.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.24) of 2018-01-22 built on localhost Repository revision: d0fd9809d7574c67a181225fcc1c59afdbb1295c Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Debian GNU/Linux Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --without-threads --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES JSON Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 95245 8904) (symbols 48 20322 1) (miscs 40 41 121) (strings 32 28332 1955) (string-bytes 1 756515) (vectors 16 14131) (vector-slots 8 499256 13524) (floats 8 49 68) (intervals 56 225 0) (buffers 992 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 13:41:06 2019 Received: (at 30205) by debbugs.gnu.org; 14 Jul 2019 17:41:06 +0000 Received: from localhost ([127.0.0.1]:45831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmiUk-00042I-7k for submit@debbugs.gnu.org; Sun, 14 Jul 2019 13:41:06 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmiUi-000429-Cc for 30205@debbugs.gnu.org; Sun, 14 Jul 2019 13:41:04 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmiUe-0004S0-5O; Sun, 14 Jul 2019 19:41:02 +0200 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#30205: 27.0.50; Minor mode commands enable the minor mode even if the body fails References: Date: Sun, 14 Jul 2019 19:40:59 +0200 In-Reply-To: (Philipp Stephani's message of "Mon, 22 Jan 2018 10:54:56 +0100") Message-ID: <87muhgy0no.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > In *scratch*: > > (define-minor-mode foo-mode nil nil nil nil (error "what")) > > C-h v foo-mode shows that foo-mode is nil, as it should be. > But after M-x foo-mode, it is t, even though the mode [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30205 Cc: 30205@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp Stephani writes: > In *scratch*: > > (define-minor-mode foo-mode nil nil nil nil (error "what")) > > C-h v foo-mode shows that foo-mode is nil, as it should be. > But after M-x foo-mode, it is t, even though the mode command failed. > This can be confusing for mode commands that can conditionally fail, > e.g. depending on some external property. Hm... OK, this is the function run when saying M-x foo-mode: (defun ,modefun (&optional arg ,@extra-args) ,(easy-mmode--mode-docstring doc pretty-name keymap-sym) ;; Use `toggle' rather than (if ,mode 0 1) so that using ;; repeat-command still does the toggling correctly. (interactive (list (or current-prefix-arg 'toggle))) (let ((,last-message (current-message))) (,@setter (if (eq arg 'toggle) (not ,getter) ;; A nil argument also means ON now. (> (prefix-numeric-value arg) 0))) ,@body ;; The on/off hooks are here for backward compatibility only. (run-hooks ',hook (if ,getter ',hook-on ',hook-off)) So `setter' is the thing that sets the mode variable, and then body is run. I agree with you that it would be better that the mode variable remains unchanged if `body' fails. But I `body' is likely to need to have that set to work. We could roll back the value to the previous value on errors? Hm. On the other hand, if `body' has done most of the stuff it needs to do and fails "late" in the process, then the mode will be in effect even if it failed, and in that case it would be wrong to roll back. So I don't know. Does anybody have an opinion? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 18 18:37:09 2019 Received: (at 30205) by debbugs.gnu.org; 18 Jul 2019 22:37:10 +0000 Received: from localhost ([127.0.0.1]:54785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoF1R-0002Yf-Al for submit@debbugs.gnu.org; Thu, 18 Jul 2019 18:37:09 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoF1P-0002Xx-LT for 30205@debbugs.gnu.org; Thu, 18 Jul 2019 18:37:08 -0400 Received: by mail-wr1-f67.google.com with SMTP id x4so30285852wrt.6 for <30205@debbugs.gnu.org>; Thu, 18 Jul 2019 15:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wxJG5hJ6y+hUlb6ycAus1ap6a8qEp8dtsNly8Ii+8ag=; b=H5Qgy296RFVCgEnGW9Fwph0kUVDad//aPjh9Ga/zv2Lzk7jrijYGkCuor2/x9JbWvT R0pVbvg3PpVfq6nWNFabQbZJfCZrSCEiLfKd+Cj5fMuHDv3KKrjnFT7zGhSD5QpSQlfH +h71XQ6WZyWgth+lmKHcqrFCJWLslEL7yw4PhPE18I2SQ6sXwYz4WBHjn2Ugoheg1qac VhbDvSRFnAsm6snPVUWIv02TochctPbFCXD1u2oAFDo/kSzLhhL4ud3wCU6dkCGT3WVN VOCRTeKzcqqKgI/S3W1d1fiiqodmewYJJMs3FS02h143T0tOCV5gQOA+6fvW2BI/llao h7dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wxJG5hJ6y+hUlb6ycAus1ap6a8qEp8dtsNly8Ii+8ag=; b=sB2ZuPs7iImDEeqyA2yX4+HQkZUrSxGRY1ifDZr9fvgDScFE+U3I353T1g1IDE4ljB BiF+Y0mEK+QHXhXy292lSwa9QY0VP3G+WPWYpJGxNF40iIg7F4Y7qNRpb3m2EcwAB+UG uXn7bfQYKUlIj0OnAFs36pSmjOBLeCLVAqVs6We+tXEJUNBJYq6EQJPUylIiamBKe93m Otm/Ol9Wo/exuAq+bflu4x64pl0gWyJyt8buoAPWkmjB+T/qrvrZAG0h+BHI25Fo8FKX vJuUSwdE8Mr1YFmFDkrM+lk+ZWtp0NGLskrJZ0WBBweJC34D/MzggTAt2ktLZZb/J0zC 0P3A== X-Gm-Message-State: APjAAAWJjTWSFACMtUFGyBKngkhV/Kd/PHeZ3bIJ5N+cZbBfC3XjxKEr yraHdo1c2xZF4aHPTk8dWArEr/1wqIw= X-Google-Smtp-Source: APXvYqwo/XphJUGy6GxTzKi8qEcDX6RfD3jm+gvhSCMZ1qXWrNv2i79DmIJ9w5bma2RpUi3n6ZpbCQ== X-Received: by 2002:adf:afe2:: with SMTP id y34mr50316230wrd.250.1563486018244; Thu, 18 Jul 2019 14:40:18 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id m7sm23523400wrx.65.2019.07.18.14.40.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 14:40:17 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#30205: 27.0.50; Minor mode commands enable the minor mode even if the body fails References: <87muhgy0no.fsf@mouse.gnus.org> Date: Thu, 18 Jul 2019 22:40:11 +0100 In-Reply-To: <87muhgy0no.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sun, 14 Jul 2019 19:40:59 +0200") Message-ID: <87lfwvyqbo.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30205 Cc: Philipp Stephani , 30205@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Philipp Stephani writes: > >> In *scratch*: >> >> (define-minor-mode foo-mode nil nil nil nil (error "what")) >> >> C-h v foo-mode shows that foo-mode is nil, as it should be. >> But after M-x foo-mode, it is t, even though the mode command failed. >> This can be confusing for mode commands that can conditionally fail, >> e.g. depending on some external property. > > Hm... OK, this is the function run when saying M-x foo-mode: > > (defun ,modefun (&optional arg ,@extra-args) > ,(easy-mmode--mode-docstring doc pretty-name keymap-sym) > ;; Use `toggle' rather than (if ,mode 0 1) so that using > ;; repeat-command still does the toggling correctly. > (interactive (list (or current-prefix-arg 'toggle))) > (let ((,last-message (current-message))) > (,@setter > (if (eq arg 'toggle) > (not ,getter) > ;; A nil argument also means ON now. > (> (prefix-numeric-value arg) 0))) > ,@body > ;; The on/off hooks are here for backward compatibility only. > (run-hooks ',hook (if ,getter ',hook-on ',hook-off)) > > So `setter' is the thing that sets the mode variable, and then body is > run. > > I agree with you that it would be better that the mode variable remains > unchanged if `body' fails. But I `body' is likely to need to have that > set to work. We could roll back the value to the previous value on > errors? > > Hm. On the other hand, if `body' has done most of the stuff it needs to > do and fails "late" in the process, then the mode will be in effect even > if it failed, and in that case it would be wrong to roll back. > > So I don't know. Does anybody have an opinion? Unless we can provide a way to roll back the entire mode function "transaction", I would regard errors in mode functions as UB and the real bug here. In other words, I don't see any benefit to using the mode variable as an indicator of success, when mode functions shouldn't fail to begin with. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 19 09:25:23 2019 Received: (at 30205) by debbugs.gnu.org; 19 Jul 2019 13:25:23 +0000 Received: from localhost ([127.0.0.1]:55378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoSt1-0000P1-3u for submit@debbugs.gnu.org; Fri, 19 Jul 2019 09:25:23 -0400 Received: from quimby.gnus.org ([80.91.231.51]:53344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoSsz-0000Ot-E4 for 30205@debbugs.gnu.org; Fri, 19 Jul 2019 09:25:21 -0400 Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hoSsu-0007uh-SP; Fri, 19 Jul 2019 15:25:19 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#30205: 27.0.50; Minor mode commands enable the minor mode even if the body fails References: <87muhgy0no.fsf@mouse.gnus.org> <87lfwvyqbo.fsf@tcd.ie> Date: Fri, 19 Jul 2019 15:25:16 +0200 In-Reply-To: <87lfwvyqbo.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 18 Jul 2019 22:40:11 +0100") Message-ID: <8736j288cj.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > Unless we can provide a way to roll back the entire mode function > "transaction", I would regard errors in mode functions as UB and the > real bug here. In other words, I don't see any benefit to u [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30205 Cc: Philipp Stephani , 30205@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Unless we can provide a way to roll back the entire mode function > "transaction", I would regard errors in mode functions as UB and the > real bug here. In other words, I don't see any benefit to using the > mode variable as an indicator of success, when mode functions shouldn't > fail to begin with. I agree, and am closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 19 09:25:32 2019 Received: (at control) by debbugs.gnu.org; 19 Jul 2019 13:25:32 +0000 Received: from localhost ([127.0.0.1]:55381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoStA-0000PT-B1 for submit@debbugs.gnu.org; Fri, 19 Jul 2019 09:25:32 -0400 Received: from quimby.gnus.org ([80.91.231.51]:53360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoSt9-0000PK-4k for control@debbugs.gnu.org; Fri, 19 Jul 2019 09:25:31 -0400 Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hoSt6-0007xe-HW for control@debbugs.gnu.org; Fri, 19 Jul 2019 15:25:30 +0200 Date: Fri, 19 Jul 2019 15:25:27 +0200 Message-Id: <871rym88c8.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #30205 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 30205 wontfix close 30205 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30205 wontfix close 30205 quit From unknown Sun Aug 17 09:12:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Aug 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator