GNU bug report logs - #30198
26.0.91; [PATCH] Fix emacs-module-tests to work with out of tree build directory

Previous Next

Full log

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Moreton <andrewjmoreton <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#30198: 26.0.91;
 Fix emacs-module-tests to work with out of tree build directory
Date: Fri, 26 Jan 2018 13:58:04 +0000

On Fri 26 Jan 2018, Eli Zaretskii wrote:

>> From: Andy Moreton <andrewjmoreton <at> gmail.com>
>> Date: Sun, 21 Jan 2018 18:44:16 +0000
>> 
>> Currently the emacs module tests fail to build when using an out of tree
>> build directory. The following patch moves the location of the module
>> library mod-test.{so,dll} from test/data/emacs-module to
>> <builddir>/test/data/emacs-module, as build outputs do not belong in the
>> source tree. It also fixes the test module build to find the module header
>> at the correct lcoation, namely <builddir>/src/emacs-module.h.
>> 
>> Tested on Windows with the mingw64-x86_64 toolchain (msys2) for both
>> both in-tree and out-of-tree build directories:
>
> Thanks, pushed to the master branch.
>
> (Note that your mailer caused the patch fail to apply due to changes
> in whitespace.)

Thanks. This also applies cleanly (and works) on emacs-26, if you feel
that it is not too disruptive for the release branch.

    AndyM

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.