Subject: Re: [bug#30194] [PATCH 1/6] gnu: Add emacs-seq.

From: Nicolas Goaziou <[email-masked]>
Date: Sun, 21 Jan 2018 19:12:33 +0100

Hello,

Ricardo Wurmus <[email-masked]> writes:

> * gnu/packages/emacs.scm (emacs-seq): New variable.
> ---
>  gnu/packages/emacs.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 0c3d5139a..cbe1ac6f7 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -6465,6 +6465,27 @@ proficiency is an advantage, since you can transform your numeric range with
>  an elisp expression.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-seq

OOC, is there a need for this since it already ships with the Emacs Guix
provides? I thought it was some backward compatibility library.

> +  (package
> +    (name "emacs-seq")
> +    (version "2.20")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://elpa.gnu.org/packages/seq-"
> +                           version ".tar"))
> +       (sha256
> +        (base32
> +         "0vrpx6nnyjb0gsypknzagimlhvcvi5y1rcdkpxyqr42415zr8d0n"))))
> +    (build-system emacs-build-system)
> +    (home-page "http://elpa.gnu.org/packages/seq.html")
> +    (synopsis "Sequence manipulation functions")
> +    (description "This Emacs package provides sequence-manipulation functions
> +that complement basic functions provided by @code{subr.el}.  All functions are

Nitpick: @file{subr.el}

> +prefixed with @code{seq-}.

Nitpick: @samp{seq-}

Regards,

-- 
Nicolas Goaziou                                                0x80A93738