From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 07:16:45 2018 Received: (at submit) by debbugs.gnu.org; 21 Jan 2018 12:16:45 +0000 Received: from localhost ([127.0.0.1]:36587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edEYH-0007ag-D1 for submit@debbugs.gnu.org; Sun, 21 Jan 2018 07:16:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edEYG-0007aR-45 for submit@debbugs.gnu.org; Sun, 21 Jan 2018 07:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edEY9-0007UU-LQ for submit@debbugs.gnu.org; Sun, 21 Jan 2018 07:16:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54781) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1edEY9-0007UQ-Hf for submit@debbugs.gnu.org; Sun, 21 Jan 2018 07:16:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edEY8-0003TC-8m for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2018 07:16:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edEY5-0007Pm-0f for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2018 07:16:36 -0500 Received: from mail-pg0-x234.google.com ([2607:f8b0:400e:c05::234]:32843) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edEY4-0007Oj-PC for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2018 07:16:32 -0500 Received: by mail-pg0-x234.google.com with SMTP id u1so4917896pgr.0 for ; Sun, 21 Jan 2018 04:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=biwe6UGzwzAa5o0e4jLmqfF4Wwbbxq7CaU0E7l6Mc+Y=; b=SU52MpkwlGKCQglJQ+8mUpFa17Zm9ossZt2pwrlvEiijfK6Gesfq68UaplJ+y8R3Yz S9ebCxRz7VAA8+ZbQY8smkgYegP/rzBD07kZpEDQqaiKK2jKAuBAuXQwXErPiBFWlgc0 Es+iR8YxRLZJgD5i+TxA4mxashjy/U1XIwSmHzjmU4q0QQK04mveE+lwken3Zw6oZ8TB 0aUKihV/SNNQ6XjdHQCoXgq1iRcKKHK3/9tZUWnOw8LM2WhV32OfYs2+CB29gvTt/476 7ijkQ4HMfkrxotdFQHBhEmBOv5oj8PqLELKZ1aaKgculOZ4LsUv/g7XDje4X47gW/iHh YLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=biwe6UGzwzAa5o0e4jLmqfF4Wwbbxq7CaU0E7l6Mc+Y=; b=dUegJTgk/kJGlNCvCMDMekkGRPN/iFwiRpzQVuGMtw8HD0p3+vQ1/dxqw3CDxARlms hg2pFoXvSRq4OJ8Vxl5yNwLfvAqAIy0dA8x9GKc2vSyBuTK3Qg20ReZ33akfQ1Wiclyq kVgywykXYplqbWje1b+263QmZZvQsVVc3s2ZXxWT1b1+b+WynacyztME/4K4JxUHHC3n GD9TukLcSwuA+0ZEgSn8jy5hTi+Y8QKqm4hZj8Lag8aVdcBuHB3HKKiPWpMoZ0rmyRWa AlBjbdXuJUHXJsCffUsRh0m2CSw0K3YdAjSvDSwfS2c+rZKM/fLAFxTw7eohLrVvs1Cj XfKQ== X-Gm-Message-State: AKwxytc4B88HlEhvj8fght3ImCNUxgDxeP1q239N7w7QetFlbTKwyIhL WZ/48mXsbBneKbNVH5C+pPpkEQ== X-Google-Smtp-Source: AH8x224j39GC5wYwcA6Pn5G/MjlPyyBSxkAUi4FhsJ7lS6UYGmC60IVdd/SBaQgsRqipXGoy8PhZgw== X-Received: by 10.98.54.71 with SMTP id d68mr5080146pfa.173.1516536991513; Sun, 21 Jan 2018 04:16:31 -0800 (PST) Received: from calancha-pc (155.7.236.133.dy.bbexcite.jp. [133.236.7.155]) by smtp.gmail.com with ESMTPSA id p14sm20104122pgu.7.2018.01.21.04.16.17 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Jan 2018 04:16:18 -0800 (PST) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 27.0.50; term run in line mode shows user passwords Date: Sun, 21 Jan 2018 21:16:07 +0900 Message-ID: <87r2qjh0fs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. Start a new terminal emulator in line mode. M-x term RET C-c C-j 2. run a command that prompt for user's password (e.g., 'sudo ls' or 'git push'); the user password visible. * If you run the terminal in char modem then the password is not shown. * If you run a dumb shell instead, then the password is read from the minibuffer with `send-invisible', thereby the password is not shown. In GNU Emacs 27.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-01-21 built on calancha-pc Repository revision: 64c846738617d1d037eac0cefb6586c04317b0a1 Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9.3 (stretch) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --enable-checking=yes,glyphs --enable-check-lisp-object-type 'CFLAGS=-O0 -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD LCMS2 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Term Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term disp-table easymenu ehelp ring elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 97899 5997) (symbols 48 20698 1) (miscs 40 46 116) (strings 32 29399 1942) (string-bytes 1 774861) (vectors 16 14837) (vector-slots 8 500989 12084) (floats 8 49 127) (intervals 56 247 0) (buffers 992 12)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 09:01:49 2018 Received: (at 30190) by debbugs.gnu.org; 21 Jan 2018 14:01:49 +0000 Received: from localhost ([127.0.0.1]:36658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edGBw-0003eU-Sg for submit@debbugs.gnu.org; Sun, 21 Jan 2018 09:01:49 -0500 Received: from mail-it0-f52.google.com ([209.85.214.52]:44997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edGBv-0003eB-8A; Sun, 21 Jan 2018 09:01:47 -0500 Received: by mail-it0-f52.google.com with SMTP id b5so7041691itc.3; Sun, 21 Jan 2018 06:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ch2k35rLcK1knBYmat//OMm3nb4OBuF1ES/oYl7YZQg=; b=e7hKv47MGROhRgB9XLZUH2LvtCWQIA3r3lNs2fCYpDKHpc59zN/K34a5s0+lffaAWH w41Cx02GEgEJSlVP9QYImWSijfbN41Davu+yKhqhCNj/xPgk30eKYow59e50sJ6cdeoH gUHkqZmRDdY65LcVTj5/RaL0sebHtiPDRB9j9W4eWlQbT4WOLyQpS9g77VZo8TWweHYh /8XZbPFHsBTlMFN4POEA2lep+hnr+5gP+4cPbChAvUmV4/cLrcaXeKAfMdokXpD+SNE/ toG3h95QYgqqhtAmM5XSowd/WjUtTFJta02QzApTWOgfUUawSh+eyGpTGMau4LuFjvbv XLfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ch2k35rLcK1knBYmat//OMm3nb4OBuF1ES/oYl7YZQg=; b=Gy2cFzDztNfi1tkmyRtHzkMRwoWVAt4aAk/g0As+ifGE+NkpTPeT5PY3lxvU7fXaY7 CPd7cueJerIAm/lMN9+H1GPlqaWvOTBTDNp+SVe2ll55meS+P/dkZ6BDz6RgsWz/fCh3 G1wexsOHcb4UxXYsY6xmH8T7OYhbh9tM2pkOnupig0gAAOXoRvhI2oEJ8yYMoPMFzQdH 4qal+cgktC5RzSwY2FC5K7qRNqmiMblJr8D1bhjXIWee1WGFyIdjWGbg2kNYvvAdgGhC G5OxkMg+j1kzxnEklvJiAtXM94BGMO2/uKJPKD62FcJfVwd7RoC1HH6VvTLsgjq/kYJK cxKg== X-Gm-Message-State: AKwxytconznv9O0h+pLezZ0wQu/xdypxE82GRyHojoX0T6veVVM4pfox 9jKTJP0G0XpJpGAXF+hH159ybQ== X-Google-Smtp-Source: AH8x226adI3w0x6oAlbiPMGNB4HqdXhFAsGwcM6Mi55LekOCGG9DtyXeiJxtNbp8QJuFakL2PyBeMg== X-Received: by 10.36.200.215 with SMTP id w206mr4384402itf.64.1516543301536; Sun, 21 Jan 2018 06:01:41 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id a19sm939471ioc.17.2018.01.21.06.01.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Jan 2018 06:01:40 -0800 (PST) From: Noam Postavsky To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> Date: Sun, 21 Jan 2018 09:01:39 -0500 In-Reply-To: <87r2qjh0fs.fsf@gmail.com> (Tino Calancha's message of "Sun, 21 Jan 2018 21:16:07 +0900") Message-ID: <87mv17nwe4.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) found 30190 24.3 tags 30190 + confirmed quit Tino Calancha writes: > 1. Start a new terminal emulator in line mode. > M-x term RET > C-c C-j > > 2. run a command that prompt for user's password > (e.g., 'sudo ls' or 'git push'); the user password > visible. Yes, seems to have been the case for a long time, I can reproduce back to 24.3 (oldest Emacs version I have running). > * If you run the terminal in char modem then the password is not shown. > * If you run a dumb shell instead, then the password is read from the > minibuffer with `send-invisible', thereby the password is not shown. What do you mean by "dumb shell"? From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 16:08:38 2018 Received: (at 30190) by debbugs.gnu.org; 21 Jan 2018 21:08:38 +0000 Received: from localhost ([127.0.0.1]:37436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edMr0-0000u3-Lg for submit@debbugs.gnu.org; Sun, 21 Jan 2018 16:08:38 -0500 Received: from mail-pg0-f46.google.com ([74.125.83.46]:37018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edMqy-0000tq-Kl for 30190@debbugs.gnu.org; Sun, 21 Jan 2018 16:08:36 -0500 Received: by mail-pg0-f46.google.com with SMTP id z17so5522762pgc.4 for <30190@debbugs.gnu.org>; Sun, 21 Jan 2018 13:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=HsRiebAVKg7+ssvtUVARycBYO2AFra177G+GCrYhxuk=; b=ZJOp04EZwR+cXZq6ckLLmBqJxooYj3f5RS7getfcZkrrE42bvV2IfpVIbqkCoZImAR gU45hMQxxs6GuZJTg2JmzsVxHRGmES4ZTVncI3oenH+NA/UJ4izKL9C4OoYjnouBd5TV XTosp+Cd5qhIwtTwlcuyXF4hd53DCnMXrK+CuHSKwe9BxHauUl3j2Py05XIioEh71GNE viwz+MAKfbBFViclsYRFS1tM0OTJTgmC8/pFkjuXiXylR6n4CctMYQ/H6GC3WTA+jVjB Z81/QcgiTdBxgpFbNDJJsyFHvxG8kge5Trkvc0Xyle3XxFIt29zin9lMLVKLdEF7/Q/c zU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=HsRiebAVKg7+ssvtUVARycBYO2AFra177G+GCrYhxuk=; b=s5DmaR9MQ303vfOKDTNA8eog2d9C8CMZVCIC9zSvKA6MdoStn0XJiDKx0eIUnOVSQW W49qlpO3+Lpvs6P6WuKnkRGXNWY5UP7lvCPp79Z+y+4vbks2Aoh/9AG9yzak4yWKWkj2 NQV+JVRu4LuwIU+VcvU00OV6JPHU95JVZgApiLS31RnGO3u4977o78pPL9RhnmsENIrn Dqr4/m5YAKmojdFMYTI/RofhvYgC2jh7HCM0fC4r/Aav1u/aOsm/JCF3ZrlyAB/fTe/6 oaNw4Xiqp4KFvYPCeYglzgbwn9zT/MzDYZdYmsnPMHCWBHl0eB/icFf9+9GxX9TT7I6C 4fsA== X-Gm-Message-State: AKwxytf71FrC5RRp9YugXSRD4s9ZhoJYhqFxSNr5Ee243DvrxstFaHG3 QPoUfUuvgp1rmWXC9///1ms= X-Google-Smtp-Source: AH8x227I4tGL9Vp3ctg1rEUCojVYbrVgyp+L/XoNOQI78Ab/AUKmX6MDJL5YFKb8xsTSmEcV/5PcyQ== X-Received: by 10.99.49.200 with SMTP id x191mr5155289pgx.394.1516568910968; Sun, 21 Jan 2018 13:08:30 -0800 (PST) Received: from calancha-pc ([210.160.37.26]) by smtp.gmail.com with ESMTPSA id n186sm24881156pgn.11.2018.01.21.13.08.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Jan 2018 13:08:30 -0800 (PST) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Mon, 22 Jan 2018 06:08:26 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <87mv17nwe4.fsf@users.sourceforge.net> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sun, 21 Jan 2018, Noam Postavsky wrote: > Yes, seems to have been the case for a long time, I can reproduce back > to 24.3 (oldest Emacs version I have running). It's even worse; the password is stored in the history of commands; after introduce the password 'M-p' will show it. >> * If you run the terminal in char modem then the password is not shown. >> * If you run a dumb shell instead, then the password is read from the >> minibuffer with `send-invisible', thereby the password is not shown. > > What do you mean by "dumb shell"? I mean this: M-x shell RET sudo ls ;; Here password is read (invisible) from the minibuffer. You still can jump to the *shell* buffer and input th epasword there; in that case the password is visible, but as longer as you input it from the minibuffer everything is OK. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 11:16:11 2018 Received: (at 30190) by debbugs.gnu.org; 3 Feb 2018 16:16:11 +0000 Received: from localhost ([127.0.0.1]:55821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei0U6-0005br-U9 for submit@debbugs.gnu.org; Sat, 03 Feb 2018 11:16:11 -0500 Received: from mail-pl0-f44.google.com ([209.85.160.44]:41280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei0U5-0005bg-Jl for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 11:16:10 -0500 Received: by mail-pl0-f44.google.com with SMTP id k8so6400558pli.8 for <30190@debbugs.gnu.org>; Sat, 03 Feb 2018 08:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=UvWfnLrb0F2l2NLf4DBnxsYKU5R66klBUEETfKBHtDE=; b=bKN3yPbXerKN5cyaxmDoSwGiYVaXX3l9GbvU7nxWxbjP8S01IwomrRexfnkViCrw4p 3H+eK/xQVuNY8RFSLnVwB0AkHxOHivGgAzWss5xJhmyMMAvAoXmYFwwGPjMd4JgFRjtN V5MCgpDxGpHnppsbsIaQd3j5QMH78XSP8DOOfILLJugRgKApO2AuvVbRqyhedHBBs50M A93vzLIRIUHKSMJtWtlewOBI4vDxGR3CgySr2QD7b9spPy9paPtbTXZWQzX4AT82mxRj Jebj54P2Y0NuwM5yyvcqHyTSb6MbIYj2j04Z765XqcKpyjO9SQk+5bbULF8K6GCqzPku dDFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=UvWfnLrb0F2l2NLf4DBnxsYKU5R66klBUEETfKBHtDE=; b=bWU47lcZJO8ZbddGNbjUMCx6PY+NoiZRpuJW6wG/zvmVqIJLsH01lOeL0v+MbVy9v2 LIubzxdkHS+++ezkr+ueunLXY94xTJCHqihrVUAbZaQF2lk9EalFBIu7y1f2KaqMdLxZ gmtcDu1wjJ5fb9hqG4TqU59wZcfnzZu/05FxatSwKHnUX25xQmB088OJgF0QIaokpgrh rPtnuCpJAdRB3Tk4Fp77pgS7omUEc2eg3dUKsVev8F3wBr2kwsJzqsJ/ueOkmRy4vgP+ AsULVSzwT2U1PDHOk5tQsmOxpYPDR2qeePhfVuU6f9x3jV+E2wYAnlgrQnIiU9k9S49v tnSw== X-Gm-Message-State: AKwxytd15FitlFG8oj0hLWG+Ygnc+gM8SuJd7nIJsKq9iO+ulwYd0PcH BgWERGIb6Qlduqpo3gDaV1oHIQ== X-Google-Smtp-Source: AH8x2240vkNl7XaX8h0JOmPX+5tt8wWQBvlIaGxyWf1jBe4D8eM6si/ub84clg+uvJuGF6RuGV7chg== X-Received: by 2002:a17:902:8f8b:: with SMTP id z11-v6mr16555832plo.43.1517674563457; Sat, 03 Feb 2018 08:16:03 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id 184sm8918907pfd.156.2018.02.03.08.16.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Feb 2018 08:16:01 -0800 (PST) From: Tino Calancha To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> Date: Sun, 04 Feb 2018 01:15:54 +0900 In-Reply-To: <87mv17nwe4.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sun, 21 Jan 2018 09:01:39 -0500") Message-ID: <87efm259s5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Noam Postavsky writes: > Yes, seems to have been the case for a long time, I can reproduce back > to 24.3 (oldest Emacs version I have running). This is a security risk. I would like to have it fixed ASAP. Below patch seems to work. Any feedback would be appreciated. --8<-----------------------------cut here---------------start------------->= 8--- commit 089c86c2d8e46fd3f134826881c010409b65d364 Author: tino calancha Date: Sun Feb 4 01:00:29 2018 +0900 Prevent term run in line mode from showing user passwords =20=20=20=20 For buffers whose mode derive from comint-mode, the user password is read from the minibuffer and it's hidden. A buffer in term-mode and line submode, instead shows the passwords. This commit forces buffers in line term-mode to hide passwords (Bug#30190). =20=20=20=20 * lisp/term-utils: New file. Move into it some common code shared by comint.el and term.el. =20=20=20=20 * lisp/comint.el (comint-password-prompt-regexp): (send-invisible) Move them to the new file. Prefix them with 'term-utils-'. Define aliases to the original names. =20=20=20=20 * lisp/term.el (term-output-filter-functions): New hook. (term-send-input, term-emulate-terminal): Call it. diff --git a/lisp/comint.el b/lisp/comint.el index 8dba317099..0e9e13f12e 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -104,6 +104,7 @@ (require 'ring) (require 'ansi-color) (require 'regexp-opt) ;For regexp-opt-charset. +(require 'term-utils) ;; Buffer Local Variables: ;;=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D @@ -342,35 +343,6 @@ comint-process-echoes :type 'boolean :group 'comint) =20 -;; AIX puts the name of the person being su'd to in front of the prompt. -;; kinit prints a prompt like `Password for devnull@GNU.ORG: '. -;; ksu prints a prompt like `Kerberos password for devnull/root@GNU.ORG: '. -;; ssh-add prints a prompt like `Enter passphrase: '. -;; plink prints a prompt like `Passphrase for key "root@GNU.ORG": '. -;; Ubuntu's sudo prompts like `[sudo] password for user:' -;; Some implementations of passwd use "Password (again)" as the 2nd prompt. -;; Something called "perforce" uses "Enter password:". -;; See M-x comint-testsuite--test-comint-password-prompt-regexp. -(defcustom comint-password-prompt-regexp - (concat - "\\(^ *\\|" - (regexp-opt - '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" - "Old" "old" "New" "new" "'s" "login" - "Kerberos" "CVS" "UNIX" " SMB" "LDAP" "PEM" "SUDO" - "[sudo]" "Repeat" "Bad" "Retype") - t) - " +\\)" - "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)" - "\\(?:\\(?:, try\\)? *again\\| (empty for no passphrase)\\| (again)\\)?" - ;; "[[:alpha:]]" used to be "for", which fails to match non-English. - "\\(?: [[:alpha:]]+ .+\\)?[\\s =C2=A0]*[:=EF=BC=9A=E1=9F=96][\\s =C2=A0= ]*\\'") - "Regexp matching prompts for passwords in the inferior process. -This is used by `comint-watch-for-password-prompt'." - :version "27.1" - :type 'regexp - :group 'comint) - ;; Here are the per-interpreter hooks. (defvar comint-get-old-input (function comint-get-old-input-default) "Function that returns old text in Comint mode. @@ -399,7 +371,7 @@ comint-input-filter-functions These functions get one argument, a string containing the text to send.") =20 ;;;###autoload -(defvar comint-output-filter-functions '(ansi-color-process-output comint-= postoutput-scroll-to-bottom comint-watch-for-password-prompt) +(defvar comint-output-filter-functions '(ansi-color-process-output comint-= postoutput-scroll-to-bottom term-utils-watch-for-password-prompt) "Functions to call after output is inserted into the buffer. One possible function is `comint-postoutput-scroll-to-bottom'. These functions get one argument, a string containing the text as original= ly @@ -2342,41 +2314,8 @@ comint-read-noecho ;; saved -- typically passwords to ftp, telnet, or somesuch. ;; Just enter m-x send-invisible and type in your line. =20 -(defun send-invisible (&optional prompt) - "Read a string without echoing. -Then send it to the process running in the current buffer. -The string is sent using `comint-input-sender'. -Security bug: your string can still be temporarily recovered with -\\[view-lossage]; `clear-this-command-keys' can fix that." - (interactive "P") ; Defeat snooping via C-x ESC ESC - (let ((proc (get-buffer-process (current-buffer))) - (prefix - (if (eq (window-buffer) (current-buffer)) - "" - (format "(In buffer %s) " - (current-buffer))))) - (if proc - (let ((str (read-passwd (concat prefix - (or prompt "Non-echoed text: "))))) - (if (stringp str) - (progn - (comint-snapshot-last-prompt) - (funcall comint-input-sender proc str)) - (message "Warning: text will be echoed"))) - (error "Buffer %s has no process" (current-buffer))))) - -(defun comint-watch-for-password-prompt (string) - "Prompt in the minibuffer for password and send without echoing. -This function uses `send-invisible' to read and send a password to the buf= fer's -process if STRING contains a password prompt defined by -`comint-password-prompt-regexp'. - -This function could be in the list `comint-output-filter-functions'." - (when (let ((case-fold-search t)) - (string-match comint-password-prompt-regexp string)) - (when (string-match "^[ \n\r\t\v\f\b\a]+" string) - (setq string (replace-match "" t t string))) - (send-invisible string))) +(defalias 'comint-watch-for-password-prompt 'term-utils-watch-for-password= -prompt) + ;; Low-level process communication =20 diff --git a/lisp/term-utils.el b/lisp/term-utils.el new file mode 100644 index 0000000000..7edb741bc3 --- /dev/null +++ b/lisp/term-utils.el @@ -0,0 +1,118 @@ +;;; term-utils.el --- Common code used by term.el and comint.el -*- lexic= al-binding: t; -*- + +;; Copyright (C) 2018 Tino Calancha + +;; Author: Tino Calancha +;; Keywords: processes, terminals + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: + +;; + +;;; code: + + +;; Retrieve the right defvar value according with the buffer mode. +(defmacro term-utils--defvar-value (suffix) + "Build a defvar with the `major-mode' and SUFFIX, return its value. +The buffer major mode must be `term-mode' or `comint-mode'." + (declare (debug (symbolp)) (indent 0)) + `(symbol-value + (intern-soft + (format "%S%S" (if (derived-mode-p 'term-mode) 'term- 'comint-) + ',suffix)))) + +;; AIX puts the name of the person being su'd to in front of the prompt. +;; kinit prints a prompt like `Password for devnull@GNU.ORG: '. +;; ksu prints a prompt like `Kerberos password for devnull/root@GNU.ORG: '. +;; ssh-add prints a prompt like `Enter passphrase: '. +;; plink prints a prompt like `Passphrase for key "root@GNU.ORG": '. +;; Ubuntu's sudo prompts like `[sudo] password for user:' +;; Some implementations of passwd use "Password (again)" as the 2nd prompt. +;; Something called "perforce" uses "Enter password:". +;; See M-x comint-testsuite--test-comint-password-prompt-regexp. +(defcustom term-utils-password-prompt-regexp + (concat + "\\(^ *\\|" + (regexp-opt + '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" + "Old" "old" "New" "new" "'s" "login" + "Kerberos" "CVS" "UNIX" " SMB" "LDAP" "PEM" "SUDO" + "[sudo]" "Repeat" "Bad" "Retype") + t) + " +\\)" + "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)" + "\\(?:\\(?:, try\\)? *again\\| (empty for no passphrase)\\| (again)\\)?" + ;; "[[:alpha:]]" used to be "for", which fails to match non-English. + "\\(?: [[:alpha:]]+ .+\\)?[\\s =C2=A0]*[:=EF=BC=9A=E1=9F=96][\\s =C2=A0= ]*\\'") + "Regexp matching prompts for passwords in the inferior process. +This is used by `term-utils-watch-for-password-prompt'." + :version "27.1" + :type 'regexp + :group 'term-utils) + +(declare-function comint-snapshot-last-prompt "comint") + +(defun term-utils-send-invisible (&optional prompt) + "Read a string without echoing with PROMPT. +Then send it to the process running in the current buffer. +The string is sent using `comint-input-sender' or `term-input-sender' +depending of the buffer mode. +Security bug: your string can still be temporarily recovered with +\\[view-lossage]; `clear-this-command-keys' can fix that." + (interactive "P") ; Defeat snooping via C-x ESC ESC + (let ((proc (get-buffer-process (current-buffer))) + (prefix + (if (eq (window-buffer) (current-buffer)) + "" + (format "(In buffer %s) " + (current-buffer))))) + (if proc + (let ((str (read-passwd (concat prefix + (or prompt "Non-echoed text: "))))) + (if (stringp str) + (let ((input-sender-fun (term-utils--defvar-value input-sender))) + (if (derived-mode-p 'comint-mode) (comint-snapshot-last-prompt)) + (funcall input-sender-fun proc str)) + (message "Warning: text will be echoed"))) + (error "Buffer %s has no process" (current-buffer))))) + +(defalias 'send-invisible 'term-utils-send-invisible) + +(defvar term-raw-map) ; Defined in term.el +(defun term-utils-term-in-line-mode-p () + "Return non-nil if the buffer is in `term-mode' and line submode." + (and (derived-mode-p 'term-mode) (eq (current-local-map) term-raw-map))) + +(defun term-utils-watch-for-password-prompt (string) + "Prompt in the minibuffer for password and send without echoing. +This function uses `send-invisible' to read and send a password to the buf= fer's +process if STRING contains a password prompt defined by +`term-utils-password-prompt-regexp'. + +This function could be in the lists `comint-output-filter-functions' +and `term-output-filter-functions'." + ;; Do nothing if buffer is in term-mode with line submode + (unless (term-utils-term-in-line-mode-p) + (when (let ((case-fold-search t)) + (string-match term-utils-password-prompt-regexp string)) + (when (string-match "^[ \n\r\t\v\f\b\a]+" string) + (setq string (replace-match "" t t string))) + (term-utils-send-invisible string)))) + + +(provide 'term-utils) +;;; term-utils.el ends here diff --git a/lisp/term.el b/lisp/term.el index a0313d88da..ed0f1715b2 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -340,6 +340,7 @@ term-protocol-version (eval-when-compile (require 'cl-lib)) (require 'ring) (require 'ehelp) +(require 'term-utils) =20 (declare-function ring-empty-p "ring" (ring)) (declare-function ring-ref "ring" (ring index)) @@ -575,6 +576,16 @@ term-input-filter-functions =20 This variable is buffer-local.") =20 +;;;###autoload +(defvar term-output-filter-functions '(term-utils-watch-for-password-promp= t) + "Functions to call after output is inserted into the buffer. +One possible function is `term-utils-watch-for-password-prompt'. +These functions get one argument, a string containing the text as original= ly +inserted. + +You can use `add-hook' to add functions to this list +either globally or locally.") + (defvar term-input-sender (function term-simple-send) "Function to actually send to PROCESS the STRING submitted by user. Usually this is just `term-simple-send', but if your mode needs to @@ -2106,7 +2117,8 @@ term-send-input (set-marker term-pending-delete-marker pmark-val) (set-marker (process-mark proc) (point))) (goto-char pmark) - (funcall term-input-sender proc input))))) + (funcall term-input-sender proc input) + (run-hook-with-args 'term-output-filter-functions ""))))) =20 (defun term-get-old-input-default () "Default for `term-get-old-input'. @@ -3017,6 +3029,8 @@ term-emulate-terminal (term-handle-deferred-scroll)) =20 (set-marker (process-mark proc) (point)) + ;; Run these hooks with point where the user had it. + (run-hook-with-args 'term-output-filter-functions str) (when save-point (goto-char save-point) (set-marker save-point nil)) --8<-----------------------------cut here---------------end--------------->= 8--- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 11:44:24 2018 Received: (at 30190) by debbugs.gnu.org; 3 Feb 2018 16:44:24 +0000 Received: from localhost ([127.0.0.1]:55838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei0vQ-0006F3-B6 for submit@debbugs.gnu.org; Sat, 03 Feb 2018 11:44:24 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:50603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei0vP-0006Es-4n for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 11:44:23 -0500 Received: by mail-it0-f53.google.com with SMTP id x128so12171569ite.0 for <30190@debbugs.gnu.org>; Sat, 03 Feb 2018 08:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aOgA6rv8ODpPMbvnD/QRh6ipkFiXs9d4wxScDw6PLGc=; b=aaF/QfIb5qe2VMXduoA8IgUEg4HOdh2v8w+zTcIaNR1Yp3EhWeqhHK3ZS7VQLwWXSn lA6h0q4eWBmX2wkEJ0GYgQPF5XOy5wheIfGrUPUMlvYXblB1CiRJSX3XkAKQISCTwfMR GaXHrfSNuUhuqs7S4RclBiu/JUBmERKQtFJibOx6G0PmPUpkHdXegxEcA5YxaTmUNjU+ 2xih0LKuos6hXgsVV+RX2TAeGPnBgO2ge3v7bPVnfm2rkPCwY2DlQfM5wuoUZUIoBl6V t19jOrtWBqhjnjiXe2YPH/aoGkUIcF4mh6iC3RAWKIwvcsoz6zXM2a8AvXRrFYo/siIq IHfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=aOgA6rv8ODpPMbvnD/QRh6ipkFiXs9d4wxScDw6PLGc=; b=TfuiiqqudJ1sLgv8FVjsTO1DwTYOzzTQFkaAE5NxRZDymBGfuejzR7KwRPWeDaj2EK 9AQF4VjLNKFVskMB2vAz7MQbwvcB5WxZeAJPkq+9YE+IcTiHM4BWjlKh2Tx2WO8sDLIz 3poaUO6CYp404XZZhXQxMrOfeLFgTyf8ugq0lnDKcBx8vtSyQYKUQ5QEfhQLBz2dP2r0 NpsM/KWqGwNdE4RYPlOPnTFrcPwlgAlke9MU+VHW8Qv2Kr8YyqHdAUpZmoTQNOqgxmtN rPTB+qn6ZhuSmVmfY64a3FdOSBiMXNaWGHQUCfgyDFdv73LYlmWhoS8rlE5wc8CQhtac ubaQ== X-Gm-Message-State: AKwxytfvJbIYajMwITyoiRD5yV6gahjNcRk7SYap+Ka4eG+6vZTleAvW 1D5IIl8wF0t12BgT7NYnMSMwZA== X-Google-Smtp-Source: AH8x224aSTRIvUgyFq79i8+Lyu64/EV9uOSoSfMyhbZv9vrVG8Bs5J3kjdW7iQC6CMffnZ+SorHsAg== X-Received: by 10.36.254.1 with SMTP id w1mr11765249ith.50.1517676257266; Sat, 03 Feb 2018 08:44:17 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m63sm2708952itm.12.2018.02.03.08.44.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Feb 2018 08:44:16 -0800 (PST) From: Noam Postavsky To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> Date: Sat, 03 Feb 2018 11:44:15 -0500 In-Reply-To: <87efm259s5.fsf@gmail.com> (Tino Calancha's message of "Sun, 04 Feb 2018 01:15:54 +0900") Message-ID: <87tvuyf2g0.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Tino Calancha writes: > Noam Postavsky writes: > >> Yes, seems to have been the case for a long time, I can reproduce back >> to 24.3 (oldest Emacs version I have running). > This is a security risk. I would like to have it fixed ASAP. > Below patch seems to work. Any feedback would be appreciated. Doesn't look like that much of a risk to me: the user immediately sees the problem, so it's more of a minor nuisance. > -(defcustom comint-password-prompt-regexp I don't see an alias for this one. Otherwise I think it's okay. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 12:09:17 2018 Received: (at 30190) by debbugs.gnu.org; 3 Feb 2018 17:09:17 +0000 Received: from localhost ([127.0.0.1]:55846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei1JV-0006nc-7K for submit@debbugs.gnu.org; Sat, 03 Feb 2018 12:09:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei1JT-0006nL-Oc for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 12:09:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei1JK-0002PT-MQ for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 12:09:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei1JK-0002PN-IE; Sat, 03 Feb 2018 12:09:06 -0500 Received: from [176.228.60.248] (port=2113 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ei1JK-0005zb-27; Sat, 03 Feb 2018 12:09:06 -0500 Date: Sat, 03 Feb 2018 19:08:53 +0200 Message-Id: <83vafe9f16.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87efm259s5.fsf@gmail.com> (message from Tino Calancha on Sun, 04 Feb 2018 01:15:54 +0900) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Sun, 04 Feb 2018 01:15:54 +0900 > Cc: 30190@debbugs.gnu.org > > Noam Postavsky writes: > > > Yes, seems to have been the case for a long time, I can reproduce back > > to 24.3 (oldest Emacs version I have running). > This is a security risk. I would like to have it fixed ASAP. > Below patch seems to work. Any feedback would be appreciated. My feedback is that such a radical solution with so many lines of code is a no-no for the release branch. Please look for a simpler solution, perhaps don't create a new file? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 21:23:53 2018 Received: (at 30190) by debbugs.gnu.org; 4 Feb 2018 02:23:53 +0000 Received: from localhost ([127.0.0.1]:56126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei9yC-0003VW-IC for submit@debbugs.gnu.org; Sat, 03 Feb 2018 21:23:53 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:37513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei9yA-0003VJ-CJ for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 21:23:50 -0500 Received: by mail-pf0-f171.google.com with SMTP id p1so19397981pfh.4 for <30190@debbugs.gnu.org>; Sat, 03 Feb 2018 18:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=vAUdNCnT6dmkR27gsvvLkrAL5dEr8Fa2gpQm9i0umfM=; b=CV85NedyyTS+GCViOe5ofPEuldg88XmkzHdSiYNRdWOR+3ttbUmJ/3zTm1OLPBZAYA JHFcAenSLpHHtZeze6lTO9Ni26uXPYKTz/G/qJyxVV/b6BEDl6j9eOLyTxnQvlMd2A4J KLlJaoigdewIIh6kijcq+W0x0hZENdpf4nfKSUfHG+DpSuf2YdSNvJQQem1uDBpoiAK5 q/Iy4IwEFlQ6sfm1RpWIhph0h1f4ALnwii/qwusYX9TcwwvnI7MgUD8eH9jki4o3m10T oy3CrBuaHv0DeaC8weklBlZ7TiJooXQ3CpPF1mLg9D30WLQV9AdGeXg/HkoljkOItDhe bVMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=vAUdNCnT6dmkR27gsvvLkrAL5dEr8Fa2gpQm9i0umfM=; b=REho6wEp63m8rWAWPUFIwMAD3LImi+gc6QcpaQzf4QDvHdXnsrUR+cM3tF3oMZOdCz hbzUS2SwBFEM7Oa/XKabXlAK+PvjCX+KtpCaw9Hc1vyD/ABFBz9hDCvx2fF0XS8mUzsB vTw6nJBGgb1cjcFgQBW6v/qvMjEMOWSZkABCYzjggOw/abDEQptTGSL1Jb9KOxP2BSyI SLOBt1uJX+qIwPpxvV6KPryWPVOQay6O7s6tMi+uETbd8CWh8pu+au5d0wr5ov8gkFLx 85DaD8O1RjOAGONcs86oD50rfotbtkQFibkVxTz8RqxKJHo0xECxY592vNOjUcwEAi9/ TiQg== X-Gm-Message-State: AKwxytfYVtdYpxmdA2RBTENV+dW7/Vb58GxXxim7Ovhdc3sK6ebPDP2w nllL14Oa4I0HL/m2cDy6MrU= X-Google-Smtp-Source: AH8x226sdrDIP3iyvzHiP2/eo1oTm11bIOfNlRv26OQf8JX2jvwqLVMGgW2wlouiwzEAXP0cSHynTQ== X-Received: by 10.98.97.4 with SMTP id v4mr34188626pfb.160.1517711024436; Sat, 03 Feb 2018 18:23:44 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id b68sm9808100pfg.159.2018.02.03.18.23.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Feb 2018 18:23:43 -0800 (PST) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 4 Feb 2018 11:23:40 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <87tvuyf2g0.fsf@users.sourceforge.net> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <87tvuyf2g0.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sat, 3 Feb 2018, Noam Postavsky wrote: > Tino Calancha writes: > >> Noam Postavsky writes: >> >>> Yes, seems to have been the case for a long time, I can reproduce back >>> to 24.3 (oldest Emacs version I have running). >> This is a security risk. I would like to have it fixed ASAP. >> Below patch seems to work. Any feedback would be appreciated. > > Doesn't look like that much of a risk to me: the user immediately sees > the problem, so it's more of a minor nuisance. It depends of the situation. Few years ago, my boss watched my password because this thing; if the password would be an offensive word against him (it wasn't, he was nice) I could be fired. I remember he mnetioned very proudly that in vi editor the password is always hidden... This is also a risk while pair-programming; recently I am doing a lot with several buddies. I suspect one of my passwords might be compromised. >> -(defcustom comint-password-prompt-regexp > > I don't see an alias for this one. Otherwise I think it's okay. Thanks, I will fix that. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 21:26:59 2018 Received: (at 30190) by debbugs.gnu.org; 4 Feb 2018 02:26:59 +0000 Received: from localhost ([127.0.0.1]:56130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiA1D-0003Zj-3Z for submit@debbugs.gnu.org; Sat, 03 Feb 2018 21:26:59 -0500 Received: from mail-pg0-f48.google.com ([74.125.83.48]:44224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiA1B-0003ZW-SO for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 21:26:58 -0500 Received: by mail-pg0-f48.google.com with SMTP id r1so334223pgn.11 for <30190@debbugs.gnu.org>; Sat, 03 Feb 2018 18:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=JKJAJ0NdXU470a/iZCghMuXytbrflzqQjUbdKxAfmwA=; b=mi3jqcWDgwXO5F1Z+nclN7uYxEDLLJcW/WaVO7CKhJcgqlKhxcKDcD3EyFmrfNiw0L 8p5rusJqpUM+xuIv7fuh1Uh8yrjAQX37r3YbJtgBWAEZ9rL+ZSzXVGVkXFWAaa0afUWw ASA/KRk4jnQOHmF7MsbK5jsjKSUuZ0tVFnzGWMNkGTdQC4g9CX5AWBhOml7x5x0bkzNx 4jBg05xY6EOjOKxRYl5/UNkyhsDGoGe2kMkfju+kN/nfZRfjfJOS6Ss4sdQ4P/6QOAcP w1STFybj2mZfUHpnsM7q2jfziA5iN2BabcZiupK8kqUqrKaT9Z1tos4cJ9nuueT1i+j0 op7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=JKJAJ0NdXU470a/iZCghMuXytbrflzqQjUbdKxAfmwA=; b=kbgz/GusU1BPHz7wbId6nMIluEagG41s2/XeeQh6Bd34Fes8BRur+/o6Xhv+0DrzwC dzR9NpH9zH2ydIW4nE/hTBXLxHR1ncwWWzu69Ts8I88m7NRZlyBVsbF2VQLzLL8pTdmh xZR+rXwdlPqXIRoMsok6kHHHZ5aTHmnyqmhr/XtZU7nAogQIvzrWD+uI7vwLfAOo5vL3 1YDQPDC66gB/UikWcqfEb8C6gunPLEDV8hCvqCnin3YB/WKL/GRI50mEwqfVIDSrTbq/ KqrPcv3Saz9mswQIw4YrvaNty6fGv5rluDZjSu7i/RMzDhKPM+FTOa0ObgeV03l+peCK sdgw== X-Gm-Message-State: AKwxytfKR2lm7CCRmMwN29WhKpTroouYolsTh+l9mhxzcsfLvqiHs7P4 1HtZxrDLNHRjQ8BahNxx6t8= X-Google-Smtp-Source: AH8x227FQcpISGm8+ZQmoKpNQt8Zd3Hjj0X2xWCIkfUtGavEvMLIlaz5e4Epchlpv0EVtcpz59HmEw== X-Received: by 10.98.66.67 with SMTP id p64mr44494128pfa.227.1517711212046; Sat, 03 Feb 2018 18:26:52 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id p62sm10449076pfi.88.2018.02.03.18.26.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Feb 2018 18:26:51 -0800 (PST) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 4 Feb 2018 11:26:48 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <83vafe9f16.fsf@gnu.org> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, npostavs@users.sourceforge.net, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sat, 3 Feb 2018, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Sun, 04 Feb 2018 01:15:54 +0900 >> Cc: 30190@debbugs.gnu.org >> >> Noam Postavsky writes: >> >>> Yes, seems to have been the case for a long time, I can reproduce back >>> to 24.3 (oldest Emacs version I have running). >> This is a security risk. I would like to have it fixed ASAP. >> Below patch seems to work. Any feedback would be appreciated. > > My feedback is that such a radical solution with so many lines of code > is a no-no for the release branch. Please look for a simpler > solution, perhaps don't create a new file? OK, I will prepare one less verbose by today. I agree it would be nice to have it in the next release. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 21:29:39 2018 Received: (at 30190) by debbugs.gnu.org; 4 Feb 2018 02:29:39 +0000 Received: from localhost ([127.0.0.1]:56135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiA3n-0003dc-JJ for submit@debbugs.gnu.org; Sat, 03 Feb 2018 21:29:39 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiA3m-0003dO-21 for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 21:29:38 -0500 Received: by mail-wm0-f47.google.com with SMTP id v71so19533354wmv.2 for <30190@debbugs.gnu.org>; Sat, 03 Feb 2018 18:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GnAz5cNc3pa4qhE1DxbqPoKPmF/JnKRdSUxoLpGmCjc=; b=PZ2GDXQnlwUru8MNLkWsjFZj8zMBuIFVXjp2o7Ip8zQXfhaLNEwFYQQVmMfJ3+CvGA benWS1+CKS6pS5ob5Jx1oSE4Co3W+643IMuwTw4Up5rGcCsW2bCIIkHWCRhKvDbRpTAq GBrEKahHuHaTjrYXzg8YmK2z0UPg7Kwk/VJDpP4ORyCLAEsk3F73+QGXvaSPFl4EFZDm xh6WSs42ThS4CS+FJaXY29q95QcwUPtmRbplkfxGs8P0/MJcQMnRMD4X5DyZjc/e8+1G Yieh1AEMqe/dux3M4K/a/twzdM/2w209pUYqWxkSoI4dcA3KRF0gc0riiLFF1jSRtnaH 1ZVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=GnAz5cNc3pa4qhE1DxbqPoKPmF/JnKRdSUxoLpGmCjc=; b=nfOJ3lfclYUzCBsghnt0P8xcKH96/jJLM9GGcRLRxfQcXK3Q558TdethLxIXSA1ZnU zzpofaPx5rqkm1VgBqj0WTsZvvJdm1islHmM2dytu+4TjOYKZnSbSAhBCfQSVVXhtnE8 Jdd69VmRYwfmvoc6w2A+b0WQrnuFivZUs+IUzwb0G1miyDjarV1HheNniQnWRwbMs5Y4 nYjrbwm8yOvhT4EPzDCGdkvRY0DQGd9o13KkqQUqeRm/Pjs/Qgp4+x3pvYf63Zef+t5n 7k8zzVPZm7oyW62osG2yzemnVEwBe1YG9HkSBBjZcscYhR1badaBPCoCBC9Zs6CTkL6d z8mA== X-Gm-Message-State: AKwxytcggPBkAYJHp7uJmGbSDm7Ttmsfb7Nya/Csa8dwOSrTWZ7ahFop PMlwW+ppVn62pfQA+DN45lsm9iHE7/pnNwWSaR4= X-Google-Smtp-Source: AH8x226MLMn/XSLQMaGO0LcToEylTTuLTDQPfLcoApSvfg3hEwGdk2NTqC8kANM8XHi6mvpukmD95slv43TEQ9m01Z0= X-Received: by 10.28.25.129 with SMTP id 123mr11708576wmz.2.1517711372459; Sat, 03 Feb 2018 18:29:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.182.77 with HTTP; Sat, 3 Feb 2018 18:29:32 -0800 (PST) In-Reply-To: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <87tvuyf2g0.fsf@users.sourceforge.net> From: Noam Postavsky Date: Sat, 3 Feb 2018 21:29:32 -0500 X-Google-Sender-Auth: 7d5MNbpgjbgbR0dPSLBQZHOhctw Message-ID: Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords To: Tino Calancha Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, Feb 3, 2018 at 9:23 PM, Tino Calancha wrote: >> Doesn't look like that much of a risk to me: the user immediately sees >> the problem, so it's more of a minor nuisance. > > It depends of the situation. Few years ago, my boss watched my password > because this thing; if the password would be an offensive word > against him (it wasn't, he was nice) I could be fired. I remember he > mnetioned very proudly that in vi editor the password is always hidden... > > This is also a risk while pair-programming; recently I am doing a lot with > several buddies. I suspect one of my passwords might be compromised. But why wouldn't you just switch to char-mode before entering your password? (which is kind of annoying to have to do, but still) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 22:37:54 2018 Received: (at 30190) by debbugs.gnu.org; 4 Feb 2018 03:37:54 +0000 Received: from localhost ([127.0.0.1]:56142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiB7p-00058R-TG for submit@debbugs.gnu.org; Sat, 03 Feb 2018 22:37:54 -0500 Received: from mail-pl0-f52.google.com ([209.85.160.52]:40597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiB7o-00058E-Fn for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 22:37:52 -0500 Received: by mail-pl0-f52.google.com with SMTP id g18so9334201plo.7 for <30190@debbugs.gnu.org>; Sat, 03 Feb 2018 19:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=A7V/zxNwS0S9QwjQQ2YtkwBsbuI4hogK6aE9Td5DJaM=; b=NDdAWqDe427WTE8OYSHZC9wTQeFN1etHGXvoFddrYURODBKDJOuRtDKFxF138SLU+B orsq27e1FkoZY4QhGEkMAMA75HdHzIoztQCkLyIgiUsb59zZoepPp/iG/Y/CZZSEbM+P Io9ESiB8MD/PTVbdsBqvyqZ0H2BpGWbu70Y3LVxhGpVoldkyZJAOB2MG2Kq6l5/iPykE hXLAcll1lEUIqSwqChLNIjIHLPATH3f5k8dDgehLwMucSwKkZ4ntL3AHkUI03v7lFjPY ENzn94dEcp/Lwp3To1wZXhuxX6WDX/5cUCGJylrrQ7GQdaCfMMGT+c0cNdrRWaIae8ST svEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=A7V/zxNwS0S9QwjQQ2YtkwBsbuI4hogK6aE9Td5DJaM=; b=e5nVpWMKPyMBhjgqZ4A7penLJNKfqq2mu7CRlkUfOqXex65CqYch/GNZYNjbEz7iyB EFCZR1T8ddjAo5Iu5es0JAzyjAM8XaqtRnAEUtUGm6kdfLNUfaD9rvw2K/YqJbsNDCFv v4LhaQlFX1NuSY/2tWS2BaiUVkW+g+lRPDKJx0cViX8yFvLAjHpAUAUP/A3DlrpCI4p4 /lm5fl42aym7ONQUabjB4uQqkJVR6xlp17+MUkdeAudecMiIioIJ7VcKWJuzvJ/FE2Cm VgGEiF8CLb0RG1DPa4VHyXyKyRSOc2GYqzOYWs5/P5OvT3kIUi2raqYYLJa8iWRc5BGq 5GHw== X-Gm-Message-State: AKwxytf2Y1yEma7rte4H/Hdx7rw0WliE8T54gfWAUuEV6CTD8vEaUq6H YmikCNIxmsUzjSxrPHPIXvo= X-Google-Smtp-Source: AH8x22557vFOeZHcuf3aj6MMSyEhG8chMXycAqDY0bOnEEpI783hLMkJJ8mlfq8z7fTgsax5NQQ80g== X-Received: by 2002:a17:902:7d8b:: with SMTP id a11-v6mr38966720plm.216.1517715466656; Sat, 03 Feb 2018 19:37:46 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id g207sm10302756pfb.95.2018.02.03.19.37.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Feb 2018 19:37:45 -0800 (PST) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 4 Feb 2018 12:37:42 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <87tvuyf2g0.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sat, 3 Feb 2018, Noam Postavsky wrote: > On Sat, Feb 3, 2018 at 9:23 PM, Tino Calancha wrote: > >>> Doesn't look like that much of a risk to me: the user immediately sees >>> the problem, so it's more of a minor nuisance. >> >> It depends of the situation. Few years ago, my boss watched my password >> because this thing; if the password would be an offensive word >> against him (it wasn't, he was nice) I could be fired. I remember he >> mnetioned very proudly that in vi editor the password is always hidden... >> >> This is also a risk while pair-programming; recently I am doing a lot with >> several buddies. I suspect one of my passwords might be compromised. > > But why wouldn't you just switch to char-mode before entering your > password? (which is kind of annoying to have to do, but still) Because I am so focused in the coding task on hands that I hardly can remember this password thing. Such bookeeping is not a human task, it must be done by computers. Like remember aniversaries: most of the people use tools to remember that its your birthday. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 22:40:19 2018 Received: (at 30190) by debbugs.gnu.org; 4 Feb 2018 03:40:19 +0000 Received: from localhost ([127.0.0.1]:56148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiBAB-0005C5-9q for submit@debbugs.gnu.org; Sat, 03 Feb 2018 22:40:19 -0500 Received: from mail-pg0-f53.google.com ([74.125.83.53]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiBA8-0005Bp-RE for 30190@debbugs.gnu.org; Sat, 03 Feb 2018 22:40:17 -0500 Received: by mail-pg0-f53.google.com with SMTP id w17so15969171pgv.6 for <30190@debbugs.gnu.org>; Sat, 03 Feb 2018 19:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=LKWc1ywGZhVTJq5XJRPhdcP9MvSTHooGWYCRXF87yOs=; b=ttUwuJLhUt/Nq1aWtlBeY6r03wCAcfZ07kPYckHoLH1zZWwDIXkM3K8+oWCKlPSk2Z cVKHC3MTE7kmHA6PbkKG/pQycGAcq4nfWCtrsKy8TsDHB8+pnpbqjPMCFmw4L6m+UqfY TiZft4NaMmlRcLOwMz93Rxv8gB2yZ88/HTU/xrGkfgvox9vug0yvGt9yGsXELqqFcW8D EitC74VWMZ2tauiUfNFk0W50hpi+lB8d76xUJ1x9k2A2pJG2SDkqbrRprJfhJ45JGlsh +FZNRWbKvqpGjczSkzKfpcbxDqgNXcwGzr+l4CSROklHjsQR1qlfjTM25n3N6KOBJNf4 eL9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=LKWc1ywGZhVTJq5XJRPhdcP9MvSTHooGWYCRXF87yOs=; b=OMiNVPyu53oyDOyxVpxcV7WezgAmreG7zokY4PuiSXD7gagvILywGp+MEaDjoK/FJz PwTYFopK11Rgc1/ZUG1cFZ2Tx3HVdY82kAEQiyLXpXkqRNOuoK0mEunvMkluYE5w87f+ ZlHnpvMftCeTfQjN34D2veMJA5FtNc2dx4S5IMb7SChjL5PcqqCLd/piA7/Ne/FYl0QJ zOG1qlDKy0axchlg7mBSak6IzOkAQi6eXTtXa0eLIu7CKyrqGHddka1GkByPl2quE3JP HUKjhNUn4mgUWeliuJ98wpokO+4dtBAnNe3e4V0hrENqz0Z4B1nPXi3YKhDwXI7C7Bkn RWwQ== X-Gm-Message-State: AKwxytcMYeqPrN0lTrL/SW55E+AMwbG5AnKFI4uAdfE8jbayo9npEoqA /kJ2vNKjJEC6UhY2SA/crQ0= X-Google-Smtp-Source: AH8x226c3kKVnVsiJZjsurM4RL0SOpUA2oWEPg7IDIx8cyxo3IrbMkn/GunwZoGHXmmuDRt2InRYuQ== X-Received: by 10.99.164.25 with SMTP id c25mr35003075pgf.430.1517715611089; Sat, 03 Feb 2018 19:40:11 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id w10sm8719704pgr.57.2018.02.03.19.40.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Feb 2018 19:40:10 -0800 (PST) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 4 Feb 2018 12:40:07 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <83vafe9f16.fsf@gnu.org> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1969643053-1517715610=:4034" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, npostavs@users.sourceforge.net, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --8323329-1969643053-1517715610=:4034 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sat, 3 Feb 2018, Eli Zaretskii wrote: > My feedback is that such a radical solution with so many lines of code > is a no-no for the release branch. Please look for a simpler > solution, perhaps don't create a new file? A suitable patch for the next release for discussion below: --8<-----------------------------cut here---------------start------------->8--- commit 2a0f243ff63772bb16ce4e3666b5fd5e696ea68f Author: tino calancha Date: Sun Feb 4 12:32:04 2018 +0900 Prevent term run in line mode from showing user passwords For buffers whose mode derive from comint-mode, the user password is read from the minibuffer and it's hidden. A buffer in term-mode and line submode, instead shows the passwords. This commit forces buffers in line term-mode to hide passwords (Bug#30190). * lisp/term.el (term-password-prompt-regexp): New user option. (term-watch-for-password-prompt): New function. (term-send-input, term-emulate-terminal): Call it. (term-output-filter-hook): New hook. Add term-watch-for-password-prompt to it. (term-send-input, term-emulate-terminal): Call the new hook each time we receive output. diff --git a/lisp/term.el b/lisp/term.el index 3970e93cf1..49fbc58cf3 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -558,6 +558,27 @@ term-suppress-hard-newline ;; indications of the current pc. (defvar term-pending-frame nil) +;; Stolen from comint.el +(defcustom term-password-prompt-regexp + (concat + "\\(^ *\\|" + (regexp-opt + '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" + "Old" "old" "New" "new" "'s" "login" + "Kerberos" "CVS" "UNIX" " SMB" "LDAP" "PEM" "SUDO" + "[sudo]" "Repeat" "Bad" "Retype") + t) + " +\\)" + "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)" + "\\(?:\\(?:, try\\)? *again\\| (empty for no passphrase)\\| (again)\\)?" + ;; "[[:alpha:]]" used to be "for", which fails to match non-English. + "\\(?: [[:alpha:]]+ .+\\)?[\\s  ]*[::៖][\\s  ]*\\'") + "Regexp matching prompts for passwords in the inferior process. +This is used by `term-watch-for-password-prompt'." + :version "27.1" + :type 'regexp + :group 'comint) + ;;; Here are the per-interpreter hooks. (defvar term-get-old-input (function term-get-old-input-default) "Function that submits old text in term mode. @@ -586,6 +607,17 @@ term-input-filter-functions This variable is buffer-local.") +;;; Stolen from comint.el +;;;###autoload +(defvar term-output-filter-hook '(term-watch-for-password-prompt) + "Functions to call after output is inserted into the buffer. +One possible function is `term-watch-for-password-prompt'. +These functions get one argument, a string containing the text as originally +inserted. + +You can use `add-hook' to add functions to this list +either globally or locally.") + (defvar term-input-sender (function term-simple-send) "Function to actually send to PROCESS the STRING submitted by user. Usually this is just `term-simple-send', but if your mode needs to @@ -2134,7 +2166,8 @@ term-send-input (set-marker term-pending-delete-marker pmark-val) (set-marker (process-mark proc) (point))) (goto-char pmark) - (funcall term-input-sender proc input))))) + (funcall term-input-sender proc input) + (run-hook-with-args 'term-output-filter-hook ""))))) (defun term-get-old-input-default () "Default for `term-get-old-input'. @@ -2264,6 +2297,21 @@ term-send-invisible (term-send-string proc str) (term-send-string proc "\n"))) +;;; Stolen from comint.el +;; TODO: This file share plenty of code with comint.el; it might be worth +;; to extract the common functionality into a new file. +(defun term-watch-for-password-prompt (string) + "Prompt in the minibuffer for password and send without echoing. +This function uses `term-send-invisible' to read and send a password to the buffer's +process if STRING contains a password prompt defined by +`term-password-prompt-regexp'. + +This function could be in the list `term-emulate-terminal'." + (when (term-in-line-mode) + (when (let ((case-fold-search t)) + (string-match term-password-prompt-regexp string)) + (term-send-invisible nil)))) + ;;; Low-level process communication @@ -3121,6 +3169,8 @@ term-emulate-terminal (term-handle-deferred-scroll)) (set-marker (process-mark proc) (point)) + ;; Run these hooks with point where the user had it. + (run-hook-with-args 'term-output-filter-hook str) (when save-point (goto-char save-point) (set-marker save-point nil)) --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.91 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-02-04 built on calancha-pc Repository revision: aafcd12eebff1549b3d4b4f8f8d0f24498c1aedf --8323329-1969643053-1517715610=:4034-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 07:41:00 2018 Received: (at 30190) by debbugs.gnu.org; 4 Feb 2018 12:41:01 +0000 Received: from localhost ([127.0.0.1]:56240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiJbQ-00037F-Ok for submit@debbugs.gnu.org; Sun, 04 Feb 2018 07:41:00 -0500 Received: from mail-it0-f50.google.com ([209.85.214.50]:38672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiJbP-000373-99 for 30190@debbugs.gnu.org; Sun, 04 Feb 2018 07:40:59 -0500 Received: by mail-it0-f50.google.com with SMTP id k6so12874438ita.3 for <30190@debbugs.gnu.org>; Sun, 04 Feb 2018 04:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CsgXolCRx2VjxtEsH8bfMUaN0rL/YVhNZr1Au/mpPGA=; b=r/16BX9mh0xiYQGWTX0dxH/gkGzNw+GS3TJRKFD7CRN07pWuSZetmZXbQR2YwspRiC JuQbeQ/6xvGJnh6aWWlHzhfd+9yxPbWwcS2hyxjW8YBJJq4nJiDRlDrTzzDNzPEOTE+x V9p/Wv5rETeButczDhFYkwsNj3HMiUeRqsNQ7X21kPm2qH/AdF/yJX4XUYXjaLWoIkKe /m7WzxEde7MigQMvuzn8+HGgiyLcjMvZhttKsN/ZXkREa4+rMz5SNzzVvBCm6FtcxuvX a9OawYcag8EqeCpjX0HNfpeFjaXUr5YkpidHjso6pfktRCSK+MOiwUpEbqrC1rBTFo1g ZLUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=CsgXolCRx2VjxtEsH8bfMUaN0rL/YVhNZr1Au/mpPGA=; b=gnXFev8aW8lXrMng7h3JZq11qFWkzSij53eab3LoRrBBW9k1Sl5T8SohM8/8I+PYJX t2Yp5lccVKOzDBqbELvCdPNksHuEnaADO/7DAzcr/pe6Zx88SWph40F1kajDjzMitYkp qVp35RS+X18x0RiCdLtL9JSfhfvwggupd/UQWbwOG82gm4rTkFHWYCQa5ueJSRYpG8gv 6A3w/Mzt6xaU2SJMHVacWJehr4gI7N/5EWpVUZ8wUr2dJTFkcTpCo2sjGBZ3loq7ZOpi rjPF5XhVs9AAOZ5Gp6kTwVJqmqXYn5Eu5r7pOxa8M9Cja6E/eQe9cZgqQwrc1JPZmgNR oXOw== X-Gm-Message-State: APf1xPCVwn1khHWj22z01Fd52raxd1DrBOy6/gEO2BrNQWMYdOuHeBpX 7s5OeXJnmOb+/SxbBgbW/m0dQw== X-Google-Smtp-Source: AH8x2260U8k4sqMGKkRsXIFTHPeLDgucSXCHqb/RCOjNwimQ0IScEi399I6ZKoIWw3H+L7szLQw+2w== X-Received: by 10.36.101.208 with SMTP id u199mr4185989itb.117.1517748053342; Sun, 04 Feb 2018 04:40:53 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z3sm3644874itf.0.2018.02.04.04.40.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Feb 2018 04:40:51 -0800 (PST) From: Noam Postavsky To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> Date: Sun, 04 Feb 2018 07:40:50 -0500 In-Reply-To: (Tino Calancha's message of "Sun, 4 Feb 2018 12:40:07 +0900 (JST)") Message-ID: <87a7wpexm5.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Tino Calancha writes: > On Sat, 3 Feb 2018, Eli Zaretskii wrote: > >> My feedback is that such a radical solution with so many lines of code >> is a no-no for the release branch. Please look for a simpler >> solution, perhaps don't create a new file? > A suitable patch for the next release for discussion below: > > +;; Stolen from comint.el > +(defcustom term-password-prompt-regexp > + :version "27.1" I guess this should say "26.1". Although maybe we should just use comint-password-prompt-regexp in term.el instead? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 07:48:08 2018 Received: (at 30190) by debbugs.gnu.org; 4 Feb 2018 12:48:08 +0000 Received: from localhost ([127.0.0.1]:56244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiJiK-0003He-GR for submit@debbugs.gnu.org; Sun, 04 Feb 2018 07:48:08 -0500 Received: from mail-pg0-f49.google.com ([74.125.83.49]:45044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiJiI-0003HG-TW for 30190@debbugs.gnu.org; Sun, 04 Feb 2018 07:48:07 -0500 Received: by mail-pg0-f49.google.com with SMTP id r1so716754pgn.11 for <30190@debbugs.gnu.org>; Sun, 04 Feb 2018 04:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=h5ISj8KbQgFuXvGAPeG1dKIPtfG5AqaMQpVsq2NLE9Y=; b=WPQtxIRjO/eKECi7GWiCmjIMCSO49CUpR+yYpgt/MNjdSnPnjrsRaN6j43DvVFLVgz W9wqcHm+E4Ab1ixgBkwFV36jy6FCiVywSCJ/60obXauyXyOBjfyrfHn/9mMdAKXutrlL ZE8/SGgpRzl7laj/J2YtsAVHlTssChvBbf4LKZWQbUb0UBLdULqt2JIyJIT2jXrOGiqc qR4veCuaYZF2Bi87lkQPmTxCZABnm2PNDH7nJx5WO4CnbCIGM3TQm6dP1YmkQJbfYDmT iF+fW4xcnJcdciH5MXI9xgK2RQ4nwhiezly8kNMdB8tyykTDcuRfEZXdLLH9S8QbB9W+ E6eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=h5ISj8KbQgFuXvGAPeG1dKIPtfG5AqaMQpVsq2NLE9Y=; b=i1bzDVVdf0BqN1vE2x/NYoQ8+KGSBDtcLswptnib4JDiyced7Rksl8TF6187+bVlYx rG6YefeR4G0dUmpJcWt0jbEJvRk7tq36H0uK7U9zCQiB1y7nDOp4ndz3TT1AaSYmfrDM EatZVHLpset+biEYkH/oX9bZPjZP4h1w4mqlFdV4CflWilu1KBZ4M6s/CFmHtQA9cW0c 4E2I2AEt2uJHAfP4jTeqAc+lEwHpYGWF9LbaTs+5n8vA6e5cUYcwXF5XaIa5QPe643nq 7ErZIVt2e5gCt80oHStvscaeoWb0FH+T7kPL4c/jupNHYFTS6LzCGqEoxK6SQRhZGyYf W7ow== X-Gm-Message-State: AKwxytfluP+I+WLuWEVx0e6axlNwDWIey5MrLNbUbrHtKnQqeX4CUWHj BnF5SQ/lTE6DUREixfyT+qE= X-Google-Smtp-Source: AH8x2259lOAOlV+zjEpLIu8wadfO796Am3z4WARSsQ/GbCovQKn00eM2f6pmoJy0+udH2/aVxKHTsQ== X-Received: by 10.101.69.66 with SMTP id x2mr36173436pgr.69.1517748480979; Sun, 04 Feb 2018 04:48:00 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id j83sm7091973pfe.47.2018.02.04.04.47.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Feb 2018 04:47:59 -0800 (PST) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 4 Feb 2018 21:47:56 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <87a7wpexm5.fsf@users.sourceforge.net> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87a7wpexm5.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-816559170-1517748479=:24516" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --8323329-816559170-1517748479=:24516 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 4 Feb 2018, Noam Postavsky wrote: > Tino Calancha writes: > >> On Sat, 3 Feb 2018, Eli Zaretskii wrote: >> >>> My feedback is that such a radical solution with so many lines of code >>> is a no-no for the release branch. Please look for a simpler >>> solution, perhaps don't create a new file? >> A suitable patch for the next release for discussion below: >> > >> +;; Stolen from comint.el >> +(defcustom term-password-prompt-regexp > >> + :version "27.1" That's right. Well catched, thank you! Updated patch. > > I guess this should say "26.1". Although maybe we should just use > comint-password-prompt-regexp in term.el instead? Part of the fun is to prevent term.el from requiring comint.el as always has be done; just for using one variable I would not require comint.el. --8<-----------------------------cut here---------------start------------->8--- commit 6187b493ded4bdcfd3c6b6fa91333c381fba8913 Author: tino calancha Date: Sun Feb 4 21:43:43 2018 +0900 Prevent term run in line mode from showing user passwords For buffers whose mode derive from comint-mode, the user password is read from the minibuffer and it's hidden. A buffer in term-mode and line submode, instead shows the passwords. This commit forces buffers in line term-mode to hide passwords (Bug#30190). * lisp/term.el (term-password-prompt-regexp): New user option. (term-watch-for-password-prompt): New function. (term-send-input, term-emulate-terminal): Call it. (term-output-filter-hook): New hook. Add term-watch-for-password-prompt to it. (term-send-input, term-emulate-terminal): Call the new hook each time we receive output. diff --git a/lisp/term.el b/lisp/term.el index 3970e93cf1..6fddef6f82 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -558,6 +558,27 @@ term-suppress-hard-newline ;; indications of the current pc. (defvar term-pending-frame nil) +;; Stolen from comint.el +(defcustom term-password-prompt-regexp + (concat + "\\(^ *\\|" + (regexp-opt + '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" + "Old" "old" "New" "new" "'s" "login" + "Kerberos" "CVS" "UNIX" " SMB" "LDAP" "PEM" "SUDO" + "[sudo]" "Repeat" "Bad" "Retype") + t) + " +\\)" + "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)" + "\\(?:\\(?:, try\\)? *again\\| (empty for no passphrase)\\| (again)\\)?" + ;; "[[:alpha:]]" used to be "for", which fails to match non-English. + "\\(?: [[:alpha:]]+ .+\\)?[\\s  ]*[::៖][\\s  ]*\\'") + "Regexp matching prompts for passwords in the inferior process. +This is used by `term-watch-for-password-prompt'." + :version "26.1" + :type 'regexp + :group 'comint) + ;;; Here are the per-interpreter hooks. (defvar term-get-old-input (function term-get-old-input-default) "Function that submits old text in term mode. @@ -586,6 +607,17 @@ term-input-filter-functions This variable is buffer-local.") +;;; Stolen from comint.el +;;;###autoload +(defvar term-output-filter-hook '(term-watch-for-password-prompt) + "Functions to call after output is inserted into the buffer. +One possible function is `term-watch-for-password-prompt'. +These functions get one argument, a string containing the text as originally +inserted. + +You can use `add-hook' to add functions to this list +either globally or locally.") + (defvar term-input-sender (function term-simple-send) "Function to actually send to PROCESS the STRING submitted by user. Usually this is just `term-simple-send', but if your mode needs to @@ -2134,7 +2166,8 @@ term-send-input (set-marker term-pending-delete-marker pmark-val) (set-marker (process-mark proc) (point))) (goto-char pmark) - (funcall term-input-sender proc input))))) + (funcall term-input-sender proc input) + (run-hook-with-args 'term-output-filter-hook ""))))) (defun term-get-old-input-default () "Default for `term-get-old-input'. @@ -2264,6 +2297,21 @@ term-send-invisible (term-send-string proc str) (term-send-string proc "\n"))) +;;; Stolen from comint.el +;; TODO: This file share plenty of code with comint.el; it might be worth +;; to extract the common functionality into a new file. +(defun term-watch-for-password-prompt (string) + "Prompt in the minibuffer for password and send without echoing. +This function uses `term-send-invisible' to read and send a password to the buffer's +process if STRING contains a password prompt defined by +`term-password-prompt-regexp'. + +This function could be in the list `term-emulate-terminal'." + (when (term-in-line-mode) + (when (let ((case-fold-search t)) + (string-match term-password-prompt-regexp string)) + (term-send-invisible nil)))) + ;;; Low-level process communication @@ -3121,6 +3169,8 @@ term-emulate-terminal (term-handle-deferred-scroll)) (set-marker (process-mark proc) (point)) + ;; Run these hooks with point where the user had it. + (run-hook-with-args 'term-output-filter-hook str) (when save-point (goto-char save-point) (set-marker save-point nil)) --8<-----------------------------cut here---------------end--------------->8--- --8323329-816559170-1517748479=:24516-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 20:07:38 2018 Received: (at 30190) by debbugs.gnu.org; 5 Feb 2018 01:07:38 +0000 Received: from localhost ([127.0.0.1]:57501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiVFy-0000o3-9a for submit@debbugs.gnu.org; Sun, 04 Feb 2018 20:07:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiVFw-0000nn-27 for 30190@debbugs.gnu.org; Sun, 04 Feb 2018 20:07:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiVFq-0000iQ-1e for 30190@debbugs.gnu.org; Sun, 04 Feb 2018 20:07:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiVFg-0000Xt-Rx; Sun, 04 Feb 2018 20:07:20 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eiVFg-0004J8-5t; Sun, 04 Feb 2018 20:07:20 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Tino Calancha In-reply-to: (message from Tino Calancha on Sun, 4 Feb 2018 11:23:40 +0900 (JST)) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <87tvuyf2g0.fsf@users.sourceforge.net> Message-Id: Date: Sun, 04 Feb 2018 20:07:20 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] Passwords should be hidden, and we must fix this bug. Nobody should argue for sloppiness about this. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) Skype: No way! See https://stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 05 01:38:42 2018 Received: (at control) by debbugs.gnu.org; 5 Feb 2018 06:38:42 +0000 Received: from localhost ([127.0.0.1]:57627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiaQM-0000os-1E for submit@debbugs.gnu.org; Mon, 05 Feb 2018 01:38:42 -0500 Received: from mail-pl0-f48.google.com ([209.85.160.48]:42109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiaQK-0000og-UU for control@debbugs.gnu.org; Mon, 05 Feb 2018 01:38:41 -0500 Received: by mail-pl0-f48.google.com with SMTP id 11so11168045plc.9 for ; Sun, 04 Feb 2018 22:38:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:from:subject; bh=DbmXEmKkwGPG6tq9vwcz9aD/5IT4XZYnKaHAtd8I/mw=; b=LGmbDyn5cKEtgSPdmLIhMY7rUvMJ2eragrrE91i6O3mQW8xkBNuWvXYto4ZJDmIaHW x9YX9EiHnAkMp1K5Khgq6NrchYL+oM2zaUvxibTbXnLDQshl9iGwTxuqm+Dm+xwVChAa C8+jE7A/8O/wLiIxK7QusaWtgJ2/XTmYGaZrqnthno5QzX8bfdwsK+NoE3yYmDcTLl6T cdxwj3nMDSKYMDYpRu92PNe4Rty1yJn4hdq8KZeMsalyT5dNPOIt4p6gi/37EDrOEWUI CB+dMTkjs3YAOnwx1OKbLyghrbDJdcnXeS6UKlcBp4bIl/IH3mlqtX/c6x0xGvMlysTr oXhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:from:subject; bh=DbmXEmKkwGPG6tq9vwcz9aD/5IT4XZYnKaHAtd8I/mw=; b=PGj0d/3oCti/DmdtgjNuJbLsx6YCT9fmsUFp+4xX7jlFio/lNBhwlRPaHQd2J20jMH bW/ZU8/B6JuzuE3JRplgafcuE2g1hHabvzwWBTogtJTXpgZrp0gOoPslA7fHn6ibu0xH CFwyhxLapGn3Xnw4ZEh+p5dr+8+MdgOZhj4nPDJUl+AGpuNTnfs7cXhWoW0sfMAPzSFS cQk43v9hMtCOAfh1fRsuk9rFgkzkWup0g6j0XdGjQ7tCpbCPewPY0cwDhPcA5P7fP504 Jth0KfpzAxuHS/JCLtQMruXXlhxDnbVVkDtnLzQpUlOmj+Iyx0qcSrJ0SMm7uatYTx6x PWTg== X-Gm-Message-State: AKwxytfmw9B9BU7KPBbhUhy63ulxusfnyGi3nGjix33JEZ8zidDqjFpS NI1CUDI1YtgGK7MAh2Rsvcrpeg== X-Google-Smtp-Source: AH8x2254KW52SL4uNmIBbUbA/Ezge9DZY06rQxpMbOw8zSP2JkCGlNoskFZEI4GRTf5EA3QKy/xcRA== X-Received: by 2002:a17:902:8215:: with SMTP id x21-v6mr43203088pln.381.1517812714906; Sun, 04 Feb 2018 22:38:34 -0800 (PST) Received: from calancha-pc (FL1-125-193-170-29.tky.mesh.ad.jp. [125.193.170.29]) by smtp.gmail.com with ESMTPSA id m1sm1522781pfi.120.2018.02.04.22.38.33 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Feb 2018 22:38:34 -0800 (PST) Date: Mon, 05 Feb 2018 15:38:28 +0900 Message-Id: <87mv0ox7ob.fsf@gmail.com> To: control@debbugs.gnu.org From: Tino Calancha Subject: control message for bug #30190 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 30190 security From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 19:10:06 2018 Received: (at 30190) by debbugs.gnu.org; 15 Feb 2018 00:10:06 +0000 Received: from localhost ([127.0.0.1]:43465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em77l-0005dt-MM for submit@debbugs.gnu.org; Wed, 14 Feb 2018 19:10:06 -0500 Received: from mail-pg0-f50.google.com ([74.125.83.50]:41412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em77j-0005cu-OY for 30190@debbugs.gnu.org; Wed, 14 Feb 2018 19:10:04 -0500 Received: by mail-pg0-f50.google.com with SMTP id t4so2877869pgp.8 for <30190@debbugs.gnu.org>; Wed, 14 Feb 2018 16:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=rMCliFsy4twZBmuEyZR/dofEbLgBJGT0Y4+9TVCeKYw=; b=QZV0VS59TfRzUOLnBUt1SsW25YetzUeXr2DeKylIi1PVh3hct4BN6RrSjn1NeEzgiv w9PjygesOuy2EiEeYvp28Eou2txlxMiABNuHBTC0f2MJE7UbC658/9Cd06ch32JO66r1 k15dq+iyFL6NLcnbV2vRYAw8nPY03Kk6B05f07UJh4orF2A0a3BKhXiaZZPsm7IoTG6o xBahiE/xZF8gxJh8jdJMpp3KO+i2CC+a0yz8/nU3BAH1GIqKECzb40m8dobSPGq152B2 LBpGJaUCWKNlYLV/Fl6hReJa09X+hwQxnsv5e5vJ3gsaQdFBooVK8gemt4DJ4JZ1r9ee +8Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rMCliFsy4twZBmuEyZR/dofEbLgBJGT0Y4+9TVCeKYw=; b=lFgZM8uicoZs2N/nYMERgy3OXTREJ1K2TmyoVad1EUdtrb/noT8tnqx8CIkdH1L8yC oLXvh+Y8QgMOZNVKh7BFnI31cGd2nMiEhVdoX3d6mKRezHW55Pfe/eI+5Msk46SNBnyo 7NYgq0PNVBZtjkdpZ/1ny5wzBx3sC5UVlBuYGqA0uMwN1kWD018BSya34xcBS1TcU+ux +CwX0r2T2Wp8WUhdmMQuc8jbPwUeBUuDR+mg1IOwqbjNHRStEoJvbmWk6qYfRIXMi3fu A8Os8jQsKOjpWSJ/GgPCSbwszKbdpGiGXORYY/DB7vN3n+kgSl73xXnF3RQPCvZ7n0RY vocA== X-Gm-Message-State: APf1xPCuvOKlPNfwmYvp7Xos/667qkVw+ShfpxraBWbhjwnTFTi9HeYE oyh4Wm90io+bHjPNyXGSz3I= X-Google-Smtp-Source: AH8x225t35C21N1N5By2G9vZH1hil0k9owYekgSQ7gxXPtTN6yUBhKbG7DqaBR7oabmZpMkZlNAKAw== X-Received: by 10.99.131.198 with SMTP id h189mr628833pge.25.1518653397836; Wed, 14 Feb 2018 16:09:57 -0800 (PST) Received: from calancha-pc (FL1-125-193-170-29.tky.mesh.ad.jp. [125.193.170.29]) by smtp.gmail.com with ESMTPSA id b88sm29943885pfd.108.2018.02.14.16.09.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Feb 2018 16:09:56 -0800 (PST) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> Date: Thu, 15 Feb 2018 09:09:50 +0900 In-Reply-To: (Tino Calancha's message of "Sun, 4 Feb 2018 12:40:07 +0900 (JST)") Message-ID: <87wozfkt9t.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Richard Stallman , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Tino Calancha writes: > On Sat, 3 Feb 2018, Eli Zaretskii wrote: > >> My feedback is that such a radical solution with so many lines of code >> is a no-no for the release branch. Please look for a simpler >> solution, perhaps don't create a new file? > A suitable patch for the next release for discussion below: My patch is not satisfactory. It uses functions that haven't been tested enough: `term-send-invisible' and `term-read-noecho' are not used in the Emacs source tree: after playing a bit with the patch I found some problems (I even crashed Emacs several times, not so fun). I) `term-read-noecho' doesn't expect the user might hit , , `C-p' or `C-n'; it will try to convert these things to strings and return them. II) `term-send-invisible' doesn't cancel if the user hit `C-g'; instead it pass nil as the string for the process. The reason is how `term-read-noecho' handles `C-g'. My Emacs session crashes if I do (using the patch in this thread): M-x term RET C-c C-j sudo ls RET C-g C-g ;; Emacs crash! Note that I) and II) don't suppose any problem in a *shell* buffer if calling `send-invisible', which uses the more robust `read-passwd'. So I want to avoid using the not well tested `term-read-noecho'. Instead, I propose to use `read-passwd' as elsewhere within Emacs. This is the updated patch: --8<-----------------------------cut here---------------start------------->= 8--- commit 6254b0aca3c91ebd6d41f865c1cdcc13166c066d Author: tino calancha Date: Thu Feb 15 08:58:45 2018 +0900 Prevent term run in line mode from showing user passwords =20=20=20=20 For buffers whose mode derive from comint-mode, the user password is read from the minibuffer and it's hidden. A buffer in term-mode and line submode, instead shows the passwords. This commit forces buffers in line term-mode to hide passwords (Bug#30190). =20=20=20=20 * lisp/term.el (term-send-invisible): Prefer the more robust `read-passwd' instead of `term-read-noecho'. =20=20=20=20 (term-password-prompt-regexp): New user option. (term-watch-for-password-prompt): New function. =20=20=20=20 (term-send-input, term-emulate-terminal): Call it. (term-output-filter-hook): New hook. Add term-watch-for-password-prompt to it. =20=20=20=20 (term-send-input, term-emulate-terminal): Call the new hook each time we receive output. diff --git a/lisp/term.el b/lisp/term.el index 3970e93cf1..484a26cd7a 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -558,6 +558,27 @@ term-suppress-hard-newline ;; indications of the current pc. (defvar term-pending-frame nil) =20 +;; Stolen from comint.el +(defcustom term-password-prompt-regexp + (concat + "\\(^ *\\|" + (regexp-opt + '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the" + "Old" "old" "New" "new" "'s" "login" + "Kerberos" "CVS" "UNIX" " SMB" "LDAP" "PEM" "SUDO" + "[sudo]" "Repeat" "Bad" "Retype") + t) + " +\\)" + "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)" + "\\(?:\\(?:, try\\)? *again\\| (empty for no passphrase)\\| (again)\\)?" + ;; "[[:alpha:]]" used to be "for", which fails to match non-English. + "\\(?: [[:alpha:]]+ .+\\)?[\\s =C2=A0]*[:=EF=BC=9A=E1=9F=96][\\s =C2=A0= ]*\\'") + "Regexp matching prompts for passwords in the inferior process. +This is used by `term-watch-for-password-prompt'." + :version "26.1" + :type 'regexp + :group 'comint) + ;;; Here are the per-interpreter hooks. (defvar term-get-old-input (function term-get-old-input-default) "Function that submits old text in term mode. @@ -586,6 +607,17 @@ term-input-filter-functions =20 This variable is buffer-local.") =20 +;;; Stolen from comint.el +;;;###autoload +(defvar term-output-filter-hook '(term-watch-for-password-prompt) + "Functions to call after output is inserted into the buffer. +One possible function is `term-watch-for-password-prompt'. +These functions get one argument, a string containing the text as original= ly +inserted. + +You can use `add-hook' to add functions to this list +either globally or locally.") + (defvar term-input-sender (function term-simple-send) "Function to actually send to PROCESS the STRING submitted by user. Usually this is just `term-simple-send', but if your mode needs to @@ -2134,7 +2166,8 @@ term-send-input (set-marker term-pending-delete-marker pmark-val) (set-marker (process-mark proc) (point))) (goto-char pmark) - (funcall term-input-sender proc input))))) + (funcall term-input-sender proc input) + (run-hook-with-args 'term-output-filter-hook ""))))) =20 (defun term-get-old-input-default () "Default for `term-get-old-input'. @@ -2255,7 +2288,8 @@ term-send-invisible \\[view-lossage]." (interactive "P") ; Defeat snooping via C-x esc (when (not (stringp str)) - (setq str (term-read-noecho "Non-echoed text: " t))) + (let ((read-hide-char ?*)) + (setq str (read-passwd "Non-echoed text: ")))) (when (not proc) (setq proc (get-buffer-process (current-buffer)))) (if (not proc) (error "Current buffer has no process") @@ -2264,6 +2298,21 @@ term-send-invisible (term-send-string proc str) (term-send-string proc "\n"))) =20 +;;; Stolen from comint.el +;; TODO: This file share plenty of code with comint.el; it might be worth +;; to extract the common functionality into a new file. +(defun term-watch-for-password-prompt (string) + "Prompt in the minibuffer for password and send without echoing. +This function uses `term-send-invisible' to read and send a password to th= e buffer's +process if STRING contains a password prompt defined by +`term-password-prompt-regexp'. + +This function could be in the list `term-emulate-terminal'." + (when (term-in-line-mode) + (when (let ((case-fold-search t)) + (string-match term-password-prompt-regexp string)) + (term-send-invisible nil)))) + ;;; Low-level process communication =20 @@ -3121,6 +3170,8 @@ term-emulate-terminal (term-handle-deferred-scroll)) =20 (set-marker (process-mark proc) (point)) + ;; Run these hooks with point where the user had it. + (run-hook-with-args 'term-output-filter-hook str) (when save-point (goto-char save-point) (set-marker save-point nil)) --8<-----------------------------cut here---------------end--------------->= 8--- In GNU Emacs 26.0.91 (build 15, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-02-15 built on calancha-pc Repository revision: 874c0edf30308392bdba870e92247d7e4b0e66f4 Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9.3 (stretch) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 05:18:48 2018 Received: (at 30190) by debbugs.gnu.org; 21 Feb 2018 10:18:48 +0000 Received: from localhost ([127.0.0.1]:53632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoRU8-0000jR-1t for submit@debbugs.gnu.org; Wed, 21 Feb 2018 05:18:48 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoRU6-0000jB-FM for 30190@debbugs.gnu.org; Wed, 21 Feb 2018 05:18:46 -0500 Received: by mail-pf0-f176.google.com with SMTP id a6so479429pfi.2 for <30190@debbugs.gnu.org>; Wed, 21 Feb 2018 02:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qGKm4BcO91WoS5lBKMyYWhqOWpGnsfH15ClQ39gPwa8=; b=qjzVF45poPN1wKrhnbCQMO7mbg7NGb3SImFb6AWsSzFFDxd96WkaaZokBKhI0LXGeu HD8r2FM95xwuBs0FN5Bih7HVfTWt768pdqH6CwaVH9Gx8K7acIiXpRJO3amZKscxvtCp nItquKMY5MLnKSLo27uploN3pAoLCtJxvomOYc+A7oHsQicwU4okC4zz1C8+2yNkTYzh 60JtOfjg+B/nPsNrY0ZeAiivPn21JFhQ2qif6WTlrQBZmV25s9KjU7h8sVcgAk8LUhx0 6SNSWsYEdmjtcM2xl1dQjB7AmZ7/X0o+Gw1famFD86ZakmvThzcyBtHCJWo4gvn3MFBU sQhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qGKm4BcO91WoS5lBKMyYWhqOWpGnsfH15ClQ39gPwa8=; b=FWjoA6K45ylStqo+1M02vMKZY0JfapT3w92MKjLNvTRRq7kEsuIxkv3fJJQEI/CqDb J2dnfY+35GmOmBQz4G5Y8qKUmzAoAZBlyDjPRuWPeeEUAWp3v7ilmDnZn7HwMFe5fSeX 05VGYJV2gFAMXjYcOH//Mlyq08a1W/iMr/a/NcvRo3HJYxsOUknteilZln39L78DS+7V 5G9eWpt7jKzgeZfgY068JpVsYenz1vpjAJEqVT7fnwB5qZGdToDrwpsJ6uY98iAgUQJQ v/bGJskWWOVITk+XPFI9jwj0gGSrfEfDNDINmZZYd7N/E060RHEljxP9ZPw5lq07GFE3 dspQ== X-Gm-Message-State: APf1xPB3Vphxw1iTTKZz0Ptz2eaLdHVuzyY0O+tcUM8LrVTNOFN5wGzD LWQlTNdRUf7+Pxqs+FPg0brHoQ== X-Google-Smtp-Source: AH8x227okE/TJnFARobCSehpQskWOoJwDervZ+bgxmHpP/suduIYRhXwpcS1pjLH1n0Effh5RQWZCA== X-Received: by 10.101.74.73 with SMTP id a9mr2429693pgu.32.1519208320475; Wed, 21 Feb 2018 02:18:40 -0800 (PST) Received: from calancha-pc (FL1-122-130-160-183.tky.mesh.ad.jp. [122.130.160.183]) by smtp.gmail.com with ESMTPSA id a3sm55241624pgw.23.2018.02.21.02.18.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Feb 2018 02:18:39 -0800 (PST) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> Date: Wed, 21 Feb 2018 19:18:31 +0900 In-Reply-To: <87wozfkt9t.fsf@gmail.com> (Tino Calancha's message of "Thu, 15 Feb 2018 09:09:50 +0900") Message-ID: <87o9kiejd4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Richard Stallman , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Tino Calancha writes: > Tino Calancha writes: > > > This is the updated patch: > > commit 6254b0aca3c91ebd6d41f865c1cdcc13166c066d > Author: tino calancha > Date: Thu Feb 15 08:58:45 2018 +0900 . . . If anyone can show just cause why this patch cannot lawfully be joined together in Emacs-26 branch, let them speak now or forever hold their peace. Otherwise I will push this fix in a couple of days, and what the Emacs hacker has joined, no men ever separate. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 12:47:13 2018 Received: (at 30190) by debbugs.gnu.org; 21 Feb 2018 17:47:13 +0000 Received: from localhost ([127.0.0.1]:54724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoYU4-0005go-Qa for submit@debbugs.gnu.org; Wed, 21 Feb 2018 12:47:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoYU3-0005ga-D5 for 30190@debbugs.gnu.org; Wed, 21 Feb 2018 12:47:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoYTx-0001NQ-LW for 30190@debbugs.gnu.org; Wed, 21 Feb 2018 12:47:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoYTt-0001Lp-53; Wed, 21 Feb 2018 12:47:01 -0500 Received: from [176.228.60.248] (port=4686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eoYTm-0000iE-6i; Wed, 21 Feb 2018 12:46:54 -0500 Date: Wed, 21 Feb 2018 19:47:08 +0200 Message-Id: <83606q6xr7.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87o9kiejd4.fsf@gmail.com> (message from Tino Calancha on Wed, 21 Feb 2018 19:18:31 +0900) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Cc: 30190@debbugs.gnu.org, Richard Stallman , npostavs@users.sourceforge.net > Date: Wed, 21 Feb 2018 19:18:31 +0900 > > If anyone can show just cause why this patch cannot lawfully be joined > together in Emacs-26 branch, let them speak now or forever hold their > peace. You'll have to convince me that all of that is needed to fix the bug exposed by your recipe, and that we really cannot live with the bug until Emacs 27. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 03:52:41 2018 Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 08:52:41 +0000 Received: from localhost ([127.0.0.1]:53071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euaF7-0006ZI-0N for submit@debbugs.gnu.org; Sat, 10 Mar 2018 03:52:41 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euaF5-0006Yz-7R for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 03:52:39 -0500 Received: by mail-pf0-f170.google.com with SMTP id 68so2271024pfx.3 for <30190@debbugs.gnu.org>; Sat, 10 Mar 2018 00:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KSsG3fhALOdL0Jq0xgwh60qj3JrQxYgVRM7tEwiPwgE=; b=TWb5yT6p6HQslB6m5mQ9u3GJO0qIFo15ysgO1uuAvDMftvPDLSvcDRhxWL3JUWT9bp 96qfCH0GKZjUJl9HzfOtgngLy84S1b7ArvdcmxomTSteQg4h4pbU/5XkTdlJoxQP9YhM AvAjcZhkBU3hn7PllJFg8Z8Why2LBXUXjfr/X6uJLfNStDK7Ksv4dpSec828CGOPD7tC yQ7hGUirkiWOqo5RU3jyShbcAZyo//oKBOH4InMY1ugoz53BdwvVVoTQrlLyJY8DRSD9 qty/b8Wp2nsM0f7I+BW/MJJGnhxvTVC9lCwli2jYTrQZrZC8fhxUbBFJmmyKJkIYQrFt N/aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KSsG3fhALOdL0Jq0xgwh60qj3JrQxYgVRM7tEwiPwgE=; b=irg/TZLHM1pUV5pI/FVUBaDXTYFoP8ehVINY4P2HRSnRM8IgOadnliqR/GarmV3qY7 wr4DRuKCVvI1mzrq0gUFFsrvtv4N6MdX6AUjnO9r0E12h8wBjWiOEREeG/1KBI61FPyc ux8wdSWCicn7m0lrEFjoJgEqp05rSsWbyEixBOs+sQTx5mvkTQT7Is22uvA0ooeDATAk pLc+brqIO+lju2X9y2ds/0qxmASNM7Qn0wt1B/WQ+Jx6A22+WsENkshW9Ie+S3lkJPyP ZEARtLJA5pfrdDYwtbBHX1SSsPpd2KyrHEe8Q+8bZGrW20aWdSrU78mQdMHijJSCfwIP nksg== X-Gm-Message-State: AElRT7EBCSMe7g71AKQ7eOAsXHgb2odKYI95zP6kBdeiAp/xVJ3LM+aY FKq+MrZZYbIXshuYv3Ywag8= X-Google-Smtp-Source: AG47ELsnird/WSxoHz/wHGDvXfsdMArJNyTKXr7yIwEpYORplNFwS9iQ6t1YaF6xueMUjHuUmm39TQ== X-Received: by 10.99.105.7 with SMTP id e7mr1160174pgc.193.1520671953114; Sat, 10 Mar 2018 00:52:33 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id q87sm6995679pfa.29.2018.03.10.00.52.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Mar 2018 00:52:32 -0800 (PST) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> Date: Sat, 10 Mar 2018 17:52:25 +0900 In-Reply-To: <83606q6xr7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 21 Feb 2018 19:47:08 +0200") Message-ID: <873718qpme.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> From: Tino Calancha >> Cc: 30190@debbugs.gnu.org, Richard Stallman , npostavs@users.sourceforge.net >> Date: Wed, 21 Feb 2018 19:18:31 +0900 >> >> If anyone can show just cause why this patch cannot lawfully be joined >> together in Emacs-26 branch, let them speak now or forever hold their >> peace. Thanks for the replay, and sorry for the late response; I am quite busy guy last 2 months (next week even more :-S ). > You'll have to convince me that > 1. we really cannot live with the bug until Emacs 27. You can live with it. Many people can live with it. Indeed, this bug has been there since the addition of this lib. several releases before. I cannot live with it; any user using 'term.el' in line mode should not live with it. It's a security issue and should be taken seriously. IMO, Emacs sends the wrong message delivering a new release with a security bug, having a simple and well understood fix for it. Last week one of my teachers saw my email password in my screen. He was very serious about that, and requested me to please, _inmediately_ change my password. Ciertanly, many developers care about these kind of issues. >2. all of that is needed to fix the bug exposed by your recipe. The patch is crafted so that: * It just modifies one file, i.e. term.el. * Don't stablishes new dependencies between comint.el and term.el. With that in mind, you can how simple is the patch. It _just_ copy step by step what it is done in comint.el: term-password-prompt-regexp <--> comint-password-prompt-regexp term-output-filter-hook <--> comint-output-filter-functions term-watch-for-password-prompt <--> comint-watch-for-password-prompt Run hook 'term-output-filter-hook' in 'term-input-sender' <--> Run hook 'comint-output-filter-functions' comint-output-filter-functions 'term-send-invisible' uses `read-passwd' <--> 'send-invisible' uses `read-passwd' Run hook 'term-output-filter-hook' in 'term-emulate-terminal' <--> Run hook 'comint-output-filter-functions' in 'comint-output-filter' IMO the patch is simple, necessary and save to be included in Emacs-26. PD: Later on, for Emacs-27 we might want to reduce code duplication withing comint.el and term.el, for instance with the addition of a new file. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 05:25:51 2018 Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 10:25:51 +0000 Received: from localhost ([127.0.0.1]:53136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eubhH-0000bb-13 for submit@debbugs.gnu.org; Sat, 10 Mar 2018 05:25:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eubhF-0000bP-Sn for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 05:25:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eubh5-0000Es-OE for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 05:25:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eubgs-0008O5-Mw; Sat, 10 Mar 2018 05:25:26 -0500 Received: from [176.228.60.248] (port=2788 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eubgb-0006qD-87; Sat, 10 Mar 2018 05:25:10 -0500 Date: Sat, 10 Mar 2018 12:25:08 +0200 Message-Id: <83a7vgut17.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <873718qpme.fsf@gmail.com> (message from Tino Calancha on Sat, 10 Mar 2018 17:52:25 +0900) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net > Date: Sat, 10 Mar 2018 17:52:25 +0900 > > > You'll have to convince me that > > 1. we really cannot live with the bug until Emacs 27. > You can live with it. Many people can live with it. Indeed, this bug > has been there since the addition of this lib. several releases before. > > I cannot live with it; any user using 'term.el' in line mode > should not live with it. It's a security issue and should be > taken seriously. IMO, Emacs sends the wrong message delivering a new > release with a security bug, having a simple and well understood > fix for it. > > Last week one of my teachers saw my email password in my screen. He > was very serious about that, and requested me to please, _inmediately_ > change my password. Ciertanly, many developers care about these kind > of issues. > > >2. all of that is needed to fix the bug exposed by your recipe. > The patch is crafted so that: > * It just modifies one file, i.e. term.el. > * Don't stablishes new dependencies between comint.el and term.el. > > With that in mind, you can how simple is the patch. It _just_ copy > step by step what it is done in comint.el: Here's what bothers me about the patch: . it installs the filter even when term.el is not in line mode . it uses many constructs in term-password-prompt-regexp that could happen in unrelated text--does that mean such unrelated text will become invisible, thus making the session at least look buggy? The 2nd issue looks to me like a more serious one, unless I'm missing something. Is it possible to make sure we don't mistakenly take some innocent text as a password? Did you try in your testing to type text that matches this regexp, and if so, what did you see as result? From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 05:44:43 2018 Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 10:44:43 +0000 Received: from localhost ([127.0.0.1]:53140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eubzX-00015b-Lp for submit@debbugs.gnu.org; Sat, 10 Mar 2018 05:44:43 -0500 Received: from mail-pg0-f42.google.com ([74.125.83.42]:46658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eubzW-00015M-0n for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 05:44:42 -0500 Received: by mail-pg0-f42.google.com with SMTP id r26so4556763pgv.13 for <30190@debbugs.gnu.org>; Sat, 10 Mar 2018 02:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZRChNkVAuWNzcJbgoQjA8yCatGNIMAyPq/g8Cyw9z9Y=; b=MZ3rnXJv/xtXYPRPc1jzAoXu19SLacixxYlT7jkj+zi39U4U9utZp0n+DuSnEx03Rb psdIoBLybSEqqb3VPgt8QOINdMoafY2JwX+fIODWmuTtUhX9MixrGlW6WlApWZVx/EpW BzkJDAwG9DGmwfRcad/RCmJQCfFXzYcEsJ0piUlv8k9H9LppuMju9rHJjzD7gCbiDS9d 88NkwNqOzhw3pf5fURQ3vKRjoalIcLXfvO9ri9DtPQYM4hcJGrlosbe2x6gCt3e3KkXt ZI5pc/BND83RcoU8cgU+AINKMxkR0EMOzF4nEY2L+hzi1utkZ5I92gTrzhN0Itu5tCaa AoKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZRChNkVAuWNzcJbgoQjA8yCatGNIMAyPq/g8Cyw9z9Y=; b=gwi/8/xLhzoHJm9LCK3mM0UL6CAcoIyxVVFylXTAWauJP3sXmK+mCyRq/qg6MB2bup ucjFdFWRAUDuiyClB4gCJ5rcEFsSNYcvthAm5anwHnC6nFGqe/XeXcAhDJQrmOg+M8pJ LDCikNWeOpeZAviOY/yj0n+fI9mAnLU/niRRpLh8PhaJRKooAVIt5csfq0w1ejb8D745 Px0oUpPxdviVvef/S2bZ99khI4DOZTaw3iHtPYtcNgES6bjsBhzS/9fJDnilghBGbvfb +bzwgAAr+QbBj43xlgR5ovVsHeCs1hWYC21fRUiMDOiIQTGdpj6W8pgOwc3RPMNxa6Gh xD+g== X-Gm-Message-State: AElRT7G+sOpftaLdmlnKspX8782XimHwK3AZCnhn1nrqgpc181o/q3Ye mpTC1da5ZrB6ebNafbrRHvE= X-Google-Smtp-Source: AG47ELtKAlQbKiWPUDaKn/27TLqqW5vkoFu9/0PgYeYKTARwg580Dgp+pePqt6ygOTIXpDiJKEg2bw== X-Received: by 10.99.108.129 with SMTP id h123mr1444209pgc.30.1520678676208; Sat, 10 Mar 2018 02:44:36 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id p6sm7350508pfg.183.2018.03.10.02.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Mar 2018 02:44:35 -0800 (PST) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sat, 10 Mar 2018 19:44:13 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <83a7vgut17.fsf@gnu.org> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, npostavs@users.sourceforge.net, rms@gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sat, 10 Mar 2018, Eli Zaretskii wrote: > Here's what bothers me about the patch: > > . it installs the filter even when term.el is not in line mode It must install it by default, because the user might switch several times between char mode <-> line mode (I do a lot). Furthermore, 'term-watch-for-password-prompt' is a noop in char-mode. Besides that, 'term-send-input' is just called in line-mode, so the filter would ever be called in char mode. > . it uses many constructs in term-password-prompt-regexp that could > happen in unrelated text--does that mean such unrelated text will > become invisible, thus making the session at least look buggy? Regarding this issue, it would behave exactly as a dumb shell buffer does M-x shell RET I've never seen a bug report about that for comint.el. If you see that, you should definitely open a bug report! > The 2nd issue looks to me like a more serious one, unless I'm missing > something. Is it possible to make sure we don't mistakenly take some > innocent text as a password? Did you try in your testing to type text > that matches this regexp, and if so, what did you see as result? I tried just after I read your message. I don't find a problem. And as a pointed out above, it uses the same mechanism as comint.el (e.g. dumb shell buffers), so I don't think you should worry about it. > If anyone can show just cause why this patch cannot lawfully be joined > together in Emacs-26 branch, let them speak now or forever hold their > peace. I have booked all the celebration... :-S I hope I can marriage soon ;-) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 07:07:38 2018 Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 12:07:38 +0000 Received: from localhost ([127.0.0.1]:53185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudHl-0003Lo-VA for submit@debbugs.gnu.org; Sat, 10 Mar 2018 07:07:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudHj-0003La-QV for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 07:07:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eudHa-0003XR-Ob for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 07:07:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eudHP-0003VY-26; Sat, 10 Mar 2018 07:07:15 -0500 Received: from [176.228.60.248] (port=3050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eudHH-00088k-28; Sat, 10 Mar 2018 07:07:07 -0500 Date: Sat, 10 Mar 2018 14:07:07 +0200 Message-Id: <83y3j0t9qs.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Sat, 10 Mar 2018 19:44:13 +0900 (JST)) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Sat, 10 Mar 2018 19:44:13 +0900 (JST) > cc: Tino Calancha , 30190@debbugs.gnu.org, > rms@gnu.org, npostavs@users.sourceforge.net > > > . it uses many constructs in term-password-prompt-regexp that could > > happen in unrelated text--does that mean such unrelated text will > > become invisible, thus making the session at least look buggy? > Regarding this issue, it would behave exactly as a dumb shell buffer does > M-x shell RET > I've never seen a bug report about that for comint.el. If you see that, > you should definitely open a bug report! > > > The 2nd issue looks to me like a more serious one, unless I'm missing > > something. Is it possible to make sure we don't mistakenly take some > > innocent text as a password? Did you try in your testing to type text > > that matches this regexp, and if so, what did you see as result? > > I tried just after I read your message. I don't find a problem. Can you please show some examples? First, what text triggers the new functionality correctly, when the user types a password at some relevant prompt, and then what happens when an unrelated prompt is taken by the filter function as a prompt for a password. I'd like to understand better what happens in each case. > And as a pointed out above, it uses the same mechanism as comint.el > (e.g. dumb shell buffers), so I don't think you should worry about > it. Sorry, this doesn't really tell me enough, because I don't think I understand the relevance of dumb shells and comint to the issue at hand. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 08:17:35 2018 Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 13:17:35 +0000 Received: from localhost ([127.0.0.1]:53208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eueNR-00075r-VQ for submit@debbugs.gnu.org; Sat, 10 Mar 2018 08:17:35 -0500 Received: from mail-pl0-f46.google.com ([209.85.160.46]:39931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eueNP-00075d-TM for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 08:17:32 -0500 Received: by mail-pl0-f46.google.com with SMTP id s13-v6so6777054plq.6 for <30190@debbugs.gnu.org>; Sat, 10 Mar 2018 05:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=qRatvfHEMNtWfEbbx7x0GhzeIZKEnbu8U35xYG4k0XA=; b=rDzR2SA3oQmykd67hH/P08MbtPBbI0NwsI2oXuY1RLjY/Vij2zX9QEovNheh2v40mC zlv8zBsOsNBp5yZwMxgjUKj8x7O2L7TSMpYrWcHqoGvvVYlM+I6RrMHEZ6k6uQuWBnOu e/P6Zwk9iw/1frwtcPt0oV0J4eH4ytIrEOcnszEt1URHu//M+vM5Hpp8Kczy5BnU2FRh sJ5XzGBtLt5vHewws4sDKnbNvrQWhgD/3NCUliPgtvynl07aj9nTtNoOjTchRChh/LZB sXUtfnDq5og2cLy1+q4DKvzjeGsIgJrf2Znd7dw7GwX9KAeJ9mSmUuji+79XciTt2pcL 7PMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=qRatvfHEMNtWfEbbx7x0GhzeIZKEnbu8U35xYG4k0XA=; b=ijw+kXalgoXOk33Jbd031ndBJh795fdJ69NSJBqPVREQ3p30C2NASb5uFuMrk8Qyof nB2vwecnc6ZNpVA5u5UcpMMOIiZiBAvpi8+zZmLZwYNHlO6kESiB99JhE+92VIsNWQAU 9Ca+xD0Mhq4pqsuU8VBI8K+WZ4cL9FjWEBdzTL/Gv6o9U+82V7JWHeV4Y2XZej7M3po1 cPxrXFVljncvQfoAct9CAz5fGSHsbHue7amjlS63hR3D+HdCZBFRzdjnbyuzDsjYEEx7 W0UWJ3Qkne1/8W9RzAihLnf80XY2G0T0rmIRY0MZkSES3bO3EQPg7BLQqH4p8rifq8Q2 vaGw== X-Gm-Message-State: AElRT7HNa7lXxynqhkARwNn2D+uX/rRUP9qgwOVCWsUzwo69w20aM35H p94IbaZ/Mca8inixY9rlZdU= X-Google-Smtp-Source: AG47ELsGmlmiD3TWP1vBpuOfK3GeFdQTrfACHZOgzIYAiknlE/aia6YtsPDbFfOboQqEt2eRsG/VMA== X-Received: by 2002:a17:902:8d90:: with SMTP id v16-v6mr2051832plo.168.1520687845915; Sat, 10 Mar 2018 05:17:25 -0800 (PST) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id e83sm9046261pfk.148.2018.03.10.05.17.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Mar 2018 05:17:23 -0800 (PST) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <83y3j0t9qs.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 10 Mar 2018 14:07:07 +0200") References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> <83y3j0t9qs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sat, 10 Mar 2018 22:17:13 +0900 Message-ID: <87woykoysm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: >> I tried just after I read your message. I don't find a problem. > > Can you please show some examples? First, what text triggers the new > functionality correctly, when the user types a password at some > relevant prompt, and then what happens when an unrelated prompt is > taken by the filter function as a prompt for a password. I'd like to > understand better what happens in each case. Good behaviour: sudo ls # you are prompted in the minibuffer for your pass Bad behaviour: [sudo] password for foo: # This throws 'command not found' BUT _sometimes_ you are prompted for # your password in the minibuffer. # Note: This happens in a dumb shell buffer as well. >> And as a pointed out above, it uses the same mechanism as comint.el >> (e.g. dumb shell buffers), so I don't think you should worry about >> it. > > Sorry, this doesn't really tell me enough, because I don't think I > understand the relevance of dumb shells and comint to the issue at > hand. The relevance is that: I have copied from comint.el how to recognize a password prompt to redirect the prompt into the minibuffer (hidding the password). Whatever misfunction of my patch should happen in a dumb shell buffer started with: M-x shell IMO such side case is not an argument to reject this patch fixing a serious thing. I have uploaded a video running the above examples: https://www.dropbox.com/s/onr7peue6xd5fqh/record-desktop.mkv?dl=01 (BTW, got an offer to be the next 007 right after upload this video. Let's see. I am considering it...) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 10:51:27 2018 Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 15:51:27 +0000 Received: from localhost ([127.0.0.1]:54475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eugmN-00052b-DA for submit@debbugs.gnu.org; Sat, 10 Mar 2018 10:51:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eugmL-00052N-Oo for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 10:51:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eugmD-0006ZS-B2 for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 10:51:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eugm1-0006WV-Je; Sat, 10 Mar 2018 10:51:05 -0500 Received: from [176.228.60.248] (port=3364 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eugll-0006ro-LG; Sat, 10 Mar 2018 10:50:50 -0500 Date: Sat, 10 Mar 2018 17:50:49 +0200 Message-Id: <83sh98szdy.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87woykoysm.fsf@gmail.com> (message from Tino Calancha on Sat, 10 Mar 2018 22:17:13 +0900) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> <83y3j0t9qs.fsf@gnu.org> <87woykoysm.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net > Date: Sat, 10 Mar 2018 22:17:13 +0900 > > Bad behaviour: > [sudo] password for foo: > # This throws 'command not found' BUT _sometimes_ you are prompted for > # your password in the minibuffer. > # Note: This happens in a dumb shell buffer as well. What happens if you have a command (say, a shell script) that prompts for something that is not a password with a prompt that starts with text that matches the regexp -- what is the behavior then, after your changes? What I see here is that the filter redirects that to the minibuffer, and doesn't show the text I type, unlike what happened before your changes. Wouldn't that look like a bug and cause bug reports? I'm also worried by the "_sometimes_" part: does it mean the behavior is not deterministic? Why? > Whatever misfunction of my patch should happen in a dumb shell buffer > started with: > M-x shell Yes, but two wrongs don't make a right... From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 11 07:02:20 2018 Received: (at 30190) by debbugs.gnu.org; 11 Mar 2018 11:02:20 +0000 Received: from localhost ([127.0.0.1]:54708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyk7-0000pD-Vb for submit@debbugs.gnu.org; Sun, 11 Mar 2018 07:02:20 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:36458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyk6-0000oz-KH for 30190@debbugs.gnu.org; Sun, 11 Mar 2018 07:02:18 -0400 Received: by mail-pf0-f174.google.com with SMTP id 68so3143775pfx.3 for <30190@debbugs.gnu.org>; Sun, 11 Mar 2018 04:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=XxW5i3SLvp4kiYzuDHmzPFaMTv3l1dkYB5pUtYNFmAk=; b=ZJqEwhpDm6y/ef3ATWWl3RraWMAWy7zcEQp+HEAy/EIyVUXtwKPaWsEzBVEyEZYMy+ Az8TU/wSbWthW1xhwAfzpdUtmKcdFotRmBxJrFJ/l954hB1F/WlSzJaQh2aRjg11lbMJ WwVPIaVwWyFxIj+Uspp2A02EXS+udDR1VhkizBADqDh2y+ueengnEk4Y6e0mhT0OuUxG kYMRC/z2vGIxGieX29fvKu4lUfdWZKOsAobkF5IKn8FpIlMfE/mbJ2YxHspbHeYYhl6S wgew06hcqd5CQpjBOPDRoOvOmi1TSpwGymSPghTJ6+yT0rOyn7YtypbpmgsNknVcMDbw 7wTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=XxW5i3SLvp4kiYzuDHmzPFaMTv3l1dkYB5pUtYNFmAk=; b=Oo7FgkYxR7+Y+YS2DvxyorbkJXU1e/ddhQdKJO4TDe3myj088mhCwYwAEZC/fqt38M qG0xvngNEc0hZQa1yk724lAcsvCZMyEXxtSRYaKPf5qghf0BaeasqMTAxQQt98QYufA/ 8CXQg5CStvzwrLfhYOjV+OLr7e/CGiV0zyEFj9RewcuvXmIS1UAOMey0/Er++nO32oJj DqGbGaT79c4A8ezfwsruno+wxWou3vbpy+jQJCS5x6BpZ5KMqmRYfMWGQWoQpbwbEia8 +fA82kEiExGs/NdEmWrIItODk0cslDHIhwY/TfuDH56kjnparvb18OHGlSXfGNwnlvKn SV/A== X-Gm-Message-State: AElRT7HhqTDrDxf2StEtiKakEiYMjd7pFAoettJ6tLIulb1Ub3zeF0Kd vNm2Uy8+dRTJkaBnsd42dvc= X-Google-Smtp-Source: AG47ELs5XLZBACqZhDPKOvXvqvBIfmE5o8EpWpAYiDlihHeI+0c1rhkxZ52Q7c5YzvVvlmZdwFTysQ== X-Received: by 10.98.162.26 with SMTP id m26mr4451112pff.217.1520766132643; Sun, 11 Mar 2018 04:02:12 -0700 (PDT) Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id l129sm12135823pfl.82.2018.03.11.04.02.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Mar 2018 04:02:11 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 11 Mar 2018 20:02:08 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <83sh98szdy.fsf@gnu.org> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> <83y3j0t9qs.fsf@gnu.org> <87woykoysm.fsf@gmail.com> <83sh98szdy.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, npostavs@users.sourceforge.net, rms@gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sat, 10 Mar 2018, Eli Zaretskii wrote: >> From: Tino Calancha >> Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net >> Date: Sat, 10 Mar 2018 22:17:13 +0900 >> >> Bad behaviour: >> [sudo] password for foo: >> # This throws 'command not found' BUT _sometimes_ you are prompted for >> # your password in the minibuffer. >> # Note: This happens in a dumb shell buffer as well. > > What happens if you have a command (say, a shell script) that prompts > for something that is not a password with a prompt that starts with > text that matches the regexp -- what is the behavior then, after your > changes? What I see here is that the filter redirects that to the > minibuffer, and doesn't show the text I type, unlike what happened > before your changes. Wouldn't that look like a bug and cause bug > reports? IMO, if the regexp is matched, then you must be prompt in the minibuffer. It is the responsability of the person writing the script to chose sensible variable names, and right prompts. If I am prompted and I expect I shouldn't, then what is happening is that I wrote a poor script. > I'm also worried by the "_sometimes_" part: does it mean the behavior > is not deterministic? Why? This is not crafted from me; it how it's designed in comint.el. It must mean that the long strings are send in chunks. That would be a totally independent bug report. Actually if it's a bug or not is arguable: don't think it is, at least until we canot fire it in a more sensical example that the toy string: [sudo] password for: >> Whatever misfunction of my patch should happen in a dumb shell buffer >> started with: >> M-x shell > > Yes, but two wrongs don't make a right... There levels of wrongs: showing a password is simply too wrong. And 2 wrongs, sharing same code give more testers, i.e., more chances to detect the anomaly to finally fix it. Anyway I already have patched my local sources and I am happy with that. I don't have time to argue further, so I give up. My team is pushing me to focus in our project. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 11 13:05:08 2018 Received: (at 30190) by debbugs.gnu.org; 11 Mar 2018 17:05:08 +0000 Received: from localhost ([127.0.0.1]:55625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ev4PE-0006nR-3j for submit@debbugs.gnu.org; Sun, 11 Mar 2018 13:05:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ev4PC-0006n4-QN for 30190@debbugs.gnu.org; Sun, 11 Mar 2018 13:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ev4P4-0001LM-H6 for 30190@debbugs.gnu.org; Sun, 11 Mar 2018 13:05:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev4Ot-0001Gt-PM; Sun, 11 Mar 2018 13:04:47 -0400 Received: from [176.228.60.248] (port=1401 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ev4Ok-00030S-QY; Sun, 11 Mar 2018 13:04:39 -0400 Date: Sun, 11 Mar 2018 19:04:41 +0200 Message-Id: <838taytufq.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Sun, 11 Mar 2018 20:02:08 +0900 (JST)) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> <83y3j0t9qs.fsf@gnu.org> <87woykoysm.fsf@gmail.com> <83sh98szdy.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Sun, 11 Mar 2018 20:02:08 +0900 (JST) > cc: Tino Calancha , 30190@debbugs.gnu.org, > rms@gnu.org, npostavs@users.sourceforge.net > > I don't have time to argue further, so I give up. Too bad, because I wasn't arguing at all, just trying to figure out how safe is this patch... From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 20 00:09:31 2018 Received: (at 30190) by debbugs.gnu.org; 20 Jun 2018 04:09:32 +0000 Received: from localhost ([127.0.0.1]:56824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVUR1-0007ot-Ke for submit@debbugs.gnu.org; Wed, 20 Jun 2018 00:09:31 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:46925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVUQz-0007og-EA for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 00:09:29 -0400 Received: by mail-io0-f182.google.com with SMTP id d22-v6so2231159iof.13 for <30190@debbugs.gnu.org>; Tue, 19 Jun 2018 21:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EDCRDg4+8wEyhve3J/pENpVbeDFVVqzu/plpxBIFrM0=; b=QLKLbXJF1pQXCarq/0EPXlp0SxEbEIIKdzNPFSPcgLKSzMOSdCS3L0SfNVrlx/leKm anQ1MtdshmoeB0+DW6XuGyvyJBaYmU5P2ZnMUa1GV8b43D1s1G3fvufnB+mDPjDbFc5O UPyWOWqaMghUHYauUXCJZlZVfYivJWQmuWyvEMYcZYbqbgmbP4a40F7bnVOqnh5u4oMR IxxXGChdjG1GL2+eeGKADsC7LIFgEEOnwoyA1qzaPN3YjwSH8LT73w1neETrBYcH6LvP dT7s2JYHN5ov/7OV8Dkcaz62bn4SyRzTQ59YlJ0lIo1fWTB7G+h+MQMU8VqVEk/cpm1y 8XqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EDCRDg4+8wEyhve3J/pENpVbeDFVVqzu/plpxBIFrM0=; b=hZO4nOsLKMFT3mdI/JBN595Q6aZ7r2Y7EiLmzBHTxiyjxyOrUFdbbqj0Jh+/RkxBbl /qeqFpRz9HjAac5sfqaJy2c4i7jXrVOPrjcRybH4m59hohRKLN6twGQakW2bWktU71wf b1dqBEqe1j/VSFf5WuwwhSWdt7qneWgtAuCejbV4Bkrri+uSeYgqC26r4HS+KeJjaZjR 0O5e2moe3TPdPyLsdHmbs1QgegYucLggtBOB1hUxDr8hjiWANiL6uJ/jSoKg40s35aE3 XI4Gy5wzcWht1nEC9NAYYo35U1cmMKptR6zUaaIAi4nQz6e+xT7uhQ3YAHH0bXfXM8qQ t3fQ== X-Gm-Message-State: APt69E18E98Ei/i/pQDyrK8mwim0Zi1YBF6yX95xzDL6oImVIzsKfCIR hieWgnAhOTR2VGfOQIbU1Ug= X-Google-Smtp-Source: ADUXVKLDxP8klUmjfv7/K+7fkPkDbZ5MgOXcVUnoLRj9xXpKX6WbKmvjmNU4NFCpbEN/hxyxtNHOYA== X-Received: by 2002:a6b:c004:: with SMTP id q4-v6mr15639844iof.61.1529467764028; Tue, 19 Jun 2018 21:09:24 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w7-v6sm814276ita.34.2018.06.19.21.09.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Jun 2018 21:09:23 -0700 (PDT) From: Noam Postavsky To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> Date: Wed, 20 Jun 2018 00:09:22 -0400 In-Reply-To: <873718qpme.fsf@gmail.com> (Tino Calancha's message of "Sat, 10 Mar 2018 17:52:25 +0900") Message-ID: <87in6erte5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , npostavs@users.sourceforge.net, 30190@debbugs.gnu.org, rms@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tino Calancha writes: > Eli Zaretskii writes: > >> You'll have to convince me that >> 1. we really cannot live with the bug until Emacs 27. > You can live with it. Many people can live with it. Indeed, this bug > has been there since the addition of this lib. several releases before. This patch missed 26.1, but perhaps we should consider it for 26.2? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 20 12:27:45 2018 Received: (at 30190) by debbugs.gnu.org; 20 Jun 2018 16:27:45 +0000 Received: from localhost ([127.0.0.1]:57861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVfxR-0003lv-Ir for submit@debbugs.gnu.org; Wed, 20 Jun 2018 12:27:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVfxQ-0003li-7L for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 12:27:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVfxI-0003UM-0Z for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 12:27:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVfxH-0003UG-Tf; Wed, 20 Jun 2018 12:27:35 -0400 Received: from [176.228.60.248] (port=4015 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fVfxH-0000Mu-Al; Wed, 20 Jun 2018 12:27:35 -0400 Date: Wed, 20 Jun 2018 19:27:40 +0300 Message-Id: <83efh1s9s3.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87in6erte5.fsf@gmail.com> (message from Noam Postavsky on Wed, 20 Jun 2018 00:09:22 -0400) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: Eli Zaretskii , 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net > Date: Wed, 20 Jun 2018 00:09:22 -0400 > > This patch missed 26.1, but perhaps we should consider it for 26.2? I'm for fixing this in Emacs 26.2, but I still don't think I understand why the latest patch proposed in the discussion of this bug needs to "steal" so much from comint.el? Also, why does term-watch-for-password-prompt need to be invoked via a hook? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 20 19:28:41 2018 Received: (at 30190) by debbugs.gnu.org; 20 Jun 2018 23:28:41 +0000 Received: from localhost ([127.0.0.1]:58065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVmWn-0007HI-3x for submit@debbugs.gnu.org; Wed, 20 Jun 2018 19:28:41 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:55831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVmWm-0007H3-6K for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 19:28:40 -0400 Received: by mail-it0-f50.google.com with SMTP id 16-v6so2056392itl.5 for <30190@debbugs.gnu.org>; Wed, 20 Jun 2018 16:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bJbu10QcB1j/2BZlJZnGnIkMLAw3P4Yvqj21e3AtiTA=; b=afXa/1nRsMuOXvKm+N2iEwhKYRqQ8xQcEzriYExsKsJQsOCdWeKf5XHc7AOxOhJeaR UQ/oTYA/ogPEai/fB9kPxmotoT5mUJz+jJmph/YRRDEklUwBKX6OoAhhKXs1/MrroCmN hGySgv7+g+F2knvsO2NNKdVGhAcY94kGOJtvYltAB+5yMWlaJyZ4V/PC3g3rMWwx3OVT VLpCMyrf+B17fqEpWg4WpAB3NUUr29VFAwYaKaea83cshtiYGjZmoL38x6vVnra12FZf MUH+XZoJMXEOu4sAvWYhZu/vZ8gehERQQhP7IpaJp/oribtlMFH1HyVw4ZwVCyUIzSWI Cd4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bJbu10QcB1j/2BZlJZnGnIkMLAw3P4Yvqj21e3AtiTA=; b=WQHMsYeG1s+lg/SOnI+8vH0YjxVmqput8n+lzX9bLsyVTKWM3nLwAXTr8kR1GFLejG YHQCBuhBWrfJEnwA7q3DkNV85ad8yN6XEehDrcAef04PI2RW+UNWktxDp5YHRv8g15Ex jC32Y+2mVHoB8C4t4qFBn10iJDCTOT8NT6Lz42sIqtvqodtAm5hupJBgCdpcMX8PRzET 9n5lRXuEI+SXJOnmkz117JI9nzWP1/jnX2TK/sfwtwGEiKkjBebsMJGeXm4nxk6h0ebz 0DStlyDiNJzXUexd5gxVihWxr8Yf1nAxdug5RuN7f2zKwzmqFPFmzvHbprPUBU2cbpPw 9eUQ== X-Gm-Message-State: APt69E0ez181xXxlk16ur8DH6+AiJUsFkrvLn04Cu5TGIgIrBXHp93/9 GhWlX65GI1tp5pb4zY/hjAc= X-Google-Smtp-Source: AAOMgpe136xH1R9kei6CqYQ/musa6r+U3zEFdo8yu/B4pmanYSKikoT8dZHXYE5l8//+fbCK31vYYw== X-Received: by 2002:a24:efc2:: with SMTP id i185-v6mr3131088ith.57.1529537314550; Wed, 20 Jun 2018 16:28:34 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y36-v6sm2016884ita.4.2018.06.20.16.28.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jun 2018 16:28:33 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> Date: Wed, 20 Jun 2018 19:28:32 -0400 In-Reply-To: <83efh1s9s3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Jun 2018 19:27:40 +0300") Message-ID: <87602drqan.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I'm for fixing this in Emacs 26.2, but I still don't think I > understand why the latest patch proposed in the discussion of this bug > needs to "steal" so much from comint.el? > > Also, why does term-watch-for-password-prompt need to be invoked via a > hook? I don't these things are really required; as far as I understand, Tino did it that way in order to be safer: the "stealing" is to avoid loading comint.el, and using the hook is to keep the code closer to the already working example it's being copied from. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 20 21:31:13 2018 Received: (at 30190) by debbugs.gnu.org; 21 Jun 2018 01:31:13 +0000 Received: from localhost ([127.0.0.1]:58098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVoRM-0001DX-Cv for submit@debbugs.gnu.org; Wed, 20 Jun 2018 21:31:12 -0400 Received: from mail-pl0-f51.google.com ([209.85.160.51]:46070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVoRL-0001Cr-7T for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 21:31:11 -0400 Received: by mail-pl0-f51.google.com with SMTP id o18-v6so31271pll.12 for <30190@debbugs.gnu.org>; Wed, 20 Jun 2018 18:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=zRlrDaGKSJ/SBUKpiirvSvU8a1e5Y6gpbCiidgaqNGU=; b=UC0UIbDo1HBEEN/kehxVX8a6138ah+x5RWA+SUuZMPbx3rJmy3mdWREojlY4KksQ+p gz6H3G2Bv7UDuBriG18EALZpRRChWcFbrcMbaDzNM2pSsblUB3Ocm8hVO0MkrkGIdcOG 6zIS1ZQ8K/WLQqeW1u6VLYg5p1ABeJVsXR9FR9pN2zaPxO45vDnFVO258s5uGPLmgbL3 /gcSOKla4HNOtxU4+FKWAq0PoqdYUQdAVPJZJSSqR1O82RHzN8TxI4t8nTiU5nnp9OSg Vil9/jowiFA1RGijY0MkryCXyIKRI1hid6N0HxTlA46z8nXNFaOMC5MOWtJoEhU5l2iw PIGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=zRlrDaGKSJ/SBUKpiirvSvU8a1e5Y6gpbCiidgaqNGU=; b=IciRpATFtEZ5tggK4MKPW82fTtMTMaqb3fbufUhNFvX+/QqScbgFka0/KfUZkajZ39 J5T4QUpVNjtzAzrTU5+HVpZ/jqOxje6Bls9BX4zZig2rNpBVVEZvYhE88zRd4qfMdvdw DIu1BnnaDpHYd8/cHRTMFx7FJOZV7o91g6a5z6y/M6PBgjyMEBPhL/exW3Atd+Sgoscu EqqzxZQUbJD5vTEyUAa8avHKCmU95L0SCBeEZx70Scpxwe7oMZoLsKAZ5SWbNAzkRt/i pV3oruH3lECUi60R/PfsCbBgxqIecqEW8eOvbehQQErb8Sxjw1qYEAboQKCOD6U+DKQf hWeQ== X-Gm-Message-State: APt69E3cCp8i//DDW5KPER95L5zcWL4J+mT9orjvmB8jR3U7hKIPJ7VQ 7FF0uAtVHFx8zpDsfalMV+E= X-Google-Smtp-Source: ADUXVKKmzV/5LwS5TiqjkuZn4TuMmF39qHzISKzLmYOrsIRubcotxlNAgOpuq01EbksKmkCE9dVdtA== X-Received: by 2002:a17:902:6686:: with SMTP id e6-v6mr26234648plk.35.1529544665231; Wed, 20 Jun 2018 18:31:05 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id n10-v6sm7044693pfb.27.2018.06.20.18.31.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 18:31:04 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Thu, 21 Jun 2018 10:31:01 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <87602drqan.fsf@gmail.com> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 20 Jun 2018, Noam Postavsky wrote: > Eli Zaretskii writes: > >> I'm for fixing this in Emacs 26.2, but I still don't think I >> understand why the latest patch proposed in the discussion of this bug >> needs to "steal" so much from comint.el? >> >> Also, why does term-watch-for-password-prompt need to be invoked via a >> hook? > > I don't these things are really required; as far as I understand, Tino > did it that way in order to be safer: the "stealing" is to avoid loading > comint.el, and using the hook is to keep the code closer to the already > working example it's being copied from. Exactly, I almost forgot this stuff. Noam now understands my patch better than me. Feel free to adjust it as you wish, you are very smart. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 20 22:44:23 2018 Received: (at 30190) by debbugs.gnu.org; 21 Jun 2018 02:44:23 +0000 Received: from localhost ([127.0.0.1]:58112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVpa9-0007FR-UL for submit@debbugs.gnu.org; Wed, 20 Jun 2018 22:44:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVpa7-0007EY-1z for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 22:44:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVpZz-0003fl-Ao for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 22:44:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVpZs-0003bF-RV; Wed, 20 Jun 2018 22:44:04 -0400 Received: from [176.228.60.248] (port=4793 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fVpZr-0000JY-7B; Wed, 20 Jun 2018 22:44:03 -0400 Date: Thu, 21 Jun 2018 05:44:08 +0300 Message-Id: <8336xgsvt3.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87602drqan.fsf@gmail.com> (message from Noam Postavsky on Wed, 20 Jun 2018 19:28:32 -0400) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com > Date: Wed, 20 Jun 2018 19:28:32 -0400 > > Eli Zaretskii writes: > > > I'm for fixing this in Emacs 26.2, but I still don't think I > > understand why the latest patch proposed in the discussion of this bug > > needs to "steal" so much from comint.el? > > > > Also, why does term-watch-for-password-prompt need to be invoked via a > > hook? > > I don't these things are really required; as far as I understand, Tino > did it that way in order to be safer: the "stealing" is to avoid loading > comint.el, and using the hook is to keep the code closer to the already > working example it's being copied from. Why is it a problem to load comint? Either in this case or even always? As for the hook: it looks strange to me to use hooks for this purpose, since IMO we are supposed to refrain from doing that as much as possible. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 20 23:08:07 2018 Received: (at 30190) by debbugs.gnu.org; 21 Jun 2018 03:08:07 +0000 Received: from localhost ([127.0.0.1]:58126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVpx8-0000np-Tg for submit@debbugs.gnu.org; Wed, 20 Jun 2018 23:08:07 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVpx7-0000mx-1Y for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 23:08:05 -0400 Received: by mail-pf0-f195.google.com with SMTP id b74-v6so769980pfl.5 for <30190@debbugs.gnu.org>; Wed, 20 Jun 2018 20:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=PaWAY0DZ1XJqoOKbojvLcYyr03DmQjGzqEel5rfWuls=; b=qQZfgWAx7MRXcnkBgyKChtkyHBRUTyfY1stVoh6DDMXiHxEfs34QYCqKueSgpo5PnR GL4QVDZXDgsSBQmgZD1g3kHJxzvbODO04Q/2T/Q62wc3ZB2xU3HxiqQ543KHCrJTmcVf cinyJAonlEPabLP7N9s8n122y2q0S5LR1Gah+sL3I7pCCWqRdTtfsUAe/P+b69LJE0Di IXV7hDxXcHpMCwbzNZtdPyoes4XfUBoRO33BmsF4q6k4SSHnTzapsjCaGq0+0rGd26hD s0ZBAp0v/rRr9CGvzCRQGTDQTbDFNFmcAw8XwoEUrsnqg6F4OGMnpDomq06nCio0tdna 3JGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=PaWAY0DZ1XJqoOKbojvLcYyr03DmQjGzqEel5rfWuls=; b=MAp7zvvslB/hStRhcQswdawBRpSEnUWvmTWclSlc17m4y08VpUCDCZu7C0ZZjArLb/ PPuvg7O/3ZkHQGsAMPtYQrpWLwzEN2AjD8YV+4muMToPxq2DALXtPmGJIjmaILMwWrqZ gypUl8ycQSv2Kp+dph7xBrzxIHtXszCsPisuYwHbbVbqEIaFV0sbakRJJSsZFSyNg03J rTDsPCJbs4V4I2Z77pnWzOHRZSRT/WX6+mk0WJbR+Ri4TU+5sI9VQQZKzzEKz4R7lWFU CJTIhLfl+MXeDbAUwhdrWNP30HusvXSybuXl5r+F3WYuNzJ/JJWDNEmL9MXWfYUtM5Yd YBJQ== X-Gm-Message-State: APt69E1PfEI5ezVFxFVJZhT8ZhB5Mn3rNglRHo0Uee/GJxaJBEYlJj2T DRHiVg50ivsgo5DMbB5QoXc= X-Google-Smtp-Source: ADUXVKJDVGJsGRVJIbxZrZoUEmfFTJVWM5tYS/1t8XAQ1R/kztF+o72ygbGIZ8ioHA6TjpI4v69dRg== X-Received: by 2002:a63:6ac5:: with SMTP id f188-v6mr20729824pgc.195.1529550479179; Wed, 20 Jun 2018 20:07:59 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id r27-v6sm7872629pfg.94.2018.06.20.20.07.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 20:07:58 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Thu, 21 Jun 2018 12:07:55 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <8336xgsvt3.fsf@gnu.org> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Noam Postavsky , Stefan Monnier , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 21 Jun 2018, Eli Zaretskii wrote: >> From: Noam Postavsky >> Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com >> Date: Wed, 20 Jun 2018 19:28:32 -0400 >> >> Eli Zaretskii writes: >> >>> I'm for fixing this in Emacs 26.2, but I still don't think I >>> understand why the latest patch proposed in the discussion of this bug >>> needs to "steal" so much from comint.el? >>> >>> Also, why does term-watch-for-password-prompt need to be invoked via a >>> hook? >> >> I don't these things are really required; as far as I understand, Tino >> did it that way in order to be safer: the "stealing" is to avoid loading >> comint.el, and using the hook is to keep the code closer to the already >> working example it's being copied from. > > Why is it a problem to load comint? Either in this case or even > always? I have the bias/personal-preference to avoid load new things when I make a change. Let's call it: 'disturb the least' with my patches. > As for the hook: it looks strange to me to use hooks for this purpose, > since IMO we are supposed to refrain from doing that as much as > possible. I must admit it: my patch brings cargo-cult from `comint.el'; comint.el performs such hook calls. My patch just tried to mimic what is done in `comint.el' and reproduce it in `term.el'. My hope was that the patch would be accepted frictionless: if it's already done in `comint.el', why not doing the same in `term.el'? The discussion turned out about point the implementation that we have in `comint.el', which is also good and interesting topic. A bit out of scope of my initial intentions, but very welcome anyway. Improve code is always a good thing. Stefan opinion on these 2 general questions might be very valuable. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 21 15:17:23 2018 Received: (at 30190) by debbugs.gnu.org; 21 Jun 2018 19:17:23 +0000 Received: from localhost ([127.0.0.1]:59375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW558-00088s-Vo for submit@debbugs.gnu.org; Thu, 21 Jun 2018 15:17:23 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:45962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW557-00088k-Hq for 30190@debbugs.gnu.org; Thu, 21 Jun 2018 15:17:22 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w5LJHpqB020025; Thu, 21 Jun 2018 15:17:51 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 2AF7D6611F; Thu, 21 Jun 2018 15:17:19 -0400 (EDT) From: Stefan Monnier To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> Date: Thu, 21 Jun 2018 15:17:19 -0400 In-Reply-To: (Tino Calancha's message of "Thu, 21 Jun 2018 12:07:55 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6313=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6313> : inlines <6711> : streams <1790352> : uri <2661954> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I have the bias/personal-preference to avoid load new things when > I make a change. Let's call it: 'disturb the least' with my patches. I'd prefer to re-use comint code rather than copy it. Copying might be tolerable for term-watch-for-password-prompt (it could conceivably require adjustments for the context of term-mode), but it's out of the question for term-password-prompt-regexp. > My patch just tried to mimic what is done in `comint.el' and reproduce > it in `term.el'. My hope was that the patch would be accepted frictionless: > if it's already done in `comint.el', why not doing the same in `term.el'? I'm not a great fan of the hooks in comint (tho I must say I haven't come up with anything really better either). And to the extent that you can set *-password-prompt-regexp buffer-locally in order to prevent *-watch-for-password-prompt from getting in the way, I don't see much benefit of going through a hook. [ The hook might be beneficial in itself, with a nil default value, but that's a different discussion. ] Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 21 23:34:27 2018 Received: (at 30190) by debbugs.gnu.org; 22 Jun 2018 03:34:27 +0000 Received: from localhost ([127.0.0.1]:59578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWCqA-0006dk-SK for submit@debbugs.gnu.org; Thu, 21 Jun 2018 23:34:27 -0400 Received: from mail-pl0-f45.google.com ([209.85.160.45]:46240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWCq8-0006dQ-V6 for 30190@debbugs.gnu.org; Thu, 21 Jun 2018 23:34:25 -0400 Received: by mail-pl0-f45.google.com with SMTP id 30-v6so2742957pld.13 for <30190@debbugs.gnu.org>; Thu, 21 Jun 2018 20:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=C0udaI+n8VtQ+CE+m71yhelBJjimKmrbWomek5cgh8k=; b=KV3CQUNUq0BwkeB156RWzzIp9FEkLxAColgUYrHF19mrclRixjKcc1Towhv1AAtkm8 5pxUL/XG5m+Q3kJRZShpovZP98CJfeHV8i9agYkftRSXn9ZwSrh4RAgJsz+Rzrhmg/Nx pfC9/UXqE7KlBeql69/2kuN1HAgOudWh6n8ChhUz/56GWU5ctHF3lS1uRT2g5xaFLF3F JVzhb0SbxxMUqTvIsAc95dbM2VIfKyNvgSFCaDtE8rPlf+c9p3coGkJnUycTdZNLxxhp wVotoxu+O0F/Qv0HUcqo7bm1EoTTrN8VYe2BURzybUt5kJ08DC3pp0EQrvblSAgWN0TN 0xlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=C0udaI+n8VtQ+CE+m71yhelBJjimKmrbWomek5cgh8k=; b=B4Vo3ubpZpMaoHUoXFflCiO+PxgkR8Aa+tQYNWzjXn+TtFPJO5/g4PENVid7jHyzd9 qnSBxFsFe0yJ5KATJZ5i0jzayVQXp9it5EFxuLryRqavoJCZIkONIR6BF5o6iXZDdMRq CduSozkr28F+TNXhLUVm5XS0VloOzygPNAUNxwPUXY00W5intM3mgeiZBVu0Ydsu4RrT KWb4pE393fuzuDl1EvcnwOBrHJFR996bQekILSuettz9HlyNJ56qySo+zUNE8UTgHPfd HsjkH1/jIt+6HfPSiUiZOkBJP0ieGviW+WiYwSD0MT1ss9S5BvdHifxEJoZ/2hkKA+CE 9iYg== X-Gm-Message-State: APt69E02dozzi+aFJPzMrytwNLMzwlp0L0+HQXFhQ0IKFLjCMmU8mxh6 h3T4LFaw3pd2c+zj9ktgQTw= X-Google-Smtp-Source: ADUXVKJgK6Ydmua2EJ9X+VYVPvVSvqJ+8F2/2600GJcvCMpClN+HOc+t+9kQFriYfgSJsbvoBaIcvA== X-Received: by 2002:a17:902:8bc6:: with SMTP id r6-v6mr30733992plo.257.1529638459149; Thu, 21 Jun 2018 20:34:19 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id z64-v6sm13055131pfi.150.2018.06.21.20.34.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 20:34:18 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Fri, 22 Jun 2018 12:34:15 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , Noam Postavsky , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 21 Jun 2018, Stefan Monnier wrote: > I'd prefer to re-use comint code rather than copy it. Copying might be > tolerable for term-watch-for-password-prompt (it could conceivably > require adjustments for the context of term-mode), but it's out of the > question for term-password-prompt-regexp. > >> My patch just tried to mimic what is done in `comint.el' and reproduce >> it in `term.el'. My hope was that the patch would be accepted frictionless: >> if it's already done in `comint.el', why not doing the same in `term.el'? > > I'm not a great fan of the hooks in comint (tho I must say I haven't > come up with anything really better either). > > And to the extent that you can set *-password-prompt-regexp > buffer-locally in order to prevent *-watch-for-password-prompt from > getting in the way, I don't see much benefit of going through a hook. > [ The hook might be beneficial in itself, with a nil default value, but > that's a different discussion. ] Thank you for the feedback! When my current mundane duties (cooking, studying, cleaning, grocery, jogging, take care of my cat and cactus, etc) offer me a break, I will prepare a new patch (not sure when I will find the time, hopefully soon): * It will recycle (require) `comint.el', i.e., it will use `comint-password-prompt-regexp'. * It will use the hook strategy until someone comes with something smarter. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 08:45:04 2018 Received: (at 30190) by debbugs.gnu.org; 22 Jun 2018 12:45:04 +0000 Received: from localhost ([127.0.0.1]:59746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLR1-0000Le-Ph for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:45:03 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:51571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLQy-0000Kw-Ou for 30190@debbugs.gnu.org; Fri, 22 Jun 2018 08:45:02 -0400 Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w5MCjVep018457; Fri, 22 Jun 2018 08:45:31 -0400 Received: by lechazo.home (Postfix, from userid 20848) id 012936045E; Fri, 22 Jun 2018 08:44:58 -0400 (EDT) From: Stefan Monnier To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> Date: Fri, 22 Jun 2018 08:44:58 -0400 In-Reply-To: (Tino Calancha's message of "Fri, 22 Jun 2018 12:34:15 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6314=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6314> : inlines <6711> : streams <1790422> : uri <2662341> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > * It will use the hook strategy until someone comes with something smarter. Something smarter is to unconditionally call *-watch-for-password-prompt right at the place where you added the "run-hook" (actually, only one of the two places), Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 07:56:54 2018 Received: (at 30190) by debbugs.gnu.org; 18 Jul 2018 11:56:54 +0000 Received: from localhost ([127.0.0.1]:46190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffl4f-0002iA-VE for submit@debbugs.gnu.org; Wed, 18 Jul 2018 07:56:54 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:53563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffl4d-0002hu-LC for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 07:56:52 -0400 Received: by mail-it0-f45.google.com with SMTP id 72-v6so3725488itw.3 for <30190@debbugs.gnu.org>; Wed, 18 Jul 2018 04:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RRtywVZqrDIs3CNBGQ7d1pvN+9IBQycZc1fnSubwnmQ=; b=tjsN3Bfor9OVKy2qWwFtsECXICYXGUtUrXByEbmYcWZyAn3rghKXQCFiRtBCmjrq1a nDJPOAbww5Mru6ctCuPKXYQamzURUYCaoc6XCJA6rrL2grCRzXOHVyfdQLuJVsZjmDaN K+zzHEl/+BR36vcc0CA1Zc7pyddjQnZXLZnkOE6gFT9PPFr7uAs09tUwnhCBRkfQJ8O5 +gWXJxIurzfs6PpYefnPqYZqcxmBXtf4p3XBgT2hycqQW0WPHHqeeCjl1YCerc236JCc jsWi8S7N5TMHP1OHsaldZXVJ18n4HIoJPH/hC/YC3I4JxPbZEZkDgVOU0jWASfKZCIWj DLWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RRtywVZqrDIs3CNBGQ7d1pvN+9IBQycZc1fnSubwnmQ=; b=TLFKrsVykQI5SdoXgW9SMuzy+c3YoqwZzSNucZjluq4UWOUPcohHU3cu5bUYL0hBnB BaaAoTkEtGsHn9I6uiKf29tbgGqJS9uLOtkSTAB0l5cwLe7HaJXEyKfdqpd1ThlEN5SC BrweW0INi75R0eq1dRHTLcVBAG9ZuL6FleseLE3wq69cLzmawrA76LpzXOkLzH78vJSd idsq+PF7TsZp2wltbzH0xKsOXCeLhhn7VkVMyAAPi60XbfqGqlsJNnO1Y0QCuSQP3D9Z YiyMzLIwQCuCdEiNHl0dneh23wamqeMXTloo6DAgxYAImYcdVRZvdJAV9fpPkhIa7O4p dotw== X-Gm-Message-State: AOUpUlFUcdOKo++GrAcVUhe3FVWd5OlZadwEKAtiPaVzD56Cp+b0jrLm xFqQ9qyxl7aPsgjV2vuGpMUyrQ== X-Google-Smtp-Source: AAOMgpcHAgkerFN18HtlA0WKWuJqxpeEuODM05X9TWm/Ks1J3A/o49fVIQH3TZ9D9Q7K+KcfrI7nEg== X-Received: by 2002:a24:3793:: with SMTP id r141-v6mr1779647itr.0.1531915005958; Wed, 18 Jul 2018 04:56:45 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i9-v6sm1461758iom.19.2018.07.18.04.56.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 04:56:45 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> Date: Wed, 18 Jul 2018 07:56:44 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 22 Jun 2018 08:44:58 -0400") Message-ID: <878t6892pv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: > unconditionally call *-watch-for-password-prompt right at the place > where you added the "run-hook" (actually, only one of the two places), Here is a modified version of Tino's patch which uses comint.el and does the above. Another difference is that we call term-watch-for-password-prompt on the decoded-substring (I believe that's required to match localized non-ASCII prompts correctly). I wasn't able to reproduce the problems described in #74 with any version of the patch (maybe it's dependent on timing?), so I'm not sure how much of a concern that is. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v3-0001-Prevent-line-mode-term-from-showing-user-password.patch Content-Description: patch >From 5e8f7abce1b1dd9796e5baab57dc6215850b3416 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Thu, 15 Feb 2018 09:09:50 +0900 Subject: [PATCH v3] Prevent line-mode term from showing user passwords For buffers whose mode derive from comint-mode, the user password is read from the minibuffer and it's hidden. A buffer in term-mode and line submode, instead shows the passwords. Make buffers in line term-mode to hide passwords too (Bug#30190). * lisp/term.el (term-send-invisible): Prefer the more robust `read-passwd' instead of `term-read-noecho'. (term-watch-for-password-prompt): New function. (term-emulate-terminal): Call it each time we receive non-escape sequence output. Co-authored-by: Noam Postavsky --- lisp/term.el | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lisp/term.el b/lisp/term.el index b7f5b0e7f2..f7cd7dcd6a 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -347,6 +347,7 @@ term-protocol-version (eval-when-compile (require 'cl-lib)) (require 'ring) (require 'ehelp) +(require 'comint) ; Password regexp. (declare-function ring-empty-p "ring" (ring)) (declare-function ring-ref "ring" (ring index)) @@ -2288,7 +2289,8 @@ term-send-invisible \\[view-lossage]." (interactive "P") ; Defeat snooping via C-x esc (when (not (stringp str)) - (setq str (term-read-noecho "Non-echoed text: " t))) + (let ((read-hide-char ?*)) + (setq str (read-passwd "Non-echoed text: ")))) (when (not proc) (setq proc (get-buffer-process (current-buffer)))) (if (not proc) (error "Current buffer has no process") @@ -2297,6 +2299,17 @@ term-send-invisible (term-send-string proc str) (term-send-string proc "\n"))) +;; TODO: Maybe combine this with `comint-watch-for-password-prompt'. +(defun term-watch-for-password-prompt (string) + "Prompt in the minibuffer for password and send without echoing. +This function uses `term-send-invisible' to read and send a password to the buffer's +process if STRING contains a password prompt defined by +`comint-password-prompt-regexp'." + (when (term-in-line-mode) + (when (let ((case-fold-search t)) + (string-match comint-password-prompt-regexp string)) + (term-send-invisible (read-passwd string))))) + ;;; Low-level process communication @@ -3152,6 +3165,9 @@ term-emulate-terminal (term-handle-deferred-scroll)) (set-marker (process-mark proc) (point)) + (when (stringp decoded-substring) + (term-watch-for-password-prompt (prog1 decoded-substring + (setq decoded-substring nil)))) (when save-point (goto-char save-point) (set-marker save-point nil)) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 08:32:31 2018 Received: (at 30190) by debbugs.gnu.org; 18 Jul 2018 12:32:31 +0000 Received: from localhost ([127.0.0.1]:46211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffld8-0003Yk-Tt for submit@debbugs.gnu.org; Wed, 18 Jul 2018 08:32:31 -0400 Received: from mail-pl0-f46.google.com ([209.85.160.46]:41318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffld7-0003YX-Fc for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 08:32:29 -0400 Received: by mail-pl0-f46.google.com with SMTP id w8-v6so1975011ply.8 for <30190@debbugs.gnu.org>; Wed, 18 Jul 2018 05:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=/WKuTGm/TrUBNCiuC8FwKsstHgZJjmrcJuaErC+wQog=; b=VpRf38InxtcJxg0hw6Q3mdu6fQwmg1ArE8jSjx6CyH6Z7V3lx7dIiDAfh/6Ir7H4jh InIzYgQ7vUP3Uf455ao0izuheKP0gMm45Q/o6DKYAxOrE6YSXGqAJkynVR7XaFAfFJln KqNM8u/zvALHNLIjLW5LpsNN2HE8JrZUFW9AjuL9heow3X5ujdxEYDhkbvai6KtUr166 Ol2zEF7tEtVwVfkYG/BFPFU+Ky9lVbSGNi24hILkc5CRVpV/hU5UCpLv8lnR7xmZNiGr NJdIQ67Xi7j9J0PeZFeFOpIM87dui0vvODOfnmZZVtbyV5J1zRIPIe8MWmDIOa0AGYLa B3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=/WKuTGm/TrUBNCiuC8FwKsstHgZJjmrcJuaErC+wQog=; b=EYRhzVRoSU9bheddTZE2k+SVOOJRz557XdfBVhKhbMjUYBSVhusxhLIUIIQvspDhsp udkyPNvDBlH35F8b3ICW+3Wv0wrbSPNGc7CaPGRe+rs122bAN3McmCRc9gYMfOBXaAIS AGoYewc3VvRN+P92V++7M7hauRrj3KVFuLeQWBcdWpxu9An4xAGce8HofzPGqN5jFzzd Nk+pM+j3IrxKA6s+dynVkcR3kRTvWUTjF6i1JR5eapfAhdbbYx6mOyXf6sF+HdIn87qJ 9ikSdMPTJ2Ye46rkMrMAnf7GC0gjlFjErqv5cBeBD7o6OwizgpXwLbnb2mLgtxRLSlK0 V55A== X-Gm-Message-State: AOUpUlEGZnikGcqORHFLTDd4c/Z6Qhev/YBv2uEbJD2xKtxaLz38D/t/ i+Yi4y+scvU+XtoiKJus4Bg= X-Google-Smtp-Source: AAOMgpdpSr8kwIqCqgvnqVVlXwx8LK8/dL1+2tlMc8f4n9lkD4Qce7ADrPKt0XZ62pHz7OwtrbYp/w== X-Received: by 2002:a17:902:342:: with SMTP id 60-v6mr5734501pld.311.1531917143496; Wed, 18 Jul 2018 05:32:23 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (195.139.137.133.dy.bbexcite.jp. [133.137.139.195]) by smtp.gmail.com with ESMTPSA id n12-v6sm8021715pfh.146.2018.07.18.05.32.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 05:32:22 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 18 Jul 2018 21:32:19 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <878t6892pv.fsf@gmail.com> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Here is a modified version of Tino's patch which uses comint.el and does > the above. Thank you Noam! Very happy to see this. The patch hide my password nicely :-) > Another difference is that we call > term-watch-for-password-prompt on the decoded-substring (I believe > that's required to match localized non-ASCII prompts correctly). Good observation. > I wasn't able to reproduce the problems described in #74 with any > version of the patch (maybe it's dependent on timing?), so I'm not sure > how much of a concern that is. I follow the recipe in my video and I cannot reproduce the funny issue mentioned there either. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 10:24:17 2018 Received: (at 30190) by debbugs.gnu.org; 18 Jul 2018 14:24:17 +0000 Received: from localhost ([127.0.0.1]:47055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffnNJ-0006OS-Cz for submit@debbugs.gnu.org; Wed, 18 Jul 2018 10:24:17 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:39815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffnNI-0006OL-28 for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 10:24:16 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6IEOv4V030718; Wed, 18 Jul 2018 10:24:58 -0400 Received: by ceviche.home (Postfix, from userid 20848) id AA4C166101; Wed, 18 Jul 2018 10:24:14 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> Date: Wed, 18 Jul 2018 10:24:14 -0400 In-Reply-To: <878t6892pv.fsf@gmail.com> (Noam Postavsky's message of "Wed, 18 Jul 2018 07:56:44 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6332=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6332> : inlines <6759> : streams <1792908> : uri <2675530> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks Noam, looks good. Couldn't help send you some nitpicks, tho, Stefan > @@ -2288,7 +2289,8 @@ term-send-invisible > \\[view-lossage]." > (interactive "P") ; Defeat snooping via C-x esc > (when (not (stringp str)) > - (setq str (term-read-noecho "Non-echoed text: " t))) > + (let ((read-hide-char ?*)) > + (setq str (read-passwd "Non-echoed text: ")))) > (when (not proc) > (setq proc (get-buffer-process (current-buffer)))) > (if (not proc) (error "Current buffer has no process") Why do we need to bind `read-hide-char` here? More specifically, shouldn't `read-passwd` do that for us (hence if it doesn't yet, then the right patch is to add this let-binding to `read-passwd`)? > @@ -2297,6 +2299,17 @@ term-send-invisible > (term-send-string proc str) > (term-send-string proc "\n"))) > > +;; TODO: Maybe combine this with `comint-watch-for-password-prompt'. Would be nice, yes. > +(defun term-watch-for-password-prompt (string) > + "Prompt in the minibuffer for password and send without echoing. > +This function uses `term-send-invisible' to read and send a password to the buffer's > +process if STRING contains a password prompt defined by > +`comint-password-prompt-regexp'." "... uses `term-send-invisible' to read [...] a password ..." is incorrect, since the password is read by `read-passwd` rather than by term-send-invisible. But in any case I don't see any reason to document in the docstring what internal mechanism is used [ I just fixed the comint version of the function accordingly. ] > @@ -3152,6 +3165,9 @@ term-emulate-terminal > (term-handle-deferred-scroll)) > > (set-marker (process-mark proc) (point)) > + (when (stringp decoded-substring) > + (term-watch-for-password-prompt (prog1 decoded-substring > + (setq decoded-substring nil)))) I suggest you add a comment explaining why we set decoded-substring to nil. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 10:56:47 2018 Received: (at 30190) by debbugs.gnu.org; 18 Jul 2018 14:56:47 +0000 Received: from localhost ([127.0.0.1]:47073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffnsk-0007B0-Rb for submit@debbugs.gnu.org; Wed, 18 Jul 2018 10:56:47 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:44977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffnsi-0007Al-PO for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 10:56:45 -0400 Received: by mail-pg1-f173.google.com with SMTP id r1-v6so2119578pgp.11 for <30190@debbugs.gnu.org>; Wed, 18 Jul 2018 07:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=9nTeLYGGtDckzQgYbrueOF0aleilTSzBWOT+56cdog8=; b=gWWulfUa/xPxA4lBztLS/lyTjc/0zvQGYJixf7OAbZtZko47+PmHCXR2inaMbu/FGO Ov+TFFrOF2OKZsrw5Ob7hYPeXJJh9QEWnEE7HCh4ZTlKRY+Y+QTyua+xiQiDP03rEc0x b9DK1wVkyY71qAzXcz7VlHRNLqESr7S/eIGQX4suLmHRGjiZIcLeUgnAb83/hhXaSiy0 5oyJVqtRhK/a8PCkDxjyMsletrZT8IMjJrbQOVGlNF8+5tMGqjfERcvU1kiPXFIlcRTX e6wWHdM2LblbRdnOtc2smb/1VwznYItxG59unxYc6Yj0hrYTBNuY5A22A73jqDHaoZGm CIeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=9nTeLYGGtDckzQgYbrueOF0aleilTSzBWOT+56cdog8=; b=FXHAjM1CzLCgKIirilKj+9E7rtOpxSNTQAmFKob/2FQjfcgWzsEIYuqSH1rhF0/HlD QMl/j/cn29mWTfr0/xaWjJF1WdjQQJUXKUdYePb8I+BxFn5PCJy0AwcX2hr2k32cTrV0 adVd87cwlnM0URkNZs+O4NNgtykV3wYYn38HTiwc9DhZwb+bzyyOuVvgIwo/AupgaD8y kzXN04gOLZmymuzz0RFZ6XLA8e/pa5ubB17HZNootFbXA+q9j+quuJqG30kUuX0jT5nR CmXYXaEvxkHvZY1u03snqtTfG64bV+wo55AZSNbfLtCmjgi3koQTVgWF4lMUkLa1RdCR V10Q== X-Gm-Message-State: AOUpUlGItP0sncuw5iVtOFXOZco7htZD1kBBqt4qXEkDIO0GWe+87rUB hzOmVZBblqxYSCu0zPoXd9c= X-Google-Smtp-Source: AAOMgpe+qofbI3I27S8waXkzemWdPbOVPS0TgunEq7gQY6g7B2AA9nMPq6NqaTG+WAiwLqkPaEQLxA== X-Received: by 2002:a63:62c4:: with SMTP id w187-v6mr6101105pgb.55.1531925798813; Wed, 18 Jul 2018 07:56:38 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (195.139.137.133.dy.bbexcite.jp. [133.137.139.195]) by smtp.gmail.com with ESMTPSA id w13-v6sm5578682pgt.84.2018.07.18.07.56.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 07:56:37 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 18 Jul 2018 23:56:34 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> @@ -2288,7 +2289,8 @@ term-send-invisible >> \\[view-lossage]." >> (interactive "P") ; Defeat snooping via C-x esc >> (when (not (stringp str)) >> - (setq str (term-read-noecho "Non-echoed text: " t))) >> + (let ((read-hide-char ?*)) >> + (setq str (read-passwd "Non-echoed text: ")))) >> (when (not proc) >> (setq proc (get-buffer-process (current-buffer)))) >> (if (not proc) (error "Current buffer has no process") > > Why do we need to bind `read-hide-char` here? I made this binding so that the user observes same characters (?*) to hide the input as with command: M-x term-send-invisble RET > More specifically, shouldn't `read-passwd` do that for us (hence if it > doesn't yet, then the right patch is to add this let-binding to > `read-passwd`)? I don't think so. `read-passwd' uses ?. as default. The docstring suggest us to let-bind `read-hide-char' in case we wish another char. Alternatively we could use ?. always as default, and change `term-send-invisble'. Personaly, I prefer ?* because my vision is quite poor and ?. looks too small :-| >> @@ -2297,6 +2299,17 @@ term-send-invisible >> (term-send-string proc str) >> (term-send-string proc "\n"))) >> >> +;; TODO: Maybe combine this with `comint-watch-for-password-prompt'. > > Would be nice, yes. Indeed, one of my favourite Beach Boys songs. >> @@ -3152,6 +3165,9 @@ term-emulate-terminal >> (term-handle-deferred-scroll)) >> >> (set-marker (process-mark proc) (point)) >> + (when (stringp decoded-substring) >> + (term-watch-for-password-prompt (prog1 decoded-substring >> + (setq decoded-substring nil)))) > > I suggest you add a comment explaining why we set decoded-substring to nil. Agreed. It's not obvious at first glance. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 11:54:51 2018 Received: (at 30190) by debbugs.gnu.org; 18 Jul 2018 15:54:51 +0000 Received: from localhost ([127.0.0.1]:47110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffomw-0002Gp-Sq for submit@debbugs.gnu.org; Wed, 18 Jul 2018 11:54:51 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:48325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffomu-0002Gg-O4 for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 11:54:49 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6IFtT8V013114; Wed, 18 Jul 2018 11:55:30 -0400 Received: by ceviche.home (Postfix, from userid 20848) id B920A66101; Wed, 18 Jul 2018 11:54:46 -0400 (EDT) From: Stefan Monnier To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> Date: Wed, 18 Jul 2018 11:54:46 -0400 In-Reply-To: (Tino Calancha's message of "Wed, 18 Jul 2018 23:56:34 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6332=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6332> : inlines <6759> : streams <1792914> : uri <2675562> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> More specifically, shouldn't `read-passwd` do that for us (hence if it >> doesn't yet, then the right patch is to add this let-binding to >> `read-passwd`)? > I don't think so. `read-passwd' uses ?. as default. The docstring suggest > us to let-bind `read-hide-char' in case we wish another char. But why does term-mode want to use a different char? What's so different about term-mode? > Alternatively we could use ?. always as default, and change > `term-send-invisble'. I don't understand what change to term-send-invisble you're thinking of. > Personaly, I prefer ?* because my vision is quite poor and ?. looks too > small :-| But your vision is not poor only in term-mode, right? So, what you're really saying here is that you'd like to change read-passwd to use ?* instead of ?., isn't it? If so, I have nothing against it, but it's a separate concern from that of bug#30190 and it should apply to all uses of read-passwd. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 19:28:31 2018 Received: (at 30190) by debbugs.gnu.org; 18 Jul 2018 23:28:31 +0000 Received: from localhost ([127.0.0.1]:47287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffvrz-0004JB-Ke for submit@debbugs.gnu.org; Wed, 18 Jul 2018 19:28:31 -0400 Received: from mail-pg1-f170.google.com ([209.85.215.170]:35684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffvry-0004Iy-HK for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 19:28:30 -0400 Received: by mail-pg1-f170.google.com with SMTP id e6-v6so2695909pgv.2 for <30190@debbugs.gnu.org>; Wed, 18 Jul 2018 16:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+pD39mwP097U2C5mbgmvWVoSGUOZPg3AeEw7OvozFRY=; b=nFVmD2tkEhNaKKAFOfyM3tNjNOLZvaZXdgPgTXcWCFkXO8yfros+tSOuxo25Ryl5II R/7+F+r5khub2/ruVWBsu+KQ8QEBzK3wSn5ho4ba5Xjiq15Vf/X7ewixCGZ+xuTAPaq/ Ur6i7S1ErUIU0KFR8CWTiZsHKU9ORzG5n9G4/pC8ZRd7f5OGQjPEqt8wgzuSZiBOUBXW 5E0MUiIftfyJ6eqcWT3jnkyEP/QH8Wx3nL2HT2pEE7j0mUNPKawjVbXizV0AIFPprKNf 5wyKecrOMWgso5uzXKxxQnzyQi+olEHf+30/z5QOkeJTSyVw/6rQD6oZAjCLJSOyomtG 9dzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=+pD39mwP097U2C5mbgmvWVoSGUOZPg3AeEw7OvozFRY=; b=VLuuQUvrB0y3TaJ9MlmN9v8S85yXB20vLXpDbymfN45L+lvcAlf1LKCMNFr6Sxl9pe EwtX5z7bh4D56B/Ahmi2UoKr/5rqPGvScmaUx5lBd6luF4Y7PB/Y+SK2/gw+KIek80yE LOmy1YNcmr24uCwBjkBqelM36Uc1mzTu9Jyjy17ktylzANq+BJfqthKk+ia/lwx4ZBhf 0x3YCAcLfRIyqx7kxUwp29KZgmSbaXDIdrmaUMUGbZFCRUmTY3GEK+bqueFbmnyxtZp/ E9O/TmxRqaTydoM5lonARhukD1VO9ZKT3akGiVZ1YO5cxtM27WEH7VBSF3+iaFjHAaxQ 5hgA== X-Gm-Message-State: AOUpUlHfBsMKsKtk3It9Q6jzc2QqwWWtKYh47XEfX1h3nK4/YjfOCcIO WhnnoYX2f46IP2miPtLknr0= X-Google-Smtp-Source: AAOMgpcUlNj8JM5XaXWeaCWvj/AA83sC1dkvqyXMOfMZlzk7FqBS+GtgtnSid5QaAzTfgmnycA3FEA== X-Received: by 2002:a65:5a8a:: with SMTP id c10-v6mr7360805pgt.389.1531956504732; Wed, 18 Jul 2018 16:28:24 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (195.139.137.133.dy.bbexcite.jp. [133.137.139.195]) by smtp.gmail.com with ESMTPSA id t12-v6sm6593376pgg.72.2018.07.18.16.28.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 16:28:23 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Thu, 19 Jul 2018 08:28:20 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 18 Jul 2018, Stefan Monnier wrote: >>> More specifically, shouldn't `read-passwd` do that for us (hence if it >>> doesn't yet, then the right patch is to add this let-binding to >>> `read-passwd`)? >> I don't think so. `read-passwd' uses ?. as default. The docstring suggest >> us to let-bind `read-hide-char' in case we wish another char. > > But why does term-mode want to use a different char? > What's so different about term-mode? Of course, nothing. I imagine it's for historical reasons; probably someone introduced ?* at some point in term.el and nobody cared about it. >> Alternatively we could use ?. always as default, and change >> `term-send-invisble'. > > I don't understand what change to term-send-invisble you're thinking of. I mean not passing non-nil 2nd argument here: (when (not (stringp str)) (setq str (term-read-noecho "Non-echoed text: " t))) ;; Above code is from `term-send-invisible'. >> Personaly, I prefer ?* because my vision is quite poor and ?. looks too >> small :-| > > But your vision is not poor only in term-mode, right? > So, what you're really saying here is that you'd like to change > read-passwd to use ?* instead of ?., isn't it? If so, I have nothing > against it, but it's a separate concern from that of bug#30190 and it > should apply to all uses of read-passwd. Let's be realistic, these kind of changes usually are not welcome. Not a problem though. It's very minor issue and many people would love ?. Since you look interested I tell a bit more; while I am introducing a hidden text (usually a password), I count the number of ?. to see if matches the length of the password. This is a fast mental check, don't bother to select the minibuffer contents and check its size. I find easier to count ?* than ?. But more than this personal issue from a handicapped person (visually), I care more about the lack of consistency, as you do: yeah, we should present uniformly the same char for any command hiding its input. How to achieve that? I am sure Eli find the proper way. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 20:02:22 2018 Received: (at 30190) by debbugs.gnu.org; 19 Jul 2018 00:02:22 +0000 Received: from localhost ([127.0.0.1]:47303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffwOk-00076b-4s for submit@debbugs.gnu.org; Wed, 18 Jul 2018 20:02:22 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:52270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffwOi-00076O-60 for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 20:02:20 -0400 Received: by mail-it0-f52.google.com with SMTP id p4-v6so6681545itf.2 for <30190@debbugs.gnu.org>; Wed, 18 Jul 2018 17:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9jMwt5Mr/bu2k/Gboa88Vo5QEOrG8CU8l8id+uWS2pA=; b=lXo61Py7jOg5XO4rzTj5cyCkmM+YqRlWWKsI1DcroAN8+kfARibcjqlSD7Sz66ZXF0 i942RloKyPurUicmadoE4Qz+AQIRpOlA1OUNx9cN3VMRRagbjfFHTRszxOPiknuliGbF PR0nLUchhqFbPdmqDcVV9f/D4JFHGKkvTBdl1vPzkibFD8aM7Z6Ok/+bK5wfXeOqEfAX aGjZf/9nEsF6VOg3ZAxo8d4sJYyy3t96XQhYXzLSQO0AKia/GReDduMErxWGYvbSJ7Sm enG1BNwbgUA71uttCiT3fMmA5E4a3Ed4hUGut+YvOfQXzHkyzZfnpP3TrV5UlJ/1ZTFH xcTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9jMwt5Mr/bu2k/Gboa88Vo5QEOrG8CU8l8id+uWS2pA=; b=M7vtWD314LHByxA//pdrSn6cjrbpopWkE2oAEpG/H7JcC45fgYPu37IPTpXNXWocPG VGMmArKQc8h09cdj/CeRVW3mtKplfRzJHWOWSmhqVm6VBV8kykIsIwBIQHICl7jjPeNO yD6ofS7iampPIV+kkXleF8nWpjWqN9egzvfHy422TbPZsOlN/1JJ/9wibz4FCHWfqWf1 KSOiuaJUMYlqT2khpRodYFCx6yJB4eLi88epGD3+X8E2AzKujXRzdxrAXShtP4l1xn8f /qmav8MUCdML8nqJDZd3dzlsarq64U7v1qnEOouPWZJIMYWuzKEzZWyBNS2zYxXD/Cw6 baEQ== X-Gm-Message-State: AOUpUlHhMrNigYknQUKM99gMCQk9osIN67L6imJqtc4PDAbwIn0E5NNt SpEsM+lWR9X5o+AOvLOzvzQ= X-Google-Smtp-Source: AAOMgpd13JjX/mjvRO1WAI4u5CxJjzLh4AtJ1A27eP9ThFETbF5LWippSfvDcxtOTCncJ3LeXIZQ7w== X-Received: by 2002:a24:f945:: with SMTP id l66-v6mr3177038ith.6.1531958534648; Wed, 18 Jul 2018 17:02:14 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w191-v6sm2172305ita.33.2018.07.18.17.02.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 17:02:13 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> Date: Wed, 18 Jul 2018 20:02:12 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 18 Jul 2018 10:24:14 -0400") Message-ID: <87zhyo6qkb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: > Couldn't help send you some nitpicks, tho, Thanks for reviewing :) >> @@ -2288,7 +2289,8 @@ term-send-invisible >> \\[view-lossage]." >> (interactive "P") ; Defeat snooping via C-x esc >> (when (not (stringp str)) >> - (setq str (term-read-noecho "Non-echoed text: " t))) >> + (let ((read-hide-char ?*)) >> + (setq str (read-passwd "Non-echoed text: ")))) >> (when (not proc) >> (setq proc (get-buffer-process (current-buffer)))) >> (if (not proc) (error "Current buffer has no process") > > Why do we need to bind `read-hide-char` here? > More specifically, shouldn't `read-passwd` do that for us (hence if it > doesn't yet, then the right patch is to add this let-binding to > `read-passwd`)? Tino mentioned "*" being more visible than ".", but poking at this a bit more, I notice that term-read-noecho uses "*", so I guess that was the original motivation. I've dropped the read-hide-char binding, I think it probably doesn't matter much either way. Another thing I noticed is that read-passwd doesn't have the view-lossage leak that term-read-noecho has, so I've removed that note from the docstring. >> +(defun term-watch-for-password-prompt (string) >> + "Prompt in the minibuffer for password and send without echoing. >> +This function uses `term-send-invisible' to read and send a password to the buffer's >> +process if STRING contains a password prompt defined by >> +`comint-password-prompt-regexp'." > I don't see any reason to document in the docstring what internal > mechanism is used Makes sense, I've trimmed the docstring. >> @@ -3152,6 +3165,9 @@ term-emulate-terminal >> (term-handle-deferred-scroll)) >> >> (set-marker (process-mark proc) (point)) >> + (when (stringp decoded-substring) >> + (term-watch-for-password-prompt (prog1 decoded-substring >> + (setq decoded-substring nil)))) > > I suggest you add a comment explaining why we set decoded-substring to nil. Ah, I carefully wrote a comment explaining why I did that, and then I realized it was wrong. There's not actually any need for it (I had got a bit mixed up and thought we might loop around and prompt twice, but this call is already after the loop). --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v4-0001-Prevent-line-mode-term-from-showing-user-password.patch Content-Description: patch >From 429082a5e14abefb503d39390044b92cd2328462 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Thu, 15 Feb 2018 09:09:50 +0900 Subject: [PATCH v4] Prevent line-mode term from showing user passwords For buffers whose mode derive from comint-mode, the user password is read from the minibuffer and it's hidden. A buffer in term-mode and line submode, instead shows the passwords. Make buffers in line term-mode to hide passwords too (Bug#30190). * lisp/term.el (term-send-invisible): Prefer the more robust `read-passwd' instead of `term-read-noecho'. (term-watch-for-password-prompt): New function. (term-emulate-terminal): Call it each time we receive non-escape sequence output. Co-authored-by: Noam Postavsky --- lisp/term.el | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/lisp/term.el b/lisp/term.el index b7f5b0e7f2..adbc0b0d88 100644 --- a/lisp/term.el +++ b/lisp/term.el @@ -347,6 +347,7 @@ term-protocol-version (eval-when-compile (require 'cl-lib)) (require 'ring) (require 'ehelp) +(require 'comint) ; Password regexp. (declare-function ring-empty-p "ring" (ring)) (declare-function ring-ref "ring" (ring index)) @@ -2283,12 +2284,10 @@ term-read-noecho (defun term-send-invisible (str &optional proc) "Read a string without echoing. Then send it to the process running in the current buffer. A new-line -is additionally sent. String is not saved on term input history list. -Security bug: your string can still be temporarily recovered with -\\[view-lossage]." +is additionally sent. String is not saved on term input history list." (interactive "P") ; Defeat snooping via C-x esc (when (not (stringp str)) - (setq str (term-read-noecho "Non-echoed text: " t))) + (setq str (read-passwd "Non-echoed text: "))) (when (not proc) (setq proc (get-buffer-process (current-buffer)))) (if (not proc) (error "Current buffer has no process") @@ -2297,6 +2296,16 @@ term-send-invisible (term-send-string proc str) (term-send-string proc "\n"))) +;; TODO: Maybe combine this with `comint-watch-for-password-prompt'. +(defun term-watch-for-password-prompt (string) + "Prompt in the minibuffer for password and send without echoing. +Checks if STRING contains a password prompt as defined by +`comint-password-prompt-regexp'." + (when (term-in-line-mode) + (when (let ((case-fold-search t)) + (string-match comint-password-prompt-regexp string)) + (term-send-invisible (read-passwd string))))) + ;;; Low-level process communication @@ -3152,6 +3161,8 @@ term-emulate-terminal (term-handle-deferred-scroll)) (set-marker (process-mark proc) (point)) + (when (stringp decoded-substring) + (term-watch-for-password-prompt decoded-substring)) (when save-point (goto-char save-point) (set-marker save-point nil)) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 21:58:52 2018 Received: (at 30190) by debbugs.gnu.org; 19 Jul 2018 01:58:52 +0000 Received: from localhost ([127.0.0.1]:47345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyDT-0003NN-NQ for submit@debbugs.gnu.org; Wed, 18 Jul 2018 21:58:51 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyDR-0003NF-It for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 21:58:50 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6J1wmXD000399; Wed, 18 Jul 2018 21:58:48 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 3730F661B8; Wed, 18 Jul 2018 21:58:48 -0400 (EDT) From: Stefan Monnier To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> Date: Wed, 18 Jul 2018 21:58:48 -0400 In-Reply-To: (Tino Calancha's message of "Thu, 19 Jul 2018 08:28:20 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6332=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6332> : inlines <6761> : streams <1792954> : uri <2675772> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Of course, nothing. I imagine it's for historical reasons; probably > someone introduced ?* at some point in term.el and nobody cared about it. I think this ?* came before the ?. of read-passwd, actually. > Let's be realistic, these kind of changes usually are not welcome. > Not a problem though. It's very minor issue and many people would love ?. Could be. I personally really don't have a preference, but I can definitely see that ?* might be more legible, and hence preferable for "rational" reasons rather than a mere preference. And I'm having trouble imagining people being emotionally tied to ?. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 22:00:34 2018 Received: (at 30190) by debbugs.gnu.org; 19 Jul 2018 02:00:34 +0000 Received: from localhost ([127.0.0.1]:47349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyF8-0003RR-4b for submit@debbugs.gnu.org; Wed, 18 Jul 2018 22:00:34 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:46461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyF6-0003RJ-F6 for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 22:00:33 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6J21Ev2026812; Wed, 18 Jul 2018 22:01:14 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 3EB22661B8; Wed, 18 Jul 2018 22:00:31 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> Date: Wed, 18 Jul 2018 22:00:31 -0400 In-Reply-To: <87zhyo6qkb.fsf@gmail.com> (Noam Postavsky's message of "Wed, 18 Jul 2018 20:02:12 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6332=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6332> : inlines <6761> : streams <1792954> : uri <2675773> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks. > - (setq str (term-read-noecho "Non-echoed text: " t))) > + (setq str (read-passwd "Non-echoed text: "))) I believe this remove the last use of term-read-noecho, so I think we can then get rid of it (or at least mark it obsolete). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 22:27:41 2018 Received: (at 30190) by debbugs.gnu.org; 19 Jul 2018 02:27:41 +0000 Received: from localhost ([127.0.0.1]:47392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyfM-00046m-Vv for submit@debbugs.gnu.org; Wed, 18 Jul 2018 22:27:41 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:40461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyfK-00046Y-Vf for 30190@debbugs.gnu.org; Wed, 18 Jul 2018 22:27:39 -0400 Received: by mail-it0-f46.google.com with SMTP id 188-v6so7198310ita.5 for <30190@debbugs.gnu.org>; Wed, 18 Jul 2018 19:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=dtUc79ArAUQpc8iTkWoC6iT4eDDDlpfQkHoocIUVH+o=; b=Py2kC+KSEirQefbTFa0W6KufsJEbDlclm6Zn8VNStP6/mwG7WLLTbpfvUw1g3c4wle Bo7nYWrSnfmNtOQ/oOgAxyirfcGkar3GhYDe6ANwdCtCXvrhliBRHrk91/91Ky3ntT+C VPr4IzkDjG++UxCmKb6N+WgladhqSQ2TvJ66UISForje0pO2+afoNalt76DoGFUFC1yT 6wAXOxG8M7fzSb3B/XW0eCgGZzsBrX8VibP1NO1Arv/bvM1opEVVtCN+QBYDx+xcTkHE auRADS7IDNM25Vpy+d72E2+zGzo4SSmDlKZajUa9jzlfifw5+ZReT9nQ2vLCp5h0jmBB 0N7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=dtUc79ArAUQpc8iTkWoC6iT4eDDDlpfQkHoocIUVH+o=; b=GCH1h+3Zd6nLeuitJ49xrKMtPiQjJAZzT4j3p23qYj6N00f+U4WaFHc2VPB5J9b1mE ypKHJW94tUqqZXfPI+hvM4rXaYu3tHkVWnuYCOXzdltrZL4KB7h63JODDW7iGA5EY1c8 UXwpvmfDM4Icx5yOKrHfRQe867oAX4BqzJlS4EFIzIXfJxchDglk9X+sPlKVO7V4ard5 e+CubmUF2HSK69hplcMw4hFRT/MhySeCem6q4kbLGgw+Nn2dQc4Iyt/h1COGdXpwbsZ4 MXPsZvTXMpJWjWGc3tYPAg60JHLBY0CMU+asj7OW6mQf+gMSDwwWfFFBD5StOT9onxDD ETZg== X-Gm-Message-State: AOUpUlFsTOswedyZpvTCMMaL9Z4g9+/X/PG7HzyxxZfEVJ/OEuotKdOi UW2XIzewSbeNWHbyFzjQTnM= X-Google-Smtp-Source: AAOMgpflTvsy76KugLBOUBmASS/ayUL5uhZ1ubJ1b1cghTR/9GH58vD9lpcfql1tB1p6B50DqmFW7w== X-Received: by 2002:a24:3997:: with SMTP id l145-v6mr4439730ita.134.1531967253583; Wed, 18 Jul 2018 19:27:33 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x6-v6sm441317ith.1.2018.07.18.19.27.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 19:27:32 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> Date: Wed, 18 Jul 2018 22:27:31 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 18 Jul 2018 21:58:48 -0400") Message-ID: <87k1ps6ju4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > And I'm having trouble imagining people being emotionally tied to ?. Yeah, ?* (?\x2A) probably won't be nearly controversial enough, to really get people going we should propose a fancy character like ?=E2=80=A2 (?\x2022) or ?=E2=97=8F (?\x25CF). From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 19 08:45:35 2018 Received: (at 30190) by debbugs.gnu.org; 19 Jul 2018 12:45:35 +0000 Received: from localhost ([127.0.0.1]:47605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fg8JK-0001cT-S7 for submit@debbugs.gnu.org; Thu, 19 Jul 2018 08:45:35 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:56962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fg8JI-0001cK-AT for 30190@debbugs.gnu.org; Thu, 19 Jul 2018 08:45:33 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6JCkErQ006725; Thu, 19 Jul 2018 08:46:14 -0400 Received: by pastel.home (Postfix, from userid 20848) id 9EC3E6582F; Thu, 19 Jul 2018 08:45:30 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87k1ps6ju4.fsf@gmail.com> Date: Thu, 19 Jul 2018 08:45:30 -0400 In-Reply-To: <87k1ps6ju4.fsf@gmail.com> (Noam Postavsky's message of "Wed, 18 Jul 2018 22:27:31 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6333=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6333> : inlines <6762> : streams <1792997> : uri <2675984> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> And I'm having trouble imagining people being emotionally tied to ?. > Yeah, ?* (?\x2A) probably won't be nearly controversial enough, > to really get people going we should propose a fancy character > like ?=E2=80=A2 (?\x2022) or ?=E2=97=8F (?\x25CF). Now you're talking! Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 20 03:34:17 2018 Received: (at 30190) by debbugs.gnu.org; 20 Jul 2018 07:34:17 +0000 Received: from localhost ([127.0.0.1]:48754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgPvd-0003m0-Gn for submit@debbugs.gnu.org; Fri, 20 Jul 2018 03:34:17 -0400 Received: from mail-pg1-f171.google.com ([209.85.215.171]:43774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgPvc-0003lp-OD for 30190@debbugs.gnu.org; Fri, 20 Jul 2018 03:34:17 -0400 Received: by mail-pg1-f171.google.com with SMTP id v13-v6so6114188pgr.10 for <30190@debbugs.gnu.org>; Fri, 20 Jul 2018 00:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=eBmUypjRRLKj1GvP5Eezuu+mppvsmoQP1Cl4JqRCBso=; b=oAt/Ture20k3VGh7beo6m5uQqgfCxwE947ZIkR1f+H4qsHUyS3PFqm679KawMSXmA8 COyUnoggYN17nMMZKUZpuqa8Xh9u5Fy/r7DYeP2JS+KZ0OnyNa+xwUcP9FjYiO0s1zWk skP6Ax11Z37XdOUI7ZtPPDDJh0zYUWvF9nUgO3yyhzvBbL4le563tMhnqVLLq5dJS12M 6leUNOthWvYH5YhsetZNuQOI83dW8r/i0m846DNn13EdkT2cCaUeL8hPVn7dqlKppykV HkzZ8zhgwNNMK9IEaGW72i2J0pN7fzAJZCEKuERMrF195WbrzRMCMmP1PMdPBVTMRWpU 3iGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=eBmUypjRRLKj1GvP5Eezuu+mppvsmoQP1Cl4JqRCBso=; b=olUDvagAmRtav1GH37kJc09D7sZemiZ+lycuMj5psAAEr0upxhgXqlKqALShI5Q/X2 L4UpDbFqAWQFMwBoje3HybGBJ2KfUwzFCD54+cpyxSsFktK+C+XgVxpdzT20zdskdx1g RTUjHxp1O3ZBPtcQjlGpMFQUR9KbXyNou48/PriN5K8G84OZNn6jHnc2OGCbzhw0Qjp6 F3Yo90JBdJyxuaMOwf3pTSybgbuXOAnBtWhy6TrJv8/nwH6P8OQNI0Toj9CJsAj+oaIo ntZXR4R1obFR3ElmSFai8iqqy7ImL88Vud5OrQwQrOcDw69c76hQWMvJWO9U9BIGJkEU CtIA== X-Gm-Message-State: AOUpUlEcK2LtV1fUq5QPC/Ku4KKhgnzmlhckLjvrKaOZYHUvMGzKMqYJ CYBkDznQ711YF1I4+PIAWa8= X-Google-Smtp-Source: AAOMgpcbLWGdVazDp3kparFwAJ9B3yhg/NowMeWjhNOEiEeY1E8plCmxYHO0axIuGT73pB+cXZ1uOw== X-Received: by 2002:a63:1722:: with SMTP id x34-v6mr1013107pgl.268.1532072050899; Fri, 20 Jul 2018 00:34:10 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (195.139.137.133.dy.bbexcite.jp. [133.137.139.195]) by smtp.gmail.com with ESMTPSA id d17-v6sm1251885pgp.50.2018.07.20.00.34.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jul 2018 00:34:09 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Fri, 20 Jul 2018 16:34:06 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: <87k1ps6ju4.fsf@gmail.com> Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87k1ps6ju4.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-1463782902-1411713276-1532072049=:17342" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ---1463782902-1411713276-1532072049=:17342 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 18 Jul 2018, Noam Postavsky wrote: > Stefan Monnier writes: > >> And I'm having trouble imagining people being emotionally tied to ?. > > Yeah, ?* (?\x2A) probably won't be nearly controversial enough, > to really get people going we should propose a fancy character > like ?• (?\x2022) or ?● (?\x25CF). I will open a bug report with this wishlist (I mean ?*). ---1463782902-1411713276-1532072049=:17342-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 14:33:28 2018 Received: (at 30190) by debbugs.gnu.org; 22 Jul 2018 18:33:28 +0000 Received: from localhost ([127.0.0.1]:52696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhJAe-0002No-Bp for submit@debbugs.gnu.org; Sun, 22 Jul 2018 14:33:28 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:37323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhJAc-0002Nc-MC for 30190@debbugs.gnu.org; Sun, 22 Jul 2018 14:33:26 -0400 Received: by mail-it0-f42.google.com with SMTP id p17-v6so20776738itc.2 for <30190@debbugs.gnu.org>; Sun, 22 Jul 2018 11:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XBA3eJ6NKmpwPBA1vELtswmA4LmV/Jl9h1IlDyoBby8=; b=g3oVsZtOC5z+g13kmzuEemDjswJiq0k65XQE+di9EedgP610lLbun5prANQbDGOkuh m7uNrKQzXQnilrjVGsUsPWghxxpJn0Ee9YqLx3Dn0ZxCfImZSNsRZqDHLSmftn7rkKs9 DPAC7fuuWcwZSGJjCmQKIL4xes69EYxKh9NkvtTj7lcHenE/zMVTIrMqBHlb5STQ3i5w nvTQ6eei6Temf2S+GH8HR29Hma1PZ3yG7xTvCPmWaqvrjXy/VIqT2P/qypH+bK4Bfofo G2/Ved0OYhi0V81rNVq/11RR2HIxWHK2OSb9RssdEmJX5VRqCQLkn56BeXV0oG3Gk+2O kTeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XBA3eJ6NKmpwPBA1vELtswmA4LmV/Jl9h1IlDyoBby8=; b=iDspF84i0yY7m5iK6XbcNOhXryqaWnqqEURouaUb8UgIgEBdSDdpemTm6RqPhaTi/o 5V8NQ6GCW4EhgEWqXLHMeP/uHKKpmf/j0JQc55zdV+BSnvCnYsWLkQQAwjgIv0Y6frGd QGpwOQRcWGww43bIGhAmJrKqjUQ4cMy0rSmGz+0JEhjxi5e5EXTr5OdHKfXnbom273DI BJw2UU578l1VCa7IteV7TdFYnB3Gr/q5VXdMWuF5Ec4Ps0ZoQAMcA8vBV40JHAvV2V/N DdzoX7lIB+QkyWE+g14Y0lINEH3yC4pW86cIBZyIhjrsYlxVDcEITBTv2VS4ZngioW8H zG0Q== X-Gm-Message-State: AOUpUlE/5+66MGe1aaGbv2UWTzbv+RScxlXdo7OAZL5vO1q5jzXH5vCo 9OM7vsqGz4DNsDqyn/YLDDc= X-Google-Smtp-Source: AAOMgpcyo7yhKH5SC8GBGFELLoAD/exA+C/1glo3Yoe7kzs9qnWtXWV30J17pvi+AAa9y2AWI/9/lQ== X-Received: by 2002:a02:9d03:: with SMTP id n3-v6mr8616547jak.113.1532284400947; Sun, 22 Jul 2018 11:33:20 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id t191-v6sm4088838ita.28.2018.07.22.11.33.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Jul 2018 11:33:20 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> Date: Sun, 22 Jul 2018 14:33:18 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 18 Jul 2018 22:00:31 -0400") Message-ID: <877eln5de9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> - (setq str (term-read-noecho "Non-echoed text: " t))) >> + (setq str (read-passwd "Non-echoed text: "))) > > I believe this remove the last use of term-read-noecho, so I think we > can then get rid of it (or at least mark it obsolete). Makes sense. I guess the obsoletion should go to master? Eli, is the patch in #131 okay for emacs-26? https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30190#131 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 14:44:35 2018 Received: (at 30190) by debbugs.gnu.org; 22 Jul 2018 18:44:35 +0000 Received: from localhost ([127.0.0.1]:52701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhJLP-0002dD-FZ for submit@debbugs.gnu.org; Sun, 22 Jul 2018 14:44:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhJLM-0002d0-2U for 30190@debbugs.gnu.org; Sun, 22 Jul 2018 14:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhJLG-0003p7-42 for 30190@debbugs.gnu.org; Sun, 22 Jul 2018 14:44:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhJLC-0003o6-AD; Sun, 22 Jul 2018 14:44:22 -0400 Received: from [176.228.60.248] (port=1202 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fhJLB-00089W-Ns; Sun, 22 Jul 2018 14:44:22 -0400 Date: Sun, 22 Jul 2018 21:44:25 +0300 Message-Id: <83lga3w1o6.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <877eln5de9.fsf@gmail.com> (message from Noam Postavsky on Sun, 22 Jul 2018 14:33:18 -0400) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, monnier@IRO.UMontreal.CA, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha > Date: Sun, 22 Jul 2018 14:33:18 -0400 > > Stefan Monnier writes: > > >> - (setq str (term-read-noecho "Non-echoed text: " t))) > >> + (setq str (read-passwd "Non-echoed text: "))) > > > > I believe this remove the last use of term-read-noecho, so I think we > > can then get rid of it (or at least mark it obsolete). > > Makes sense. I guess the obsoletion should go to master? > > Eli, is the patch in #131 okay for emacs-26? > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30190#131 Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 23 08:22:34 2018 Received: (at 30190) by debbugs.gnu.org; 23 Jul 2018 12:22:34 +0000 Received: from localhost ([127.0.0.1]:53150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhZrG-00004z-IH for submit@debbugs.gnu.org; Mon, 23 Jul 2018 08:22:34 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:45781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhZrC-0008WE-3x; Mon, 23 Jul 2018 08:22:30 -0400 Received: by mail-io0-f178.google.com with SMTP id k16-v6so337325iom.12; Mon, 23 Jul 2018 05:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ED8mu3drv0fM48qo5xm1xkFuy2Pq9N5GOrSvXYM68Rw=; b=W1HyGWVvR7XARS3O2pgPMDHrNjLD6t9s5vbcMHHAiZAzCNLilpT1GDJ9Y6GRgvle5l FcP6tYzReFdzL3kvyfXV4ZriiM/kA3zRN0NZe1RgxNe0RLRLG5kLknpN/ZPpjlzI6ob9 IIpCejYKBJ8mgrKr2ygyxf7LW/LmqWYgLu6o/XCZQnYmaOOoTE0NM5rHxsmi+Ydn2+q8 FisoMXJQVRXDWStC8gqKQmsnANETIFXKZRdMM/m8b1gGCcem0P79U7BHEGcxDdRJ/Z/l hEjyxNJRhn/fo+RioKfAZFycYQv3JxyCbbKAL4VTwrrY0WiVra/j0OBblUk112c3llm4 aICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ED8mu3drv0fM48qo5xm1xkFuy2Pq9N5GOrSvXYM68Rw=; b=NoB2Ut5D2DgqL9zOOLAfGYTbrj5ubUYDRL/YX4IefUG7WAdF12ntjI08wUV8WphD/w nLIkr1p2vLmaNLiA2cps50JqUNWg8WpDO/h1DaO9zrUczIdF5H9yCda4H0rCQJm1O7Jv ifm/MbEoGnNjEmOqNZs46Q2IcaE57e8wGf7rgiij2ju3k54pKGddBV9iDDTfVPvN2ubO nJSUa4YkoiAouELRFqsak/MBhYL41U3NP1S7h2mu1nwbV9ge1rA6PCxdlIJ7PMFADAOa dwNbfg4HLE7ZfMim2EKfWGzizGqSzznAjJeZzt+UuJt1l4PMZruBNNe3cVb14FITshcn LxkA== X-Gm-Message-State: AOUpUlE7WoCoORlhZk4TDir1AKHvO9/sWOKiPLm6/lXISHD9V4YdEqrW hqA2XqpijPCqSWjlE8H2OfxvOEM/ X-Google-Smtp-Source: AAOMgpe9pxXMXmdGurfeGXAeoL/CG+gWpIc4ghdw0chdbx80ahBlIKamx9bMBi5Sah1HpxUbl86rCw== X-Received: by 2002:a6b:28c2:: with SMTP id o185-v6mr9518843ioo.109.1532348544434; Mon, 23 Jul 2018 05:22:24 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w5-v6sm2808774ioc.58.2018.07.23.05.22.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 05:22:23 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> <83lga3w1o6.fsf@gnu.org> Date: Mon, 23 Jul 2018 08:22:21 -0400 In-Reply-To: <83lga3w1o6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Jul 2018 21:44:25 +0300") Message-ID: <87zhyi3zwi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, monnier@IRO.UMontreal.CA, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30190 fixed close 30190 26.2 quit Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha >> Date: Sun, 22 Jul 2018 14:33:18 -0400 >> >> Stefan Monnier writes: >> >> >> - (setq str (term-read-noecho "Non-echoed text: " t))) >> >> + (setq str (read-passwd "Non-echoed text: "))) >> > >> > I believe this remove the last use of term-read-noecho, so I think we >> > can then get rid of it (or at least mark it obsolete). >> >> Makes sense. I guess the obsoletion should go to master? >> >> Eli, is the patch in #131 okay for emacs-26? >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30190#131 > > Yes, thanks. Pushed to emacs-26. [1: 2b70b54739]: 2018-07-23 08:20:07 -0400 Prevent line-mode term from showing user passwords https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2b70b54739a8a422aff85f0183fb69eb339c35d4 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 23 08:46:30 2018 Received: (at 30190) by debbugs.gnu.org; 23 Jul 2018 12:46:30 +0000 Received: from localhost ([127.0.0.1]:53185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhaEQ-0002g4-4x for submit@debbugs.gnu.org; Mon, 23 Jul 2018 08:46:30 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhaEN-0002fu-Cb for 30190@debbugs.gnu.org; Mon, 23 Jul 2018 08:46:28 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6NCkQJE028916; Mon, 23 Jul 2018 08:46:26 -0400 Received: by pastel.home (Postfix, from userid 20848) id 9E3FF6559A; Mon, 23 Jul 2018 08:46:25 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> Date: Mon, 23 Jul 2018 08:46:25 -0400 In-Reply-To: <877eln5de9.fsf@gmail.com> (Noam Postavsky's message of "Sun, 22 Jul 2018 14:33:18 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6335=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6335> : inlines <6769> : streams <1793378> : uri <2677903> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30190 Cc: Eli Zaretskii , 30190@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Makes sense. I guess the obsoletion should go to master? FWIW, I think obsoletions are a form of documentation, so the earlier we announce them, the better. IOW if the patch goes to emacs-26, then the obsoletion should go there as well. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 23 08:56:36 2018 Received: (at 30190) by debbugs.gnu.org; 23 Jul 2018 12:56:36 +0000 Received: from localhost ([127.0.0.1]:53189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhaOC-0002ua-3M for submit@debbugs.gnu.org; Mon, 23 Jul 2018 08:56:36 -0400 Received: from mail-pf1-f171.google.com ([209.85.210.171]:36335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhaOA-0002uO-EY for 30190@debbugs.gnu.org; Mon, 23 Jul 2018 08:56:34 -0400 Received: by mail-pf1-f171.google.com with SMTP id d14-v6so82909pfo.3 for <30190@debbugs.gnu.org>; Mon, 23 Jul 2018 05:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=eLkbvwbQyXuIvZhRy+l1SEG0V/QS2rI6jj4JM+RvJfw=; b=PjU3G7ZLwtubF/FTJ0mKxlSjZsXZpQ1IVKMDkeLrquuXOlyiDQlm8g2K2z/pmO3OfM ve+f8cwzj20PdfWtBuiG/1ormznn4nExlR512JKbCNwxKNIQt+gsKsDMwsNMUxlMpTvN nEjMeULov5vQBd+oe4DpN8j/6nsaKBQqQSJHD8VmoLR3sk+yR2hKXVvi6yPRVhrL5Fd1 849kVQtAU3ucpVVFKjfkHf0GVThrbgNvkkeoRIflb8Iy+FfMZFb59xRd1bbzN2LHGDJm Ai4duC7B4ScjZl+Hd4wevH4YrmY8W3szXp2lRGo+0FqY7oCUZxncBoU9wlbHJDTybwxU bdbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=eLkbvwbQyXuIvZhRy+l1SEG0V/QS2rI6jj4JM+RvJfw=; b=abOwNRO4Qqhn77IMQW0SdbFHNHNiLhZeeUtZkq89TvYqdhrC9n1MMyp/nsZD9cn/nT EiU6NZ3u6BxJOxU9hAgxf68eMgGrFcamsc1UGv7aBcFRt7O5YCUq/gc8DbM9ha0djjhX H29g2qevOwprWdpkWgvmq21o6RVobSNJ0UxAZ/X5/ud4rbyCr5XeJ42SjVtIrHwSj3dM PpwwOON7eF4qG5gJNFQDSqrHypybdGpcmxxIPZUXlj5O8KMpDrAbn1Z9tZKhqGr3BoTJ 2WDnYd0HZ7EQU8TQngvQF+jda3tnqwrESclv+2BP9VXYoPUy/I5ktIRmarsvxGv8Y2lA 74jw== X-Gm-Message-State: AOUpUlEre3e45HqCYuY+3KN7Ps2Uf4vGpxNE4yQo9h0GXgsoSoCq36h/ RXj+OV/JY7lk9+MSsS3DbWA= X-Google-Smtp-Source: AAOMgpeGHI1YEdj6z9KC9Dju4J+cc50l8cwuKj//PuhIPcNEt8TBHL1uCY5yhiIvl8moVfaBpwpo8Q== X-Received: by 2002:a65:5c03:: with SMTP id u3-v6mr11602565pgr.402.1532350588508; Mon, 23 Jul 2018 05:56:28 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp (195.139.137.133.dy.bbexcite.jp. [133.137.139.195]) by smtp.gmail.com with ESMTPSA id c131-v6sm27865100pga.69.2018.07.23.05.56.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 05:56:27 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Mon, 23 Jul 2018 21:56:24 +0900 (JST) X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp To: Stefan Monnier Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords In-Reply-To: Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 23 Jul 2018, Stefan Monnier wrote: >> Makes sense. I guess the obsoletion should go to master? > > FWIW, I think obsoletions are a form of documentation, so the earlier we > announce them, the better. IOW if the patch goes to emacs-26, then the > obsoletion should go there as well. Good point. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 23 20:28:37 2018 Received: (at 30190) by debbugs.gnu.org; 24 Jul 2018 00:28:37 +0000 Received: from localhost ([127.0.0.1]:54461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhlBs-0004au-Tk for submit@debbugs.gnu.org; Mon, 23 Jul 2018 20:28:37 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:40739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhlBs-0004ai-79 for 30190@debbugs.gnu.org; Mon, 23 Jul 2018 20:28:36 -0400 Received: by mail-io0-f171.google.com with SMTP id l14-v6so2068118iob.7 for <30190@debbugs.gnu.org>; Mon, 23 Jul 2018 17:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KW4ijHNAbVNsj3HNEu5vGCCn/g0nOs3W48npZSUMIzU=; b=nLM88DincuJE3PP3utG/JrFt8B86W/xO9/IgyWbFznbQTrdZPKysthbfv2cg8ijzrd i6tAIm9isO4HtbDuM4zBkbl6eFP6b0MevmIGzO8e0uCsZgp15OGcjl5h12QZkejMPOHK pPajjT8enZbBAtI8NJH8Zh+W1dvZZce4XJaGCuSSE/I6IIUzx/ubR8L0mqkdEMHGw1Nw iSx4b2fjAkM5URFa3y4Eladn32pXh+pP9Mcm8v3cp6lmWQnwAgGFvnHBYV/3ZutBaG7W tr45ub48VrMlAfPwfpZnPlDmA3e8yq26XolC0XSKNYnSQ8xVv+Kz9J0KJiEi6FqCFnsC sh6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KW4ijHNAbVNsj3HNEu5vGCCn/g0nOs3W48npZSUMIzU=; b=DxPLSOkeHePHnLXMehav/FTnoC0Ww8BLhwxSDe5JvtcOpzbh/wKLfehftXpSIC6QMr euk1+NVJI4v3i+a6hK8LP1TrZEg5KqM0cRkUfhs6WFOtb6o5rJCwojsl0LAc3jpfXr7G mzOvJoexjYZylSF2QDTnstHachr9/htCEK+w03oPrOKVlFeSl1G1HTvwUzh9RNS92ss2 qCgcJBerZxPNC8J2d8BhxHUmqSy+Q7F3OkUfbpznRQIFEfJTDEJix88eDR8lrHFvzFT8 YV3VLU7x5NvcC2zdkpF8kg7vLSV+/0JA8Hz36yzh0+v5w6hsztLXcrOnca/EU7XTLOR0 8xSg== X-Gm-Message-State: AOUpUlFW8KUo0+F8TLEzKG6yYDHIJyk5kNs53YQKmJcKImejQ6NTQAYa rb3UzJbAh3/NetyjxdhYteA= X-Google-Smtp-Source: AAOMgpd94vqigKQVNQPMMhy0z4VUAQ6TpMniv+8XSMJZcaMLzUunvA6m742Bvq7GAf2+TH/q1whtgw== X-Received: by 2002:a6b:a7c9:: with SMTP id q192-v6mr11782480ioe.116.1532392110692; Mon, 23 Jul 2018 17:28:30 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i74-v6sm168409itb.21.2018.07.23.17.28.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 17:28:29 -0700 (PDT) From: Noam Postavsky To: Tino Calancha Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> Date: Mon, 23 Jul 2018 20:28:27 -0400 In-Reply-To: (Tino Calancha's message of "Mon, 23 Jul 2018 21:56:24 +0900 (JST)") Message-ID: <87sh494gus.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tino Calancha writes: > On Mon, 23 Jul 2018, Stefan Monnier wrote: > >>> Makes sense. I guess the obsoletion should go to master? >> >> FWIW, I think obsoletions are a form of documentation, so the earlier we >> announce them, the better. IOW if the patch goes to emacs-26, then the >> obsoletion should go there as well. > > Good point. This sounds good in theory, although in practice people tend to treat it as more than just documentation (e.g., Bug#30039). On the other hand, a search for "term-read-noecho" on the web gets 9 hits, all of which are either this bug thread, or copies of term.el/Emacs commit logs. So maybe this is all theoretical anyway... From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 23 22:35:36 2018 Received: (at 30190) by debbugs.gnu.org; 24 Jul 2018 02:35:36 +0000 Received: from localhost ([127.0.0.1]:54506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhnAm-00015s-LO for submit@debbugs.gnu.org; Mon, 23 Jul 2018 22:35:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhnAk-00015g-UC for 30190@debbugs.gnu.org; Mon, 23 Jul 2018 22:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhnAc-0008Eu-Dy for 30190@debbugs.gnu.org; Mon, 23 Jul 2018 22:35:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhnAc-0008Eq-8y; Mon, 23 Jul 2018 22:35:26 -0400 Received: from [176.228.60.248] (port=3212 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fhnAb-0007Nj-Nh; Mon, 23 Jul 2018 22:35:26 -0400 Date: Tue, 24 Jul 2018 05:35:33 +0300 Message-Id: <831sbtwebu.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87sh494gus.fsf@gmail.com> (message from Noam Postavsky on Mon, 23 Jul 2018 20:28:27 -0400) Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> <87sh494gus.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, monnier@iro.umontreal.ca, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: Stefan Monnier , 30190@debbugs.gnu.org, Eli Zaretskii > Date: Mon, 23 Jul 2018 20:28:27 -0400 > > Tino Calancha writes: > > > On Mon, 23 Jul 2018, Stefan Monnier wrote: > > > >>> Makes sense. I guess the obsoletion should go to master? > >> > >> FWIW, I think obsoletions are a form of documentation, so the earlier we > >> announce them, the better. IOW if the patch goes to emacs-26, then the > >> obsoletion should go there as well. > > > > Good point. > > This sounds good in theory, although in practice people tend to treat it > as more than just documentation (e.g., Bug#30039). > > On the other hand, a search for "term-read-noecho" on the web gets 9 > hits, all of which are either this bug thread, or copies of > term.el/Emacs commit logs. So maybe this is all theoretical anyway... My POV on this is that we shouldn't in general deprecate anything in a bugfix release. However, I agree that this particular case is not really important to justify bikeshedding, so I won't holler if we did it this time. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 29 21:15:57 2018 Received: (at 30190) by debbugs.gnu.org; 30 Jul 2018 01:15:57 +0000 Received: from localhost ([127.0.0.1]:34233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjwmy-0007DX-Uk for submit@debbugs.gnu.org; Sun, 29 Jul 2018 21:15:57 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:55099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjwmw-0007DJ-SE for 30190@debbugs.gnu.org; Sun, 29 Jul 2018 21:15:55 -0400 Received: by mail-it0-f51.google.com with SMTP id s7-v6so15051295itb.4 for <30190@debbugs.gnu.org>; Sun, 29 Jul 2018 18:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6xgA0hoc2/l9eoW5nW6BURuNCHB33Bu0y2lS0kLi11Y=; b=k6ydV5sYlL/xzLmB/1Ao1vvyOBFC0E26CpDm5QTMeoEzrSa18AyyodgjrIdrUYYz2n 3TWp/7g3fQ9zXXKlvEGwG8GzrxemEdb4sTggs3hTaSPn2jR4PUkmiqOfieXNWiMHNJ4C BJEmnr3O0qCe4WFpJZrk94uyQk0rGgxyQGhKARhhqURPkUP5uo3gXo7E0RyFxCpPMOm5 l2MzBrKuWD04ZCwgiSc0bqCoZ5uQ3bclnNfkpm9dhrRDYGA60BTa1Q29AVw00bd0sduT WQaIU7rka8e7sLrA9AJEtP3k71ejtq0wZKvdtiib4MV5NldCocPTOe+ai9uguZ5ViRkR KXfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6xgA0hoc2/l9eoW5nW6BURuNCHB33Bu0y2lS0kLi11Y=; b=kvD2i0eNpyi23GloIPnO31LZQSej6u24j4hxfhKBSyTYco6VaT07B6kqIJXTk/uQwD +yZ0abiQE67pOTKKZ1j5EgOqFTQyyhtAZ8cJFdwvxL5gnyd7F+McMGMalT3GfTaTYAT+ kuWwEDosuXfzGsIyK2Uq8AaTtm5OEFJMGm3kz8e5+ZfgwkzSwwO+diYhgH/tAHn9zhb8 +7j5ejV7CkKk8ghBbYpj4f7nox+mBOl1s/3ds2WZK77h6Kr/pmriiJ8e4Bm2kZAgE7Ni AON+PZff6zDWu2/WvvyePl9o+GOixg0nOJ12p0P+hxmefG3OCeG+eSxNTKsWIRFM7WPO 9/og== X-Gm-Message-State: AOUpUlF7jDn3JBmNlHSDloVl/oQjYfz8wdhz52y2H9mF5O1FXVeWvA27 AT6AaFBhDDPvxqtpbpZofZU= X-Google-Smtp-Source: AAOMgpfZpr8ud/YhemfUUah07hD8yAPA60JMKPIFukTIJ5FSmNsXl2ephTYz/GOFi5QvMM4DVgsL7A== X-Received: by 2002:a02:c617:: with SMTP id i23-v6mr14959667jan.75.1532913349368; Sun, 29 Jul 2018 18:15:49 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b81-v6sm5710338itg.6.2018.07.29.18.15.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jul 2018 18:15:48 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#30190: 27.0.50; term run in line mode shows user passwords References: <87r2qjh0fs.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> <878t6892pv.fsf@gmail.com> <87zhyo6qkb.fsf@gmail.com> <877eln5de9.fsf@gmail.com> <87sh494gus.fsf@gmail.com> <831sbtwebu.fsf@gnu.org> Date: Sun, 29 Jul 2018 21:15:47 -0400 In-Reply-To: <831sbtwebu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Jul 2018 05:35:33 +0300") Message-ID: <87y3dt1q2k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30190 Cc: 30190@debbugs.gnu.org, monnier@iro.umontreal.ca, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> >>> Makes sense. I guess the obsoletion should go to master? >> >> >> >> FWIW, I think obsoletions are a form of documentation, so the earlier we >> >> announce them, the better. IOW if the patch goes to emacs-26, then the >> >> obsoletion should go there as well. >> > >> > Good point. >> >> This sounds good in theory, although in practice people tend to treat it >> as more than just documentation (e.g., Bug#30039). >> >> On the other hand, a search for "term-read-noecho" on the web gets 9 >> hits, all of which are either this bug thread, or copies of >> term.el/Emacs commit logs. So maybe this is all theoretical anyway... > > My POV on this is that we shouldn't in general deprecate anything in a > bugfix release. However, I agree that this particular case is not > really important to justify bikeshedding, so I won't holler if we did > it this time. Well, I've pushed the obsoletion to master. [1: bd36ab560d]: 2018-07-29 21:13:48 -0400 * lisp/term.el (term-read-noecho): Mark obsolete. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=bd36ab560d5efcc5853e455c2312cf1a104e78ea From unknown Mon Aug 18 02:36:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 Aug 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator