GNU bug report logs - #30188
[PATCH] gnu: clisp: Fix build with glibc 2.26.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#30188: closed ([PATCH] gnu: clisp: Fix build with glibc 2.26.)
Date: Mon, 22 Jan 2018 02:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 21 Jan 2018 21:41:34 -0500
with message-id <877esasjhd.fsf <at> posteo.net>
and subject line Re: [bug#30188] [PATCH] gnu: clisp: Fix build with glibc 2.26.
has caused the debbugs.gnu.org bug report #30188,
regarding [PATCH] gnu: clisp: Fix build with glibc 2.26.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
30188: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30188
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] gnu: clisp: Fix build with glibc 2.26.
Date: Sat, 20 Jan 2018 21:50:19 -0500

* gnu/packages/patches/clisp-glibc-2.26.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/lisp.scm (clisp)[source]: Use it.
---
 gnu/local.mk                                |  1 +
 gnu/packages/lisp.scm                       |  3 ++-
 gnu/packages/patches/clisp-glibc-2.26.patch | 20 ++++++++++++++++++++
 3 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/clisp-glibc-2.26.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index c8c31e1b9..865d1eae8 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -581,6 +581,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/clang-runtime-asan-build-fixes.patch	\
   %D%/packages/patches/clang-runtime-esan-build-fixes.patch	\
   %D%/packages/patches/clementine-use-openssl.patch		\
+  %D%/packages/patches/clisp-glibc-2.26.patch			\
   %D%/packages/patches/clisp-remove-failing-test.patch		\
   %D%/packages/patches/clucene-pkgconfig.patch			\
   %D%/packages/patches/clx-remove-demo.patch			\
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 8427a1971..10c49e0c0 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -262,7 +262,8 @@ supporting ASDF, Sockets, Gray streams, MOP, and other useful components.")
        (file-name (string-append name "-" version "-checkout"))
        (sha256
         (base32 "0qjv3z274rbdmb941hy03hl63f4z7bmci234f8dyz4skgfr82d3i"))
-       (patches (search-patches "clisp-remove-failing-test.patch"))))
+       (patches (search-patches "clisp-glibc-2.26.patch"
+                                "clisp-remove-failing-test.patch"))))
     (build-system gnu-build-system)
     (inputs `(("libffcall" ,libffcall)
               ("ncurses" ,ncurses)
diff --git a/gnu/packages/patches/clisp-glibc-2.26.patch b/gnu/packages/patches/clisp-glibc-2.26.patch
new file mode 100644
index 000000000..c8920cecc
--- /dev/null
+++ b/gnu/packages/patches/clisp-glibc-2.26.patch
@@ -0,0 +1,20 @@
+This patch comes from Debian.
+
+Description: cfree is not present in glibc-2.26, stop wrapping it
+Author: Adam Conrad <adconrad <at> ubuntu.com>
+Bug: https://sourceforge.net/p/clisp/bugs/717/
+Bug-Debian: https://bugs.debian.org/880686
+Applied-Upstream: https://sourceforge.net/p/clisp/clisp/ci/3bc928712d150ff1e5f6b2bfb7838655f3ff52fa/
+Reviewed-By: Sébastien Villemot <sebastien <at> debian.org>
+Last-Update: 2017-11-27
+
+--- clisp-2.49.20170913.orig/modules/bindings/glibc/linux.lisp
++++ clisp-2.49.20170913/modules/bindings/glibc/linux.lisp
+@@ -649,7 +649,6 @@
+ (def-call-out calloc (:arguments (nmemb size_t) (size size_t))
+   (:return-type c-pointer))
+ (def-call-out free (:arguments (ptr c-pointer)) (:return-type nil))
+-(def-call-out cfree (:arguments (ptr c-pointer)) (:return-type nil))
+ (def-call-out valloc (:arguments (size size_t)) (:return-type c-pointer))
+ 
+ (def-call-out abort (:arguments) (:return-type nil))
-- 
2.15.1

[Message part 3 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 30188-done <at> debbugs.gnu.org
Subject: Re: [bug#30188] [PATCH] gnu: clisp: Fix build with glibc 2.26.
Date: Sun, 21 Jan 2018 21:41:34 -0500

[Message part 4 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> LGTM!

Thanks! I've pushed to core-updates. The current SBCL package (1.3.7)
still fails to build but the *latest* version (1.4.3) builds (which then
breaks sbcl-slynk if I remember correctly).

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.