GNU bug report logs - #30186
27.0.50; Password is not hidden in read-passwd

Previous Next

Full log

Message #59 received at 30186 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Eli Zaretskii <eliz <at> gnu.org>, juri <at> linkov.net
Cc: 30186 <at> debbugs.gnu.org
Subject: Re: bug#30186: 27.0.50; Password is not hidden in read-passwd
Date: Sat, 27 Jan 2018 13:38:02 +0000

Hello, Eli and Juri.

On Sat, Jan 27, 2018 at 14:23:31 +0200, Eli Zaretskii wrote:
> > Date: Sat, 27 Jan 2018 11:37:13 +0000
> > Cc: juri <at> linkov.net, 30186 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm <at> muc.de>

[ .... ]

> > So, I'm changing my mind, after looking into it a bit more.
> > Removing the with-silent-modifications from
> > remove-yank-excluded-properties would not slow down undo in CC Mode
> > buffers noticeably.

> So let's do that now.  I think the problem with read-passwd is a
> security issue, so it should go to emacs-26, do you agree?

Yes, i think it should go into emacs-26.

Juri, do you see any problem with just removing that
with-silent-modifications altogether?  I.e. this:



Allow read-passwd to hide characters inserted by C-y.  (Security fix.)

This fixes bug #30186.  The with-silent-modifications was there to prevent
records of text property manipulations being put into buffer-undo-list.  These
had been causing a significant slowdown in CC Mode with C-_ after a large
C-y.  This CC Mode problem has since been solved by a different workaround.

* lisp/subr.el (remove-yank-excluded-properties): Remove the invocation of
with-silent-modifications around the text property manipulations.



diff --git a/lisp/subr.el b/lisp/subr.el
index 052d9cd821..64cbbd52ab 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3019,10 +3019,9 @@ remove-yank-excluded-properties
                           run-start prop nil end)))
             (funcall fun value run-start run-end)
             (setq run-start run-end)))))
-    (with-silent-modifications
-      (if (eq yank-excluded-properties t)
-          (set-text-properties start end nil)
-        (remove-list-of-text-properties start end yank-excluded-properties)))))
+    (if (eq yank-excluded-properties t)
+        (set-text-properties start end nil)
+      (remove-list-of-text-properties start end yank-excluded-properties))))
 
 (defvar yank-undo-function)
 

[ .... ]


-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.