GNU bug report logs - #30175
25.3; [PATCH] activate mark when marking bibtex entry

Previous Next

Package: emacs;

Reported by: Alex Branham <alex.branham <at> gmail.com>

Date: Fri, 19 Jan 2018 19:00:02 UTC

Severity: minor

Tags: patch

Found in version 25.3

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30175 in the body.
You can then email your comments to 30175 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#30175; Package emacs. (Fri, 19 Jan 2018 19:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alex Branham <alex.branham <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 19 Jan 2018 19:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.3; [PATCH] activate mark when marking bibtex entry
Date: Fri, 19 Jan 2018 12:59:02 -0600
[Message part 1 (text/plain, inline)]
This patch activates the mark when running bibtex-mark-entry, making behavior consistent with e.g. mark-paragraph.

Can this make it into Emacs 26 (please)?

Thanks,
Alex

From d069aee2fed5f281f8fba2b0c430624462c94d27 Mon Sep 17 00:00:00 2001
From: Alex Branham <branham <at> utexas.edu>
Date: Fri, 19 Jan 2018 12:54:00 -0600
Subject: [PATCH] * lisp/textmodes/bibtex.el (bibtex-mark-entry): activate mark

---
 lisp/textmodes/bibtex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index a30e146892..a3f9804358 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -3871,7 +3871,7 @@ bibtex-reposition-window
 (defun bibtex-mark-entry ()
   "Put mark at beginning, point at end of current BibTeX entry."
   (interactive)
-  (push-mark (bibtex-beginning-of-entry))
+  (push-mark (bibtex-beginning-of-entry) :activate t)
   (bibtex-end-of-entry))
 
 (defun bibtex-count-entries (&optional count-string-entries)
-- 
2.16.0

[0001-lisp-textmodes-bibtex.el-bibtex-mark-entry-activate-.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30175; Package emacs. (Sat, 27 Jan 2018 15:55:02 GMT) Full text and rfc822 format available.

Message #8 received at 30175 <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: 30175 <at> debbugs.gnu.org
Subject: Follow-up
Date: Sat, 27 Jan 2018 09:54:34 -0600
Hello -

It's been about a week since I sent this patch and I haven't heard anything. Just sending a follow-up so it doesn't get lost in the shuffle.

FWIW I've been using it locally without ill effect.

Thanks again!
Alex




Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Tue, 20 Mar 2018 06:51:02 GMT) Full text and rfc822 format available.

Notification sent to Alex Branham <alex.branham <at> gmail.com>:
bug acknowledged by developer. (Tue, 20 Mar 2018 06:51:02 GMT) Full text and rfc822 format available.

Message #13 received at 30175-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 30175-done <at> debbugs.gnu.org
Subject: Re: bug#30175: 25.3; [PATCH] activate mark when marking bibtex entry
Date: Tue, 20 Mar 2018 08:50:54 +0200
> From: Alex Branham <alex.branham <at> gmail.com>
> Date: Fri, 19 Jan 2018 12:59:02 -0600
> 
> This patch activates the mark when running bibtex-mark-entry, making behavior consistent with e.g. mark-paragraph.
> 
> Can this make it into Emacs 26 (please)?

Pushed to the emacs-26 branch.  Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 17 Apr 2018 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 7 years and 69 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.