GNU bug report logs - #30162
27.0.50; Wrong order of directories in *Deletions*

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30162 in the body.
You can then email your comments to 30162 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Wrong order of directories in *Deletions*
Date: Thu, 18 Jan 2018 23:34:38 +0200

This is a regression.  The order of directories in *Deletions* was right
in older versions, but not now.

Steps to reproduce:

0. emacs -Q
1. ‘M-!’ mkdir x y z RET
2. ‘C-x d’ RET
3. ‘D D D’ (select dirs x, y, z for deletion)
4. ‘x’ (dired-do-flagged-delete)

Directories in *Deletions* are reversed:

  z
  y
  x

It seems this is a result of the commit 9ecbdee, but I can't find
a related discussion.

I think we should either reverse the list of buffers at the lowest level
in ‘dired-map-over-marks’ (this might cause backward-compatibility
issues), or don't call ‘nreverse’ twice and remove ‘nreverse’ from
‘dired-internal-do-deletions’.

Message #8 received at 30162 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 30162 <at> debbugs.gnu.org
Subject: Re: bug#30162: 27.0.50; Wrong order of directories in *Deletions*
Date: Tue, 23 Jan 2018 23:56:44 +0200

> This is a regression.  The order of directories in *Deletions* was right
> in older versions, but not now.
>
> Steps to reproduce:
>
> 0. emacs -Q
> 1. ‘M-!’ mkdir x y z RET
> 2. ‘C-x d’ RET
> 3. ‘D D D’ (select dirs x, y, z for deletion)
> 4. ‘x’ (dired-do-flagged-delete)
>
> Directories in *Deletions* are reversed:
>
>   z
>   y
>   x
>
> It seems this is a result of the commit 9ecbdee, but I can't find
> a related discussion.
>
> I think we should either reverse the list of buffers at the lowest level
> in ‘dired-map-over-marks’ (this might cause backward-compatibility
> issues), or don't call ‘nreverse’ twice and remove ‘nreverse’ from
> ‘dired-internal-do-deletions’.

This patch is for the latter:

diff --git a/lisp/dired.el b/lisp/dired.el
index eebf836..eade11b 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3094,7 +3094,7 @@ dired-internal-do-deletions
 	 (dired-recursive-deletes dired-recursive-deletes)
 	 (trashing (and trash delete-by-moving-to-trash)))
     ;; canonicalize file list for pop up
-    (setq files (nreverse (mapcar #'dired-make-relative files)))
+    (setq files (mapcar #'dired-make-relative files))
     (if (dired-mark-pop-up
 	 " *Deletions*" 'delete files dired-deletion-confirmer
 	 (format "%s %s "

Message #13 received at 30162-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 30162-done <at> debbugs.gnu.org
Subject: Re: bug#30162: 27.0.50; Wrong order of directories in *Deletions*
Date: Wed, 24 Jan 2018 23:44:25 +0200

Done.

>> This is a regression.  The order of directories in *Deletions* was right
>> in older versions, but not now.
>>
>> Steps to reproduce:
>>
>> 0. emacs -Q
>> 1. ‘M-!’ mkdir x y z RET
>> 2. ‘C-x d’ RET
>> 3. ‘D D D’ (select dirs x, y, z for deletion)
>> 4. ‘x’ (dired-do-flagged-delete)
>>
>> Directories in *Deletions* are reversed:
>>
>>   z
>>   y
>>   x
>>
>> It seems this is a result of the commit 9ecbdee, but I can't find
>> a related discussion.
>>
>> I think we should either reverse the list of buffers at the lowest level
>> in ‘dired-map-over-marks’ (this might cause backward-compatibility
>> issues), or don't call ‘nreverse’ twice and remove ‘nreverse’ from
>> ‘dired-internal-do-deletions’.
>
> This patch is for the latter:
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index eebf836..eade11b 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -3094,7 +3094,7 @@ dired-internal-do-deletions
>  	 (dired-recursive-deletes dired-recursive-deletes)
>  	 (trashing (and trash delete-by-moving-to-trash)))
>      ;; canonicalize file list for pop up
> -    (setq files (nreverse (mapcar #'dired-make-relative files)))
> +    (setq files (mapcar #'dired-make-relative files))
>      (if (dired-mark-pop-up
>  	 " *Deletions*" 'delete files dired-deletion-confirmer
>  	 (format "%s %s "

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.