Subject: Re: [bug#30159] [PATCH 1/2] gnu: Add deluge.

From: Danny Milosavljevic <[email-masked]>
Date: Thu, 18 Jan 2018 17:56:59 +0100

Hi,

thanks for the patch.

On Thu, 18 Jan 2018 07:03:50 -0800
mike rosset <[email-masked]> wrote:

> * gnu/packages/bittorrent.scm (deluge): New variable.
> ---
>  gnu/packages/bittorrent.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index 053988c8d..17c72a635 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -41,6 +41,7 @@
>    #:use-module (gnu packages cyrus-sasl)
>    #:use-module (gnu packages databases)
>    #:use-module (gnu packages file)
> +  #:use-module (gnu packages freedesktop)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gnupg)
> @@ -53,6 +54,7 @@
>    #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages python)
> +  #:use-module (gnu packages python-crypto)
>    #:use-module (gnu packages ssh)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages xml))
> @@ -408,3 +410,35 @@ desktops.")
>      (license l:bsd-2)))
>  
>  
> +(define-public deluge

The name suggests that this is a program and not a library (which is fine).

> +    (propagated-inputs
> +     `(("python2-pygtk" ,python2-pygtk)
> +       ("python2-chardet" ,python2-chardet)
> +       ("python2-pyopenssl" ,python2-pyopenssl)
> +       ("python2-libtorrent" ,python2-libtorrent)
> +       ("python2-twisted" ,python2-twisted)
> +       ("python2-pyxdg" ,python2-pyxdg)))

Hmm, ok, but for programs, regular inputs would work as well.

> +As Deluge heavily utilises the libtorrent library")

^^^^ Sentence is cut.