GNU bug report logs - #30148
26.0.91; EWW binding for `r'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30148 in the body.
You can then email your comments to 30148 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.91; EWW binding for `r'
Date: Wed, 17 Jan 2018 20:45:39 +0100

Normally `l' and `r' in "EWW" go back and forward through the buffer's
history.  But when point is on an image (or, oddly, a link -- see
below), `r' instead runs `image-rotate'.  Since there are quite some
keys left unbound in both eww-mode-map and in shr-image-map, one of
these bindings should budge.

Also, I do not understand why eww-link-keymap is a copy of
shr-image-map, when so many commands that could apply to images do not
apply to links:

  (defvar eww-link-keymap
    (let ((map (copy-keymap shr-image-map)))
      (define-key map "\r" 'eww-follow-link)
      map))

Message #8 received at 30148 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 30148 <at> debbugs.gnu.org
Subject: Re: bug#30148: 26.0.91; EWW binding for `r'
Date: Fri, 13 Apr 2018 00:29:08 +0200

charles <at> aurox.ch (Charles A. Roelli) writes:

> Normally `l' and `r' in "EWW" go back and forward through the buffer's
> history.  But when point is on an image (or, oddly, a link -- see
> below), `r' instead runs `image-rotate'.  Since there are quite some
> keys left unbound in both eww-mode-map and in shr-image-map, one of
> these bindings should budge.

You can have images in other buffers, too, and the `r' for "rotate"
seems very natural.  And `r' for "return" is a generally accepted
command in many Emacs modes, so I don't really know which one to change.

> Also, I do not understand why eww-link-keymap is a copy of
> shr-image-map, when so many commands that could apply to images do not
> apply to links:
>
>   (defvar eww-link-keymap
>     (let ((map (copy-keymap shr-image-map)))
>       (define-key map "\r" 'eww-follow-link)
>       map))

It's presumably to have the image commands not disappear if there's an
image in a link.  Too bad Emacs doesn't have a way to add several local
keymaps using text properties...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 30148 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 30148 <at> debbugs.gnu.org
Subject: Re: bug#30148: 26.0.91; EWW binding for `r'
Date: Sat, 14 Apr 2018 00:17:59 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> Also, I do not understand why eww-link-keymap is a copy of
>> shr-image-map, when so many commands that could apply to images do not
>> apply to links:
>>
>>   (defvar eww-link-keymap
>>     (let ((map (copy-keymap shr-image-map)))
>>       (define-key map "\r" 'eww-follow-link)
>>       map))
>
> It's presumably to have the image commands not disappear if there's an
> image in a link.  Too bad Emacs doesn't have a way to add several local
> keymaps using text properties...

I've now tweaked this to make the image commands go away on non-image
links in eww.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.