GNU bug report logs - #30141
26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes

Previous Next

Full log

View this message in rfc822 format

From: Aaron Jensen <aaronjensen <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>, 30141 <at> debbugs.gnu.org
Subject: bug#30141: (26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes)
Date: Wed, 17 Jan 2018 03:50:24 -0800

[Message part 1 (text/plain, inline)]

From: martin rudalics (mailto:rudalics <at> gmx.at)
> Doesn't look wrong to me. But if we use it we'd have to change the
> comment below:

Updated patch attached.

I tried out a naive approach to filtering (filter out all frameset--
params when restoring) and it broke on the mini buffer restoring,
though I didn’t debug the exact issue.

Reading over the code makes me wonder if I put the text pixel
width/height saving code in the wrong place,
frameset--record-relationships, as it is named, seems to be more about
the relationships between frames. Tossing in pixel sizing in there is
a bit misplaced probably. Maybe it would be more appropriate to add a
custom width/height filter that would save the text pixel width/height
while filtering.

Either way, this patch fixes a bug so it is probably worth applying if
you’re good with it.

Thanks,

Aaron

[patch2 (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.