GNU bug report logs - #30131
26.0.50; compile.el no longer calls compilation-parse-errors-filename-function

Previous Next

Full log

View this message in rfc822 format

From: Gary Oberbrunner <garyo <at> oberbrunner.com>
To: 30131 <at> debbugs.gnu.org
Subject: bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function
Date: Mon, 15 Jan 2018 12:28:15 -0500

[Message part 1 (text/plain, inline)]

In git rev e335e1949, back in 2001,
compilation-parse-errors-filename-function was introduced to compile.el, to
postprocess filenames. Somewhere in the last few months, emacs has stopped
calling that function from compilation-find-file, so it no longer works.
(It's still called from a function that now only is used for display, so it
doesn't actually find the processed filename.)

This patch re-adds it to the new processing path:

modified   lisp/progmodes/compile.el
@@ -2745,8 +2745,11 @@ compilation-find-file
       ;; For each directory, try each format string.
       (while (and fmts (null buffer))
         (setq name (expand-file-name (format (car fmts) filename) thisdir)
-              buffer (and (file-exists-p name)
-                          (find-file-noselect name))
+       processed-name (if (boundp
'compilation-parse-errors-filename-function)
+ (funcall compilation-parse-errors-filename-function name)
+        name)
+              buffer (and (file-exists-p processed-name)
+                          (find-file-noselect processed-name))
               fmts (cdr fmts)))
       (setq dirs (cdr dirs)))
     (while (null buffer)    ;Repeat until the user selects an existing
file.

By the way, I did file an emacs contributor release form some years ago.

Hope this is helpful;

Gary Oberbrunner

-- 
Gary

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.