GNU bug report logs - #30106
Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test'

Previous Next

Package: emacs;

Reported by: Jean Louis <bugs <at> gnu.support>

Date: Sun, 14 Jan 2018 06:35:01 UTC

Severity: normal

Fixed in version 27.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Forwarded to https://github.com/anse1/emacs-libpq/issues/8

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: phst <at> google.com, rgm <at> gnu.org, 30106 <at> debbugs.gnu.org
Subject: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106)
Date: Thu, 18 Jan 2018 16:04:05 +0200

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Cc: Philipp Stephani <phst <at> google.com>
> Date: Wed, 17 Jan 2018 23:28:46 +0100
> 
> * src/systhread.c (sys_thread_equal): New function.
> * src/emacs-module.c (in_current_thread): Use it.

I'd prefer that the only file that calls systhread.c functions is
thread.c; systhread.c is supposed to be low-level code concealed from
application levels.  So this would call for another level of
indirection: add a new function to thread.c, and call that from
emacs-module.c.

Otherwise, LGTM for master; thanks.
This bug report was last modified 6 years and 34 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.