GNU bug report logs - #30106
Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test'

Previous Next

Full log

Message #103 received at 30106 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: phst <at> google.com, 30106 <at> debbugs.gnu.org
Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled
 (Bug#30106)
Date: Thu, 18 Jan 2018 14:23:03 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Do., 18. Jan. 2018 um 15:05 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Cc: Philipp Stephani <phst <at> google.com>
> > Date: Wed, 17 Jan 2018 23:28:46 +0100
> >
> > * src/systhread.c (sys_thread_equal): New function.
> > * src/emacs-module.c (in_current_thread): Use it.
>
> I'd prefer that the only file that calls systhread.c functions is
> thread.c; systhread.c is supposed to be low-level code concealed from
> application levels.  So this would call for another level of
> indirection: add a new function to thread.c, and call that from
> emacs-module.c.
>

Makes sense, I've moved in_current_thread to thread.c because it's
unrelated to modules.


>
> Otherwise, LGTM for master; thanks.
>
>
Can we push this to emacs-26? Right now emacs-26 can't even be compiled
with --without-threads --with-modules (on some systems at least).

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.