Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106)

From: Glenn Morris <[email-masked]>
Date: Thu, 18 Jan 2018 17:55:22 -0500

Eli Zaretskii wrote:

>> If it's not to be fixed then IMO in the meantime configure should
>> explicitly reject --with-modules if threads are disabled.
>
> That'd replace one non-trivial change with another, so I think it's
> worse than fixing the problem.

You think the following is non-trivial?

--- a/configure.ac
+++ b/configure.ac
@@ -3513,6 +3513,8 @@ case $opsys in
   *) MODULES_SUFFIX=".so" ;;
 esac
 if test "${with_modules}" != "no"; then
+  test "${threads_enabled}" = "no" && \
+    AC_MSG_ERROR([modules currently require threads])
   case $opsys in
     gnu|gnu-linux)
       LIBMODULES="-ldl"