From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 01:34:37 2018 Received: (at submit) by debbugs.gnu.org; 14 Jan 2018 06:34:37 +0000 Received: from localhost ([127.0.0.1]:55339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eabsL-0004P3-0W for submit@debbugs.gnu.org; Sun, 14 Jan 2018 01:34:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eabsJ-0004Oo-HC for submit@debbugs.gnu.org; Sun, 14 Jan 2018 01:34:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eabsD-0008Mq-Kl for submit@debbugs.gnu.org; Sun, 14 Jan 2018 01:34:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59099) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eabsD-0008Mk-HA for submit@debbugs.gnu.org; Sun, 14 Jan 2018 01:34:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eabs9-0004f8-Vc for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2018 01:34:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eabs3-0008Kt-T8 for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2018 01:34:25 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:52297 helo=static.rcdrun.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eabs3-0008KV-La for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2018 01:34:19 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Sat, 13 Jan 2018 23:34:48 -0700 id 00000000001256D4.000000005A5AFA08.00000B95 Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Sun, 14 Jan 2018 07:36:03 +0100 id 00000000001C038A.000000005A5AFA53.0000241D Date: Sun, 14 Jan 2018 09:36:03 +0300 From: Jean Louis To: bug-gnu-emacs@gnu.org Subject: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180114063602.GA9234@protected.rcdrun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15) X-Mime-Autoconverted: from 8bit to quoted-printable by courier 0.68.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hello, I cannot compile the development version so that dynamic modules work. When making: make test, I can see this error: GEN src/editfns-tests.log ELC src/emacs-module-tests.elc In toplevel form: src/emacs-module-tests.el:32:1:Error: Loading file /sources/emacs/lisp/em= acs-lisp/ert.elc failed to provide feature `mod-test' make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 1 make[3]: Target 'src/emacs-module-tests.log' not remade because of errors. And if try to load module pq (new one from Github), I get errors like: Debugger entered--Lisp error: (error "Loading file /package/text/emacs-27= .0.50/share/emacs/27.0.50/lisp/vc/vc-git.elc failed to provide feature =E2= =80=98pq=E2=80=99") require(pq) eval((require 'pq) nil) elisp--eval-last-sexp(nil) eval-last-sexp(nil) funcall-interactively(eval-last-sexp nil) call-interactively(eval-last-sexp nil nil) command-execute(eval-last-sexp) If anybody can help me to make loading dynamic modules with development version, let me know. Jean From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 11:09:15 2018 Received: (at 30106) by debbugs.gnu.org; 14 Jan 2018 16:09:15 +0000 Received: from localhost ([127.0.0.1]:56168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eakqR-00051p-GN for submit@debbugs.gnu.org; Sun, 14 Jan 2018 11:09:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eakqQ-00051c-51 for 30106@debbugs.gnu.org; Sun, 14 Jan 2018 11:09:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eakqF-00018m-Ps for 30106@debbugs.gnu.org; Sun, 14 Jan 2018 11:09:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eakqF-00018g-Mo; Sun, 14 Jan 2018 11:09:03 -0500 Received: from [176.228.60.248] (port=2632 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eakqF-0004rG-1Q; Sun, 14 Jan 2018 11:09:03 -0500 Date: Sun, 14 Jan 2018 18:08:48 +0200 Message-Id: <83zi5gzalr.fsf@gnu.org> From: Eli Zaretskii To: Jean Louis In-reply-to: <20180114063602.GA9234@protected.rcdrun.com> (message from Jean Louis on Sun, 14 Jan 2018 09:36:03 +0300) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sun, 14 Jan 2018 09:36:03 +0300 > From: Jean Louis > > I cannot compile the development version so that > dynamic modules work. > > When making: make test, I can see this error: > > GEN src/editfns-tests.log > ELC src/emacs-module-tests.elc > > In toplevel form: > src/emacs-module-tests.el:32:1:Error: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' > make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 1 > make[3]: Target 'src/emacs-module-tests.log' not > remade because of errors. How did you configure and build Emacs? What were the commands you used for that? (FWIW, the emacs-module-tests test works for me with today's master branch.) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 12:46:16 2018 Received: (at 30106) by debbugs.gnu.org; 14 Jan 2018 17:46:16 +0000 Received: from localhost ([127.0.0.1]:56278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eamMK-00019P-F0 for submit@debbugs.gnu.org; Sun, 14 Jan 2018 12:46:16 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:45373 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eamMJ-000198-56 for 30106@debbugs.gnu.org; Sun, 14 Jan 2018 12:46:15 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Sun, 14 Jan 2018 10:46:39 -0700 id 000000000011B76B.000000005A5B9780.0000152D Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Sun, 14 Jan 2018 18:47:48 +0100 id 00000000001C038A.000000005A5B97C4.00007719 Date: Sun, 14 Jan 2018 20:47:48 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180114174748.GA12223@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <83zi5gzalr.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Dear Eli, I appreciate your efforts. On Sun, Jan 14, 2018 at 06:08:48PM +0200, Eli Zaretskii wrote: > > Date: Sun, 14 Jan 2018 09:36:03 +0300 > > From: Jean Louis > > > > I cannot compile the development version so that > > dynamic modules work. > > > > When making: make test, I can see this error: > > > > GEN src/editfns-tests.log > > ELC src/emacs-module-tests.elc > > > > In toplevel form: > > src/emacs-module-tests.el:32:1:Error: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' > > make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 1 > > make[3]: Target 'src/emacs-module-tests.log' not > > remade because of errors. > > How did you configure and build Emacs? What were the commands you > used for that? > > (FWIW, the emacs-module-tests test works for me with today's master > branch.) Here is how I did it: ./configure --prefix=/package/text/emacs-27.0.50/ --with-mailutils --without-imagemagick --without-pop --with-x-toolkit=lucid --with-modules I really hope to find out what is wrong. Jean I From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 14:45:12 2018 Received: (at 30106) by debbugs.gnu.org; 14 Jan 2018 19:45:12 +0000 Received: from localhost ([127.0.0.1]:56330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaoDQ-0005n7-Co for submit@debbugs.gnu.org; Sun, 14 Jan 2018 14:45:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaoDO-0005mt-Hp for 30106@debbugs.gnu.org; Sun, 14 Jan 2018 14:45:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaoDG-00025K-20 for 30106@debbugs.gnu.org; Sun, 14 Jan 2018 14:45:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaoDF-000258-UM; Sun, 14 Jan 2018 14:45:01 -0500 Received: from [176.228.60.248] (port=3055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eaoDE-0004p5-0p; Sun, 14 Jan 2018 14:45:01 -0500 Date: Sun, 14 Jan 2018 21:44:40 +0200 Message-Id: <83shb8z0lz.fsf@gnu.org> From: Eli Zaretskii To: Jean Louis In-reply-to: <20180114174748.GA12223@protected.rcdrun.com> (message from Jean Louis on Sun, 14 Jan 2018 20:47:48 +0300) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sun, 14 Jan 2018 20:47:48 +0300 > From: Jean Louis > Cc: 30106@debbugs.gnu.org > > ./configure --prefix=/package/text/emacs-27.0.50/ --with-mailutils --without-imagemagick --without-pop --with-x-toolkit=lucid --with-modules Does src/config.h have this line: #define HAVE_MODULES 1 And does src/Makefile have this line: MODULES_OBJ = dynlib.o emacs-module.o From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 17:10:54 2018 Received: (at 30106) by debbugs.gnu.org; 14 Jan 2018 22:10:55 +0000 Received: from localhost ([127.0.0.1]:56411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqUQ-0000lA-OD for submit@debbugs.gnu.org; Sun, 14 Jan 2018 17:10:54 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:53062 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqUN-0000kw-Se for 30106@debbugs.gnu.org; Sun, 14 Jan 2018 17:10:52 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Sun, 14 Jan 2018 15:11:16 -0700 id 000000000011B76B.000000005A5BD585.00001BCF Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Sun, 14 Jan 2018 23:12:28 +0100 id 00000000001C03A5.000000005A5BD5CC.00004428 Date: Mon, 15 Jan 2018 01:12:28 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180114221228.GA17422@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <83shb8z0lz.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org, Jean Louis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sun, Jan 14, 2018 at 09:44:40PM +0200, Eli Zaretskii wrote: > > Date: Sun, 14 Jan 2018 20:47:48 +0300 > > From: Jean Louis > > Cc: 30106@debbugs.gnu.org > > > > ./configure --prefix=/package/text/emacs-27.0.50/ --with-mailutils --without-imagemagick --without-pop --with-x-toolkit=lucid --with-modules > > Does src/config.h have this line: > > #define HAVE_MODULES 1 Output of grep MODULES src/config.h: #define EMACS_CONFIG_FEATURES "XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 MODULES LCMS2" #define HAVE_MODULES 1 #define MODULES_SUFFIX ".so" > And does src/Makefile have this line: > > MODULES_OBJ = dynlib.o emacs-module.o Output of grep MODULES Makefile: LIBMODULES = -ldl MODULES_OBJ = dynlib.o emacs-module.o eval.o floatfns.o fns.o font.o print.o lread.o $(MODULES_OBJ) \ $(NOTIFY_LIBS) $(LIB_MATH) $(LIBZ) $(LIBMODULES) $(LIBSYSTEMD_LIBS) \ Jean From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 20:31:11 2018 Received: (at control) by debbugs.gnu.org; 15 Jan 2018 01:31:11 +0000 Received: from localhost ([127.0.0.1]:56498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eatcE-0000ix-TI for submit@debbugs.gnu.org; Sun, 14 Jan 2018 20:31:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eatcE-0000ik-1k for control@debbugs.gnu.org; Sun, 14 Jan 2018 20:31:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eatc8-0003ws-B6 for control@debbugs.gnu.org; Sun, 14 Jan 2018 20:31:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eatc8-0003wk-7a for control@debbugs.gnu.org; Sun, 14 Jan 2018 20:31:04 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eatc7-0004N2-MX for control@debbugs.gnu.org; Sun, 14 Jan 2018 20:31:03 -0500 Subject: control message for bug 30106 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sun, 14 Jan 2018 20:31:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) forwarded 30106 https://github.com/anse1/emacs-libpq/issues/8 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 08:15:21 2018 Received: (at 30106) by debbugs.gnu.org; 15 Jan 2018 13:15:21 +0000 Received: from localhost ([127.0.0.1]:56758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb4bh-0004PV-38 for submit@debbugs.gnu.org; Mon, 15 Jan 2018 08:15:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb4bf-0004PF-Fx for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 08:15:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eb4bX-0001Ez-8b for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 08:15:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eb4bX-0001Ev-5V; Mon, 15 Jan 2018 08:15:11 -0500 Received: from [176.228.60.248] (port=4064 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eb4bW-0007rG-IG; Mon, 15 Jan 2018 08:15:11 -0500 Date: Mon, 15 Jan 2018 15:14:57 +0200 Message-Id: <833737z2jy.fsf@gnu.org> From: Eli Zaretskii To: Jean Louis In-reply-to: <20180114221228.GA17422@protected.rcdrun.com> (message from Jean Louis on Mon, 15 Jan 2018 01:12:28 +0300) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Mon, 15 Jan 2018 01:12:28 +0300 > From: Jean Louis > Cc: Jean Louis , 30106@debbugs.gnu.org > > Output of grep MODULES src/config.h: > > #define EMACS_CONFIG_FEATURES "XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 MODULES LCMS2" > #define HAVE_MODULES 1 > #define MODULES_SUFFIX ".so" > > > And does src/Makefile have this line: > > > > MODULES_OBJ = dynlib.o emacs-module.o > > Output of grep MODULES Makefile: > > LIBMODULES = -ldl > MODULES_OBJ = dynlib.o emacs-module.o > eval.o floatfns.o fns.o font.o print.o lread.o $(MODULES_OBJ) \ > $(NOTIFY_LIBS) $(LIB_MATH) $(LIBZ) $(LIBMODULES) $(LIBSYSTEMD_LIBS) \ This means your build does have support for modules. Returning to the original error: ELC src/emacs-module-tests.elc In toplevel form: src/emacs-module-tests.el:32:1:Error: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' line 32 of emacs-module-test.el is this: (require 'mod-test mod-test-file) So one problem could be that mod-test-file is somehow not calculated correctly: (eval-and-compile (defconst mod-test-file (substitute-in-file-name "$EMACS_TEST_DIRECTORY/data/emacs-module/mod-test") "File name of the module test file.")) So maybe EMACS_TEST_DIRECTORY is incorrect, you your Emacs tree doesn't have the test/data/emacs-module/mod-test directory, or there's no mod-test.so file in that directory? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 12:57:00 2018 Received: (at 30106) by debbugs.gnu.org; 15 Jan 2018 17:57:01 +0000 Received: from localhost ([127.0.0.1]:57733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb90G-0003wZ-Og for submit@debbugs.gnu.org; Mon, 15 Jan 2018 12:57:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb90F-0003wM-4p for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 12:56:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eb908-0006u0-9i for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 12:56:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD, UNRESOLVED_TEMPLATE autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eb8zb-0006Wi-Ao; Mon, 15 Jan 2018 12:56:19 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eb8zZ-0006J7-JW; Mon, 15 Jan 2018 12:56:17 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> X-Spook: Terror Plane quarter USSS Leak Hostage Computer X-Ran: L.:g{flef(w'lV:*Nnl1Su-yV5>9Gom%KGT#$qaj*jod{Ef'%Y1tS}~D>{t*VhOQ!In3+S X-Hue: brightcyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 15 Jan 2018 12:56:17 -0500 In-Reply-To: <833737z2jy.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Jan 2018 15:14:57 +0200") Message-ID: <7l37370zwe.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org, Jean Louis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Eli Zaretskii wrote: > src/emacs-module-tests.el:32:1:Error: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' > > line 32 of emacs-module-test.el is this: > > (require 'mod-test mod-test-file) > > So one problem could be that mod-test-file is somehow not calculated > correctly: > > (eval-and-compile > (defconst mod-test-file > (substitute-in-file-name > "$EMACS_TEST_DIRECTORY/data/emacs-module/mod-test") > "File name of the module test file.")) > > So maybe EMACS_TEST_DIRECTORY is incorrect, you your Emacs tree > doesn't have the test/data/emacs-module/mod-test directory, or there's > no mod-test.so file in that directory? But that would give a different error message. It seems that Fmodule_load does not update load-history. This is causing Frequire to report the wrong file names in its error message, which is making it hard to diagnose the real problem. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 13:10:00 2018 Received: (at 30106) by debbugs.gnu.org; 15 Jan 2018 18:10:00 +0000 Received: from localhost ([127.0.0.1]:57740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb9Cp-0004GB-SV for submit@debbugs.gnu.org; Mon, 15 Jan 2018 13:10:00 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:42881 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb9Cn-0004Fk-26 for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 13:09:57 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Mon, 15 Jan 2018 11:10:21 -0700 id 000000000011B774.000000005A5CEE8E.00003232 Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Mon, 15 Jan 2018 19:09:38 +0100 id 00000000001C038A.000000005A5CEE62.000042AF Date: Mon, 15 Jan 2018 21:09:38 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180115180938.GK30277@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <833737z2jy.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Dear Eli, See below: On Mon, Jan 15, 2018 at 03:14:57PM +0200, Eli Zaretskii wrote: > > Output of grep MODULES src/config.h: > > > > #define EMACS_CONFIG_FEATURES "XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 MODULES LCMS2" > > #define HAVE_MODULES 1 > > #define MODULES_SUFFIX ".so" > > > > > And does src/Makefile have this line: > > > > > > MODULES_OBJ = dynlib.o emacs-module.o > > > > Output of grep MODULES Makefile: > > > > LIBMODULES = -ldl > > MODULES_OBJ = dynlib.o emacs-module.o > > eval.o floatfns.o fns.o font.o print.o lread.o $(MODULES_OBJ) \ > > $(NOTIFY_LIBS) $(LIB_MATH) $(LIBZ) $(LIBMODULES) $(LIBSYSTEMD_LIBS) \ > > This means your build does have support for modules. > > Returning to the original error: > > ELC src/emacs-module-tests.elc On my side that file is located in: /sources/emacs/test/src > In toplevel form: > src/emacs-module-tests.el:32:1:Error: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' > > line 32 of emacs-module-test.el is this: > > (require 'mod-test mod-test-file) That is same so here. > So one problem could be that mod-test-file is somehow not calculated > correctly: > > (eval-and-compile > (defconst mod-test-file > (substitute-in-file-name > "$EMACS_TEST_DIRECTORY/data/emacs-module/mod-test") > "File name of the module test file.")) > > So maybe EMACS_TEST_DIRECTORY is incorrect, you your Emacs tree > doesn't have the test/data/emacs-module/mod-test directory, or there's > no mod-test.so file in that directory? There exist no directory: test/data/emacs-module/mod-test/ There is directory: test/data/emacs-module/ inside of which are following files: total 76 -rw-r--r-- 1 root root 9915 Jan 3 08:19 mod-test.c -rwxr-xr-x 1 root root 62008 Jan 14 20:56 mod-test.so Let me know if I can help anything more. Jean From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 13:55:58 2018 Received: (at 30106) by debbugs.gnu.org; 15 Jan 2018 18:55:58 +0000 Received: from localhost ([127.0.0.1]:57760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb9vJ-0005O1-Vm for submit@debbugs.gnu.org; Mon, 15 Jan 2018 13:55:58 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:51310 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb9vH-0005Nl-VK for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 13:55:56 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Mon, 15 Jan 2018 11:56:20 -0700 id 000000000011B768.000000005A5CF955.00003373 Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Mon, 15 Jan 2018 19:55:33 +0100 id 00000000001C03A5.000000005A5CF925.000018CE Date: Mon, 15 Jan 2018 21:55:33 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180115185533.GA6309@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <833737z2jy.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Mon, Jan 15, 2018 at 03:14:57PM +0200, Eli Zaretskii wrote: > > Date: Mon, 15 Jan 2018 01:12:28 +0300 > > From: Jean Louis > > Cc: Jean Louis , 30106@debbugs.gnu.org > > > > Output of grep MODULES src/config.h: > > > > #define EMACS_CONFIG_FEATURES "XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 MODULES LCMS2" > > #define HAVE_MODULES 1 > > #define MODULES_SUFFIX ".so" > > > > > And does src/Makefile have this line: > > > > > > MODULES_OBJ = dynlib.o emacs-module.o > > > > Output of grep MODULES Makefile: > > > > LIBMODULES = -ldl > > MODULES_OBJ = dynlib.o emacs-module.o > > eval.o floatfns.o fns.o font.o print.o lread.o $(MODULES_OBJ) \ > > $(NOTIFY_LIBS) $(LIB_MATH) $(LIBZ) $(LIBMODULES) $(LIBSYSTEMD_LIBS) \ > > This means your build does have support for modules. > > Returning to the original error: > > ELC src/emacs-module-tests.elc > > In toplevel form: > src/emacs-module-tests.el:32:1:Error: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' > > line 32 of emacs-module-test.el is this: > > (require 'mod-test mod-test-file) > > So one problem could be that mod-test-file is somehow not calculated > correctly: > > (eval-and-compile > (defconst mod-test-file > (substitute-in-file-name > "$EMACS_TEST_DIRECTORY/data/emacs-module/mod-test") > "File name of the module test file.")) > > So maybe EMACS_TEST_DIRECTORY is incorrect, you your Emacs tree > doesn't have the test/data/emacs-module/mod-test directory, or there's > no mod-test.so file in that directory? I can see that 'make check' fails so: ELC src/emacs-module-tests.elc Emacs module assertion: Module function called from outside the current Lisp thread /bin/sh: line 1: 6214 Aborted EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" --module-assertions -batch --no-site-file --no-site-lisp -L ":." -f batch-byte-compile src/emacs-module-tests.el make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 134 make[3]: Target 'src/emacs-module-tests.log' not remade because of errors. GEN src/eval-tests.log From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 15:16:23 2018 Received: (at 30106) by debbugs.gnu.org; 15 Jan 2018 20:16:23 +0000 Received: from localhost ([127.0.0.1]:57796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebBB6-0007NV-PX for submit@debbugs.gnu.org; Mon, 15 Jan 2018 15:16:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebBB4-0007NF-Hl for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 15:16:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebBAu-0004Q9-7Z for 30106@debbugs.gnu.org; Mon, 15 Jan 2018 15:16:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebBAu-0004Q5-3z; Mon, 15 Jan 2018 15:16:08 -0500 Received: from [176.228.60.248] (port=4748 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ebBAt-0007fR-I7; Mon, 15 Jan 2018 15:16:07 -0500 Date: Mon, 15 Jan 2018 22:15:55 +0200 Message-Id: <83wp0iyj2c.fsf@gnu.org> From: Eli Zaretskii To: Jean Louis In-reply-to: <20180115185533.GA6309@protected.rcdrun.com> (message from Jean Louis on Mon, 15 Jan 2018 21:55:33 +0300) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Mon, 15 Jan 2018 21:55:33 +0300 > From: Jean Louis > Cc: 30106@debbugs.gnu.org > > I can see that 'make check' fails so: > > ELC src/emacs-module-tests.elc > Emacs module assertion: Module function called from outside the current Lisp thread > /bin/sh: line 1: 6214 Aborted EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" --module-assertions -batch --no-site-file --no-site-lisp -L ":." -f batch-byte-compile src/emacs-module-tests.el > make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 134 > make[3]: Target 'src/emacs-module-tests.log' not remade because of errors. > GEN src/eval-tests.log Was your Emacs built with threads? What OS is that? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 00:17:46 2018 Received: (at 30106) by debbugs.gnu.org; 16 Jan 2018 05:17:46 +0000 Received: from localhost ([127.0.0.1]:57975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebJd4-0000Ui-FY for submit@debbugs.gnu.org; Tue, 16 Jan 2018 00:17:46 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:38730 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebJd3-0000UQ-8a for 30106@debbugs.gnu.org; Tue, 16 Jan 2018 00:17:45 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Mon, 15 Jan 2018 22:18:09 -0700 id 000000000011B76D.000000005A5D8B12.00003E49 Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Tue, 16 Jan 2018 06:17:27 +0100 id 00000000001C03A4.000000005A5D8AE7.000061D8 Date: Tue, 16 Jan 2018 08:17:27 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180116051727.GB9388@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <83wp0iyj2c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <83wp0iyj2c.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, On Mon, Jan 15, 2018 at 10:15:55PM +0200, Eli Zaretskii wrote: > > Date: Mon, 15 Jan 2018 21:55:33 +0300 > > From: Jean Louis > > Cc: 30106@debbugs.gnu.org > > > > I can see that 'make check' fails so: > > > > ELC src/emacs-module-tests.elc > > Emacs module assertion: Module function called from outside the current Lisp thread > > /bin/sh: line 1: 6214 Aborted EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" --module-assertions -batch --no-site-file --no-site-lisp -L ":." -f batch-byte-compile src/emacs-module-tests.el > > make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 134 > > make[3]: Target 'src/emacs-module-tests.log' not remade because of errors. > > GEN src/eval-tests.log > > Was your Emacs built with threads? What OS is that? I tried building with this configuration: ./configure --prefix=/package/text/emacs --with-modules --without-all --without-pop --with-mailutils and OS is just GNU with kernel Linux, I do not use distributions, I am compiling from source. I have tried --without-threads and it is not working as well. Jean From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 13:07:21 2018 Received: (at 30106) by debbugs.gnu.org; 16 Jan 2018 18:07:21 +0000 Received: from localhost ([127.0.0.1]:59023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebVdp-0001nk-Jw for submit@debbugs.gnu.org; Tue, 16 Jan 2018 13:07:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebVdo-0001nW-7m for 30106@debbugs.gnu.org; Tue, 16 Jan 2018 13:07:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebVdi-0004wW-Be for 30106@debbugs.gnu.org; Tue, 16 Jan 2018 13:07:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebVd3-00047T-Ar; Tue, 16 Jan 2018 13:06:33 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ebVd2-0005Ul-SD; Tue, 16 Jan 2018 13:06:32 -0500 From: Glenn Morris To: Jean Louis Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <83wp0iyj2c.fsf@gnu.org> <20180116051727.GB9388@protected.rcdrun.com> X-Spook: gamma Secret Service Spammer Artistic Assassins 64 X-Ran: O/}YWT0l{v_L`]FLy4B5y0PzxG:zzM8> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Jean Louis wrote: >> ELC src/emacs-module-tests.elc >> >> In toplevel form: >> src/emacs-module-tests.el:32:1:Error: Loading file >> /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature >> `mod-test' >> make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 1 [...] >> > ELC src/emacs-module-tests.elc >> > Emacs module assertion: Module function called from outside the >> > current Lisp thread >> > /bin/sh: line 1: 6214 Aborted EMACSLOADPATH= LC_ALL=C >> > EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" >> > --module-assertions -batch --no-site-file --no-site-lisp -L ":." >> > -f batch-byte-compile src/emacs-module-tests.el So what's changed such that you now get a different error to the one that is the subject of this report? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 13:11:08 2018 Received: (at 30106) by debbugs.gnu.org; 16 Jan 2018 18:11:08 +0000 Received: from localhost ([127.0.0.1]:59029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebVhU-0001tF-41 for submit@debbugs.gnu.org; Tue, 16 Jan 2018 13:11:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebVhT-0001t2-7X for 30106@debbugs.gnu.org; Tue, 16 Jan 2018 13:11:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebVhK-0007yu-RJ for 30106@debbugs.gnu.org; Tue, 16 Jan 2018 13:11:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebVhK-0007yp-NB; Tue, 16 Jan 2018 13:10:58 -0500 Received: from [176.228.60.248] (port=1677 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ebVhK-00008c-3w; Tue, 16 Jan 2018 13:10:58 -0500 Date: Tue, 16 Jan 2018 20:10:49 +0200 Message-Id: <836081y8ra.fsf@gnu.org> From: Eli Zaretskii To: Jean Louis In-reply-to: <20180115185533.GA6309@protected.rcdrun.com> (message from Jean Louis on Mon, 15 Jan 2018 21:55:33 +0300) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Mon, 15 Jan 2018 21:55:33 +0300 > From: Jean Louis > Cc: 30106@debbugs.gnu.org > > I can see that 'make check' fails so: > > ELC src/emacs-module-tests.elc > Emacs module assertion: Module function called from outside the current Lisp thread > /bin/sh: line 1: 6214 Aborted EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" --module-assertions -batch --no-site-file --no-site-lisp -L ":." -f batch-byte-compile src/emacs-module-tests.el Ah, that changes almost everything. The test fails here: static void module_assert_thread (void) { if (!module_assertions) return; if (!in_current_thread ()) module_abort ("Module function called from outside " <<<<<<<<<<<<<<< "the current Lisp thread"); if (gc_in_progress) module_abort ("Module function called during garbage collection"); } And in_current_thread does this: static bool in_current_thread (void) { if (current_thread == NULL) return false; #ifdef HAVE_PTHREAD return pthread_equal (pthread_self (), current_thread->thread_id); #elif defined WINDOWSNT return GetCurrentThreadId () == current_thread->thread_id; #endif } So either current_thread is NULL in your case, or pthread_equal returns false. Can you tell which one of these happens? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 16:02:30 2018 Received: (at 30106) by debbugs.gnu.org; 16 Jan 2018 21:02:30 +0000 Received: from localhost ([127.0.0.1]:59135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebYNJ-0007rP-W5 for submit@debbugs.gnu.org; Tue, 16 Jan 2018 16:02:30 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:47197 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebYNI-0007rC-TF for 30106@debbugs.gnu.org; Tue, 16 Jan 2018 16:02:29 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Tue, 16 Jan 2018 14:02:46 -0700 id 000000000011B78D.000000005A5E687B.00005284 Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Tue, 16 Jan 2018 20:17:01 +0100 id 00000000001C99B2.000000005A5E4FAD.000046FE Date: Tue, 16 Jan 2018 22:17:01 +0300 From: Jean Louis To: Glenn Morris Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180116191701.GA18155@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <83wp0iyj2c.fsf@gnu.org> <20180116051727.GB9388@protected.rcdrun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Jan 16, 2018 at 01:06:32PM -0500, Glenn Morris wrote: > Jean Louis wrote: > > >> ELC src/emacs-module-tests.elc > >> > >> In toplevel form: > >> src/emacs-module-tests.el:32:1:Error: Loading file > >> /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature > >> `mod-test' > >> make[3]: *** [Makefile:146: src/emacs-module-tests.elc] Error 1 > [...] > >> > ELC src/emacs-module-tests.elc > >> > Emacs module assertion: Module function called from outside the > >> > current Lisp thread > >> > /bin/sh: line 1: 6214 Aborted EMACSLOADPATH= LC_ALL=C > >> > EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" > >> > --module-assertions -batch --no-site-file --no-site-lisp -L ":." > >> > -f batch-byte-compile src/emacs-module-tests.el > > So what's changed such that you now get a different error to the one > that is the subject of this report? The original report relates to the fact that I cannot do (require 'pq) for dynamic module in question. I have tried to "make check", and the message above is the result of it. Jean From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 16:02:33 2018 Received: (at 30106) by debbugs.gnu.org; 16 Jan 2018 21:02:33 +0000 Received: from localhost ([127.0.0.1]:59138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebYNN-0007re-77 for submit@debbugs.gnu.org; Tue, 16 Jan 2018 16:02:33 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:50126 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebYNK-0007rE-3i for 30106@debbugs.gnu.org; Tue, 16 Jan 2018 16:02:30 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Tue, 16 Jan 2018 14:02:47 -0700 id 000000000011B78E.000000005A5E687C.0000528B Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Tue, 16 Jan 2018 20:18:55 +0100 id 00000000001C99B5.000000005A5E501F.0000471E Date: Tue, 16 Jan 2018 22:18:55 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180116191855.GB18155@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <836081y8ra.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Jan 16, 2018 at 08:10:49PM +0200, Eli Zaretskii wrote: > > Date: Mon, 15 Jan 2018 21:55:33 +0300 > > From: Jean Louis > > Cc: 30106@debbugs.gnu.org > > > > I can see that 'make check' fails so: > > > > ELC src/emacs-module-tests.elc > > Emacs module assertion: Module function called from outside the current Lisp thread > > /bin/sh: line 1: 6214 Aborted EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" --module-assertions -batch --no-site-file --no-site-lisp -L ":." -f batch-byte-compile src/emacs-module-tests.el > > Ah, that changes almost everything. The test fails here: > > static void > module_assert_thread (void) > { > if (!module_assertions) > return; > if (!in_current_thread ()) > module_abort ("Module function called from outside " <<<<<<<<<<<<<<< > "the current Lisp thread"); > if (gc_in_progress) > module_abort ("Module function called during garbage collection"); > } > > And in_current_thread does this: > > static bool > in_current_thread (void) > { > if (current_thread == NULL) > return false; > #ifdef HAVE_PTHREAD > return pthread_equal (pthread_self (), current_thread->thread_id); > #elif defined WINDOWSNT > return GetCurrentThreadId () == current_thread->thread_id; > #endif > } > > So either current_thread is NULL in your case, or pthread_equal > returns false. Can you tell which one of these happens? I cannot test it myself on my own. You may tell me what to do, to test it. Do I miss some software package? Jean From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 10:37:04 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 15:37:04 +0000 Received: from localhost ([127.0.0.1]:60369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebplw-0004Bh-0s for submit@debbugs.gnu.org; Wed, 17 Jan 2018 10:37:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebplu-0004BD-66 for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 10:37:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebplj-0007pP-Ok for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 10:36:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebplj-0007pF-K8; Wed, 17 Jan 2018 10:36:51 -0500 Received: from [176.228.60.248] (port=2401 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ebplj-0002Zf-37; Wed, 17 Jan 2018 10:36:51 -0500 Date: Wed, 17 Jan 2018 17:36:45 +0200 Message-Id: <83mv1cwl82.fsf@gnu.org> From: Eli Zaretskii To: Jean Louis In-reply-to: <20180116191855.GB18155@protected.rcdrun.com> (message from Jean Louis on Tue, 16 Jan 2018 22:18:55 +0300) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Tue, 16 Jan 2018 22:18:55 +0300 > From: Jean Louis > Cc: 30106@debbugs.gnu.org > > > in_current_thread (void) > > { > > if (current_thread == NULL) > > return false; > > #ifdef HAVE_PTHREAD > > return pthread_equal (pthread_self (), current_thread->thread_id); > > #elif defined WINDOWSNT > > return GetCurrentThreadId () == current_thread->thread_id; > > #endif > > } > > > > So either current_thread is NULL in your case, or pthread_equal > > returns false. Can you tell which one of these happens? > > I cannot test it myself on my own. You may tell me > what to do, to test it. Apply the patch below, rebuild Emacs, rerun the test, and see if there's the telltale "current_thread is NULL" message in the log. > Do I miss some software package? Not sure yet. diff --git a/src/emacs-module.c b/src/emacs-module.c index 00f0e86..333c583 100644 --- a/src/emacs-module.c +++ b/src/emacs-module.c @@ -804,7 +804,10 @@ static bool in_current_thread (void) { if (current_thread == NULL) + { + fprintf (stderr, "current_thread is NULL\n"); return false; + } #ifdef HAVE_PTHREAD return pthread_equal (pthread_self (), current_thread->thread_id); #elif defined WINDOWSNT From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 12:03:56 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 17:03:56 +0000 Received: from localhost ([127.0.0.1]:60412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebr7x-0006XQ-Sw for submit@debbugs.gnu.org; Wed, 17 Jan 2018 12:03:56 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:47839 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebr7s-0006Wf-Ii for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 12:03:51 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Wed, 17 Jan 2018 10:04:12 -0700 id 000000000011D712.000000005A5F820D.0000690C Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Wed, 17 Jan 2018 18:03:10 +0100 id 00000000001C038A.000000005A5F81CE.00006050 Date: Wed, 17 Jan 2018 20:03:10 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180117170310.GA31570@protected.rcdrun.com> References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_protected.rcdrun.com-24656-1516208590-0001-2" Content-Disposition: inline In-Reply-To: <83mv1cwl82.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_protected.rcdrun.com-24656-1516208590-0001-2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wed, Jan 17, 2018 at 05:36:45PM +0200, Eli Zaretskii wrote: > > Date: Tue, 16 Jan 2018 22:18:55 +0300 > > From: Jean Louis > > Cc: 30106@debbugs.gnu.org > > > > > in_current_thread (void) > > > { > > > if (current_thread == NULL) > > > return false; > > > #ifdef HAVE_PTHREAD > > > return pthread_equal (pthread_self (), current_thread->thread_id); > > > #elif defined WINDOWSNT > > > return GetCurrentThreadId () == current_thread->thread_id; > > > #endif > > > } > > > > > > So either current_thread is NULL in your case, or pthread_equal > > > returns false. Can you tell which one of these happens? > > > > I cannot test it myself on my own. You may tell me > > what to do, to test it. > > Apply the patch below, rebuild Emacs, rerun the test, and see if > there's the telltale "current_thread is NULL" > message in the log. I have done that, I did not see during "make check" the line "current_thread is NULL", and I am attaching the output from "make check". Jean > > > Do I miss some software package? > > Not sure yet. > > diff --git a/src/emacs-module.c b/src/emacs-module.c > index 00f0e86..333c583 100644 > --- a/src/emacs-module.c > +++ b/src/emacs-module.c > @@ -804,7 +804,10 @@ static bool > in_current_thread (void) > { > if (current_thread == NULL) > + { > + fprintf (stderr, "current_thread is NULL\n"); > return false; > + } > #ifdef HAVE_PTHREAD > return pthread_equal (pthread_self (), current_thread->thread_id); > #elif defined WINDOWSNT --=_protected.rcdrun.com-24656-1516208590-0001-2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="check.log" nohup: ignoring input make -C lib all make[1]: Entering directory '/sources/emacs/lib' make[1]: Nothing to be done for 'all'. make[1]: Leaving directory '/sources/emacs/lib' make -C lib-src all make[1]: Entering directory '/sources/emacs/lib-src' make[1]: Nothing to be done for 'all'. make[1]: Leaving directory '/sources/emacs/lib-src' make -C src VCSWITNESS='$(srcdir)/../.git/logs/HEAD' all make[1]: Entering directory '/sources/emacs/src' make -C ../admin/charsets all make[2]: Entering directory '/sources/emacs/admin/charsets' make[2]: Nothing to be done for 'all'. make[2]: Leaving directory '/sources/emacs/admin/charsets' make -C ../admin/unidata charscript.el make[2]: Entering directory '/sources/emacs/admin/unidata' make[2]: Nothing to be done for 'charscript.el'. make[2]: Leaving directory '/sources/emacs/admin/unidata' make -C ../admin/unidata all EMACS="../../src/bootstrap-emacs" make[2]: Entering directory '/sources/emacs/admin/unidata' make[2]: Nothing to be done for 'all'. make[2]: Leaving directory '/sources/emacs/admin/unidata' make -C ../admin/charsets cp51932.el make[2]: Entering directory '/sources/emacs/admin/charsets' make[2]: Nothing to be done for 'cp51932.el'. make[2]: Leaving directory '/sources/emacs/admin/charsets' make -C ../admin/charsets eucjp-ms.el make[2]: Entering directory '/sources/emacs/admin/charsets' make[2]: Nothing to be done for 'eucjp-ms.el'. make[2]: Leaving directory '/sources/emacs/admin/charsets' make[1]: Leaving directory '/sources/emacs/src' make -C lisp all make[1]: Entering directory '/sources/emacs/lisp' make -C ../leim all EMACS="../src/emacs" make[2]: Entering directory '/sources/emacs/leim' make[2]: Nothing to be done for 'all'. make[2]: Leaving directory '/sources/emacs/leim' make -C ../admin/grammars all EMACS="../../src/emacs" make[2]: Entering directory '/sources/emacs/admin/grammars' make[2]: Nothing to be done for 'all'. make[2]: Leaving directory '/sources/emacs/admin/grammars' make[2]: Entering directory '/sources/emacs/lisp' make[2]: Nothing to be done for 'compile-targets'. make[2]: Leaving directory '/sources/emacs/lisp' make[1]: Leaving directory '/sources/emacs/lisp' make info-real info-dir make[1]: Entering directory '/sources/emacs' make -C doc/lispref info make[2]: Entering directory '/sources/emacs/doc/lispref' make[2]: Nothing to be done for 'info'. make[2]: Leaving directory '/sources/emacs/doc/lispref' make -C doc/lispintro info make[2]: Entering directory '/sources/emacs/doc/lispintro' make[2]: Nothing to be done for 'info'. make[2]: Leaving directory '/sources/emacs/doc/lispintro' make -C doc/emacs info make[2]: Entering directory '/sources/emacs/doc/emacs' make[2]: Nothing to be done for 'info'. make[2]: Leaving directory '/sources/emacs/doc/emacs' make -C doc/misc info make[2]: Entering directory '/sources/emacs/doc/misc' make[2]: Nothing to be done for 'info'. make[2]: Leaving directory '/sources/emacs/doc/misc' make[1]: Nothing to be done for 'info-dir'. make[1]: Leaving directory '/sources/emacs' make -C test check make[1]: Entering directory '/sources/emacs/test' rm -f *.tmp make[2]: Entering directory '/sources/emacs/test' make[3]: Entering directory '/sources/emacs/test' GEN lib-src/emacsclient-tests.log GEN lisp/abbrev-tests.log GEN lisp/arc-mode-tests.log GEN lisp/auth-source-pass-tests.log GEN lisp/auth-source-tests.log GEN lisp/autorevert-tests.log GEN lisp/buff-menu-tests.log GEN lisp/calc/calc-tests.log GEN lisp/calendar/icalendar-tests.log GEN lisp/calendar/parse-time-tests.log GEN lisp/calendar/todo-mode-tests.log GEN lisp/char-fold-tests.log GEN lisp/color-tests.log ELC lisp/comint-tests.elc GEN lisp/comint-tests.log GEN lisp/dabbrev-tests.log GEN lisp/descr-text-tests.log GEN lisp/dired-aux-tests.log GEN lisp/dired-tests.log GEN lisp/dired-x-tests.log GEN lisp/dom-tests.log GEN lisp/electric-tests.log GEN lisp/emacs-lisp/benchmark-tests.log ELC lisp/emacs-lisp/bytecomp-tests.elc GEN lisp/emacs-lisp/bytecomp-tests.log GEN lisp/emacs-lisp/checkdoc-tests.log GEN lisp/emacs-lisp/cl-extra-tests.log GEN lisp/emacs-lisp/cl-generic-tests.log GEN lisp/emacs-lisp/cl-lib-tests.log GEN lisp/emacs-lisp/cl-macs-tests.log GEN lisp/emacs-lisp/cl-print-tests.log GEN lisp/emacs-lisp/cl-seq-tests.log GEN lisp/emacs-lisp/derived-tests.log GEN lisp/emacs-lisp/edebug-tests.log ELC lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.elc `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. In toplevel form: lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:97:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:101:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:105:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:106:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:179:8:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:179:24:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:184:8:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:184:24:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:219:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:231:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:236:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:237:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:261:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:271:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:275:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:276:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:299:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:300:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:310:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:311:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:323:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:324:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:328:14:Warning: Obsolete name arg "test" to constructor eitest-Jd `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:349:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:350:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:356:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:357:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:363:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:364:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:369:10:Warning: `next-method-p' is an obsolete function (as of 25.1); use `cl-next-method-p' instead. lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:370:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. Obsolete name arg "" to constructor CNM-2 GEN lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.log GEN lisp/emacs-lisp/eieio-tests/eieio-test-persist.log ELC lisp/emacs-lisp/eieio-tests/eieio-tests.elc Class allocated slots do not need :initarg Class allocated slots do not need :initarg `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. In toplevel form: lisp/emacs-lisp/eieio-tests/eieio-tests.el:169:18:Warning: `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:246:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:291:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:300:4:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:355:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:353:36:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:376:12:Warning: Unknown slot `ooga-booga' lisp/emacs-lisp/eieio-tests/eieio-tests.el:376:44:Warning: Unknown slot `ooga-booga' `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:404:8:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:418:12:Warning: Unknown slot `:derived-value' lisp/emacs-lisp/eieio-tests/eieio-tests.el:424:20:Warning: Unknown slot `:derived-value' `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:455:6:Warning: `call-next-method' is an obsolete function (as of 25.1); use `cl-call-next-method' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. Obsolete name arg "II Test." to constructor II Class allocated slots do not need :initarg lisp/emacs-lisp/eieio-tests/eieio-tests.el:875:40:Warning: Unknown slot `missing-slot' `defmethod' is an obsolete macro (as of 25.1); use `cl-defmethod' instead. `defgeneric' is an obsolete macro (as of 25.1); use `cl-defgeneric' instead. lisp/emacs-lisp/eieio-tests/eieio-tests.el:916:16:Warning: Obsolete name arg "toto" to constructor eieio--testing In end of data: lisp/emacs-lisp/eieio-tests/eieio-tests.el:928:1:Warning: the following functions are not known to be defined: class-alloc-initarg--eieio-childp, static-method-class-2--eieio-childp, static-method-class-2, eitest-subordinate--eieio-childp, eitest-superior--eieio-childp, eitest-superior GEN lisp/emacs-lisp/eieio-tests/eieio-tests.log GEN lisp/emacs-lisp/ert-tests.log GEN lisp/emacs-lisp/ert-x-tests.log GEN lisp/emacs-lisp/faceup-tests/faceup-test-basics.log GEN lisp/emacs-lisp/faceup-tests/faceup-test-files.log GEN lisp/emacs-lisp/generator-tests.log ELC lisp/emacs-lisp/gv-tests.elc GEN lisp/emacs-lisp/gv-tests.log GEN lisp/emacs-lisp/let-alist-tests.log GEN lisp/emacs-lisp/lisp-mode-tests.log GEN lisp/emacs-lisp/lisp-tests.log GEN lisp/emacs-lisp/map-tests.log ELC lisp/emacs-lisp/nadvice-tests.elc GEN lisp/emacs-lisp/nadvice-tests.log GEN lisp/emacs-lisp/package-tests.log ELC lisp/emacs-lisp/pcase-tests.elc GEN lisp/emacs-lisp/pcase-tests.log GEN lisp/emacs-lisp/pp-tests.log GEN lisp/emacs-lisp/regexp-opt-tests.log GEN lisp/emacs-lisp/ring-tests.log GEN lisp/emacs-lisp/rmc-tests.log GEN lisp/emacs-lisp/rx-tests.log GEN lisp/emacs-lisp/seq-tests.log GEN lisp/emacs-lisp/subr-x-tests.log GEN lisp/emacs-lisp/tabulated-list-test.log GEN lisp/emacs-lisp/testcover-tests.log GEN lisp/emacs-lisp/thunk-tests.log GEN lisp/emacs-lisp/timer-tests.log GEN lisp/emulation/viper-tests.log GEN lisp/epg-tests.log GEN lisp/erc/erc-track-tests.log GEN lisp/eshell/em-hist-tests.log GEN lisp/eshell/em-ls-tests.log GEN lisp/eshell/eshell-tests.log GEN lisp/faces-tests.log GEN lisp/ffap-tests.log ELC lisp/filenotify-tests.elc GEN lisp/filenotify-tests.log GEN lisp/files-tests.log GEN lisp/files-x-tests.log GEN lisp/gnus/gnus-tests.log GEN lisp/gnus/message-tests.log GEN lisp/help-fns-tests.log GEN lisp/hi-lock-tests.log GEN lisp/htmlfontify-tests.log GEN lisp/ibuffer-tests.log GEN lisp/ido-tests.log GEN lisp/imenu-tests.log GEN lisp/info-xref-tests.log GEN lisp/international/mule-tests.log GEN lisp/international/mule-util-tests.log GEN lisp/international/ucs-normalize-tests.log GEN lisp/isearch-tests.log GEN lisp/jit-lock-tests.log GEN lisp/json-tests.log GEN lisp/kmacro-tests.log GEN lisp/ls-lisp-tests.log GEN lisp/mail/rmail-tests.log GEN lisp/man-tests.log GEN lisp/md4-tests.log GEN lisp/minibuffer-tests.log GEN lisp/mouse-tests.log GEN lisp/net/dbus-tests.log GEN lisp/net/gnutls-tests.log GEN lisp/net/mailcap-tests.log GEN lisp/net/network-stream-tests.log GEN lisp/net/newsticker-tests.log GEN lisp/net/puny-tests.log GEN lisp/net/sasl-scram-rfc-tests.log GEN lisp/net/shr-tests.log GEN lisp/net/tramp-archive-tests.log GEN lisp/net/tramp-tests.log GEN lisp/obarray-tests.log GEN lisp/progmodes/bat-mode-tests.log GEN lisp/progmodes/cc-mode-tests.log GEN lisp/progmodes/compile-tests.log GEN lisp/progmodes/elisp-mode-tests.log GEN lisp/progmodes/etags-tests.log GEN lisp/progmodes/f90-tests.log GEN lisp/progmodes/flymake-tests.log GEN lisp/progmodes/js-tests.log GEN lisp/progmodes/python-tests.log GEN lisp/progmodes/ruby-mode-tests.log GEN lisp/progmodes/sql-tests.log GEN lisp/progmodes/subword-tests.log GEN lisp/progmodes/xref-tests.log GEN lisp/ps-print-tests.log GEN lisp/register-tests.log GEN lisp/replace-tests.log GEN lisp/rot13-tests.log GEN lisp/ses-tests.log GEN lisp/shell-tests.log GEN lisp/simple-tests.log GEN lisp/sort-tests.log GEN lisp/soundex-tests.log GEN lisp/subr-tests.log GEN lisp/tar-mode-tests.log GEN lisp/textmodes/css-mode-tests.log GEN lisp/textmodes/dns-mode-tests.log GEN lisp/textmodes/mhtml-mode-tests.log GEN lisp/textmodes/reftex-tests.log GEN lisp/textmodes/sgml-mode-tests.log GEN lisp/textmodes/tildify-tests.log GEN lisp/thingatpt-tests.log GEN lisp/url/url-auth-tests.log GEN lisp/url/url-expand-tests.log GEN lisp/url/url-future-tests.log GEN lisp/url/url-parse-tests.log GEN lisp/url/url-tramp-tests.log GEN lisp/url/url-util-tests.log GEN lisp/vc/add-log-tests.log GEN lisp/vc/diff-mode-tests.log GEN lisp/vc/ediff-diff-tests.log GEN lisp/vc/ediff-ptch-tests.log GEN lisp/vc/smerge-mode-tests.log GEN lisp/vc/vc-bzr-tests.log Running 3 tests (2018-01-17 17:54:54+0100) Test vc-bzr-test-bug9726 backtrace: signal(error ("No VC backend is responsible for /tmp/vc-bzr-testvLXk error("No VC backend is responsible for %s" "/tmp/vc-bzr-testvLXkL6/ vc-responsible-backend("/tmp/vc-bzr-testvLXkL6/bzr/ignored-dir") vc-dir("/tmp/vc-bzr-testvLXkL6/bzr/ignored-dir") (progn (make-directory ignored-dir) (let ((temp-buffer (generate-new (unwind-protect (progn (make-directory ignored-dir) (let ((temp-buff (let* ((homedir (make-temp-file "vc-bzr-test" t)) (bzrdir (expand-fi (lambda nil (let* ((fn-0 (function executable-find)) (args-1 (condit ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name vc-bzr-test-bug9726 :documentation "T ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/vc/vc-bzr-tests.el" command-line() normal-top-level() Test vc-bzr-test-bug9726 condition: (error "No VC backend is responsible for /tmp/vc-bzr-testvLXkL6/bzr/ignored-dir") FAILED 1/3 vc-bzr-test-bug9726 Test vc-bzr-test-bug9781 backtrace: signal(error ("No VC backend is responsible for /tmp/vc-bzr-testp9QA error("No VC backend is responsible for %s" "/tmp/vc-bzr-testp9QA97/ vc-responsible-backend("/tmp/vc-bzr-testp9QA97/bzr") vc-dir("/tmp/vc-bzr-testp9QA97/bzr") (progn (call-process vc-bzr-program nil nil nil "init") (make-direct (unwind-protect (progn (call-process vc-bzr-program nil nil nil "ini (let* ((homedir (make-temp-file "vc-bzr-test" t)) (bzrdir (expand-fi (lambda nil (let* ((fn-10 (function executable-find)) (args-11 (cond ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name vc-bzr-test-bug9781 :documentation "T ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/vc/vc-bzr-tests.el" command-line() normal-top-level() Test vc-bzr-test-bug9781 condition: (error "No VC backend is responsible for /tmp/vc-bzr-testp9QA97/bzr") FAILED 2/3 vc-bzr-test-bug9781 passed 3/3 vc-bzr-test-faulty-bzr-autoloads Ran 3 tests, 1 results as expected, 2 unexpected (2018-01-17 17:54:55+0100) 2 unexpected results: FAILED vc-bzr-test-bug9726 FAILED vc-bzr-test-bug9781 make[3]: *** [Makefile:166: lisp/vc/vc-bzr-tests.log] Error 1 GEN lisp/vc/vc-hg-tests.log GEN lisp/vc/vc-tests.log Running 20 tests (2018-01-17 17:54:55+0100) Test vc-test-bzr00-create-repo backtrace: signal(error ("Running bzr init ....FAILED (status 1)")) error("Running %s...FAILED (%s)" "bzr init ." "status 1") vc-do-command("*vc*" 0 "bzr" nil "init") apply(vc-do-command "*vc*" 0 "bzr" nil "init" nil) vc-bzr-command("init" nil 0 nil) vc-bzr-create-repo() apply(vc-bzr-create-repo nil) vc-call-backend(Bzr create-repo) vc-create-repo(Bzr) (cond ((eq backend 'CVS) (let ((tmp-dir (expand-file-name (make-temp vc-test--create-repo-function(Bzr) (progn (add-hook 'vc-test--cleanup-hook (list 'lambda nil (cons 'del (unwind-protect (progn (add-hook 'vc-test--cleanup-hook (list 'lambd (let ((vc-handled-backends (list backend)) (default-directory (file- vc-test--create-repo(Bzr) (lambda nil (vc-test--create-repo 'Bzr))() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name vc-test-bzr00-create-repo :documentat ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/vc/vc-tests.el" "--e command-line() normal-top-level() Test vc-test-bzr00-create-repo condition: (error "Running bzr init ....FAILED (status 1)") FAILED 1/20 vc-test-bzr00-create-repo skipped 2/20 vc-test-bzr01-register skipped 3/20 vc-test-bzr02-state skipped 4/20 vc-test-bzr03-working-revision skipped 5/20 vc-test-bzr04-checkout-model Test vc-test-cvs00-create-repo backtrace: rename-file("module/CVS" "/tmp/vc-testR6RH3f/") (let ((tmp-dir (expand-file-name (make-temp-name "vc-test") temporar (cond ((eq backend 'CVS) (let ((tmp-dir (expand-file-name (make-temp vc-test--create-repo-function(CVS) (progn (add-hook 'vc-test--cleanup-hook (list 'lambda nil (cons 'del (unwind-protect (progn (add-hook 'vc-test--cleanup-hook (list 'lambd (let ((vc-handled-backends (list backend)) (default-directory (file- vc-test--create-repo(CVS) (lambda nil (vc-test--create-repo 'CVS))() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name vc-test-cvs00-create-repo :documentat ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/vc/vc-tests.el" "--e command-line() normal-top-level() Test vc-test-cvs00-create-repo condition: (file-missing "Renaming" "No such file or directory" "/tmp/vc-testR6RH3f/module/CVS" "/tmp/vc-testR6RH3f/CVS") FAILED 6/20 vc-test-cvs00-create-repo skipped 7/20 vc-test-cvs01-register skipped 8/20 vc-test-cvs02-state skipped 9/20 vc-test-cvs03-working-revision skipped 10/20 vc-test-cvs04-checkout-model passed 11/20 vc-test-git00-create-repo Registering (/tmp/vc-testYZB7BT/foo bla)... Registering (/tmp/vc-testYZB7BT/foo bla)... done passed 12/20 vc-test-git01-register vc-state2 nil vc-state3 Git unregistered Registering (foo)... Registering (foo)... done vc-state4 added vc-state5 Git unregistered passed 13/20 vc-test-git02-state vc-working-revision1 nil vc-working-revision2 nil vc-working-revision3 nil Registering (foo)... Registering (foo)... done vc-working-revision4 nil vc-working-revision5 nil passed 14/20 vc-test-git03-working-revision vc-checkout-model1 implicit vc-checkout-model2 implicit vc-checkout-model3 implicit Registering (foo)... Registering (foo)... done vc-checkout-model4 implicit vc-checkout-model5 implicit passed 15/20 vc-test-git04-checkout-model passed 16/20 vc-test-hg00-create-repo Registering (/tmp/vc-testbjakLV/foo bla)... Registering (/tmp/vc-testbjakLV/foo bla)... done passed 17/20 vc-test-hg01-register vc-state2 nil vc-state3 Hg unregistered Registering (foo)... Registering (foo)... done vc-state4 added vc-state5 Hg unregistered passed 18/20 vc-test-hg02-state vc-working-revision1 nil vc-working-revision2 nil vc-working-revision3 nil Registering (foo)... Registering (foo)... done vc-working-revision4 0 vc-working-revision5 nil passed 19/20 vc-test-hg03-working-revision vc-checkout-model1 implicit vc-checkout-model2 implicit vc-checkout-model3 implicit Registering (foo)... Registering (foo)... done vc-checkout-model4 implicit vc-checkout-model5 implicit passed 20/20 vc-test-hg04-checkout-model Ran 20 tests, 10 results as expected, 2 unexpected, 8 skipped (2018-01-17 17:54:58+0100) 2 unexpected results: FAILED vc-test-bzr00-create-repo FAILED vc-test-cvs00-create-repo 8 skipped results: SKIPPED vc-test-bzr01-register SKIPPED vc-test-bzr02-state SKIPPED vc-test-bzr03-working-revision SKIPPED vc-test-bzr04-checkout-model SKIPPED vc-test-cvs01-register SKIPPED vc-test-cvs02-state SKIPPED vc-test-cvs03-working-revision SKIPPED vc-test-cvs04-checkout-model make[3]: *** [Makefile:166: lisp/vc/vc-tests.log] Error 1 GEN lisp/whitespace-tests.log GEN lisp/xdg-tests.log ELC lisp/xml-tests.elc GEN lisp/xml-tests.log GEN lisp/xt-mouse-tests.log GEN src/alloc-tests.log GEN src/buffer-tests.log GEN src/callproc-tests.log GEN src/casefiddle-tests.log GEN src/charset-tests.log GEN src/chartab-tests.log GEN src/cmds-tests.log GEN src/coding-tests.log GEN src/data-tests.log GEN src/decompress-tests.log GEN src/doc-tests.log GEN src/editfns-tests.log CCLD data/emacs-module/mod-test.so ELC src/emacs-module-tests.elc Emacs module assertion: Module function called from outside the current Lisp thread /bin/sh: line 1: 24340 Aborted EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/sources/emacs/test "../src/emacs" --module-assertions -batch --no-site-file --no-site-lisp -L ":." -f batch-byte-compile src/emacs-module-tests.el make[3]: *** [Makefile:147: src/emacs-module-tests.elc] Error 134 make[3]: Target 'src/emacs-module-tests.log' not remade because of errors. GEN src/eval-tests.log GEN src/fileio-tests.log GEN src/floatfns-tests.log GEN src/fns-tests.log ELC src/font-tests.elc GEN src/font-tests.log GEN src/inotify-tests.log GEN src/json-tests.log GEN src/keyboard-tests.log Running 1 tests (2018-01-17 17:55:00+0100) make[3]: *** [Makefile:166: src/keyboard-tests.log] Error 1 GEN src/keymap-tests.log GEN src/lcms-tests.log GEN src/lread-tests.log GEN src/marker-tests.log GEN src/minibuf-tests.log GEN src/print-tests.log ELC src/process-tests.elc GEN src/process-tests.log GEN src/regex-tests.log GEN src/syntax-tests.log GEN src/textprop-tests.log GEN src/thread-tests.log Running 28 tests (2018-01-17 17:55:02+0100) Test thread-errors backtrace: (make-thread (function call-error) "call-error") (setq th1 (make-thread (function call-error) "call-error")) (let (th1 th2) (setq th1 (make-thread (function call-error) "call-er (lambda nil (let (th1 th2) (setq th1 (make-thread (function call-err ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name thread-errors :documentation "Test wh ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test thread-errors condition: (void-function make-thread) FAILED 1/28 thread-errors Test thread-signal-early backtrace: (make-thread (function (lambda nil (while t (thread-yield))))) (let ((thread (make-thread (function (lambda nil (while t (thread-yi (lambda nil (let ((thread (make-thread (function (lambda nil (while ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name thread-signal-early :documentation "T ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test thread-signal-early condition: (void-function make-thread) FAILED 2/28 thread-signal-early passed 3/28 thread-sticky-point Test threads-alive backtrace: signal(void-function (make-thread)) apply(signal (void-function (make-thread))) (setq value-22 (apply fn-20 args-21)) (unwind-protect (setq value-22 (apply fn-20 args-21)) (setq form-des (if (unwind-protect (setq value-22 (apply fn-20 args-21)) (setq form (let (form-description-24) (if (unwind-protect (setq value-22 (apply (let ((value-22 'ert-form-evaluation-aborted-23)) (let (form-descrip (let* ((fn-20 (function thread-alive-p)) (args-21 (condition-case er (lambda nil (let* ((fn-20 (function thread-alive-p)) (args-21 (condi ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-alive :documentation "test fo ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-alive condition: (void-function make-thread) FAILED 4/28 threads-alive Test threads-all-threads backtrace: signal(void-function (all-threads)) apply(signal (void-function (all-threads))) (setq value-27 (apply fn-25 args-26)) (unwind-protect (setq value-27 (apply fn-25 args-26)) (setq form-des (if (unwind-protect (setq value-27 (apply fn-25 args-26)) (setq form (let (form-description-29) (if (unwind-protect (setq value-27 (apply (let ((value-27 'ert-form-evaluation-aborted-28)) (let (form-descrip (let* ((fn-25 (function listp)) (args-26 (condition-case err (let (( (lambda nil (let* ((fn-25 (function listp)) (args-26 (condition-case ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-all-threads :documentation "s ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-all-threads condition: (void-function all-threads) FAILED 5/28 threads-all-threads Test threads-basic backtrace: (make-thread (function threads-test-thread1)) (progn (setq threads-test-global nil) (make-thread (function threads (setq value-30 (progn (setq threads-test-global nil) (make-thread (f (unwind-protect (setq value-30 (progn (setq threads-test-global nil) (if (unwind-protect (setq value-30 (progn (setq threads-test-global (let (form-description-31) (if (unwind-protect (setq value-30 (progn (let ((value-30 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-30 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-basic :documentation "basic t ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-basic condition: (void-function make-thread) FAILED 6/28 threads-basic Test threads-condvar-mutex backtrace: (make-mutex) (let ((m (make-mutex))) (eq m (condition-mutex (make-condition-varia (setq value-83 (let ((m (make-mutex))) (eq m (condition-mutex (make- (unwind-protect (setq value-83 (let ((m (make-mutex))) (eq m (condit (if (unwind-protect (setq value-83 (let ((m (make-mutex))) (eq m (co (let (form-description-84) (if (unwind-protect (setq value-83 (let ( (let ((value-83 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-83 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-condvar-mutex :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-condvar-mutex condition: (void-function make-mutex) FAILED 7/28 threads-condvar-mutex Test threads-condvar-name backtrace: signal(void-function (condition-name)) apply(signal (void-function (condition-name))) (setq value-87 (apply fn-85 args-86)) (unwind-protect (setq value-87 (apply fn-85 args-86)) (setq form-des (if (unwind-protect (setq value-87 (apply fn-85 args-86)) (setq form (let (form-description-89) (if (unwind-protect (setq value-87 (apply (let ((value-87 'ert-form-evaluation-aborted-88)) (let (form-descrip (let* ((fn-85 (function eq)) (args-86 (condition-case err (let ((sig (lambda nil (let* ((fn-85 (function eq)) (args-86 (condition-case er ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-condvar-name :documentation " ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-condvar-name condition: (void-function condition-name) FAILED 8/28 threads-condvar-name Test threads-condvar-name-2 backtrace: signal(void-function (condition-name)) apply(signal (void-function (condition-name))) (setq value-92 (apply fn-90 args-91)) (unwind-protect (setq value-92 (apply fn-90 args-91)) (setq form-des (if (unwind-protect (setq value-92 (apply fn-90 args-91)) (setq form (let (form-description-94) (if (unwind-protect (setq value-92 (apply (let ((value-92 'ert-form-evaluation-aborted-93)) (let (form-descrip (let* ((fn-90 (function string=)) (args-91 (condition-case err (let (lambda nil (let* ((fn-90 (function string=)) (args-91 (condition-ca ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-condvar-name-2 :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-condvar-name-2 condition: (void-function condition-name) FAILED 9/28 threads-condvar-name-2 Test threads-condvar-type backtrace: signal(void-function (make-condition-variable)) apply(signal (void-function (make-condition-variable))) (setq value-80 (apply fn-78 args-79)) (unwind-protect (setq value-80 (apply fn-78 args-79)) (setq form-des (if (unwind-protect (setq value-80 (apply fn-78 args-79)) (setq form (let (form-description-82) (if (unwind-protect (setq value-80 (apply (let ((value-80 'ert-form-evaluation-aborted-81)) (let (form-descrip (let* ((fn-78 (function eq)) (args-79 (condition-case err (let ((sig (lambda nil (let* ((fn-78 (function eq)) (args-79 (condition-case er ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-condvar-type :documentation " ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-condvar-type condition: (void-function make-condition-variable) FAILED 10/28 threads-condvar-type Test threads-condvar-wait backtrace: (make-mutex) (let ((cv-mutex (make-mutex)) new-thread) (while (> (length (all-thr (lambda nil (let ((cv-mutex (make-mutex)) new-thread) (while (> (len ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-condvar-wait :documentation " ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-condvar-wait condition: (void-function make-mutex) FAILED 11/28 threads-condvar-wait passed 12/28 threads-condvarp Test threads-condvarp-2 backtrace: signal(void-function (make-condition-variable)) apply(signal (void-function (make-condition-variable))) (setq value-75 (apply fn-73 args-74)) (unwind-protect (setq value-75 (apply fn-73 args-74)) (setq form-des (if (unwind-protect (setq value-75 (apply fn-73 args-74)) (setq form (let (form-description-77) (if (unwind-protect (setq value-75 (apply (let ((value-75 'ert-form-evaluation-aborted-76)) (let (form-descrip (let* ((fn-73 (function condition-variable-p)) (args-74 (condition-c (lambda nil (let* ((fn-73 (function condition-variable-p)) (args-74 ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-condvarp-2 :documentation "an ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-condvarp-2 condition: (void-function make-condition-variable) FAILED 13/28 threads-condvarp-2 Test threads-io-switch backtrace: (make-thread (function threads-test-io-switch)) (progn (setq threads-test-global nil) (make-thread (function threads (setq value-66 (progn (setq threads-test-global nil) (make-thread (f (unwind-protect (setq value-66 (progn (setq threads-test-global nil) (if (unwind-protect (setq value-66 (progn (setq threads-test-global (let (form-description-67) (if (unwind-protect (setq value-66 (progn (let ((value-66 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-66 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-io-switch :documentation "tes ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-io-switch condition: (void-function make-thread) FAILED 14/28 threads-io-switch Test threads-is-one backtrace: current-thread() apply(current-thread nil) (setq value-2 (apply fn-0 args-1)) (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-descri (if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de (let (form-description-4) (if (unwind-protect (setq value-2 (apply f (let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti (let* ((fn-0 (function current-thread)) (args-1 (condition-case err (lambda nil (let* ((fn-0 (function current-thread)) (args-1 (conditi ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-is-one :documentation "test f ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-is-one condition: (void-function current-thread) FAILED 15/28 threads-is-one Test threads-join backtrace: (make-thread (function threads-test-thread1)) (let ((thread (make-thread (function threads-test-thread1)))) (threa (progn (setq threads-test-global nil) (let ((thread (make-thread (fu (setq value-32 (progn (setq threads-test-global nil) (let ((thread ( (unwind-protect (setq value-32 (progn (setq threads-test-global nil) (if (unwind-protect (setq value-32 (progn (setq threads-test-global (let (form-description-33) (if (unwind-protect (setq value-32 (progn (let ((value-32 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-32 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-join :documentation "test of ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-join condition: (void-function make-thread) FAILED 16/28 threads-join passed 17/28 threads-join-self Test threads-let-binding backtrace: (make-thread (function threads-test-thread2)) (progn (setq threads-test-global nil) (make-thread (function threads (setq value-41 (progn (setq threads-test-global nil) (make-thread (f (unwind-protect (setq value-41 (progn (setq threads-test-global nil) (if (unwind-protect (setq value-41 (progn (setq threads-test-global (let (form-description-42) (if (unwind-protect (setq value-41 (progn (let ((value-41 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-41 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-let-binding :documentation "s ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-let-binding condition: (void-function make-thread) FAILED 18/28 threads-let-binding Test threads-mutex-contention backtrace: (make-mutex) (setq threads-mutex (make-mutex)) (progn (setq threads-mutex (make-mutex)) (setq threads-mutex-key nil (setq value-62 (progn (setq threads-mutex (make-mutex)) (setq thread (unwind-protect (setq value-62 (progn (setq threads-mutex (make-mute (if (unwind-protect (setq value-62 (progn (setq threads-mutex (make- (let (form-description-63) (if (unwind-protect (setq value-62 (progn (let ((value-62 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-62 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-mutex-contention :documentati ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-mutex-contention condition: (void-function make-mutex) FAILED 19/28 threads-mutex-contention Test threads-mutex-lock-unlock backtrace: (make-mutex) (let ((mx (make-mutex))) (mutex-lock mx) (mutex-unlock mx) t) (setq value-58 (let ((mx (make-mutex))) (mutex-lock mx) (mutex-unloc (unwind-protect (setq value-58 (let ((mx (make-mutex))) (mutex-lock (if (unwind-protect (setq value-58 (let ((mx (make-mutex))) (mutex-l (let (form-description-59) (if (unwind-protect (setq value-58 (let ( (let ((value-58 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-58 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-mutex-lock-unlock :documentat ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-mutex-lock-unlock condition: (void-function make-mutex) FAILED 20/28 threads-mutex-lock-unlock Test threads-mutex-recursive backtrace: (make-mutex) (let ((mx (make-mutex))) (mutex-lock mx) (mutex-lock mx) (mutex-unlo (setq value-60 (let ((mx (make-mutex))) (mutex-lock mx) (mutex-lock (unwind-protect (setq value-60 (let ((mx (make-mutex))) (mutex-lock (if (unwind-protect (setq value-60 (let ((mx (make-mutex))) (mutex-l (let (form-description-61) (if (unwind-protect (setq value-60 (let ( (let ((value-60 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-60 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-mutex-recursive :documentatio ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-mutex-recursive condition: (void-function make-mutex) FAILED 21/28 threads-mutex-recursive Test threads-mutex-signal backtrace: (make-mutex) (setq threads-mutex (make-mutex)) (progn (setq threads-mutex (make-mutex)) (setq threads-mutex-key nil (setq value-64 (progn (setq threads-mutex (make-mutex)) (setq thread (unwind-protect (setq value-64 (progn (setq threads-mutex (make-mute (if (unwind-protect (setq value-64 (progn (setq threads-mutex (make- (let (form-description-65) (if (unwind-protect (setq value-64 (progn (let ((value-64 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-64 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-mutex-signal :documentation " ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-mutex-signal condition: (void-function make-mutex) FAILED 22/28 threads-mutex-signal Test threads-mutex-type backtrace: signal(void-function (make-mutex)) apply(signal (void-function (make-mutex))) (setq value-55 (apply fn-53 args-54)) (unwind-protect (setq value-55 (apply fn-53 args-54)) (setq form-des (if (unwind-protect (setq value-55 (apply fn-53 args-54)) (setq form (let (form-description-57) (if (unwind-protect (setq value-55 (apply (let ((value-55 'ert-form-evaluation-aborted-56)) (let (form-descrip (let* ((fn-53 (function eq)) (args-54 (condition-case err (let ((sig (lambda nil (let* ((fn-53 (function eq)) (args-54 (condition-case er ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-mutex-type :documentation "ty ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-mutex-type condition: (void-function make-mutex) FAILED 23/28 threads-mutex-type passed 24/28 threads-mutexp Test threads-mutexp-2 backtrace: signal(void-function (make-mutex)) apply(signal (void-function (make-mutex))) (setq value-50 (apply fn-48 args-49)) (unwind-protect (setq value-50 (apply fn-48 args-49)) (setq form-des (if (unwind-protect (setq value-50 (apply fn-48 args-49)) (setq form (let (form-description-52) (if (unwind-protect (setq value-50 (apply (let ((value-50 'ert-form-evaluation-aborted-51)) (let (form-descrip (let* ((fn-48 (function mutexp)) (args-49 (condition-case err (let ( (lambda nil (let* ((fn-48 (function mutexp)) (args-49 (condition-cas ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-mutexp-2 :documentation "anot ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-mutexp-2 condition: (void-function make-mutex) FAILED 25/28 threads-mutexp-2 Test threads-name backtrace: signal(void-function (thread-name)) apply(signal (void-function (thread-name))) (setq value-17 (apply fn-15 args-16)) (unwind-protect (setq value-17 (apply fn-15 args-16)) (setq form-des (if (unwind-protect (setq value-17 (apply fn-15 args-16)) (setq form (let (form-description-19) (if (unwind-protect (setq value-17 (apply (let ((value-17 'ert-form-evaluation-aborted-18)) (let (form-descrip (let* ((fn-15 (function string=)) (args-16 (condition-case err (let (lambda nil (let* ((fn-15 (function string=)) (args-16 (condition-ca ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-name :documentation "test for ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-name condition: (void-function thread-name) FAILED 26/28 threads-name Test threads-threadp backtrace: signal(void-function (current-thread)) apply(signal (void-function (current-thread))) (setq value-7 (apply fn-5 args-6)) (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-descri (if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de (let (form-description-9) (if (unwind-protect (setq value-7 (apply f (let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti (let* ((fn-5 (function threadp)) (args-6 (condition-case err (let (( (lambda nil (let* ((fn-5 (function threadp)) (args-6 (condition-case ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-threadp :documentation "test ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-threadp condition: (void-function current-thread) FAILED 27/28 threads-threadp Test threads-type backtrace: signal(void-function (current-thread)) apply(signal (void-function (current-thread))) (setq value-12 (apply fn-10 args-11)) (unwind-protect (setq value-12 (apply fn-10 args-11)) (setq form-des (if (unwind-protect (setq value-12 (apply fn-10 args-11)) (setq form (let (form-description-14) (if (unwind-protect (setq value-12 (apply (let ((value-12 'ert-form-evaluation-aborted-13)) (let (form-descrip (let* ((fn-10 (function eq)) (args-11 (condition-case err (let ((sig (lambda nil (let* ((fn-10 (function eq)) (args-11 (condition-case er ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name threads-type :documentation "test of ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e command-line() normal-top-level() Test threads-type condition: (void-function current-thread) FAILED 28/28 threads-type Ran 28 tests, 4 results as expected, 24 unexpected (2018-01-17 17:55:26+0100) 24 unexpected results: FAILED thread-errors FAILED thread-signal-early FAILED threads-alive FAILED threads-all-threads FAILED threads-basic FAILED threads-condvar-mutex FAILED threads-condvar-name FAILED threads-condvar-name-2 FAILED threads-condvar-type FAILED threads-condvar-wait FAILED threads-condvarp-2 FAILED threads-io-switch FAILED threads-is-one FAILED threads-join FAILED threads-let-binding FAILED threads-mutex-contention FAILED threads-mutex-lock-unlock FAILED threads-mutex-recursive FAILED threads-mutex-signal FAILED threads-mutex-type FAILED threads-mutexp-2 FAILED threads-name FAILED threads-threadp FAILED threads-type make[3]: *** [Makefile:166: src/thread-tests.log] Error 1 GEN src/undo-tests.log GEN src/xml-tests.log make[3]: Leaving directory '/sources/emacs/test' make[2]: [Makefile:268: check-doit] Error 2 (ignored) SUMMARY OF TEST RESULTS ----------------------- Files examined: 186 Ran 2658 tests, 1 failed to run, 2549 results as expected, 28 unexpected, 81 skipped 1 files did not contain any tests: src/emacs-module-tests.log 1 files did not finish: src/keyboard-tests.log 3 files contained unexpected results: src/thread-tests.log lisp/vc/vc-tests.log lisp/vc/vc-bzr-tests.log make[2]: *** [Makefile:269: check-doit] Error 2 make[2]: Leaving directory '/sources/emacs/test' make[1]: *** [Makefile:244: check] Error 2 make[1]: Leaving directory '/sources/emacs/test' make: *** [Makefile:945: check] Error 2 --=_protected.rcdrun.com-24656-1516208590-0001-2-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 13:26:10 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 18:26:10 +0000 Received: from localhost ([127.0.0.1]:60473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsPa-0001CO-El for submit@debbugs.gnu.org; Wed, 17 Jan 2018 13:26:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsPY-0001CA-Es for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 13:26:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebsPO-0003S0-Fl for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 13:26:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebsPO-0003Ri-BZ; Wed, 17 Jan 2018 13:25:58 -0500 Received: from [176.228.60.248] (port=2848 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ebsPN-0002vw-Ik; Wed, 17 Jan 2018 13:25:58 -0500 Date: Wed, 17 Jan 2018 20:25:51 +0200 Message-Id: <837esgwde8.fsf@gnu.org> From: Eli Zaretskii To: Jean Louis In-reply-to: <20180117170310.GA31570@protected.rcdrun.com> (message from Jean Louis on Wed, 17 Jan 2018 20:03:10 +0300) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Wed, 17 Jan 2018 20:03:10 +0300 > From: Jean Louis > Cc: 30106@debbugs.gnu.org > > > Apply the patch below, rebuild Emacs, rerun the test, and see if > > there's the telltale "current_thread is NULL" > > message in the log. > > I have done that, I did not see during "make > check" the line "current_thread is NULL", and I am > attaching the output from "make check". Then I'm not sure what's going on there. Is HAVE_PTHREAD defined in src/config.h? Does anyone else on this list see anything similar? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 13:33:31 2018 Received: (at submit) by debbugs.gnu.org; 17 Jan 2018 18:33:31 +0000 Received: from localhost ([127.0.0.1]:60479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsWh-0001NR-8g for submit@debbugs.gnu.org; Wed, 17 Jan 2018 13:33:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsWg-0001ND-6R for submit@debbugs.gnu.org; Wed, 17 Jan 2018 13:33:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebsWa-000498-Ay for submit@debbugs.gnu.org; Wed, 17 Jan 2018 13:33:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36999) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ebsWa-00048w-73 for submit@debbugs.gnu.org; Wed, 17 Jan 2018 13:33:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebsWZ-0001qN-79 for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 13:33:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebsWU-000426-Oa for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 13:33:23 -0500 Received: from [195.159.176.226] (port=35456 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebsWU-0003zS-Hw for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 13:33:18 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1ebsU7-0003tQ-EU for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 19:30:51 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Date: Wed, 17 Jan 2018 18:32:24 +0000 Lines: 41 Message-ID: References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (windows-nt) Cancel-Lock: sha1:Xsg9Y6xAU/d3+mLDUmm0GZXUYHw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) On Wed 17 Jan 2018, Jean Louis wrote: > On Wed, Jan 17, 2018 at 05:36:45PM +0200, Eli Zaretskii wrote: >> > Date: Tue, 16 Jan 2018 22:18:55 +0300 >> > From: Jean Louis >> > Cc: 30106@debbugs.gnu.org >> > >> > > in_current_thread (void) >> > > { >> > > if (current_thread == NULL) >> > > return false; >> > > #ifdef HAVE_PTHREAD >> > > return pthread_equal (pthread_self (), current_thread->thread_id); >> > > #elif defined WINDOWSNT >> > > return GetCurrentThreadId () == current_thread->thread_id; >> > > #endif >> > > } >> > > >> > > So either current_thread is NULL in your case, or pthread_equal >> > > returns false. Can you tell which one of these happens? >> > >> > I cannot test it myself on my own. You may tell me >> > what to do, to test it. >> >> Apply the patch below, rebuild Emacs, rerun the test, and see if >> there's the telltale "current_thread is NULL" >> message in the log. > > I have done that, I did not see during "make > check" the line "current_thread is NULL", and I am > attaching the output from "make check". Looking at the log you supplied: CCLD data/emacs-module/mod-test.so ELC src/emacs-module-tests.elc Emacs module assertion: Module function called from outside the current Lisp thread That would seem to be the cause of your problem. AndyM From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 13:51:47 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 18:51:47 +0000 Received: from localhost ([127.0.0.1]:60486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsoM-0001m7-Rf for submit@debbugs.gnu.org; Wed, 17 Jan 2018 13:51:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsoL-0001lu-Qc for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 13:51:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebsoF-00030W-Tr for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 13:51:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebsnj-0002We-4R; Wed, 17 Jan 2018 13:51:07 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ebsnh-00075l-Ax; Wed, 17 Jan 2018 13:51:05 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> X-Spook: S Box Guantanamo Conventional weapon enforcers Baranyi X-Ran: }RDs6rDEa|,?iY?#C$6AnRug.b*g=K!_8,234)>UlC0 X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 17 Jan 2018 13:51:05 -0500 In-Reply-To: <837esgwde8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Jan 2018 20:25:51 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org, Jean Louis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: > Does anyone else on this list see anything similar? Same error on rhel 7.4 if configure with --without-threads --with-modules. Emacs module assertion: Module function called from outside the current Lisp thread From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 13:58:25 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 18:58:25 +0000 Received: from localhost ([127.0.0.1]:60490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsun-0001v8-Ig for submit@debbugs.gnu.org; Wed, 17 Jan 2018 13:58:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebsum-0001uw-0M for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 13:58:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebsug-0008Ak-06 for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 13:58:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebsuf-0008Ac-SZ; Wed, 17 Jan 2018 13:58:17 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ebsuf-0001iO-5s; Wed, 17 Jan 2018 13:58:17 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> X-Spook: domestic disruption bomb Cyber terror encryption Social X-Ran: \b#'TPVU1$SgWz:QW}d.X~~V{dc9!G%j"ILZ#\B*Iw$ipCYh%BzY"@96TtZ6B.<#Q6_&DU X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 17 Jan 2018 13:58:17 -0500 In-Reply-To: (Glenn Morris's message of "Wed, 17 Jan 2018 13:51:05 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org, Jean Louis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Glenn Morris wrote: > Same error on rhel 7.4 if configure with --without-threads --with-modules. > > Emacs module assertion: Module function called from outside the current > Lisp thread PS --without-all implies --without-threads, ref. https://debbugs.gnu.org/30106#37 Note that the OP has switched to using --without-all from the initial report, and is now having a different problem. Compare https://debbugs.gnu.org/30106#11 https://debbugs.gnu.org/30106#37 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 14:21:31 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 19:21:32 +0000 Received: from localhost ([127.0.0.1]:60511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebtH9-0002T6-Lu for submit@debbugs.gnu.org; Wed, 17 Jan 2018 14:21:31 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:59705 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebtH7-0002St-6S for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 14:21:30 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Wed, 17 Jan 2018 12:21:48 -0700 id 000000000011D716.000000005A5FA24D.00006D4C Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Wed, 17 Jan 2018 20:20:39 +0100 id 00000000001C038A.000000005A5FA207.00006F8E Date: Wed, 17 Jan 2018 22:20:39 +0300 From: Jean Louis To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180117192039.GA28510@protected.rcdrun.com> References: <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <837esgwde8.fsf@gnu.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Wed, Jan 17, 2018 at 08:25:51PM +0200, Eli Zaretskii wrote: > > Date: Wed, 17 Jan 2018 20:03:10 +0300 > > From: Jean Louis > > Cc: 30106@debbugs.gnu.org > > > > > Apply the patch below, rebuild Emacs, rerun the test, and see if > > > there's the telltale "current_thread is NULL" > > > message in the log. > > > > I have done that, I did not see during "make > > check" the line "current_thread is NULL", and I am > > attaching the output from "make check". > > Then I'm not sure what's going on there. Is HAVE_PTHREAD defined in > src/config.h? > > Does anyone else on this list see anything similar? src/config.h: admin-> grep HAVE_PTHREAD src/config.h #define HAVE_PTHREAD 1 #define HAVE_PTHREAD_H 1 #define HAVE_PTHREAD_SIGMASK 1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 14:37:58 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 19:37:58 +0000 Received: from localhost ([127.0.0.1]:60526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebtX4-0002qy-2V for submit@debbugs.gnu.org; Wed, 17 Jan 2018 14:37:58 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:50147 helo=static.rcdrun.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebtX2-0002ql-7Y for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 14:37:56 -0500 Received: from protected.rcdrun.com (localhost [::1]) (AUTH: PLAIN admin, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by stw1.rcdrun.com with ESMTPSA; Wed, 17 Jan 2018 12:38:21 -0700 id 000000000011D714.000000005A5FA62E.00006DA6 Received: from localhost (localhost [127.0.0.1]) (uid 1001) by protected.rcdrun.com with local; Wed, 17 Jan 2018 20:37:35 +0100 id 00000000001C03A5.000000005A5FA5FF.00006ECE Date: Wed, 17 Jan 2018 22:37:35 +0300 From: Jean Louis To: Glenn Morris Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Message-ID: <20180117193734.GB28510@protected.rcdrun.com> References: <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Wed, Jan 17, 2018 at 01:58:17PM -0500, Glenn Morris wrote: > Glenn Morris wrote: > > > Same error on rhel 7.4 if configure with --without-threads --with-modules. > > > > Emacs module assertion: Module function called from outside the current > > Lisp thread > > PS --without-all implies --without-threads, ref. > > https://debbugs.gnu.org/30106#37 > > Note that the OP has switched to using --without-all from the initial > report, and is now having a different problem. Compare > > https://debbugs.gnu.org/30106#11 > https://debbugs.gnu.org/30106#37 In beginning I did not use without-all, then I changed, overlooked it. However, now at this point, but maybe after patching, I could compile it so that it works. I can load the dynamic module with (require 'pq) Earlier, even though I did not use --without-all, but I did use --with-modules I could not compile it to work. Jean From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 15:06:10 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 20:06:10 +0000 Received: from localhost ([127.0.0.1]:60604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebtyM-0003kG-35 for submit@debbugs.gnu.org; Wed, 17 Jan 2018 15:06:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebtyK-0003k3-OC for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 15:06:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebtyA-0006T0-KF for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 15:06:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebtyA-0006St-HL; Wed, 17 Jan 2018 15:05:58 -0500 Received: from [176.228.60.248] (port=2957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ebty8-0006lm-PO; Wed, 17 Jan 2018 15:05:58 -0500 Date: Wed, 17 Jan 2018 22:05:44 +0200 Message-Id: <836080w8rr.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Wed, 17 Jan 2018 13:51:05 -0500) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org, bugs@gnu.support X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: Jean Louis , 30106@debbugs.gnu.org > Date: Wed, 17 Jan 2018 13:51:05 -0500 > > Eli Zaretskii wrote: > > > Does anyone else on this list see anything similar? > > Same error on rhel 7.4 if configure with --without-threads --with-modules. > > Emacs module assertion: Module function called from outside the current > Lisp thread Does this go away if you put return true; at the end of in_current_thread, outside of all the #ifdef's? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 15:30:06 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 20:30:06 +0000 Received: from localhost ([127.0.0.1]:60614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebuLU-0004IR-Dg for submit@debbugs.gnu.org; Wed, 17 Jan 2018 15:30:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebuLS-0004HU-1x for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 15:30:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebuLM-0002Gv-0G for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 15:29:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebuKm-0001eM-56; Wed, 17 Jan 2018 15:29:20 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ebuKl-0002Tx-Mi; Wed, 17 Jan 2018 15:29:19 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> <836080w8rr.fsf@gnu.org> X-Spook: Ermes ASPIC Basque Separatists USCG ATF counter X-Ran: ;N-LG&i"hU/2k#9FWzbDSHFZJY-p\4Je$t|C\1%8hAWT:'2XyMD8!o^~TzI@J*WCB!zY}f X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 17 Jan 2018 15:29:19 -0500 In-Reply-To: <836080w8rr.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Jan 2018 22:05:44 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: 30106@debbugs.gnu.org, bugs@gnu.support X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: >> Same error on rhel 7.4 if configure with --without-threads --with-modules. >> >> Emacs module assertion: Module function called from outside the current >> Lisp thread > > Does this go away if you put > > return true; > > at the end of in_current_thread, outside of all the #ifdef's? No. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 17:17:17 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 22:17:17 +0000 Received: from localhost ([127.0.0.1]:60640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebw1E-00009a-Tu for submit@debbugs.gnu.org; Wed, 17 Jan 2018 17:17:17 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:39957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebw1D-00009I-1s for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 17:17:15 -0500 Received: by mail-lf0-f48.google.com with SMTP id h92so13645080lfi.7 for <30106@debbugs.gnu.org>; Wed, 17 Jan 2018 14:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EVMQ4F4d+neGBupw/k2pnf8xQYTMeO2K0vzpqNjCjCU=; b=tYovFIb49xlG8ncYNDukvOFugzmRvF3Fyyml4WvDoAAoHud9Ny7t5ExksgI8q/t7uC 0MMJxr9jcMfNAPve4sOH1VipMQDpVRRT0Kd/OZFOoS7YL3EeGscUQGXzcvKlazOVeIjF xGb8crYcjyMyGStPdQNjBl5Mooc5t01AKJzst1LeIB4QTyifcilgp72APjBjw6fthOZk B4ZFLcxpJ0SDRknKP5d9xzvO23b24SkyRaCrhG1ogmUDuD8mSyoF5z60nRcWGrswMZ7A Dtsfwp6RyDQDTSmM2e9TjSBWCBeEA868k3n9uf+mSXnqFxxg3Go9UsTndnOrRqOOce8E Xxkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EVMQ4F4d+neGBupw/k2pnf8xQYTMeO2K0vzpqNjCjCU=; b=Yv0b5bwHoLHeW6KLAmzfOIJl1WtT7iSfQwIq4O8KrucOFOWB9//5Qr5+Exvmf/65pd VwQVqljGTaOXiYq33yH8x1O/Iy9bewf8I8NbQCfLfoVNsCjue8rH4/6AQZDSWaWnsbBf Wee1Ptrgl1cUlq9HT441mg05p2I1uA/MVebv4xl0G0mMZOo5dKjfMH6MsUhlxMuvoRPy ejqlCfgjAV0nJEbfcLeiUgjhT2eHgCeZspA9LYvauMWcIXQ0thVSgm82G3f799DMTyb1 1tskHu2tyF3WnZfuZK9kSV3wfZ4Trm78qnG53xxonSJWm+v+KXqK1GJBIuJrZMDCW0zU SoGA== X-Gm-Message-State: AKwxytd57UK26fhJ0E1ONa4mnozPgvyszGmXeMIZY3mRL3oEIg+9i//X i4nEwYDp7zj1xF/GQRm85MwFkBuz3Ba20L5xI4s= X-Google-Smtp-Source: ACJfBovEYQkiuFqXcmictLEszXWVHP60T5pbxPhP2U9RIu9wInJXMkQwZYmuGqqzZrIdp/+tk1uqrKl0doohZZsJTf8= X-Received: by 10.46.15.2 with SMTP id 2mr1526619ljp.144.1516227428980; Wed, 17 Jan 2018 14:17:08 -0800 (PST) MIME-Version: 1.0 References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> <836080w8rr.fsf@gnu.org> In-Reply-To: From: Philipp Stephani Date: Wed, 17 Jan 2018 22:16:58 +0000 Message-ID: Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' To: Glenn Morris Content-Type: multipart/alternative; boundary="f403043604144d9f0d0563003505" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org, bugs@gnu.support X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --f403043604144d9f0d0563003505 Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Mi., 17. Jan. 2018 um 21:31 Uhr: > Eli Zaretskii wrote: > > >> Same error on rhel 7.4 if configure with --without-threads > --with-modules. > >> > >> Emacs module assertion: Module function called from outside the > current > >> Lisp thread > > > > Does this go away if you put > > > > return true; > > > > at the end of in_current_thread, outside of all the #ifdef's? > > No. > > > > > The current implementation of in_current_thread is definitely bogus if threads are disabled; I can't even compile temacs with --without-threads --with-modules: *emacs-module.c:814:42: **error: **incompatible integer to pointer conversion passing 'sys_thread_t' (aka 'int') to parameter of type 'pthread_t _Nullable'* * (aka 'struct _opaque_pthread_t *') [-Werror,-Wint-conversion]* return pthread_equal (pthread_self (), current_thread->thread_id); * ^~~~~~~~~~~~~~~~~~~~~~~~~* */usr/include/pthread.h:340:59: note: *passing argument to parameter here int pthread_equal(pthread_t _Nullable, pthread_t _Nullable); because if threads are disabled, the thread ID is an int. The function also doesn't handle the case where neither HAVE_PTHREAD nor WINDOWSNT are defined (but maybe we don't have such platforms). Maybe systhread.h should have a function extern sys_thread_t sys_thread_self (); so emacs-module.c doesn't have to care about the threading implementations. --f403043604144d9f0d0563003505 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Mi= ., 17. Jan. 2018 um 21:31=C2=A0Uhr:
Eli Zaretskii wrote:

>> Same error on rhel 7.4 if configure with --without-threads --with-= modules.
>>
>>=C2=A0 =C2=A0Emacs module assertion: Module function called from ou= tside the current
>>=C2=A0 =C2=A0Lisp thread
>
> Does this go away if you put
>
>=C2=A0 =C2=A0return true;
>
> at the end of in_current_thread, outside of all the #ifdef's?

No.





The current implementation of in_curre= nt_thread is definitely bogus if threads are disabled; I can't even com= pile temacs with --without-threads --with-modules:

emacs-module.= c:814:42: error: incompatible integer to pointer conversion = passing 'sys_thread_t' (aka 'int') to parameter of type = 9;pthread_t _Nullable'

=C2=A0 =C2=A0 =C2=A0 (aka = 9;struct _opaque_pthread_t *') [-Werror,-Wint-conversion]

=C2=A0 return pthread_equal (pthre= ad_self (), current_thread->thread_id);

=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~~~~~~~~~~~~~~~~~~=

/usr/include/= pthread.h:340:59: note: passing argument to parameter here

int pthread_equa= l(pthread_t _Nullable, pthread_t _Nullable);


because if threads are disabled, the = thread ID is an int.

The function also doesn't handle the case where neither = HAVE_PTHREAD nor WINDOWSNT are defined (but maybe we don't have such pl= atforms).

Maybe systhread.h should ha= ve a function

extern sys_thread_t sys_thread= _self ();

so emacs-module.c doesn't have= to care about the threading implementations.

--f403043604144d9f0d0563003505-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 17:19:12 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 22:19:12 +0000 Received: from localhost ([127.0.0.1]:60644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebw36-0000CQ-DF for submit@debbugs.gnu.org; Wed, 17 Jan 2018 17:19:12 -0500 Received: from mail-lf0-f41.google.com ([209.85.215.41]:37064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebw35-0000CC-2y for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 17:19:11 -0500 Received: by mail-lf0-f41.google.com with SMTP id f3so24000618lfe.4 for <30106@debbugs.gnu.org>; Wed, 17 Jan 2018 14:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5h+PTvVXuQ9SxnbAOnb1EwDkx8H8omzGFwRy/pt3myQ=; b=mOAB/ta7frU0MsXrezsIrAGku3jhz3WYGjRwSHmPAJIpiNEe1ZCbKu2BnHrOnbmCbM w4zfCdobP8E/zYzG5rlNFcOaLqdza4um0kEJ7Z2BTo/58MsrUW2nOkT7Qz+EC11G8tKD SmlmlF+9YE9xBbhC+ELgOMAos7P4fAynXvTHvQIsWibuvpm0+Sjad1ulWXrPB92kSIlK TMV8ONlf+BkuOk8qcpqOHv5NFSFbjpuxxVzI1CgFQMWOjsMRkWBmJF+CtCZ4zBPQzmXg w5rFiSwnYM9wfHquz++e9L3y55fdNhpotu91DcbUyTxOgOPwvili9SDfOr+DmzZDyGpi 9sMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5h+PTvVXuQ9SxnbAOnb1EwDkx8H8omzGFwRy/pt3myQ=; b=Kaf+gSEglw6egDb0gM6xEreRAY+8c1dZwSe1nLOL1qp60ZUmbZye7XDaiBAJfm7GA1 PG12d9baHN/3QtDbhqJ0dUw7np+k17vLtG9CpzoAGYQ4XA9lztFH0u0+Inaixao1HXIE 5FwZb9cfYq9s4z8C85wHExqUb+4UEAI2YKkVAq/A6pwvD7GkvJIm3IXYxIqQCwuncVeu yYGzF83WA0M3uCZ1gmfbyAAPr+n9yZ07vgKc4u2Px3xFn2jvcqCdL0ivq9vbKtsTy42J CgBvyzVNfdXkDSBBJnlo46RAbX2ro9ntG+1dXIGEERKFARbAf1P2mA2n3TjkG8qpgyvB UNGw== X-Gm-Message-State: AKwxytfwldQ52itPT4O63+6k9dAYj1qfmqVK79zQO1NW0rVDQ2B4+r9N Zexab7WHzmj1Mvo9idH9Y4Wx0//SPRp4yqRArSI= X-Google-Smtp-Source: ACJfBovYPHWr4cpAuNofIxEEoIH04npooJlAsilQ2t0zi0l5EVF2+oJ+5DY9v/MgNzU7rbkvHqmlY7+tCnkeon8rHFU= X-Received: by 10.46.43.71 with SMTP id q68mr7952009lje.92.1516227545415; Wed, 17 Jan 2018 14:19:05 -0800 (PST) MIME-Version: 1.0 References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> <836080w8rr.fsf@gnu.org> In-Reply-To: From: Philipp Stephani Date: Wed, 17 Jan 2018 22:18:54 +0000 Message-ID: Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' To: Glenn Morris Content-Type: multipart/alternative; boundary="94eb2c1ac1523e45820563003c24" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org, bugs@gnu.support X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c1ac1523e45820563003c24 Content-Type: text/plain; charset="UTF-8" Philipp Stephani schrieb am Mi., 17. Jan. 2018 um 23:16 Uhr: > Maybe systhread.h should have a function > > extern sys_thread_t sys_thread_self (); > > > Uh, it already has that :) --94eb2c1ac1523e45820563003c24 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Mi., 17. Jan. 2018 um 23:16=C2=A0Uhr:
Maybe systhread.h should have a function

extern sys_thread_t sys_thread_self ();


Uh= , it already has that :)=C2=A0
--94eb2c1ac1523e45820563003c24-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 17:29:03 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 22:29:03 +0000 Received: from localhost ([127.0.0.1]:60650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebwCd-0000QN-BB for submit@debbugs.gnu.org; Wed, 17 Jan 2018 17:29:03 -0500 Received: from mail-wr0-f179.google.com ([209.85.128.179]:39005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebwCb-0000Pr-NE for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 17:29:02 -0500 Received: by mail-wr0-f179.google.com with SMTP id z48so20588225wrz.6 for <30106@debbugs.gnu.org>; Wed, 17 Jan 2018 14:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TLar6gWv3GLhCBiJpcFIs/ZaeTdiXoZ4PQivVduO3Fw=; b=QNsgv8hNAhnrhYPacM+1Sk3cNuN1Grh/eV+Jl/qdWbdriczkwPOVow/GvxKKI7EuFm ukcJk2lHgdURvC4cBWShmjQV/yUuhEbNL9z9VOr8nJAaCsvHOiptQlcQSbmFkKMZDl1u hiJA4zuVfMt6mqf8O8VHHfHdNofijnKashBMSFu5z69sAHa1OE/dkTHG/CrfmgPQ6oqt WsFr3fAsaPoCcOCTkvWlEcldD4mZ+lL6cTdvifJIHzaHEeP0F2mMGHieKRUq1GWznioT P1PbEe89HfgZA5yQD/HbgWCcAa5IHi63pCE2BfC+y23tkQQhq832pqryZjDanYdCZmjx Y/gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TLar6gWv3GLhCBiJpcFIs/ZaeTdiXoZ4PQivVduO3Fw=; b=q1lpM1X+mbus30f+jVqUVkvSbLbTD9LuacZkA58yNjuArueq50r++7q0GIlvBvbCcX U+ZtE+FsehguOmDdE9XKljWqPJhqVufiS3KD70oz5TorNP7lDHtY9EAMfAE9vUu2eDKZ 4f8jczBTva7ts0x05deCD5G3rsxw8e1QXXAH1645f93LPBPVbZ62uJ+IKfpZs/KsMDEr K8W64T66MWpaKVoiRWiKDdKPUQr3hV2zZoVXJsAYM2pebDkICeccRKwGQOyu6apWGXyu oQkW65q5ABmBqiYdSZ5aeeFSxqI8xNVL4q+OL0MaAYqjY3KjYxJPtaaOABsO97ggyJGs gOMQ== X-Gm-Message-State: AKwxytfGjNDDbh2ZDacip74iTJKs7HXsl6gCXFl/PzC/MWTgdPy6ad5F CoguzZN6Nu2A9dGHtxf2vXY= X-Google-Smtp-Source: ACJfBotjQdKV2oeRTsSn7NE0ek6ZuJyPb9LTltt8TVEgb08bd5riSCxjPW4Kkl2n4ir+Xx7NbIN8CQ== X-Received: by 10.223.184.58 with SMTP id h55mr3976377wrf.110.1516228135862; Wed, 17 Jan 2018 14:28:55 -0800 (PST) Received: from p.cm.cablesurf.de (46.128.198.151.dynamic.cablesurf.de. [46.128.198.151]) by smtp.gmail.com with ESMTPSA id z71sm16696138wrc.11.2018.01.17.14.28.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Jan 2018 14:28:55 -0800 (PST) From: Philipp Stephani X-Google-Original-From: Philipp Stephani To: Glenn Morris , Eli Zaretskii , 30106@debbugs.gnu.org Subject: [PATCH 1/2] Use recommended long options syntax in man page Date: Wed, 17 Jan 2018 23:28:45 +0100 Message-Id: <20180117222846.93077-1-phst@google.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: References: X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 30106 Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) * doc/man/emacs.1.in: Specify equals sign for long options, as recommended in the manual. --- doc/man/emacs.1.in | 50 +++++++++++++++++++++++++------------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/doc/man/emacs.1.in b/doc/man/emacs.1.in index 7654c9610d..5116953041 100644 --- a/doc/man/emacs.1.in +++ b/doc/man/emacs.1.in @@ -61,7 +61,7 @@ The following options are of general interest: Edit .IR file . .TP -.BI \-\-file " file\fR,\fP " \-\-find-file " file\fR,\fP " \-\-visit " file" +.BI \-\-file= "file\fR,\fP " \-\-find-file= "file\fR,\fP " \-\-visit= "file" The same as specifying .I file directly as an argument. @@ -79,7 +79,7 @@ Go to the specified and .IR column . .TP -.BI \-\-chdir " directory" +.BI \-\-chdir= "directory" Change to .IR directory . .TP @@ -112,12 +112,12 @@ Lisp debugger during the processing of the user init file .BR ~/.emacs . This is useful for debugging problems in the init file. .TP -.BI \-u " user\fR,\fP " \-\-user " user" +.BI \-u " user\fR,\fP " \-\-user= "user" Load .IR user 's init file. .TP -.BI \-t " file\fR,\fP " \-\-terminal " file" +.BI \-t " file\fR,\fP " \-\-terminal= "file" Use specified .I file as the terminal instead of using stdin/stdout. @@ -144,15 +144,15 @@ The following options are Lisp-oriented (these options are processed in the order encountered): .RS .TP 8 -.BI \-f " function\fR,\fP " \-\-funcall " function" +.BI \-f " function\fR,\fP " \-\-funcall= "function" Execute the lisp function .IR function . .TP -.BI \-l " file\fR,\fP " \-\-load " file" +.BI \-l " file\fR,\fP " \-\-load= "file" Load the lisp code in the file .IR file . .TP -.BI \-\-eval " expr\fR,\fP " \-\-execute " expr" +.BI \-\-eval= "expr\fR,\fP " \-\-execute= "expr" Evaluate the Lisp expression .IR expr . .RE @@ -168,12 +168,12 @@ The editor will send messages to stderr. You must use \-l and \-f options to specify files to execute and functions to call. .TP -.BI \-\-script " file" +.BI \-\-script= "file" Run .I file as an Emacs Lisp script. .TP -.BI \-\-insert " file" +.BI \-\-insert= "file" Insert contents of .I file into the current buffer. @@ -183,7 +183,7 @@ Exit .I Emacs while in batch mode. .TP -.BI \-L " dir\fR,\fP " \-\-directory " dir" +.BI \-L " dir\fR,\fP " \-\-directory= "dir" Add .I dir to the list of directories @@ -206,13 +206,13 @@ process so that you can continue using your original window. can be started with the following X switches: .RS .TP 8 -.BI \-\-name " name" +.BI \-\-name= "name" Specify the name which should be assigned to the initial .I Emacs window. This controls looking up X resources as well as the window title. .TP -.BI \-T " name\fR,\fP " \-\-title " name" +.BI \-T " name\fR,\fP " \-\-title= "name" Specify the title for the initial X window. .TP .BR \-r ", " \-rv ", " \-\-reverse\-video @@ -220,7 +220,7 @@ Display the .I Emacs window in reverse video. .TP -.BI \-fn " font\fR,\fP " \-\-font " font" +.BI \-fn " font\fR,\fP " \-\-font= "font" Set the .I Emacs window's font to that specified by @@ -247,7 +247,7 @@ for more information. When you specify a font, be sure to put a space between the switch and the font name. .TP -.BI \-\-xrm " resources" +.BI \-\-xrm= "resources" Set additional X resources. .TP .BI "\-\-color\fR,\fP \-\-color=" mode @@ -256,20 +256,20 @@ Override color mode for character terminals; defaults to "auto", and can also be "never", "auto", "always", or a mode name like "ansi8". .TP -.BI \-bw " pixels\fR,\fP " \-\-border\-width " pixels" +.BI \-bw " pixels\fR,\fP " \-\-border\-width= "pixels" Set the .I Emacs window's border width to the number of pixels specified by .IR pixels . Defaults to one pixel on each side of the window. .TP -.BI \-ib " pixels\fR,\fP " \-\-internal\-border " pixels" +.BI \-ib " pixels\fR,\fP " \-\-internal\-border= "pixels" Set the window's internal border width to the number of pixels specified by .IR pixels . Defaults to one pixel of padding on each side of the window. .TP -.BI \-g " geometry\fR,\fP " \-\-geometry " geometry" +.BI \-g " geometry\fR,\fP " \-\-geometry= "geometry" Set the .I Emacs window's width, height, and position as specified. @@ -282,7 +282,7 @@ See the Emacs manual, section "Options for Window Size and Position", for information on how window sizes interact with selecting or deselecting the tool bar and menu bar. .TP -.BI \-lsp " pixels\fR,\fP " \-\-line\-spacing " pixels" +.BI \-lsp " pixels\fR,\fP " \-\-line\-spacing= "pixels" Additional space to put between lines. .TP .BR \-vb ", " \-\-vertical\-scroll\-bars @@ -300,26 +300,26 @@ Make the first frame as wide as the screen. .BR \-mm ", " \-\-maximized Maximize the first frame, like "\-fw \-fh". .TP -.BI \-fg " color\fR,\fP " \-\-foreground\-color " color" +.BI \-fg " color\fR,\fP " \-\-foreground\-color= "color" On color displays, set the color of the text. Use the command .I M\-x list\-colors\-display for a list of valid color names. .TP -.BI \-bg " color\fR,\fP " \-\-background\-color " color" +.BI \-bg " color\fR,\fP " \-\-background\-color= "color" On color displays, set the color of the window's background. .TP -.BI \-bd " color\fR,\fP " \-\-border\-color " color" +.BI \-bd " color\fR,\fP " \-\-border\-color= "color" On color displays, set the color of the window's border. .TP -.BI \-cr " color\fR,\fP " \-\-cursor\-color " color" +.BI \-cr " color\fR,\fP " \-\-cursor\-color= "color" On color displays, set the color of the window's text cursor. .TP -.BI \-ms " color\fR,\fP " \-\-mouse\-color " color" +.BI \-ms " color\fR,\fP " \-\-mouse\-color= "color" On color displays, set the color of the window's mouse cursor. .TP -.BI \-d " displayname\fR,\fP " \-\-display " displayname" +.BI \-d " displayname\fR,\fP " \-\-display= "displayname" Create the .I Emacs window on the display specified by @@ -337,7 +337,7 @@ in iconified state. .BR \-nbc ", " \-\-no\-blinking\-cursor Disable blinking cursor. .TP -.BI \-\-parent-id " xid" +.BI \-\-parent-id= "xid" Set parent window. .TP .BR \-nw ", " \-\-no\-window\-system -- 2.15.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 17:29:20 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 22:29:20 +0000 Received: from localhost ([127.0.0.1]:60654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebwCt-0000Qr-OW for submit@debbugs.gnu.org; Wed, 17 Jan 2018 17:29:19 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebwCr-0000Qe-Sx for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 17:29:18 -0500 Received: by mail-wr0-f193.google.com with SMTP id x1so16409737wrb.5 for <30106@debbugs.gnu.org>; Wed, 17 Jan 2018 14:29:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yWwskjJ5GvpylHrDfwbHTXWw34HuuKccqu3eiaxQCck=; b=BcUm83l774segCZHtCAT0+3NeLFC1oaD3rYs/+7/duvU2DdMxLZaWR3vi6J/B+zw18 H7tlfZxqt9KDwNU29H6pXxExztfnh//1FtDf9IzhjDi5N4Ki1NKqNURQ2zVmzn24kr7W 6Acd0hrcmy43iOE26s7PTV1coKdaD97qOrAgf5a7lD614FQ3JclhuxP1G0ekMVLDeyH9 OYiv2SsJCNODPDzv/zE9bQC85wWUOJLnfPp0YPLrsVIjPRixcPD0M4zuQmtf5jdqvqbo DMI1sHdD7AJRREMqzZxIkk0ejvRKK0jZ4XhV4ze2QmwfjdVYPaRuSC0/KqOk/jOhwFbN rSjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yWwskjJ5GvpylHrDfwbHTXWw34HuuKccqu3eiaxQCck=; b=g+f73U7YOwQzVxpda5cGUTGP36Ec4ar/cmLbHLesfREOXZ0Ej1r0J++W0f6sLqh4Qh ICtXkCuuBC8Ci0Eywax4GBg34w9zxOEcDx4XrFNZQoQi6CualHhWk0gtGn7FmFuPkTGX tLdD46YPiabb+TuWyfwDmKbRxCSUa1MlPSCVT/MmGAq+4nFsjq3r8HWuPTrQeu/M+Kay 37UrEvD3z3Men9KH/YLFSOXSep0l9EcM/+ISt9l7aWHg/GwYW2j2rcAQJ0o03IUUmg7i 1ST3Z7oTCYDRJggOb3zNADxA682CqmjeWLuInQSNWZl9DieBjpq11t/HuQlYX0iU3FjI nCiw== X-Gm-Message-State: AKwxytdhcRjv65iLyue/UFXRncDmZbupFFnxf7SAanbsMEsPAjZeC0Hw m7Og/qvhp8cAwKavsxevN5hx9hDJ X-Google-Smtp-Source: ACJfBota37fR0HgFgEJ8E/nagnkl+TlijWmnmyzitRc1zZ350reicoMWw3vN3VybYGsBG7Eoe2JoDg== X-Received: by 10.223.190.4 with SMTP id n4mr4480954wrh.28.1516228152212; Wed, 17 Jan 2018 14:29:12 -0800 (PST) Received: from p.cm.cablesurf.de (46.128.198.151.dynamic.cablesurf.de. [46.128.198.151]) by smtp.gmail.com with ESMTPSA id z71sm16696138wrc.11.2018.01.17.14.29.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Jan 2018 14:29:11 -0800 (PST) From: Philipp Stephani X-Google-Original-From: Philipp Stephani To: Glenn Morris , Eli Zaretskii , 30106@debbugs.gnu.org Subject: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Date: Wed, 17 Jan 2018 23:28:46 +0100 Message-Id: <20180117222846.93077-2-phst@google.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180117222846.93077-1-phst@google.com> References: <20180117222846.93077-1-phst@google.com> X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 30106 Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) * src/systhread.c (sys_thread_equal): New function. * src/emacs-module.c (in_current_thread): Use it. --- src/emacs-module.c | 7 ++----- src/systhread.c | 18 ++++++++++++++++++ src/systhread.h | 1 + 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/src/emacs-module.c b/src/emacs-module.c index 00f0e86d7d..298080e646 100644 --- a/src/emacs-module.c +++ b/src/emacs-module.c @@ -31,6 +31,7 @@ along with GNU Emacs. If not, see . */ #include "coding.h" #include "keyboard.h" #include "syssignal.h" +#include "systhread.h" #include "thread.h" #include @@ -805,11 +806,7 @@ in_current_thread (void) { if (current_thread == NULL) return false; -#ifdef HAVE_PTHREAD - return pthread_equal (pthread_self (), current_thread->thread_id); -#elif defined WINDOWSNT - return GetCurrentThreadId () == current_thread->thread_id; -#endif + return sys_thread_equal (sys_thread_self (), current_thread->thread_id); } static void diff --git a/src/systhread.c b/src/systhread.c index 4ffb7db143..3f162a2bcb 100644 --- a/src/systhread.c +++ b/src/systhread.c @@ -74,6 +74,12 @@ sys_thread_self (void) return 0; } +bool +sys_thread_equal (sys_thread_t t, sys_thread_t u) +{ + return t == u; +} + int sys_thread_create (sys_thread_t *t, const char *name, thread_creation_function *func, void *datum) @@ -155,6 +161,12 @@ sys_thread_self (void) return pthread_self (); } +bool +sys_thread_equal (sys_thread_t t, sys_thread_t u) +{ + return pthread_equal (t, u); +} + int sys_thread_create (sys_thread_t *thread_ptr, const char *name, thread_creation_function *func, void *arg) @@ -323,6 +335,12 @@ sys_thread_self (void) return (sys_thread_t) GetCurrentThreadId (); } +bool +sys_thread_equal (sys_thread_t t, sys_thread_t u) +{ + return t == u; +} + static thread_creation_function *thread_start_address; /* _beginthread wants a void function, while we are passed a function diff --git a/src/systhread.h b/src/systhread.h index 4745d22065..5dbb12dffb 100644 --- a/src/systhread.h +++ b/src/systhread.h @@ -100,6 +100,7 @@ extern void sys_cond_broadcast (sys_cond_t *); extern void sys_cond_destroy (sys_cond_t *); extern sys_thread_t sys_thread_self (void); +extern bool sys_thread_equal (sys_thread_t, sys_thread_t); extern int sys_thread_create (sys_thread_t *, const char *, thread_creation_function *, -- 2.15.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 17:35:44 2018 Received: (at 30106) by debbugs.gnu.org; 17 Jan 2018 22:35:44 +0000 Received: from localhost ([127.0.0.1]:60659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebwJ4-0000ao-Gu for submit@debbugs.gnu.org; Wed, 17 Jan 2018 17:35:43 -0500 Received: from mail-lf0-f41.google.com ([209.85.215.41]:36475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebwJ3-0000aa-7s for 30106@debbugs.gnu.org; Wed, 17 Jan 2018 17:35:41 -0500 Received: by mail-lf0-f41.google.com with SMTP id t79so8666668lfe.3 for <30106@debbugs.gnu.org>; Wed, 17 Jan 2018 14:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CtbWrO+XGqSiBcoF8bvYiboBHlk55UA3Hu+Dt0a/ln8=; b=iHhByXhH/bkXAHwuHvg0SD2BKE9f9yWBktzSpEg+1OOOPjJpFOLvLXJzNlBBvsyzED naGDd4ZAPoHVu6VMKRxAD4wWjJLIOxhkUAzYcRLBuHCl72cDyc9uX8RZHy+rTy7hRqPh z/bkmDwlEC+9gL2Ye22D4R7cDdXrPphnmIlI7vjMgsDEOGuPCAq/4lXxAHvKF9muhNxa VFvzn8tyNTmUXQycqaKH65sXgsF8pPd/MrM9BZArhEZD25kLOctz/YpwrQdPGysC1kzJ mAttLSBm2Nxu+WZrFxOjB5C2XfovIJP6m+4izftJXjpomUq5kWtnRUjwJ3CPSPXghbKH wh2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CtbWrO+XGqSiBcoF8bvYiboBHlk55UA3Hu+Dt0a/ln8=; b=PoARCqzNpc4XJN2cxKA075UW3UMjkUpSpthTKrFoqt5TbXro2uwMHh4FXDbBLcDzNc fZ6vT8x1kHK7W/v0Y8UybGme1nA4XKiNXYFhqyVPpOy/8KPZC/3OxrmSWHP7OVTSl4de 7t8IU4AN6no4T2gScCoSQWIdYdihdAoL22EIgTAfVT8pUwpyxda6XDLHNqmVf3UVjq4P Nh2d9joFXGVTL+Vy5BQHFFXCLuiu60yn/wdVvXA5RlMcw6QDufJQJrZVclcjM86CWdi4 viXTEtk1SfhR/9XW7Ta1LrYHFcdrercnQZibSyBD8qHLbCiTzetQGMz8Pn8hYQotwYqr L5Ow== X-Gm-Message-State: AKwxytfsRlDnWhxemfiA2iQF9BuTIqRR5TAj6lIFrJIOyAWtOzHigxbD BrHYDM0XzVBns+h6spX2wGd31U1HU7NZLmCSisM= X-Google-Smtp-Source: ACJfBoufA/hJeHIC1jU0zmZh1bj5Nrff++32M5kGI1MjkhTLq9b/5y1X+0GGoa00FTdyVyKhQnWKtFL1QFFUFv/63ko= X-Received: by 10.46.15.2 with SMTP id 2mr1547648ljp.144.1516228535402; Wed, 17 Jan 2018 14:35:35 -0800 (PST) MIME-Version: 1.0 References: <20180117222846.93077-1-phst@google.com> In-Reply-To: <20180117222846.93077-1-phst@google.com> From: Philipp Stephani Date: Wed, 17 Jan 2018 22:35:24 +0000 Message-ID: Subject: Re: bug#30106: [PATCH 1/2] Use recommended long options syntax in man page To: Glenn Morris , Eli Zaretskii , 30106@debbugs.gnu.org Content-Type: multipart/alternative; boundary="f403043604144046dc0563007781" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30106 Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --f403043604144046dc0563007781 Content-Type: text/plain; charset="UTF-8" Philipp Stephani schrieb am Mi., 17. Jan. 2018 um 23:30 Uhr: > * doc/man/emacs.1.in: Specify equals sign for long options, as > recommended in the manual. > Please ignore this, it obviously has nothing to do with this bug. I've started off from the wrong branch and then didn't pay close attention to the output of `git send-email'. --f403043604144046dc0563007781 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Mi., 17. Jan. 2018 um 23:30=C2=A0Uhr:
* doc/man/emacs.1.in: Specify equals sign for long opt= ions, as
recommended in the manual.

Please ignore this, it obviously has nothi= ng to do with this bug. I've started off from the wrong branch and then= didn't pay close attention to the output of `git send-email'.=C2= =A0
--f403043604144046dc0563007781-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 09:00:40 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 14:00:40 +0000 Received: from localhost ([127.0.0.1]:32863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecAkB-00042M-Ng for submit@debbugs.gnu.org; Thu, 18 Jan 2018 09:00:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecAkA-000426-72 for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:00:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecAk2-0008FR-Fb for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:00:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecAjQ-0007sv-Ia; Thu, 18 Jan 2018 08:59:52 -0500 Received: from [176.228.60.248] (port=3963 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecAjP-0003G3-Lj; Thu, 18 Jan 2018 08:59:52 -0500 Date: Thu, 18 Jan 2018 15:59:47 +0200 Message-Id: <83zi5buv1o.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Wed, 17 Jan 2018 22:16:58 +0000) Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> <836080w8rr.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: rgm@gnu.org, 30106@debbugs.gnu.org, bugs@gnu.support X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Wed, 17 Jan 2018 22:16:58 +0000 > Cc: Eli Zaretskii , 30106@debbugs.gnu.org, bugs@gnu.support > > The function also doesn't handle the case where neither HAVE_PTHREAD nor WINDOWSNT are defined > (but maybe we don't have such platforms). We don't, see sys_thread.c. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 09:04:32 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 14:04:32 +0000 Received: from localhost ([127.0.0.1]:32867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecAnw-000485-Bm for submit@debbugs.gnu.org; Thu, 18 Jan 2018 09:04:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecAns-00047q-Fk for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:04:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecAnk-0001zS-L2 for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:04:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecAna-0001tK-E4; Thu, 18 Jan 2018 09:04:10 -0500 Received: from [176.228.60.248] (port=3972 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecAnZ-0001aT-Dg; Thu, 18 Jan 2018 09:04:09 -0500 Date: Thu, 18 Jan 2018 16:04:05 +0200 Message-Id: <83y3kvuuui.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: <20180117222846.93077-2-phst@google.com> (message from Philipp Stephani on Wed, 17 Jan 2018 23:28:46 +0100) Subject: Re: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, rgm@gnu.org, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Cc: Philipp Stephani > Date: Wed, 17 Jan 2018 23:28:46 +0100 > > * src/systhread.c (sys_thread_equal): New function. > * src/emacs-module.c (in_current_thread): Use it. I'd prefer that the only file that calls systhread.c functions is thread.c; systhread.c is supposed to be low-level code concealed from application levels. So this would call for another level of indirection: add a new function to thread.c, and call that from emacs-module.c. Otherwise, LGTM for master; thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 09:23:22 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 14:23:22 +0000 Received: from localhost ([127.0.0.1]:32883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecB6A-0004ZD-8l for submit@debbugs.gnu.org; Thu, 18 Jan 2018 09:23:22 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecB68-0004Z0-Dz for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 09:23:20 -0500 Received: by mail-lf0-f44.google.com with SMTP id k19so6640070lfj.1 for <30106@debbugs.gnu.org>; Thu, 18 Jan 2018 06:23:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F2ylcu2/HlNy0DA4IDMADGiFiSIXfYtKKtadGNCg86E=; b=qxeE1GmHa9thIbkZ9K/BI2Ezo69m1zSkMTU4IAYd+EzQq+dpMgUqONRo8Cd3n60k2q kwUEYe+8xJ6xXvlSXnPjXLVEplZ/Wn5iadUvWenccNK3GstsrB6CL3hABNp61BO7+BGY Z4ENCDpkrFs8HEy089pXzT9nbRHkb0bcdU076iWoW9Gg6G+b4OCfgy0lxYC7jLdf+jnD gI1bXsFHZ30d6Yltn/F7fmirxZno+GNtFeTyENf0Mex3aTKqgbWSMo5ioJ6LLmN0+mXK vq6QiyMKUHVRzg2vFjC8QQAA+dlUcpWDl4X9RxOi65IM+5aftFBZHF0ExXyMeRw5AIhz ROVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F2ylcu2/HlNy0DA4IDMADGiFiSIXfYtKKtadGNCg86E=; b=Bs3jxoRKJHghHNFFq9czAravyFIuYw6M8Jy7WFMn/Pcly5elUex2bA5qcM+yAx6n1P CpURSVSO0Oz802CgvbRqSob6/iT/p0H9cX+iIxa93G68hq915lRkEx8ARqQU0cGt108e DG4PL+/f2LgSTovj3x8kAn2YjiJERpGprc4qqjlntARs/MxBUq2juKOTZ/fJO0y4/ebv SI6ebD2g/XjE13nEHra8hZo1oZMahigO9/bc47TJT1A8aPunLG2KBGw1AukZfq4sF08k egsLh006ePA4fx04d2mc411MpfiF0QjZb1xN0yb7Ir/GPp7gRohCouGaafVdtylPEmOa LgnA== X-Gm-Message-State: AKwxyte+07pkro0cy+XjOYEN8QlhDmOD218nrHQDdQi1GMLVgFEu5ZNU TQNc6zpGnaC/pi1LvOiO9kJ+mplT095E2XgIo+M= X-Google-Smtp-Source: ACJfBou1ayhsyUsCLKzc9XHuIsadw4zL3XKVMaq/aXUuc8ksHnC+4/9GduW270qyyhwODpKuo7ERfce4PsBMS8HH+F8= X-Received: by 10.46.68.11 with SMTP id r11mr12243034lja.13.1516285394337; Thu, 18 Jan 2018 06:23:14 -0800 (PST) MIME-Version: 1.0 References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> In-Reply-To: <83y3kvuuui.fsf@gnu.org> From: Philipp Stephani Date: Thu, 18 Jan 2018 14:23:03 +0000 Message-ID: Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) To: Eli Zaretskii Content-Type: multipart/alternative; boundary="94eb2c1942de4ec53905630db48c" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c1942de4ec53905630db48c Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Do., 18. Jan. 2018 um 15:05 Uhr: > > From: Philipp Stephani > > Cc: Philipp Stephani > > Date: Wed, 17 Jan 2018 23:28:46 +0100 > > > > * src/systhread.c (sys_thread_equal): New function. > > * src/emacs-module.c (in_current_thread): Use it. > > I'd prefer that the only file that calls systhread.c functions is > thread.c; systhread.c is supposed to be low-level code concealed from > application levels. So this would call for another level of > indirection: add a new function to thread.c, and call that from > emacs-module.c. > Makes sense, I've moved in_current_thread to thread.c because it's unrelated to modules. > > Otherwise, LGTM for master; thanks. > > Can we push this to emacs-26? Right now emacs-26 can't even be compiled with --without-threads --with-modules (on some systems at least). --94eb2c1942de4ec53905630db48c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Do., 18. Jan. 2018 um 15:05=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Cc: Philipp Stephani <phst@google.com>
> Date: Wed, 17 Jan 2018 23:28:46 +0100
>
> * src/systhread.c (sys_thread_equal): New function.
> * src/emacs-module.c (in_current_thread): Use it.

I'd prefer that the only file that calls systhread.c functions is
thread.c; systhread.c is supposed to be low-level code concealed from
application levels.=C2=A0 So this would call for another level of
indirection: add a new function to thread.c, and call that from
emacs-module.c.

Makes sense, I've m= oved in_current_thread to thread.c because it's unrelated to modules.
=C2=A0

Otherwise, LGTM for master; thanks.


Can we push this to emacs-26? Right now em= acs-26 can't even be compiled with --without-threads --with-modules (on= some systems at least).=C2=A0
--94eb2c1942de4ec53905630db48c-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 10:23:44 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 15:23:44 +0000 Received: from localhost ([127.0.0.1]:33553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecC2Z-000869-OA for submit@debbugs.gnu.org; Thu, 18 Jan 2018 10:23:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecC2Y-00085x-Qs for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 10:23:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecC2Q-0006Pf-D8 for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 10:23:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecC2Q-0006Pb-A3; Thu, 18 Jan 2018 10:23:34 -0500 Received: from [176.228.60.248] (port=4418 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecC2P-0004mb-Nh; Thu, 18 Jan 2018 10:23:34 -0500 Date: Thu, 18 Jan 2018 17:23:29 +0200 Message-Id: <83mv1bur66.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Thu, 18 Jan 2018 14:23:03 +0000) Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Thu, 18 Jan 2018 14:23:03 +0000 > Cc: phst@google.com, 30106@debbugs.gnu.org > > I'd prefer that the only file that calls systhread.c functions is > thread.c; systhread.c is supposed to be low-level code concealed from > application levels. So this would call for another level of > indirection: add a new function to thread.c, and call that from > emacs-module.c. > > Makes sense, I've moved in_current_thread to thread.c because it's unrelated to modules. Thanks. > Otherwise, LGTM for master; thanks. > > Can we push this to emacs-26? Right now emacs-26 can't even be compiled with --without-threads > --with-modules (on some systems at least). How important is this? --with-modules is an opt-in switch, and the default is to build with threads. So this sounds not very important to me, and the change, although simple, is not really trivial, and will affect any module. So I'm uneasy putting this on emacs-26, especially since the Emacs 26.0.91 tarball is already ready and is awaiting upload, so this will only go into the next pretest, which I hoped could be a release candidate... Do you think leaving this for the next release will be so bad? From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 12:40:45 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 17:40:45 +0000 Received: from localhost ([127.0.0.1]:33630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecEBA-0004w3-KJ for submit@debbugs.gnu.org; Thu, 18 Jan 2018 12:40:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecEB8-0004vm-TF for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 12:40:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecEB3-0004h3-1w for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 12:40:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecEB1-0004fX-95; Thu, 18 Jan 2018 12:40:35 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ecEAy-0001l4-Hs; Thu, 18 Jan 2018 12:40:32 -0500 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> <836080w8rr.fsf@gnu.org> X-Spook: pipeline Leuken-Baden AMTRAK Riot MD5 Electric ANZUS X-Ran: K#GFA-j$;(97@,W,~s+ri+U%$~w0aAp=z$)8MYmA)v}s+%'Lml`,i}]w"*3; X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 18 Jan 2018 12:40:32 -0500 In-Reply-To: (Philipp Stephani's message of "Wed, 17 Jan 2018 22:16:58 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org, bugs@gnu.support X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Philipp Stephani wrote: > The function also doesn't handle the case where neither HAVE_PTHREAD nor > WINDOWSNT are defined (but maybe we don't have such platforms). I don't know, but if not then IMO configure should explicitly reject that situation. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 12:41:49 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 17:41:49 +0000 Received: from localhost ([127.0.0.1]:33634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecECD-0004xw-BF for submit@debbugs.gnu.org; Thu, 18 Jan 2018 12:41:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecECB-0004xi-7W for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 12:41:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecEC4-0006PT-Tn for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 12:41:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecEC1-0006H1-W9; Thu, 18 Jan 2018 12:41:38 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ecEC1-0003ql-6S; Thu, 18 Jan 2018 12:41:37 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> X-Spook: Aid FMD computer terrorism Drill Radiation cybercash X-Ran: vQ#2+35;G2r'{D^er6EkO(GK?1gA4S?>"4E#m,{!`Y*G3L,B1oK'|VW"e{-nKB65Pd$U+) X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 18 Jan 2018 12:41:37 -0500 In-Reply-To: <83mv1bur66.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Jan 2018 17:23:29 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, Philipp Stephani , 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) If it's not to be fixed then IMO in the meantime configure should explicitly reject --with-modules if threads are disabled. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 13:53:28 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 18:53:28 +0000 Received: from localhost ([127.0.0.1]:33675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecFJY-00009b-57 for submit@debbugs.gnu.org; Thu, 18 Jan 2018 13:53:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecFJV-00009L-NB for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 13:53:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecFJL-0002Ij-PJ for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 13:53:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecFJL-0002Ie-Ln; Thu, 18 Jan 2018 13:53:15 -0500 Received: from [176.228.60.248] (port=4882 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecFJK-0004qS-Sx; Thu, 18 Jan 2018 13:53:15 -0500 Date: Thu, 18 Jan 2018 20:53:11 +0200 Message-Id: <83efmnuhgo.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Thu, 18 Jan 2018 12:41:37 -0500) Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, p.stephani2@gmail.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: Philipp Stephani , phst@google.com, 30106@debbugs.gnu.org > Date: Thu, 18 Jan 2018 12:41:37 -0500 > > > If it's not to be fixed then IMO in the meantime configure should > explicitly reject --with-modules if threads are disabled. That'd replace one non-trivial change with another, so I think it's worse than fixing the problem. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 14:26:13 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 19:26:13 +0000 Received: from localhost ([127.0.0.1]:33695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecFpE-0000vY-32 for submit@debbugs.gnu.org; Thu, 18 Jan 2018 14:26:12 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:36162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecFpC-0000vH-2E for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 14:26:10 -0500 Received: by mail-lf0-f47.google.com with SMTP id t79so12724525lfe.3 for <30106@debbugs.gnu.org>; Thu, 18 Jan 2018 11:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dbu73V5nNugTocEZ1QdItSIxQ9b1PjGmFmQlX3IGxfg=; b=r8DrLrN7mOYHhxW6bASgtdLf4vvAnVcjUbOB8V3ZBOXnAlHamF8rEpl9c81l8RbQ7l EEa1MCd6oOqjupmDsXYaeSMJXi6pk9fHOOXBtTJW6VOdtKYOOGev5l3br6KqBDzCAiSO 3TemmfawOW/bTbJPkli2jYium9nyhfHU+iV1UgOuD3d+sHZSOIt7z7Cronp0lQkYZ8j8 LMsr9Bq4ZgHg0noMujfZ7k0LVlTOM1UJ4RUz+4TfhrZbvB6gG5nOuWiv1MtMgX0n1DYr 43PylK6OcAcXEmLQySW00GpRyAGJpVvGCBpBCsKJ59DfU7q6km1XG0lzf/kl0S/fbGTU EdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dbu73V5nNugTocEZ1QdItSIxQ9b1PjGmFmQlX3IGxfg=; b=CcYY5SpijCF9BnkS6uJHsJ5jV80zBR4DDUltmw6YYOB43qfWcA/i8T/zL2caMkr4Qu t9qJ47H6DqA7czQyKMsTGFPyU6BP+9WNlTpjOYsIeLjSdztRtI3oFAeeo1gc1rQBx4y6 X5MJ85cBM0suCt8C6YcJgwH7mTsnnl9AfsZmRE21bnZYJMMVVvj81AV91N0f1oLgXOsz rjwBWIvj+0JqhhbfmCHbnMzsgMkPaSAtUhWvnFOF1zSm7aBTDV+DrMbXNSHWZVRGSFkt FFuzP59NauglfL1sFExecDd/tgkynFmogDvqCV9FN/vDrqlNKPUgdl97Jti7qnsxr5UP AJhw== X-Gm-Message-State: AKwxytfveNr7SVuJr2Z30tVAoj4C0FUxYYhbCzQ+T31aNfguML51N1MB bm+9T4WET9hCI1dBVfp/KLJb0VryhQ3ULKt4ZWc= X-Google-Smtp-Source: ACJfBouhejGQ8sqC7UHV0fsZ0QMSvleQT//x/+VJHZySeN97omVvamz+B9r1qewPslXFc0cxfW0y0Vs0cu3JW02nykM= X-Received: by 10.46.15.2 with SMTP id 2mr3598849ljp.144.1516303563878; Thu, 18 Jan 2018 11:26:03 -0800 (PST) MIME-Version: 1.0 References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> In-Reply-To: <83mv1bur66.fsf@gnu.org> From: Philipp Stephani Date: Thu, 18 Jan 2018 19:25:53 +0000 Message-ID: Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) To: Eli Zaretskii Content-Type: multipart/alternative; boundary="f403043604144bf785056311efd1" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --f403043604144bf785056311efd1 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Do., 18. Jan. 2018 um 16:23 Uhr: > > From: Philipp Stephani > > Date: Thu, 18 Jan 2018 14:23:03 +0000 > > Cc: phst@google.com, 30106@debbugs.gnu.org > > > > I'd prefer that the only file that calls systhread.c functions is > > thread.c; systhread.c is supposed to be low-level code concealed from > > application levels. So this would call for another level of > > indirection: add a new function to thread.c, and call that from > > emacs-module.c. > > > > Makes sense, I've moved in_current_thread to thread.c because it's > unrelated to modules. > > Thanks. > > > Otherwise, LGTM for master; thanks. > > > > Can we push this to emacs-26? Right now emacs-26 can't even be compiled > with --without-threads > > --with-modules (on some systems at least). > > How important is this? --with-modules is an opt-in switch, and the > default is to build with threads. So this sounds not very important > to me, and the change, although simple, is not really trivial, and > will affect any module. So I'm uneasy putting this on emacs-26, > especially since the Emacs 26.0.91 tarball is already ready and is > awaiting upload, so this will only go into the next pretest, which I > hoped could be a release candidate... > > Do you think leaving this for the next release will be so bad? > OK, pushed to master as 694ee38f8b. I don't expect this bug to cause correctness problems, even with the combination --without-threads --with-modules. The test is buggy, but it will only cause false positives with --module-assertions. That's annoying, but users can ignore these assertions. However, in the correct implementation, in_current_thread is effectively always true if threads are unavailable, so occasionally returning false is not a problem as far as modules are concerned. --f403043604144bf785056311efd1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Do., 18. Jan. 2018 um 16:23=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Thu, 18 Jan 2018 14:23:03 +0000
> Cc: phst@google.c= om, 30106@de= bbugs.gnu.org
>
>=C2=A0 I'd prefer that the only file that calls systhread.c functio= ns is
>=C2=A0 thread.c; systhread.c is supposed to be low-level code concealed= from
>=C2=A0 application levels.=C2=A0 So this would call for another level o= f
>=C2=A0 indirection: add a new function to thread.c, and call that from<= br> >=C2=A0 emacs-module.c.
>
> Makes sense, I've moved in_current_thread to thread.c because it&#= 39;s unrelated to modules.

Thanks.

>=C2=A0 Otherwise, LGTM for master; thanks.
>
> Can we push this to emacs-26? Right now emacs-26 can't even be com= piled with --without-threads
> --with-modules (on some systems at least).

How important is this?=C2=A0 --with-modules is an opt-in switch, and the default is to build with threads.=C2=A0 So this sounds not very important to me, and the change, although simple, is not really trivial, and
will affect any module.=C2=A0 So I'm uneasy putting this on emacs-26, especially since the Emacs 26.0.91 tarball is already ready and is
awaiting upload, so this will only go into the next pretest, which I
hoped could be a release candidate...

Do you think leaving this for the next release will be so bad?

OK, pushed to master as=C2=A0=C2=A0694ee38f8b.

I don't expect this bug to cause correctness probl= ems, even with the combination --without-threads --with-modules. The test i= s buggy, but it will only cause false positives with --module-assertions. T= hat's annoying, but users can ignore these assertions. However, in the = correct implementation, in_current_thread is effectively always true if thr= eads are unavailable, so occasionally returning false is not a problem as f= ar as modules are concerned.
--f403043604144bf785056311efd1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 14:35:50 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 19:35:51 +0000 Received: from localhost ([127.0.0.1]:33704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecFyY-000355-MH for submit@debbugs.gnu.org; Thu, 18 Jan 2018 14:35:50 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:38507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecFyS-00034l-7k for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 14:35:45 -0500 Received: by mail-lf0-f50.google.com with SMTP id g72so22655658lfg.5 for <30106@debbugs.gnu.org>; Thu, 18 Jan 2018 11:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jPHTSozR0HZFg5LCLFUac5By9YUnu51q6gXcODcutRA=; b=KPXDyR9BGurfcLSfvApaFO2vtKXDpfUXEmww7G3jt+6Gs02Kn38Y9gjyrTFFEoYw1a 0fFsjgST0NRFucNOTILq216WKhCkoRMc/QOCJCiK43CYtpWImmZE/9PKsY814vhgyD2b SeyPLSTVrzv8AsBui8D71HWrJL2Bl/GByyfBxlQsAhw6cGv8Wu4F+nZ3KNXCfozn2kU8 C74nR9oRytVoMmqa6XVwsyVvqK49lJNWXT2vyIXeqZE/ifP4Rl24tVZajP/lqM3nIcKK ejneO8dv8kWD9DbPTAtWxfVjv/nSLbW3gnxywe4E17cqGu88ghV0X/6zj7EyEMY+NdPP dMQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jPHTSozR0HZFg5LCLFUac5By9YUnu51q6gXcODcutRA=; b=sjen/NKTXle8Go6LXecSknOUoMOD4vY3GGZmeJzS3o3TWh2K2YU7DQzyVcs71XNNuL heGQXJDV/8Rm523t4o0MWc/0np7m8l0GM1qy+Isx8ugBYoWXtAEL8iMp8gDwRK3s3Ev0 /tYCXXCAHsfXZzwTAmcRZbqwlICfWFs0OArwpMq3nrLs/g7pWB1B+bIEMRgwQuRwfx5V RfK0f+GQ7aWX/gjTLiMXXgdsSSzxA6dEj2ZoAZvpUGcdFJf7K/k/47ZUDpaX2nfBGjzV xdVsuCWhNdACttP7kKXxQc3xSgyRl26suZIS8WRXv1jMzwxIrqVy2TbCtiLdpVGDckWz OpXg== X-Gm-Message-State: AKwxytfG5tt1xLI5Kp+KHfRtnjt2zjCpfXes/cBxr9tlja4JyjuehtBG VgPECsf5ibKkTkWYQdQFOJRtWsJEI4siEbL8w38= X-Google-Smtp-Source: ACJfBovCA5IEUWBKNWSOAEa8oBVxMInXS4OJrUozaIrupaQ64empXwzGCw+yXxGB4GlnAQ5WtPEIlqAnGduvznwCJWc= X-Received: by 10.25.171.10 with SMTP id u10mr23437150lfe.12.1516304136812; Thu, 18 Jan 2018 11:35:36 -0800 (PST) MIME-Version: 1.0 References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <7l37370zwe.fsf@fencepost.gnu.org> In-Reply-To: <7l37370zwe.fsf@fencepost.gnu.org> From: Philipp Stephani Date: Thu, 18 Jan 2018 19:35:26 +0000 Message-ID: Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' To: Glenn Morris Content-Type: multipart/alternative; boundary="94eb2c1cd70c72402b056312118a" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org, Jean Louis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c1cd70c72402b056312118a Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Mo., 15. Jan. 2018 um 18:57 Uhr: > > It seems that Fmodule_load does not update load-history. > This is causing Frequire to report the wrong file names in its error > message, which is making it hard to diagnose the real problem. > > > > Sigh, Fmodule_load has many other bugs, now that I look at it: - It doesn't protect against recursive loads - It doesn't print load messages even if force-load-messages is t - It doesn't update loads-in-progress - It doesn't do any of the other things that Fload does for .el and .elc files I think we should get rid of Fmodule_load entirely and add the module-specific parts to Fload (the module initialization step itself should stay in emacs-module.c though). --94eb2c1cd70c72402b056312118a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Mo= ., 15. Jan. 2018 um 18:57=C2=A0Uhr:

It seems that Fmodule_load does not update load-history.
This is causing Frequire to report the wrong file names in its error
message, which is making it hard to diagnose the real problem.




Sigh, Fmodule_load has many other bugs= , now that I look at it:
- It doesn't protect against recursi= ve loads
- It doesn't print load messages even if force-load-= messages is t
- It doesn't update loads-in-progress
- It doesn't do any of the other things that Fload does for .el and .e= lc files
I think we should get rid of Fmodule_load entirely and a= dd the module-specific parts to Fload (the module initialization step itsel= f should stay in emacs-module.c though).
--94eb2c1cd70c72402b056312118a-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 17:55:42 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 22:55:42 +0000 Received: from localhost ([127.0.0.1]:33826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJ5x-000744-TB for submit@debbugs.gnu.org; Thu, 18 Jan 2018 17:55:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJ5u-00073q-EK for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 17:55:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecJ5o-0005yz-7O for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 17:55:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecJ5f-0005xW-8Y; Thu, 18 Jan 2018 17:55:23 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ecJ5e-0002Tl-LG; Thu, 18 Jan 2018 17:55:22 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> <83efmnuhgo.fsf@gnu.org> X-Spook: AIMSX cryptanalysis Ermes Al Qa'ida CDC CISU Deaths X-Ran: /Yi2n?xK>R+z*d/b-g[yux}=5J:j}&,Wfvy>S:KG^cB&3r@edk>xQNR[X\OC)EB17Z:m{+ X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 18 Jan 2018 17:55:22 -0500 In-Reply-To: <83efmnuhgo.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Jan 2018 20:53:11 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, p.stephani2@gmail.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: >> If it's not to be fixed then IMO in the meantime configure should >> explicitly reject --with-modules if threads are disabled. > > That'd replace one non-trivial change with another, so I think it's > worse than fixing the problem. You think the following is non-trivial? --- a/configure.ac +++ b/configure.ac @@ -3513,6 +3513,8 @@ case $opsys in *) MODULES_SUFFIX=".so" ;; esac if test "${with_modules}" != "no"; then + test "${threads_enabled}" = "no" && \ + AC_MSG_ERROR([modules currently require threads]) case $opsys in gnu|gnu-linux) LIBMODULES="-ldl" From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 18:00:17 2018 Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 23:00:17 +0000 Received: from localhost ([127.0.0.1]:33830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJAP-0007C3-IR for submit@debbugs.gnu.org; Thu, 18 Jan 2018 18:00:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJAN-0007Bo-RE for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 18:00:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecJAD-0000kD-Bh for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 18:00:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecJAB-0000jc-Rt; Thu, 18 Jan 2018 18:00:03 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ecJAB-0007Rb-6U; Thu, 18 Jan 2018 18:00:03 -0500 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114063602.GA9234@protected.rcdrun.com> <83zi5gzalr.fsf@gnu.org> <20180114174748.GA12223@protected.rcdrun.com> <83shb8z0lz.fsf@gnu.org> <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <7l37370zwe.fsf@fencepost.gnu.org> X-Spook: Enriched WMATA tempest AMTRAK JFK Dateline pipeline DEA X-Ran: b{r)-]cPIp=>9[<.N2\w18\\6Qwlk'l`$1K&4I1j;]*PZSpDPJ0l[=eq5t\M!VaTEO,Kiw X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 18 Jan 2018 18:00:03 -0500 In-Reply-To: (Philipp Stephani's message of "Thu, 18 Jan 2018 19:35:26 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: Eli Zaretskii , 30106@debbugs.gnu.org, Jean Louis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Philipp Stephani wrote: >> It seems that Fmodule_load does not update load-history. >> This is causing Frequire to report the wrong file names in its error >> message, which is making it hard to diagnose the real problem. Sorry, I made a separate report for this before seeing your reply. bug#30164 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 18:01:47 2018 Received: (at 30106-done) by debbugs.gnu.org; 18 Jan 2018 23:01:47 +0000 Received: from localhost ([127.0.0.1]:33834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJBq-0007EO-Vu for submit@debbugs.gnu.org; Thu, 18 Jan 2018 18:01:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecJBn-0007EA-Nj for 30106-done@debbugs.gnu.org; Thu, 18 Jan 2018 18:01:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecJBh-0001jx-RT for 30106-done@debbugs.gnu.org; Thu, 18 Jan 2018 18:01:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD, UNRESOLVED_TEMPLATE autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecJBh-0001js-OY for 30106-done@debbugs.gnu.org; Thu, 18 Jan 2018 18:01:37 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ecJBh-0001kz-DN; Thu, 18 Jan 2018 18:01:37 -0500 From: Glenn Morris To: 30106-done@debbugs.gnu.org Subject: Re: bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' References: <20180114221228.GA17422@protected.rcdrun.com> <833737z2jy.fsf@gnu.org> <20180115185533.GA6309@protected.rcdrun.com> <836081y8ra.fsf@gnu.org> <20180116191855.GB18155@protected.rcdrun.com> <83mv1cwl82.fsf@gnu.org> <20180117170310.GA31570@protected.rcdrun.com> <837esgwde8.fsf@gnu.org> <20180117193734.GB28510@protected.rcdrun.com> X-Spook: Flood Pirates argus Infection csystems Blowpipe DES TSA X-Ran: 5k(;kC*'xd'ZxGxj$HFrv({?zAGX,\wA%)1Nkcr6yCV(;TUP@_>!BaRlpX4a1bJW>%KZ8h X-Hue: black X-Attribution: GM Date: Thu, 18 Jan 2018 18:01:37 -0500 In-Reply-To: <20180117193734.GB28510@protected.rcdrun.com> (Jean Louis's message of "Wed, 17 Jan 2018 22:37:35 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 30106-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Jean Louis wrote: > However, now at this point, but maybe after patching, I could compile > it so that it works. I can load the dynamic module with (require 'pq) Based on this comment I am closing this report. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 19 02:59:21 2018 Received: (at 30106) by debbugs.gnu.org; 19 Jan 2018 07:59:21 +0000 Received: from localhost ([127.0.0.1]:34005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecRa5-00056Z-3i for submit@debbugs.gnu.org; Fri, 19 Jan 2018 02:59:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecRa3-00056L-PP for 30106@debbugs.gnu.org; Fri, 19 Jan 2018 02:59:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecRZw-0006RG-2W for 30106@debbugs.gnu.org; Fri, 19 Jan 2018 02:59:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecRZv-0006RC-VZ; Fri, 19 Jan 2018 02:59:12 -0500 Received: from [176.228.60.248] (port=1522 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecRZv-0001KD-3O; Fri, 19 Jan 2018 02:59:11 -0500 Date: Fri, 19 Jan 2018 09:58:51 +0200 Message-Id: <83607yuvno.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Thu, 18 Jan 2018 17:55:22 -0500) Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> <83efmnuhgo.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, p.stephani2@gmail.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: p.stephani2@gmail.com, phst@google.com, 30106@debbugs.gnu.org > Date: Thu, 18 Jan 2018 17:55:22 -0500 > > Eli Zaretskii wrote: > > >> If it's not to be fixed then IMO in the meantime configure should > >> explicitly reject --with-modules if threads are disabled. > > > > That'd replace one non-trivial change with another, so I think it's > > worse than fixing the problem. > > You think the following is non-trivial? Yes, because it changes the configure script. How do we know it won't fail builds on some obscure platforms? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 13:08:00 2018 Received: (at 30106) by debbugs.gnu.org; 20 Jan 2018 18:08:00 +0000 Received: from localhost ([127.0.0.1]:36314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecxYe-0003aW-Jn for submit@debbugs.gnu.org; Sat, 20 Jan 2018 13:08:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecxYd-0003aG-4n for 30106@debbugs.gnu.org; Sat, 20 Jan 2018 13:07:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecxYX-0008Nt-47 for 30106@debbugs.gnu.org; Sat, 20 Jan 2018 13:07:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecxYU-0008Kd-0i; Sat, 20 Jan 2018 13:07:50 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ecxYR-0002Z8-R3; Sat, 20 Jan 2018 13:07:47 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> <83efmnuhgo.fsf@gnu.org> <83607yuvno.fsf@gnu.org> X-Spook: Riot embassy Stuck Crypto AG Drill Iraq War on Terrorism X-Ran: YB`Bcr8Fy+2S]yRp!h$R(^G@RI@xtr (Eli Zaretskii's message of "Fri, 19 Jan 2018 09:58:51 +0200") Message-ID: <8wpo642yks.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, p.stephani2@gmail.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: >> You think the following is non-trivial? > > Yes, because it changes the configure script. How do we know it won't > fail builds on some obscure platforms? Basic common sense. But don't worry, I've learnt that expressing my opinion is a waste of time. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 14:01:46 2018 Received: (at 30106) by debbugs.gnu.org; 20 Jan 2018 19:01:47 +0000 Received: from localhost ([127.0.0.1]:36333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecyOg-00058l-Mv for submit@debbugs.gnu.org; Sat, 20 Jan 2018 14:01:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecyOf-00058I-4o for 30106@debbugs.gnu.org; Sat, 20 Jan 2018 14:01:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecyOV-00026f-8c for 30106@debbugs.gnu.org; Sat, 20 Jan 2018 14:01:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecyOV-00026V-5A; Sat, 20 Jan 2018 14:01:35 -0500 Received: from [176.228.60.248] (port=1313 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecyOS-0001oC-KO; Sat, 20 Jan 2018 14:01:34 -0500 Date: Sat, 20 Jan 2018 21:01:06 +0200 Message-Id: <83fu70s6bx.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: <8wpo642yks.fsf@fencepost.gnu.org> (message from Glenn Morris on Sat, 20 Jan 2018 13:07:47 -0500) Subject: Re: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> <83mv1bur66.fsf@gnu.org> <83efmnuhgo.fsf@gnu.org> <83607yuvno.fsf@gnu.org> <8wpo642yks.fsf@fencepost.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30106 Cc: phst@google.com, p.stephani2@gmail.com, 30106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: p.stephani2@gmail.com, phst@google.com, 30106@debbugs.gnu.org > Date: Sat, 20 Jan 2018 13:07:47 -0500 > > Eli Zaretskii wrote: > > >> You think the following is non-trivial? > > > > Yes, because it changes the configure script. How do we know it won't > > fail builds on some obscure platforms? > > Basic common sense. I'm afraid that has failed us more than once in the past. > But don't worry, I've learnt that expressing my opinion is a waste of time. I value your opinions very much, I just don't always agree with them (as you don't with mine). I very much hope you don't decide to stop voicing your opinions here. From unknown Sun Jun 15 08:49:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Feb 2018 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 15 21:13:25 2019 Received: (at control) by debbugs.gnu.org; 16 Apr 2019 01:13:25 +0000 Received: from localhost ([127.0.0.1]:35965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGCf6-0006fF-MJ for submit@debbugs.gnu.org; Mon, 15 Apr 2019 21:13:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGCf4-0006ew-2K for control@debbugs.gnu.org; Mon, 15 Apr 2019 21:13:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGCey-0005qL-R1 for control@debbugs.gnu.org; Mon, 15 Apr 2019 21:13:16 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hGCey-0007S8-F0 for control@debbugs.gnu.org; Mon, 15 Apr 2019 21:13:16 -0400 Subject: control message for bug 30106 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 15 Apr 2019 21:13:16 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) unarchive 30106 fixed 30106 27.1 From unknown Sun Jun 15 08:49:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 May 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator