From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Resent-From: Tim Landscheidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2018 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30101@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15158817133714 (code B ref -1); Sat, 13 Jan 2018 22:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jan 2018 22:15:13 +0000 Received: from localhost ([127.0.0.1]:55206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaU53-0000xq-9J for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaU51-0000xb-J0 for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaU4v-0006JE-KV for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45913) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eaU4v-0006J7-H4 for submit@debbugs.gnu.org; Sat, 13 Jan 2018 17:15:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaU4u-0001vY-JR for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:15:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaU4p-0006H4-LA for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:15:04 -0500 Received: from mezzogiorno.tim-landscheidt.de ([2a01:4f8:d15:2286::2]:46980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eaU4p-0006Ew-Ee for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 17:14:59 -0500 Received: from dslb-092-076-023-076.092.076.pools.vodafone-ip.de ([92.76.23.76]:36798 helo=passepartout.tim-landscheidt.de) by mezzogiorno.tim-landscheidt.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eaU4h-0002Km-Fq for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 22:14:51 +0000 From: Tim Landscheidt Organization: http://www.tim-landscheidt.de/ Date: Sat, 13 Jan 2018 22:14:50 +0000 Message-ID: <87y3l1l82t.fsf@passepartout.tim-landscheidt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) If one evaluates first: | (defcustom tmp-test-variable2 nil | "A vowel." | :type 'alist | :options '("A" "F" "I" "O" "U")) and then changes "F" to "E" and evaluates: | (defcustom tmp-test-variable2 nil | "A vowel." | :type 'alist | :options '("A" "E" "I" "O" "U")) the resulting customization page looks like: | Hide Tmp Test Variable2: | [ ] Key: E | Value: nil | [ ] Key: A | Value: nil | [ ] Key: F | Value: nil | [ ] Key: I | Value: nil | [ ] Key: O | Value: nil | [ ] Key: U | Value: nil | INS | State : STANDARD. | A vowel. | Groups: Nil i. e., it is the superset of the :options of the two calls. This is unexpected and undocumented. AFAICT, this behaviour stems from lisp/custom.el's: | [=E2=80=A6] | ((eq keyword :options) | (if (get symbol 'custom-options) | ;; Slow safe code to avoid duplicates. | (mapc (lambda (option) | (custom-add-option symbol option)) | value) | ;; Fast code for the common case. | (put symbol 'custom-options (copy-sequence value)))) | [=E2=80=A6] which has not been substantially touched since the initial revision (d543e20b611fc289b174aa82cab940d873a586ff). Is there any harm in always putting the copied sequence un- conditionally? (Workaround: (put 'tmp-test-variable2 'custom-options nil).) From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Resent-From: Tim Landscheidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jan 2018 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30101@debbugs.gnu.org Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.151596194726756 (code B ref 30101); Sun, 14 Jan 2018 20:33:02 +0000 Received: (at 30101) by debbugs.gnu.org; 14 Jan 2018 20:32:27 +0000 Received: from localhost ([127.0.0.1]:56369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaox7-0006xR-Ps for submit@debbugs.gnu.org; Sun, 14 Jan 2018 15:32:27 -0500 Received: from mezzogiorno.tim-landscheidt.de ([78.47.87.37]:36618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaox5-0006xI-BK for 30101@debbugs.gnu.org; Sun, 14 Jan 2018 15:32:23 -0500 Received: from dslb-092-076-023-076.092.076.pools.vodafone-ip.de ([92.76.23.76]:43172 helo=passepartout.tim-landscheidt.de) by mezzogiorno.tim-landscheidt.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eaox3-0006t2-EZ for 30101@debbugs.gnu.org; Sun, 14 Jan 2018 20:32:21 +0000 From: Tim Landscheidt Organization: http://www.tim-landscheidt.de/ References: <87y3l1l82t.fsf@passepartout.tim-landscheidt.de> Date: Sun, 14 Jan 2018 20:32:19 +0000 In-Reply-To: <87y3l1l82t.fsf@passepartout.tim-landscheidt.de> (Tim Landscheidt's message of "Sat, 13 Jan 2018 22:14:50 +0000") Message-ID: <87o9lwtc4s.fsf@passepartout.tim-landscheidt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Further reading shows that this cumultative behaviour is needed via custom-add-option by various files that enhance the options of a different file's variables with it: | [tim@passepartout ~/src/emacs]$ git grep custom-add-option -- \*.el | lisp/calendar/diary-lib.el:(custom-add-option 'gnus-article-prepare-hook 'diary-from-outlook-gnus) | lisp/custom.el: (custom-add-option symbol option)) | lisp/custom.el:(defun custom-add-option (symbol option) | lisp/custom.el:(defalias 'custom-add-frequent-value 'custom-add-option) | lisp/emacs-lisp/checkdoc.el:(custom-add-option 'emacs-lisp-mode-hook 'checkdoc-minor-mode) | lisp/eshell/esh-mode.el:(custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark) | lisp/eshell/esh-mode.el:(custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark) | lisp/eshell/esh-mode.el:(custom-add-option 'eshell-input-filter-functions 'eshell-kill-new) | lisp/eshell/esh-mode.el:(custom-add-option 'eshell-output-filter-functions | lisp/eshell/esh-mode.el:(custom-add-option 'eshell-output-filter-functions | lisp/eshell/esh-mode.el:(custom-add-option 'eshell-output-filter-functions | lisp/eshell/esh-mode.el:(custom-add-option 'eshell-output-filter-functions | lisp/gnus/message.el:(custom-add-option 'message-setup-hook 'message-check-recipients) | lisp/gnus/nnmail.el:(custom-add-option 'nnmail-prepare-incoming-header-hook | lisp/simple.el:(custom-add-option 'text-mode-hook 'turn-on-auto-fill) | lisp/textmodes/flyspell.el:(custom-add-option 'text-mode-hook 'turn-on-flyspell) | [tim@passepartout ~/src/emacs]$ So this behaviour cannot be changed, but should be document- ed. From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jan 2018 05:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tim Landscheidt Cc: 30101@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.151599338830303 (code B ref 30101); Mon, 15 Jan 2018 05:17:02 +0000 Received: (at 30101) by debbugs.gnu.org; 15 Jan 2018 05:16:28 +0000 Received: from localhost ([127.0.0.1]:56590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eax8G-0007sh-2y for submit@debbugs.gnu.org; Mon, 15 Jan 2018 00:16:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eax8D-0007sT-QW for 30101@debbugs.gnu.org; Mon, 15 Jan 2018 00:16:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eax87-0007Pr-Tl for 30101@debbugs.gnu.org; Mon, 15 Jan 2018 00:16:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eax87-0007Pl-Q8; Mon, 15 Jan 2018 00:16:19 -0500 Received: from [176.228.60.248] (port=3419 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eax87-00063W-6S; Mon, 15 Jan 2018 00:16:19 -0500 Date: Mon, 15 Jan 2018 07:16:06 +0200 Message-Id: <83lggzzoq1.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87o9lwtc4s.fsf@passepartout.tim-landscheidt.de> (message from Tim Landscheidt on Sun, 14 Jan 2018 20:32:19 +0000) References: <87y3l1l82t.fsf@passepartout.tim-landscheidt.de> <87o9lwtc4s.fsf@passepartout.tim-landscheidt.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tim Landscheidt > Date: Sun, 14 Jan 2018 20:32:19 +0000 > > So this behaviour cannot be changed, but should be document- > ed. Patches to document this will be welcome. Thanks. From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated References: <87y3l1l82t.fsf@passepartout.tim-landscheidt.de> In-Reply-To: <87y3l1l82t.fsf@passepartout.tim-landscheidt.de> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 15:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 30101@debbugs.gnu.org, tim@tim-landscheidt.de Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.15987138888082 (code B ref 30101); Sat, 29 Aug 2020 15:12:01 +0000 Received: (at 30101) by debbugs.gnu.org; 29 Aug 2020 15:11:28 +0000 Received: from localhost ([127.0.0.1]:48871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2Vs-00026I-Fu for submit@debbugs.gnu.org; Sat, 29 Aug 2020 11:11:28 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:33149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2Vq-000262-ET for 30101@debbugs.gnu.org; Sat, 29 Aug 2020 11:11:27 -0400 Received: by mail-wr1-f45.google.com with SMTP id o4so1882407wrn.0 for <30101@debbugs.gnu.org>; Sat, 29 Aug 2020 08:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=L93JsJ2c8onjMVhtbmUo8ECYeJxu/mBmAK5ms84BB8I=; b=qtR/1A5IGelgRaejNve4uvWIlv/CbJ5iuxKmSB7HD+XXoUXcB4cfGbvWZWzd1baC6K 0eM3D+QTplAd5xYPYMSzd42vDfSwxJ0f+6HMtFdMa9nl++Sp81uDyLqaJVPS25JJa343 osUseFjthxm5Ue18hxnqK7f01hbCfIDdtejYS9ApaQTlz2fiFBaPEV2isSQeLeYerNfU ZQdHYlah+CHnNtfLUtm9ugapS0EstAsMJoX92gkPt951AtNyexr0kFyCs5NuqrlhbYvn RNu1ID4Yl0ETSdC3HuAFdg0FU2Z4OUvGjiwsyibOeQfEZ/r2doQXgNGiQ7adGPldD8Sb 4EIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=L93JsJ2c8onjMVhtbmUo8ECYeJxu/mBmAK5ms84BB8I=; b=i198eHmVohANkdfP0jmfaujneUCxGNBnkI64A4/VEznlaqnof4CPJ/fWSy6Apgz05C YjjdmY50lKDbioW5kaPRSnbngvWRcen6hcBunY4Vy3jRBjjbjw+DKjZVxTRmSfasSUik yBHUQZSeGEUzXVse0vD5ZYwC9t2Nb6idEpAiiuWqy7Bo877rOTmhsSotHDbKoLZXPGBy B9Cuuf/mMQSJssIBVpodceAGD8Uh5TtW069LUW2KaOyDL4m+R/zoZvjUOaLxKFI8gSsP X3kPvv4SNB36i5cgGjwaTzghCCZpnzvyPjTu1qpaUd2mFFff72b7k2q/fzzdHw8doVhJ dmCg== X-Gm-Message-State: AOAM530fhleId6+8niNGMuq/351FFN5/AENd8Hnapxo4uLOHrqcGuTFS aYlBUXS7Cw62Ynsgabs1yzvMDhZ39w3yJ/eR0GU= X-Google-Smtp-Source: ABdhPJy81T+qHAbfHTulecVwQ1sBvf9l4k6oi88EdoID9J4wnSKSJcgQgGqHfyIFk84kPf+19IHE/R6RJhi4HtfVgz8= X-Received: by 2002:a5d:540c:: with SMTP id g12mr3825835wrv.120.1598713880526; Sat, 29 Aug 2020 08:11:20 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Sat, 29 Aug 2020 12:11:07 -0300 Message-ID: Content-Type: multipart/mixed; boundary="000000000000f260ba05ae05946a" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f260ba05ae05946a Content-Type: multipart/alternative; boundary="000000000000f260b905ae059468" --000000000000f260b905ae059468 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Tim Landscheidt >> Date: Sun, 14 Jan 2018 20:32:19 +0000 >> >> So this behaviour cannot be changed, but should be document- >> ed. > > Patches to document this will be welcome. > > Thanks. I took a shot at it. Please review. --000000000000f260b905ae059468 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Tim Landscheidt <tim@tim-landscheidt.de>
>> Da= te: Sun, 14 Jan 2018 20:32:19 +0000
>>
>> So this behavi= our cannot be changed, but should be document-
>> ed.
>
&= gt; Patches to document this will be welcome.
>
> Thanks.
I took a shot at it.=C2=A0 Please review.
--000000000000f260b905ae059468-- --000000000000f260ba05ae05946a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Improve-documentation-for-custom-options.patch" Content-Disposition: attachment; filename="0001-Improve-documentation-for-custom-options.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kefswf8f0 RnJvbSAyMzE1ZDFlM2NlYzI2NGVmODlkYWVhNTE3NzJlZTM0OGFiMTg3YTNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFNhdCwgMjkgQXVnIDIwMjAgMTI6MDQ6MjcgLTAzMDAKU3ViamVjdDogW1BBVENIXSBJ bXByb3ZlIGRvY3VtZW50YXRpb24gZm9yIGN1c3RvbSA6b3B0aW9ucwoKKiBkb2MvbGlzcHJlZi9j dXN0b21pemUudGV4aSAoRGVmaW5pbmcgQ3VzdG9taXphdGlvbiBWYXJpYWJsZXMpOgpNZW50aW9u IHRoYXQgcmUtZXZhbHVhdGluZyBhIGRlZmN1c3RvbSBmb3JtIGRvZXNuJ3QgcmVzZXQgY3VzdG9t Cm9wdGlvbnMuICAoQnVnIzMwMTAxKQoqIGxpc3AvY3VzdG9tLmVsIChjdXN0b20tYWRkLW9wdGlv bik6IE1lbnRpb24gdGhlIHBsaXN0IGNhc2UgaW4gdGhlCmRvY3N0cmluZy4KLS0tCiBkb2MvbGlz cHJlZi9jdXN0b21pemUudGV4aSB8IDYgKysrKysrCiBsaXNwL2N1c3RvbS5lbCAgICAgICAgICAg ICB8IDkgKysrKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvY3VzdG9taXplLnRleGkgYi9kb2Mv bGlzcHJlZi9jdXN0b21pemUudGV4aQppbmRleCAyYTcyMjc2YmM1Li5lZTk0YzVlNTRlIDEwMDY0 NAotLS0gYS9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQorKysgYi9kb2MvbGlzcHJlZi9jdXN0 b21pemUudGV4aQpAQCAtNDc5LDYgKzQ3OSwxMiBAQCBWYXJpYWJsZSBEZWZpbml0aW9ucwogICAg J215LWxpc3AtbW9kZS1pbml0aWFsaXphdGlvbikKIEBlbmQgZXhhbXBsZQogCitSZS1ldmFsdWF0 aW5nIGEgQGNvZGV7ZGVmY3VzdG9tfSBmb3JtIG9mIGFuIGFscmVhZHkgZGVmaW5lZCB1c2VyCitv cHRpb24gZG9lcyBub3QgY2xlYXIgdGhlIHJlYXNvbmFibGUgdmFsdWVzIGFkZGVkIGJ5IHByZXZp b3VzCitldmFsdWF0aW9ucywgb3IgYnkgY2FsbHMgdG8gQGNvZGV7Y3VzdG9tLWFkZC1mcmVxdWVu dC12YWx1ZX0uICBUaGlzCit3YXksIExpc3AgcHJvZ3JhbXMgY2FuIGFkZCByZWFzb25hYmxlIHZh bHVlcyBmb3IgdXNlciBvcHRpb25zIG5vdCB5ZXQKK2RlZmluZWQuCisKIEBkZWZ1biBjdXN0b20t YWRkLWZyZXF1ZW50LXZhbHVlIHN5bWJvbCB2YWx1ZQogRm9yIHRoZSBjdXN0b21pemF0aW9uIG9w dGlvbiBAdmFye3N5bWJvbH0sIGFkZCBAdmFye3ZhbHVlfSB0byB0aGUKIGxpc3Qgb2YgcmVhc29u YWJsZSB2YWx1ZXMuCmRpZmYgLS1naXQgYS9saXNwL2N1c3RvbS5lbCBiL2xpc3AvY3VzdG9tLmVs CmluZGV4IDc1ODE0NTdjZTguLjhjMDlmYThlZDAgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzdG9tLmVs CisrKyBiL2xpc3AvY3VzdG9tLmVsCkBAIC01NzgsOSArNTc4LDE0IEBAIGN1c3RvbS1hZGQtZGVw ZW5kZW5jaWVzCiAoZGVmdW4gY3VzdG9tLWFkZC1vcHRpb24gKHN5bWJvbCBvcHRpb24pCiAgICJU byB0aGUgdmFyaWFibGUgU1lNQk9MIGFkZCBPUFRJT04uCiAKK0N1c3RvbSB0aGVuIHByZXNlbnRz IE9QVElPTiB0byB0aGUgdXNlciBhcyBhIHN1Z2dlc3RlZCBtZW1iZXIKK2ZvciB0aGUgdmFsdWUg b2YgU1lNQk9MLgorCiBJZiBTWU1CT0wncyBjdXN0b20gdHlwZSBpcyBhIGhvb2ssIE9QVElPTiBz aG91bGQgYmUgYSBob29rIG1lbWJlci4KLUlmIFNZTUJPTCdzIGN1c3RvbSB0eXBlIGlzIGFuIGFs aXN0LCBPUFRJT04gc3BlY2lmaWVzIGEgc3ltYm9sCi10byBvZmZlciB0byB0aGUgdXNlciBhcyBh IHBvc3NpYmxlIGtleSBpbiB0aGUgYWxpc3QuCitJZiBTWU1CT0wncyBjdXN0b20gdHlwZSBpcyBh biBhbGlzdCwgT1BUSU9OIHNwZWNpZmllcyBhIHBvc3NpYmxlIGtleQoraW4gdGhlIGFsaXN0Lgor U2ltaWxhcmx5LCBpZiBTWU1CT0wncyBjdXN0b20gdHlwZSBpcyBhIHBsaXN0LCBPUFRJT04gc3Bl Y2lmaWVzCithIHBvc3NpYmxlIG5hbWUgaW4gdGhlIHBsaXN0LgogRm9yIG90aGVyIGN1c3RvbSB0 eXBlcywgdGhpcyBoYXMgbm8gZWZmZWN0LiIKICAgKGxldCAoKG9wdGlvbnMgKGdldCBzeW1ib2wg J2N1c3RvbS1vcHRpb25zKSkpCiAgICAgKHVubGVzcyAobWVtYmVyIG9wdGlvbiBvcHRpb25zKQot LSAKMi4yOC4wCgo= --000000000000f260ba05ae05946a-- From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 30101@debbugs.gnu.org, tim@tim-landscheidt.de Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.159871570110908 (code B ref 30101); Sat, 29 Aug 2020 15:42:02 +0000 Received: (at 30101) by debbugs.gnu.org; 29 Aug 2020 15:41:41 +0000 Received: from localhost ([127.0.0.1]:48892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2z6-0002pr-R8 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 11:41:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2z5-0002pf-8V for 30101@debbugs.gnu.org; Sat, 29 Aug 2020 11:41:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54513) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC2yz-00086Q-9N; Sat, 29 Aug 2020 11:41:33 -0400 Received: from [176.228.60.248] (port=2989 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kC2yx-0001pZ-Lw; Sat, 29 Aug 2020 11:41:32 -0400 Date: Sat, 29 Aug 2020 18:41:24 +0300 Message-Id: <83y2lxxxwb.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Mauro Aranda on Sat, 29 Aug 2020 12:11:07 -0300) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Sat, 29 Aug 2020 12:11:07 -0300 > Cc: tim@tim-landscheidt.de, 30101@debbugs.gnu.org > > I took a shot at it. Please review. Thanks, I have a few comments. > * doc/lispref/customize.texi (Defining Customization Variables): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The name in parentheses should be the name of the node, not of the section. > +Re-evaluating a @code{defcustom} form of an already defined user > +option does not clear the reasonable values added by previous > +evaluations, or by calls to @code{custom-add-frequent-value}. This > +way, Lisp programs can add reasonable values for user options not yet > +defined. This doesn't emphasize the fact that you are talking about reevaluation after changing the option's values. Without that, this text doesn't drive the point home. Also, I'd suggest to drop the "reasonable" part, as it gets in the way of understanding the important parts by distracting the reader to think about what "reasonable" means in this context. > --- a/lisp/custom.el > +++ b/lisp/custom.el > @@ -578,9 +578,14 @@ custom-add-dependencies > (defun custom-add-option (symbol option) > "To the variable SYMBOL add OPTION. > > +Custom then presents OPTION to the user as a suggested member > +for the value of SYMBOL. > + > If SYMBOL's custom type is a hook, OPTION should be a hook member. > -If SYMBOL's custom type is an alist, OPTION specifies a symbol > -to offer to the user as a possible key in the alist. > +If SYMBOL's custom type is an alist, OPTION specifies a possible key > +in the alist. > +Similarly, if SYMBOL's custom type is a plist, OPTION specifies > +a possible name in the plist. > For other custom types, this has no effect." I don't think I understand what this tries to accomplish, or how it is relevant to the issue discussed here. From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 30101@debbugs.gnu.org, tim@tim-landscheidt.de Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.159871785814238 (code B ref 30101); Sat, 29 Aug 2020 16:18:02 +0000 Received: (at 30101) by debbugs.gnu.org; 29 Aug 2020 16:17:38 +0000 Received: from localhost ([127.0.0.1]:48948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC3Xu-0003hZ-AT for submit@debbugs.gnu.org; Sat, 29 Aug 2020 12:17:38 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:36860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC3Xs-0003hL-Mg for 30101@debbugs.gnu.org; Sat, 29 Aug 2020 12:17:37 -0400 Received: by mail-wr1-f41.google.com with SMTP id x7so1969312wro.3 for <30101@debbugs.gnu.org>; Sat, 29 Aug 2020 09:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SlcOO8DYG5iq9ozGasiR6autUunWUi0xD4naa3x1EOA=; b=sjRAg0qRd5J1wiAVV3ZRgozBAvSvCjDWc2M5pLAdo+1VAv/I6VUV+jTx2E8ou4BFIE eOBtExUNZNLGzDp5/0x//sVPLdyBWiWJV+q0MR0m95OpjCQS6MltDKrxSGI4lOZGtDmJ OM4jfKgOfS9hkowyYb4GMq7TW7Miynizhf2MKjHrardmQg94jo5+E5trIJMT29KUG1YH 0/aWtm94iHk9wPf+0vFqUl0fRqbPRj1KRoYcwVFxmRsVtYFyiOw2/cESoVuKwe90JMFQ FLPMEBwx1tvzHOesY7LldIenSZNB02QqDfxqNGsVvMx/qjjaLOa36ln18pB6Ol4G+Z6t eHeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SlcOO8DYG5iq9ozGasiR6autUunWUi0xD4naa3x1EOA=; b=GFGgbN+32xG0E3r7zguy3mk6iCESYrIks+vOBW2Xx498Ib+wTo+dGdyVzi7/G8q2Yx nRXtEjULqFWROCfZ0sFJjMEDRgDY9Lj1pV/U3uHR+Ly6EXClK+JDDB7wnpHPvi3Uk3kV 4ewu/6/MQi000ZNwUOMRkMIlnlHRK7TYNtziF3BTcdm6Z+IVadUZURBQv+Fu+GKcsHwH Oy3Pv2sT3hud2Czbmsi4Ukk+ZItxSHfIUGXrXs2aMwHKJJ1KBcDOAAISB7RG1QlavE75 SMDqq4CD3o+FQUqHb4hpTTqwPr4Zww9XFOBUfoVyOcJicMeCCfQ5pk40rZToQ4Axz6Wm CafQ== X-Gm-Message-State: AOAM531SMHPxNAD9AigllFSFKQYQhVDiVDAnwA2r+MKWIj1GN7oYftya 5qZ0IVqpsqmmFyW7vT5S8eMQ2hEosMP5pcNm+1w= X-Google-Smtp-Source: ABdhPJw8NtkkUovS9/CBu8slssta8Cy+fHBbi30to0Uminl6t6rErpOFxKXY1CkWKRWfDUJdgCdTG/sv9+xgCy1Hy9U= X-Received: by 2002:adf:e411:: with SMTP id g17mr4373154wrm.77.1598717850870; Sat, 29 Aug 2020 09:17:30 -0700 (PDT) MIME-Version: 1.0 References: <83y2lxxxwb.fsf@gnu.org> In-Reply-To: <83y2lxxxwb.fsf@gnu.org> From: Mauro Aranda Date: Sat, 29 Aug 2020 13:17:18 -0300 Message-ID: Content-Type: multipart/mixed; boundary="00000000000099027c05ae0681cd" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000099027c05ae0681cd Content-Type: multipart/alternative; boundary="00000000000099026f05ae0681cb" --00000000000099026f05ae0681cb Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> * doc/lispref/customize.texi (Defining Customization Variables): > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > The name in parentheses should be the name of the node, not of the > section. Right, sorry. >> +Re-evaluating a @code{defcustom} form of an already defined user >> +option does not clear the reasonable values added by previous >> +evaluations, or by calls to @code{custom-add-frequent-value}. This >> +way, Lisp programs can add reasonable values for user options not yet >> +defined. > > This doesn't emphasize the fact that you are talking about > reevaluation after changing the option's values. Without that, this > text doesn't drive the point home. Then perhaps it makes sense to split the paragraph, and talk about that when describing the :options keyword? I did that in this new patch. > Also, I'd suggest to drop the "reasonable" part, as it gets in the way > of understanding the important parts by distracting the reader to > think about what "reasonable" means in this context. Fair enough. Dropped it. >> --- a/lisp/custom.el >> +++ b/lisp/custom.el >> @@ -578,9 +578,14 @@ custom-add-dependencies >> (defun custom-add-option (symbol option) >> "To the variable SYMBOL add OPTION. >> >> +Custom then presents OPTION to the user as a suggested member >> +for the value of SYMBOL. >> + >> If SYMBOL's custom type is a hook, OPTION should be a hook member. >> -If SYMBOL's custom type is an alist, OPTION specifies a symbol >> -to offer to the user as a possible key in the alist. >> +If SYMBOL's custom type is an alist, OPTION specifies a possible key >> +in the alist. >> +Similarly, if SYMBOL's custom type is a plist, OPTION specifies >> +a possible name in the plist. >> For other custom types, this has no effect." > > I don't think I understand what this tries to accomplish, or how it is > relevant to the issue discussed here. The docstring didn't mention what was the effect if SYMBOL was a plist, so I thought I'd take the chance of improving the docstring for the function that also affects the suggested values. But maybe that can be left for another patch, so I dropped it in this new one. Thanks for reviewing, I hope this patch is better. --00000000000099026f05ae0681cb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> * doc/lispref/customize.texi (Defining= Customization Variables):
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^= ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> The name in parentheses should be = the name of the node, not of the
> section.

Right, sorry.
<= br>>> +Re-evaluating a @code{defcustom} form of an already defined us= er
>> +option does not clear the reasonable values added by previo= us
>> +evaluations, or by calls to @code{custom-add-frequent-value= }.=C2=A0 This
>> +way, Lisp programs can add reasonable values for= user options not yet
>> +defined.
>
> This doesn'= t emphasize the fact that you are talking about
> reevaluation after = changing the option's values.=C2=A0 Without that, this
> text doe= sn't drive the point home.

Then perhaps it makes sense to split = the paragraph, and talk about that
when describing the :options keyword?= =C2=A0 I did that in this new patch.

> Also, I'd suggest to d= rop the "reasonable" part, as it gets in the way
> of under= standing the important parts by distracting the reader to
> think abo= ut what "reasonable" means in this context.

Fair enou= gh.=C2=A0 Dropped it.

>> --- a/lisp/custom.el
= >> +++ b/lisp/custom.el
>> @@ -578,9 +578,14 @@ custom-add-d= ependencies
>> =C2=A0(defun custom-add-option (symbol option)
&= gt;> =C2=A0 =C2=A0"To the variable SYMBOL add OPTION.
>> = =C2=A0
>> +Custom then presents OPTION to the user as a suggested = member
>> +for the value of SYMBOL.
>> +
>> =C2= =A0If SYMBOL's custom type is a hook, OPTION should be a hook member.>> -If SYMBOL's custom type is an alist, OPTION specifies a sym= bol
>> -to offer to the user as a possible key in the alist.
&g= t;> +If SYMBOL's custom type is an alist, OPTION specifies a possibl= e key
>> +in the alist.
>> +Similarly, if SYMBOL's cu= stom type is a plist, OPTION specifies
>> +a possible name in the = plist.
>> =C2=A0For other custom types, this has no effect."<= br>>
> I don't think I understand what this tries to accomplis= h, or how it is
> relevant to the issue discussed here.

The do= cstring didn't mention what was the effect if SYMBOL was a plist,
so= I thought I'd take the chance of improving the docstring for the
fu= nction that also affects the suggested values.=C2=A0 But maybe that can be<= br>left for another patch, so I dropped it in this new one.

Thanks f= or reviewing, I hope this patch is better.
--00000000000099026f05ae0681cb-- --00000000000099027c05ae0681cd Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Improve-documentation-for-custom-options.patch" Content-Disposition: attachment; filename="0001-Improve-documentation-for-custom-options.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kefv97j00 RnJvbSAxNGMyMjYwMTdiMGU4NjhjZjY4YWVmOGY0ZDNiOWExZThjZDk0YWI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFNhdCwgMjkgQXVnIDIwMjAgMTM6MDc6MzIgLTAzMDAKU3ViamVjdDogW1BBVENIXSBJ bXByb3ZlIGRvY3VtZW50YXRpb24gZm9yIGN1c3RvbSA6b3B0aW9ucwoKKiBkb2MvbGlzcHJlZi9j dXN0b21pemUudGV4aSAoVmFyaWFibGUgRGVmaW5pdGlvbnMpOgpNZW50aW9uIHRoYXQgcmUtZXZh bHVhdGluZyBhIGRlZmN1c3RvbSBmb3JtIGRvZXNuJ3QgcmVzZXQgY3VzdG9tCm9wdGlvbnMuICAo QnVnIzMwMTAxKQotLS0KIGRvYy9saXNwcmVmL2N1c3RvbWl6ZS50ZXhpIHwgOCArKysrKysrKwog MSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVm L2N1c3RvbWl6ZS50ZXhpIGIvZG9jL2xpc3ByZWYvY3VzdG9taXplLnRleGkKaW5kZXggMmE3MjI3 NmJjNS4uZmNmYzBkMjk3ZSAxMDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvY3VzdG9taXplLnRleGkK KysrIGIvZG9jL2xpc3ByZWYvY3VzdG9taXplLnRleGkKQEAgLTM1OCw2ICszNTgsMTAgQEAgVmFy aWFibGUgRGVmaW5pdGlvbnMKIEBjb2Rle2hvb2t9LCBAY29kZXtwbGlzdH0gYW5kIEBjb2Rle2Fs aXN0fS4gIFNlZSB0aGUgZGVmaW5pdGlvbiBvZiB0aGUKIGluZGl2aWR1YWwgdHlwZXMgZm9yIGEg ZGVzY3JpcHRpb24gb2YgaG93IHRvIHVzZSBAY29kZXs6b3B0aW9uc30uCiAKK1JlLWV2YWx1YXRp bmcgYSBAY29kZXtkZWZjdXN0b219IGZvcm0gd2l0aCBhIGRpZmZlcmVudCA6b3B0aW9ucyB2YWx1 ZQorZG9lcyBub3QgY2xlYXIgdGhlIHZhbHVlcyBhZGRlZCBieSBwcmV2aW91cyBldmFsdWF0aW9u cywgb3IgYnkKK2NhbGxzIHRvIEBjb2Rle2N1c3RvbS1hZGQtZnJlcXVlbnQtdmFsdWV9IChzZWUg YmVsb3cpLgorCiBAaXRlbSA6c2V0IEB2YXJ7c2V0ZnVuY3Rpb259CiBAa2luZGV4IHNldEByeywg QGNvZGV7ZGVmY3VzdG9tfSBrZXl3b3JkfQogU3BlY2lmeSBAdmFye3NldGZ1bmN0aW9ufSBhcyB0 aGUgd2F5IHRvIGNoYW5nZSB0aGUgdmFsdWUgb2YgdGhpcwpAQCAtNDg1LDYgKzQ4OSwxMCBAQCBW YXJpYWJsZSBEZWZpbml0aW9ucwogCiBUaGUgcHJlY2lzZSBlZmZlY3Qgb2YgYWRkaW5nIGEgdmFs dWUgZGVwZW5kcyBvbiB0aGUgY3VzdG9taXphdGlvbiB0eXBlCiBvZiBAdmFye3N5bWJvbH0uCisK K1NpbmNlIGV2YWx1YXRpbmcgYSBAY29kZXtkZWZjdXN0b219IGZvcm0gZG9lcyBub3QgY2xlYXIg dmFsdWVzIGFkZGVkCitwcmV2aW91c2x5LCBMaXNwIHByb2dyYW1zIGNhbiB1c2UgdGhpcyBmdW5j dGlvbiB0byBhZGQgdmFsdWVzIGZvciB1c2VyCitvcHRpb25zIG5vdCB5ZXQgZGVmaW5lZC4KIEBl bmQgZGVmdW4KIAogSW50ZXJuYWxseSwgQGNvZGV7ZGVmY3VzdG9tfSB1c2VzIHRoZSBzeW1ib2wg cHJvcGVydHkKLS0gCjIuMjguMAoK --00000000000099027c05ae0681cd-- From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Sep 2020 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Eli Zaretskii , 30101@debbugs.gnu.org, tim@tim-landscheidt.de Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.159897244823817 (code B ref 30101); Tue, 01 Sep 2020 15:01:01 +0000 Received: (at 30101) by debbugs.gnu.org; 1 Sep 2020 15:00:48 +0000 Received: from localhost ([127.0.0.1]:56751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7mB-0006C3-LM for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:00:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7m8-0006Bn-OY for 30101@debbugs.gnu.org; Tue, 01 Sep 2020 11:00:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y2usxgoAx1szHX1rUdAozsIWviaEY5qDcYFFpKyj8JE=; b=BDs9jaIaoeLwvzwAv3kVIMS9H8 nt8D/wk0usBumU8UEhqWpyM8jlswLE7HoUzYf9ji/SzTa6Zd2/Awcd6BlGLAAs6k/TEAkYj2cXl85 EmvuQ11OiQuOVCbT3BSIOG9VKIdUqJNij3Rbxgkw2sVwe5slBh9U3eml2dnd3mpBgnos=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD7ly-0002j7-FE; Tue, 01 Sep 2020 17:00:37 +0200 From: Lars Ingebrigtsen References: <83y2lxxxwb.fsf@gnu.org> X-Now-Playing: DACM's =?UTF-8?Q?=5FSt=C3=A9r=C3=A9otypie=5F:?= "Outparis Kiss" Date: Tue, 01 Sep 2020 17:00:33 +0200 In-Reply-To: (Mauro Aranda's message of "Sat, 29 Aug 2020 13:17:18 -0300") Message-ID: <87blipczji.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > Thanks for reviewing, I hope this patch is better. Looks good to me -- I've now applied it to Emacs 28 (with a minor rewording for clarity). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Thanks for reviewing, I hope this patch is better. Looks good to me -- I've now applied it to Emacs 28 (with a minor rewording for clarity). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:00:52 2020 Received: (at control) by debbugs.gnu.org; 1 Sep 2020 15:00:52 +0000 Received: from localhost ([127.0.0.1]:56754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7mF-0006CL-U6 for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:00:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7mE-0006Bv-AR for control@debbugs.gnu.org; Tue, 01 Sep 2020 11:00:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9Gjv7ZnzO90MAwjpPKajbqbhcetbsqGxyx4mouV/Xew=; b=vFlUTgz69PgZJn3tzm87cArFEt T27Au+lyN30+pmUvwkFvgynCdOr9iSX5+CSIXvhKVIi6UO+Y9292HOtuJTai8V1NPtbqk61jZ81wL OlDqXEWRdkHffFYXtbN/fruk+FkSL9QWvIuDMK46fbAsDMsPknmVS58SdY4zhgYjb5aE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD7m6-0002jE-I4 for control@debbugs.gnu.org; Tue, 01 Sep 2020 17:00:44 +0200 Date: Tue, 01 Sep 2020 17:00:41 +0200 Message-Id: <87a6y9czja.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #30101 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 30101 fixed close 30101 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30101 fixed close 30101 28.1 quit From unknown Thu Aug 14 21:54:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30101: 25.3; defcustom does not clear old :options when reevaluated Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Sep 2020 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: 30101@debbugs.gnu.org Received: via spool by 30101-submit@debbugs.gnu.org id=B30101.15989918288669 (code B ref 30101); Tue, 01 Sep 2020 20:24:02 +0000 Received: (at 30101) by debbugs.gnu.org; 1 Sep 2020 20:23:48 +0000 Received: from localhost ([127.0.0.1]:57446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDCom-0002Fl-AL for submit@debbugs.gnu.org; Tue, 01 Sep 2020 16:23:48 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:46337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDCog-0002FQ-TN for 30101@debbugs.gnu.org; Tue, 01 Sep 2020 16:23:46 -0400 Received: by mail-wr1-f50.google.com with SMTP id o5so2889451wrn.13 for <30101@debbugs.gnu.org>; Tue, 01 Sep 2020 13:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5aij7Xr4uE5NFDHmCXFbWyDtXzBpRXTDPZPpVZ6/ChY=; b=TMqwKIoWWUvGN/sAt1hpDBRi9SeCQxrwLjunW0DhzfPIWJXJdEBJIn087AAc4YkJr3 /Sb7OlD263dm0Ujjgkt+zJjaZVQqBm6ZY6TF86poKGYq3pbCwjjqAJWdpto2PkeEL1Dp xqOGiH58wsWC2pY2COFeOvew5CvKg5MUCFwMFOlGvk2W++kedGQ4G5udx5kPwdxTuph7 m4gU/Zva1cyoM1xaPDB8H3HKkZPXruhg0Ahn/xUzlBYeJH8qZxHUEfMeIzzCcTi2NdM3 6XI+13yfp/KO8eskIQ1goBGZOG/L8MKER/dG2wrjW2cadBZlkSwf1dko2W7HOVzHazCB HJ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5aij7Xr4uE5NFDHmCXFbWyDtXzBpRXTDPZPpVZ6/ChY=; b=C5UzZKfFR7uR7plBpBsUVBnmQJIIKhvjxDRVaORs50v7vUTuq8rtwYVGO78IP2PjFV vwUcadGDmtH9lwHnlnNuybx1adb8eYIU0iacYNUXI1r/aUjzCIgRaKyhH20F42u8kSms 71Pal2IU1qyuIXm05/rHiBNGzTUHIrsHnXbkYWEpqhU3LC1vbWLgFRDkYjLNfs1/BRwh aObN7YWJPfb87IjTXgZ0WABe6RBlMrx79LFZ5lWe6misTh+Brdr5u3oZhUaLt1q+kXXN HCuDTSvG4ZwefMvEWbE1YzLeh8jjzIk//ZEBs5DDPwwaF0G8XJoUCG8UZuKHJ7biSCnu Adaw== X-Gm-Message-State: AOAM532hxL0Hy6bOMWph0EgfBJuEkbMH6k+kX25oj9lgjI3HdslshJKA e0yC6LuHEOu/n6n3NXe2aPhggODJmwxP3F9SwIo= X-Google-Smtp-Source: ABdhPJzbLKj2ir6OscuzuTADRGrkbC95D9TFpOI6v2xnuqwaUx4MA6vhg2JHn063W++FimdObsfz1h8095vkdURP6zA= X-Received: by 2002:adf:f290:: with SMTP id k16mr3900886wro.124.1598991817076; Tue, 01 Sep 2020 13:23:37 -0700 (PDT) MIME-Version: 1.0 References: <83y2lxxxwb.fsf@gnu.org> <87blipczji.fsf@gnus.org> In-Reply-To: <87blipczji.fsf@gnus.org> From: Mauro Aranda Date: Tue, 1 Sep 2020 17:23:25 -0300 Message-ID: Content-Type: multipart/alternative; boundary="00000000000041745b05ae464b48" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000041745b05ae464b48 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> Thanks for reviewing, I hope this patch is better. > > Looks good to me -- I've now applied it to Emacs 28 (with a minor > rewording for clarity). Thanks! --00000000000041745b05ae464b48 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> Thanks for reviewing, I hope this patch is better.
>
>= Looks good to me -- I've now applied it to Emacs 28 (with a minor
&= gt; rewording for clarity).

Thanks!
--00000000000041745b05ae464b48--